On Wed, 23 Aug 2017 18:25:05 +0200 Pierre Morel <pmo...@linux.vnet.ibm.com> wrote:
> On 23/08/2017 17:54, Cornelia Huck wrote: > > If we do not provide zpci, pci reconfiguration via sclp is not available > > either. I/O adapter configuration, however, should always be present. > > > > Rename the values that refer to I/O adapter configuration (instead of only > > pci) to make things clearer. > > > > Move length checking of the sccb for I/O adapter configuration into the > > common sclp code (out of the pci code). This also fixes an issue that > > the pci code would refer to a field in the sccb before checking whether > > it was actually long enough. > > > > Check for the adapter type in the sccb and return unrecognized adapter > > type if the guest tries to issue I/O adapter configure/deconfigure for > > a type other than pci or for pci if the zpci facility is not provided. > > > > Signed-off-by: Cornelia Huck <coh...@redhat.com> > > --- > > hw/s390x/s390-pci-bus.c | 14 ++------------ > > hw/s390x/s390-pci-bus.h | 8 -------- > > hw/s390x/s390-pci-stub.c | 2 ++ > > hw/s390x/sclp.c | 39 ++++++++++++++++++++++++++++++++++----- > > include/hw/s390x/sclp.h | 17 +++++++++++++---- > > 5 files changed, 51 insertions(+), 29 deletions(-) > LGTM and > I could also test the all serie on the hardware (sure is sure) :) > with VFIO and virtio PCI... so > > Reviewed-by: Pierre Morel <pmo...@linux.vnet.ibm.com> Cool, thanks!
