Re: [Qemu-devel] [PATCH v2 1/3] ipmi: Fix SEL get/set time commands

On 08/20/2017 11:46 PM, miny...@acm.org wrote: > From: Corey Minyard > > The minimum message size was on the wrong commands, for getting > the time it's zero and for setting the time it's 6. > > Signed-off-by: Corey Minyard Reviewed-by: Cédric Le Goater > --- > hw/ipmi/ipmi_bmc_sim.c | 4 ++-

Re: [Qemu-devel] [PATCH v2 3/3] ipmi: Add the platform event message command

On 08/20/2017 11:46 PM, miny...@acm.org wrote: > From: Corey Minyard > > This lets an event be added to the SEL as if a sensor had generated > it. The OpenIPMI driver uses it for storing panic event information. > > Signed-off-by: Corey Minyard As Philippe pointed it out, we could initialize

Re: [Qemu-devel] [PATCHv3 00/03] Replace the COLO comparing thread with IOThread

Hi~ Wang Yong. I have rebased this series to colo-for-qemu-2.10-2017-4-22 , But with this patch set COLO can't start normally, something I missed? Can you give me a github branch based on colo-for-qemu-2.10-2017-4-22

Re: [Qemu-devel] [PATCH v2] hw/ppc/spapr: Fix segfault when instantiating a 'pc-dimm' without 'memdev'

Hello Thomas, > > QEMU currently crashes when trying to use a 'pc-dimm' on the pseries > machine without specifying its 'memdev' property. This happens because > pc_dimm_get_memory_region() does not check whether the 'memdev' property > has properly been set by the user. Looking closer at this f

[Qemu-devel] [RFC 2/6] monitor: allow monitor to create thread to poll

Firstly, introduce Monitor.use_thread, and set it for monitors that are using non-mux typed backend chardev. We only do this for monitors, so mux-typed chardevs are not suitable (when it connects to, e.g., serials and the monitor together). When use_thread is set, we create standalone thread to p

[Qemu-devel] [RFC 3/6] QAPI: new QMP command option "without-bql"

Introducing this new parameter for QMP commands in general to mark out when the command does not need BQL. Normally QMP command executions are done with the protection of BQL in QEMU. However the truth is that not all the QMP commands require the BQL. This new parameter provides a way to allow Q

[Qemu-devel] [RFC 4/6] migration: qmp: migrate_incoming don't need BQL

Let "migrate-incoming" command be run without BQL. Then even if any thread hanged with BQL held, we can still run this command. Signed-off-by: Peter Xu --- qapi-schema.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qapi-schema.json b/qapi-schema.json index 802ea53..b

[Qemu-devel] [RFC 6/6] migration: hmp: migrate_incoming don't need BQL

Allow this command to run without BQL held. Signed-off-by: Peter Xu --- hmp-commands.hx | 1 + 1 file changed, 1 insertion(+) diff --git a/hmp-commands.hx b/hmp-commands.hx index 1941e19..e8d8812 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -968,6 +968,7 @@ ETEXI .params =

[Qemu-devel] [RFC 5/6] hmp: support "without_bql"

Introducing new option "without_bql" for HMP commands. It works just like QMP "without-bql", but for HMP commands. Signed-off-by: Peter Xu --- monitor.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/monitor.c b/monitor.c index 18504ef..475a3a6 100644 --- a/monitor.c +++ b/moni

Re: [Qemu-devel] [RFC 00/29] Migration: postcopy failure recovery

On Thu, Aug 03, 2017 at 04:57:54PM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > As we all know that postcopy migration has a potential risk to lost > > the VM if the network is broken during the migration. This series > > tries to solve the problem by allowing th

[Qemu-devel] [RFC 0/6] monitor: allow per-monitor thread

This is an extended work for migration postcopy recovery. This series is tested with the following series to make sure it solves the monitor hang problem that we have encountered for postcopy recovery: [RFC 00/29] Migration: postcopy failure recovery [RFC 0/6] migration: re-use migrate_incomin

[Qemu-devel] [RFC 1/6] monitor: move skip_flush into monitor_data_init

It's part of the data init. Collect it. Signed-off-by: Peter Xu --- monitor.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/monitor.c b/monitor.c index e0f8801..7c90df7 100644 --- a/monitor.c +++ b/monitor.c @@ -568,13 +568,14 @@ static void monitor_qapi_event_init

[Qemu-devel] [Bug 1054180] Re: DNS activity in slirp (user networking) mode quickly depletes file descriptors and crashes qemu

Triaging old bug tickets ... can you still reproduce this problem with the latest version of QEMU (currently v2.9 or a release candidate of 2.10)? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subsc

[Qemu-devel] [Bug 1054558] Re: 1366x768 resolution missing

** Changed in: qemu Importance: Undecided => Wishlist -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1054558 Title: 1366x768 resolution missing Status in QEMU: New Status in Debian: Confirme

Re: [Qemu-devel] [PATCH v2] hw/ppc/spapr: Fix segfault when instantiating a 'pc-dimm' without 'memdev'

Hi, On 21.08.2017 09:36, Pankaj Gupta wrote: > > Hello Thomas, >> >> QEMU currently crashes when trying to use a 'pc-dimm' on the pseries >> machine without specifying its 'memdev' property. This happens because >> pc_dimm_get_memory_region() does not check whether the 'memdev' property >> has p

[Qemu-devel] [Bug 1054180] Re: DNS activity in slirp (user networking) mode quickly depletes file descriptors and crashes qemu

Also could you please provide the exact command line that you use to start QEMU? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1054180 Title: DNS activity in slirp (user networking) mode quickly de

Re: [Qemu-devel] [PATCH v2] hw/ppc/spapr: Fix segfault when instantiating a 'pc-dimm' without 'memdev'

On Mon, Aug 21, 2017 at 08:30:29AM +0200, Thomas Huth wrote: > QEMU currently crashes when trying to use a 'pc-dimm' on the pseries > machine without specifying its 'memdev' property. This happens because > pc_dimm_get_memory_region() does not check whether the 'memdev' property > has properly been

[Qemu-devel] 答复: Re: [PATCHv3 00/03] Replace the COLO comparing thread with IOThread

>Hi~ Wang Yong. >>I have rebased this series to colo-for-qemu-2.10-2017-4-22 >>>,>>But >>with this patch set COLO can't start normally, something I missed?>>Can you >>give me a github branch based on colo-for-qemu-2.10-2017-4-22

Re: [Qemu-devel] [PATCH 1/2] target-i386: cpu: convert plus/minus properties to global properties

On Fri, 18 Aug 2017 14:40:29 -0300 Eduardo Habkost wrote: > On Thu, Aug 17, 2017 at 04:07:56PM +0200, Igor Mammedov wrote: > > Since > > (commit d4a606b3 i386: Don't override -cpu options on -cpu host/max) > > it became possible to delete hack where it was necessary to > > postpone applying plus

Re: [Qemu-devel] [PATCH v2] hw/ppc/spapr: Fix segfault when instantiating a 'pc-dimm' without 'memdev'

On Mon, 21 Aug 2017 17:55:20 +1000 David Gibson wrote: > On Mon, Aug 21, 2017 at 08:30:29AM +0200, Thomas Huth wrote: > > QEMU currently crashes when trying to use a 'pc-dimm' on the pseries > > machine without specifying its 'memdev' property. This happens because > > pc_dimm_get_memory_region()

Re: [Qemu-devel] [PATCH v2] hw/ppc/spapr: Fix segfault when instantiating a 'pc-dimm' without 'memdev'

On Mon, Aug 21, 2017 at 10:45:02AM +0200, Igor Mammedov wrote: > On Mon, 21 Aug 2017 17:55:20 +1000 > David Gibson wrote: > > > On Mon, Aug 21, 2017 at 08:30:29AM +0200, Thomas Huth wrote: > > > QEMU currently crashes when trying to use a 'pc-dimm' on the pseries > > > machine without specifying

[Qemu-devel] [PATCH V4 3/3] net/colo-compare.c: Fix comments and scheme

Signed-off-by: Zhang Chen --- net/colo-compare.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/net/colo-compare.c b/net/colo-compare.c index a8ccac7..e8af8bb 100644 --- a/net/colo-compare.c +++ b/net/colo-compare.c @@ -44,7 +44,7 @@ + CompareState ++

[Qemu-devel] [PATCH V4 2/3] net/colo-compare.c: Adjust net queue pop order for performance

The packet_enqueue() use g_queue_push_tail() to enqueue net packet, so it is more efficent way use g_queue_pop_head() to get packet for compare. That will improve the success rate of comparison. In my test the performance of ftp put 1000M file will increase 10% Signed-off-by: Zhang Chen --- net/

[Qemu-devel] [PATCH V4 1/3] net/colo-compare.c: Optimize unpredictable tcp options comparison

When network is busy, some tcp options(like sack) will unpredictable occur in primary side or secondary side. it will make packet size not same, but the two packet's payload is identical. colo just care about packet payload, so we skip the option field. Signed-off-by: Zhang Chen --- net/colo-com

[Qemu-devel] [PATCH V4 0/3] Optimize COLO-compare performance

In this serise, we do a lot of job to optimize COLO net performance. Mainly focus on TCP protocol. V4: - Remove the old patch1. V3: - Rebase on upstream. - Remove origin p2. - Move the "checkpoint_time_ms" to CompareState, in order to aviod multi colo-compare instance conflict. - Add "TOD

Re: [Qemu-devel] [PATCH v3] hw/acpi-build: Fix SRAT memory building when there is no memory in node0

On Sun, 20 Aug 2017 19:52:11 +0800 Dou Liyang wrote: > Hi Eduardo, > > At 08/19/2017 12:48 AM, Eduardo Habkost wrote: > > On Thu, Aug 17, 2017 at 01:58:40PM +0800, Dou Liyang wrote: > >> Hi Igor, > >> > >> I tested this patch with following guests: > >> > >> 1. RHEL 6.5 with Linux 2.6.32 > >>

Re: [Qemu-devel] [PATCH 2/8] mips: introduce internal.h and cleanup cpu.h

On Fri, 18 Aug 2017 17:03:03 -0300 Philippe Mathieu-Daudé wrote: > Hi Igor, > > On 08/17/2017 12:06 PM, Philippe Mathieu-Daudé wrote: > >>> no logical change, only code movement (and fix a comment typo). > > > >> while at that fix checkpatch errors or > >> first fix checkpatch noted issues

Re: [Qemu-devel] [PATCH 0/8] QOMify MIPS cpu

On Fri, 18 Aug 2017 17:08:29 -0300 Philippe Mathieu-Daudé wrote: > On 08/17/2017 12:22 PM, Igor Mammedov wrote: > > On Thu, 17 Aug 2017 01:30:54 -0300 > > Philippe Mathieu-Daudé wrote: > [...] > >> Also I couldn't test it with KVM. > > Tested in TCG mode (boots debian mips/mips64 kernel with

Re: [Qemu-devel] [RFC 0/6] monitor: allow per-monitor thread

On Mon, 08/21 15:44, Peter Xu wrote: > This is an extended work for migration postcopy recovery. This series > is tested with the following series to make sure it solves the monitor > hang problem that we have encountered for postcopy recovery: > > [RFC 00/29] Migration: postcopy failure recover

Re: [Qemu-devel] [PATCH v3 0/5] target-ppc/spapr: Add FWNMI support in QEMU for PowerKVM guests

On Thursday 17 August 2017 09:05 AM, Sam Bobroff wrote: > On Wed, Aug 16, 2017 at 02:41:59PM +0530, Aravinda Prasad wrote: >> This series of patches adds support for FWNMI in PowerKVM guests. >> >> Memory error such as bit flips that cannot be corrected >> by hardware is passed on to the kernel f

Re: [Qemu-devel] [PATCH v6 7/7] qemu.py: include debug information on launch error

Amador Pahim writes: > On Fri, Aug 18, 2017 at 4:01 PM, Markus Armbruster wrote: >> Amador Pahim writes: >> >>> On Tue, Aug 15, 2017 at 10:57 AM, Markus Armbruster >>> wrote: Amador Pahim writes: > When launching a VM, if an exception happens and the VM is not > initiated,

[Qemu-devel] [PATCH v4 03/10] s390x/pci: add stubs

Some non-pci code calls into zpci code. Provide some stubs for builds without pci. Reviewed-by: Thomas Huth Signed-off-by: Cornelia Huck --- hw/s390x/Makefile.objs | 3 +- hw/s390x/s390-pci-stub.c | 74 2 files changed, 76 insertions(+), 1 del

[Qemu-devel] [PATCH v4 04/10] s390x: chsc nt2 events are pci-only

The nt2 event class is pci-only - don't look for events if pci is not in the active cpu model. Signed-off-by: Cornelia Huck --- hw/s390x/s390-pci-bus.c | 4 ++-- hw/s390x/s390-pci-bus.h | 4 ++-- hw/s390x/s390-pci-stub.c | 4 ++-- target/s390x/ioinst.c| 16 4 files chan

[Qemu-devel] [PATCH v4 06/10] s390x/ccw: create s390 phb conditionally

Don't create the s390 pci host bridge if we do not provide the zpci facility. Reviewed-by: Thomas Huth Acked-by: Christian Borntraeger Signed-off-by: Cornelia Huck --- hw/s390x/s390-virtio-ccw.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/hw/s390x/s390-vi

[Qemu-devel] [PATCH v4 08/10] s390x/pci: fence off instructions for non-pci

If a guest running on a machine without zpci issues a pci instruction, throw them an exception. Reviewed-by: Thomas Huth Signed-off-by: Cornelia Huck --- target/s390x/kvm.c | 54 +- 1 file changed, 41 insertions(+), 13 deletions(-) diff --git

[Qemu-devel] [PATCH v4 07/10] s390x/sclp: properly guard pci-specific functions

If we do not provide zpci, pci reconfiguration via sclp is not available either. Don't indicate it in the sclp facilities and return an invalid command if the guest tries to issue pci configure/deconfigure. Reviewed-by: Thomas Huth Signed-off-by: Cornelia Huck --- hw/s390x/sclp.c | 19 +

[Qemu-devel] [PATCH v4 05/10] s390x/pci: do not advertise pci on non-pci builds

Only set the zpci feature bit on builds that actually support pci. Reviewed-by: David Hildenbrand Signed-off-by: Cornelia Huck --- target/s390x/kvm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c index c4c5791d27..bc62bba5b7 10064

[Qemu-devel] [PATCH v4 10/10] s390x: refine pci dependencies

VIRTIO_PCI should properly depend on CONFIG_PCI. With this change, we can switch off pci for s390x by removing 'CONFIG_PCI=y' from the default config. Reviewed-by: Thomas Huth Reviewed-by: David Hildenbrand Signed-off-by: Cornelia Huck --- default-configs/s390x-softmmu.mak | 2 +- 1 file chang

[Qemu-devel] [PATCH v4 09/10] s390x/kvm: msi route fixup for non-pci

If we don't provide pci, we cannot have a pci device for which we have to translate to adapter routes: just return -ENODEV. Signed-off-by: Cornelia Huck --- target/s390x/kvm.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c index 9de165d8b1..d8db

[Qemu-devel] [PATCH v4 00/10] zpci detangling

Just some minor changes from the last one. If nobody complains, I'll queue to s390-next. I'd be happy about some acks/r-bs for patches that don't have any yet, though. v3->v4: - add "9pfs: fix dependencies" - in "kvm: remove hard dependency on pci", do s/assert/g_assert/ and add return statemen

[Qemu-devel] [PATCH v4 02/10] kvm: remove hard dependency on pci

The msi routing code in kvm calls some pci functions: provide some stubs to enable builds without pci. Also, to make this more obvious, guard them via a pci_available boolean (which also can be reused in other places). Fixes: e1d4fb2de ("kvm-irqchip: x86: add msi route notify fn") Fixes: 767a554a

[Qemu-devel] [Bug 1712027] [NEW] qemu: Cryptography adding encrypted disk with luks format failed

Public bug reported: I'm using libvirt to attach luks encrypted disk to a running VM. The qemu-monitor-command like the following: {"execute":"object-add","arguments":{"qom-type":"secret","id":"virtio- disk11-luks- secret0","props":{"data":"El7jOYLCZwrij2Mue0q2tA==","keyid":"masterKey0","iv":"J2

Re: [Qemu-devel] [PATCH for-2.11 v2 4/5] qmp-shell: Accept QMP command as argument

Eduardo Habkost writes: > On Wed, Aug 16, 2017 at 08:25:41AM +0200, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > On Tue, Aug 15, 2017 at 12:03:53PM +0200, Markus Armbruster wrote: >> >> Eduardo Habkost writes: >> >> >> >> Suggest to insert here: >> >> >> >> If additional arg

[Qemu-devel] [PATCH v4 01/10] 9pfs: fix dependencies

Nothing in fsdev/ or hw/9pfs/ depends on pci; it should rather depend on CONFIG_VIRTFS and CONFIG_VIRTIO/CONFIG_XEN only. Acked-by: Greg Kurz Reviewed-by: Thomas Huth Signed-off-by: Cornelia Huck --- fsdev/Makefile.objs | 9 +++-- hw/9pfs/Makefile.objs | 2 +- hw/Makefile.objs | 2 +

Re: [Qemu-devel] [RFC PATCH] osdep.h: Prohibit disabling assert() in supported builds

Eric Blake writes: > We already have several files that knowingly require assert() > to work. While we do NOT want to encourage the use of > 'assert(side-effects)' (that is a bad practice that prevents > copy-and-paste of code to other projects that CAN disable > assertions; plus it costs unnece

[Qemu-devel] [PATCH v6 0/6] add throttle block driver filter

This series adds a throttle block driver filter. Currently throttling is done at the BlockBackend level. Using block driver interfaces we can move the throttling to any point in the BDS graph using a throttle node which uses the existing throttling code. This allows for potentially more complex con

[Qemu-devel] [PATCH v6 2/6] block: add aio_context field in ThrottleGroupMember

timer_cb() needs to know about the current Aio context of the throttle request that is woken up. In order to make ThrottleGroupMember backend agnostic, this information is stored in an aio_context field instead of accessing it from BlockBackend. Reviewed-by: Alberto Garcia Reviewed-by: Stefan Haj

[Qemu-devel] [PATCH v6 6/6] qemu-iotests: add 184 for throttle filter driver

Signed-off-by: Manos Pitsidianakis --- tests/qemu-iotests/184 | 244 tests/qemu-iotests/184.out | 339 + tests/qemu-iotests/group | 1 + 3 files changed, 584 insertions(+) create mode 100755 tests/qemu-iotests/1

[Qemu-devel] [PATCH v6 5/6] block: add throttle block filter driver

block/throttle.c uses existing I/O throttle infrastructure inside a block filter driver. I/O operations are intercepted in the filter's read/write coroutines, and referred to block/throttle-groups.c The driver can be used with the syntax -drive driver=throttle,file.filename=foo.qcow2, \ li

[Qemu-devel] [PATCH v6 4/6] block: convert ThrottleGroup to object with QOM

ThrottleGroup is converted to an object. This will allow the future throttle block filter drive easy creation and configuration of throttle groups in QMP and cli. A new QAPI struct, ThrottleLimits, is introduced to provide a shared struct for all throttle configuration needs in QMP. ThrottleGroup

Re: [Qemu-devel] [PATCH v2] hw/ppc/spapr: Fix segfault when instantiating a 'pc-dimm' without 'memdev'

> > > > Hello Thomas, > >> > >> QEMU currently crashes when trying to use a 'pc-dimm' on the pseries > >> machine without specifying its 'memdev' property. This happens because > >> pc_dimm_get_memory_region() does not check whether the 'memdev' property > >> has properly been set by the user. Lo

[Qemu-devel] [PATCH v6 1/6] block: move ThrottleGroup membership to ThrottleGroupMember

This commit eliminates the 1:1 relationship between BlockBackend and throttle group state. Users will be able to create multiple throttle nodes, each with its own throttle group state, in the future. The throttle group state cannot be per-BlockBackend anymore, it must be per-throttle node. This i

[Qemu-devel] [PATCH v6 3/6] block: tidy ThrottleGroupMember initializations

Move the CoMutex and CoQueue inits inside throttle_group_register_tgm() which is called whenever a ThrottleGroupMember is initialized. There's no need for them to be separate. Reviewed-by: Alberto Garcia Reviewed-by: Stefan Hajnoczi Signed-off-by: Manos Pitsidianakis --- block/block-backend.c

Re: [Qemu-devel] [PATCH v3 1/5] ppc: spapr: Register and handle HCALL to receive updated RTAS region

On Thursday 17 August 2017 07:04 AM, David Gibson wrote: > On Wed, Aug 16, 2017 at 02:42:13PM +0530, Aravinda Prasad wrote: >> Receive updates from SLOF about the updated rtas-base. >> A separate patch for SLOF [1] adds functionality to invoke >> a private HCALL whenever OS issues instantiate-rta

Re: [Qemu-devel] [PATCH v3 for-2.11 07/18] s390x: drop inclusion of sysemu/kvm.h from some files

On Fri, 18 Aug 2017 19:28:34 +0200 David Hildenbrand wrote: > On 18.08.2017 18:08, Thomas Huth wrote: > > On 18.08.2017 13:43, David Hildenbrand wrote: > >> s390-stattrib.c needs definition of TARGET_PAGE_SIZE, solve it via cpu.h. > > > > Why not simply #include "exec/cpu-all.h" ? If cpu.h i

Re: [Qemu-devel] [RFC 0/6] monitor: allow per-monitor thread

On Mon, Aug 21, 2017 at 04:58:51PM +0800, Fam Zheng wrote: > On Mon, 08/21 15:44, Peter Xu wrote: > > This is an extended work for migration postcopy recovery. This series > > is tested with the following series to make sure it solves the monitor > > hang problem that we have encountered for postco

Re: [Qemu-devel] [RFC PATCH] osdep.h: Prohibit disabling assert() in supported builds

On 21 August 2017 at 10:31, Markus Armbruster wrote: > I'm fine with project-wide, but does it have to be a hard error? Can we > make it a warning? Same effect by default, but it lets people > experiment more easily with --disable-werror. It won't be the same effect by default for our releases,

Re: [Qemu-devel] [PATCH v3 for-2.11 08/18] target/s390x: move gtod_*() declarations to s390-virtio.h

On Fri, 18 Aug 2017 13:43:43 +0200 David Hildenbrand wrote: > Signed-off-by: David Hildenbrand > --- > hw/s390x/s390-virtio.h | 2 ++ > target/s390x/cpu.h | 3 --- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/hw/s390x/s390-virtio.h b/hw/s390x/s390-virtio.h > index f2

Re: [Qemu-devel] [PULL 7/7] nbd-client: Fix regression when server sends garbage

15.08.2017 18:09, Eric Blake wrote: When we switched NBD to use coroutines for qemu 2.9 (in particular, commit a12a712a), we introduced a regression: if a server sends us garbage (such as a corrupted magic number), we quit the read loop but do not stop sending further queued commands, resulting i

Re: [Qemu-devel] [PULL 7/7] nbd-client: Fix regression when server sends garbage

21.08.2017 13:11, Vladimir Sementsov-Ogievskiy wrote: 15.08.2017 18:09, Eric Blake wrote: When we switched NBD to use coroutines for qemu 2.9 (in particular, commit a12a712a), we introduced a regression: if a server sends us garbage (such as a corrupted magic number), we quit the read loop but d

Re: [Qemu-devel] [RFC 0/6] monitor: allow per-monitor thread

* Peter Xu (pet...@redhat.com) wrote: > On Mon, Aug 21, 2017 at 04:58:51PM +0800, Fam Zheng wrote: > > On Mon, 08/21 15:44, Peter Xu wrote: > > > This is an extended work for migration postcopy recovery. This series > > > is tested with the following series to make sure it solves the monitor > > >

[Qemu-devel] [PATCH] hw/ppc/spapr: Fix segfault when instantiating a 'pc-dimm' without 'memdev'

From: Thomas Huth QEMU currently crashes when trying to use a 'pc-dimm' on the pseries machine without specifying its 'memdev' property. This happens because pc_dimm_get_memory_region() does not check whether the 'memdev' property has properly been set by the user. Looking closer at this function

Re: [Qemu-devel] [PATCH 02/15] ppc4xx: Make MAL emulation more generic

On Sun, Aug 20, 2017 at 07:23:05PM +0200, BALATON Zoltan wrote: > Allow MAL with more RX and TX channels as found in newer versions. > > Signed-off-by: BALATON Zoltan > Reviewed-by: David Gibson I've applied patches 1 & 2 to my ppc-for-2.11 tree. > --- > hw/ppc/ppc405_uc.c | 2 +- > hw

Re: [Qemu-devel] [PATCH v3 5/5] ppc: spapr: Enable FWNMI capability

On Thursday 17 August 2017 07:29 AM, David Gibson wrote: > On Wed, Aug 16, 2017 at 02:42:48PM +0530, Aravinda Prasad wrote: >> Enable the KVM capability KVM_CAP_PPC_FWNMI so that >> the KVM causes guest exit with NMI as exit reason >> when it encounters a machine check exception on the >> address

[Qemu-devel] Any release-critical issues for 2.10 ?

Last call -- are there any release critical issues for 2.10? If not then I'll tag the current rc3 as the final release tomorrow, so please reply here to let me know if there's anything we should be considering as needing an rc4. thanks -- PMM

[Qemu-devel] [PATCH v3 2/2] virtio-iommu: vfio integration with virtio-iommu

This RFC patch allows virtio-iommu protection for PCI device-passthrough. MSI region is mapped by current version of virtio-iommu driver. This uses VFIO extension of map/unmap notification when an area of memory is mappedi/unmapped in emulated iommu device. This series is tested with 2 PCI device

[Qemu-devel] [PATCH v3 0/2] virtio-iommu: VFIO integration

This V3 version is mainly about rebasing on v3 version on Virtio-iommu device framework from Eric Augur and addresing review comments. This patch series allows PCI pass-through using virtio-iommu. This series is based on: - virtio-iommu specification written by Jean-Philippe Brucker [RFC 0/

Re: [Qemu-devel] [PATCH v3 for-2.11 07/18] s390x: drop inclusion of sysemu/kvm.h from some files

On 21.08.2017 11:52, Cornelia Huck wrote: > On Fri, 18 Aug 2017 19:28:34 +0200 > David Hildenbrand wrote: > >> On 18.08.2017 18:08, Thomas Huth wrote: >>> On 18.08.2017 13:43, David Hildenbrand wrote: s390-stattrib.c needs definition of TARGET_PAGE_SIZE, solve it via cpu.h. >>> >>> Why n

Re: [Qemu-devel] nVidia emulation in QEMU?

On Thu, 2017-08-17 at 23:11 -0300, Philippe Mathieu-Daudé wrote: > Hi, > > On 08/17/2017 10:01 PM, Darius Goad wrote: > > Hello. I'm Melissa, a trans woman who is the main developer of the > > nVidia > > emulation code for 86Box. I'm interested in porting this code over > > to QEMU > > as QEMU has

[Qemu-devel] [PATCH v3 1/2] target/arm/kvm: Translate the MSI doorbell in kvm_arch_fixup_msi_route

Translate msi address if device is behind virtio-iommu. This logic is similar to vSMMUv3/Intel iommu emulation. This RFC patch does not handle the case where both vsmmuv3 and virtio-iommu are available. Signed-off-by: Eric Auger Signed-off-by: Bharat Bhushan --- v2->v3: - Rebased to on top of

Re: [Qemu-devel] [RFC v2 PATCH 2/2] virtio-iommu: vfio integration with virtio-iommu

Hi Eric, > -Original Message- > From: Auger Eric [mailto:eric.au...@redhat.com] > Sent: Thursday, August 17, 2017 9:03 PM > To: Bharat Bhushan ; > eric.auger@gmail.com; peter.mayd...@linaro.org; > alex.william...@redhat.com; m...@redhat.com; qemu-...@nongnu.org; > qemu-devel@nongnu.org

Re: [Qemu-devel] [PATCH for-2.11 01/27] sparc: convert cpu models to SPARC cpu subclasses

On Fri, 18 Aug 2017 16:00:37 -0300 Philippe Mathieu-Daudé wrote: > Hi Igor, > > On 08/18/2017 07:08 AM, Igor Mammedov wrote: > > QOMfy cpu models handling introducing propper cpu types > > for each cpu model. > > > > Signed-off-by: Igor Mammedov > > --- > > with this and conversion of features

Re: [Qemu-devel] [PATCH for-2.11 03/27] sparc: convert cpu features to qdev properties

On Fri, 18 Aug 2017 15:24:04 -0300 Eduardo Habkost wrote: > On Fri, Aug 18, 2017 at 12:08:35PM +0200, Igor Mammedov wrote: > > SPARC is the last target that uses legacy way of parsing > > and initializing cpu features, drop legacy approach and > > convert features to properties so that SPARC coul

Re: [Qemu-devel] [PATCH v3 for-2.11 08/18] target/s390x: move gtod_*() declarations to s390-virtio.h

On 21.08.2017 12:08, Cornelia Huck wrote: > On Fri, 18 Aug 2017 13:43:43 +0200 > David Hildenbrand wrote: > >> Signed-off-by: David Hildenbrand >> --- >> hw/s390x/s390-virtio.h | 2 ++ >> target/s390x/cpu.h | 3 --- >> 2 files changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/hw/s

Re: [Qemu-devel] [PATCH for-2.11 06/27] x86: extract legacy cpu features format parser

On Fri, 18 Aug 2017 15:08:48 -0300 Eduardo Habkost wrote: > On Fri, Aug 18, 2017 at 12:08:38PM +0200, Igor Mammedov wrote: > > Move cpu_model +-feat parsing into a separate file so that it > > could be reused later for parsing similar format of sparc target > > > > Signed-off-by: Igor Mammedov

[Qemu-devel] [PATCH 3/3] Add manpage for QEMU Backup Tool

qemu-backup will be a command-line tool for performing full and incremental disk backups on running VMs. It is intended as a reference implementation for management stack and backup developers to see QEMU's backup features in action. The following commit is an initial implementation of manpage list

[Qemu-devel] [PATCH 0/3] QEMU Backup Tool

This patch series is intended to introduce QEMU Backup tool. qemu-backup will be a command-line tool for performing full and incremental disk backups on running VMs. It is intended as a reference implementation for management stack and backup developers to see QEMU's backup features in action. This

Re: [Qemu-devel] [PATCH for-2.11 08/27] sparc: replace cpu_sparc_init() with cpu_generic_init()

On Fri, 18 Aug 2017 16:57:20 -0300 Philippe Mathieu-Daudé wrote: > I succeed booting a SPARC image once applying 1 to 8 (this commit), > so not being able to boot the image previously is probably due to patch > order, which mean current order is not bisect-able. I repeated patch by patch (1-8)

[Qemu-devel] [PATCH 2/3] Test for full Backup

This patch is the test for full backup implementation in Backup tool. The test employs two basic substests: 1) Backing up an empty guest and comparing it with base image. 2) Writing a pattern to the guest, creating backup and comparing with the base image. Signed-off-by: Ishani Chugh --- test

Re: [Qemu-devel] [PATCH v3 2/3] scsi: Enhance scsi_sense_to_errno

On Fri, 08/18 16:36, Paolo Bonzini wrote: > On 18/08/2017 16:15, Fam Zheng wrote: > > Two changes: > > > > 1) Look at asc/ascq for NOT_READY and DATA_PROTECT; > > 2) Translate SPACE_ALLOC_FAILED as ENOSPC; > > > > Signed-off-by: Fam Zheng > > --- > > util/scsi.c | 7 +++ > > 1 file changed,

[Qemu-devel] [PATCH 1/3] backup: QEMU Backup Tool

qemu-backup will be a command-line tool for performing full and incremental disk backups on running VMs. It is intended as a reference implementation for management stack and backup developers to see QEMU's backup features in action. The tool writes details of guest in a configuration file and the

Re: [Qemu-devel] [PATCH v3 for-2.11 08/18] target/s390x: move gtod_*() declarations to s390-virtio.h

On Mon, 21 Aug 2017 13:05:12 +0200 David Hildenbrand wrote: > On 21.08.2017 12:08, Cornelia Huck wrote: > > In s390-virtio.c, the only thing used outside of s390-virtio-ccw.c is > > s390_cpuaddr2state(), and the only place that uses it for something > > other than getting a dummy cpu is the kvm

Re: [Qemu-devel] [PATCH for-2.10] numa: Move numa_legacy_auto_assign_ram to pc-i440fx-2.9

On Fri, 18 Aug 2017 16:15:34 -0300 Eduardo Habkost wrote: > On Fri, Aug 18, 2017 at 04:09:43PM -0300, Eduardo Habkost wrote: > > The 'm->numa_auto_assign_ram = numa_legacy_auto_assign_ram;' line > > was supposed to be in pc_i440fx_2_9_machine_options() (see commit > > 3bfe5716 "numa: equally dist

Re: [Qemu-devel] [PATCH v3] hw/acpi-build: Fix SRAT memory building when there is no memory in node0

Hi, Igor [...] Ok, I will do it right now. see commit 6b9c1dd2c for example of adding test case, currently test has base SRAT tables that is reused by all tests. When you create testcase that produces different SRAT table, 'make check' will print warnings that ables do not match you can add "

Re: [Qemu-devel] [PATCH v3 2/3] scsi: Enhance scsi_sense_to_errno

On 21/08/2017 13:11, Fam Zheng wrote: > On Fri, 08/18 16:36, Paolo Bonzini wrote: >> On 18/08/2017 16:15, Fam Zheng wrote: >>> Two changes: >>> >>> 1) Look at asc/ascq for NOT_READY and DATA_PROTECT; >>> 2) Translate SPACE_ALLOC_FAILED as ENOSPC; >>> >>> Signed-off-by: Fam Zheng >>> --- >>> util/

Re: [Qemu-devel] [PATCH v4 07/10] s390x/sclp: properly guard pci-specific functions

On 08/21/2017 11:16 AM, Cornelia Huck wrote: > If we do not provide zpci, pci reconfiguration via sclp is not available > either. Don't indicate it in the sclp facilities and return an invalid > command if the guest tries to issue pci configure/deconfigure. > > Reviewed-by: Thomas Huth > Signed

Re: [Qemu-devel] [RFC v4 12/13] usb: enumerate_slots implementation

Hi, -ENOCONTEXT What is the use case? > +QTAILQ_FOREACH(port, l, next) { > +DeviceSlotInfo *slot = make_slot(BUS(bus)); > +/* > + * TODO: should the "bus" option be included, or is > + * "port" enough to identify the USB bus + port? > + */ Yes, bus

Re: [Qemu-devel] [PATCH v3] target-i386/cpu: Add new EPYC CPU model

Hi Paolo, On 8/17/17 1:37 PM, Brijesh Singh wrote: > On 08/17/2017 11:45 AM, Paolo Bonzini wrote: >> On 15/08/2017 19:00, Brijesh Singh wrote: >>> >>> The following features bits have been added/removed compare to >>> Opteron_G5 >>> >>> Added: monitor, movbe, rdrand, mmxext, ffxsr, rdtscp, cr8leg

Re: [Qemu-devel] AVMF & OVMF blobs in QEMU tree???

On Mon, 2017-08-07 at 18:51 +0200, Laszlo Ersek wrote: > On 08/07/17 16:40, Peter Maydell wrote: > > On 7 August 2017 at 15:31, Igor Mammedov > > wrote: > > > As I recall there were issues with FAT driver licensing in edk2, > > > but I've heard there were some changes in that regard. > > > > > >

Re: [Qemu-devel] [PATCH v4 09/10] s390x/kvm: msi route fixup for non-pci

On 08/21/2017 11:16 AM, Cornelia Huck wrote: > If we don't provide pci, we cannot have a pci device for which we > have to translate to adapter routes: just return -ENODEV. > > Signed-off-by: Cornelia Huck > --- > target/s390x/kvm.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git

Re: [Qemu-devel] [PATCH for-2.10] numa: Move numa_legacy_auto_assign_ram to pc-i440fx-2.9

On 18 August 2017 at 20:15, Eduardo Habkost wrote: > On Fri, Aug 18, 2017 at 04:09:43PM -0300, Eduardo Habkost wrote: >> The 'm->numa_auto_assign_ram = numa_legacy_auto_assign_ram;' line >> was supposed to be in pc_i440fx_2_9_machine_options() (see commit >> 3bfe5716 "numa: equally distribute memo

Re: [Qemu-devel] [PATCH v5 4/6] block: convert ThrottleGroup to object with QOM

On Sat 19 Aug 2017 09:08:59 AM CEST, Manos Pitsidianakis wrote: >>> +if (tg->name) { >>> +/* error if name is duplicate */ >>> +QTAILQ_FOREACH(iter, &throttle_groups, list) { >>> +if (!g_strcmp0(tg->name, iter->name) && tg != iter) { >> >>I'm just nitpicking here :)

Re: [Qemu-devel] [PATCH] hw/ppc/spapr: Fix segfault when instantiating a 'pc-dimm' without 'memdev'

On Mon, 21 Aug 2017 20:35:24 +1000 David Gibson wrote: > From: Thomas Huth > > QEMU currently crashes when trying to use a 'pc-dimm' on the pseries > machine without specifying its 'memdev' property. This happens because > pc_dimm_get_memory_region() does not check whether the 'memdev' property

Re: [Qemu-devel] [PATCH 3/4] throttle: Remove throttle_fix_bucket() / throttle_unfix_bucket()

On Sat 19 Aug 2017 05:23:12 PM CEST, Manos Pitsidianakis wrote: >>-/* If the bucket is full then we have to wait */ >>-extra = bkt->level - bkt->max * bkt->burst_length; >>+if (!bkt->max) { >>+/* If bkt->max is 0 we still want to allow short bursts of I/O >>+ * from the

Re: [Qemu-devel] xhci: guard xhci_kick_epctx against recursive calls for 2.8?

> After applying commit 96d87bdda3919bb16f754b3d3fd1227e1f38f13c: > > Author: Gerd Hoffmann > Date:   Thu Feb 2 12:36:12 2017 +0100 > > xhci: guard xhci_kick_epctx against recursive calls > to 2.8, to fix the CVE-2017-9375 in 2.8, it starts to fail at > startup with the assertion failure i

Re: [Qemu-devel] [PATCH v4 09/10] s390x/kvm: msi route fixup for non-pci

On Mon, 21 Aug 2017 14:00:15 +0200 Halil Pasic wrote: > On 08/21/2017 11:16 AM, Cornelia Huck wrote: > > If we don't provide pci, we cannot have a pci device for which we > > have to translate to adapter routes: just return -ENODEV. > > > > Signed-off-by: Cornelia Huck > > --- > > target/s390x

Re: [Qemu-devel] [PATCH 1/4] throttle: Fix wrong variable name in the header documentation

On Sat 19 Aug 2017 04:29:47 PM CEST, Manos Pitsidianakis wrote: > On Thu, Aug 17, 2017 at 05:28:12PM +0300, Alberto Garcia wrote: >>The level of the burst bucket is stored in bkt.burst_level, not >>bkt.burst_lenght. > > s/lenght/length, otherwise: Oh my, fixing a typo by introducing another typo :

Re: [Qemu-devel] [PATCH 3/4] throttle: Remove throttle_fix_bucket() / throttle_unfix_bucket()

On Mon, Aug 21, 2017 at 02:10:59PM +0200, Alberto Garcia wrote: On Sat 19 Aug 2017 05:23:12 PM CEST, Manos Pitsidianakis wrote: -/* If the bucket is full then we have to wait */ -extra = bkt->level - bkt->max * bkt->burst_length; +if (!bkt->max) { +/* If bkt->max is 0 we stil

Re: [Qemu-devel] xhci: move command stop and command abort flag check to the case when the crcr_low register is set

On Tue, 2017-08-01 at 01:48 +0200, Jaroslav Jindrák wrote: > Hello, > > I'd like to submit a patch to the xhci subsystem of QEMU. Currently, > when the command stop or command abort flags in the crcr_low register > are set, nothing happens. This is because the part of the code that > tests those t

Re: [Qemu-devel] [PATCH v4 04/10] s390x: chsc nt2 events are pci-only

On 21.08.2017 11:16, Cornelia Huck wrote: > The nt2 event class is pci-only - don't look for events if pci is > not in the active cpu model. > > Signed-off-by: Cornelia Huck > --- > hw/s390x/s390-pci-bus.c | 4 ++-- > hw/s390x/s390-pci-bus.h | 4 ++-- > hw/s390x/s390-pci-stub.c | 4 ++-- >

  1   2   3   >