On Mon, Aug 21, 2017 at 10:45:02AM +0200, Igor Mammedov wrote: > On Mon, 21 Aug 2017 17:55:20 +1000 > David Gibson <da...@gibson.dropbear.id.au> wrote: > > > On Mon, Aug 21, 2017 at 08:30:29AM +0200, Thomas Huth wrote: > > > QEMU currently crashes when trying to use a 'pc-dimm' on the pseries > > > machine without specifying its 'memdev' property. This happens because > > > pc_dimm_get_memory_region() does not check whether the 'memdev' property > > > has properly been set by the user. Looking closer at this function, it's > > > also obvious that it is using &error_abort to call another function - and > > > this is bad in a function that is used in the hot-plugging calling chain > > > since this can also cause QEMU to exit unexpectedly. > > > > > > So let's fix these issues in a proper way now: Add a "Error **errp" > > > parameter to pc_dimm_get_memory_region() which we use in case the 'memdev' > > > property has not been set by the user, and which we can use instead of > > > the &error_abort, and change the callers of get_memory_region() to make > > > use of this "errp" parameter for proper error checking. > > > > > > Signed-off-by: Thomas Huth <th...@redhat.com> > > > > ppc portions > > > > Acked-by: David Gibson <da...@gibson.dropbear.id.au> > > > > and the rest > > > > Reviewed-by: David Gibson <da...@gibson.dropbear.id.au> > Reviewed-by: Igor Mammedov <imamm...@redhat.com> > > > > I'm happy to queue this or have someone else queue it. > Pls, go ahead and queue it via your tree
Done.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
