[Qemu-devel] [PATCH v5 09/10] qmp.py: Avoid overriding a builtin object

2017-08-15 Thread Lukáš Doktor
The "id" is a builtin method to get object's identity and should not be overridden. This might bring some issues in case someone was directly calling "cmd(..., id=id)" but I haven't found such usage on brief search for "cmd\(.*id=". Signed-off-by: Lukáš Doktor Reviewed-by: Eduardo Habkost --- s

[Qemu-devel] [PATCH v5 06/10] qmp.py: Couple of pylint/style fixes

2017-08-15 Thread Lukáš Doktor
No actual code changes, just initializing attributes earlier to avoid AttributeError on early introspection, a few pylint/style fixes and docstring clarifications. Signed-off-by: Lukáš Doktor Reviewed-by: Philippe Mathieu-Daudé --- scripts/qmp/qmp.py | 37 -

[Qemu-devel] [PATCH v5 10/10] qtest.py: Few pylint/style fixes

2017-08-15 Thread Lukáš Doktor
No actual code changes, just few pylint/style fixes. Signed-off-by: Lukáš Doktor Reviewed-by: John Snow --- scripts/qtest.py | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/scripts/qtest.py b/scripts/qtest.py index ab183c0..df0daf2 100644 --- a/scripts/qtest.py +

[Qemu-devel] [PATCH v5 08/10] qmp.py: Avoid "has_key" usage

2017-08-15 Thread Lukáš Doktor
The "has_key" is deprecated in favor of "__in__" operator. Signed-off-by: Lukáš Doktor Reviewed-by: Eduardo Habkost Reviewed-by: Philippe Mathieu-Daudé --- scripts/qmp/qmp.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/qmp/qmp.py b/scripts/qmp/qmp.py index 95ff5

Re: [Qemu-devel] [PATCH for-2.10 v2 0/2] trace: fix simpletrace.stp flight recorder mode

2017-08-15 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20170815084430.7128-1-stefa...@redhat.com Subject: [Qemu-devel] [PATCH for-2.10 v2 0/2] trace: fix simpletrace.stp flight recorder mode Type: series === TEST SCRIPT BEGIN === #!/bin/bash

[Qemu-devel] [PATCH] hw/acpi: Select an node with memory for mapping memory hole to

2017-08-15 Thread Dou Liyang
Currently, Using the fisrt node without memory on the machine makes QEMU unhappy. With this example command line: ... \ -m 1024M,slots=4,maxmem=32G \ -numa node,nodeid=0 \ -numa node,mem=1024M,nodeid=1 \ -numa node,nodeid=2 \ -numa node,nodeid=3 \ Guest reports "No NUMA configuration fo

[Qemu-devel] [PATCH v5 00/10] qemu.py: Pylint/style fixes

2017-08-15 Thread Lukáš Doktor
Hello guys, I'm reading the available python modules to exercise qemu and while reading them I fixed some issues that caught my attention. It usually starts with a simple pylint/docstring fixes and slowly graduates to more controversial ones so I'm open to suggestion to remove some of them. Kind

Re: [Qemu-devel] [PATCH] numa: Add a check whether the node0 has memory or not

2017-08-15 Thread Dou Liyang
Hi Igor, At 08/15/2017 04:04 PM, Igor Mammedov wrote: On Tue, 15 Aug 2017 09:26:46 +0800 Dou Liyang wrote: Hi Eduardo, At 08/14/2017 08:44 PM, Eduardo Habkost wrote: On Mon, Aug 14, 2017 at 06:11:11PM +0800, Dou Liyang wrote: Currently, Using the fisrt node without memory on the machine ma

[Qemu-devel] [PATCH v5 01/10] qemu.py: Pylint/style fixes

2017-08-15 Thread Lukáš Doktor
No actual code changes, just several pylint/style fixes and docstring clarifications. Signed-off-by: Lukáš Doktor --- scripts/qemu.py | 76 - 1 file changed, 53 insertions(+), 23 deletions(-) diff --git a/scripts/qemu.py b/scripts/qemu.py

[Qemu-devel] [PATCH v5 02/10] qemu|qtest: Avoid dangerous arguments

2017-08-15 Thread Lukáš Doktor
The list object is mutable in python and potentially might modify other object's arguments when used as default argument. Reproducer: >>> vm1 = QEMUMachine("qemu") >>> vm2 = QEMUMachine("qemu") >>> vm1._wrapper.append("foo") >>> print vm2._wrapper ['foo'] In this case the `arg

[Qemu-devel] [PATCH v5 03/10] qemu.py: Use iteritems rather than keys()

2017-08-15 Thread Lukáš Doktor
Let's avoid creating an in-memory list of keys and query for each value and use `iteritems` which is an iterator of key-value pairs. Signed-off-by: Lukáš Doktor Reviewed-by: Eduardo Habkost Reviewed-by: Philippe Mathieu-Daudé --- scripts/qemu.py | 6 +++--- 1 file changed, 3 insertions(+), 3 d

Re: [Qemu-devel] [PATCH] hw/acpi: Select an node with memory for mapping memory hole to

2017-08-15 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 1502787511-20894-1-git-send-email-douly.f...@cn.fujitsu.com Subject: [Qemu-devel] [PATCH] hw/acpi: Select an node with memory for mapping memory hole to Type: series === TEST SCRIPT BEGI

[Qemu-devel] [RFC PATCH for 2.11] tests: Introduce generic device hot-plug/hot-unplug functions

2017-08-15 Thread Thomas Huth
A lot of tests provide code for adding and removing a device via the device_add and device_del QMP commands. Maintaining this code in so many places is cumbersome and error-prone (some of the code parts check the responses in an incorrect way, for example), so let's provide some proper generic qtes

Re: [Qemu-devel] [RFC 5/6] migration: store listen task tag

2017-08-15 Thread Daniel P. Berrange
On Tue, Aug 15, 2017 at 04:50:06PM +0800, Peter Xu wrote: > On Tue, Aug 15, 2017 at 09:37:14AM +0100, Daniel P. Berrange wrote: > > On Tue, Aug 15, 2017 at 02:17:06PM +0800, Peter Xu wrote: > > > Store the task tag for migration types: tcp/unix/fd/exec in current > > > MigrationIncomingState struct

Re: [Qemu-devel] [PATCH] Makefile: Let "make check-help" work without running ./configure

2017-08-15 Thread Alex Bennée
Fam Zheng writes: > On Thu, 08/10 08:59, Philippe Mathieu-Daudé wrote: >> Hi Fam, >> >> thank for fixing this :) >> >> I think as a bugfix it should enter 2.10 >> (maybe through Alex's Travis series, CC'ing him) > > Since Alex hasn't replied, I'll send a pull request for -rc3. Yes please. Sorry

[Qemu-devel] [PATCH v4 00/12] Convert over to use keycodemapdb

2017-08-15 Thread Daniel P. Berrange
An update of: v1: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02047.html v2: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02471.html v3: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02517.html The keycodemap project[1] provides a database mapping between

[Qemu-devel] [PATCH v4 02/12] ui: convert common input code to keycodemapdb

2017-08-15 Thread Daniel P. Berrange
Replace the number_to_qcode, qcode_to_number and linux_to_qcode tables with automatically generated tables. Missing entries in linux_to_qcode now fixed: KEY_LINEFEED -> Q_KEY_CODE_LF KEY_KPEQUAL -> Q_KEY_CODE_KP_EQUALS KEY_COMPOSE -> Q_KEY_CODE_COMPOSE KEY_AGAIN -> Q_KEY_CODE_AGAIN KEY_

[Qemu-devel] [PATCH v4 01/12] ui: add keycodemapdb repository as a GIT submodule

2017-08-15 Thread Daniel P. Berrange
The https://gitlab.com/keycodemap/keycodemapdb/ repo contains a data file mapping between all the different scancode/keycode/keysym sets that are known, and a tool to auto-generate lookup tables for different combinations. It is used by GTK-VNC, SPICE-GTK and libvirt for mapping keys. Using it in

[Qemu-devel] [PATCH v4 06/12] input: convert ps2 device to keycodemapdb

2017-08-15 Thread Daniel P. Berrange
Replace the qcode_to_keycode_set1, qcode_to_keycode_set2, and qcode_to_keycode_set3 tables with automatically generated tables. Missing entries in qcode_to_keycode_set1 now fixed: - Q_KEY_CODE_SYSRQ -> 0x54 - Q_KEY_CODE_PRINT -> 0x54 (NB ignored due to special case) - Q_KEY_CODE_AGAIN -> 0xe00

[Qemu-devel] [PATCH v4 04/12] ui: don't export qemu_input_event_new_key

2017-08-15 Thread Daniel P. Berrange
All public code should use qemu_input_event_send_key* functions instead of creating an event directly. Signed-off-by: Daniel P. Berrange --- include/ui/input.h | 1 - ui/input.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/include/ui/input.h b/include/ui/input.h

[Qemu-devel] [PATCH v4 03/12] ui: convert key events to QKeyCodes immediately

2017-08-15 Thread Daniel P. Berrange
Always use QKeyCode in the InputKeyEvent struct, by converting key numbers to QKeyCode at the time the event is created. Signed-off-by: Daniel P. Berrange --- ui/input.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/ui/input.c b/ui/input.c index af05f06368..64e9103a61

[Qemu-devel] [PATCH v4 05/12] input: convert virtio-input-hid device to keycodemapdb

2017-08-15 Thread Daniel P. Berrange
Replace the keymap_qcode table with automatically generated tables. Missing entries in keymap_qcode now fixed: Q_KEY_CODE_ASTERISK -> KEY_KPASTERISK Q_KEY_CODE_KP_MULTIPLY -> KEY_KPASTERISK Q_KEY_CODE_STOP -> KEY_STOP Q_KEY_CODE_AGAIN -> KEY_AGAIN Q_KEY_CODE_PROPS -> KEY_PROPS Q_KEY_C

[Qemu-devel] [PATCH v4 07/12] input: convert the adb device to keycodemapdb

2017-08-15 Thread Daniel P. Berrange
Replace the qcode_to_adb_keycode table with automatically generated tables. Missing entries in qcode_to_adb_keycode now fixed: - Q_KEY_CODE_KP_COMMA -> 0x47 Signed-off-by: Daniel P. Berrange --- hw/input/adb.c | 124 +- include/hw/input/adb-key

[Qemu-devel] [PATCH v4 08/12] char: convert the escc device to keycodemapdb

2017-08-15 Thread Daniel P. Berrange
Replace the qcode_to_keycode table with automatically generated tables. Missing entries in qcode_to_keycode now fixed: - Q_KEY_CODE_KP_COMMA -> 0x2d Signed-off-by: Daniel P. Berrange --- hw/char/escc.c | 126 +++-- include/ui/input.h | 3 +

[Qemu-devel] [PATCH v4 09/12] ui: convert cocoa frontend to keycodemapdb

2017-08-15 Thread Daniel P. Berrange
Replace the mac_to_qkeycode_map table with automatically generated table. Signed-off-by: Daniel P. Berrange --- include/ui/input.h | 3 ++ ui/Makefile.objs | 1 + ui/cocoa.m | 129 + ui/input-keymap.c | 1 + 4 files changed, 7

[Qemu-devel] [PATCH v4 11/12] ui: convert GTK and SDL1 frontends to keycodemapdb

2017-08-15 Thread Daniel P. Berrange
The x_keycode_to_pc_keycode and evdev_keycode_to_pc_keycode tables are replaced with automatically generated tables. In addition the X11 heuristics are improved to detect running on XQuartz and XWin X11 servers, to activate the correct OS-X and Win32 keycode maps. Signed-off-by: Daniel P. Berrange

[Qemu-devel] [PATCH v4 12/12] display: convert XenInput keyboard to keycodemapdb

2017-08-15 Thread Daniel P. Berrange
Replace the scancode2linux table with an automatically generated table. In doing so, the XenFB keyboard handler is also converted to the modern InputEvent framework. Signed-off-by: Daniel P. Berrange --- hw/display/xenfb.c | 133 - 1 file chang

[Qemu-devel] [PATCH v4 10/12] ui: convert the SDL2 frontend to keycodemapdb

2017-08-15 Thread Daniel P. Berrange
The SDL2 scancodes are conveniently identical to the USB scancodes. Replace the sdl2_scancode_to_qcode table with an automatically generated table. Missing entries in sdl2_scancode_to_qcode now fixed: - 0x32 -> Q_KEY_CODE_BACKSLASH - 0x66 -> Q_KEY_CODE_POWER - 0x67 -> Q_KEY_CODE_KP_EQUALS

Re: [Qemu-devel] [PULL for-2.10 0/1] bugfix for s390x

2017-08-15 Thread Peter Maydell
ohuck/qemu tags/s390x-20170815 > > for you to fetch changes up to 88b3739acdec0b8ccdbb65425b0d31235e2c7ca3: > > pc-bios/s390-ccw: Use rm command during make clean (2017-08-15 09:06:01 > +0200) > >

Re: [Qemu-devel] [RFC 5/6] migration: store listen task tag

2017-08-15 Thread Peter Xu
On Tue, Aug 15, 2017 at 10:27:07AM +0100, Daniel P. Berrange wrote: > On Tue, Aug 15, 2017 at 04:50:06PM +0800, Peter Xu wrote: > > On Tue, Aug 15, 2017 at 09:37:14AM +0100, Daniel P. Berrange wrote: > > > On Tue, Aug 15, 2017 at 02:17:06PM +0800, Peter Xu wrote: > > > > Store the task tag for migr

Re: [Qemu-devel] [PATCH for-2.11 v2 1/5] qmp-shell: Use optparse module

2017-08-15 Thread Markus Armbruster
Eduardo Habkost writes: > It makes command-line parsing and generation of help text much > simpler. There's really no excuse for parsing command line arguments by hand in Python. > The optparse module is deprecated since Python 2.7, but argparse > is not available in Python 2.6 (the minimum Pyt

Re: [Qemu-devel] [PATCH for-2.11 v2 1/5] qmp-shell: Use optparse module

2017-08-15 Thread Daniel P. Berrange
On Tue, Aug 15, 2017 at 11:47:28AM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > It makes command-line parsing and generation of help text much > > simpler. > > There's really no excuse for parsing command line arguments by hand in > Python. > > > The optparse module is deprec

Re: [Qemu-devel] [PATCH for-2.11 v2 1/5] qmp-shell: Use optparse module

2017-08-15 Thread Daniel P. Berrange
On Tue, Aug 08, 2017 at 05:39:31PM -0300, Eduardo Habkost wrote: > It makes command-line parsing and generation of help text much > simpler. > > The optparse module is deprecated since Python 2.7, but argparse > is not available in Python 2.6 (the minimum Python version > required for building QEM

Re: [Qemu-devel] [PATCH for-2.10 0/1] Fix "make clean" for s390 target

2017-08-15 Thread Peter Maydell
On 14 August 2017 at 21:44, Eric Farman wrote: > How often does one really do a "make clean" ? Rather infrequently, > as I only stumbled on this today. FWIW, one of my standard pre-merge build tests does a "make clean" and then a make (mostly as a check that we do build from clean as well as inc

Re: [Qemu-devel] [PATCH for-2.11 v2 4/5] qmp-shell: Accept QMP command as argument

2017-08-15 Thread Markus Armbruster
Eduardo Habkost writes: Suggest to insert here: If additional arguments QMP-COMMAND ARG=VAL... are given, run just that QMP command instead of the REPL. Question: is this limited to simple arguments? If no, how would I write an object argument? For instance, how would I do { "execute

Re: [Qemu-devel] [PATCH v4 01/12] ui: add keycodemapdb repository as a GIT submodule

2017-08-15 Thread Daniel P. Berrange
On Tue, Aug 15, 2017 at 10:36:04AM +0100, Daniel P. Berrange wrote: > The https://gitlab.com/keycodemap/keycodemapdb/ repo contains a > data file mapping between all the different scancode/keycode/keysym > sets that are known, and a tool to auto-generate lookup tables for > different combinations.

Re: [Qemu-devel] [PATCH] ppc: fix ppc_set_compat() with KVM PR

2017-08-15 Thread Greg Kurz
On Tue, 15 Aug 2017 14:04:09 +1000 David Gibson wrote: > On Mon, Aug 14, 2017 at 07:49:16PM +0200, Greg Kurz wrote: > > When running in KVM PR mode, kvmppc_set_compat() always fail because the > > current PR implementation doesn't handle KVM_REG_PPC_ARCH_COMPAT. Now that > > the machine code inco

Re: [Qemu-devel] [PATCH for-2.10 0/1] Fix "make clean" for s390 target

2017-08-15 Thread Eric Farman
On 08/15/2017 04:26 AM, Thomas Huth wrote: On 15.08.2017 10:01, Thomas Huth wrote: On 15.08.2017 09:03, Cornelia Huck wrote: On Tue, 15 Aug 2017 07:02:10 +0200 Thomas Huth wrote: On 14.08.2017 22:44, Eric Farman wrote: How often does one really do a "make clean" ? Rather infrequently, as

Re: [Qemu-devel] [PATCH v4 01/12] ui: add keycodemapdb repository as a GIT submodule

2017-08-15 Thread Fam Zheng
On Tue, 08/15 11:04, Daniel P. Berrange wrote: > On Tue, Aug 15, 2017 at 10:36:04AM +0100, Daniel P. Berrange wrote: > > The https://gitlab.com/keycodemap/keycodemapdb/ repo contains a > > data file mapping between all the different scancode/keycode/keysym > > sets that are known, and a tool to aut

Re: [Qemu-devel] [PATCH v4 01/12] ui: add keycodemapdb repository as a GIT submodule

2017-08-15 Thread Daniel P. Berrange
On Tue, Aug 15, 2017 at 06:47:22PM +0800, Fam Zheng wrote: > On Tue, 08/15 11:04, Daniel P. Berrange wrote: > > On Tue, Aug 15, 2017 at 10:36:04AM +0100, Daniel P. Berrange wrote: > > > The https://gitlab.com/keycodemap/keycodemapdb/ repo contains a > > > data file mapping between all the different

[Qemu-devel] [PULL 2/5] docker: use one package per line in CentOS config

2017-08-15 Thread Fam Zheng
From: Philippe Mathieu-Daudé This ease rebase/cherry-pick, also it is faster to visually find if a package is here. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20170728233316.13352-2-f4...@amsat.org> Signed-off-by: Fam Zheng --- tests/docker/dockerfiles/centos6.docker | 18

[Qemu-devel] [PULL 0/5] Build and test patches

2017-08-15 Thread Fam Zheng
The following changes since commit 83c3a1f61673ef554facf4d6d29ed56c5a219f9d: xlnx-qspi: add a property for mmio-execution (2017-08-14 14:17:18 +0100) are available in the git repository at: git://github.com/famz/qemu.git tags/build-and-test-pull-request for you to fetch changes up to a8132a

[Qemu-devel] [PULL 3/5] docker: add Xen libs to centos6 image

2017-08-15 Thread Fam Zheng
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20170728233316.13352-3-f4...@amsat.org> Signed-off-by: Fam Zheng --- tests/docker/dockerfiles/centos6.docker | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/docker/dockerfiles/centos6.do

[Qemu-devel] [PULL 1/5] Makefile: Let "make check-help" work without running ./configure

2017-08-15 Thread Fam Zheng
Currently if you do "make check-help" in a fresh checkout, only an error is printed which is not nice: $ make check-help V=1 cc -nostdlib -o check-help.mo cc: fatal error: no input files compilation terminated. rules.mak:115: recipe for target 'check-help.mo' failed make:

[Qemu-devel] [PULL 4/5] docker: install more packages on CentOS to extend code coverage

2017-08-15 Thread Fam Zheng
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20170728233316.13352-4-f4...@amsat.org> Signed-off-by: Fam Zheng --- tests/docker/dockerfiles/centos6.docker | 10 ++ 1 file changed, 10 insertions(+) diff --git a/tests/docker/dockerfiles/centos6.docker

[Qemu-devel] [PULL 5/5] docker: add centos7 image

2017-08-15 Thread Fam Zheng
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20170728233316.13352-5-f4...@amsat.org> Signed-off-by: Fam Zheng --- tests/docker/dockerfiles/centos7.docker | 31 +++ 1 file changed, 31 insertions(+) create mode 100644 tests/docker/d

Re: [Qemu-devel] [PATCH for-2.10 0/1] Fix "make clean" for s390 target

2017-08-15 Thread Cornelia Huck
On Tue, 15 Aug 2017 11:00:51 +0100 Peter Maydell wrote: > On 14 August 2017 at 21:44, Eric Farman wrote: > > How often does one really do a "make clean" ? Rather infrequently, > > as I only stumbled on this today. > > FWIW, one of my standard pre-merge build tests does a > "make clean" and t

Re: [Qemu-devel] [PATCH for-2.10 0/1] Fix "make clean" for s390 target

2017-08-15 Thread Peter Maydell
On 15 August 2017 at 12:07, Cornelia Huck wrote: > On Tue, 15 Aug 2017 11:00:51 +0100 > Peter Maydell wrote: > >> On 14 August 2017 at 21:44, Eric Farman wrote: >> > How often does one really do a "make clean" ? Rather infrequently, >> > as I only stumbled on this today. >> >> FWIW, one of my s

[Qemu-devel] [Bug 1708442] Re: Crash(assert) during reading image from http url through qemu-nbd

2017-08-15 Thread Andrey Smetanin
ping -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1708442 Title: Crash(assert) during reading image from http url through qemu-nbd Status in QEMU: New Bug description: Description: During

[Qemu-devel] [PATCH for-2.10 v2 2/2] Revert "ACPI: don't call acpi_pcihp_device_plug_cb on xen"

2017-08-15 Thread Anthony PERARD
This reverts commit 153eba4726dfa1bdfc31d1fe973b2a61b9035492. This patch prevents PCI passthrough hotplug on Xen. Even if the Xen tool stack prepares its own ACPI tables, we still rely on QEMU for hotplug ACPI notifications. The original issue is fixed by the previous patch (hw/acpi: Call acpi_se

[Qemu-devel] [PATCH for-2.10 v2 1/2] hw/acpi: Call acpi_set_pci_info when no ACPI tables needed

2017-08-15 Thread Anthony PERARD
To do PCI passthrough with Xen, the property acpi-pcihp-bsel needs to be set, but this was done only when ACPI tables are built which is not needed for a Xen guest. The need for the property starts with commit "pc: pcihp: avoid adding ACPI_PCIHP_PROP_BSEL twice" (f0c9d64a68b776374ec4732424a3e27753c

[Qemu-devel] [PATCH for-2.10 v2 0/2] Fix hotplug of PCI passthrought device on Xen

2017-08-15 Thread Anthony PERARD
Adding PCI passthrough before the guest start works fine (broken in 2.9 but now fixed), but hotplug does not work anymore. Anthony PERARD (2): hw/acpi: Call acpi_set_pci_info when no ACPI tables needed Revert "ACPI: don't call acpi_pcihp_device_plug_cb on xen" hw/acpi/piix4.c | 11 +++--

Re: [Qemu-devel] RFH: difference in read-only mapped bios.bin - memory corruption?

2017-08-15 Thread Laszlo Ersek
On 08/14/17 20:39, Dr. David Alan Gilbert wrote: > * Philipp Hahn (h...@univention.de) wrote: >> Hello, >> >> I'm currently investigating a problem, were a Linux VM does not reboot >> and gets stuck in the SeaBIOS reboot code: >> >> I'm using SeaBIOS-1.7 from Debian with a more modern qemu-2.8 >> >

Re: [Qemu-devel] [PATCH 04/28] sparc: convert cpu models to SPARC cpu subclasses

2017-08-15 Thread Mark Cave-Ayland
On 14/08/17 08:56, Igor Mammedov wrote: > On Fri, 14 Jul 2017 15:51:55 +0200 > Igor Mammedov wrote: > >> QOMfy cpu models handling introducing propper cpu types >> for each cpu model. >> >> Signed-off-by: Igor Mammedov >> --- >> with this and conversion of features to properties, >> it would be

Re: [Qemu-devel] [PATCH] target-i386/cpu: Add new EYPC CPU model

2017-08-15 Thread Eduardo Habkost
Hi, Thanks for the patch. On Mon, Aug 14, 2017 at 10:52:17AM -0500, Brijesh Singh wrote: > Add a new base CPU model called 'EPYC' to model processors from AMD EPYC > family (which includes EPYC 76xx,75xx,74xx,73xx and 72xx). I suggest enumerating in the commit message which features were added t

Re: [Qemu-devel] [RFC PATCH 08/12] hw/ide: Emulate SiI3112 SATA controller

2017-08-15 Thread David Gibson
On Mon, Aug 14, 2017 at 01:16:13PM +0200, BALATON Zoltan wrote: > On Mon, 14 Aug 2017, David Gibson wrote: > > On Sun, Aug 13, 2017 at 07:04:38PM +0200, BALATON Zoltan wrote: > > > Signed-off-by: BALATON Zoltan > > > > Needs a commit message: where does this controller appear? what's > > distinct

Re: [Qemu-devel] [PULL 0/6] ppc patch queue 2017-08-09

2017-08-15 Thread David Gibson
On Mon, Aug 14, 2017 at 05:20:21PM +0300, Michael S. Tsirkin wrote: > On Fri, Aug 11, 2017 at 09:59:00AM +0100, Peter Maydell wrote: > > On 11 August 2017 at 09:51, David Gibson > > wrote: > > > On Thu, Aug 10, 2017 at 01:47:03PM +0100, Peter Maydell wrote: > > >> On 9 August 2017 at 08:03, David

Re: [Qemu-devel] [PATCH for-2.10 3/4] block-backend: Defer shared_perm tightening migration completion

2017-08-15 Thread Stefan Hajnoczi
On Tue, Aug 15, 2017 at 12:04:53PM +0800, Fam Zheng wrote: > @@ -147,6 +166,24 @@ static void blk_root_activate(BdrvChild *child, Error > **errp) > > blk->disable_perm = false; > > +blk_set_perm(blk, blk->perm, BLK_PERM_ALL, &local_err); > +if (local_err) { > +error_propag

Re: [Qemu-devel] [PATCH for-2.10 v2 0/2] trace: fix simpletrace.stp flight recorder mode

2017-08-15 Thread Stefan Hajnoczi
On Tue, Aug 15, 2017 at 09:44:28AM +0100, Stefan Hajnoczi wrote: > v2: > * Don't emit event ID mapping records in simpletrace.stp [Daniel Berrange] > > The SystemTap flight recorder mode no longer works with simpletrace.stp > because > the event ID mapping records are emitted the first time an e

Re: [Qemu-devel] [PATCH for-2.10 v2 0/2] trace: fix simpletrace.stp flight recorder mode

2017-08-15 Thread Stefan Hajnoczi
On Tue, Aug 15, 2017 at 01:59:50AM -0700, no-re...@patchew.org wrote: > Checking PATCH 2/2: simpletrace: fix flight recorder --no-header option... > ERROR: line over 90 characters > #40: FILE: scripts/simpletrace.py:101: > +"""Deserialize trace records from a file, yielding record tuples > (ev

Re: [Qemu-devel] [PATCH v5 01/10] qemu.py: Pylint/style fixes

2017-08-15 Thread Stefan Hajnoczi
On Tue, Aug 15, 2017 at 10:57:23AM +0200, Lukáš Doktor wrote: > No actual code changes, just several pylint/style fixes and docstring > clarifications. > > Signed-off-by: Lukáš Doktor > --- > scripts/qemu.py | 76 > - > 1 file changed, 53

Re: [Qemu-devel] [PATCH for-2.10 v2 1/2] hw/acpi: Call acpi_set_pci_info when no ACPI tables needed

2017-08-15 Thread Igor Mammedov
On Tue, 15 Aug 2017 12:15:48 +0100 Anthony PERARD wrote: > To do PCI passthrough with Xen, the property acpi-pcihp-bsel needs to be > set, but this was done only when ACPI tables are built which is not > needed for a Xen guest. The need for the property starts with commit > "pc: pcihp: avoid addi

Re: [Qemu-devel] [PULL 0/5] Build and test patches

2017-08-15 Thread Peter Maydell
On 15 August 2017 at 11:57, Fam Zheng wrote: > The following changes since commit 83c3a1f61673ef554facf4d6d29ed56c5a219f9d: > > xlnx-qspi: add a property for mmio-execution (2017-08-14 14:17:18 +0100) > > are available in the git repository at: > > git://github.com/famz/qemu.git tags/build-and

Re: [Qemu-devel] [PATCH for-2.10 1/4] stubs: Add vm state change handler stubs

2017-08-15 Thread Eric Blake
On 08/14/2017 11:04 PM, Fam Zheng wrote: > Signed-off-by: Fam Zheng A bit sparse on the 'why' - presumably, upcoming patches will fail to compile if the stub is not present, but mentioning what dependency this solves never hurts. > --- > stubs/Makefile.objs | 1 + > stubs/change-state

Re: [Qemu-devel] [PATCH v5 01/10] qemu.py: Pylint/style fixes

2017-08-15 Thread Markus Armbruster
Lukáš Doktor writes: > No actual code changes, just several pylint/style fixes and docstring > clarifications. > > Signed-off-by: Lukáš Doktor > --- > scripts/qemu.py | 76 > - > 1 file changed, 53 insertions(+), 23 deletions(-) > > diff

Re: [Qemu-devel] [PATCH v4 01/12] ui: add keycodemapdb repository as a GIT submodule

2017-08-15 Thread Fam Zheng
On Tue, 08/15 11:53, Daniel P. Berrange wrote: > On Tue, Aug 15, 2017 at 06:47:22PM +0800, Fam Zheng wrote: > > On Tue, 08/15 11:04, Daniel P. Berrange wrote: > > > On Tue, Aug 15, 2017 at 10:36:04AM +0100, Daniel P. Berrange wrote: > > > > The https://gitlab.com/keycodemap/keycodemapdb/ repo conta

Re: [Qemu-devel] [PATCH for-2.10 1/4] stubs: Add vm state change handler stubs

2017-08-15 Thread Fam Zheng
On Tue, 08/15 07:26, Eric Blake wrote: > On 08/14/2017 11:04 PM, Fam Zheng wrote: > > Signed-off-by: Fam Zheng > > A bit sparse on the 'why' - presumably, upcoming patches will fail to > compile if the stub is not present, but mentioning what dependency this > solves never hurts. > > > --- > >

[Qemu-devel] [PATCH for-2.10] qemu-iotests: step clock after each test iteration

2017-08-15 Thread Stefan Hajnoczi
The 093 throttling test submits twice as many requests as the throttle limit in order to ensure that we reach the limit. The remaining requests are left in-flight at the end of each test iteration. Commit 452589b6b47e8dc6353df257fc803dfc1383bed8 ("vl.c/exit: pause cpus before closing block device

[Qemu-devel] [PATCH for-2.10 v2 0/4] block: Fix non-shared storage migration

2017-08-15 Thread Fam Zheng
v2: Don't leak blk->vmsh when BB is deleted before the callback is called. [Stefan] From stub functions, don't return g_malloc0(1) which is risky, return NULL. [Eric] "nbd-server-add -w" doesn't work when we are in "-incoming defer" state: (qemu) nbd_server_add -w drive-virtio-dis

[Qemu-devel] [PATCH for-2.10 v2 1/4] stubs: Add vm state change handler stubs

2017-08-15 Thread Fam Zheng
They will be used by BlockBackend code in block-obj-y, which doesn't always get linked with common-obj-y. Add stubs to keep ld happy. Signed-off-by: Fam Zheng --- stubs/Makefile.objs | 1 + stubs/change-state-handler.c | 14 ++ 2 files changed, 15 insertions(+) create mode

[Qemu-devel] [PATCH for-2.10 v2 3/4] block-backend: Defer shared_perm tightening migration completion

2017-08-15 Thread Fam Zheng
As in the case of nbd_export_new(), bdrv_invalidate_cache() can be called when migration is still in progress. In this case we are not ready to tighten the shared permissions fenced by blk->disable_perm. Defer to a VM state change handler. Signed-off-by: Fam Zheng --- block/block-backend.c | 41

[Qemu-devel] [PATCH for-2.10 v2 4/4] iotests: Add non-shared storage migration case 192

2017-08-15 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/qemu-iotests/192 | 63 ++ tests/qemu-iotests/192.out | 7 ++ tests/qemu-iotests/group | 1 + 3 files changed, 71 insertions(+) create mode 100755 tests/qemu-iotests/192 create mode 100644 tests/qemu-iotes

[Qemu-devel] [PATCH for-2.10 v2 2/4] nbd: Fix order of bdrv_set_perm and bdrv_invalidate_cache

2017-08-15 Thread Fam Zheng
From: Kevin Wolf The "inactive" state of BDS affects whether the permissions can be granted, we must call bdrv_invalidate_cache before bdrv_set_perm to support "-incoming defer" case. Reported-by: Christian Ehrhardt Signed-off-by: Fam Zheng --- nbd/server.c | 20 +++- 1 file c

Re: [Qemu-devel] [PATCH v2 1/6] block: skip implicit nodes in snapshots, blockjobs

2017-08-15 Thread Alberto Garcia
On Wed 09 Aug 2017 04:02:51 PM CEST, Manos Pitsidianakis wrote: > @@ -2988,6 +3004,9 @@ void qmp_block_stream(bool has_job_id, const char > *job_id, const char *device, > return; > } > > +/* Skip implicit filter nodes */ > +bs = bdrv_get_first_explicit(bs); > + > aio_c

[Qemu-devel] [PULL 0/2] Tracing patches

2017-08-15 Thread Stefan Hajnoczi
The following changes since commit 5681da292242550f37ba4c03f46a8a6f8ee9278a: Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20170815' into staging (2017-08-15 09:39:14 +0100) are available in the git repository at: git://github.com/stefanha/qemu.git tags/tracing-pull-re

[Qemu-devel] [PULL 1/2] trace: use static event ID mapping in simpletrace.stp

2017-08-15 Thread Stefan Hajnoczi
This is a partial revert of commit 7f1b588f20d027730676e627713ae3bbf6baab04 ("trace: emit name <-> ID mapping in simpletrace header"), which broke the SystemTap flight recorder because event mapping records may not be present in the ring buffer when the trace is analyzed. This means simpletrace.py

[Qemu-devel] [PULL 2/2] simpletrace: fix flight recorder --no-header option

2017-08-15 Thread Stefan Hajnoczi
The simpletrace.py script can pretty-print flight recorder ring buffers. These are not full simpletrace binary trace files but just the end of a trace file. There is no header and the event ID mapping information is often unavailable since the ring buffer may have filled up and discarded event ID

Re: [Qemu-devel] [PATCH for 2.10?] qxl: call qemu_spice_display_init_common for secondary devices

2017-08-15 Thread Daniel P. Berrange
On Tue, Aug 15, 2017 at 01:15:52AM +0200, Paolo Bonzini wrote: > Fixes this 2.10 regression: > > $ qemu-system-x86_64 -cpu host -m 6144 -vga qxl -device qxl > qemu-system-x86_64: util/qemu-thread-posix.c:64: qemu_mutex_lock: Assertion > `mutex->initialized' failed. > > Reported-by: adema...

Re: [Qemu-devel] [PATCH for 2.10?] qxl: call qemu_spice_display_init_common for secondary devices

2017-08-15 Thread Stefan Hajnoczi
On Tue, Aug 15, 2017 at 01:15:52AM +0200, Paolo Bonzini wrote: > Fixes this 2.10 regression: > > $ qemu-system-x86_64 -cpu host -m 6144 -vga qxl -device qxl > qemu-system-x86_64: util/qemu-thread-posix.c:64: qemu_mutex_lock: Assertion > `mutex->initialized' failed. > > Reported-by: adema...

Re: [Qemu-devel] [PATCH for-2.10] qemu-iotests: step clock after each test iteration

2017-08-15 Thread Eric Blake
On 08/15/2017 08:05 AM, Stefan Hajnoczi wrote: > The 093 throttling test submits twice as many requests as the throttle > limit in order to ensure that we reach the limit. The remaining > requests are left in-flight at the end of each test iteration. > > Commit 452589b6b47e8dc6353df257fc803dfc138

Re: [Qemu-devel] [PULL 0/2] Tracing patches

2017-08-15 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20170815132746.12540-1-stefa...@redhat.com Subject: [Qemu-devel] [PULL 0/2] Tracing patches Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BA

Re: [Qemu-devel] [PATCH v3 00/12] Convert over to use keycodemapdb

2017-08-15 Thread Programmingkid
> On Aug 15, 2017, at 4:38 AM, Daniel P. Berrange wrote: > > On Mon, Aug 14, 2017 at 02:46:22PM -0400, Programmingkid wrote: >> Sorry but there appears to be an issue with your patchset. I ran this >> command: >> >> ./configure --target-list=ppc-softmmu,i386-softmmu >> >> Then saw this error

Re: [Qemu-devel] [PATCH v3 00/12] Convert over to use keycodemapdb

2017-08-15 Thread Daniel P. Berrange
On Tue, Aug 15, 2017 at 09:49:00AM -0400, Programmingkid wrote: > > > On Aug 15, 2017, at 4:38 AM, Daniel P. Berrange wrote: > > > > On Mon, Aug 14, 2017 at 02:46:22PM -0400, Programmingkid wrote: > >> Sorry but there appears to be an issue with your patchset. I ran this > >> command: > >> > >

Re: [Qemu-devel] [PATCH v2 1/6] block: skip implicit nodes in snapshots, blockjobs

2017-08-15 Thread Manos Pitsidianakis
On Tue, Aug 15, 2017 at 03:24:38PM +0200, Alberto Garcia wrote: On Wed 09 Aug 2017 04:02:51 PM CEST, Manos Pitsidianakis wrote: @@ -2988,6 +3004,9 @@ void qmp_block_stream(bool has_job_id, const char *job_id, const char *device, return; } +/* Skip implicit filter nodes */ +

Re: [Qemu-devel] [PATCH for-2.10 v2 1/4] stubs: Add vm state change handler stubs

2017-08-15 Thread Eric Blake
On 08/15/2017 08:07 AM, Fam Zheng wrote: > They will be used by BlockBackend code in block-obj-y, which doesn't > always get linked with common-obj-y. Add stubs to keep ld happy. > > Signed-off-by: Fam Zheng > --- > stubs/Makefile.objs | 1 + > stubs/change-state-handler.c | 14 +++

Re: [Qemu-devel] [PATCH v2 for 2.10] block/nbd-client: always return EIO on and after the first io channel error

2017-08-15 Thread Eric Blake
On 08/15/2017 02:26 AM, Vladimir Sementsov-Ogievskiy wrote: >>> The only doubt: is it possible to hang on nbd_rwv because some fail in >>> connection or server? >> We _already_ have the bug that we are hanging in trying to talk to a >> broken server, which is a regression introduced in 2.9 and not

Re: [Qemu-devel] [PULL 0/2] Tracing patches

2017-08-15 Thread Peter Maydell
On 15 August 2017 at 14:27, Stefan Hajnoczi wrote: > The following changes since commit 5681da292242550f37ba4c03f46a8a6f8ee9278a: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20170815' into > staging (2017-08-15 09:39:14 +0100) > > are availa

Re: [Qemu-devel] [PATCH for-2.10 v2 2/4] nbd: Fix order of bdrv_set_perm and bdrv_invalidate_cache

2017-08-15 Thread Eric Blake
On 08/15/2017 08:07 AM, Fam Zheng wrote: > From: Kevin Wolf > > The "inactive" state of BDS affects whether the permissions can be > granted, we must call bdrv_invalidate_cache before bdrv_set_perm to > support "-incoming defer" case. > > Reported-by: Christian Ehrhardt > Signed-off-by: Fam Zhe

Re: [Qemu-devel] [PATCH v2 2/6] block: add options parameter to bdrv_new_open_driver()

2017-08-15 Thread Alberto Garcia
On Wed 09 Aug 2017 04:02:52 PM CEST, Manos Pitsidianakis wrote: > Allow passing a QDict *options parameter to bdrv_new_open_driver() so > that it can be used if a driver needs it upon creation. The previous > behaviour (empty bs->options and bs->explicit_options) remains when > options is NULL. > >

Re: [Qemu-devel] [PATCH for-2.10 v2 3/4] block-backend: Defer shared_perm tightening migration completion

2017-08-15 Thread Eric Blake
On 08/15/2017 08:07 AM, Fam Zheng wrote: > As in the case of nbd_export_new(), bdrv_invalidate_cache() can be > called when migration is still in progress. In this case we are not > ready to tighten the shared permissions fenced by blk->disable_perm. > > Defer to a VM state change handler. > > Si

Re: [Qemu-devel] [PATCH for-2.10 v2 4/4] iotests: Add non-shared storage migration case 192

2017-08-15 Thread Eric Blake
On 08/15/2017 08:07 AM, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > tests/qemu-iotests/192 | 63 > ++ > tests/qemu-iotests/192.out | 7 ++ > tests/qemu-iotests/group | 1 + > 3 files changed, 71 insertions(+) > create mode 100755 t

[Qemu-devel] [PATCH for-2.10] mmio-interface: Mark as not user creatable

2017-08-15 Thread Peter Maydell
The mmio-interface device is not something we want to allow users to create on the command line: * it is intended as an implementation detail of the memory subsystem, which gets created and deleted by that subsystem on demand; it makes no sense to create it by hand on the command line *

Re: [Qemu-devel] [PATCH for 2.10?] qxl: call qemu_spice_display_init_common for secondary devices

2017-08-15 Thread Peter Maydell
On 15 August 2017 at 14:39, Stefan Hajnoczi wrote: > On Tue, Aug 15, 2017 at 01:15:52AM +0200, Paolo Bonzini wrote: >> Fixes this 2.10 regression: >> >> $ qemu-system-x86_64 -cpu host -m 6144 -vga qxl -device qxl >> qemu-system-x86_64: util/qemu-thread-posix.c:64: qemu_mutex_lock: >> Asserti

Re: [Qemu-devel] [PATCH 01/26] qapi: fix type_seen key error

2017-08-15 Thread Markus Armbruster
Marc-André Lureau writes: > The type_seen member can be of a different type than the 'qtype' being > checked, since a string create several conflicts. Lookup the real > conflicting type in the conflict set, that one must be present in > type_seen. > > This fixes the following error, reproducible

Re: [Qemu-devel] [PATCH v3 00/12] Convert over to use keycodemapdb

2017-08-15 Thread Programmingkid
> On Aug 15, 2017, at 9:49 AM, Daniel P. Berrange wrote: > > On Tue, Aug 15, 2017 at 09:49:00AM -0400, Programmingkid wrote: >> >>> On Aug 15, 2017, at 4:38 AM, Daniel P. Berrange wrote: >>> >>> On Mon, Aug 14, 2017 at 02:46:22PM -0400, Programmingkid wrote: Sorry but there appears to be

Re: [Qemu-devel] [PATCH for-2.10 v2] nbd-client: Fix regression when server sends garbage

2017-08-15 Thread Vladimir Sementsov-Ogievskiy
15.08.2017 00:34, Eric Blake wrote: When we switched NBD to use coroutines for qemu 2.9 (in particular, commit a12a712a), we introduced a regression: if a server sends us garbage (such as a corrupted magic number), we quit the read loop but do not stop sending further queued commands, resulting i

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.10 v2] nbd-client: Fix regression when server sends garbage

2017-08-15 Thread Stefan Hajnoczi
On Mon, Aug 14, 2017 at 04:34:26PM -0500, Eric Blake wrote: > When we switched NBD to use coroutines for qemu 2.9 (in particular, > commit a12a712a), we introduced a regression: if a server sends us > garbage (such as a corrupted magic number), we quit the read loop > but do not stop sending furthe

Re: [Qemu-devel] [PATCH v2 for-2.11 1/2] tests/boot-sector: Do not overwrite the x86 buffer on other architectures

2017-08-15 Thread Cornelia Huck
On Fri, 11 Aug 2017 07:57:55 +0200 Thomas Huth wrote: > Re-using the boot_sector code buffer from x86 for other architectures > is not very nice, especially if we add more architectures later. It's > also ugly that the test uses a huge pre-initialized array at all - the > size of the executable i

Re: [Qemu-devel] [PATCH for-2.10 v2] nbd-client: Fix regression when server sends garbage

2017-08-15 Thread Eric Blake
On 08/15/2017 09:45 AM, Vladimir Sementsov-Ogievskiy wrote: > 15.08.2017 00:34, Eric Blake wrote: >> When we switched NBD to use coroutines for qemu 2.9 (in particular, >> commit a12a712a), we introduced a regression: if a server sends us >> garbage (such as a corrupted magic number), we quit the r

[Qemu-devel] [PATCH v2 for-2.10 2/3] target/arm: Correct load exclusive pair atomicity

2017-08-15 Thread Richard Henderson
We are not providing the required single-copy atomic semantics for the 64-bit operation that is the 32-bit paired load. At the same time, leave the entire 64-bit value in cpu_exclusive_val and stop writing to cpu_exclusive_high. This means that we do not have to re-assemble the 64-bit quantity wh

  1   2   3   >