Fam Zheng <f...@redhat.com> writes: > On Thu, 08/10 08:59, Philippe Mathieu-Daudé wrote: >> Hi Fam, >> >> thank for fixing this :) >> >> I think as a bugfix it should enter 2.10 >> (maybe through Alex's Travis series, CC'ing him) > > Since Alex hasn't replied, I'll send a pull request for -rc3.
Yes please. Sorry I got distracted by other stuff. > >> >> On 08/10/2017 05:50 AM, Fam Zheng wrote: >> > Currently if you do "make check-help" in a fresh checkout, only an error >> > is printed which is not nice: >> > >> > $ make check-help V=1 >> > cc -nostdlib -o check-help.mo >> > cc: fatal error: no input files >> > compilation terminated. >> > rules.mak:115: recipe for target 'check-help.mo' failed >> > make: *** [check-help.mo] Error 1 >> > >> > Move the config-host.mak condition into the body of >> > tests/Makefile.include and always include the rule for check-help. >> > >> > Reported-by: Philippe Mathieu-Daudé <f4...@amsat.org> >> > Signed-off-by: Fam Zheng <f...@redhat.com> >> >> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> >> Tested-by: Philippe Mathieu-Daudé <f4...@amsat.org> >> > > Fam -- Alex Bennée