[Qemu-devel] [Bug 1706866] [NEW] migrate: add tls option in virsh, migrate failed

2017-07-27 Thread chan
Public bug reported: version: libvirt-3.4.0 + qemu-2.9.90(latest) domain: any step: 1. generate tls certificate in /etc/pki/libvirt-migrate 2. start vm 3. migrate vm, cmdline: virsh migrate rh7.1-3 --live --undefinesource --persistent --verbose --tls qemu+ssh://IP/sys

[Qemu-devel] [PATCH v6 2/5] hypertrace: Add tracing event "guest_hypertrace"

2017-07-27 Thread Lluís Vilanova
Generates the "guest_hypertrace" event with a user-configurable number of arguments. Signed-off-by: Lluís Vilanova --- Makefile |7 --- Makefile.objs |2 ++ configure | 34 ++ rules.mak |2 +- trace-events | 11 +++ 5 file

[Qemu-devel] [PATCH v6 3/5] hypertrace: [*-user] Add QEMU-side proxy to "guest_hypertrace" event

2017-07-27 Thread Lluís Vilanova
QEMU detects when the guest uses 'mmap' on hypertrace's control channel file, and then uses 'mprotect' to detect accesses to it, which are used to trigger tracing event "guest_hypertrace". Signed-off-by: Lluís Vilanova --- Makefile.objs|4 bsd-user/main.c | 17 ++ bsd

[Qemu-devel] [PATCH v6 4/5] hypertrace: [softmmu] Add QEMU-side proxy to "guest_hypertrace" event

2017-07-27 Thread Lluís Vilanova
Uses a virtual device to trigger the hypertrace channel event. Signed-off-by: Lluís Vilanova --- hypertrace/Makefile.objs |4 + hypertrace/softmmu.c | 237 ++ include/hw/pci/pci.h |2 3 files changed, 243 insertions(+) create mode 10

[Qemu-devel] [PATCH v6 5/5] hypertrace: Add guest-side user-level library

2017-07-27 Thread Lluís Vilanova
Provides guest library "libqemu-hypertrace-guest.a" to abstract access to the hypertrace channel. Signed-off-by: Lluís Vilanova --- Makefile |5 + configure |2 hypertrace/guest/Makefile | 30 hypertrace/guest/common.c

Re: [Qemu-devel] [PATCH v6 0/5] hypertrace: Lightweight guest-to-QEMU trace channel

2017-07-27 Thread no-reply
Hi, This series failed build test on FreeBSD host. Please find the details below. Subject: [Qemu-devel] [PATCH v6 0/5] hypertrace: Lightweight guest-to-QEMU trace channel Type: series Message-id: 150113848793.25904.12006041120076726256.st...@frigg.lan === TEST SCRIPT BEGIN === #!/bin/sh # Testi

Re: [Qemu-devel] [PATCH v8 3/3] migration: add bitmap for received page

2017-07-27 Thread Alexey Perevalov
On 07/27/2017 05:35 AM, Peter Xu wrote: On Wed, Jul 26, 2017 at 06:24:11PM +0300, Alexey Perevalov wrote: On 07/26/2017 11:43 AM, Peter Xu wrote: On Wed, Jul 26, 2017 at 11:07:17AM +0300, Alexey Perevalov wrote: On 07/26/2017 04:49 AM, Peter Xu wrote: On Thu, Jul 20, 2017 at 09:52:34AM +0300,

[Qemu-devel] [Bug 1706866] Re: migrate: add tls option in virsh, migrate failed

2017-07-27 Thread Thomas Huth
This is the qemu bug tracker here. Please report libvirt bugs to the libvirt project instead (see http://libvirt.org/bugs.html). Thanks! ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU

[Qemu-devel] [Bug 1706866] [NEW]migrate: add tls option in virsh, migrate failed

2017-07-27 Thread Yuchen
Bug Description version: libvirt-3.4.0 + qemu-2.9.90(latest) domain: any step: 1. generate tls certificate in /etc/pki/libvirt-migrate 2. start vm 3. migrate vm, cmdline: virsh migrate rh7.1-3 --live --undefinesource --persistent --verbose --tls qemu+ssh://IP/system

Re: [Qemu-devel] [sw-dev] RFC: QEMU RISC-V modular ISA decoding

2017-07-27 Thread Markus Armbruster
Bastian Koppelmann writes: > On 07/25/2017 06:37 PM, Bruce Hoult wrote: >> Do you have any good estimates for how much of the execution time is >> typically spent in instruction decode? >> >> RISC-V qemu is twice as fast as ARM or Aarch64 qemu, so it's doing >> something right! >> >> (I suspect

Re: [Qemu-devel] [PATCH v4 1/2] qemu.py: make 'args' public

2017-07-27 Thread Amador Pahim
On Wed, Jul 26, 2017 at 7:35 PM, Stefan Hajnoczi wrote: > On Tue, Jul 25, 2017 at 11:30:16AM -0400, Cleber Rosa wrote: >> On 07/25/2017 09:37 AM, Stefan Hajnoczi wrote: >> > On Mon, Jul 24, 2017 at 02:44:37PM +0200, Amador Pahim wrote: >> >> Signed-off-by: Amador Pahim >> >> Reviewed-by: Fam Zhen

Re: [Qemu-devel] [PATCHv2 02/04] colo-compare: Processpactkets in the IOThreadofthe primary

2017-07-27 Thread Zhang Chen
CC. Fam and David. Any idea about it? Thanks Zhang Chen On 07/25/2017 09:02 AM, wang.yong...@zte.com.cn wrote: >On 24/07/2017 12:38, wang.yong...@zte.com.cn wrote: >> finally use g_main_loop_run to replace aio_poll in the >> iothread_run function. > >That would make the performance of

[Qemu-devel] [Bug 1706866] Re: migrate: add tls option in virsh, migrate failed

2017-07-27 Thread chan
with libvirt test, qemu report error, this is problem for qemu,so report here! ** Changed in: qemu Status: Invalid => New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1706866 Title: migrat

Re: [Qemu-devel] [PATCH v5 4/6] qemu.py: cleanup launch()

2017-07-27 Thread Amador Pahim
On Tue, Jul 25, 2017 at 10:42 PM, Eduardo Habkost wrote: > On Tue, Jul 25, 2017 at 07:10:12PM +0200, Amador Pahim wrote: >> launch() is currently taking care of a number of flows, each one if its >> own exception treatment, depending on the VM state and the files >> creation state. >> >> This patc

Re: [Qemu-devel] [PATCH v5 6/6] qemu.py: include qemu command line and output on launch error

2017-07-27 Thread Amador Pahim
On Tue, Jul 25, 2017 at 11:17 PM, Eduardo Habkost wrote: > On Tue, Jul 25, 2017 at 07:10:14PM +0200, Amador Pahim wrote: >> When launching a VM, if an exception happens and the VM is not >> initiated, it is useful to see the qemu command line that was executed >> and the output of that command. >>

Re: [Qemu-devel] [PATCH 2/2] s390x/css: fix bits must be zero check for TIC

2017-07-27 Thread Cornelia Huck
On Wed, 26 Jul 2017 00:44:42 +0200 Halil Pasic wrote: > According to the PoP bit positions 0-3 and 8-32 of the format-1 CCW must > contain zeros. Bits 0-3 are already covered by cmd_code validity > checking, and bit 32 is covered by the CCW address checking. > > Bits 8-31 correspond to CCW1.fla

Re: [Qemu-devel] [PATCH v1 2/5] Convert remaining error_report() to warn_report()

2017-07-27 Thread Cornelia Huck
On Wed, 26 Jul 2017 09:07:52 -0700 Alistair Francis wrote: > In a previous patch (3dc6f8693694a649a9c83f1e2746565b47683923) we > converted uses of error_report("warning:"... to use warn_report() > instead. This was to help standardise on a single method of printing > warnings to the user. > > Th

[Qemu-devel] [Bug 1706866] Re: migrate: add tls option in virsh, migrate failed

2017-07-27 Thread Thomas Huth
But then please follow this recommendation from http://www.qemu.org/contribute/report-a-bug/ : "Reproduce the problem directly with a QEMU command-line. Avoid frontends and management stacks, to ensure that the bug is in QEMU itself and not in a frontend." So can you reproduce the problem by star

Re: [Qemu-devel] [PATCH v1 4/5] Convert multi-line fprintf() to warn_report()

2017-07-27 Thread Cornelia Huck
On Wed, 26 Jul 2017 09:07:57 -0700 Alistair Francis wrote: > Convert all the multi-line uses of fprintf(stderr, "warning:"..."\n"... > to use warn_report() instead. This helps standardise on a single > method of printing warnings to the user. > > All of the warnings were changed using these comm

Re: [Qemu-devel] Improving QMP test coverage

2017-07-27 Thread Markus Armbruster
Cleber Rosa writes: > On 07/24/2017 02:56 AM, Markus Armbruster wrote: >> Test code language is orthogonal to verification method (with code >> vs. with diff). Except verifying with shell code would be obviously >> nuts[*]. >> >> The existing iotests written in Python verify with code, and the

Re: [Qemu-devel] [PATCH v5 3/6] qemu.py: cleanup message on negative exit code

2017-07-27 Thread Amador Pahim
On Tue, Jul 25, 2017 at 9:51 PM, Eduardo Habkost wrote: > On Tue, Jul 25, 2017 at 07:10:11PM +0200, Amador Pahim wrote: >> The message contains the self._args, which has only part of the >> options used in the qemu command line and is not representative >> enough to figure out what happened to the

[Qemu-devel] [Bug 1352465] Re: Can't install virtio block drivers during Windows setup

2017-07-27 Thread Thomas Huth
Looks like nobody replied here within the last three years ... closing this now, since this is not directly a QEMU problem. You should likely report it to the virtio-win driver folks instead if the problem still persists. ** Changed in: qemu Status: New => Invalid -- You received this bug

[Qemu-devel] [Bug 1610368] Re: qemu-system-x86_64 read acces DENIED in apparmor

2017-07-27 Thread Thomas Huth
** No longer affects: qemu -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1610368 Title: qemu-system-x86_64 read acces DENIED in apparmor Status in qemu package in Ubuntu: New Bug description:

Re: [Qemu-devel] [PATCH 0/2] ccw interpretation AR compliance improvements

2017-07-27 Thread Cornelia Huck
On Wed, 26 Jul 2017 00:44:40 +0200 Halil Pasic wrote: > There were some missing checks. There might be some more missing. For > details, > see the individual patches. The checks are not perfect? Colour me shocked ;) > > Regarding testing: did not do much more than a simple smoke test > with

Re: [Qemu-devel] [PULL 6/9] Convert error_report() to warn_report()

2017-07-27 Thread Markus Armbruster
Paolo Bonzini writes: > On 24/07/2017 08:30, Markus Armbruster wrote: [...] >> What's the recommended way to run all iotests a build of QEMU can run? > > I use "path-to-srcdir/tests/check-block.sh". It takes about 20 minutes. > > There are two issues with check-block: > > * tests that require QE

Re: [Qemu-devel] [PATCH 6/9] tests/libqos/pci: Clean up string interpolation into QMP input

2017-07-27 Thread Markus Armbruster
Eric Blake writes: > On 07/21/2017 08:53 AM, Markus Armbruster wrote: >> Leaving interpolation into JSON to qmp() is more robust than building >> QMP input manually, as explained in the commit before previous. >> >> The case in qpci_plug_device_test() is a bit complicated: it >> interpolates sev

Re: [Qemu-devel] [PATCH 2/2] s390x/css: fix bits must be zero check for TIC

2017-07-27 Thread Cornelia Huck
On Wed, 26 Jul 2017 00:44:42 +0200 Halil Pasic wrote: > According to the PoP bit positions 0-3 and 8-32 of the format-1 CCW must > contain zeros. Bits 0-3 are already covered by cmd_code validity > checking, and bit 32 is covered by the CCW address checking. > > Bits 8-31 correspond to CCW1.fla

[Qemu-devel] [Bug 1096714] Re: qemu 1.3.0: usb devices shouldn't have same vendor/product ID and same serial

2017-07-27 Thread Gerd Hoffmann
Try "-device usb-tablet,serial=1234" -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1096714 Title: qemu 1.3.0: usb devices shouldn't have same vendor/product ID and same serial Status in QEMU:

[Qemu-devel] [Bug 1354727] Re: build error with GCC 4.9

2017-07-27 Thread Thomas Huth
Triaging old bug tickets ... can you still reproduce this problem with the latest version of QEMU? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1

Re: [Qemu-devel] [PATCH 9/9] tests/libqtest: Enable compile-time format string checking

2017-07-27 Thread Markus Armbruster
Eric Blake writes: > On 07/21/2017 08:53 AM, Markus Armbruster wrote: >> qtest_qmp() & friends pass their format string and variable arguments >> to qobject_from_jsonv(). Unlike qobject_from_jsonv(), they aren't >> decorated with GCC_FMT_ATTR(). Fix that to get compile-time format >> string che

Re: [Qemu-devel] [SeaBIOS] Commit 77af8a2b95b79699de650965d5228772743efe84 breaks Windows 2000 support

2017-07-27 Thread Gerd Hoffmann
Hi, > > SeaBIOS is used with both modern and legacy OSes, and it doesn't > > have > > any knowledge about what kind of OS will be used.  If anything, I'd > > argue that QEMU has more knowledge about the guest OS than SeaBIOS > > does (due to command-line options like machine version). > > No, t

Re: [Qemu-devel] [PATCH 2/2] s390x/css: fix bits must be zero check for TIC

2017-07-27 Thread Dong Jia Shi
* Cornelia Huck [2017-07-27 10:32:14 +0200]: > On Wed, 26 Jul 2017 00:44:42 +0200 > Halil Pasic wrote: > > > According to the PoP bit positions 0-3 and 8-32 of the format-1 CCW must > > contain zeros. Bits 0-3 are already covered by cmd_code validity > > checking, and bit 32 is covered by the

Re: [Qemu-devel] [PULL 6/9] Convert error_report() to warn_report()

2017-07-27 Thread Kevin Wolf
Am 27.07.2017 um 10:25 hat Markus Armbruster geschrieben: > Paolo Bonzini writes: > > > On 24/07/2017 08:30, Markus Armbruster wrote: > [...] > >> What's the recommended way to run all iotests a build of QEMU can run? > > > > I use "path-to-srcdir/tests/check-block.sh". It takes about 20 minutes

Re: [Qemu-devel] [PATCH v2 1/8] usb-ccid: Add support to dump all USB packets

2017-07-27 Thread Stefan Fritsch
On Fri, 21 Jul 2017, Gerd Hoffmann wrote: > > index bef1f03c42..624dc2c447 100644 > > --- a/hw/usb/dev-smartcard-reader.c > > +++ b/hw/usb/dev-smartcard-reader.c > > @@ -54,9 +54,25 @@ do { \ > >  #define D_INFO 2 > >  #define D_MORE_INFO 3 > >  #define D_VERBOSE 4 > > +#define D_TRACE 5 > > +#def

Re: [Qemu-devel] [PATCH v2 8/8] usb-ccid: Reduce logging at level WARN

2017-07-27 Thread Stefan Fritsch
On Thu, 20 Jul 2017, Stefan Fritsch wrote: > Thanks for the review. > > On Thu, 20 Jul 2017, Marc-André Lureau wrote: > > > On Thu, Jul 20, 2017 at 11:04 AM Stefan Fritsch wrote: > > > > > From: Stefan Fritsch > > > > > > Change all DPRINTF()s using (1 == WARN) to use symbolic > > > constants

Re: [Qemu-devel] [PATCH for-2.10 0/3] qdev/vfio: defer DEVICE_DEL to avoid races with libvirt

2017-07-27 Thread Peter Maydell
On 27 July 2017 at 02:30, Michael Roth wrote: > In particular, Mellanox CX4 adapters on PowerNV hosts might not be fully > quiesced by vfio-pci's finalize() routine until up to 6s after the > DEVICE_DELETED was emitted, leading to detach-device on the libvirt side > pretty > much always crashing

Re: [Qemu-devel] [PULL 6/9] Convert error_report() to warn_report()

2017-07-27 Thread Markus Armbruster
Kevin Wolf writes: > Am 27.07.2017 um 10:25 hat Markus Armbruster geschrieben: >> Paolo Bonzini writes: >> >> > On 24/07/2017 08:30, Markus Armbruster wrote: >> [...] >> >> What's the recommended way to run all iotests a build of QEMU can run? >> > >> > I use "path-to-srcdir/tests/check-block.s

Re: [Qemu-devel] [qemu-web PATCH] Add a favicon.ico file

2017-07-27 Thread Thomas Huth
On 26.07.2017 16:54, Paolo Bonzini wrote: > On 26/07/2017 16:47, Thomas Huth wrote: >> If you're willing to maintain that "mess", sure, please go ahead! But >> please remove my SoB, I don't want to be responsible for all those files ;-) > > Changed it to suggested-by then, and pushed. :> > > Plea

Re: [Qemu-devel] Improving QMP test coverage

2017-07-27 Thread Fam Zheng
On Thu, 07/27 10:14, Markus Armbruster wrote: > This brings some advantages of "verify output with diff" to tests that > verify with code. Improvement if it simplifies the verification code. > > I'd still prefer *no* verification code (by delegating the job to diff) > for tests where I can get aw

[Qemu-devel] [Bug 1706866] Re: migrate: add tls option in virsh, migrate failed

2017-07-27 Thread chan
ok, thank you! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1706866 Title: migrate: add tls option in virsh, migrate failed Status in QEMU: Incomplete Bug description: version: libvir

Re: [Qemu-devel] [RFC PATCH v2 4/6] hw/pci: introduce bridge-only vendor-specific capability to provide some hints to firmware

2017-07-27 Thread Marcel Apfelbaum
On 27/07/2017 2:28, Michael S. Tsirkin wrote: On Thu, Jul 27, 2017 at 12:54:07AM +0300, Alexander Bezzubikov wrote: 2017-07-26 22:43 GMT+03:00 Michael S. Tsirkin : On Sun, Jul 23, 2017 at 01:15:41AM +0300, Aleksandr Bezzubikov wrote: On PCI init PCI bridges may need some extra info about bus n

Re: [Qemu-devel] [PATCH 0/3] Channel Path realted CRW generation

2017-07-27 Thread Cornelia Huck
On Thu, 27 Jul 2017 03:54:15 +0200 Dong Jia Shi wrote: > This series is trying to: > 1. clear up CRW related code. > 2. generate the right channel path related CRW at the right time. > > I did this mainly because it's a requirement from my current work, that is I'm > in preparation of a group of

[Qemu-devel] [PATCH v2 0/3] Proactive pow2floor() fix, and dead code removal

2017-07-27 Thread Markus Armbruster
Reviving a series from 2015 I dropped on the floor. My apologies. v2: * PATCH 1 (was PATCH 2): rebased, R-bys kept * PATCH 2 (was PATCH 1): rebased, commit message updated, legibility improved, R-bys dropped * PATCH 3: new Markus Armbruster (3): xbzrle: Drop unused cache_resize() host-util

[Qemu-devel] [PATCH v2 3/3] host-utils: Simplify pow2ceil()

2017-07-27 Thread Markus Armbruster
Cc: Radim Krčmář Signed-off-by: Markus Armbruster --- include/qemu/host-utils.h | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/include/qemu/host-utils.h b/include/qemu/host-utils.h index 6c6005f..5ac621c 100644 --- a/include/qemu/host-utils.h +++ b/inc

[Qemu-devel] [PATCH v2 2/3] host-utils: Proactively fix pow2floor(), switch to unsigned

2017-07-27 Thread Markus Armbruster
The function's stated contract is simple enough: "round down to the nearest power of 2". Suggests the domain is the representable numbers >= 1, because that's the smallest power of two. The implementation doesn't check for domain errors, but returns garbage instead: * For negative arguments, pow

[Qemu-devel] [PATCH v2 1/3] xbzrle: Drop unused cache_resize()

2017-07-27 Thread Markus Armbruster
Unused since commit fd8cec XBZRLE: Fix qemu crash when resize the xbzrle cache. Cc: Juan Quintela Cc: "Dr. David Alan Gilbert" Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Eric Blake Reviewed-by: Amit Shah Signed-off-by: Markus Armbruster --- migration/page_cache.c | 56

Re: [Qemu-devel] [PULL 0/3] x86 bug fix for -rc1

2017-07-27 Thread Peter Maydell
On 26 July 2017 at 19:36, Eduardo Habkost wrote: > The following changes since commit 522fd24ca030c27c591dafedd65c1dfd51e40450: > > Update version for v2.10.0-rc0 release (2017-07-25 17:13:09 +0100) > > are available in the git repository at: > > git://github.com/ehabkost/qemu.git tags/x86-pul

Re: [Qemu-devel] [PATCH 1/2] vhost-user-blk: introduce a new vhost-user-blk host device

2017-07-27 Thread Stefan Hajnoczi
On Thu, Jul 27, 2017 at 12:29:45AM +, Liu, Changpeng wrote: > > > +.fields = (VMStateField[]) { > > > +VMSTATE_VIRTIO_DEVICE, > > > +VMSTATE_END_OF_LIST() > > > +}, > > > +}; > > > + > > > +static Property vhost_user_blk_properties[] = { > > > +DEFINE_PROP_CHR("chard

Re: [Qemu-devel] [PATCH for 2.10] ps2: fix sending of PAUSE/BREAK scancodes

2017-07-27 Thread Daniel P. Berrange
On Wed, Jul 26, 2017 at 01:45:51PM +0100, Daniel P. Berrange wrote: > On Wed, Jul 26, 2017 at 02:33:10PM +0200, Gerd Hoffmann wrote: > > Hi, > > > > > FYI, after adding qcodes to the keycodemapdb, (but not having picked > > > your branch), > > > > I don't think this is a good idea. qkeycode nu

[Qemu-devel] [PATCH] tests/hmp: Fix typo in the 'chardev-send-break' test

2017-07-27 Thread Thomas Huth
testchardev2 is not a valid chardev id here. Use testchardev1 instead which has been created with chardev-add right before the 'chardev-send-break' line. And while we're at it, add the test-hmp.c file to the MAINTAINERS file, too. Signed-off-by: Thomas Huth --- MAINTAINERS | 1 + tests/test

Re: [Qemu-devel] [qemu-web PATCH] Add a favicon.ico file

2017-07-27 Thread Daniel P. Berrange
On Thu, Jul 27, 2017 at 11:24:59AM +0200, Thomas Huth wrote: > On 26.07.2017 16:54, Paolo Bonzini wrote: > > On 26/07/2017 16:47, Thomas Huth wrote: > >> If you're willing to maintain that "mess", sure, please go ahead! But > >> please remove my SoB, I don't want to be responsible for all those fil

Re: [Qemu-devel] [PATCH] tests/hmp: Fix typo in the 'chardev-send-break' test

2017-07-27 Thread Dr. David Alan Gilbert
* Thomas Huth (th...@redhat.com) wrote: > testchardev2 is not a valid chardev id here. Use testchardev1 > instead which has been created with chardev-add right before > the 'chardev-send-break' line. > And while we're at it, add the test-hmp.c file to the MAINTAINERS > file, too. > > Signed-off-by

Re: [Qemu-devel] Improving QMP test coverage

2017-07-27 Thread Fam Zheng
On Thu, 07/27 17:19, Fam Zheng wrote: > On the other hand the iotests are more difficult to debug when things go wrong s/iotests/python tests/

Re: [Qemu-devel] Improving QMP test coverage

2017-07-27 Thread Daniel P. Berrange
On Mon, Jul 24, 2017 at 08:56:50AM +0200, Markus Armbruster wrote: > Cleber Rosa writes: > > > On 07/21/2017 11:33 AM, Stefan Hajnoczi wrote: > >>> Output testing style delegates checking ouput to diff. I rather like it > >>> when text output is readily available. It is when testing QMP. A > >

Re: [Qemu-devel] [RFC] block-insert-node and block-job-delete

2017-07-27 Thread Stefan Hajnoczi
On Wed, Jul 26, 2017 at 09:23:20PM +0300, Manos Pitsidianakis wrote: > On Wed, Jul 26, 2017 at 04:12:21PM +0100, Stefan Hajnoczi wrote: > > On Wed, Jul 26, 2017 at 05:19:24PM +0300, Manos Pitsidianakis wrote: > > > This proposal follows a discussion we had with Kevin and Stefan on filter > > > node

Re: [Qemu-devel] [PATCH 1/2] vhost-user-blk: introduce a new vhost-user-blk host device

2017-07-27 Thread Liu, Changpeng
> -Original Message- > From: Stefan Hajnoczi [mailto:stefa...@redhat.com] > Sent: Thursday, July 27, 2017 5:49 PM > To: Liu, Changpeng > Cc: qemu-devel@nongnu.org; pbonz...@redhat.com; fel...@nutanix.com; > m...@redhat.com > Subject: Re: [PATCH 1/2] vhost-user-blk: introduce a new vhost-

Re: [Qemu-devel] [PATCH 1/3] s390x/css: use macro for event-information pending error recover code

2017-07-27 Thread Cornelia Huck
On Thu, 27 Jul 2017 03:54:16 +0200 Dong Jia Shi wrote: > Let's use a macro for the ERC (error recover code) when generating a > Channel Subsystem Event-information pending CRW (channel report word). Sounds reasonable. > > Signed-off-by: Dong Jia Shi > --- > hw/s390x/css.c| 2 +- >

[Qemu-devel] [PATCH] MAINTAINERS: Improve the NetBSD regex pattern

2017-07-27 Thread Thomas Huth
Currently get_maintainers.pl claims that the configure script is maintained by Kamil: $ scripts/get_maintainer.pl -f configure Kamil Rytarowski (maintainer:NETBSD) qemu-devel@nongnu.org (open list:All patches CC here) This happens because the regex pattern for the NETBSD entry triggers on eve

Re: [Qemu-devel] Improving QMP test coverage

2017-07-27 Thread Daniel P. Berrange
On Thu, Jul 27, 2017 at 05:19:57PM +0800, Fam Zheng wrote: > On Thu, 07/27 10:14, Markus Armbruster wrote: > > This brings some advantages of "verify output with diff" to tests that > > verify with code. Improvement if it simplifies the verification code. > > > > I'd still prefer *no* verificatio

Re: [Qemu-devel] [PATCH v3] docs: add qemu-block-drivers(7) man page

2017-07-27 Thread Stefan Hajnoczi
On Wed, Jul 26, 2017 at 02:09:13PM +0100, Daniel P. Berrange wrote: > On Wed, Jul 26, 2017 at 02:03:37PM +0100, Stefan Hajnoczi wrote: > > Block driver documentation is available in qemu-doc.html. It would be > > convenient to have documentation for formats, protocols, and filter > > drivers in a

Re: [Qemu-devel] [PATCH v3] docs: add qemu-block-drivers(7) man page

2017-07-27 Thread Daniel P. Berrange
On Thu, Jul 27, 2017 at 11:12:35AM +0100, Stefan Hajnoczi wrote: > On Wed, Jul 26, 2017 at 02:09:13PM +0100, Daniel P. Berrange wrote: > > On Wed, Jul 26, 2017 at 02:03:37PM +0100, Stefan Hajnoczi wrote: > > > Block driver documentation is available in qemu-doc.html. It would be > > > convenient t

Re: [Qemu-devel] [PULL 0/2] VFIO fixes for v2.10-rc1

2017-07-27 Thread Peter Maydell
On 26 July 2017 at 19:45, Alex Williamson wrote: > The following changes since commit 522fd24ca030c27c591dafedd65c1dfd51e40450: > > Update version for v2.10.0-rc0 release (2017-07-25 17:13:09 +0100) > > are available in the git repository at: > > git://github.com/awilliam/qemu-vfio.git tags/vf

Re: [Qemu-devel] [PATCH 00/13] instrument: Add basic event instrumentation

2017-07-27 Thread Stefan Hajnoczi
On Wed, Jul 26, 2017 at 03:44:39PM +0300, Lluís Vilanova wrote: > Stefan Hajnoczi writes: > > > On Tue, Jul 25, 2017 at 06:11:43PM +0300, Lluís Vilanova wrote: > >> Peter Maydell writes: > >> > >> > On 25 July 2017 at 14:19, Stefan Hajnoczi wrote: > >> >> Instead I suggest adding a trace backend

[Qemu-devel] For unix domain socket, will only one client could connect to this socket?

2017-07-27 Thread Sam
Hi all, I'm working on qemu-qga, and I want to send qmp command from this unix socket, but it hanged there(no response), I don't know if it's connect failed or something? [root@yf-mos-test-net09 ~]# socat > /opt/cloud/workspace/servers/f6fdd093-383b-444e-9bcf-dfa81794d465/qga.sock > readline > {"

Re: [Qemu-devel] [PATCH 00/13] instrument: Add basic event instrumentation

2017-07-27 Thread Peter Maydell
On 27 July 2017 at 11:32, Stefan Hajnoczi wrote: > On Wed, Jul 26, 2017 at 03:44:39PM +0300, Lluís Vilanova wrote: >> And why exactly is this a threat? Because it can be used to "extend" QEMU >> without touching its sources? Is this a realistic threat? (it's a rather >> brittle >> way to do it, s

Re: [Qemu-devel] [PATCH 00/13] instrument: Add basic event instrumentation

2017-07-27 Thread Daniel P. Berrange
On Wed, Jul 26, 2017 at 12:49:00PM +0100, Peter Maydell wrote: > On 26 July 2017 at 12:26, Stefan Hajnoczi wrote: > > On Tue, Jul 25, 2017 at 02:30:06PM +0100, Peter Maydell wrote: > >> Is your proposal that my-instrumentation.c gets compiled into > >> QEMU at this point? That doesn't seem like a

Re: [Qemu-devel] For unix domain socket, will only one client could connect to this socket?

2017-07-27 Thread Daniel P. Berrange
On Thu, Jul 27, 2017 at 06:37:32PM +0800, Sam wrote: > Hi all, > > I'm working on qemu-qga, and I want to send qmp command from this unix > socket, but it hanged there(no response), I don't know if it's connect > failed or something? > > [root@yf-mos-test-net09 ~]# socat > > /opt/cloud/workspace/

[Qemu-devel] [PATCH] ui: drop altgr and altgr_r QKeyCodes

2017-07-27 Thread Gerd Hoffmann
The right alt key (alt_r aka KEY_RIGHTALT) is used for AltGr. The altgr and altgr_r keys simply don't exist. Drop them. Signed-off-by: Gerd Hoffmann --- hw/char/escc.c| 1 - hw/input/adb.c| 1 - hw/input/ps2.c| 2 -- ui/input-keymap.c | 2 -- qapi-schema.json | 3 ++- 5 files chang

Re: [Qemu-devel] [PATCH 00/13] instrument: Add basic event instrumentation

2017-07-27 Thread Peter Maydell
On 27 July 2017 at 11:43, Daniel P. Berrange wrote: > Maybe I'm missing something, but aren't all these things > already possible via either the statically defined tracepoints > QEMU exposes, or by placing dynamic tracepoints on arbitrary > code locations using dtrace/systemtap/lttng-ust. Last ti

[Qemu-devel] [PATCH for-2.10 4/5] target/arm: Move PMSAv7 reset into arm_cpu_reset() so M profile MPUs get reset

2017-07-27 Thread Peter Maydell
When the PMSAv7 implementation was originally added it was for R profile CPUs only, and reset was handled using the cpreg .resetfn hooks. Unfortunately for M profile cores this doesn't work, because they do not register any cpregs. Move the reset handling into arm_cpu_reset(), where it will work fo

[Qemu-devel] [PATCH for-2.10 5/5] target/arm: Migrate MPU_RNR register state for M profile cores

2017-07-27 Thread Peter Maydell
The PMSAv7 region number register is migrated for R profile cores using the cpreg scheme, but M profile doesn't use cpregs, and so we weren't migrating the MPU_RNR register state at all. Fix that by adding a migration subsection for the M profile case. Signed-off-by: Peter Maydell --- target/arm

[Qemu-devel] [PATCH for-2.10 0/5] M profile MPU bugfixes

2017-07-27 Thread Peter Maydell
This patchset fixes some bugs in the M profile MPU code: * the guest shouldn't be able to make system space executable * PPB region accesses should not be subject to MPU lookups * we were not resetting the PMSAv7 MPU state for M profile CPUs * we weren't migrating the MPU_RNR state The renamin

[Qemu-devel] [PATCH for-2.10 1/5] target/arm: Don't do MPU lookups for addresses in M profile PPB region

2017-07-27 Thread Peter Maydell
The M profile PMSAv7 specification says that if the address being looked up is in the PPB region (0xe000 - 0xe00f) then we do not use the MPU regions but always use the default memory map. Implement this (we were previously behaving like an R profile PMSAv7, which does not special case this

[Qemu-devel] [PATCH for-2.10 2/5] target/arm: Don't allow guest to make System space executable for M profile

2017-07-27 Thread Peter Maydell
For an M profile v7PMSA, the system space (0xe000 - 0x) can never be executable, even if the guest tries to set the MPU registers up that way. Enforce this restriction. Signed-off-by: Peter Maydell --- target/arm/helper.c | 16 +++- 1 file changed, 15 insertions(+), 1 del

[Qemu-devel] [PATCH for-2.10 3/5] target/arm: Rename cp15.c6_rgnr to pmsav7.rnr

2017-07-27 Thread Peter Maydell
Almost all of the PMSAv7 state is in the pmsav7 substruct of the ARM CPU state structure. The exception is the region number register, which is in cp15.c6_rgnr. This exception is a bit odd for M profile, which otherwise generally does not store state in the cp15 substruct. Rename cp15.c6_rgnr to p

Re: [Qemu-devel] Status and RFC of patchew testings on QEMU

2017-07-27 Thread Fam Zheng
On Tue, 07/25 10:58, Peter Maydell wrote: > For patchew, I basically ignore patchew compile failure emails > because it is too painful to get to the bottom of the email > where the actual error message is because of the pages and > pages and pages of useless progress output :-( Isn't it very easy

Re: [Qemu-devel] Improving QMP test coverage

2017-07-27 Thread Fam Zheng
On Thu, 07/27 11:09, Daniel P. Berrange wrote: > On Thu, Jul 27, 2017 at 05:19:57PM +0800, Fam Zheng wrote: > > On Thu, 07/27 10:14, Markus Armbruster wrote: > > > This brings some advantages of "verify output with diff" to tests that > > > verify with code. Improvement if it simplifies the verifi

Re: [Qemu-devel] [PATCH 2/2] s390x/css: fix bits must be zero check for TIC

2017-07-27 Thread Halil Pasic
On 07/27/2017 10:01 AM, Cornelia Huck wrote: > On Wed, 26 Jul 2017 00:44:42 +0200 > Halil Pasic wrote: > >> According to the PoP bit positions 0-3 and 8-32 of the format-1 CCW must >> contain zeros. Bits 0-3 are already covered by cmd_code validity >> checking, and bit 32 is covered by the CCW

Re: [Qemu-devel] [PATCH 2/3] s390x/css: generate solicited crw for rchp completion signaling

2017-07-27 Thread Cornelia Huck
On Thu, 27 Jul 2017 03:54:17 +0200 Dong Jia Shi wrote: > A successful completion of rchp should signal a solicited channel path > initialized CRW (channel report word), while the current implementation > always generates an un-solicited one. Let's fix this. Sounds legit. > > Reported-by: Halil

Re: [Qemu-devel] [PATCH for 2.10 v2 04/20] nbd: fix memory leak in nbd_opt_go()

2017-07-27 Thread Eric Blake
On 07/26/2017 09:42 PM, Philippe Mathieu-Daudé wrote: > nbd/client.c:385:12: warning: Potential leak of memory pointed to by 'buf' > > Reported-by: Clang Static Analyzer > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Eric Blake > --- > nbd/client.c | 8 +--- > 1 file changed, 5 inse

Re: [Qemu-devel] Status and RFC of patchew testings on QEMU

2017-07-27 Thread Gerd Hoffmann
On Thu, 2017-07-27 at 19:03 +0800, Fam Zheng wrote: > On Tue, 07/25 10:58, Peter Maydell wrote: > > For patchew, I basically ignore patchew compile failure emails > > because it is too painful to get to the bottom of the email > > where the actual error message is because of the pages and > > pages

[Qemu-devel] [PATCH v2] ps2: fix sending of PAUSE/BREAK scancodes

2017-07-27 Thread Daniel P. Berrange
The processing of the scancodes for PAUSE/BREAK has been broken since the conversion to qcodes in: commit 8c10e0baf0260b59a4e984744462a18016662e3e Author: Hervé Poussineau Date: Thu Sep 15 22:06:26 2016 +0200 ps2: use QEMU qcodes instead of scancodes When using a VNC client, with t

Re: [Qemu-devel] [PATCH 0/2] ccw interpretation AR compliance improvements

2017-07-27 Thread Halil Pasic
On 07/27/2017 10:26 AM, Cornelia Huck wrote: > On Wed, 26 Jul 2017 00:44:40 +0200 > Halil Pasic wrote: > >> There were some missing checks. There might be some more missing. For >> details, >> see the individual patches. > > The checks are not perfect? Colour me shocked ;) > With a fedora

Re: [Qemu-devel] [PATCH] ui: drop altgr and altgr_r QKeyCodes

2017-07-27 Thread Eric Blake
On 07/27/2017 05:47 AM, Gerd Hoffmann wrote: > The right alt key (alt_r aka KEY_RIGHTALT) is used for AltGr. > The altgr and altgr_r keys simply don't exist. Drop them. > > Signed-off-by: Gerd Hoffmann > --- > +++ b/qapi-schema.json > @@ -4863,13 +4863,14 @@ > # @ac_stop: since 2.10 > # @ac_r

Re: [Qemu-devel] [RFC 26/29] vhost: Add VHOST_USER_POSTCOPY_END message

2017-07-27 Thread Maxime Coquelin
On 06/28/2017 09:00 PM, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" This message is sent just before the end of postcopy to get the client to stop using userfault since we wont respond to any more requests. It should close userfaultfd so that any other pages get mapped

Re: [Qemu-devel] [PATCH] MAINTAINERS: Improve the NetBSD regex pattern

2017-07-27 Thread Eric Blake
On 07/27/2017 05:09 AM, Thomas Huth wrote: > Currently get_maintainers.pl claims that the configure script is > maintained by Kamil: > > $ scripts/get_maintainer.pl -f configure > Kamil Rytarowski (maintainer:NETBSD) > qemu-devel@nongnu.org (open list:All patches CC here) > > This happens bec

Re: [Qemu-devel] [PATCH v3] docs: add qemu-block-drivers(7) man page

2017-07-27 Thread Kevin Wolf
Am 26.07.2017 um 15:03 hat Stefan Hajnoczi geschrieben: > Block driver documentation is available in qemu-doc.html. It would be > convenient to have documentation for formats, protocols, and filter > drivers in a man page. > > Extract the relevant part of qemu-doc.html into a new file called > do

Re: [Qemu-devel] [PATCH for 2.10 v2 18/20] 9pfs: avoid sign conversion error simplifying the code

2017-07-27 Thread Greg Kurz
On Wed, 26 Jul 2017 23:42:22 -0300 Philippe Mathieu-Daudé wrote: > (note this is how other functions also handle the errors). > > hw/9pfs/9p.c:948:18: warning: Loss of sign in implicit conversion > offset = err; > ^~~ > > Reported-by: Clang Static Analyzer > Signed-off-

Re: [Qemu-devel] [PATCH for-2.10 0/3] qdev/vfio: defer DEVICE_DEL to avoid races with libvirt

2017-07-27 Thread David Gibson
On Thu, Jul 27, 2017 at 10:11:48AM +0100, Peter Maydell wrote: > On 27 July 2017 at 02:30, Michael Roth wrote: > > In particular, Mellanox CX4 adapters on PowerNV hosts might not be fully > > quiesced by vfio-pci's finalize() routine until up to 6s after the > > DEVICE_DELETED was emitted, leading

Re: [Qemu-devel] [PULL 6/9] Convert error_report() to warn_report()

2017-07-27 Thread Max Reitz
On 2017-07-24 09:30, Paolo Bonzini wrote: [...] > * it only runs the "quick" group, but I think we should reverse the > direction and mark slow tests specifically (that would cut about 10 > minutes out of the 20). Side note: tmpfs speeds things up quite a bit. Running all qcow2 tests (except for

Re: [Qemu-devel] [PATCH for-2.10 0/3] qdev/vfio: defer DEVICE_DEL to avoid races with libvirt

2017-07-27 Thread Daniel P. Berrange
On Thu, Jul 27, 2017 at 08:53:48PM +1000, David Gibson wrote: > On Thu, Jul 27, 2017 at 10:11:48AM +0100, Peter Maydell wrote: > > On 27 July 2017 at 02:30, Michael Roth wrote: > > > In particular, Mellanox CX4 adapters on PowerNV hosts might not be fully > > > quiesced by vfio-pci's finalize() ro

Re: [Qemu-devel] [PATCH for-2.10 0/3] qdev/vfio: defer DEVICE_DEL to avoid races with libvirt

2017-07-27 Thread Michael Roth
Quoting David Gibson (2017-07-27 05:53:48) > On Thu, Jul 27, 2017 at 10:11:48AM +0100, Peter Maydell wrote: > > On 27 July 2017 at 02:30, Michael Roth wrote: > > > In particular, Mellanox CX4 adapters on PowerNV hosts might not be fully > > > quiesced by vfio-pci's finalize() routine until up to 6

Re: [Qemu-devel] For unix domain socket, will only one client could connect to this socket?

2017-07-27 Thread Sam
Thank you, I think another process connect this socket, so I hanged here. 2017-07-27 18:47 GMT+08:00 Daniel P. Berrange : > On Thu, Jul 27, 2017 at 06:37:32PM +0800, Sam wrote: > > Hi all, > > > > I'm working on qemu-qga, and I want to send qmp command from this unix > > socket, but it hanged the

Re: [Qemu-devel] [PATCH 3/3] s390x/css: generate channel path initialized CRW for channel path hotplug

2017-07-27 Thread Cornelia Huck
On Thu, 27 Jul 2017 03:54:18 +0200 Dong Jia Shi wrote: > When a channel path is hot plugged into a CSS, we should generate > a channel path initialized CRW (channel report word). The current > code does not do that, instead it puts a stub function with a TODO > reminder there. > > This implement

[Qemu-devel] [PATCH 0/5] Trivial fixes and cleanups

2017-07-27 Thread Cleber Rosa
This is a collection of trivial fixes and cleanups. The only expected behavior change is in the output on config.log, as per the first patch. Cleber Rosa(5): configure: remove duplicate single quotes on config.log qemu-iotests: get rid of _full_imgproto_details() qemu-iotests: remove commen

[Qemu-devel] [PATCH 2/5] qemu-iotests: get rid of _full_imgproto_details()

2017-07-27 Thread Cleber Rosa
Although this function is used, its implementation does nothing besides echoing a variable name. There's no need to wrap this functionality in a function, and based on the one usage it has, it's not even required to adhere to a convention or code style. Signed-off-by: Cleber Rosa --- tests/qemu

[Qemu-devel] [PATCH 1/5] configure: remove duplicate single quotes on config.log header

2017-07-27 Thread Cleber Rosa
The generation of the informational header on config.log contains two pairs of single quotes, which seems unintentional, and looks like this: # QEMU configure log Thu Jul 26 08:17:15 EDT 2017 # Configured with: './configure' '--target-list=x86_64-softmmu' With this change, the quotes comprehe

[Qemu-devel] [PATCH 5/5] docs: fix broken paths to docs/interop dir

2017-07-27 Thread Cleber Rosa
With the move of some docs to docs/interop on d59157e, a couple of references where not updated. Signed-off-by: Cleber Rosa --- docs/devel/writing-qmp-commands.txt | 2 +- qapi-schema.json| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/devel/writin

[Qemu-devel] [PATCH 3/5] qemu-iotests: remove commented out variables

2017-07-27 Thread Cleber Rosa
The variables FULL_MKFS_OPTIONS and FULL_MOUNT_OPTIONS are commented out, never used, and even refer to functions that do exist. The last time these were touched was around 8 years ago, so I guess it's safe to assume outputting such information on test execution is still on the radar. Signed-off-

[Qemu-devel] [PATCH 4/5] qemu-iotests: remove comment about root privileges requirement

2017-07-27 Thread Cleber Rosa
The check script contains a commented out root user requirement, probably because of its xfstests heritage. This requirement doesn't apply to qemu-iotests, so it better be gone. Signed-off-by: Cleber Rosa --- tests/qemu-iotests/check | 6 -- 1 file changed, 6 deletions(-) diff --git a/test

  1   2   3   4   >