Re: [Qemu-devel] [PATCH v2 5/7] kdump: add vmcoreinfo ELF note

2017-07-06 Thread Marc-André Lureau
Hi On Thu, Jul 6, 2017 at 7:13 PM, Laszlo Ersek wrote: > On 07/06/17 12:16, Marc-André Lureau wrote: >> kdump header provides offset and size of the vmcoreinfo ELF note, >> append it if available. >> >> Signed-off-by: Marc-André Lureau >> --- >> dump.c | 20 >> 1 file chang

Re: [Qemu-devel] [PATCH 0/3] Add new utility function memory_region_allocate_aux_memory()

2017-07-06 Thread Paolo Bonzini
On 06/07/2017 19:13, Peter Maydell wrote: > Slightly awkward because owner is an Object but vmstate_register_ram() > needs a DeviceState. Is this OK, or too much magic? > > DeviceState *owner_dev; > Error *err = NULL; > > memory_region_init_ram(mr, owner, name, ram_size, &err); >

Re: [Qemu-devel] [PATCH v4 20/21] block: Minimize raw use of bds->total_sectors

2017-07-06 Thread Kevin Wolf
Am 06.07.2017 um 19:03 hat Eric Blake geschrieben: > On 07/06/2017 11:48 AM, Kevin Wolf wrote: > > Am 05.07.2017 um 23:08 hat Eric Blake geschrieben: > >> bdrv_is_allocated_above() was relying on intermediate->total_sectors, > >> which is a field that can have stale contents depending on the value

Re: [Qemu-devel] [PATCH v2 6/7] scripts/dump-guest-memory.py: add vmcoreinfo

2017-07-06 Thread Laszlo Ersek
On 07/06/17 12:16, Marc-André Lureau wrote: > Add vmcoreinfo ELF note if vmcoreinfo device is ready. > > To help the python script, add a little global vmcoreinfo_gdb > structure, that is populated with vmcoreinfo_gdb_update(). > > Signed-off-by: Marc-André Lureau > --- > scripts/dump-guest-mem

Re: [Qemu-devel] [PATCH v3 2/6] block: Add VFIO based NVMe driver

2017-07-06 Thread Keith Busch
On Wed, Jul 05, 2017 at 09:36:31PM +0800, Fam Zheng wrote: > This is a new protocol driver that exclusively opens a host NVMe > controller through VFIO. It achieves better latency than linux-aio by > completely bypassing host kernel vfs/block layer. > > $rw-$bs-$iodepth linux-aio nvme://

Re: [Qemu-devel] [PATCH v5 0/4] Introduce vhost-user-scsi and sample application

2017-07-06 Thread Harris, James R
> On Jul 6, 2017, at 10:06 AM, Paolo Bonzini wrote: > > > > On 06/07/2017 19:03, Harris, James R wrote: >> >> vhost-user-blk: >> >> We have an initial implementation in our SPDK QEMU repo. Changpeng Liu >> (added) >> will be sending this to the QEMU mailing list shortly. If you are >> in

Re: [Qemu-devel] [PATCH v5 0/4] Introduce vhost-user-scsi and sample application

2017-07-06 Thread Harris, James R
> On Jul 6, 2017, at 10:11 AM, Marc-André Lureau > wrote: > > Hi > > - Original Message - >> >>> On Jul 6, 2017, at 9:56 AM, Paolo Bonzini wrote: >>> >>> >>> >>> On 06/07/2017 18:54, Harris, James R wrote: Hi Michael, Yes - we (SPDK team at Intel) have this on our

Re: [Qemu-devel] [PATCH 0/3] Add new utility function memory_region_allocate_aux_memory()

2017-07-06 Thread Peter Maydell
On 6 July 2017 at 18:26, Paolo Bonzini wrote: > > > On 06/07/2017 19:13, Peter Maydell wrote: >> Slightly awkward because owner is an Object but vmstate_register_ram() >> needs a DeviceState. Is this OK, or too much magic? >> >> DeviceState *owner_dev; >> Error *err = NULL; >> >> memor

Re: [Qemu-devel] [PATCH 12/17] migration: add postcopy migration of dirty bitmaps

2017-07-06 Thread John Snow
On 07/06/2017 04:05 AM, Vladimir Sementsov-Ogievskiy wrote: > 06.07.2017 00:46, John Snow wrote: >> >> On 07/05/2017 05:24 AM, Vladimir Sementsov-Ogievskiy wrote: >>> 16.02.2017 16:04, Fam Zheng wrote: > +dbms->node_name = bdrv_get_node_name(bs); > +if (!dbms->node

Re: [Qemu-devel] [PATCH v7 2/6] qmp: Create IOThrottle structure

2017-07-06 Thread Markus Armbruster
Pradeep Jagadeesh writes: > This patch enables qmp interfaces for the fsdev > devices. This provides two interfaces one > for querying info of all the fsdev devices. The second one > to set the IO limits for the required fsdev device. > > Signed-off-by: Pradeep Jagadeesh > Reviewed-by: Greg Kur

Re: [Qemu-devel] [PATCH v2 5/7] kdump: add vmcoreinfo ELF note

2017-07-06 Thread Dave Anderson
- Original Message - > Hi > > On Thu, Jul 6, 2017 at 7:13 PM, Laszlo Ersek wrote: > > On 07/06/17 12:16, Marc-André Lureau wrote: > >> kdump header provides offset and size of the vmcoreinfo ELF note, > >> append it if available. > >> > >> Signed-off-by: Marc-André Lureau > >> --- > >>

Re: [Qemu-devel] [PATCH v5 2/2] live-block-ops.txt: Rename, rewrite, and improve it

2017-07-06 Thread Kashyap Chamarthy
On Thu, Jul 06, 2017 at 04:36:46PM +0200, Kashyap Chamarthy wrote: > This patch documents (including their QMP invocations) all the four > major kinds of live block operations: [...] > (cherry picked from commit aef3e734f2d30b97e29345943d9e1cab794d0846) Oops, the above "cherry picked" line is ac

Re: [Qemu-devel] [PATCH v7 5/6] fsdev: hmp interface for throttling

2017-07-06 Thread Markus Armbruster
Pradeep Jagadeesh writes: > This patch introduces hmp interfaces for the fsdev > devices. > > Signed-off-by: Pradeep Jagadeesh Fails to compile, first error: /work/armbru/qemu/hmp.c: In function ‘hmp_fsdev_set_io_throttle’: /work/armbru/qemu/hmp.c:1791:5: warning: implicit declaration of funct

Re: [Qemu-devel] [PATCH v2.1 3/4] doc: add item for "-M enforce-config-section"

2017-07-06 Thread Eduardo Habkost
On Thu, Jul 06, 2017 at 10:08:41AM +0800, Peter Xu wrote: > It's never documented, and now we have one more parameter for it (which > obsoletes this one). Document it properly. > > Although now when enforce-config-section is set, it'll override the > other "-global" parameter, that is not necessar

Re: [Qemu-devel] [RFC v3 2/3] qemu-error: Implement a more generic error reporting

2017-07-06 Thread Alistair Francis
On Thu, Jul 6, 2017 at 7:44 AM, Markus Armbruster wrote: > "Daniel P. Berrange" writes: > >> On Thu, Jul 06, 2017 at 02:20:51PM +0200, Markus Armbruster wrote: >>> "Daniel P. Berrange" writes: >>> >>> > On Thu, Jul 06, 2017 at 01:27:15PM +0200, Markus Armbruster wrote: >>> >> "Daniel P. Berrange

Re: [Qemu-devel] [PATCH v7 6/6] fsdev: QMP interface for throttling

2017-07-06 Thread Markus Armbruster
Pradeep Jagadeesh writes: > This patch introduces qmp interfaces for the fsdev > devices. This provides two interfaces one > for querying info of all the fsdev devices. The second one > to set the IO limits for the required fsdev device. > > Signed-off-by: Pradeep Jagadeesh > --- > Makefile

Re: [Qemu-devel] [PATCH 0/5] hostmem-file: Add "persistent" option

2017-07-06 Thread Eduardo Habkost
On Wed, Jun 14, 2017 at 05:29:55PM -0300, Eduardo Habkost wrote: > This series adds a new "persistent" option to > memory-backend-file. The new option it will be useful if > somebody is sharing RAM contents on a file using share=on, but > don't need it to be flushed to disk when QEMU exits. > > I

Re: [Qemu-devel] [PATCH v2 5/7] kdump: add vmcoreinfo ELF note

2017-07-06 Thread Laszlo Ersek
On 07/06/17 20:09, Dave Anderson wrote: > > > - Original Message - >> Hi >> >> On Thu, Jul 6, 2017 at 7:13 PM, Laszlo Ersek wrote: >>> On 07/06/17 12:16, Marc-André Lureau wrote: kdump header provides offset and size of the vmcoreinfo ELF note, append it if available.

[Qemu-devel] [PATCH v2] Python3 Support for qmp.py

2017-07-06 Thread Ishani Chugh
This patch intends to make qmp.py compatible with both python2 and python3. * Python 3 does not have dict.has_key(key), use key in dict instead * Avoid line-based I/O since Python 2/3 have different character encoding behavior. Explicitly encode/decode JSON UTF-8. * Replace print by print f

[Qemu-devel] [PATCH v2 1/1] util/aio-win32: Only select on what we are actually waiting for

2017-07-06 Thread Alistair Francis
Signed-off-by: Alistair Francis Acked-by: Edgar E. Iglesias Reviewed-by: Philippe Mathieu-Daudé --- Changes in V2: - Rebase on master Changes since RFC: - Include more bitmasks for the select call util/aio-win32.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --g

Re: [Qemu-devel] [PATCH 09/22] monitor: disable "info jit" and "info opcount" if !TCG

2017-07-06 Thread Emilio G. Cota
On Tue, Jul 04, 2017 at 13:12:02 +0200, Paolo Bonzini wrote: > Reviewed-by: Richard Henderson > Signed-off-by: Paolo Bonzini > --- > accel/tcg/translate-all.c | 5 + > hmp-commands-info.hx | 4 > monitor.c | 2 ++ > 3 files changed, 11 insertions(+) > > diff --git

Re: [Qemu-devel] [PATCH 4/9] target-mips: Check memory permissions with mem_idx

2017-07-06 Thread James Hogan
On Fri, Oct 07, 2016 at 04:48:31PM +0100, Yongbok Kim wrote: > On 06/09/2016 12:03, James Hogan wrote: > > diff --git a/target-mips/helper.c b/target-mips/helper.c > > index 29ebf391cb94..2065fc3ec119 100644 > > --- a/target-mips/helper.c > > +++ b/target-mips/helper.c > > @@ -413,11 +413,12 @@ st

Re: [Qemu-devel] [PATCH 5/9] target-mips: Abstract mmu_idx from hflags

2017-07-06 Thread James Hogan
On Fri, Oct 07, 2016 at 05:08:46PM +0100, Yongbok Kim wrote: > On 06/09/2016 12:03, James Hogan wrote: > > The MIPS mmu_idx is sometimes calculated from hflags without an env > > pointer available as cpu_mmu_index() requires. > > > > Create a common hflags_mmu_index() for the purpose of this calcu

Re: [Qemu-devel] [PATCH 6/9] target-mips: Add an MMU mode for ERL

2017-07-06 Thread James Hogan
On Thu, Oct 13, 2016 at 02:18:31PM +0100, Yongbok Kim wrote: > > > On 06/09/2016 12:03, James Hogan wrote: > > The segmentation control feature allows a legacy memory segment to > > become unmapped uncached at error level (according to CP0_Status.ERL), > > and in fact the user segment is already

Re: [Qemu-devel] [RFC v2 0/8] VIRTIO-IOMMU device

2017-07-06 Thread Auger Eric
Hello Bharat, Jean-Philippe, On 06/07/2017 12:02, Jean-Philippe Brucker wrote: > On 05/07/17 09:49, Bharat Bhushan wrote:>>> Also when setup msi-route > kvm_irqchip_add_msi_route() we needed to >>> provide the translated address. According to my understanding this is required because kernel do

Re: [Qemu-devel] [RFC v2 0/8] VIRTIO-IOMMU device

2017-07-06 Thread Auger Eric
Hi Bharat, On 06/07/2017 13:24, Bharat Bhushan wrote: > > >> -Original Message- >> From: Jean-Philippe Brucker [mailto:jean-philippe.bruc...@arm.com] >> Sent: Thursday, July 06, 2017 3:33 PM >> To: Bharat Bhushan ; Auger Eric >> ; eric.auger@gmail.com; >> peter.mayd...@linaro.org; al

Re: [Qemu-devel] [Qemu-block] [PATCH] iscsi: use scsi_create_task()

2017-07-06 Thread John Snow
On 06/07/2017 02:35 AM, Marc-André Lureau wrote: > The function does the same initialization, and matches with > scsi_free_scsi_task() usage, and qemu doesn't need to know the > allocator details. > Happy month-iversary for this patch! Yeah, uh, we should probably not be reaching into this stru

Re: [Qemu-devel] [Qemu-block] [PATCH] iscsi: use scsi_create_task()

2017-07-06 Thread Paolo Bonzini
On 06/07/2017 23:37, John Snow wrote: > > On 06/07/2017 02:35 AM, Marc-André Lureau wrote: >> The function does the same initialization, and matches with >> scsi_free_scsi_task() usage, and qemu doesn't need to know the >> allocator details. >> > > Happy month-iversary for this patch! > > Yeah,

Re: [Qemu-devel] [PATCH 7/9] target-mips: Add segmentation control registers

2017-07-06 Thread James Hogan
On Mon, Oct 10, 2016 at 03:57:08PM +0100, Yongbok Kim wrote: > > > On 06/09/2016 12:03, James Hogan wrote: > > The optional segmentation control registers CP0_SegCtl0, CP0_SegCtl1 & > > CP0_SegCtl2 control the behaviour and required privilege of the legacy > > virtual memory segments. > > > > Ad

Re: [Qemu-devel] [Qemu-block] [PATCH] iscsi: use scsi_create_task()

2017-07-06 Thread Paolo Bonzini
> Drats, backwards compatibility gets me again. > > I guess it should become a comment in the code that explains why we > cannot use the lib function for it? Or take Marc-André's patch and copy the (fixed) function into QEMU. > Tch, just trying to keep backlogged qemu-block patches from falling

Re: [Qemu-devel] [PATCH v5 2/2] live-block-ops.txt: Rename, rewrite, and improve it

2017-07-06 Thread John Snow
On 07/06/2017 10:36 AM, Kashyap Chamarthy wrote: > This patch documents (including their QMP invocations) all the four > major kinds of live block operations: > > - `block-stream` > - `block-commit` > - `drive-mirror` (& `blockdev-mirror`) > - `drive-backup` (& `blockdev-backup`) > > Th

Re: [Qemu-devel] [PATCH v4 02/17] hbitmap: Rename serialization_granularity to serialization_align

2017-07-06 Thread John Snow
On 07/03/2017 11:10 AM, Eric Blake wrote: > The only client of hbitmap_serialization_granularity() is dirty-bitmap's > bdrv_dirty_bitmap_serialization_align(). Keeping the two names consistent > is worthwhile, and the shorter name is more representative of what the > function returns (the requir

Re: [Qemu-devel] [PATCH v2 1/1] util/aio-win32: Only select on what we are actually waiting for

2017-07-06 Thread Paolo Bonzini
Looks good, but I noticed now that you may want to do that for qio_channel_create_socket_watch too. Paolo - Original Message - > From: "Alistair Francis" > To: qemu-devel@nongnu.org, stefa...@redhat.com, f...@redhat.com > Cc: "alistair francis" , alistai...@gmail.com, > "edgar iglesias"

Re: [Qemu-devel] [PATCH v4 03/17] qcow2: Ensure bitmap serialization is aligned

2017-07-06 Thread John Snow
On 07/03/2017 11:10 AM, Eric Blake wrote: > When subdividing a bitmap serialization, the code in hbitmap.c > enforces that start/count parameters are aligned (except that > count can end early at end-of-bitmap). We exposed this required > alignment through bdrv_dirty_bitmap_serialization_align()

Re: [Qemu-devel] [PATCH 8/9] target-mips: Implement segmentation control

2017-07-06 Thread James Hogan
On Thu, Oct 13, 2016 at 02:06:25PM +0100, Yongbok Kim wrote: > > > On 06/09/2016 12:03, James Hogan wrote: > > Implement the optional segmentation control feature in the virtual to > > physical address translation code. > > > > The fixed legacy segment and XKPhys handling is replaced with a dyna

Re: [Qemu-devel] [PATCH v3 2/6] block: Add VFIO based NVMe driver

2017-07-06 Thread Fam Zheng
On Thu, 07/06 13:38, Keith Busch wrote: > On Wed, Jul 05, 2017 at 09:36:31PM +0800, Fam Zheng wrote: > > This is a new protocol driver that exclusively opens a host NVMe > > controller through VFIO. It achieves better latency than linux-aio by > > completely bypassing host kernel vfs/block layer. >

Re: [Qemu-devel] [Qemu-arm] [RFC v2 0/8] VIRTIO-IOMMU device

2017-07-06 Thread Michael S. Tsirkin
On Thu, Jul 06, 2017 at 11:23:41PM +, Kalra, Ashish wrote: > I have a generic question on vIOMMU support, is there any proposal/plan to > add ATS/PRI extension support to vIOMMUs and allow > handling for end to end (v)IOMMU Page faults (w/t the device side > implementation on Vhost) ? > > Ag

Re: [Qemu-devel] [Qemu-arm] [RFC v2 0/8] VIRTIO-IOMMU device

2017-07-06 Thread Tian, Kevin
> From: Kalra, Ashish [mailto:ashish.ka...@cavium.com] > Sent: Friday, July 7, 2017 7:24 AM > > I have a generic question on vIOMMU support, is there any proposal/plan to > add ATS/PRI extension support to vIOMMUs and allow > handling for end to end (v)IOMMU Page faults (w/t the device side > impl

Re: [Qemu-devel] [PATCH v2] xenfb: remove xen_init_display "temporary" hack

2017-07-06 Thread Stefano Stabellini
On Thu, 29 Jun 2017, Paul Durrant wrote: > > -Original Message- > > From: Stefano Stabellini [mailto:sstabell...@kernel.org] > > Sent: 28 June 2017 19:37 > > To: xen-de...@lists.xenproject.org; qemu-devel@nongnu.org > > Cc: sstabell...@kernel.org; peter.mayd...@linaro.org; Anthony Perard >

Re: [Qemu-devel] [PATCH v4 04/17] dirty-bitmap: Drop unused functions

2017-07-06 Thread John Snow
On 07/03/2017 11:10 AM, Eric Blake wrote: > We had several functions that no one is currently using, and which > use sector-based interfaces. I'm trying to convert towards byte-based > interfaces, so it's easier to just drop the unused functions: > > bdrv_dirty_bitmap_get_meta > bdrv_dirty_bitm

[Qemu-devel] [PATCH v3] xenfb: remove xen_init_display "temporary" hack

2017-07-06 Thread Stefano Stabellini
Initialize xenfb properly, as all other backends, from its own "initialise" function. Remove the dependency of vkbd on vfb: use qemu_console_lookup_by_index to find the principal console (to get the size of the screen) instead of relying on a vfb backend to be available (which adds a dependency be

Re: [Qemu-devel] [RFC v1 0/4] Windows runtime improvements

2017-07-06 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [RFC v1 0/4] Windows runtime improvements Message-id: cover.1498607452.git.alistair.fran...@xilinx.com

Re: [Qemu-devel] [PATCH v3 0/2] main_loop: Make main_loop_wait() return void

2017-07-06 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH v3 0/2] main_loop: Make main_loop_wait() return void Message-id: 1498584769-12439-1-git-send-ema

Re: [Qemu-devel] [RFC PATCH 0/8] removal of tci (tcg interpreter)

2017-07-06 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [RFC PATCH 0/8] removal of tci (tcg interpreter) Message-id: 20170629010300.2848-1-f4...@amsat.org Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git

Re: [Qemu-devel] [PATCH v1 0/3] Some armv7m fixes

2017-07-06 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH v1 0/3] Some armv7m fixes Message-id: 1498728533-23160-1-git-send-email-frederic.kon...@adacore.c

Re: [Qemu-devel] [PATCH 0/2] Pending MTTCG patches

2017-07-06 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH 0/2] Pending MTTCG patches Message-id: 20170629071129.29362-1-bobby.pr...@gmail.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --on

Re: [Qemu-devel] [PATCH] target/ppc: Only set PCR in kvm if actually in a compat mode

2017-07-06 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] target/ppc: Only set PCR in kvm if actually in a compat mode Message-id: 20170629045940.11242-1-sjitindarsi...@gmail.com Type: series === TEST SCRIPT BEGIN === #!/bin/b

Re: [Qemu-devel] [PATCH V2 0/8] add Qcow2 compress format extension

2017-07-06 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH V2 0/8] add Qcow2 compress format extension Message-id: 1498733831-15254-1-git-send-email...@kamp.de Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 tot

Re: [Qemu-devel] [PATCH 0/3] Qemu: Add Xen vIOMMU interrupt remapping function support

2017-07-06 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH 0/3] Qemu: Add Xen vIOMMU interrupt remapping function support Message-id: 1498715394-16402-1-git-send-email-tianyu@intel.com Type: series === TEST SCRIPT BEGIN ===

Re: [Qemu-devel] [PATCH] replace struct ucontext with ucontext_t type

2017-07-06 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH] replace struct ucontext with ucontext_t type Message-id: 20170628204452.41230-1-raj.k...@gmail.c

Re: [Qemu-devel] [PATCH] qom: enforce readonly nature of link's check callback

2017-07-06 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] qom: enforce readonly nature of link's check callback Message-id: 1498734863-164338-1-git-send-email-imamm...@redhat.com Type: series === TEST SCRIPT BEGIN === #!/bin/b

[Qemu-devel] [PATCH v1 1/6] util/qemu-error: Rename error_print_loc() to be more generic

2017-07-06 Thread Alistair Francis
Rename the error_print_loc() function in preparation for using it to print warnings as well. Signed-off-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- util/qemu-error.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/util/qemu-err

[Qemu-devel] [PATCH v1 4/6] char-socket: Report TCP socket waiting as information

2017-07-06 Thread Alistair Francis
When QEMU is waiting for a TCP socket connection it reports that message as an error. This isn't an error it is just information so let's change the report to use info_report() instead. Signed-off-by: Alistair Francis Reviewed-by: Thomas Huth --- chardev/char-socket.c | 4 ++-- 1 file changed,

Re: [Qemu-devel] [PATCH v2] docs: add qemu-block-drivers(7) man page

2017-07-06 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH v2] docs: add qemu-block-drivers(7) man page Message-id: 20170627154120.20346-1-stefa...@redhat.c

Re: [Qemu-devel] [PATCH v2 00/11] Block layer thread-safety, part 2

2017-07-06 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v2 00/11] Block layer thread-safety, part 2 Message-id: 20170629132749.997-1-pbonz...@redhat.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$

[Qemu-devel] [PATCH v1 5/6] error: Implement the warn and free Error functions

2017-07-06 Thread Alistair Francis
Implement warn_report_err() and warn_reportf_err() functions which are the same as the error_report_err() and error_reportf_err() functions except report a warning instead of an error. Signed-off-by: Alistair Francis --- include/qapi/error.h | 11 +++ scripts/checkpatch.pl | 1 + util

Re: [Qemu-devel] [PATCH] block: fix bs->file leak in bdrv_new_open_driver()

2017-07-06 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] block: fix bs->file leak in bdrv_new_open_driver() Message-id: 20170629060300.29869-1-el13...@mail.ntua.gr Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base

[Qemu-devel] [PATCH v1 6/6] Convert error_report*_err() to warn_report*_err()

2017-07-06 Thread Alistair Francis
Convert all uses of error_report*_err("[Ww]arning:"... to use warn_report*_err() instead. This helps standardise on a single method of printing warnings to the user. Signed-off-by: Alistair Francis Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Cc: "Michael S. Tsirkin" --- hw/c

Re: [Qemu-devel] [PATCH v2] docs: add qemu-block-drivers(7) man page

2017-07-06 Thread Fam Zheng
On Thu, 07/06 16:48, no-re...@patchew.org wrote: > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > fatal: unable to access 'https://github.com/patchew-project/qemu/': Could not > resolve host: github.com > error: Could not fetch 3c8cf5a9c21ff8782164d1def7f44bd888713384 > Traceback (most recent

[Qemu-devel] [PATCH v1 0/6] Implement a warning_report function

2017-07-06 Thread Alistair Francis
QEMU currently has a standard method to report errors with error_repot(). This ensure a sane and standard format when printing errors. This series is attempting to extend this functionality for warnings and information as well. This patch renames error_print_loc() function to be more clear, but I

[Qemu-devel] [PATCH v1 2/6] error: Functions to report warnings and informational messages

2017-07-06 Thread Alistair Francis
Add warn_report(), warn_vreport() for reporting warnings, and info_report(), info_vreport() for informational messages. These are implemented them with a helper function factored out of error_vreport(), suitably generalized. As we don't regard error messages as a stable API the original error mess

Re: [Qemu-devel] [PATCH] qom: enforce readonly nature of link's check callback

2017-07-06 Thread Fam Zheng
On Thu, 07/06 16:50, no-re...@patchew.org wrote: > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > fatal: Cannot update paths and switch to branch 'test' at the same time. > Did you intend to checkout > 'origin/patchew/1498734863-164338-1-git-send-email-imamm...@redhat.com' which > can not be

Re: [Qemu-devel] [PATCH 0/2] Pending MTTCG patches

2017-07-06 Thread Fam Zheng
On Thu, 07/06 16:49, no-re...@patchew.org wrote: > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > fatal: Cannot update paths and switch to branch 'test' at the same time. > Did you intend to checkout > 'origin/patchew/20170629071129.29362-1-bobby.pr...@gmail.com' which can not > be resolved

Re: [Qemu-devel] [PATCH] replace struct ucontext with ucontext_t type

2017-07-06 Thread Fam Zheng
On Thu, 07/06 16:49, no-re...@patchew.org wrote: > Hi, > > This series failed automatic build test. Please find the testing commands and > their output below. If you have docker installed, you can probably reproduce > it > locally. > > Subject: [Qemu-devel] [PATCH] replace struct ucontext with u

Re: [Qemu-devel] [PATCH V2 0/8] add Qcow2 compress format extension

2017-07-06 Thread Fam Zheng
On Thu, 07/06 16:49, no-re...@patchew.org wrote: > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Subject: [Qemu-devel] [PATCH V2 0/8] add Qcow2 compress format extension > Message-id: 1498733831-15254-1-git-send-email...@kamp.de > Type:

[Qemu-devel] [PATCH v1 3/6] Convert error_report() to warn_report()

2017-07-06 Thread Alistair Francis
Convert all uses of error_report("[Ww]arning:"... to use warn_report() instead. This helps standardise on a single method of printing warnings to the user. All of the warnings were found using this regex expression: error_report.*[Ww]arning: and replaced with: warn_report(" Signed-off-by:

Re: [Qemu-devel] [PATCH v3 0/2] main_loop: Make main_loop_wait() return void

2017-07-06 Thread Fam Zheng
On Thu, 07/06 16:48, no-re...@patchew.org wrote: > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > fatal: Cannot update paths and switch to branch 'test' at the same time. > Did you intend to checkout > 'origin/patchew/1498584769-12439-1-git-send-email-peter.mayd...@linaro.org' > which can no

Re: [Qemu-devel] [PATCH] target/ppc: Only set PCR in kvm if actually in a compat mode

2017-07-06 Thread Fam Zheng
On Thu, 07/06 16:49, no-re...@patchew.org wrote: > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > fatal: Cannot update paths and switch to branch 'test' at the same time. > Did you intend to checkout > 'origin/patchew/20170629045940.11242-1-sjitindarsi...@gmail.com' which can > not be resolv

Re: [Qemu-devel] [RFC PATCH 0/8] removal of tci (tcg interpreter)

2017-07-06 Thread Fam Zheng
On Thu, 07/06 16:49, no-re...@patchew.org wrote: > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > fatal: Cannot update paths and switch to branch 'test' at the same time. > Did you intend to checkout > 'origin/patchew/20170629010300.2848-1-f4...@amsat.org' which can not be > resolved as comm

Re: [Qemu-devel] [PATCH 0/3] Qemu: Add Xen vIOMMU interrupt remapping function support

2017-07-06 Thread Fam Zheng
On Thu, 07/06 16:50, no-re...@patchew.org wrote: > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Subject: [Qemu-devel] [PATCH 0/3] Qemu: Add Xen vIOMMU interrupt remapping > function support > Message-id: 1498715394-16402-1-git-send-em

Re: [Qemu-devel] [RFC v1 0/4] Windows runtime improvements

2017-07-06 Thread Fam Zheng
On Thu, 07/06 16:48, no-re...@patchew.org wrote: > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > fatal: Cannot update paths and switch to branch 'test' at the same time. > Did you intend to checkout > 'origin/patchew/cover.1498607452.git.alistair.fran...@xilinx.com' which can > not be resol

Re: [Qemu-devel] [PATCH v1 0/3] Some armv7m fixes

2017-07-06 Thread Fam Zheng
On Thu, 07/06 16:49, no-re...@patchew.org wrote: > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > fatal: Cannot update paths and switch to branch 'test' at the same time. > Did you intend to checkout > 'origin/patchew/1498728533-23160-1-git-send-email-frederic.kon...@adacore.com' > which can

Re: [Qemu-devel] [PATCH] block: fix bs->file leak in bdrv_new_open_driver()

2017-07-06 Thread Fam Zheng
On Thu, 07/06 16:49, no-re...@patchew.org wrote: > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > fatal: Cannot update paths and switch to branch 'test' at the same time. > Did you intend to checkout > 'origin/patchew/20170629060300.29869-1-el13...@mail.ntua.gr' which can not be > resolved a

Re: [Qemu-devel] [PATCH v2 00/11] Block layer thread-safety, part 2

2017-07-06 Thread Fam Zheng
On Thu, 07/06 16:50, no-re...@patchew.org wrote: > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > fatal: Cannot update paths and switch to branch 'test' at the same time. > Did you intend to checkout > 'origin/patchew/20170629132749.997-1-pbonz...@redhat.com' which can not be > resolved as c

Re: [Qemu-devel] [RFC PATCH 00/11] Block layer thread-safety, next part

2017-07-06 Thread Fam Zheng
On Thu, 07/06 16:48, no-re...@patchew.org wrote: > fatal: Cannot update paths and switch to branch 'test' at the same time. > Did you intend to checkout > 'origin/patchew/20170706163828.24082-1-pbonz...@redhat.com' which can not be > resolved as commit? > Traceback (most recent call last): > Fi

[Qemu-devel] [Bug 1702798] [NEW] colo: secondary vm can't receive any packet

2017-07-06 Thread pork-prince
Public bug reported: Following document 'COLO-FT.txt', I test colo feature on my hosts. It seems goes well,but I found the secondary vm can't receive any packets. I attached the process and find out the reason as follow, the filter-redirector(red0) didn't flush it's queue because the secondary

Re: [Qemu-devel] [PATCH v1 3/6] Convert error_report() to warn_report()

2017-07-06 Thread David Gibson
On Thu, Jul 06, 2017 at 04:49:44PM -0700, Alistair Francis wrote: > Convert all uses of error_report("[Ww]arning:"... to use warn_report() > instead. This helps standardise on a single method of printing warnings > to the user. > > All of the warnings were found using this regex expression: >

Re: [Qemu-devel] [Qemu-arm] [RFC v2 0/8] VIRTIO-IOMMU device

2017-07-06 Thread Kalra, Ashish
I have a generic question on vIOMMU support, is there any proposal/plan to add ATS/PRI extension support to vIOMMUs and allow handling for end to end (v)IOMMU Page faults (w/t the device side implementation on Vhost) ? Again, the motivation will be to do DMA on paged guest memory and potentially

Re: [Qemu-devel] [PATCH v1 3/6] Convert error_report() to warn_report()

2017-07-06 Thread Peter.Chubb
> "Alistair" == Alistair Francis writes: Alistair> Convert all uses of error_report("[Ww]arning:"... to use Alistair> warn_report() instead. This helps standardise on a single Alistair> method of printing warnings to the user. In a number of cases the initial double quote has been removed as

[Qemu-devel] [Bug 1702798] Re: colo: secondary vm can't receive any packet

2017-07-06 Thread pork-prince
The qemu version is 2.9.0 release. The secondary vm state make me confused. I tried to add vm_stop and vm_start in colo_process_incoming_thread function, but it crashed. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.la

[Qemu-devel] [PATCH v2 00/27] target/sh4 improvements

2017-07-06 Thread Richard Henderson
This fixes two problems with atomic operations on sh4, including an attempt at supporting the user-space atomics technique used by most sh-linux-user binaries. Changes since v1: * Rebase on Aurelien's recent sh4 patchset. * Patch 3,5 split out of patch 6. * Patch 4 fixes the sh4-softmmu prob

[Qemu-devel] [PATCH v2 02/27] target/sh4: Consolidate end-of-TB tests

2017-07-06 Thread Richard Henderson
We can fold 3 different tests within the decode loop into a more accurate computation of max_insns to start. Signed-off-by: Richard Henderson --- target/sh4/translate.c | 29 + 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/target/sh4/translate.c b/ta

[Qemu-devel] [PATCH v2 01/27] target/sh4: Use cmpxchg for movco

2017-07-06 Thread Richard Henderson
As for other targets, cmpxchg isn't quite right for ll/sc, suffering from an ABA race, but is sufficient to implement portable atomic operations. Signed-off-by: Richard Henderson --- target/sh4/cpu.h | 3 ++- target/sh4/translate.c | 56 +-

[Qemu-devel] [PATCH v2 07/27] target/sh4: Recognize common gUSA sequences

2017-07-06 Thread Richard Henderson
For many of the sequences produced by gcc or glibc, we can translate these as host atomic operations. Which saves the need to acquire the exclusive lock. Signed-off-by: Richard Henderson --- target/sh4/translate.c | 316 + 1 file changed, 316 inser

[Qemu-devel] [PATCH v2 05/27] target/sh4: Adjust TB_FLAG_PENDING_MOVCA

2017-07-06 Thread Richard Henderson
Don't leave an unused bit after DELAY_SLOT_MASK. Signed-off-by: Richard Henderson --- target/sh4/cpu.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/sh4/cpu.h b/target/sh4/cpu.h index 6d179a7..da31805 100644 --- a/target/sh4/cpu.h +++ b/target/sh4/cpu.h @@ -96,

[Qemu-devel] [PATCH v2 03/27] target/sh4: Introduce TB_FLAG_ENVFLAGS_MASK

2017-07-06 Thread Richard Henderson
We'll be putting more things into this bitmask soon. Let's have a name that covers all possible uses. Signed-off-by: Richard Henderson --- target/sh4/cpu.h | 4 +++- target/sh4/translate.c | 4 ++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/target/sh4/cpu.h b/target/sh

[Qemu-devel] [PATCH v2 09/27] linux-user/sh4: Clean env->flags on signal boundaries

2017-07-06 Thread Richard Henderson
If a signal is delivered during the execution of a delay slot, or a gUSA region, clear those bits from the environment so that the signal handler does not start in that same state. Cleaning the bits on signal return is paranoid good sense. Signed-off-by: Richard Henderson --- linux-user/signal.

[Qemu-devel] [PATCH v2 10/27] target/sh4: Hoist register bank selection

2017-07-06 Thread Richard Henderson
Compute which register bank to use once at the start of translation. Signed-off-by: Richard Henderson --- target/sh4/translate.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/target/sh4/translate.c b/target/sh4/translate.c index 73b3e02..0ac101e 1006

[Qemu-devel] [PATCH v2 04/27] target/sh4: Keep env->flags clean

2017-07-06 Thread Richard Henderson
If we mask off any out-of-band bits before we assign to the variable, then we don't need to clean it up when reading. Signed-off-by: Richard Henderson --- target/sh4/cpu.h | 2 +- target/sh4/cpu.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target/sh4/cpu.h b/target/sh

[Qemu-devel] [PATCH v2 14/27] target/sh4: Eliminate unused XREG macro

2017-07-06 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sh4/translate.c | 1 - 1 file changed, 1 deletion(-) diff --git a/target/sh4/translate.c b/target/sh4/translate.c index fc743da..b6c3ff9 100644 --- a/target/sh4/translate.c +++ b/target/sh4/translate.c @@ -369,7 +369,6 @@ static inline void gen_store_f

[Qemu-devel] [PATCH v2 08/27] linux-user/sh4: Notice gUSA regions during signal delivery

2017-07-06 Thread Richard Henderson
We translate gUSA regions atomically in a parallel context. But in a serial context a gUSA region may be interrupted. In that case, restart the region as the kernel would. Signed-off-by: Richard Henderson --- linux-user/signal.c | 23 +++ 1 file changed, 23 insertions(+) dif

[Qemu-devel] [PATCH v2 16/27] target/sh4: Load/store Dr as 64-bit quantities

2017-07-06 Thread Richard Henderson
This enforces proper alignment and makes the register update more natural. Note that there is a more serious bug fix for fmov {DX}Rn,@(R0,Rn) to use a store instead of a load. Signed-off-by: Richard Henderson --- target/sh4/translate.c | 74 -- 1

[Qemu-devel] [PATCH v2 13/27] target/sh4: Hoist fp register bank selection

2017-07-06 Thread Richard Henderson
Compute which register bank to use once at the start of translation. Signed-off-by: Richard Henderson --- target/sh4/translate.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/target/sh4/translate.c b/target/sh4/translate.c index 878c0bd..fc743da 100644 --- a/target/

[Qemu-devel] [PATCH v2 06/27] target/sh4: Handle user-space atomics

2017-07-06 Thread Richard Henderson
For uniprocessors, SH4 uses optimistic restartable atomic sequences. Upon an interrupt, a real kernel would simply notice magic values in the registers and reset the PC to the start of the sequence. For QEMU, we cannot do this in quite the same way. Instead, we notice the normal start of such a s

[Qemu-devel] [PATCH v2 20/27] target/sh4: Unify code for CHECK_FPU_ENABLED

2017-07-06 Thread Richard Henderson
We do not need to emit N copies of raising an exception. Signed-off-by: Richard Henderson --- target/sh4/translate.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/target/sh4/translate.c b/target/sh4/translate.c index dd14b43..a4370c6 100644 --- a/

[Qemu-devel] [PATCH v2 15/27] target/sh4: Merge DREG into fpr64 routines

2017-07-06 Thread Richard Henderson
Also add a debugging assert that we did signal illegal opc for odd double-precision registers. Signed-off-by: Richard Henderson --- target/sh4/translate.c | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/target/sh4/translate.c b/target/sh4/translat

[Qemu-devel] [PATCH v2 22/27] target/sh4: Introduce CHECK_FPSCR_PR_*

2017-07-06 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sh4/translate.c | 57 +++--- 1 file changed, 31 insertions(+), 26 deletions(-) diff --git a/target/sh4/translate.c b/target/sh4/translate.c index 06cf649..3d8ac59 100644 --- a/target/sh4/translate.c +++ b/tar

[Qemu-devel] [PATCH v2 11/27] target/sh4: Unify cpu_fregs into FREG

2017-07-06 Thread Richard Henderson
We were treating FREG as an index and REG as a TCGv. Making FREG return a TCGv is both less confusing and a step toward cleaner banking of cpu_fregs. Signed-off-by: Richard Henderson --- target/sh4/translate.c | 125 - 1 file changed, 52 insertions

[Qemu-devel] [PATCH v2 17/27] target/sh4: Simplify 64-bit fp reg-reg move

2017-07-06 Thread Richard Henderson
We do not need to form full 64-bit quantities in order to perform the move. This reduces code expansion on 64-bit hosts. Signed-off-by: Richard Henderson --- target/sh4/translate.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/sh4/translate.c b/target/sh4/tr

[Qemu-devel] [PATCH v2 27/27] target/sh4: Use tcg_gen_lookup_and_goto_ptr

2017-07-06 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sh4/translate.c | 30 -- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/target/sh4/translate.c b/target/sh4/translate.c index 5fae872..7e80e10 100644 --- a/target/sh4/translate.c +++ b/target/sh4/translate.c

<    1   2   3   4   >