On 07/03/2017 11:10 AM, Eric Blake wrote: > We had several functions that no one is currently using, and which > use sector-based interfaces. I'm trying to convert towards byte-based > interfaces, so it's easier to just drop the unused functions: > > bdrv_dirty_bitmap_get_meta > bdrv_dirty_bitmap_get_meta_locked > bdrv_dirty_bitmap_reset_meta > bdrv_dirty_bitmap_meta_granularity > > Signed-off-by: Eric Blake <ebl...@redhat.com> >
Admittedly I forget entirely why some of these are here, or to be more precise I forget entirely why they are unused as I remember exactly why we needed them -- but I forget why we merged them without a caller. Oh well. If they're unused, they're unused, and can be re-added, especially if we're changing the underpinnings. I bet my last review on this email used nearly identical wordings. I'm CCing Vladimir so he has a chance to see that we're removing functions that he may have wanted to use for his migration series. Reviewed-by: John Snow <js...@redhat.com>
