[Qemu-devel] [Bug 1694998] Re: PPC: msgsnd instruction leads to assertion

2017-07-03 Thread Thomas Huth
Fix has now been included: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=f1c29ebc51be77bd64178c8d ** Changed in: qemu Status: New => Fix Committed ** Changed in: qemu Assignee: (unassigned) => Thomas Huth (th-huth) -- You received this bug notification because you are a member of q

Re: [Qemu-devel] [PATCH] s390: return unavailable features via query-cpu-definitions

2017-07-03 Thread Viktor Mihajlovski
On 30.06.2017 18:47, David Hildenbrand wrote: > On 30.06.2017 15:25, Viktor Mihajlovski wrote: >> The response for query-cpu-definitions didn't include the >> unavailable-features field, which is used by libvirt to figure >> out whether a certain cpu model is usable on the host. >> >> The unavailab

[Qemu-devel] Launching Standalone in QEMU-Microblaze

2017-07-03 Thread Ormaetxea Xabier
Hello! I'm trying to run QEMU-Microblaze (Little-endian) with a standalone app in some different ways, but none of them works for me: 1) I have created my own .DTB from my system design (.HDF), just a microblaze connected to the Uartlite AXI, leds, interrupt controller, and a gpio. Using

[Qemu-devel] [PATCH 0/1] virtio-scsi-ccw: fix iotest 068 on s390x

2017-07-03 Thread QingFeng Hao
This commit fixes iotest 068 for s390x as s390x uses virtio-scsi-ccw. The related commit is c324fd0a39c for other platforms by Stefan Hajnoczi. Thanks! QingFeng Hao (1): virtio-scsi-ccw: use ioeventfd even when KVM is disabled hw/s390x/virtio-ccw.c | 2 +- target/s390x/kvm.c| 3 +++ 2 fil

Re: [Qemu-devel] [PATCH 1/1] virtio-scsi-ccw: use ioeventfd even when KVM is disabled

2017-07-03 Thread Christian Borntraeger
On 07/03/2017 09:38 AM, QingFeng Hao wrote: > Do not check kvm_eventfds_enabled() when KVM is disabled since it > always returns 0. Since commit 8c56c1a592b5092d91da8d8943c1d6462a6f > ("memory: emulate ioeventfd") it has been possible to use ioeventfds in > qtest or TCG mode. > > This patch m

Re: [Qemu-devel] [PATCH v1 2/3] arm: fix the armv7m reset state

2017-07-03 Thread KONRAD Frederic
On 06/30/2017 11:06 AM, Peter Maydell wrote: On 30 June 2017 at 09:24, KONRAD Frederic wrote: On 06/29/2017 06:45 PM, Peter Maydell wrote: It's the same thing, though, right? If the user's ELF file says "vector table is at 0x800" then we should either (a) say that's a user error, or (b)

[Qemu-devel] [PATCH 1/1] virtio-scsi-ccw: use ioeventfd even when KVM is disabled

2017-07-03 Thread QingFeng Hao
Do not check kvm_eventfds_enabled() when KVM is disabled since it always returns 0. Since commit 8c56c1a592b5092d91da8d8943c1d6462a6f ("memory: emulate ioeventfd") it has been possible to use ioeventfds in qtest or TCG mode. This patch makes -device virtio-scsi-ccw,iothread=iothread0 work eve

[Qemu-devel] [RFC v2 0/1] target/ppc/cpu-models: set POWER9_v1.0 as POWER9 DD1

2017-07-03 Thread Laurent Vivier
This patch allows to use "-cpu POWER9" with a POWER9 DD1 host and KVM HV. With TCG, "-cpu POWER9" selects POWER9_v2.0 (POWER9 DD2). I post this patch as a RFC because kernel boots well with "-cpu host", but hangs with "-cpu POWER9" whereas I can see it selects correctly the POWER9_v1.0 CPU in both

[Qemu-devel] [RFC v2 1/1] target/ppc/cpu-models: set POWER9_v1.0 as POWER9 DD1

2017-07-03 Thread Laurent Vivier
CPU_POWERPC_POWER9_DD1 is 0x004E0100, so this is the POWER9 v1.0. When we run qemu on a POWER9 DD1 host, we must use either "-cpu host" or "-cpu POWER9", but in the latter case it fails with Unable to find sPAPR CPU Core definition because POWER9 DD1 doesn't appear in the list of known CPUs.

[Qemu-devel] [PATCH v2] s390: return unavailable features via query-cpu-definitions

2017-07-03 Thread Viktor Mihajlovski
The response for query-cpu-definitions didn't include the unavailable-features field, which is used by libvirt to figure out whether a certain cpu model is usable on the host. The unavailable features are now computed by obtaining the host CPU model and comparing it against the known CPU models. T

Re: [Qemu-devel] [Qemu-PPC] [PATCH 0/3] target/ppc: Implement radix mmu debug functions

2017-07-03 Thread David Gibson
On Mon, Jul 03, 2017 at 04:19:45PM +1000, Suraj Jitindar Singh wrote: > When the radix mmu emulation code was implemented the translation > debug functions were left as a todo. > > Implement the functions ppc_radix64_get_phys_page_debug() and > ppc_radix64_dump_level() to translate a single addre

Re: [Qemu-devel] [Qemu-PPC] [PATCH 3/3] target/ppc: Add debug function to dump radix mmu translations

2017-07-03 Thread David Gibson
On Mon, Jul 03, 2017 at 04:19:48PM +1000, Suraj Jitindar Singh wrote: > In target/ppc/mmu-hash64.c there already exists the function > dump_slb() to dump the hash translation entries (for effective to > virtual translation at least). > > Implement the function ppc_radix64_dump() to allow all the k

Re: [Qemu-devel] [PATCH 0/4] migration: fix iotest 055, only-migratable break

2017-07-03 Thread QingFeng Hao
I tested the 2 patches and they can make iotest 055 passed on both x86 and s390x. thanks 在 2017/7/3 10:44, Peter Xu 写道: Two breakage introduced during the migration objectify series: one for --only-migratable, another one for iotest 055. First two patches fixes the breakages. Latter two are

Re: [Qemu-devel] [PATCH 1/1] virtio-scsi-ccw: use ioeventfd even when KVM is disabled

2017-07-03 Thread QingFeng Hao
在 2017/7/3 15:41, Christian Borntraeger 写道: On 07/03/2017 09:38 AM, QingFeng Hao wrote: Do not check kvm_eventfds_enabled() when KVM is disabled since it always returns 0. Since commit 8c56c1a592b5092d91da8d8943c1d6462a6f ("memory: emulate ioeventfd") it has been possible to use ioeventfd

[Qemu-devel] [Bug 1701449] Re: high memory usage when using rbd with client caching

2017-07-03 Thread Markus Schade
We are seeing pretty much the same issue with even small (1G mem) virtual instances using 2-3GB of RSS after running I/O intensive applications. Live migrating the instance to another machine pushes the memory usage back, but it will grow back again once I/O is back. -- You received this bug noti

Re: [Qemu-devel] [PATCH 1/1] virtio-scsi-ccw: use ioeventfd even when KVM is disabled

2017-07-03 Thread Christian Borntraeger
On 07/03/2017 10:08 AM, QingFeng Hao wrote: > > > 在 2017/7/3 15:41, Christian Borntraeger 写道: >> On 07/03/2017 09:38 AM, QingFeng Hao wrote: >>> Do not check kvm_eventfds_enabled() when KVM is disabled since it >>> always returns 0. Since commit 8c56c1a592b5092d91da8d8943c1d6462a6f >>> ("mem

Re: [Qemu-devel] [PATCH 1/1] virtio-scsi-ccw: use ioeventfd even when KVM is disabled

2017-07-03 Thread QingFeng Hao
在 2017/7/3 16:21, Christian Borntraeger 写道: On 07/03/2017 10:08 AM, QingFeng Hao wrote: 在 2017/7/3 15:41, Christian Borntraeger 写道: On 07/03/2017 09:38 AM, QingFeng Hao wrote: Do not check kvm_eventfds_enabled() when KVM is disabled since it always returns 0. Since commit 8c56c1a592b5092d9

Re: [Qemu-devel] [PATCH] Python3 Support for qmp.py

2017-07-03 Thread Stefan Hajnoczi
On Sat, Jul 01, 2017 at 12:39:41AM +0530, Ishani Chugh wrote: > This patch intends to make qmp.py compatible with both python2 and python3. Please identify the Python 2/3 compatibility issues addressed in the patch like: * Python 3 does not have dict.has_key(key), use key in dict instead * Avoi

[Qemu-devel] [PATCH v2 1/1] virtio-scsi-ccw: use ioeventfd even when KVM is disabled

2017-07-03 Thread QingFeng Hao
This patch is based on a similar patch from Stefan Hajnoczi - commit c324fd0a39c (" virtio-pci: use ioeventfd even when KVM is disabled) Do not check kvm_eventfds_enabled() when KVM is disabled since it always returns 0. Since commit 8c56c1a592b5092d91da8d8943c1d6462a6f ("memory: emulate ioev

Re: [Qemu-devel] [PATCH v1 2/3] arm: fix the armv7m reset state

2017-07-03 Thread Peter Maydell
On 3 July 2017 at 08:31, KONRAD Frederic wrote: > On 06/30/2017 11:06 AM, Peter Maydell wrote: >> On 30 June 2017 at 09:24, KONRAD Frederic >> wrote: >>> If I choose (b) I won't be able to load it to SRAM and it is >>> basically the same result I'll need to move or modify the config. >> >> >> I d

[Qemu-devel] [PATCH v2 0/1] virtio-scsi-ccw: fix iotest 068 for s390x

2017-07-03 Thread QingFeng Hao
This commit fixes iotest 068 for s390x as s390x uses virtio-scsi-ccw. It's based on commit c324fd0a39c by Stefan Hajnoczi. Thanks! Change history: v2: Remove Stefan from sign-off list and change the patch's commit message according to Christian Borntraeger's comment. QingFeng Hao (1):

Re: [Qemu-devel] [PATCH 0/4] migration: fix iotest 055, only-migratable break

2017-07-03 Thread Peter Xu
On Mon, Jul 03, 2017 at 03:54:38PM +0800, QingFeng Hao wrote: > I tested the 2 patches and they can make iotest 055 passed on both x86 and > s390x. Thanks for testing! -- Peter Xu

Re: [Qemu-devel] [PATCH v1 2/3] arm: fix the armv7m reset state

2017-07-03 Thread KONRAD Frederic
On 07/03/2017 10:51 AM, Peter Maydell wrote: On 3 July 2017 at 08:31, KONRAD Frederic wrote: On 06/30/2017 11:06 AM, Peter Maydell wrote: On 30 June 2017 at 09:24, KONRAD Frederic wrote: If I choose (b) I won't be able to load it to SRAM and it is basically the same result I'll need to mov

Re: [Qemu-devel] [PATCH v1] target-s390x: fix risbg handling

2017-07-03 Thread David Hildenbrand
On 01.07.2017 22:27, Richard Henderson wrote: > On 06/25/2017 03:19 PM, Aurelien Jarno wrote: >> On 2017-06-23 01:12, David Hildenbrand wrote: >>> If we have for example: r3 contains 0x >>> ec 33 3f bf 61 55 risbg %r3,%r3,63,191,97 >>> >>> We want to rotate 33 to the le

Re: [Qemu-devel] Launching Standalone in QEMU-Microblaze

2017-07-03 Thread Edgar E. Iglesias
On Mon, Jul 03, 2017 at 07:23:23AM +, Ormaetxea Xabier wrote: > Hello! Hi! > > I'm trying to run QEMU-Microblaze (Little-endian) with a standalone app in > some different ways, but none of them works for me: > > > 1) I have created my own .DTB from my system design (.HDF), just a >

Re: [Qemu-devel] [PATCH] target/ppc: Only set PCR in kvm if actually in a compat mode

2017-07-03 Thread David Gibson
On Mon, Jul 03, 2017 at 01:18:38PM +1000, Suraj Jitindar Singh wrote: > On Fri, 2017-06-30 at 14:03 +1000, David Gibson wrote: > > On Thu, Jun 29, 2017 at 02:59:39PM +1000, Suraj Jitindar Singh wrote: > > > The Processor Compatibility Register (PCR) I used to set the > > > compatibility mode of the

Re: [Qemu-devel] [PATCH v2] s390: return unavailable features via query-cpu-definitions

2017-07-03 Thread David Hildenbrand
> > +static S390CPUModel *get_max_cpu_model(Error **errp); > + > #ifndef CONFIG_USER_ONLY > +static void list_add_feat(const char *name, void *opaque); Wonder if we should declare all these prototypes at the beginning of the file. > + > +static void check_unavailable_features(const S390CPUMod

Re: [Qemu-devel] [RFC v2 1/1] target/ppc/cpu-models: set POWER9_v1.0 as POWER9 DD1

2017-07-03 Thread Thomas Huth
On 03.07.2017 09:45, Laurent Vivier wrote: > CPU_POWERPC_POWER9_DD1 is 0x004E0100, so this is the POWER9 v1.0. > > When we run qemu on a POWER9 DD1 host, we must use either > "-cpu host" or "-cpu POWER9", but in the latter case it fails with > > Unable to find sPAPR CPU Core definition > > b

Re: [Qemu-devel] [PATCHv7 5/6] fw_cfg: move qdev_init_nofail() from fw_cfg_init1() to callers

2017-07-03 Thread Igor Mammedov
On Thu, 29 Jun 2017 15:07:19 +0100 Mark Cave-Ayland wrote: > When looking to instantiate a TYPE_FW_CFG_MEM or TYPE_FW_CFG_IO device to be > able to wire it up differently, it is much more convenient for the caller to > instantiate the device and have the fw_cfg default files already preloaded > d

Re: [Qemu-devel] [PATCHv7 3/6] fw_cfg: switch fw_cfg_find() to locate the fw_cfg device by type rather than path

2017-07-03 Thread Igor Mammedov
On Thu, 29 Jun 2017 15:07:17 +0100 Mark Cave-Ayland wrote: > This will enable the fw_cfg device to be placed anywhere within the QOM tree > regardless of its machine location. > > Signed-off-by: Mark Cave-Ayland > --- > hw/nvram/fw_cfg.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(

[Qemu-devel] handling emulation fine-grained memory protection

2017-07-03 Thread Peter Maydell
For the ARM v7M microcontrollers we currently treat their memory protection unit like a funny kind of MMU that only has a 1:1 address mapping. This basically works but it means that we can only support protection regions which are a multiple of 1K in size and on a 1K address boundary (because that'

Re: [Qemu-devel] [PULL 0/3] Queued TCG patches

2017-07-03 Thread Peter Maydell
On 30 June 2017 at 20:09, Richard Henderson wrote: > None of my TCGTemp patches for now; I'm still trying to understand > how they might (or might not) conflict with multi-threaded code gen > for TCG. > > > r~ > > > The following changes since commit 82d76dc7fc19a5eb9f731d7faed1792bb97214e0: > >

[Qemu-devel] [PATCH v2 04/15] tcg: change tcg_enabled()

2017-07-03 Thread Yang Zhong
Change the tcg_enabled() and make sure user build still enable tcg even x86 softmmu disable tcg. Signed-off-by: Yang Zhong --- accel/tcg/tcg-all.c | 2 +- accel/tcg/translate-all.c | 6 +- bsd-user/main.c | 1 + include/qemu-common.h | 7 ++- linux-user/main.c

[Qemu-devel] [PATCH v2 00/15] add disable-tcg option for x86 build

2017-07-03 Thread Yang Zhong
This patchset rebased from Paolo's below patchset, which was based on QEMU 2.0.50 version. https://github.com/bonzini/qemu/tree/disable-tcg Since qemu-system-x86_64 enabled kvm and TCG accelators by default, in fact, the TCG accelator is NOT useful in the system build of x86 platform. This patchse

[Qemu-devel] [PATCH v2 05/15] tcg: move page_size_init() function

2017-07-03 Thread Yang Zhong
translate-all.c will be disabled if tcg is disabled in the build, so page_size_init() function and related variables will be moved to exec.c file. Signed-off-by: Yang Zhong --- accel/tcg/translate-all.c | 18 -- exec.c| 20 2 files changed

[Qemu-devel] [PATCH v2 01/15] configure: add the disable-tcg option

2017-07-03 Thread Yang Zhong
Add the disable-tcg option into configure and echo CONFIG_TCG=y into $config_target_mak. The default tcg is enabled for all build, only i386 and x86_64 softmmu option can be disabled. This operation do not make big change with the older build command. The new configure build command like below (1)

[Qemu-devel] [PATCH v2 08/15] tcg: make cpu_get_fp80()/cpu_set_fp80() static

2017-07-03 Thread Yang Zhong
Move cpu_get_fp80()/cpu_set_fp80() from fpu_helper.c to machine.c because fpu_helper.c will be disabled if tcg is disabled in the build. Signed-off-by: Yang Zhong --- target/i386/cpu.h| 2 -- target/i386/fpu_helper.c | 18 -- target/i386/machine.c| 18 +++

[Qemu-devel] [PATCH v2 02/15] vl: add tcg_enabled() for tcg related code

2017-07-03 Thread Yang Zhong
Need to disable the tcg related code in the vl.c if the disable-tcg option is added into ./configure command. Signed-off-by: Yang Zhong --- accel/tcg/tcg-all.c| 2 +- include/sysemu/accel.h | 2 +- vl.c | 15 +++ 3 files changed, 13 insertions(+), 6 deletions(

[Qemu-devel] [PATCH v2 09/15] tcg: add the tcg-stub.c file into accel/stubs/

2017-07-03 Thread Yang Zhong
If tcg is disabled, the functions in tcg-stub.c file will be called. This file is target-independent file, do not include any platform related stub functions into this file. Signed-off-by: Yang Zhong --- accel/stubs/Makefile.objs | 1 + accel/stubs/tcg-stub.c| 80 +++

[Qemu-devel] [PATCH v2 06/15] kvmvapic: remove tcg related code

2017-07-03 Thread Yang Zhong
Since Paolo's below patch has fixed A20 issue commit bbfa326fc8028e275eddf8c9965c2a1b59405b2e target/i386: enable A20 automatically in system management mod The tcg code in kvmvapic.c is NOT useful, those code need remove. Signed-off-by: Yang Zhong --- hw/i386/kvmvapic.c | 24 --

[Qemu-devel] [PATCH v2 03/15] tcg: tcg_handle_interrupt() function

2017-07-03 Thread Yang Zhong
Move tcg_handle_interrupt() from translate-common.c to accel/tcg/tcg-all.c. Signed-off-by: Yang Zhong --- accel/tcg/Makefile.objs | 2 +- accel/tcg/tcg-all.c | 32 + accel/tcg/translate-common.c | 56 qom/cpu.c

[Qemu-devel] [PATCH v2 15/15] tcg: add the CONFIG_TCG into Makefiles

2017-07-03 Thread Yang Zhong
Add the CONFIG_TCG for frontend and backend's files in the related Makefiles. Signed-off-by: Yang Zhong --- Makefile.target | 4 ++-- accel/Makefile.objs | 2 +- target/i386/Makefile.objs | 7 --- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/Makefile.target

[Qemu-devel] [PATCH v2 14/15] tcg: add the tcg_enabled() in target/i386/

2017-07-03 Thread Yang Zhong
Add the tcg_enabled() to disable tcg code in x86 target. Signed-off-by: Yang Zhong --- target/i386/bpt_helper.c | 26 -- target/i386/cpu.c| 4 +++- target/i386/machine.c| 5 +++-- 3 files changed, 26 insertions(+), 9 deletions(-) diff --git a/target/i386/bp

[Qemu-devel] [PATCH v2 11/15] tcg: split cpu_set_mxcsr() and make cpu_set_fpuc() inline

2017-07-03 Thread Yang Zhong
Split the cpu_set_mxcsr() and make cpu_set_fpuc() inline with specific tcg code. Signed-off-by: Yang Zhong --- target/i386/cpu.h| 18 -- target/i386/fpu_helper.c | 11 ++- 2 files changed, 18 insertions(+), 11 deletions(-) diff --git a/target/i386/cpu.h b/target/

[Qemu-devel] [PATCH v2 07/15] tcg: move cpu_sync_bndcs_hflags() function

2017-07-03 Thread Yang Zhong
Move cpu_sync_bndcs_hflags() function from mpx_helper.c to helper.c because mpx_helper.c need be disabled when tcg is disabled. Signed-off-by: Yang Zhong --- target/i386/helper.c | 34 +- target/i386/mpx_helper.c | 30 -- 2 files ch

[Qemu-devel] what is the USB 'maxframes' parameter for and what is its maximum value?

2017-07-03 Thread Peter Maydell
Hi; I've been idly looking through our fairly small number of remaining Coverity issues, and one of them is in hw/usb/hcd-ehci.c: in ehci_work_bh() we do: if (uframes > (ehci->maxframes * 8)) { but if maxframes is very large then the multiply will overflow a 32-bit integer. (CID 1375885)

[Qemu-devel] [PATCH v2 10/15] tcg: move tb related lock functions

2017-07-03 Thread Yang Zhong
Move tb_lock()/tb_unlock()/tb_lock_reset() from tcg.h to translate-all.h. tb_lock()/tb_unlock() need be impelemnted in accel/stubs/tcg-stub.c. Signed-off-by: Yang Zhong --- accel/stubs/tcg-stub.c| 8 accel/tcg/cpu-exec.c | 1 + accel/tcg/cputlb.c| 1 + accel/tcg/transla

Re: [Qemu-devel] [PATCH v2 01/15] configure: add the disable-tcg option

2017-07-03 Thread Daniel P. Berrange
On Mon, Jul 03, 2017 at 06:12:09PM +0800, Yang Zhong wrote: > Add the disable-tcg option into configure and echo CONFIG_TCG=y into > $config_target_mak. The default tcg is enabled for all build, only i386 > and x86_64 softmmu option can be disabled. This operation do not make > big change with the

Re: [Qemu-devel] [RFC PATCH 7/8] VFIO: Add new IOCTL for IOMMU TLB invalidate propagation

2017-07-03 Thread Liu, Yi L
On Fri, May 12, 2017 at 01:11:02PM +0100, Jean-Philippe Brucker wrote: Hi Jean, As we've got a few discussions on it. I'd like to have a conclusion and make it as a reference for future discussion. Currently, we are inclined to have a hybrid format for the iommu tlb invalidation from userspace(v

[Qemu-devel] [PATCH v2 12/15] tcg: disable tcg in CPUX86State struct

2017-07-03 Thread Yang Zhong
Add the CONFIG_TCG for CPU_COMMON_TLB in the CPUX86State struct. Signed-off-by: Yang Zhong --- include/exec/cpu-defs.h | 4 +++- target/i386/cpu.h | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/include/exec/cpu-defs.h b/include/exec/cpu-defs.h index 5f4e303..bc8e7f8

[Qemu-devel] [PATCH v2 13/15] tcg: add the CONFIG_TCG for header

2017-07-03 Thread Yang Zhong
Add the CONFIG_TCG for exec-all.h. Since function tlb_set_page_with_attrs() is defined in ./accel/tcg/cputlb.c, which will be disabled if tcg is disabled. This function need be implemented in accel/stubs/tcg-stub.c for disable-tcg. Signed-off-by: Yang Zhong --- accel/stubs/tcg-stub.c | 6 +

Re: [Qemu-devel] [PATCH v2 1/1] virtio-scsi-ccw: use ioeventfd even when KVM is disabled

2017-07-03 Thread Christian Borntraeger
On 07/03/2017 10:51 AM, QingFeng Hao wrote: > This patch is based on a similar patch from Stefan Hajnoczi - > commit c324fd0a39c (" virtio-pci: use ioeventfd even when KVM is disabled) > > Do not check kvm_eventfds_enabled() when KVM is disabled since it > always returns 0. Since commit 8c56c1a59

Re: [Qemu-devel] [PATCH v2 01/15] configure: add the disable-tcg option

2017-07-03 Thread Paolo Bonzini
On 03/07/2017 12:20, Daniel P. Berrange wrote: >> >> +if test "$tcg" = "no"; then >> + for target in $target_list; do >> + if test "$softmmu" = "yes"; then >> +case $target in >> + i386-softmmu|x86_64-softmmu) >> + ;; >> +*) >> + error_exit "

Re: [Qemu-devel] [PATCH v2 01/15] configure: add the disable-tcg option

2017-07-03 Thread Daniel P. Berrange
On Mon, Jul 03, 2017 at 12:25:36PM +0200, Paolo Bonzini wrote: > > > On 03/07/2017 12:20, Daniel P. Berrange wrote: > >> > >> +if test "$tcg" = "no"; then > >> + for target in $target_list; do > >> + if test "$softmmu" = "yes"; then > >> +case $target in > >> + i386-sof

Re: [Qemu-devel] [PATCH v2] s390: return unavailable features via query-cpu-definitions

2017-07-03 Thread Viktor Mihajlovski
On 03.07.2017 11:25, David Hildenbrand wrote: > >> >> +static S390CPUModel *get_max_cpu_model(Error **errp); >> + >> #ifndef CONFIG_USER_ONLY >> +static void list_add_feat(const char *name, void *opaque); > > Wonder if we should declare all these prototypes at the beginning of the > file. > D

Re: [Qemu-devel] [PATCH v2 01/15] configure: add the disable-tcg option

2017-07-03 Thread Paolo Bonzini
On 03/07/2017 12:33, Daniel P. Berrange wrote: >> i386-softmmu and x86_64-softmmu are singled out here, because they're >> the only targets where --disable-tcg compiles. For the others, more >> work is needed (see patches 6-15 in Yang Zhong's series). > > Even with that, you still can't disable

Re: [Qemu-devel] [RFC 00/29] postcopy+vhost-user/shared ram

2017-07-03 Thread Marc-André Lureau
Hi On Thu, Jun 29, 2017 at 8:56 PM Dr. David Alan Gilbert wrote: > * Dr. David Alan Gilbert (git) (dgilb...@redhat.com) wrote: > > From: "Dr. David Alan Gilbert" > > > > Hi, > > This is a RFC/WIP series that enables postcopy migration > > with shared memory to a vhost-user process. > > It's b

Re: [Qemu-devel] [PATCH v1] s390x/cpumodel: allow to enable "idtes" feature for TCG

2017-07-03 Thread Thomas Huth
On 30.06.2017 21:22, Richard Henderson wrote: > On 06/29/2017 12:05 AM, Thomas Huth wrote: >> However, I'm not sure whether you can simply ignore the clearing-by-ASCE >> stuff in this case. For example, according to the PoP: >> >> "When the clearing-by-ASCE-option bit (bit 52 of gen- >> eral regi

[Qemu-devel] [PATCH] ehci: add sanity check for maxframes

2017-07-03 Thread Gerd Hoffmann
Reported-by: Peter Maydell Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 73090e01ad..604912cb3e 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c @@ -2483,6 +2483,11 @@ void usb_ehci_re

Re: [Qemu-devel] [PATCH] ehci: add sanity check for maxframes

2017-07-03 Thread Peter Maydell
On 3 July 2017 at 12:15, Gerd Hoffmann wrote: > Reported-by: Peter Maydell > Signed-off-by: Gerd Hoffmann > --- > hw/usb/hcd-ehci.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c > index 73090e01ad..604912cb3e 100644 > --- a/hw/usb/hcd-ehci.c

Re: [Qemu-devel] [PATCH 1/4] migration: fix handling for --only-migratable

2017-07-03 Thread Juan Quintela
Peter Xu wrote: > MigrateState object is not ready at that time, so we'll get an > assertion. Use qemu_global_option() instead. > > Reported-by: Eduardo Habkost > Suggested-by: Eduardo Habkost > Fixes: 3df663e ("migration: move only_migratable to MigrationState") > Signed-off-by: Peter Xu Revi

Re: [Qemu-devel] [PATCH 3/4] doc: add item for "-M enforce-config-section"

2017-07-03 Thread Juan Quintela
Peter Xu wrote: > It's never documented, and now we have one more parameter for it (which > means this one can be obsolete in the future). Document it properly. > > Although now when enforce-config-section is set, it'll override the > other "-global" parameter, that is not necessarily a rule. Forb

Re: [Qemu-devel] [PATCH 4/4] doc: update TYPE_MIGRATION documents

2017-07-03 Thread Juan Quintela
Peter Xu wrote: > [Peter collected Eduardo's patch comment and formatted into patch] > > Suggested-by: Eduardo Habkost > Signed-off-by: Peter Xu > --- Reviewed-by: Juan Quintela

Re: [Qemu-devel] [PATCH v6 3/3] test-qga: add test for guest-get-osinfo

2017-07-03 Thread Tomáš Golembiovský
Uh, sorry. I will resend in a minute. Tomas On Fri, 30 Jun 2017 13:48:41 + Marc-André Lureau wrote: > Hi, > > It's missing test-qga-os-release :) > > On Thu, Jun 29, 2017 at 11:27 PM Tomáš Golembiovský > wrote: > > > Add test for guest-get-osinfo command. > > > > Qemu-ga was modifie

Re: [Qemu-devel] [PATCH v3 0/3] Generic PCIe host bridge INTx determination for INTx routing

2017-07-03 Thread Auger Eric
Hi, On 13/06/2017 15:31, Eric Auger wrote: > This series implements INTx to gsi routing for ARM VIRT/GPEX. This is > a respin of [1] which was lost in limbo. > > ARM virt uses GPEX PCIe bridge. This latter does not implement INTx > to GSI routing. PCIe/INTx assignment works but the consequence is

Re: [Qemu-devel] [PATCH v1] s390x/cpumodel: allow to enable "idtes" feature for TCG

2017-07-03 Thread David Hildenbrand
On 03.07.2017 13:07, Thomas Huth wrote: > On 30.06.2017 21:22, Richard Henderson wrote: >> On 06/29/2017 12:05 AM, Thomas Huth wrote: >>> However, I'm not sure whether you can simply ignore the clearing-by-ASCE >>> stuff in this case. For example, according to the PoP: >>> >>> "When the clearing-by

Re: [Qemu-devel] [Qemu-block] [PATCH 10/31] vvfat: use DIV_ROUND_UP

2017-07-03 Thread Eric Blake
On 06/22/2017 07:41 AM, Marc-André Lureau wrote: > I used the clang-tidy qemu-round check to generate the fix: > https://github.com/elmarco/clang-tools-extra > > Signed-off-by: Marc-André Lureau > --- > block/vvfat.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/b

[Qemu-devel] [PATCH v7 2/3] test-qga: pass environemnt to qemu-ga

2017-07-03 Thread Tomáš Golembiovský
Modify fixture_setup() to pass environemnt variables to spawned qemu-ga instance. Signed-off-by: Tomáš Golembiovský --- tests/test-qga.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/test-qga.c b/tests/test-qga.c index c77f241036..631b98639a 100644 --- a/tests

[Qemu-devel] [PATCH v7 0/3] qemu-ga: add guest-get-osinfo command

2017-07-03 Thread Tomáš Golembiovský
v7: - fixed incorrect error check in ga_get_win_version() - added missing test-qga-os-release - fixed coding style issues v6: - fixed the documentation comment in schema - disguising os-release as key-value file (thanks Marc-André) - dropped dependency on gio - improved error handling - added test

Re: [Qemu-devel] [PATCH v2 01/15] configure: add the disable-tcg option

2017-07-03 Thread Thomas Huth
On 03.07.2017 12:55, Paolo Bonzini wrote: > > > On 03/07/2017 12:33, Daniel P. Berrange wrote: >>> i386-softmmu and x86_64-softmmu are singled out here, because they're >>> the only targets where --disable-tcg compiles. For the others, more >>> work is needed (see patches 6-15 in Yang Zhong's se

Re: [Qemu-devel] [PATCH v2] s390: return unavailable features via query-cpu-definitions

2017-07-03 Thread David Hildenbrand
>> Wonder if we should declare all these prototypes at the beginning of the >> file. >> > Don't know either. Looking around in QEMU, forward declarations for > static functions seem to be used sparsely (only when needed). I could > have reordered the functions to get around without forward decls b

[Qemu-devel] [PATCH v7 3/3] test-qga: add test for guest-get-osinfo

2017-07-03 Thread Tomáš Golembiovský
Add test for guest-get-osinfo command. Qemu-ga was modified to accept QGA_OS_RELEASE environment variable. If the variable is defined it is interpreted as path to the os-release file and it is parsed instead of the default paths. Signed-off-by: Tomáš Golembiovský --- qga/commands-posix.c

[Qemu-devel] [PATCH v7 1/3] qemu-ga: add guest-get-osinfo command

2017-07-03 Thread Tomáš Golembiovský
Add a new 'guest-get-osinfo' command for reporting basic information of the guest operating system. This includes machine architecture, version and release of the kernel and several fields from os-release file if it is present (as defined in [1]). [1] https://www.freedesktop.org/software/systemd/m

[Qemu-devel] [PATCH v3] s390: return unavailable features via query-cpu-definitions

2017-07-03 Thread Viktor Mihajlovski
The response for query-cpu-definitions didn't include the unavailable-features field, which is used by libvirt to figure out whether a certain cpu model is usable on the host. The unavailable features are now computed by obtaining the host CPU model and comparing it against the known CPU models. T

Re: [Qemu-devel] [RFC 00/29] postcopy+vhost-user/shared ram

2017-07-03 Thread Dr. David Alan Gilbert
* Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > Hi > > On Thu, Jun 29, 2017 at 8:56 PM Dr. David Alan Gilbert > wrote: > > > * Dr. David Alan Gilbert (git) (dgilb...@redhat.com) wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > Hi, > > > This is a RFC/WIP series that enables p

Re: [Qemu-devel] [PATCH v4 11/13] virtio-console: chardev hotswap support

2017-07-03 Thread Anton Nefedov
On 06/29/2017 01:02 PM, Marc-André Lureau wrote: Hi Looks good, but please write something in the commit message about what needs to be done for be-change (what this patch does). thanks Hi, thank you! I guess the description should look like virtio-console: chardev hotswap support In

Re: [Qemu-devel] [RFC PATCH 7/8] VFIO: Add new IOCTL for IOMMU TLB invalidate propagation

2017-07-03 Thread Jean-Philippe Brucker
Hi Yi, On 02/07/17 11:06, Liu, Yi L wrote: > On Fri, May 12, 2017 at 01:11:02PM +0100, Jean-Philippe Brucker wrote: > > Hi Jean, > > As we've got a few discussions on it. I'd like to have a conclusion and > make it as a reference for future discussion. > > Currently, we are inclined to have a h

Re: [Qemu-devel] [PATCH RFC 1/6] hw/acpi: remove dead acpi code

2017-07-03 Thread Igor Mammedov
On Fri, 30 Jun 2017 02:27:40 +0300 "Michael S. Tsirkin" wrote: > On Fri, Jun 30, 2017 at 12:55:57AM +0300, Aleksandr Bezzubikov wrote: > > Signed-off-by: Aleksandr Bezzubikov > > > I agree it seems unused. I'm not sure why do we have this > code. Igor? it's leftovers of original ASL code fro

Re: [Qemu-devel] [PATCH v4 13/13] serial: chardev hotswap support

2017-07-03 Thread Anton Nefedov
Hi Paolo, Michael, Any feedback on this change? (and a cosmetic patch 12 of this series) Thanks a lot in advance, /Anton On 06/26/2017 07:45 PM, Anton Nefedov wrote: for a backend change, a number of ioctls has to be replayed to sync the current setup of a frontend to a backend tty. This is

Re: [Qemu-devel] [PATCH v2 01/15] configure: add the disable-tcg option

2017-07-03 Thread Daniel P. Berrange
On Mon, Jul 03, 2017 at 12:55:04PM +0200, Paolo Bonzini wrote: > > > On 03/07/2017 12:33, Daniel P. Berrange wrote: > >> i386-softmmu and x86_64-softmmu are singled out here, because they're > >> the only targets where --disable-tcg compiles. For the others, more > >> work is needed (see patches

Re: [Qemu-devel] [PATCH v5 1/2] iotests: Use absolute paths for executables

2017-07-03 Thread Eric Blake
On 07/02/2017 10:05 AM, Max Reitz wrote: > A user may specify a relative path for accessing qemu, qemu-img, etc. > through environment variables ($QEMU_PROG and friends) or a symlink. > > If a test decides to change its working directory, relative paths will > cease to work, however. Work around t

[Qemu-devel] [PATCH] spapr: fix memory hotplug error path

2017-07-03 Thread Greg Kurz
QEMU shouldn't abort if spapr_add_lmbs()->spapr_drc_attach() fails. Let's propagate the error instead, like it is done everywhere else where spapr_drc_attach() is called. Signed-off-by: Greg Kurz --- hw/ppc/spapr.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/

[Qemu-devel] [PATCH v3 1/5] qapi/qnull: Add own header

2017-07-03 Thread Max Reitz
Reviewed-by: Markus Armbruster Signed-off-by: Max Reitz --- include/qapi/qmp/qnull.h | 26 ++ include/qapi/qmp/qobject.h | 8 include/qapi/qmp/types.h | 1 + qobject/qnull.c| 2 +- tests/check-qnull.c| 2 +- 5 files changed, 29 inserti

Re: [Qemu-devel] [PATCH v2] tests: Avoid non-portable 'echo -ARG'

2017-07-03 Thread Eric Blake
On 07/02/2017 09:49 AM, Max Reitz wrote: > On 2017-06-30 21:58, Eric Blake wrote: >> POSIX says that backslashes in the arguments to 'echo', as well as >> any use of 'echo -n' and 'echo -e', are non-portable; it recommends >> people should favor 'printf' instead. This is definitely true where >> w

[Qemu-devel] [PATCH v3 0/5] block: Don't compare strings in bdrv_reopen_prepare()

2017-07-03 Thread Max Reitz
bdrv_reopen_prepare() assumes that all BDS options are strings, which is not necessarily correct. This series introduces a new qobject_is_equal() function which can be used to test whether any options have changed, independently of their type. v3: - Patch 1: - Fix copyright header [Markus] -

[Qemu-devel] [PATCH v3 5/5] tests: Add check-qobject for equality tests

2017-07-03 Thread Max Reitz
Add a new test file (check-qobject.c) for unit tests that concern QObjects as a whole. Its only purpose for now is to test the qobject_is_equal() function. Signed-off-by: Max Reitz --- tests/Makefile.include | 4 +- tests/check-qobject.c | 312

[Qemu-devel] [PATCH v3 2/5] qapi: Add qobject_is_equal()

2017-07-03 Thread Max Reitz
This generic function (along with its implementations for different types) determines whether two QObjects are equal. Signed-off-by: Max Reitz --- include/qapi/qmp/qbool.h | 1 + include/qapi/qmp/qdict.h | 1 + include/qapi/qmp/qlist.h | 1 + include/qapi/qmp/qnull.h | 2 ++ include/

[Qemu-devel] [PATCH v3 3/5] block: qobject_is_equal() in bdrv_reopen_prepare()

2017-07-03 Thread Max Reitz
Currently, bdrv_reopen_prepare() assumes that all BDS options are strings. However, this is not the case if the BDS has been created through the json: pseudo-protocol or blockdev-add. Note that the user-invokable reopen command is an HMP command, so you can only specify strings there. Therefore, s

Re: [Qemu-devel] [PATCH RFC 0/6] q35: add acpi pci hotplug support

2017-07-03 Thread Igor Mammedov
On Fri, 30 Jun 2017 10:25:05 +0300 Marcel Apfelbaum wrote: [...] > > So for the modern systems not supporting PCI ACPI hotplug > we don't need pci-bridges anyway, but for the older ones > the ACPI code of the pci-bridge will be loaded into the > ACPI namespace only if a pci-bridge is actually ho

[Qemu-devel] [PATCH v3 4/5] iotests: Add test for non-string option reopening

2017-07-03 Thread Max Reitz
Reviewed-by: Kevin Wolf Signed-off-by: Max Reitz --- tests/qemu-iotests/133 | 9 + tests/qemu-iotests/133.out | 5 + 2 files changed, 14 insertions(+) diff --git a/tests/qemu-iotests/133 b/tests/qemu-iotests/133 index 9d35a6a..af6b3e1 100755 --- a/tests/qemu-iotests/133 +++ b/te

Re: [Qemu-devel] [PATCH v2 02/15] vl: add tcg_enabled() for tcg related code

2017-07-03 Thread Thomas Huth
On 03.07.2017 12:12, Yang Zhong wrote: > Need to disable the tcg related code in the vl.c if the > disable-tcg option is added into ./configure command. > > Signed-off-by: Yang Zhong > --- > accel/tcg/tcg-all.c| 2 +- > include/sysemu/accel.h | 2 +- > vl.c | 15 +

[Qemu-devel] [PATCH v3] tests: Avoid non-portable 'echo -ARG'

2017-07-03 Thread Eric Blake
POSIX says that backslashes in the arguments to 'echo', as well as any use of 'echo -n' and 'echo -e', are non-portable; it recommends people should favor 'printf' instead. This is definitely true where we do not control which shell is running (such as in makefile snippets or in documentation exam

Re: [Qemu-devel] [PATCH v5 0/2] iotests: Add test for colon handling

2017-07-03 Thread Max Reitz
On 2017-07-02 17:05, Max Reitz wrote: > v3 of v3 of "iotests: Add test for colon handling"; thus, basically, v5. > > This adds an iotest for the original series "block: Fix backing paths > for filenames with colons" and fixes common.config so it works if you > have specified the qemu binaries thro

Re: [Qemu-devel] [PATCH v3 1/5] qapi/qnull: Add own header

2017-07-03 Thread Eric Blake
On 07/03/2017 07:25 AM, Max Reitz wrote: > Reviewed-by: Markus Armbruster > Signed-off-by: Max Reitz > --- > include/qapi/qmp/qnull.h | 26 ++ > include/qapi/qmp/qobject.h | 8 > include/qapi/qmp/types.h | 1 + > qobject/qnull.c| 2 +- > tests/

Re: [Qemu-devel] [PATCH v2 03/15] tcg: tcg_handle_interrupt() function

2017-07-03 Thread Thomas Huth
On 03.07.2017 12:12, Yang Zhong wrote: > Move tcg_handle_interrupt() from translate-common.c to > accel/tcg/tcg-all.c. Why is this necessary / wanted? Could you please mention the reason in the patch description? Thanks, Thomas

Re: [Qemu-devel] [PATCH v3 2/5] qapi: Add qobject_is_equal()

2017-07-03 Thread Eric Blake
On 07/03/2017 07:25 AM, Max Reitz wrote: > This generic function (along with its implementations for different > types) determines whether two QObjects are equal. > > Signed-off-by: Max Reitz > --- > +++ b/qobject/qnum.c > +case QNUM_DOUBLE: > +switch (num_y->kind) { > +case

Re: [Qemu-devel] [PATCH v3 3/5] block: qobject_is_equal() in bdrv_reopen_prepare()

2017-07-03 Thread Eric Blake
On 07/03/2017 07:25 AM, Max Reitz wrote: > Currently, bdrv_reopen_prepare() assumes that all BDS options are > strings. However, this is not the case if the BDS has been created > through the json: pseudo-protocol or blockdev-add. > > Note that the user-invokable reopen command is an HMP command,

Re: [Qemu-devel] [RFC 00/15] Error API: Flag errors in *errp even if errors are being ignored

2017-07-03 Thread Markus Armbruster
Eduardo Habkost writes: > On Fri, Jun 30, 2017 at 01:40:58PM +0200, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > On Thu, Jun 29, 2017 at 08:54:29AM +0200, Markus Armbruster wrote: >> >> Eduardo Habkost writes: >> >> >> >> > On Wed, Jun 28, 2017 at 11:05:26AM +0200, Markus Armbr

Re: [Qemu-devel] [PATCH v2 01/15] configure: add the disable-tcg option

2017-07-03 Thread Paolo Bonzini
On 03/07/2017 14:09, Daniel P. Berrange wrote: >> It would leave you with a tools-only build; whether that's a good idea, >> it's another story. I think it's acceptable, but others may disagree. > If you do 'configure --target-list=x86_64-softmmu --disable-tcg' on a > non-x86 host I would be sur

Re: [Qemu-devel] [PATCH v3] tests: Avoid non-portable 'echo -ARG'

2017-07-03 Thread Max Reitz
On 2017-07-03 14:31, Eric Blake wrote: > POSIX says that backslashes in the arguments to 'echo', as well as > any use of 'echo -n' and 'echo -e', are non-portable; it recommends > people should favor 'printf' instead. This is definitely true where > we do not control which shell is running (such a

  1   2   3   4   >