On 03/07/2017 12:33, Daniel P. Berrange wrote: >> i386-softmmu and x86_64-softmmu are singled out here, because they're >> the only targets where --disable-tcg compiles. For the others, more >> work is needed (see patches 6-15 in Yang Zhong's series). > > Even with that, you still can't disable TCG if building on a non-x86 > host, since that'd leave you with no available CPU at all. So the > code still needs refactoring to check architectures properly.
It would leave you with a tools-only build; whether that's a good idea, it's another story. I think it's acceptable, but others may disagree. Paolo >> The part that is missing in this patch is disabling non-hypervisor >> targets when --disable-tcg is specified. My original patch built only >> i386-softmmu and x86_64-softmmu if you specified --disable-tcg, see >> >> https://lists.nongnu.org/archive/html/qemu-devel/2012-09/msg02570.html >> https://lists.nongnu.org/archive/html/qemu-devel/2012-09/msg02571.html