Re: [Qemu-devel] [PATCH] MAINTAINERS: seccomp: change email contact for Eduardo Otubo

2017-06-20 Thread Eduardo Otubo
On 06/12/2017 06:03 PM, Thomas Huth wrote: On 12.06.2017 14:18, Eduardo Otubo wrote: Signed-off-by: Eduardo Otubo --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 120788d..0d065a0 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@

Re: [Qemu-devel] [PATCH v11 4/6] mm: function to offer a page block on the free list

2017-06-20 Thread Rik van Riel
On Tue, 2017-06-20 at 21:26 +0300, Michael S. Tsirkin wrote: > On Tue, Jun 20, 2017 at 01:29:00PM -0400, Rik van Riel wrote: > > I agree with that.  Let me go into some more detail of > > what Nitesh is implementing: > > > > 1) In arch_free_page, the being-freed page is added > >    to a per-cpu s

[Qemu-devel] [PATCH v5 2/6] target-m68k: initialize FPU registers

2017-06-20 Thread Laurent Vivier
on reset, set FP registers to NaN and control registers to 0 Signed-off-by: Laurent Vivier --- target/m68k/cpu.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/target/m68k/cpu.c b/target/m68k/cpu.c index f068922..f2e031f 100644 --- a/target/m68k/cpu.c +++ b/target/m6

[Qemu-devel] [PATCH v5 0/6] target-m68k: implement 680x0 FPU

2017-06-20 Thread Laurent Vivier
This series modifies the original ColdFire FPU implementation to use floatx80 instead of float64 internally as this is the native datatype for 680x0. I didn't keep the float64 type for ColdFire, but if someone thinks it's required I can update this series in this way. The series also adds the FPU

[Qemu-devel] [PATCH v5 1/6] target-m68k: move fmove CR to a function

2017-06-20 Thread Laurent Vivier
Move code of fmove to/from control register to a function Signed-off-by: Laurent Vivier --- target/m68k/translate.c | 56 +++-- 1 file changed, 31 insertions(+), 25 deletions(-) diff --git a/target/m68k/translate.c b/target/m68k/translate.c index dfec

[Qemu-devel] [PATCH v5 4/6] target-m68k: define 96bit FP registers for gdb on 680x0

2017-06-20 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson --- configure| 2 +- gdb-xml/m68k-fp.xml | 21 + target/m68k/helper.c | 45 + 3 files changed, 67 insertions(+), 1 deletion(-) create mode 100644 gdb-xml/m6

[Qemu-devel] [PATCH v5 5/6] target-m68k: add FPCR and FPSR

2017-06-20 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- target/m68k/cpu.c| 2 +- target/m68k/cpu.h| 43 +- target/m68k/fpu_helper.c | 117 +--- target/m68k/helper.c | 22 ++- target/m68k/helper.h | 5 +- target/m68k/translate.c | 351 +++---

[Qemu-devel] [PATCH v5 6/6] target-m68k, linux-user: manage FP registers in ucontext

2017-06-20 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- linux-user/signal.c | 41 + 1 file changed, 41 insertions(+) diff --git a/linux-user/signal.c b/linux-user/signal.c index 3d18d1b..d3753e4 100644 --- a/linux-user/signal.c +++ b/linux-user/signal.c @@ -5673,6 +5673,24 @@ g

[Qemu-devel] [PATCH v5 3/6] target-m68k: use floatx80 internally

2017-06-20 Thread Laurent Vivier
Coldfire uses float64, but 680x0 use floatx80. This patch introduces the use of floatx80 internally and enables 680x0 80bits FPU. Signed-off-by: Laurent Vivier --- target/m68k/cpu.c| 4 +- target/m68k/cpu.h| 15 +- target/m68k/fpu_helper.c | 85 --- target/m68k/helper.c

Re: [Qemu-devel] [PATCH v3 1/2] tests: Add test-listen - a stress test for QEMU socket listen

2017-06-20 Thread Knut Omang
On Fri, 2017-06-16 at 15:41 +0100, Daniel P. Berrange wrote: > On Wed, Jun 14, 2017 at 06:53:51PM +0200, Knut Omang wrote: > > There's a potential race condition between multiple bind()'s > > attempting to bind to the same port, which occasionally > > allows more than one bind to succeed against th

Re: [Qemu-devel] [PATCH v3 2/2] sockets: Handle race condition between binds to the same port

2017-06-20 Thread Knut Omang
On Fri, 2017-06-16 at 15:45 +0100, Daniel P. Berrange wrote: > On Wed, Jun 14, 2017 at 06:53:52PM +0200, Knut Omang wrote: > > If an offset of ports is specified to the inet_listen_saddr function(), > > and two or more processes tries to bind from these ports at the same time, > > occasionally more

Re: [Qemu-devel] [PATCH v1 1/8] target-microblaze: Correct bit shift for the PVR0 version field

2017-06-20 Thread Alistair Francis
On Tue, Jun 20, 2017 at 8:51 AM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Correct bit shift for the PVR0 version field. > > Signed-off-by: Edgar E. Iglesias > --- > target/microblaze/cpu.c | 2 +- > target/microblaze/cpu.h | 2 ++ > 2 files changed, 3 insertions(+), 1 deletion(-

Re: [Qemu-devel] [PATCH v1 1/8] target-microblaze: Correct bit shift for the PVR0 version field

2017-06-20 Thread Alistair Francis
On Tue, Jun 20, 2017 at 2:09 PM, Alistair Francis wrote: > On Tue, Jun 20, 2017 at 8:51 AM, Edgar E. Iglesias > wrote: >> From: "Edgar E. Iglesias" >> >> Correct bit shift for the PVR0 version field. >> >> Signed-off-by: Edgar E. Iglesias >> --- >> target/microblaze/cpu.c | 2 +- >> target/mic

Re: [Qemu-devel] [PATCH v1 2/8] target-microblaze: Don't hard code 0xb as initial MB version

2017-06-20 Thread Alistair Francis
On Tue, Jun 20, 2017 at 8:51 AM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Don't hard code 0xb as initial MB version. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Alistair Francis Thanks, Alistair > --- > target/microblaze/cpu.c | 3 +-- > 1 file changed, 1 insertion(+),

Re: [Qemu-devel] [PATCH v1 3/8] target-microblaze: Add CPU versions 9.4, 9.5 and 9.6

2017-06-20 Thread Alistair Francis
On Tue, Jun 20, 2017 at 8:51 AM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Add CPU versions 9.4, 9.5 and 9.6. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Alistair Francis Thanks, Alistair > --- > target/microblaze/cpu.c | 3 +++ > 1 file changed, 3 insertions(+) > > dif

Re: [Qemu-devel] [PATCH v1 4/8] target-microblaze: Introduce a use-barrel property

2017-06-20 Thread Alistair Francis
On Tue, Jun 20, 2017 at 8:51 AM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Introduce a use-barrel property making barrel shifter instructions > optional. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Alistair Francis Thanks, Alistair > --- > target/microblaze/cpu.c

Re: [Qemu-devel] [PATCH v1 5/8] target-microblaze: Introduce a use-div property

2017-06-20 Thread Alistair Francis
On Tue, Jun 20, 2017 at 8:51 AM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Introduce a use-div property making division instructions > optional. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Alistair Francis Thanks, Alistair > --- > target/microblaze/cpu.c | 9 +

Re: [Qemu-devel] [PATCH v1 6/8] target-microblaze: Introduce a use-hw-mul property

2017-06-20 Thread Alistair Francis
On Tue, Jun 20, 2017 at 8:51 AM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Introduce a use-div property making multiplication instructions > optional. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Alistair Francis Thanks, Alistair > --- > target/microblaze/cpu.c | 1

Re: [Qemu-devel] [PATCH v1 7/8] target-microblaze: Introduce a use-msr-instr property

2017-06-20 Thread Alistair Francis
On Tue, Jun 20, 2017 at 8:51 AM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Introduce a use-msr-instr property making msr instructions > optional. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Alistair Francis Thanks, Alistair > --- > target/microblaze/cpu.c | 5 +++-

Re: [Qemu-devel] [PATCH] xen/disk: don't leak stack data via response ring

2017-06-20 Thread Stefano Stabellini
On Tue, 20 Jun 2017, Jan Beulich wrote: > Rather than constructing a local structure instance on the stack, fill > the fields directly on the shared ring, just like other (Linux) > backends do. Build on the fact that all response structure flavors are > actually identical (the old code did make thi

Re: [Qemu-devel] [PATCH v1 8/8] target-microblaze: Introduce a use-pcmp-instr property

2017-06-20 Thread Alistair Francis
On Tue, Jun 20, 2017 at 8:51 AM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Introduce a use-pcmp-instr property making pcmp instructions > optional. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Alistair Francis Thanks, Alistair > --- > target/microblaze/cpu.c | 5 ++

Re: [Qemu-devel] [PATCH v3 1/2] tests: Add test-listen - a stress test for QEMU socket listen

2017-06-20 Thread Daniel P. Berrange
On Tue, Jun 20, 2017 at 10:58:43PM +0200, Knut Omang wrote: > On Fri, 2017-06-16 at 15:41 +0100, Daniel P. Berrange wrote: > > On Wed, Jun 14, 2017 at 06:53:51PM +0200, Knut Omang wrote: > > > +static void listen_compete(void) > > > +{ > > > +listen_compete_nthr(true, 200, 5920, 300); > > > +}

Re: [Qemu-devel] [PATCH 1/3] xen-disk: only advertize feature-persistent if grant copy is not available

2017-06-20 Thread Stefano Stabellini
On Tue, 20 Jun 2017, Paul Durrant wrote: > If grant copy is available then it will always be used in preference to > persistent maps. In this case feature-persistent should not be advertized > to the frontend, otherwise it may needlessly copy data into persistently > granted buffers. > > Signed-of

Re: [Qemu-devel] Tracing guest virtual addresses

2017-06-20 Thread Jayanto Minocha
Lluis, My modifications were almost the same as those done by Emilio. There were no memory trace events in the trace file. -J On Tue, Jun 20, 2017 at 10:20 AM, Emilio G. Cota wrote: > On Tue, Jun 20, 2017 at 14:02:02 +0300, Lluís Vilanova wrote: > > Jayanto Minocha writes: > > > > > Hi, > > >

Re: [Qemu-devel] [PATCH v5 2/6] target-m68k: initialize FPU registers

2017-06-20 Thread Richard Henderson
On 06/20/2017 01:51 PM, Laurent Vivier wrote: +env->fpcr = 0; You probably want to use cpu_m68k_set_fpcr here too, so that fp_status matches. r~

Re: [Qemu-devel] [PATCH v5 3/6] target-m68k: use floatx80 internally

2017-06-20 Thread Richard Henderson
On 06/20/2017 01:51 PM, Laurent Vivier wrote: Coldfire uses float64, but 680x0 use floatx80. This patch introduces the use of floatx80 internally and enables 680x0 80bits FPU. Signed-off-by: Laurent Vivier --- Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v5 1/6] target-m68k: move fmove CR to a function

2017-06-20 Thread Richard Henderson
On 06/20/2017 01:51 PM, Laurent Vivier wrote: Move code of fmove to/from control register to a function Signed-off-by: Laurent Vivier --- target/m68k/translate.c | 56 +++-- 1 file changed, 31 insertions(+), 25 deletions(-) Reviewed-by: Richard He

Re: [Qemu-devel] [PATCH 2/3] xen-disk: add support for multi-page shared rings

2017-06-20 Thread Stefano Stabellini
On Tue, 20 Jun 2017, Paul Durrant wrote: > The blkif protocol has had provision for negotiation of multi-page shared > rings for some time now and many guest OS have support in their frontend > drivers. > > This patch makes the necessary modifications to xen-disk support a shared > ring up to orde

Re: [Qemu-devel] [PATCH v5 2/6] target-m68k: initialize FPU registers

2017-06-20 Thread Richard Henderson
On 06/20/2017 01:51 PM, Laurent Vivier wrote: on reset, set FP registers to NaN and control registers to 0 Signed-off-by: Laurent Vivier --- target/m68k/cpu.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) Nevermind the last... it's in 5/6. Reviewed-by: Richard Henderson

Re: [Qemu-devel] [PATCH v5 5/6] target-m68k: add FPCR and FPSR

2017-06-20 Thread Richard Henderson
On 06/20/2017 01:51 PM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier --- target/m68k/cpu.c| 2 +- target/m68k/cpu.h| 43 +- target/m68k/fpu_helper.c | 117 +--- target/m68k/helper.c | 22 ++- target/m68k/helper.h | 5 +- target/m68k/tran

Re: [Qemu-devel] [PATCH v5 6/6] target-m68k, linux-user: manage FP registers in ucontext

2017-06-20 Thread Richard Henderson
On 06/20/2017 01:51 PM, Laurent Vivier wrote: +__get_user(env->fpcr, &fpregs->f_fpcntl[0]); cpu_m68k_set_fpcr r~

[Qemu-devel] [Bug 1699277] Re: qemu-system-s390x: asserts while booting Debian Stretch installer

2017-06-20 Thread Thomas Huth
Thanks for the bug report! If you've got a chance to use the latest development version of QEMU from the git repository instead, could you please try whether you could also reproduce the problem there? I think we've already got the fix for this problem in there: http://git.qemu.org/?p=qemu.git;a=c

Re: [Qemu-devel] pci_nic_init_nofail() only works on root PCI buses?

2017-06-20 Thread Thomas Huth
On 11.06.2017 17:08, Mark Cave-Ayland wrote: > Hi all, > > Playing around with trying to set up PCI bridges for sun4u, I noticed > that I get an assert with the following diff which simply moves the > default NIC behind a PCI bridge rather than being directly on the root > PCI bus: > > diff --git

Re: [Qemu-devel] pci_nic_init_nofail() only works on root PCI buses?

2017-06-20 Thread Michael S. Tsirkin
On Wed, Jun 21, 2017 at 03:00:31AM +0200, Thomas Huth wrote: > On 11.06.2017 17:08, Mark Cave-Ayland wrote: > > Hi all, > > > > Playing around with trying to set up PCI bridges for sun4u, I noticed > > that I get an assert with the following diff which simply moves the > > default NIC behind a PCI

Re: [Qemu-devel] [PATCH v3 8/8] hw/misc/edu: Compile the edu device as common object

2017-06-20 Thread Thomas Huth
On 20.06.2017 20:14, Richard Henderson wrote: > On 06/19/2017 10:52 PM, Thomas Huth wrote: >> edu.c does not contain any target-specific code, so we can put >> it into common-obj-y to compile it only once for all targets. >> >> Signed-off-by: Thomas Huth > > Isn't CONFIG_EDU defined by the target

Re: [Qemu-devel] [PATCH qemu v8 2/2] memory/iommu: introduce IOMMUMemoryRegionClass

2017-06-20 Thread Alexey Kardashevskiy
On 14/06/17 16:36, Alexey Kardashevskiy wrote: > This finishes QOM'fication of IOMMUMemoryRegion by introducing > a IOMMUMemoryRegionClass. This also provides a fastpath analog for > IOMMU_MEMORY_REGION_GET_CLASS(). Ping? > > Signed-off-by: Alexey Kardashevskiy > --- > hw/i386/amd_iommu.h

[Qemu-devel] [PATCH 01/16] tcg: Merge opcode arguments into TCGOp

2017-06-20 Thread Richard Henderson
Rather than have a separate buffer of 10*max_ops entries, give each opcode 10 entries. The result is actually a bit smaller and should have slightly more cache locality. Signed-off-by: Richard Henderson --- tcg/optimize.c | 6 ++-- tcg/tcg-op.c | 99 +-

[Qemu-devel] [PATCH 09/16] tcg: Use per-temp state data in liveness

2017-06-20 Thread Richard Henderson
This avoids having to allocate external memory for each temporary. Signed-off-by: Richard Henderson --- tcg/tcg.c | 232 ++ tcg/tcg.h | 6 ++ 2 files changed, 120 insertions(+), 118 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c ind

[Qemu-devel] [PATCH 00/16] Cleanups within TCG middle-end

2017-06-20 Thread Richard Henderson
There are two conceptually unrelated cleanups in here, though the second touches many of the same lines as the first, so separating the two would be ugly. The first is to split gen_opparam_buf and move the pieces into TCGOp. This has two effects: the operands for an op is in the same cacheline as

[Qemu-devel] [PATCH 15/16] tcg: Define separate structures for TCGv_*

2017-06-20 Thread Richard Henderson
Pointers that devolve to TCGTemp will tidy things up. At present, we continue to store indicies in TCGArg. Signed-off-by: Richard Henderson --- tcg/tcg.c | 67 +- tcg/tcg.h | 237 +- 2 files changed, 146 insertions(+),

[Qemu-devel] [PATCH 12/16] tcg: Remove unused TCG_CALL_DUMMY_TCGV

2017-06-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/tcg.h | 1 - 1 file changed, 1 deletion(-) diff --git a/tcg/tcg.h b/tcg/tcg.h index 1eeeca5..4f69d0c 100644 --- a/tcg/tcg.h +++ b/tcg/tcg.h @@ -503,7 +503,6 @@ static inline intptr_t QEMU_ARTIFICIAL GET_TCGV_PTR(TCGv_ptr t) #define TCG_CALL_NO_WG_SE

[Qemu-devel] [PATCH 04/16] tcg: Propagate TCGOp down to allocators

2017-06-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/tcg.c | 82 +++ 1 file changed, 40 insertions(+), 42 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index be5b69c..e2248a6 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -2111,25 +2111,24 @@ static v

[Qemu-devel] [PATCH 02/16] tcg: Propagate args to op->args in optimizer

2017-06-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/optimize.c | 430 ++--- 1 file changed, 227 insertions(+), 203 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 002aad6..1a1c6fb 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -166,8

[Qemu-devel] [PATCH 16/16] tcg: Store pointers to temporaries directly in TCGArg

2017-06-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/tcg.c | 8 tcg/tcg.h | 14 -- 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index 1ca1192..c25f455 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -810,11 +810,11 @@ void tcg_gen_callN(TCGContext *s,

[Qemu-devel] [PATCH 03/16] tcg: Propagate args to op->args in tcg.c

2017-06-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/tcg.c | 121 ++ 1 file changed, 58 insertions(+), 63 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index 298aa0c..be5b69c 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -1054,14 +1054,12 @@ void tcg

[Qemu-devel] [PATCH 05/16] tcg: Introduce arg_temp

2017-06-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/optimize.c | 4 ++-- tcg/tcg.c | 51 +-- tcg/tcg.h | 5 + 3 files changed, 32 insertions(+), 28 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 1a1c6fb..d8c3a7e 100644 --- a/t

[Qemu-devel] [PATCH 10/16] tcg: Avoid loops against variable bounds

2017-06-20 Thread Richard Henderson
Copy s->nb_globals or s->nb_temps to a local variable for the purposes of iteration. This should allow the compiler to use low-overhead looping constructs on some hosts. Signed-off-by: Richard Henderson --- tcg/tcg.c | 27 ++- 1 file changed, 10 insertions(+), 17 deletio

[Qemu-devel] [PATCH 06/16] tcg: Add temp_global bit to TCGTemp

2017-06-20 Thread Richard Henderson
This avoids needing to test the index of a temp against nb_globals. Signed-off-by: Richard Henderson --- tcg/optimize.c | 15 --- tcg/tcg.c | 11 --- tcg/tcg.h | 12 3 files changed, 24 insertions(+), 14 deletions(-) diff --git a/tcg/optimize.c b/tcg/o

[Qemu-devel] [PATCH 13/16] tcg: Export temp_idx

2017-06-20 Thread Richard Henderson
At the same time, drop the TCGContext argument and use tcg_ctx instead. Signed-off-by: Richard Henderson --- tcg/tcg.c | 15 --- tcg/tcg.h | 7 ++- 2 files changed, 10 insertions(+), 12 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index f8d96fa..26931a7 100644 --- a/tcg/tcg.

[Qemu-devel] [PATCH 07/16] tcg: Return NULL temp for TCG_CALL_DUMMY_ARG

2017-06-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/tcg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/tcg.h b/tcg/tcg.h index 3b35344..6c357e7 100644 --- a/tcg/tcg.h +++ b/tcg/tcg.h @@ -730,7 +730,7 @@ extern bool parallel_cpus; static inline TCGTemp *arg_temp(TCGArg a) { -

[Qemu-devel] [PATCH 14/16] tcg: Use per-temp state data in optimize

2017-06-20 Thread Richard Henderson
While we're touching many of the lines anyway, adjust the naming of the functions to better distinguish when "TCGArg" vs "TCGTemp" should be used. Signed-off-by: Richard Henderson --- tcg/optimize.c | 424 + tcg/tcg.h | 5 + 2 files

[Qemu-devel] [PATCH 08/16] tcg: Introduce temp_arg

2017-06-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/tcg.c | 4 ++-- tcg/tcg.h | 7 +++ 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index 0bb88b1..0d758e4 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -1718,7 +1718,7 @@ static bool liveness_pass_2(TCGContext *s, uint8

[Qemu-devel] [PATCH 11/16] tcg: Change temp_allocate_frame arg to TCGTemp

2017-06-20 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/tcg.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index c228f1e..f8d96fa 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -1869,10 +1869,8 @@ static void check_regs(TCGContext *s) } #endif -static void tem

Re: [Qemu-devel] [PATCH v3 06/13] kvm: let kvm use AccelState.global_props

2017-06-20 Thread Peter Xu
On Tue, Jun 20, 2017 at 11:07:34AM -0300, Eduardo Habkost wrote: > On Tue, Jun 20, 2017 at 09:55:03PM +0800, Peter Xu wrote: > > On Mon, Jun 19, 2017 at 01:14:03PM -0300, Eduardo Habkost wrote: [...] > > > This is where things get tricky and fragile: the translation from > > > -cpu to global prop

Re: [Qemu-devel] [PATCH v3 11/13] migration: move only_migratable to MigrationState

2017-06-20 Thread Peter Xu
On Mon, Jun 19, 2017 at 05:50:50PM +0200, Juan Quintela wrote: > Peter Xu wrote: > > One less global variable, and it does only matter with migration. > > > > We keep the old "--only-migratable" option, but also now we support: > > > > -global migration.only-migratable=true > > > > Currently sti

[Qemu-devel] [PATCH] KVM: Add async pf flag to KVM_GET/SET_VCPU_EVENTS interface

2017-06-20 Thread Wanpeng Li
From: Wanpeng Li This patch adds async pf flag to KVM_GET/SET_VCPU_EVENTS interface. Signed-off-by: Wanpeng Li --- linux-headers/asm-x86/kvm.h | 2 ++ target/i386/cpu.h | 1 + target/i386/kvm.c | 6 +- 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/linux-

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v11 6/6] virtio-balloon: VIRTIO_BALLOON_F_CMD_VQ

2017-06-20 Thread Wei Wang
On 06/21/2017 12:18 AM, Michael S. Tsirkin wrote: On Fri, Jun 09, 2017 at 06:41:41PM +0800, Wei Wang wrote: - if (!virtqueue_indirect_desc_table_add(vq, desc, num)) { + if (!virtqueue_indirect_desc_table_add(vq, desc, *num)) { virtqueue_kick(vq); - wait_

[Qemu-devel] Will huge page have negative effect on guest vm in qemu enviroment?

2017-06-20 Thread Sam
Hi all, We plan to use DPDK on HP host machine with several core and big memory. We plan to use qemu-kvm enviroment. The host will carry 4 or more guest vm and 1 ovs. Ovs-dpdk is much faster then normal ovs, but to use ovs-dpdk, we have to enable huge page globally. My question is, will huge pag

Re: [Qemu-devel] [PATCH v3 12/13] migration: move skip_configuration out

2017-06-20 Thread Peter Xu
On Mon, Jun 19, 2017 at 05:56:29PM +0200, Juan Quintela wrote: > Peter Xu wrote: > > It was in SaveState but now moved to MigrationState altogether, reverted > > its meaning, then renamed to "send_configuration". Again, using > > HW_COMPAT_2_3 for old PC/SPAPR machines, and accel_register_prop() f

Re: [Qemu-devel] Will huge page have negative effect on guest vm in qemu enviroment?

2017-06-20 Thread Sam
BTW, we also think about use ovs-dpdk in docker enviroment, but test result said it's not good idea, we don't know why. 2017-06-21 11:32 GMT+08:00 Sam : > Hi all, > > We plan to use DPDK on HP host machine with several core and big memory. > We plan to use qemu-kvm enviroment. The host will carry

Re: [Qemu-devel] [PATCH 00/16] Cleanups within TCG middle-end

2017-06-20 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH 00/16] Cleanups within TCG middle-end Type: series Message-id: 20170621024831.26019-1-...@twiddle.net === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log

Re: [Qemu-devel] [PATCH] KVM: Add async pf flag to KVM_GET/SET_VCPU_EVENTS interface

2017-06-20 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] KVM: Add async pf flag to KVM_GET/SET_VCPU_EVENTS interface Type: series Message-id: 1498014889-52658-1-git-send-email-wanpeng...@hotmail.com === TEST SCRIPT BEGIN ===

[Qemu-devel] [PATCH 2/2] audio/adlib: remove limitation of one adlib card

2017-06-20 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/audio/adlib.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/hw/audio/adlib.c b/hw/audio/adlib.c index be4203476a..6a5d39a8c8 100644 --- a/hw/audio/adlib.c +++ b/hw/audio/adlib.c @@ -74,8 +74,6 @@ typedef struct { Port

[Qemu-devel] [PATCH 0/2] Support multiple adlib sound cards

2017-06-20 Thread Hervé Poussineau
Hi, This patchset removes a global variable in adlib emulation, and allows to have multiple adlib sound cards. Note that indentation seem off because I have replaced some tabulations by spaces. Before: qemu-system-i386 -device adlib,iobase=0x220 -device adlib,iobase=0x240 qemu-system-i386: -devi

[Qemu-devel] [PATCH 1/2] audio/fmopl: modify timer callback to give opaque and channel parameters in two arguments

2017-06-20 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/audio/adlib.c | 2 +- hw/audio/fmopl.c | 18 +- hw/audio/fmopl.h | 7 --- 3 files changed, 18 insertions(+), 9 deletions(-) diff --git a/hw/audio/adlib.c b/hw/audio/adlib.c index c6e0f10c16..be4203476a 100644 --- a/hw/audio/adlib.c +++

Re: [Qemu-devel] [PATCH] xen/disk: don't leak stack data via response ring

2017-06-20 Thread Jan Beulich
>>> On 20.06.17 at 23:48, wrote: > On Tue, 20 Jun 2017, Jan Beulich wrote: >> @@ -36,13 +33,7 @@ struct blkif_x86_32_request_discard { >> blkif_sector_t sector_number;/* start sector idx on disk (r/w only) >> */ >> uint64_t nr_sectors; /* # of contiguous sectors to disc

Re: [Qemu-devel] [PATCH v5 00/24] docker/shippable: cross-build mipsel and powerpc targets

2017-06-20 Thread Fam Zheng
On Tue, 06/20 16:54, Alex Bennée wrote: > > Philippe Mathieu-Daudé writes: > > > This patchset add 2 more architectures to the cross-build farm. > > > > There is still some issue trying to cross-build mips64el-softmmu, it seems > > the > > cross tools use the system outdated libfdt instead of t

Re: [Qemu-devel] [PATCH v2 1/1] qga-win: fix installation on localized windows

2017-06-20 Thread Sameeh Jubran
This patch have been waiting too long for a review, Can someone please review it!! On Thu, Jun 1, 2017 at 3:07 PM, Sameeh Jubran wrote: > Can someone review this patch please? > > On Thu, May 25, 2017 at 2:06 PM, Sameeh Jubran wrote: > >> Ping >> >> On Sun, May 14, 2017 at 3:53 PM, Sameeh Jubra

Re: [Qemu-devel] [PATCHv6 3/5] fw_cfg: move assert() and linking of fw_cfg device to the machine into instance_init()

2017-06-20 Thread Mark Cave-Ayland
On 19/06/17 23:43, Laszlo Ersek wrote: > It looks good to me, but please await Eduardo's reply as well. > > In particular, it should be confirmed that object_resolve_path_type() > matches instances of *subclasses* as well (as I expect it would). Your > test results confirm that; let's make sure i

<    1   2   3