On Fri, Jun 09, 2017 at 04:02:37PM +0200, Markus Armbruster wrote:
> Test compile gripes:
>
> hw/xen/xen-common.c: In function ‘xen_init’:
> hw/xen/xen-common.c:147:5: warning: implicit declaration of function
> ‘register_compat_prop’ [-Wimplicit-function-declaration]
> register_
Can happen with usb-storage devices: ehci_work_bh calls usb-storage,
usb-storage calls into block layer, block layer may run BHs.
Add a simple bool and just do nothing in case we figure ehci_work_bh is
active.
Signed-off-by: Gerd Hoffmann
---
hw/usb/hcd-ehci.h | 1 +
hw/usb/hcd-ehci.c | 7 +
On Fri, Jun 09, 2017 at 10:40:10AM -0300, Eduardo Habkost wrote:
> On Fri, Jun 09, 2017 at 11:48:59AM +0800, Peter Xu wrote:
> > Put it into MigrationState then we can use the properties to specify
> > whether to enable storing global state.
> >
> > Removing global_state_set_optional() since now w
On Wed, 2017-06-07 at 21:02 +, Marc-André Lureau wrote:
> Hi
>
> The patch looks good to me, but I tried to use egl-headless for the
> first time, and I get a weird crash on virgl init:
> (gdb) bt
> #0 0x7fffd8cd935f in rawmemchr () at /lib64/libc.so.6
> #1 0x7fffd8cc1832 in _IO_str_
Hi,
> It's a bit weird to have win_fb used without being really
> initialized.
>
> Furthermore, there doesn't seem to be guarantee that
> glGenFramebuffers(1, &fb->framebuffer) will make only non-0 values.
0 is reserved for the default framebuffer of the current context, i.e.
the sdl window in
On Mon, Jun 12, 2017 at 11:02:33AM +0530, Bharata B Rao wrote:
> This patchset fixes the migration of sPAPR radix guests.
>
> Migration of hash and radix guests individually has been tested on
> TCG and KVM (P8 and P9 hosts). Changeover from HPT to RPT and vice versa
> via reboot during migration
On Sun, Jun 11, 2017 at 4:58 PM, Mark Cave-Ayland
wrote:
> On 10/06/17 19:05, Philippe Mathieu-Daudé wrote:
>
>> Hi Mark,
>>
>> I'm not sure having this patch split from the previous (2/3) really
>> helps bisecting, I'd rather squash them altogether.
>>
>> Either way:
>>
>> Reviewed-by: Philippe M
On Thu, Jun 01, 2017 at 11:29:11PM +0200, Juan Quintela wrote:
> All callers were calling migrate_get_current(), so do it inside the function.
>
> Signed-off-by: Juan Quintela
Reviewed-by: Peter Xu
--
Peter Xu
On Thu, Jun 01, 2017 at 11:29:12PM +0200, Juan Quintela wrote:
> Signed-off-by: Juan Quintela
Reviewed-by: Peter Xu
--
Peter Xu
On 06/09/2017 02:08 PM, Jason Wang wrote:
On 2017年06月07日 17:55, Zhang Chen wrote:
We add the vnet_hdr_support option for filter-mirror, default is
disable.
s/disable/disabled/
If you use virtio-net-pci net driver, please enable it.
You can use it for example:
-object
filter-mirror,id=m0
Ping for comments, thanks.
On 06/09/2017 11:00 AM, Wei Wang wrote:
On 06/09/2017 03:01 AM, Michael S. Tsirkin wrote:
On Wed, Jun 07, 2017 at 09:04:29AM +0800, Wei Wang wrote:
On 06/05/2017 11:38 PM, Michael S. Tsirkin wrote:
On Mon, Jun 05, 2017 at 04:57:29PM +0800, Wei Wang wrote:
This patc
On Thu, Jun 01, 2017 at 11:29:13PM +0200, Juan Quintela wrote:
> They are indpendent, and nowadays almost every device register things
> with qdev->vmsd.
>
> Signed-off-by: Juan Quintela
> ---
> hw/net/vmxnet3.c | 1 +
> hw/ppc/spapr.c | 1 +
> hw/s390x/s390-skeys.c
On Mon, May 08, 2017 at 10:15:27AM -0400, Stefan Hajnoczi wrote:
> v6:
> * Change bdrv_measure() return type to BlockMeasureInfo * [Eric]
> * Clarify that holes in sparse POSIX files are still counted [Eric]
>
> v5:
> * Use UINT64_MAX instead of ~0ULL [Berto]
> * Document qemu-img measure ofmt
On Thu, Jun 01, 2017 at 11:29:14PM +0200, Juan Quintela wrote:
> It was not from vmstate.c to start with.
>
> Signed-off-by: Juan Quintela
Reviewed-by: Peter Xu
> ---
> include/migration/misc.h| 4
> include/migration/vmstate.h | 2 --
> 2 files changed, 4 insertions(+), 2 deletions(
On 11/06/2017 14:37, Max Reitz wrote:
> qemu proper has done so for 13 years
> (8a7ddc38a60648257dc0645ab4a05b33d6040063), qemu-img and qemu-io have
> done so for four years (526eda14a68d5b3596be715505289b541288ef2a).
> Ignoring this signal is especially important in qemu-nbd because
> otherwise
On Mon, Jun 12, 2017 at 11:02:35AM +0530, Bharata B Rao wrote:
> Fix migration of radix guests by ensuring that we issue
> KVM_PPC_CONFIGURE_V3_MMU for radix case post migration.
>
> Reported-by: Nageswara R Sastry
> Signed-off-by: Bharata B Rao
> Reviewed-by: Suraj Jitindar Singh
I believe we
On 7 June 2017 at 17:22, Paolo Bonzini wrote:
> The following changes since commit 65dfad62a176f5265f801683be64149c5ad55f7d:
>
> Merge remote-tracking branch 'remotes/xtensa/tags/20170606-xtensa' into
> staging (2017-06-06 17:00:12 +0100)
>
> are available in the git repository at:
>
> git://
On Mon, Jun 12, 2017 at 11:02:34AM +0530, Bharata B Rao wrote:
> Add a "no HPT" encoding (using value -1) to the HTAB migration
> stream (in the place of HPT size) when the guest doesn't allocate HPT.
> This will help the target side to match target HPT with the source HPT
> and thus enable success
On Thu, Jun 01, 2017 at 11:29:19PM +0200, Juan Quintela wrote:
> Signed-off-by: Juan Quintela
Reviewed-by: Peter Xu
--
Peter Xu
On Thu, Jun 01, 2017 at 11:29:20PM +0200, Juan Quintela wrote:
> Nothing uses it outside of migration.h
>
> Signed-off-by: Juan Quintela
Reviewed-by: Peter Xu
--
Peter Xu
* Alexey Perevalov (a.pereva...@samsung.com) wrote:
> This modification is necessary for userfault fd features which are
> required to be requested from userspace.
> UFFD_FEATURE_THREAD_ID is a one of such "on demand" feature, which will
> be introduced in the next patch.
>
> QEMU have to use sepa
On Mon 08 May 2017 04:15:34 PM CEST, Stefan Hajnoczi wrote:
> The measure subcommand calculates the size required by a new image file.
> This can be used by users or management tools that need to allocate
> space on an LVM volume, SAN LUN, etc before creating or converting an
> image file.
>
> Sugg
On 01/06/2017 23:29, Juan Quintela wrote:
> All callers were calling migrate_get_current(), so do it inside the function.
>
> Signed-off-by: Juan Quintela
Reviewed-by: Laurent Vivier
> ---
> migration/channel.c | 5 +++--
> migration/channel.h | 3 +--
> migration/exec.c| 2 +-
> migratio
On 7 June 2017 at 18:50, Kevin Wolf wrote:
> The following changes since commit b55a69fe5f0a504dac6359bb7e99a72b130c3661:
>
> Merge remote-tracking branch 'remotes/juanquintela/tags/migration/20170607'
> into staging (2017-06-07 15:06:42 +0100)
>
> are available in the git repository at:
>
>
>
Hi,
I am newbie to qemu. Recently, I am reading the code and found one question.
I can see some property function is added to the object. But I wonder
when these
property functions are called or triggered. When I try to trace them,
only the initialization
is found. I found some unclear lin
Emilio G. Cota writes:
> On Sat, Jun 10, 2017 at 09:59:19 -0700, Richard Henderson wrote:
>> On 06/10/2017 01:51 AM, Alex Bennée wrote:
>> >I would agree with Emilio that we revert but I can't quite shake the
>> >feeling we are missing an underlying problem. Would just skipping the
>> >htable lo
On 01/06/2017 23:29, Juan Quintela wrote:
> Signed-off-by: Juan Quintela
> ---
> hw/net/virtio-net.c | 1 +
> include/migration/misc.h| 10 ++
> include/migration/vmstate.h | 10 --
> migration/savevm.c | 1 +
> 4 files changed, 12 insertions(+), 10 deletion
Laurent Vivier wrote:
> On 01/06/2017 23:29, Juan Quintela wrote:
>> Signed-off-by: Juan Quintela
>> ---
>> hw/net/virtio-net.c | 1 +
>> include/migration/misc.h| 10 ++
>> include/migration/vmstate.h | 10 --
>> migration/savevm.c | 1 +
>> 4 files change
Peter Xu wrote:
> On Thu, Jun 01, 2017 at 11:29:13PM +0200, Juan Quintela wrote:
>> They are indpendent, and nowadays almost every device register things
>> with qdev->vmsd.
>>
>> Signed-off-by: Juan Quintela
>> +
>> +int register_savevm(DeviceState *dev,
>> +const char *ids
On 9 June 2017 at 14:46, Markus Armbruster wrote:
> The following changes since commit 64175afc695c0672876fbbfc31b299c86d562cb4:
>
> arm_gicv3: Fix ICC_BPR1 reset value when EL3 not implemented (2017-06-07
> 17:21:44 +0100)
>
> are available in the git repository at:
>
> git://repo.or.cz/qemu
On 01/06/2017 23:29, Juan Quintela wrote:
> It was not from vmstate.c to start with.
>
> Signed-off-by: Juan Quintela
Reviewed-by: Laurent Vivier
> ---
> include/migration/misc.h| 4
> include/migration/vmstate.h | 2 --
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --
On 12/06/2017 12:35, Juan Quintela wrote:
> Laurent Vivier wrote:
>> On 01/06/2017 23:29, Juan Quintela wrote:
>>> Signed-off-by: Juan Quintela
>>> ---
>>> hw/net/virtio-net.c | 1 +
>>> include/migration/misc.h| 10 ++
>>> include/migration/vmstate.h | 10 --
>>> mi
On 01/06/2017 23:29, Juan Quintela wrote:
> Signed-off-by: Juan Quintela
Reviewed-by: Laurent Vivier
> ---
> include/migration/migration.h | 15 ---
> migration/savevm.h| 15 +++
> migration/vmstate.c | 1 +
> tests/test-vmstate.c | 1 +
Hi
- Original Message -
> On 9 June 2017 at 14:46, Markus Armbruster wrote:
> > The following changes since commit
> > 64175afc695c0672876fbbfc31b299c86d562cb4:
> >
> > arm_gicv3: Fix ICC_BPR1 reset value when EL3 not implemented (2017-06-07
> > 17:21:44 +0100)
> >
> > are available i
* Alexey Perevalov (a.pereva...@samsung.com) wrote:
> This patch adds ability to track down already copied
> pages, it's necessary for calculation vCPU block time in
> postcopy migration feature, maybe for restore after
> postcopy migration failure.
> Also it's necessary to solve shared memory issu
Am 08.06.2017 um 20:21 hat Manos Pitsidianakis geschrieben:
> In continuation of the discussion at [0], here follows a proposal
> for a new ThrottleGroup object defined through QOM.
>
> Throttle groups are currently defined when instantiating a drive in
> the command line,, eg. -drive
> file=foo.
On Sat, 10 Jun 2017 13:30:16 +0100
Mark Cave-Ayland wrote:
> Signed-off-by: Mark Cave-Ayland
> ---
> hw/nvram/fw_cfg.c | 14 ++
> 1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c
> index 316fca9..144e0c6 100644
> --- a/hw/nvr
* Alexey Perevalov (a.pereva...@samsung.com) wrote:
> This patch provides blocktime calculation per vCPU,
> as a summary and as a overlapped value for all vCPUs.
>
> This approach was suggested by Peter Xu, as an improvements of
> previous approch where QEMU kept tree with faulted page address and
On 01/06/2017 23:29, Juan Quintela wrote:
> So, move them there. Notice that we export functions that send
> commands, not the command themselves.
>
> Signed-off-by: Juan Quintela
Reviewed-by: Laurent Vivier
> ---
> include/migration/migration.h | 15 --
> migration/migration.c
On Sat, 10 Jun 2017 13:30:18 +0100
Mark Cave-Ayland wrote:
> The dma_enabled property enables us to set the FW_CFG_ID version
> accordingly.
it might be not safe as patch reorders FW_CFG_ID entry.
(I recall there were patches that sorted fwcfg entries,
but it's worth checking that it won't break
On 01/06/2017 23:29, Juan Quintela wrote:
> Signed-off-by: Juan Quintela
Reviewed-by: Laurent Vivier
> ---
> include/migration/migration.h | 18 --
> migration/qemu-file.h | 17 +
> 2 files changed, 17 insertions(+), 18 deletions(-)
>
> diff --git a/inc
On Sat, 10 Jun 2017 13:30:17 +0100
Mark Cave-Ayland wrote:
patch needs a commit message saying why it's needed.
maybe add something similar to:
qdev_init_nofail() essentially 'realizes' object,
taking in account that fw_cfg_init1() will be moved to
realize in follow up patches, move qdev_init_no
On 01/06/2017 23:29, Juan Quintela wrote:
> It don't belong anywhere else, just the global state where everybody
> can stick other things.
>
> Signed-off-by: Juan Quintela
Reviewed-by: Laurent Vivier
> ---
> hw/i386/pc_piix.c| 1 +
> hw/ppc/spapr.c | 1 +
On 12/06/17 12:20, Igor Mammedov wrote:
> On Sat, 10 Jun 2017 13:30:16 +0100
> Mark Cave-Ayland wrote:
>
>> Signed-off-by: Mark Cave-Ayland
>> ---
>> hw/nvram/fw_cfg.c | 14 ++
>> 1 file changed, 10 insertions(+), 4 deletions(-)
>>
>> diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_
On 12/06/17 12:37, Igor Mammedov wrote:
> On Sat, 10 Jun 2017 13:30:18 +0100
> Mark Cave-Ayland wrote:
>
>> The dma_enabled property enables us to set the FW_CFG_ID version
>> accordingly.
> it might be not safe as patch reorders FW_CFG_ID entry.
>
> (I recall there were patches that sorted fwc
On 12 June 2017 at 11:52, Marc-André Lureau wrote:
>> On 9 June 2017 at 14:46, Markus Armbruster wrote:
>> Can you fix and resend the pullreq, please?
>
> Markus made me switch from g_assert_not_reached() to assert(0) in v3.
>
> He is on PTO this week, if you don't mind (as you wanted this
> seri
On 01/06/2017 23:29, Juan Quintela wrote:
> Nothing uses it outside of migration.h
>
> Signed-off-by: Juan Quintela
Reviewed-by: Laurent Vivier
> ---
> migration/block.c| 2 +-
> migration/channel.c | 2 +-
> migration/colo-comm.c
* Juan Quintela (quint...@redhat.com) wrote:
> Once there, create populate_disk_info.
>
> Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
>
> --
>
> - create populate_disk_info instead of "abusing" populate_ram_info
> ---
> migration/migration.c | 31 +--
On 12/06/17 12:43, Igor Mammedov wrote:
> On Sat, 10 Jun 2017 13:30:17 +0100
> Mark Cave-Ayland wrote:
>
> patch needs a commit message saying why it's needed.
> maybe add something similar to:
>
> qdev_init_nofail() essentially 'realizes' object,
> taking in account that fw_cfg_init1() will be
* Juan Quintela (quint...@redhat.com) wrote:
> Merge them.
>
> Signed-off-by: Juan Quintela
> Reviewed-by: Eric Blake
Reviewed-by: Dr. David Alan Gilbert
> ---
> migration/migration.c | 14 +-
> 1 file changed, 1 insertion(+), 13 deletions(-)
>
> diff --git a/migration/migration
On 07/06/2017 12:58, Juan Quintela wrote:
> Once there, create populate_disk_info.
>
> Signed-off-by: Juan Quintela
Reviewed-by: Laurent Vivier
>
> --
>
> - create populate_disk_info instead of "abusing" populate_ram_info
> ---
> migration/migration.c | 31 +--
>
On 07/06/2017 12:58, Juan Quintela wrote:
> Merge them.
>
> Signed-off-by: Juan Quintela
> Reviewed-by: Eric Blake
Reviewed-by: Laurent Vivier
> ---
> migration/migration.c | 14 +-
> 1 file changed, 1 insertion(+), 13 deletions(-)
>
> diff --git a/migration/migration.c b/migrat
On Sat, 10 Jun 2017 13:30:19 +0100
Mark Cave-Ayland wrote:
> And rename to fw_cfg_common_realize() which better describes its role.
>
> Signed-off-by: Mark Cave-Ayland
> ---
> hw/nvram/fw_cfg.c |8 +---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/hw/nvram/fw_cfg
On Sat, 10 Jun 2017 13:30:20 +0100
Mark Cave-Ayland wrote:
> This brings the function in line with fw_cfg_mem_realize(), deferring the
> actual mapping until outside of the realize function.
you are changing used API here, so add to commit message why is that
>
> Signed-off-by: Mark Cave-Ayland
Signed-off-by: Eduardo Otubo
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 120788d..0d065a0 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1490,7 +1490,7 @@ F: tests/vmstate-static-checker-data/
F: docs/migration.txt
Seccom
* Eduardo Otubo (ot...@redhat.com) wrote:
> Signed-off-by: Eduardo Otubo
> ---
> MAINTAINERS | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 120788d..0d065a0 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1490,7 +1490,7 @@ F: tests
* Alexey Perevalov (a.pereva...@samsung.com) wrote:
> This commit duplicates header of "userfaultfd: provide pid in userfault msg"
> into linux kernel.
>
> Signed-off-by: Alexey Perevalov
OK, so this isn't yet merged into Linus' tree from what I can tell;
we need to wait until it gets merged, an
On Fri 09 Jun 2017 06:06:09 PM CEST, Manos Pitsidianakis wrote:
>>> -drive file=foo.qcow2,throttling.group=bar \
>>> -object throttle-group,iops-total=100,id=bar
>>
>>, and I guess the name would be throttling-group?
>
> Hm, I thought throttle-group would be nicer because it's shorter, but
On 10/06/2017 15:54, ??6A wrote:
> Hello Qemu-devel,
>
> Recently I'm trying to study vm memory allocation on qemu-kvm environment.
> I found some interesting here:
>
> I have create a 8GB(8388608 k) memory guest using Centos 7. but when I using
> dmesg to show the init memory,
> it was 9437
On 12/06/17 13:16, Igor Mammedov wrote:
> On Sat, 10 Jun 2017 13:30:20 +0100
> Mark Cave-Ayland wrote:
>
>> This brings the function in line with fw_cfg_mem_realize(), deferring the
>> actual mapping until outside of the realize function.
> you are changing used API here, so add to commit messag
On Fri 09 Jun 2017 04:53:05 PM CEST, Eric Blake wrote:
> Let's suppose we have a guest issuing 512-byte aligned requests and a
> host that requires 4k alignment; and the guest does an operation that
> needs a COW with one sector at both the front and end of the cluster.
>
>> @@ -760,22 +776,59 @@ s
On Mon, 2017-06-12 at 13:37 +0200, Igor Mammedov wrote:
> On Sat, 10 Jun 2017 13:30:18 +0100
> Mark Cave-Ayland wrote:
>
> > The dma_enabled property enables us to set the FW_CFG_ID version
> > accordingly.
>
> it might be not safe as patch reorders FW_CFG_ID entry.
>
> (I recall there were pat
On 7 June 2017 at 18:54, Daniel P. Berrange wrote:
> The following changes since commit 0db1851becbefe3e50cfc03776fb1f75817376af:
>
> Merge remote-tracking branch
> 'remotes/vivier/tags/m68k-for-2.10-pull-request' into staging (2017-06-07
> 11:56:00 +0100)
>
> are available in the git reposito
Guest using kvmclock will be hanged when migrating from unstable
tsc host to stable tsc host occasionally.
Sometimes, the tsc timestamp saved at the source side will be
backward when the guest stopped, and this value is transferred
to the destination side. The guest at the destination side thought
Guest using kvmclock will be hanged when migrating from unstable
tsc host to stable tsc host occasionally.
Sometimes, the tsc timestamp saved at the source side will be
backward when the guest stopped, and this value is transferred
to the destination side. The guest at the destination side thought
On Mon, May 22, 2017 at 02:57:00PM +0100, Stefan Hajnoczi wrote:
> v3:
> * Add missing bdrv_drain_all_end() in error code paths [Kevin]
> v2:
> * New patch to use bdrv_drain_all_begin/end() in savevm/loadvm [Kevin]
>(All other patches unchanged)
>
> The 'savevm' command hangs when -object io
On Mon, Jun 05, 2017 at 11:42:14AM +0100, Stefan Hajnoczi wrote:
> It's nice to have HMP and QMP commands as part of a trace log. This makes it
> possible to correlate QEMU-internal events with the monitor commands that
> caused them.
>
> Stefan Hajnoczi (2):
> monitor: add handle_hmp_command t
hi all，
I'm debuging ovs-2.6.0, dpdk-2.2.0 and qemu-2.6.0. And I run such command:
QEMU_CMD -D qemu-log.log -trace events=qemu-events ...
I want to trace vhost-user protocol process between QEMU and ovs-dpdk.
Ovs-dpdk's log shows lots of infomations of vhost-user protocol, but QEMU's
log shows o
On 7 June 2017 at 19:07, Stefan Hajnoczi wrote:
> The following changes since commit 0db1851becbefe3e50cfc03776fb1f75817376af:
>
> Merge remote-tracking branch
> 'remotes/vivier/tags/m68k-for-2.10-pull-request' into staging (2017-06-07
> 11:56:00 +0100)
>
> are available in the git repository
Comments for pci_add_capability2() to explain the return
value. This may help to make a correct return value check
for its callers.
Cc: m...@redhat.com
Cc: mar...@redhat.com
Cc: arm...@redhat.com
Suggested-by: Markus Armbruster
Signed-off-by: Mao Zhongyi
---
hw/pci/pci.c | 6 ++
1 file chan
When the function no success value to transmit, it usually make the
function return void. It has turned out not to be a success, because
it means that the extra local_err variable and error_propagate() will
be needed. It leads to cumbersome code, therefore, transmit success/
failure in the return v
On success, pci_add_capability2() returns a positive value. On
failure, it sets an error and return a negative value.
pci_add_capability() laboriously checks this behavior. No other
caller does. Drop the checks from pci_add_capability().
Cc: m...@redhat.com
Cc: mar...@redhat.com
Signed-off-by: Ma
On Mon, Jun 12, 2017 at 12:05:12AM -0400, Jeff Cody wrote:
> We need to be able to parse the 'filename' option for both rbd and iscsi,
> because there may exist images in the wild that have json backing files,
> that specify the filename argument.
>
> Marking the series as RFC at least partially f
In order to propagate error message better, convert shpc_init() to
Error also convert the pci_bridge_dev_initfn() to realize.
Cc: m...@redhat.com
Cc: mar...@redhat.com
Cc: arm...@redhat.com
Signed-off-by: Mao Zhongyi
---
hw/pci-bridge/pci_bridge_dev.c | 21 -
hw/pci/shpc.c
This series mainly implements the conversions of pci-bridge devices
i82801b11, io3130_upstream/downstream and so on to realize(). Naturally
part of error messages need to be converted to Error, then propagate
to its callers via the argument errp, bonus clean related minor flaw
up. In short, the for
The pci-birdge device i82801b11 and io3130_upstream/downstream
still implements the old PCIDeviceClass .init() through *_init()
instead of the new .realize(). All devices need to be converted
to .realize(). So convert it and rename it to *_realize().
Cc: m...@redhat.com
Cc: mar...@redhat.com
Cc: a
Add Error argument for pci_add_capability() to leverage the errp
to pass info on errors. This way is helpful for its callers to
make a better error handling when moving to 'realize'.
Cc: pbonz...@redhat.com
Cc: r...@twiddle.net
Cc: ehabk...@redhat.com
Cc: m...@redhat.com
Cc: jasow...@redhat.com
Cc
After the patch 'Make errp the last parameter of pci_add_capability()',
pci_add_capability() and pci_add_capability2() now do exactly the same.
So drop the wrapper pci_add_capability() of pci_add_capability2(), then
replace the pci_add_capability2() with pci_add_capability() everywhere.
Cc: pbonz.
On Thu, Jun 08, 2017 at 09:21:13PM +0300, Manos Pitsidianakis wrote:
> The old interface will be retained as much as possible.
I think "retained" means "reused" here but in case it doesn't:
The old interface must remain 100% functional. Existing software like
libvirt must continue to work withou
In assigned_device_pci_cap_init(), first, error messages are filled
to a local_err variable, then through error_propagate() pass to
the parameter of errp. It leads to cumbersome code. In order to
avoid the extra local_err and error_propagate(), drop it and use
errp instead.
Cc: pbonz...@redhat.com
pci_add_capability returns a strictly positive value on success,
correct asserts.
Cc: dmi...@daynix.com
Cc: jasow...@redhat.com
Cc: kra...@redhat.com
Cc: alex.william...@redhat.com
Cc: arm...@redhat.com
Signed-off-by: Mao Zhongyi
---
hw/net/e1000e.c | 2 +-
hw/net/eepro100.c | 2 +-
hw/usb/hcd
On Fri, Jun 02, 2017 at 03:51:51PM +0200, Kevin Wolf wrote:
> Am 02.06.2017 um 03:47 hat Qu Wenruo geschrieben:
> > When going through NVMe specification and hw/block/nvme.c,
> > I found that it seems that NVMe qemu implementation only support PRP
> > for sq entry.
> > And NvmeRwCmd doesn't even us
On Thu, Jun 08, 2017 at 09:21:13PM +0300, Manos Pitsidianakis wrote:
> Users can hotplug ThrottleGroups with object-add in QMP/HMP, then
> attach drives to a throttle group (ie adding a filter node in the drive path
> that points to that throttle group) with an 'attach-throttle' and detach
> with '
On 06/09/2017 03:41 AM, Wei Wang wrote:
> + for_each_populated_zone(zone) {
> + for (order = MAX_ORDER - 1; order > 0; order--) {
> + for (migratetype = 0; migratetype < MIGRATE_TYPES;
> + migratetype++) {
> +
Please stop cc'ing me on things also sent to closed mailing lists
(virtio-...@lists.oasis-open.org). I'm happy to review things on open
lists, but I'm not fond of the closed lists bouncing things at me.
On 06/09/2017 03:41 AM, Wei Wang wrote:
> Add a function to find a page block on the free list
In the net_socket_fd_init(), the 'default' case and comment is odd.
If @fd really was a pty, getsockopt() would fail with ENOTSOCK. If
@fd was a socket, but neither SOCK_DGRAM nor SOCK_STREAM. It should
not be treated as if it was SOCK_STREAM.
If there is a genuine reason to support something like
Daniel's patch(commit 6701e551, Revert "Change net/socket.c to use socket_*()
functions" again) has been in upstream. Continue this patchset.
In v2, this series convert the non-blocking connect mechanism to QIOchannel
by replace the socket_connect(), and some errors also are converted to Error.
On 2017-06-12 05:19, Philippe Mathieu-Daudé wrote:
> Hi Tsung-en,
>
> On 06/11/2017 04:08 PM, Tsung-en Hsiao wrote:
>> Hi all,
>> I encountered the same problem on gcc 7.1.1 and found Qu's mail in
>> this list from google search.
>>
>> Temporarily fix it by specifying the string length in snprintf
When -net socket fails, it first reports a specific error, then
a generic one, like this:
$ qemu-system-x86_64 -net socket,
qemu-system-x86_64: -net socket: exactly one of fd=, listen=, connect=,
mcast= or udp= is required
qemu-system-x86_64: -net socket: Device 'socket' could not be
Cc: berra...@redhat.com
Cc: kra...@redhat.com
Cc: pbonz...@redhat.com
Cc: jasow...@redhat.com
Cc: arm...@redhat.com
Signed-off-by: Mao Zhongyi
---
include/qemu/sockets.h | 2 +-
net/net.c | 21 -
net/socket.c | 37 ++---
Currently, net_socket_mcast_create(), net_socket_fd_init_dgram() and
net_socket_fd_init() use the function such as fprintf(), perror() to
report an error message.
Now, convert these functions to Error.
Cc: jasow...@redhat.com
Cc: arm...@redhat.com
Cc: berra...@redhat.com
Signed-off-by: Mao Zhongy
On Thu, Jun 08, 2017 at 03:43:27PM +0200, Greg Kurz wrote:
> Commit 5bc8d26de20c ("spapr: allocate the ICPState object from under
> sPAPRCPUCore") moved ICPState objects from the machine to CPU cores.
> This is an improvement since we no longer allocate ICPState objects
> that will never be used. B
On Thu, Jun 08, 2017 at 03:43:18PM +0200, Greg Kurz wrote:
> The ICPState objects are currently registered to vmstate as qdev objects.
> Their instance ids are hence computed automatically in the migration code,
> and thus depends on the order the CPU cores were plugged.
>
> If the destination had
On Fri, Jun 09, 2017 at 01:18:08PM +0300, Manos Pitsidianakis wrote:
> Change the 'int count' parameter in *pwrite_zeros, *pdiscard related
> functions (and some others) to 'int bytes', as they both refer to bytes.
> This helps with code legibility.
>
> Signed-off-by: Manos Pitsidianakis
> ---
P
On Thu, Jun 08, 2017 at 11:54:10AM +0200, Greg Kurz wrote:
> On Thu, 8 Jun 2017 14:08:57 +1000
> David Gibson wrote:
>
> > On Wed, Jun 07, 2017 at 07:17:26PM +0200, Greg Kurz wrote:
> > > Commit 5bc8d26de20c ("spapr: allocate the ICPState object from under
> > > sPAPRCPUCore") moved ICPState obje
On Sun, Jun 11, 2017 at 02:37:14PM +0200, Max Reitz wrote:
> qemu proper has done so for 13 years
> (8a7ddc38a60648257dc0645ab4a05b33d6040063), qemu-img and qemu-io have
> done so for four years (526eda14a68d5b3596be715505289b541288ef2a).
> Ignoring this signal is especially important in qemu-nbd b
On 7 June 2017 at 19:55, Stefan Hajnoczi wrote:
> The following changes since commit 0db1851becbefe3e50cfc03776fb1f75817376af:
>
> Merge remote-tracking branch
> 'remotes/vivier/tags/m68k-for-2.10-pull-request' into staging (2017-06-07
> 11:56:00 +0100)
>
> are available in the git repository
On Thu, Jun 08, 2017 at 03:35:58PM -0300, Daniel Henrique Barboza wrote:
>
>
> On 06/08/2017 02:27 PM, Laurent Vivier wrote:
> > If the OS is not started, QEMU sends an event to the OS
> > that is lost and cannot be recovered. An unplug is not
> > able to restore QEMU in a coherent state.
> > So,
On Thu, Jun 08, 2017 at 07:27:42PM +0200, Laurent Vivier wrote:
> If the OS is not started, QEMU sends an event to the OS
> that is lost and cannot be recovered. An unplug is not
> able to restore QEMU in a coherent state.
> So, while the OS is not started, disable CPU and memory hotplug.
> We gues
This series proposes a generic (target-agnostic) instruction translation
framework.
It basically provides a generic main loop for instruction disassembly, which
calls target-specific functions when necessary. This generalization makes
inserting new code in the main loop easier, and helps in keepin
1 - 100 of 178 matches
Mail list logo
