On 12/06/17 12:43, Igor Mammedov wrote: > On Sat, 10 Jun 2017 13:30:17 +0100 > Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> wrote: > > patch needs a commit message saying why it's needed. > maybe add something similar to: > > qdev_init_nofail() essentially 'realizes' object, > taking in account that fw_cfg_init1() will be moved to > realize in follow up patches, move qdev_init_nofail() outside of > fw_cfg_init1().
Yes, I can alter the commit message to provide more explanation. For some background the use case can be found in my follow-up sun4u patches here (i.e. preparation for moving the ebus device behind a PCI bridge): https://lists.nongnu.org/archive/html/qemu-devel/2017-06/msg02658.html https://lists.nongnu.org/archive/html/qemu-devel/2017-06/msg02656.html ATB, Mark.