Re: [Qemu-devel] [PATCH 1/5] spapr: Introduce DRC subclasses

2017-06-04 Thread David Gibson
On Sat, Jun 03, 2017 at 05:05:26PM -0500, Michael Roth wrote: > Quoting David Gibson (2017-06-02 02:29:48) > > Currently we only have a single QOM type for all DRCs, but lots of > > places where we switch behaviour based on the DRC's PAPR defined type. > > This is a poor use of our existing type sy

Re: [Qemu-devel] [PATCH 3/5] spapr: Move configure-connector state into DRC

2017-06-04 Thread David Gibson
On Sat, Jun 03, 2017 at 05:24:23PM -0500, Michael Roth wrote: > Quoting David Gibson (2017-06-02 02:29:50) > > Currently the sPAPRMachineState contains a of sPAPRConfigureConnector > > "contains a list"? Ta, corrected. > > structures which store intermediate state for the ibm,configure-connector

Re: [Qemu-devel] [virtio-dev] Re: [virtio-dev] Re: [virtio-dev] Re: [PATCH v2 00/16] Vhost-pci for inter-VM communication

2017-06-04 Thread Wei Wang
On 05/26/2017 01:57 AM, Michael S. Tsirkin wrote: I think that's a very valid point. Linux isn't currently optimized to handle packets in device BAR. There are several issues here and you do need to address them in the kernel, no way around that: 1. lots of drivers set protection to v

Re: [Qemu-devel] [PATCHv4 0/5] Clean up compatibility mode handling

2017-06-04 Thread David Gibson
On Fri, Jun 02, 2017 at 10:15:25AM +0200, Greg Kurz wrote: > On Fri, 2 Jun 2017 12:00:07 +1000 > David Gibson wrote: > > > On Thu, Jun 01, 2017 at 03:09:15PM +0200, Greg Kurz wrote: > > > On Thu, 1 Jun 2017 13:59:14 +0200 > > > Cédric Le Goater wrote: > > > > > > > On 06/01/2017 08:52 AM, Dav

[Qemu-devel] [PULL 02/22] qemu-doc: Add hyperlinks to further license information

2017-06-04 Thread Michael Tokarev
From: Thomas Huth Add a link to the GPLv2 and a link to the LICENSE file in the QEMU repository to fix the two TODO items in this appendix. Signed-off-by: Thomas Huth Reviewed-by: Stefan Hajnoczi Signed-off-by: Michael Tokarev --- qemu-doc.texi | 8 1 file changed, 4 insertions(+),

[Qemu-devel] [PULL 08/22] trivial: Remove unneeded ifndef in memory.h

2017-06-04 Thread Michael Tokarev
From: Juan Quintela All the file is surounded already by #ifndef CONFIG_USER_ONLY. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Laurent Vivier Signed-off-by: Michael Tokarev --- include/exec/memory.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/inclu

[Qemu-devel] [PULL 10/22] target/arm: add data cache invalidation cp15 instruction to cortex-r5

2017-06-04 Thread Michael Tokarev
From: Luc MICHEL The cp15, CRn=15, opc1=0, CRm=5, opc2=0 instruction invalidates all the data cache on the cortex-r5. Implementing it as a NOP. Signed-off-by: Luc MICHEL Signed-off-by: Michael Tokarev --- target/arm/cpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/arm/cpu.c

[Qemu-devel] [PULL 07/22] altera_timer: fix incorrect memset

2017-06-04 Thread Michael Tokarev
From: Paolo Bonzini Use sizeof instead of ARRAY_SIZE, fixing -Wmemset-elt-size with recent GCC versions. Signed-off-by: Paolo Bonzini Reviewed-by: Laurent Vivier Signed-off-by: Michael Tokarev --- hw/timer/altera_timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/

[Qemu-devel] [PULL 05/22] tests/libqtest: Print error instead of aborting when env variable is missing

2017-06-04 Thread Michael Tokarev
From: Thomas Huth When you currently try to run a test directly from the command line without setting the QTEST_QEMU_BINARY environment variable first, you are presented with an unhelpful assertion message like this: ERROR:tests/libqtest.c:163:qtest_init_without_qmp_handshake: assertion failed

[Qemu-devel] [PULL 22/22] hw/core: nmi.c can be compiled as common-obj nowadays

2017-06-04 Thread Michael Tokarev
From: Thomas Huth The target-specific code in nmi.c has been removed with this commit: commit f7e981f29548fe4af7812f5920304fe607e5bf0d nmi: remove x86 specific nmi handling Signed-off-by: Thomas Huth Reviewed-by: Juan Quintela Signed-off-by: Michael Tokarev --- hw/core/Makef

[Qemu-devel] [PULL 00/22] Trivial patches for 2017-06-04

2017-06-04 Thread Michael Tokarev
Trivial patches for 04 Jun 2017. Please consider applying. /mjt The following changes since commit c6e84fbd447a51e1161d74d71566a5f67b47eac5: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2017-06-02 17:46:22 +0100) are available in the git repository at: git://

[Qemu-devel] [PULL 11/22] hw/xtensa: sim: use g_string/g_new

2017-06-04 Thread Michael Tokarev
From: Max Filippov Replace malloc/free/sprintf with g_string/g_string_printf/g_string_free. Replace g_malloc with g_new when allocating the MemoryRegion to get more type safety. Suggested-by: Alex Bennée Signed-off-by: Max Filippov Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Michael To

Re: [Qemu-devel] [PATCH v2 1/4] dump: add DumpInfo structure

2017-06-04 Thread Zhang Chen
On 06/03/2017 06:49 AM, Laszlo Ersek wrote: On 06/02/17 11:55, Marc-André Lureau wrote: Hi On Fri, Jun 2, 2017 at 1:46 PM Marc-André Lureau wrote: Hi On Thu, Jun 1, 2017 at 10:19 PM Eric Blake wrote: On 06/01/2017 01:06 PM, Laszlo Ersek wrote: On 06/01/17 15:03, Marc-André Lureau wrot

[Qemu-devel] [PULL 14/22] hw/mips: add missing include

2017-06-04 Thread Michael Tokarev
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Acked-by: Aurelien Jarno Signed-off-by: Michael Tokarev --- include/hw/mips/mips.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/hw/mips/mips.h b/include/hw/mips/mips.h index e0065ce808..16412dc150 100644 --- a/i

[Qemu-devel] [PULL 19/22] ide-test: check return of fwrite

2017-06-04 Thread Michael Tokarev
From: John Snow To quiet patchew, add an assert for fwrite's return value. Signed-off-by: John Snow Reviewed-by: Jeff Cody Reviewed-by: Laurent Vivier Signed-off-by: Michael Tokarev --- tests/ide-test.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/ide-te

[Qemu-devel] [PULL 01/22] qemu-doc: Move the qemu-ga description into a separate chapter

2017-06-04 Thread Michael Tokarev
From: Thomas Huth The qemu-ga description is currently a subsection of the Disk Images chapter - which does not make much sense since the qemu-ga is not directly related to disk images. So let's move this information into a separate chapter instead. Signed-off-by: Thomas Huth Reviewed-by: Stefa

[Qemu-devel] [PULL 17/22] qemu-ga: remove useless allocation

2017-06-04 Thread Michael Tokarev
From: Marc-André Lureau There is no need to duplicate a fixed string. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Michael Tokarev --- qga/commands-posix.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/q

[Qemu-devel] [PULL 18/22] help: Add newline to end of thread option help text

2017-06-04 Thread Michael Tokarev
From: Suraj Jitindar Singh The help text for the thread sub option of the accel option is missing a newline at the end. This is annoying as it makes it hard to see the help text for the next option. Add the new line so that the following option help text (-smp) is displayed on a new line rather

[Qemu-devel] [PULL 20/22] dump: fix memory_mapping_filter leak

2017-06-04 Thread Michael Tokarev
From: Marc-André Lureau Spotted by ASAN. Signed-off-by: Marc-André Lureau Signed-off-by: Michael Tokarev --- memory_mapping.c | 1 + 1 file changed, 1 insertion(+) diff --git a/memory_mapping.c b/memory_mapping.c index 6a39d71da2..a5d38552a6 100644 --- a/memory_mapping.c +++ b/memory_mapping

[Qemu-devel] [PULL 15/22] qapi: Fix some QMP documentation regressions

2017-06-04 Thread Michael Tokarev
From: Eric Blake In the process of getting rid of docs/qmp-commands.txt, we managed to regress on some of the text that changed after the point where the move was first branched and when the move actually occurred. For example, commit 3282eca for blockdev-snapshot re-added the extra "options" lay

[Qemu-devel] [PULL 04/22] docs/qdev-device-use.txt: update section Default Devices

2017-06-04 Thread Michael Tokarev
From: Markus Armbruster Resynchronize the table of default device suppressions with vl.c's default_list[]. Signed-off-by: Markus Armbruster Reviewed-by: Thomas Huth Signed-off-by: Michael Tokarev --- docs/qdev-device-use.txt | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) dif

[Qemu-devel] [PULL 03/22] docs qemu-doc: Avoid ide-drive, it's deprecated

2017-06-04 Thread Michael Tokarev
From: Markus Armbruster Suggested-by: Thomas Huth Signed-off-by: Markus Armbruster Reviewed-by: Thomas Huth Signed-off-by: Michael Tokarev --- docs/bootindex.txt | 2 +- docs/qdev-device-use.txt | 4 ++-- qemu-options.hx | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)

[Qemu-devel] [PULL 13/22] register: display register prefix (name) since it is available

2017-06-04 Thread Michael Tokarev
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Signed-off-by: Michael Tokarev --- hw/core/register.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/core/register.c b/hw/core/register.c index da38ef3a54..900294b9

[Qemu-devel] [PULL 06/22] configure: Detect native NetBSD curses(3)

2017-06-04 Thread Michael Tokarev
From: Kamil Rytarowski NetBSD ships with traditional BSD curses with compatibility with ncurses. qemu works nicely with the basesystem version of curses(3) from NetBSD. The only mismatch between curses(3) and ncurses is the lack of curses_version() in the NetBSD version. This function is used so

[Qemu-devel] [PULL 21/22] ivshmem-server: ivshmem-client: Build when eventfd() is available

2017-06-04 Thread Michael Tokarev
From: Kamil Rytarowski Currently ivshmem requires eventfd() which is Linux specific. Do not and build it unconditionally on every Linux/BSD/Solaris. This patch indirectly fixes build failure on NetBSD, where these tools additionally require -lrt for shm_open(3). In future there should be added s

[Qemu-devel] [PULL 16/22] scsi/lsi53c895a: Remove unused lsi_mem_*() return value

2017-06-04 Thread Michael Tokarev
From: Mao Zhongyi lsi_mem_read/write() always return 0 about which their callers actually don't care. Change the function type to void. Signed-off-by: Mao Zhongyi Signed-off-by: Michael Tokarev --- hw/scsi/lsi53c895a.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --g

[Qemu-devel] [PULL 09/22] block: Correct documentation for BLOCK_WRITE_THRESHOLD

2017-06-04 Thread Michael Tokarev
From: Eric Blake Use the correct command name. Signed-off-by: Eric Blake Signed-off-by: Michael Tokarev --- qapi/block-core.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index ea0b3e8b13..309b1df214 100644 --- a/qapi/block

[Qemu-devel] [PULL 12/22] hw/sparc: use ARRAY_SIZE() macro

2017-06-04 Thread Michael Tokarev
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Signed-off-by: Michael Tokarev --- hw/sparc64/sun4u.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c index 18b8f8bcba..69f565db25 100644 ---

Re: [Qemu-devel] [PATCH v1] target/s390x: addressing exceptions are suppressing

2017-06-04 Thread Richard Henderson
On 05/29/2017 05:12 AM, David Hildenbrand wrote: We have to make the address in the old PSW point at the next instruction, as addressing exceptions are suppressing and not nullifying. I assume that there are a lot of other broken cases (as most instructions we care about are suppressing) - all t

[Qemu-devel] [PULL 00/69] target/s390x tcg patches

2017-06-04 Thread Richard Henderson
0/qemu.git tags/pull-s390-20170604 for you to fetch changes up to 2be5fdbe14165d47a88054c9d117801e09239098: target/s390x: addressing exceptions are suppressing (2017-06-04 10:23:15 -0700) Queu

[Qemu-devel] [PULL 01/69] target/s390x: Add support for the TEST BLOCK instruction

2017-06-04 Thread Richard Henderson
From: Thomas Huth TEST BLOCK was likely once used to execute basic memory tests, but nowadays it's just a (slow) way to clear a page. Reviewed-by: Aurelien Jarno Reviewed-by: David Hildenbrand Reviewed-by: Richard Henderson Signed-off-by: Thomas Huth Message-Id: <1495128400-23759-1-git-send-

[Qemu-devel] [PULL 02/69] target/s390x: Use cpu_loop_exit_restore for tlb_fill

2017-06-04 Thread Richard Henderson
Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 0c6a0d9..e3325a4 100644 --- a/target/s39

[Qemu-devel] [PULL 08/69] target/s390x: Use unwind data for helper_clc

2017-06-04 Thread Richard Henderson
Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 29 + target/s390x/translate.c | 1 - 2 files changed, 17 insertions(+), 13 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 78a9ac1..5

[Qemu-devel] [PULL 03/69] target/s390x: Move helper_ex to end of file

2017-06-04 Thread Richard Henderson
This will avoid needing forward declarations in following patches. Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 161 +++--- 1 file changed, 81 insertions(+), 80 deletions(-) diff --git a/target/s390x/mem_he

[Qemu-devel] [PULL 11/69] target/s390x: Use unwind data for helper_clst

2017-06-04 Thread Richard Henderson
Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 5 +++-- target/s390x/translate.c | 1 - 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 33d83e5..af2

[Qemu-devel] [PULL 16/69] target/s390x: Use unwind data for helper_mvcl

2017-06-04 Thread Richard Henderson
Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 7 --- target/s390x/translate.c | 1 - 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 2acc984..4

[Qemu-devel] [PULL 04/69] target/s390x: Use unwind data for helper_nc

2017-06-04 Thread Richard Henderson
Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 31 ++- target/s390x/translate.c | 1 - 2 files changed, 18 insertions(+), 14 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 90b62fa.

[Qemu-devel] [PULL 07/69] target/s390x: Use unwind data for helper_mvc

2017-06-04 Thread Richard Henderson
Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 30 ++ target/s390x/translate.c | 1 - 2 files changed, 18 insertions(+), 13 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index b71437a..

[Qemu-devel] [PULL 05/69] target/s390x: Use unwind data for helper_oc

2017-06-04 Thread Richard Henderson
Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 31 ++- target/s390x/translate.c | 1 - 2 files changed, 18 insertions(+), 14 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 7d6133b.

[Qemu-devel] [PULL 17/69] target/s390x: Use unwind data for helper_mvcle

2017-06-04 Thread Richard Henderson
Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 7 --- target/s390x/translate.c | 1 - 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 49cfc9b..8

[Qemu-devel] [PULL 19/69] target/s390x: Use unwind data for helper_cksm

2017-06-04 Thread Richard Henderson
Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 11 ++- target/s390x/translate.c | 1 - 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index f5a3

[Qemu-devel] [PULL 21/69] target/s390x: Use unwind data for helper_tr

2017-06-04 Thread Richard Henderson
Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 25 +++-- target/s390x/translate.c | 1 - 2 files changed, 15 insertions(+), 11 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 0701e10..b37a9

[Qemu-devel] [PULL 06/69] target/s390x: Use unwind data for helper_xc

2017-06-04 Thread Richard Henderson
Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 44 target/s390x/translate.c | 1 - 2 files changed, 24 insertions(+), 21 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c i

[Qemu-devel] [PULL 20/69] target/s390x: Use unwind data for helper_unpk

2017-06-04 Thread Richard Henderson
Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 9 + target/s390x/translate.c | 1 - 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index d4ee364.

[Qemu-devel] [PULL 15/69] target/s390x: Use unwind data for helper_stam

2017-06-04 Thread Richard Henderson
Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 3 ++- target/s390x/translate.c | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 88e817a..2acc9

[Qemu-devel] [PULL 23/69] target/s390x: Use unwind data for helper_trt

2017-06-04 Thread Richard Henderson
Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 28 target/s390x/translate.c | 1 - 2 files changed, 16 insertions(+), 13 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_

[Qemu-devel] [PULL 09/69] target/s390x: Use unwind data for helper_clm

2017-06-04 Thread Richard Henderson
Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 11 ++- target/s390x/translate.c | 1 - 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 5068

[Qemu-devel] [PULL 25/69] target/s390x: Use unwind data for helper_lctl

2017-06-04 Thread Richard Henderson
Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 9 + target/s390x/translate.c | 1 - 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 68e3817.

[Qemu-devel] [PULL 18/69] target/s390x: Use unwind data for helper_clcle

2017-06-04 Thread Richard Henderson
Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 6 +++--- target/s390x/translate.c | 1 - 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 8a095ad..f5

[Qemu-devel] [PULL 27/69] target/s390x: Use unwind data for helper_testblock

2017-06-04 Thread Richard Henderson
Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 3 +++ target/s390x/translate.c | 1 - 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index b64c04e..7df2e5

[Qemu-devel] [PULL 10/69] target/s390x: Use unwind data for helper_srst

2017-06-04 Thread Richard Henderson
Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 3 ++- target/s390x/translate.c | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 3e75cae..33d83

[Qemu-devel] [PULL 26/69] target/s390x: Use unwind data for helper_stctl

2017-06-04 Thread Richard Henderson
Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 10 ++ target/s390x/translate.c | 2 -- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 614c

[Qemu-devel] [PULL 22/69] target/s390x: Use unwind data for helper_tre

2017-06-04 Thread Richard Henderson
Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 15 --- target/s390x/translate.c | 1 - 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index

[Qemu-devel] [PULL 12/69] target/s390x: Use unwind data for helper_mvpg

2017-06-04 Thread Richard Henderson
Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/helper.h | 2 +- target/s390x/mem_helper.c | 9 + target/s390x/translate.c | 3 +-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/target/s390x/helper.h b/target/s

[Qemu-devel] [PULL 40/69] target/s390x: remove dead code in translate.c

2017-06-04 Thread Richard Henderson
From: Aurelien Jarno Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Aurelien Jarno Message-Id: <20170531220129.27724-2-aurel...@aurel32.net> Signed-off-by: Richard Henderson --- target/s390x/translate.c | 5 + 1 file changed, 1 insertion(+), 4 deletions

[Qemu-devel] [PULL 29/69] target/s390x: Use unwind data for helper_lra

2017-06-04 Thread Richard Henderson
Fix saving exception_index around mmu_translate; eliminate a dead store. Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 6 +++--- target/s390x/translate.c | 1 - 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/target/s390x/mem_helper

[Qemu-devel] [PULL 30/69] target/s390x: Use unwind data for helper_mvcs/mvcp

2017-06-04 Thread Richard Henderson
Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 8 ++-- target/s390x/translate.c | 2 -- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 17d8257.

[Qemu-devel] [PULL 35/69] target/s390x: Save current ilen during translation

2017-06-04 Thread Richard Henderson
Use this saved value instead of recomputing from next_pc difference. Reviewed-by: David Hildenbrand Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/translate.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/target/s390x/translate.c b/t

[Qemu-devel] [PULL 13/69] target/s390x: Use unwind data for helper_mvst

2017-06-04 Thread Richard Henderson
Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 5 +++-- target/s390x/translate.c | 1 - 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 1c36a47..e4b

[Qemu-devel] [PULL 44/69] target/s390x: implement TEST ADDRESSING MODE

2017-06-04 Thread Richard Henderson
From: Aurelien Jarno Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno Message-Id: <20170531220129.27724-6-aurel...@aurel32.net> Signed-off-by: Richard Henderson --- target/s390x/insn-data.def | 3 +++ target/s390x/translate.c | 10 ++ 2 files changed, 13 insertions(+)

[Qemu-devel] [PULL 33/69] target/s390x: Use atomic operations for COMPARE SWAP PURGE

2017-06-04 Thread Richard Henderson
Also provide the cross-cpu tlb flushing required by the PoO. Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/helper.h | 2 +- target/s390x/insn-data.def | 2 +- target/s390x/mem_helper.c | 32 target/s390x/translate.c | 42

[Qemu-devel] [PULL 14/69] target/s390x: Use unwind data for helper_lam

2017-06-04 Thread Richard Henderson
Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 3 ++- target/s390x/translate.c | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index e4bfc6e..88e81

[Qemu-devel] [PULL 37/69] target/s390x: Implement EXECUTE via new TranslationBlock

2017-06-04 Thread Richard Henderson
Previously, helper_ex would construct the insn and then implement the insn via direct calls other helpers. This was sufficient to boot Linux but that is all. It is easy enough to go the whole nine yards by stashing state for EXECUTE within the cpu, and then rely on a new TB to be created that pro

[Qemu-devel] [PULL 45/69] target/s390x: implement PACK

2017-06-04 Thread Richard Henderson
From: Aurelien Jarno Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno Message-Id: <20170531220129.27724-7-aurel...@aurel32.net> Signed-off-by: Richard Henderson --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 5 + target/s390x/mem_helper.c | 37 ++

[Qemu-devel] [PULL 34/69] target/s390x: Implement CSPG

2017-06-04 Thread Richard Henderson
Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/insn-data.def | 1 + target/s390x/translate.c | 1 + 2 files changed, 2 insertions(+) diff --git a/target/s390x/insn-data.def b/target/s390x/insn-data.def index 4c91f30..f818437 100644 --- a/target/s390x/insn-data.d

[Qemu-devel] [PULL 41/69] target/s390x: remove some Linux assumptions from IPTE

2017-06-04 Thread Richard Henderson
From: Aurelien Jarno Signed-off-by: Aurelien Jarno Message-Id: <20170531220129.27724-3-aurel...@aurel32.net> Signed-off-by: Richard Henderson --- target/s390x/cpu.h| 2 ++ target/s390x/mem_helper.c | 17 ++--- target/s390x/mmu_helper.c | 2 -- 3 files changed, 12 insertio

[Qemu-devel] [PULL 46/69] target/s390x: implement LOAD PAIR FROM QUADWORD

2017-06-04 Thread Richard Henderson
From: Aurelien Jarno Signed-off-by: Aurelien Jarno Message-Id: <20170531220129.27724-8-aurel...@aurel32.net> Signed-off-by: Richard Henderson --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 2 ++ target/s390x/mem_helper.c | 13 + target/s390x/translate.c |

[Qemu-devel] [PULL 24/69] target/s390x: Use unwind data for helper_lctlg

2017-06-04 Thread Richard Henderson
Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 8 target/s390x/translate.c | 1 - 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index ff12777..

[Qemu-devel] [PULL 36/69] target/s390x: End the TB after EXECUTE

2017-06-04 Thread Richard Henderson
This split will be required for implementing EXECUTE properly. Do this now as a separate step to aid comparison of before and after TB listings. Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 54 --- targe

[Qemu-devel] [PULL 28/69] target/s390x: Use unwind data for helper_tprot

2017-06-04 Thread Richard Henderson
Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 1 - target/s390x/translate.c | 1 - 2 files changed, 2 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 7df2e53..a8c85c9 100644 --- a/tar

[Qemu-devel] [PULL 53/69] target/s390x: improve 24-bit and 31-bit addresses read

2017-06-04 Thread Richard Henderson
From: Aurelien Jarno Improve fix_address to also handle the 24-bit mode. Rename fix_address to wrap_address to better explain what is changed. Replace the calls to get_address with x2 = 0 and b2 = 0 by call to wrap_address, leading to the removal of this function. Rename get_address_31fix into g

[Qemu-devel] [PULL 47/69] target/s390x: implement STORE PAIR TO QUADWORD

2017-06-04 Thread Richard Henderson
From: Aurelien Jarno Signed-off-by: Aurelien Jarno Message-Id: <20170531220129.27724-9-aurel...@aurel32.net> Signed-off-by: Richard Henderson --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 2 ++ target/s390x/mem_helper.c | 12 target/s390x/translate.c | 6

[Qemu-devel] [PULL 38/69] target/s390x: Re-implement a few EXECUTE target insns directly

2017-06-04 Thread Richard Henderson
While the previous patch is required for proper conformance, the vast majority of target insns are MVC and XC for implementing memmove and memset respectively. The next most common are CLC, TR, and SVC. Implementing these (and a few others for which we already have an implementation) directly is

[Qemu-devel] [PULL 31/69] target/s390x: Fix some helper_ex problems

2017-06-04 Thread Richard Henderson
(1) The OR of the low bits or R1 into INSN were not being done consistently; it was forgotten along all but the SVC path. (2) The setting of ILEN was wrong on SVC path for EXRL. (3) The data load for ICM read too much. Fix these by consolidating data load at the beginning, using get_ilen to contro

[Qemu-devel] [PULL 54/69] target/s390x: improve 24-bit and 31-bit addresses write

2017-06-04 Thread Richard Henderson
From: Aurelien Jarno Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno Message-Id: <20170531220129.27724-16-aurel...@aurel32.net> Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 37 ++--- 1 file changed, 30 insertions(+), 7 deletions

[Qemu-devel] [PULL 42/69] target/s390x: implement local-TLB-clearing in IPTE

2017-06-04 Thread Richard Henderson
From: Aurelien Jarno And at the same time make IPTE SMP aware. Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno Message-Id: <20170531220129.27724-4-aurel...@aurel32.net> Signed-off-by: Richard Henderson --- target/s390x/helper.h | 2 +- target/s390x

[Qemu-devel] [PULL 48/69] target/s390x: implement COMPARE AND SIGNAL

2017-06-04 Thread Richard Henderson
From: Aurelien Jarno These functions differ from COMPARE by generating an exception for a QNaN input. Use the non quiet version of floatXX_compare. Signed-off-by: Aurelien Jarno Message-Id: <20170531220129.27724-10-aurel...@aurel32.net> Signed-off-by: Richard Henderson --- target/s390x/fpu_he

[Qemu-devel] [PULL 32/69] target/s390x: Fix EXECUTE with R1==0

2017-06-04 Thread Richard Henderson
The PoO specifies that when R1==0, no ORing into the insn loaded from storage takes place. Load a zero for this case. Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/insn-data.def | 4 ++-- target/s390x/translate.c | 14 +- 2 files changed, 15 inser

[Qemu-devel] [PULL 58/69] target/s390x: fix adj_len_to_page

2017-06-04 Thread Richard Henderson
From: Aurelien Jarno adj_len_to_page doesn't return the correct result when the address is already page aligned and the length is bigger than a page. Fix that. Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno Message-Id: <20170531220129.27724-20-aurel...@aurel32.net> Signed-off-by:

[Qemu-devel] [PULL 49/69] target/s390x: implement MOVE INVERSE

2017-06-04 Thread Richard Henderson
From: Aurelien Jarno Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno Message-Id: <20170531220129.27724-11-aurel...@aurel32.net> Signed-off-by: Richard Henderson --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 2 ++ target/s390x/mem_helper.c | 12

[Qemu-devel] [PULL 57/69] target/s390x: implement COMPARE LOGICAL LONG

2017-06-04 Thread Richard Henderson
From: Aurelien Jarno As CLCL and CLCLE mostly differ by their operands, use a common do_clcl helper. Another difference is that CLCL is not interruptible. Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno Message-Id: <20170531220129.27724-19-aurel...@aurel32.net> Signed-off-by: Rich

[Qemu-devel] [PULL 59/69] target/s390x: improve MOVE LONG and MOVE LONG EXTENDED

2017-06-04 Thread Richard Henderson
From: Aurelien Jarno As MVCL and MVCLE only differ by their operands, use a common do_mvcl helper. Optimize it calling fast_memmove and fast_memset. Correctly write back addresses. Check that r1 and r2/r3 registers are even. Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno Message-

[Qemu-devel] [PULL 39/69] target/s390x/cpu_models: Allow some additional feature bits for the "qemu" CPU

2017-06-04 Thread Richard Henderson
From: Thomas Huth Currently we only present the plain z900 feature bits to the guest, but QEMU already emulates some additional features (but not all of the next CPU generation, so we can not use the next CPU level as default yet). Since newer Linux kernels are checking the feature bits and refus

[Qemu-devel] [PULL 50/69] target/s390x: implement MOVE NUMERICS

2017-06-04 Thread Richard Henderson
From: Aurelien Jarno Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno Message-Id: <20170531220129.27724-12-aurel...@aurel32.net> Signed-off-by: Richard Henderson --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 2 ++ target/s390x/mem_helper.c | 13

[Qemu-devel] [PULL 43/69] target/s390x: implement TEST AND SET

2017-06-04 Thread Richard Henderson
From: Aurelien Jarno Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno Message-Id: <20170531220129.27724-5-aurel...@aurel32.net> Signed-off-by: Richard Henderson --- target/s390x/insn-data.def | 3 +++ target/s390x/translate.c | 10 ++ 2 files changed, 13 insertions(+)

[Qemu-devel] [PULL 66/69] target/s390x: implement TEST DECIMAL

2017-06-04 Thread Richard Henderson
From: Aurelien Jarno Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno Message-Id: <20170531220129.27724-28-aurel...@aurel32.net> Signed-off-by: Richard Henderson --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 3 +++ target/s390x/mem_helper.c | 23 +++

[Qemu-devel] [PULL 63/69] target/s390x: implement PACK UNICODE

2017-06-04 Thread Richard Henderson
From: Aurelien Jarno Use a common helper with PACK ASCII as the differences are limited to the stride of the source operand. Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno Message-Id: <20170531220129.27724-25-aurel...@aurel32.net> Signed-off-by: Richard Henderson --- target/s39

[Qemu-devel] [PULL 51/69] target/s390x: implement MOVE WITH OFFSET

2017-06-04 Thread Richard Henderson
From: Aurelien Jarno Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno Message-Id: <20170531220129.27724-13-aurel...@aurel32.net> Signed-off-by: Richard Henderson --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 4 target/s390x/mem_helper.c | 31 ++

[Qemu-devel] [PULL 52/69] target/s390x: implement MOVE ZONES

2017-06-04 Thread Richard Henderson
From: Aurelien Jarno Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno Message-Id: <20170531220129.27724-14-aurel...@aurel32.net> Signed-off-by: Richard Henderson --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 2 ++ target/s390x/mem_helper.c | 13

[Qemu-devel] [PULL 67/69] target/s390x: implement TRANSLATE ONE/TWO TO ONE/TWO

2017-06-04 Thread Richard Henderson
From: Aurelien Jarno Signed-off-by: Aurelien Jarno Message-Id: <20170531220129.27724-29-aurel...@aurel32.net> Signed-off-by: Richard Henderson --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 9 + target/s390x/mem_helper.c | 45 +

[Qemu-devel] [PULL 60/69] target/s390x: implement COMPARE LOGICAL LONG UNICODE

2017-06-04 Thread Richard Henderson
From: Aurelien Jarno For that we need to make program_interrupt available to qemu-user. Fortunately there is almost nothing to change as both kvm_enabled and CONFIG_KVM evaluate to false in that case. Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno Message-Id: <20170531220129.2772

[Qemu-devel] [PULL 55/69] target/s390x: improve 24-bit and 31-bit lengths read/write

2017-06-04 Thread Richard Henderson
From: Aurelien Jarno Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno Message-Id: <20170531220129.27724-17-aurel...@aurel32.net> Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 47 +-- 1 file changed, 33 insertions(+), 1

[Qemu-devel] [PULL 61/69] target/s390x: implement MOVE LONG UNICODE

2017-06-04 Thread Richard Henderson
From: Aurelien Jarno Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno Message-Id: <20170531220129.27724-23-aurel...@aurel32.net> Signed-off-by: Richard Henderson --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 2 ++ target/s390x/mem_helper.c | 47

[Qemu-devel] [PULL 69/69] target/s390x: addressing exceptions are suppressing

2017-06-04 Thread Richard Henderson
From: David Hildenbrand We have to make the address in the old PSW point at the next instruction, as addressing exceptions are suppressing and not nullifying. I assume that there are a lot of other broken cases (as most instructions we care about are suppressing) - all trigger_pgm_exception() sp

[Qemu-devel] [PULL 56/69] target/s390x: fix COMPARE LOGICAL LONG EXTENDED

2017-06-04 Thread Richard Henderson
From: Aurelien Jarno There are multiple issues with the COMPARE LOGICAL LONG EXTENDED instruction: - The test between the two operands is inverted, leading to an inversion of the cc values 1 and 2. - The address and length of an operand continue to be decreased after reaching the end of this

[Qemu-devel] [PULL 64/69] target/s390x: implement UNPACK ASCII

2017-06-04 Thread Richard Henderson
From: Aurelien Jarno Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno Message-Id: <20170531220129.27724-26-aurel...@aurel32.net> Signed-off-by: Richard Henderson --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 2 ++ target/s390x/mem_helper.c | 51

[Qemu-devel] [PULL 62/69] target/s390x: implement PACK ASCII

2017-06-04 Thread Richard Henderson
From: Aurelien Jarno Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno Message-Id: <20170531220129.27724-24-aurel...@aurel32.net> Signed-off-by: Richard Henderson --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 2 ++ target/s390x/mem_helper.c | 35

[Qemu-devel] [PULL 65/69] target/s390x: implement UNPACK UNICODE

2017-06-04 Thread Richard Henderson
From: Aurelien Jarno Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno Message-Id: <20170531220129.27724-27-aurel...@aurel32.net> Signed-off-by: Richard Henderson --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 2 ++ target/s390x/mem_helper.c | 49

[Qemu-devel] [PULL 68/69] target/s390x: mark ETF2 and ETF2-ENH facilities as available

2017-06-04 Thread Richard Henderson
From: Aurelien Jarno Signed-off-by: Aurelien Jarno Message-Id: <20170531220129.27724-30-aurel...@aurel32.net> Signed-off-by: Richard Henderson --- target/s390x/cpu_models.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c index e5e005a

Re: [Qemu-devel] [PATCH] tcg: allocate TB structs before the corresponding translated code

2017-06-04 Thread Richard Henderson
On 06/02/2017 04:39 PM, Emilio G. Cota wrote: +aligned = (void *)ROUND_UP((uintptr_t)s->code_gen_ptr, 64); I would prefer that this and +} QEMU_ALIGNED(64); this both use a define. We may well have to adjust this for different hosts. In particular I'm thinking of PPC64 which would pre

  1   2   >