On 06/02/2017 04:39 PM, Emilio G. Cota wrote:
+ aligned = (void *)ROUND_UP((uintptr_t)s->code_gen_ptr, 64);
I would prefer that this and
+} QEMU_ALIGNED(64);
this both use a define. We may well have to adjust this for different hosts.
In particular I'm thinking of PPC64 which would prefer 128.
+ if (unlikely(!tcg_ctx.tb_ctx.tbs_size)) {
+ tcg_ctx.tb_ctx.tbs_size = 1024;
+ }
And I know that you resize this on demand, but surely we can avoid some startup
slowdown by picking a more reasonable initial estimate here. Like 32k or 64k.
Otherwise this looks good. I'll have to have a more detailed look at the
differences in the generated code later.
r~
