Re: [Qemu-devel] ssi_auto_connect_slave

2017-05-24 Thread boddu pavan via Qemu-devel
+qemu-dev Show original message On Monday, May 22, 2017 6:34 PM, boddu pavan wrote: Hi, I see that ssi_auto_connect_slave helper of ssi.c (https://github.com/qemu/qemu/blob/master/hw/ssi/ssi.c#L166) is used to connect SSISlave children of spi controller to its respective spi bus. Bu

Re: [Qemu-devel] [PATCH v3 1/3] migration: Introduce unregister_savevm_live()

2017-05-24 Thread Juan Quintela
David Gibson wrote: > On Wed, May 24, 2017 at 08:28:59AM +0200, Juan Quintela wrote: >> Bharata B Rao wrote: >> > Introduce a new function unregister_savevm_live() to unregister the vmstate >> > handlers registered via register_savevm_live(). >> > >> > register_savevm() allocates SaveVMHandlers w

Re: [Qemu-devel] [PATCH v3 00/10] Clock framework API.

2017-05-24 Thread KONRAD Frederic
Ping. Thanks, Fred Le 28/02/2017 à 11:02, fred.kon...@greensocs.com a écrit : From: KONRAD Frederic Hi, This is the third version of the clock framework API it contains: * The first 6 patches which introduce the framework. * The 7th patch which introduces a fixed-clock model. * The re

[Qemu-devel] [PATCH] migration: Allow unregister of save_live handlers

2017-05-24 Thread Juan Quintela
Migration non save_live handlers have an ops member that is dinamically allocated by migration code. Save_live handlers have it passed as argument and are responsability of the caller. Add a new member is_allocated that remembers if ops has to be freed. This allows unregister_savevm() to work wi

Re: [Qemu-devel] [PATCH V6 08/10] migration: calculate vCPU blocktime on dst side

2017-05-24 Thread Peter Xu
On Tue, May 23, 2017 at 02:31:09PM +0300, Alexey Perevalov wrote: > This patch provides blocktime calculation per vCPU, > as a summary and as a overlapped value for all vCPUs. > > This approach was suggested by Peter Xu, as an improvements of > previous approch where QEMU kept tree with faulted pa

Re: [Qemu-devel] [PATCH V6 07/10] migration: add bitmap for copied page

2017-05-24 Thread Alexey
On Wed, May 24, 2017 at 02:57:36PM +0800, Peter Xu wrote: > On Tue, May 23, 2017 at 02:31:08PM +0300, Alexey Perevalov wrote: > > This patch adds ability to track down already copied > > pages, it's necessary for calculation vCPU block time in > > postcopy migration feature and maybe for restore af

Re: [Qemu-devel] [PATCH v11 0/5] migration/ppc: migrating DRC and ccs_list

2017-05-24 Thread David Gibson
I've merged 1..4 with some minor changes for style and error handling. 5/5 I still need to review in a bit more detail. On Mon, May 22, 2017 at 04:35:46PM -0300, Daniel Henrique Barboza wrote: > v11: > - rebased with dgibson/ppc-for-2.10 branch > - patch 1: > * use PCDIMMDevice* as index of p

[Qemu-devel] [PATCH] net: Mark the 'hubport' netdev as deprecated

2017-05-24 Thread Thomas Huth
The 'hubport' netdev is closely tied to the 'vlan' concept which has been marked as deprecated in commit a2dbe1356faff3cb6 already. Thus we should also mark the hubport netdevs as deprecated to make the remaining users aware that they should not use this anymore. Signed-off-by: Thomas Huth --- n

[Qemu-devel] [PATCH] pc: ACPI BIOS: use highest NUMA node for hotplug mem hole SRAT entry

2017-05-24 Thread Ladi Prosek
For reasons unknown, Windows won't online all memory, both at command line and hot-plugged later, unless the hotplug mem hole SRAT entry specifies a node greater or equal to the ones where memory is added. Using the highest node on the machine makes recent versions of Windows happy. With this exa

Re: [Qemu-devel] [virtio-dev] Re: [PATCH RFC] virtio-net: enable configurable tx queue size

2017-05-24 Thread Wei Wang
On 05/24/2017 11:19 AM, Jason Wang wrote: On 2017年05月23日 18:36, Wei Wang wrote: On 05/23/2017 02:24 PM, Jason Wang wrote: On 2017年05月23日 13:15, Wei Wang wrote: On 05/23/2017 10:04 AM, Jason Wang wrote: On 2017年05月22日 19:52, Wei Wang wrote: On 05/20/2017 04:42 AM, Michael S. Tsirkin wro

Re: [Qemu-devel] [PATCH] migration: Allow unregister of save_live handlers

2017-05-24 Thread Peter Xu
On Wed, May 24, 2017 at 09:37:19AM +0200, Juan Quintela wrote: > Migration non save_live handlers have an ops member that is > dinamically allocated by migration code. Save_live handlers have it > passed as argument and are responsability of the caller. Add a new > member is_allocated that rememb

Re: [Qemu-devel] [virtio-dev] Re: [virtio-dev] Re: [PATCH v2 00/16] Vhost-pci for inter-VM communication

2017-05-24 Thread Wei Wang
On 05/24/2017 11:24 AM, Jason Wang wrote: On 2017年05月23日 18:48, Wei Wang wrote: On 05/23/2017 02:32 PM, Jason Wang wrote: On 2017年05月23日 13:47, Wei Wang wrote: On 05/23/2017 10:08 AM, Jason Wang wrote: On 2017年05月22日 19:46, Wang, Wei W wrote: On Monday, May 22, 2017 10:28 AM, Jason Wan

Re: [Qemu-devel] [PATCH v2 00/18] Block layer thread safety, part 1

2017-05-24 Thread Paolo Bonzini
On 11/05/2017 16:41, Paolo Bonzini wrote: > This series uses mutexes or atomic operations around core block layer > operations. The remaining parts include: > > I've removed the failing assertion in bdrv_aligned_pwritev in order to > test block migration. > > Paolo > > v1->v2: add missing com

Re: [Qemu-devel] [PATCH] pc: ACPI BIOS: use highest NUMA node for hotplug mem hole SRAT entry

2017-05-24 Thread Igor Mammedov
On Wed, 24 May 2017 10:09:14 +0200 Ladi Prosek wrote: > For reasons unknown, Windows won't online all memory, both at command > line and hot-plugged later, unless the hotplug mem hole SRAT entry > specifies a node greater or equal to the ones where memory is added. > > Using the highest node on

Re: [Qemu-devel] [PATCH] migration: Allow unregister of save_live handlers

2017-05-24 Thread Juan Quintela
Peter Xu wrote: > On Wed, May 24, 2017 at 09:37:19AM +0200, Juan Quintela wrote: >> Migration non save_live handlers have an ops member that is >> dinamically allocated by migration code. Save_live handlers have it >> passed as argument and are responsability of the caller. Add a new >> member i

[Qemu-devel] [PATCH] vhost-user: pass message as a pointer to process_message_reply()

2017-05-24 Thread Maxime Coquelin
process_message_reply() was recently updated to get full message content instead of only its request field. There is no need to copy all the struct content into the stack, so just pass its pointer. Cc: Zhiyong Yang Fixes: 60cd11024f41 ("hw/virtio: fix vhost user fails to startup when MQ") Signed

Re: [Qemu-devel] new to qemu with a simple question

2017-05-24 Thread Wang Dong
Thank you, Fam. On 05/24/2017 11:11 AM, Fam Zheng wrote: On Wed, 05/24 10:56, Wang Dong wrote: Some C source code is generate from json file. I wonder why this? What is the benefits of this? This allows you to concentrate on the high level semantics of the QMP API, without worrying about C s

Re: [Qemu-devel] [PATCH] vhost-user: pass message as a pointer to process_message_reply()

2017-05-24 Thread Marc-André Lureau
On Wed, May 24, 2017 at 11:35 AM Maxime Coquelin wrote: > process_message_reply() was recently updated to get full message > content instead of only its request field. > > There is no need to copy all the struct content into the stack, > so just pass its pointer. > > Cc: Zhiyong Yang > Fixes: 60

Re: [Qemu-devel] [PATCH] vhost-user: pass message as a pointer to process_message_reply()

2017-05-24 Thread Maxime Coquelin
On 05/24/2017 10:40 AM, Marc-André Lureau wrote: On Wed, May 24, 2017 at 11:35 AM Maxime Coquelin mailto:maxime.coque...@redhat.com>> wrote: process_message_reply() was recently updated to get full message content instead of only its request field. There is no need to copy all

Re: [Qemu-devel] [PATCH v2 4/4] 9pfs: local: metadata file for the VirtFS root

2017-05-24 Thread Greg Kurz
On Wed, 24 May 2017 01:08:55 +0200 Leo Gaspard wrote: > On 05/23/2017 07:13 PM, Eric Blake wrote:> We have to block > VIRTFS_META_DIR at any depth in the hierarchy, but > > can/should we change the blocking of VIRTFS_META_ROOT_FILE to only > > happen at the root directory, rather than at all dire

Re: [Qemu-devel] [PATCH] vhost-user: pass message as a pointer to process_message_reply()

2017-05-24 Thread Yang, Zhiyong
Hi, Maxime: > -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Wednesday, May 24, 2017 4:35 PM > To: Yang, Zhiyong ; m...@redhat.com; qemu- > de...@nongnu.org; jfrei...@redhat.com; marcandre.lur...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH] v

Re: [Qemu-devel] [PATCH] vhost-user: pass message as a pointer to process_message_reply()

2017-05-24 Thread Jens Freimann
On Wed, May 24, 2017 at 10:42:30AM +0200, Maxime Coquelin wrote: > > > On 05/24/2017 10:40 AM, Marc-André Lureau wrote: > > > > > > On Wed, May 24, 2017 at 11:35 AM Maxime Coquelin > > mailto:maxime.coque...@redhat.com>> wrote: > > > > process_message_reply() was recently updated to get fu

Re: [Qemu-devel] [PATCH v2 0/4] 9pfs: local: fix metadata of mapped-file security mode

2017-05-24 Thread Greg Kurz
On Wed, 24 May 2017 00:59:29 +0200 Leo Gaspard wrote: > On 05/23/2017 04:32 PM, Greg Kurz wrote: > > v2: - posted patch for CVE-2017-7493 separately > > - other changes available in each patch changelog > > > > Leo, > > > > If you find time to test this series, I'll gladly add your Tested-b

[Qemu-devel] [PATCH] target/s390x/cpu_models: Allow some additional feature bits for the "qemu" CPU

2017-05-24 Thread Thomas Huth
Currently we only present the plain z900 feature bits to the guest, but QEMU already emulates some additional features (but not all of the next CPU generation, so we can not use the next CPU level as default yet). Since newer Linux kernels are checking the feature bits and refuse to work if a requi

[Qemu-devel] [PATCH 0/3] Remove of loadvm handlers

2017-05-24 Thread Juan Quintela
Hi We just have a loadvm handlers that are a new list only used in a single place. Just move everything to use the savevm_handlers (yes, it is a list, and we could have a better name). Once there, vmstate_load() had three arguments but only needs two. Fix that. Please, review. Juan Quintela (

[Qemu-devel] [PATCH 1/3] migration: Use savevm_handlers instead of loadvm copy

2017-05-24 Thread Juan Quintela
From: Juan Quintela There is no reason for having the loadvm_handlers at all. There is only one use, and we can use the savevm handlers. We will remove the loadvm handlers on a following patch. Signed-off-by: Juan Quintela --- migration/savevm.c | 24 1 file changed,

[Qemu-devel] [PATCH 2/3] migration: loadvm handlers are not used

2017-05-24 Thread Juan Quintela
From: Juan Quintela So we remove all traces of them. Signed-off-by: Juan Quintela --- include/migration/migration.h | 5 - include/migration/vmstate.h | 2 -- include/qemu/typedefs.h | 1 - migration/migration.c | 2 -- migration/savevm.c| 28 +--

[Qemu-devel] [PATCH 3/3] migration: Remove section_id parameter from vmstate_load

2017-05-24 Thread Juan Quintela
From: Juan Quintela Everything else assumes that we always load a device from its own savevm handler. Signed-off-by: Juan Quintela --- migration/savevm.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/migration/savevm.c b/migration/savevm.c index 96b7173..e847a6

Re: [Qemu-devel] [PATCH] block/gluster: glfs_lseek() workaround

2017-05-24 Thread Niels de Vos
On Tue, May 23, 2017 at 01:27:50PM -0400, Jeff Cody wrote: > On current released versions of glusterfs, glfs_lseek() will sometimes > return invalid values for SEEK_DATA or SEEK_HOLE. For SEEK_DATA and > SEEK_HOLE, the returned value should be >= the passed offset, or < 0 in > the case of error: >

Re: [Qemu-devel] [PATCH v3 15/24] docker: add powerpc build target

2017-05-24 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Hi Alex, > > On 05/22/2017 11:08 AM, Alex Bennée wrote: >> >> Philippe Mathieu-Daudé writes: >> >>> Signed-off-by: Philippe Mathieu-Daudé >>> --- >>> tests/docker/Makefile.include | 4 +-- >>> .../docker/dockerfiles/debian-powerpc-cross.d

Re: [Qemu-devel] [PATCH] docker: Add flex and bison to centos6 image

2017-05-24 Thread Alex Bennée
Fam Zheng writes: > Currently there are warnings about flex and bison being missing when > building in the centos6 image: > > make[1]: flex: Command not found > BISON dtc-parser.tab.c > make[1]: bison: Command not found > > Add them. > > Reported-by: Thomas Huth > Signed-of

Re: [Qemu-devel] [PATCH] pc: ACPI BIOS: use highest NUMA node for hotplug mem hole SRAT entry

2017-05-24 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 20170524080914.23484-1-lpro...@redhat.com Subject: [Qemu-devel] [PATCH] pc: ACPI BIOS: use highest NUMA node for h

[Qemu-devel] [PATCH v2] vhost-user: pass message as a pointer to process_message_reply()

2017-05-24 Thread Maxime Coquelin
process_message_reply() was recently updated to get full message content instead of only its request field. There is no need to copy all the struct content into the stack, so just pass its pointer as const. Cc: Zhiyong Yang Fixes: 60cd11024f41 ("hw/virtio: fix vhost user fails to startup when MQ

Re: [Qemu-devel] [PATCH] pc: ACPI BIOS: use highest NUMA node for hotplug mem hole SRAT entry

2017-05-24 Thread Laszlo Ersek
On 05/24/17 10:09, Ladi Prosek wrote: > For reasons unknown, Windows won't online all memory, both at command > line and hot-plugged later, unless the hotplug mem hole SRAT entry > specifies a node greater or equal to the ones where memory is added. s/greater or equal to/greater *than* or equal to

Re: [Qemu-devel] [PATCH v2] vhost-user: pass message as a pointer to process_message_reply()

2017-05-24 Thread Marc-André Lureau
Hi On Wed, May 24, 2017 at 1:06 PM Maxime Coquelin wrote: > process_message_reply() was recently updated to get full message > content instead of only its request field. > > There is no need to copy all the struct content into the stack, > so just pass its pointer as const. > > Cc: Zhiyong Yang

[Qemu-devel] [PATCH] load_uboot_image: don't assume a full header read

2017-05-24 Thread Andrew Jones
Don't allow load_uboot_image() to proceed when less bytes than header-size was read. Signed-off-by: Andrew Jones --- hw/core/loader.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/core/loader.c b/hw/core/loader.c index bf17b42cbec2..f72930ca4a41 100644 --- a/hw/core/lo

Re: [Qemu-devel] [PATCH] pc: ACPI BIOS: use highest NUMA node for hotplug mem hole SRAT entry

2017-05-24 Thread Ladi Prosek
On Wed, May 24, 2017 at 11:07 AM, Laszlo Ersek wrote: > On 05/24/17 10:09, Ladi Prosek wrote: >> For reasons unknown, Windows won't online all memory, both at command >> line and hot-plugged later, unless the hotplug mem hole SRAT entry >> specifies a node greater or equal to the ones where memory

Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/4] spapr: disable hotplugging without OS

2017-05-24 Thread Greg Kurz
On Wed, 24 May 2017 15:07:54 +1000 David Gibson wrote: > On Tue, May 23, 2017 at 01:18:11PM +0200, Laurent Vivier wrote: > > If the OS is not started, QEMU sends an event to the OS > > that is lost and cannot be recovered. An unplug is not > > able to restore QEMU in a coherent state. > > So, whi

Re: [Qemu-devel] [PATCH V6 08/10] migration: calculate vCPU blocktime on dst side

2017-05-24 Thread Alexey
On Wed, May 24, 2017 at 03:53:05PM +0800, Peter Xu wrote: > On Tue, May 23, 2017 at 02:31:09PM +0300, Alexey Perevalov wrote: > > This patch provides blocktime calculation per vCPU, > > as a summary and as a overlapped value for all vCPUs. > > > > This approach was suggested by Peter Xu, as an imp

Re: [Qemu-devel] [PATCH] pc: ACPI BIOS: use highest NUMA node for hotplug mem hole SRAT entry

2017-05-24 Thread Igor Mammedov
On Wed, 24 May 2017 11:16:14 +0200 Ladi Prosek wrote: > On Wed, May 24, 2017 at 11:07 AM, Laszlo Ersek wrote: > > On 05/24/17 10:09, Ladi Prosek wrote: > >> For reasons unknown, Windows won't online all memory, both at command > >> line and hot-plugged later, unless the hotplug mem hole SRAT e

Re: [Qemu-devel] [PATCH 0/3] Remove of loadvm handlers

2017-05-24 Thread Peter Xu
On Wed, May 24, 2017 at 10:55:16AM +0200, Juan Quintela wrote: > Hi > > We just have a loadvm handlers that are a new list only used in a > single place. Just move everything to use the savevm_handlers (yes, > it is a list, and we could have a better name). > > Once there, vmstate_load() had thr

Re: [Qemu-devel] [PATCH 1/7] qcow2: Remove unused Error in do_perform_cow()

2017-05-24 Thread Alberto Garcia
On Tue 23 May 2017 10:21:49 PM CEST, Eric Blake wrote: >> qcow2_encrypt_sectors() does not need an Error parameter, and we're >> not checking its value anyway, so we can safely remove it. > > Misleading. You are NOT removing the Error parameter from > qcow2_encrypt_sectors(), but rather are explic

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/4] spapr: add pre_plug function for memory

2017-05-24 Thread Greg Kurz
On Wed, 24 May 2017 14:52:36 +1000 David Gibson wrote: [...] > > This patch seems like a good idea regardless of the rest, so I've > fixed the minor nits Greg pointed out and merged to ppc-for-2.10. > David, Commit d2e4c6a1437fab2fbb4553b598f25e282c475199 in your ppc-for-2.10 branch doesn't co

Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/4] spapr: disable hotplugging without OS

2017-05-24 Thread Igor Mammedov
On Wed, 24 May 2017 11:28:57 +0200 Greg Kurz wrote: > On Wed, 24 May 2017 15:07:54 +1000 > David Gibson wrote: > > > On Tue, May 23, 2017 at 01:18:11PM +0200, Laurent Vivier wrote: > > > If the OS is not started, QEMU sends an event to the OS > > > that is lost and cannot be recovered. An unp

Re: [Qemu-devel] [virtio-dev] Re: virtio crypto device implemenation

2017-05-24 Thread Cornelia Huck
On Wed, 24 May 2017 04:13:47 +0300 "Michael S. Tsirkin" wrote: > On Tue, May 23, 2017 at 04:08:25PM +, Zeng, Xin wrote: > > Hi, Michael, > >As you know, Lei Gong from Huawei and I are co-working on virtio crypto > > device spec, he is focusing on symmetric algorithm part, I am focusing

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/4] spapr: add pre_plug function for memory

2017-05-24 Thread David Gibson
On Wed, May 24, 2017 at 11:55:13AM +0200, Greg Kurz wrote: 1;4601;0c> On Wed, 24 May 2017 14:52:36 +1000 > David Gibson wrote: > [...] > > > > This patch seems like a good idea regardless of the rest, so I've > > fixed the minor nits Greg pointed out and merged to ppc-for-2.10. > > > > David, >

[Qemu-devel] [PATCH v2] migration: Allow unregister of save_live handlers

2017-05-24 Thread Juan Quintela
Migration non save_live handlers have an ops member that is dinamically allocated by migration code. Save_live handlers have it passed as argument and are responsability of the caller. Add a new member is_allocated that remembers if ops has to be freed. This allows unregister_savevm() to work wi

Re: [Qemu-devel] [PATCH V6 08/10] migration: calculate vCPU blocktime on dst side

2017-05-24 Thread Peter Xu
On Wed, May 24, 2017 at 12:37:20PM +0300, Alexey wrote: > On Wed, May 24, 2017 at 03:53:05PM +0800, Peter Xu wrote: > > On Tue, May 23, 2017 at 02:31:09PM +0300, Alexey Perevalov wrote: > > > This patch provides blocktime calculation per vCPU, > > > as a summary and as a overlapped value for all vC

Re: [Qemu-devel] [PATCH v2] migration: Allow unregister of save_live handlers

2017-05-24 Thread Peter Xu
On Wed, May 24, 2017 at 01:21:52PM +0200, Juan Quintela wrote: > Migration non save_live handlers have an ops member that is > dinamically allocated by migration code. Save_live handlers have it > passed as argument and are responsability of the caller. Add a new > member is_allocated that rememb

Re: [Qemu-devel] [PATCH V6 04/10] migration: split ufd_version_check onto receive/request features part

2017-05-24 Thread Peter Xu
On Wed, May 24, 2017 at 09:45:48AM +0300, Alexey wrote: [...] > > > > > return false; > > > } > > > > > > -ioctl_mask = (__u64)1 << _UFFDIO_REGISTER | > > > - (__u64)1 << _UFFDIO_UNREGISTER; > > > +ioctl_mask = 1 << _UFFDIO_REGISTER | > > > +

Re: [Qemu-devel] [PATCH v2] migration: Allow unregister of save_live handlers

2017-05-24 Thread Juan Quintela
Peter Xu wrote: > On Wed, May 24, 2017 at 01:21:52PM +0200, Juan Quintela wrote: >> Migration non save_live handlers have an ops member that is >> dinamically allocated by migration code. Save_live handlers have it >> passed as argument and are responsability of the caller. Add a new >> member i

Re: [Qemu-devel] [PATCH 2/4] migration: Inactivate images after .save_live_complete_precopy()

2017-05-24 Thread Juan Quintela
Kevin Wolf wrote: > Block migration may still access the image during its > .save_live_complete_precopy() implementation, so we should only > inactivate the image afterwards. > > Another reason for the change is that inactivating an image fails when > there is still a non-device BlockBackend using

Re: [Qemu-devel] [PATCH V6 08/10] migration: calculate vCPU blocktime on dst side

2017-05-24 Thread Alexey Perevalov
On 05/24/2017 02:22 PM, Peter Xu wrote: On Wed, May 24, 2017 at 12:37:20PM +0300, Alexey wrote: On Wed, May 24, 2017 at 03:53:05PM +0800, Peter Xu wrote: On Tue, May 23, 2017 at 02:31:09PM +0300, Alexey Perevalov wrote: This patch provides blocktime calculation per vCPU, as a summary and as a

Re: [Qemu-devel] [PATCH V6 04/10] migration: split ufd_version_check onto receive/request features part

2017-05-24 Thread Alexey Perevalov
On 05/24/2017 02:33 PM, Peter Xu wrote: On Wed, May 24, 2017 at 09:45:48AM +0300, Alexey wrote: [...] return false; } -ioctl_mask = (__u64)1 << _UFFDIO_REGISTER | - (__u64)1 << _UFFDIO_UNREGISTER; +ioctl_mask = 1 << _UFFDIO_REGISTER | +

Re: [Qemu-devel] [PATCH V6 07/10] migration: add bitmap for copied page

2017-05-24 Thread Peter Xu
On Wed, May 24, 2017 at 10:56:37AM +0300, Alexey wrote: > On Wed, May 24, 2017 at 02:57:36PM +0800, Peter Xu wrote: > > On Tue, May 23, 2017 at 02:31:08PM +0300, Alexey Perevalov wrote: > > > This patch adds ability to track down already copied > > > pages, it's necessary for calculation vCPU block

Re: [Qemu-devel] [PATCH v5 1/4] net/rocker: Remove the dead error handling

2017-05-24 Thread Marcel Apfelbaum
- Original Message - > From: "Markus Armbruster" > To: "Philippe Mathieu-Daudé" > Cc: qemu-devel@nongnu.org, "Mao Zhongyi" , > j...@resnulli.us, jasow...@redhat.com, "Michael > S. Tsirkin" , "Marcel Apfelbaum" > Sent: Wednesday, May 24, 2017 8:35:04 AM > Subject: Re: [Qemu-devel] [PAT

[Qemu-devel] [PATCH] migration: remove register_savevm()

2017-05-24 Thread Laurent Vivier
We can replace the four remaining calls of register_savevm() by calls to register_savevm_live(). So we can remove the function and as we don't allocate anymore the ops pointer with g_new0() we don't have to free it then. Signed-off-by: Laurent Vivier --- hw/net/vmxnet3.c| 8 ++--

Re: [Qemu-devel] [RFC 0/3] qmp: Return extra information on qom-list-types

2017-05-24 Thread Markus Armbruster
Eduardo Habkost writes: > On Tue, May 23, 2017 at 04:12:43PM +0200, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > This series adds 'abstract' and 'parent-types' fields to the >> > output of qom-list-types. >> >> Peeking at PATCH 3, it looks like 'parent-types' is the transitive >

Re: [Qemu-devel] [PATCH V6 07/10] migration: add bitmap for copied page

2017-05-24 Thread Alexey Perevalov
On 05/24/2017 03:01 PM, Peter Xu wrote: On Wed, May 24, 2017 at 10:56:37AM +0300, Alexey wrote: On Wed, May 24, 2017 at 02:57:36PM +0800, Peter Xu wrote: On Tue, May 23, 2017 at 02:31:08PM +0300, Alexey Perevalov wrote: This patch adds ability to track down already copied pages, it's necessary

Re: [Qemu-devel] [PATCH 3/5] migration: Remove use of old MigrationParams

2017-05-24 Thread Markus Armbruster
Juan Quintela writes: > We have change in the previous patch to use migration capabilities for > it. Notice that we continue using the old command line flags from > migrate command from the time being. Remove the set_params method as for the time being > now it is empty. > > For savevm, one c

Re: [Qemu-devel] [PATCH 3/5] migration: Remove use of old MigrationParams

2017-05-24 Thread Markus Armbruster
I got confused and replied to an old version. Please ignore. Markus Armbruster writes: > Juan Quintela writes: > >> We have change in the previous patch to use migration capabilities for >> it. Notice that we continue using the old command line flags from >> migrate command from the time bein

Re: [Qemu-devel] [PATCH 3/5] migration: Remove use of old MigrationParams

2017-05-24 Thread Markus Armbruster
Markus Armbruster writes: > Juan Quintela writes: > >> We have change in the previous patch to use migration capabilities for >> it. Notice that we continue using the old command line flags from >> migrate command from the time being. Remove the set_params method as >> now it is empty. >> >> F

Re: [Qemu-devel] [PATCH] migration: remove register_savevm()

2017-05-24 Thread Samuel Thibault
Laurent Vivier, on mer. 24 mai 2017 14:10:48 +0200, wrote: > We can replace the four remaining calls of register_savevm() by > calls to register_savevm_live(). So we can remove the function and > as we don't allocate anymore the ops pointer with g_new0() > we don't have to free it then. > > Signed

Re: [Qemu-devel] [PULL 00/21] s390x patches

2017-05-24 Thread Stefan Hajnoczi
On Tue, May 23, 2017 at 01:12:45PM +0200, Cornelia Huck wrote: > The following changes since commit 56821559f0ba682fe6b367815572e6f974d329ab: > > Merge remote-tracking branch 'dgilbert/tags/pull-hmp-20170517' into staging > (2017-05-18 13:36:15 +0100) > > are available in the git repository at

Re: [Qemu-devel] [PATCH v6 0/9] qemu-img: add measure sub-command

2017-05-24 Thread Stefan Hajnoczi
On Mon, May 08, 2017 at 10:15:27AM -0400, Stefan Hajnoczi wrote: > v6: > * Change bdrv_measure() return type to BlockMeasureInfo * [Eric] > * Clarify that holes in sparse POSIX files are still counted [Eric] > > v5: > * Use UINT64_MAX instead of ~0ULL [Berto] > * Document qemu-img measure ofmt

Re: [Qemu-devel] [PATCH] migration: keep bytes_xfer_prev init'd to zero

2017-05-24 Thread Felipe Franciosi
> On 23 May 2017, at 05:27, Peter Xu wrote: > > On Fri, May 19, 2017 at 10:59:02PM +0100, Felipe Franciosi wrote: >> The first time migration_bitmap_sync() is called, bytes_xfer_prev is set >> to ram_state.bytes_transferred which is, at this point, zero. The next >> time migration_bitmap_sync()

Re: [Qemu-devel] [RFC 0/3] qmp: Return extra information on qom-list-types

2017-05-24 Thread Eduardo Habkost
On Wed, May 24, 2017 at 02:13:16PM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Tue, May 23, 2017 at 04:12:43PM +0200, Markus Armbruster wrote: > >> Eduardo Habkost writes: > >> > >> > This series adds 'abstract' and 'parent-types' fields to the > >> > output of qom-list-t

Re: [Qemu-devel] [PATCH] libvhost-user: Fix VHOST_USER_NET_SET_MTU entry

2017-05-24 Thread Marc-André Lureau
- Original Message - > From: "Dr. David Alan Gilbert" > > VHOST_USER_'s 20th entry is defined as VHOST_USER_INPUT_GET_CONFIG but > should be VHOST_USER_NET_SET_MTU. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Marc-André Lureau > --- > contrib/libvhost-user/libvhost-user

Re: [Qemu-devel] new to qemu with a simple question

2017-05-24 Thread Eric Blake
On 05/23/2017 09:56 PM, Wang Dong wrote: > > Hi guys, > > I am new to qemu. But I need do some job in it right now. > > When I try read qmp code. I found a interesting part against it. > > Some C source code is generate from json file. > > I wonder why this? What is the benefits of this? Bori

Re: [Qemu-devel] [PATCH 1/3] migration: Use savevm_handlers instead of loadvm copy

2017-05-24 Thread Laurent Vivier
On 24/05/2017 10:55, Juan Quintela wrote: > From: Juan Quintela > > There is no reason for having the loadvm_handlers at all. There is > only one use, and we can use the savevm handlers. > > We will remove the loadvm handlers on a following patch. > > Signed-off-by: Juan Quintela > --- > mig

Re: [Qemu-devel] [PATCH v2 05/13] vvfat: introduce offset_to_bootsector, offset_to_fat and offset_to_root_dir

2017-05-24 Thread Eric Blake
On 05/23/2017 11:10 PM, Philippe Mathieu-Daudé wrote: > Hi Hervé, > > On 05/22/2017 06:11 PM, Hervé Poussineau wrote: >> - offset_to_bootsector is the number of sectors up to FAT bootsector >> - offset_to_fat is the number of sectors up to first File Allocation >> Table >> - offset_to_root_dir is

Re: [Qemu-devel] [PATCH 1/4] qemu-io: Don't die on second open

2017-05-24 Thread Eric Blake
On 05/24/2017 01:28 AM, Fam Zheng wrote: > On Thu, 05/18 21:32, Eric Blake wrote: >> Failure to open a file in qemu-io should normally return 1 on >> failure to end the command loop, on the presumption that when >> batching commands all on the command line, failure to open means >> nothing further

Re: [Qemu-devel] [PATCH] kvmclock: update system_time_msr address forcibly

2017-05-24 Thread Denis V. Lunev
On 05/24/2017 05:07 PM, Denis Plotnikov wrote: > Do an update of system_time_msr address every time before reading > the value of tsc_timestamp from guest's kvmclock page. > > It should be done in a forcible manner because there is a situation > when system_time_msr has been set by kvm but qemu doe

Re: [Qemu-devel] [PATCH v4 1/8] tpm-backend: Remove unneeded member variable from backend class

2017-05-24 Thread Stefan Berger
On 05/16/2017 03:58 AM, Amarnath Valluri wrote: TPMDriverOps inside TPMBackend is not required, as it is supposed to be a class member. The only possible reason for keeping in TPMBackend was, to get the backend type in tpm.c where dedicated backend api, tpm_backend_get_type() is present. Signed-

Re: [Qemu-devel] [PATCH v4 2/8] tpm-backend: Move thread handling inside TPMBackend

2017-05-24 Thread Stefan Berger
On 05/16/2017 03:58 AM, Amarnath Valluri wrote: Move thread handling inside TPMBackend, this way backend implementations need not to maintain their own thread life cycle, instead they needs to implement 'handle_request()' class method that always been called from a thread. This change made tpm_b

Re: [Qemu-devel] [PATCH 0/7] qcow2: Reduce the number of I/O ops when doing COW

2017-05-24 Thread Alberto Garcia
On Tue 23 May 2017 04:36:52 PM CEST, Eric Blake wrote: >> here's a patch series that rewrites the copy-on-write code in the >> qcow2 driver to reduce the number of I/O operations. > > And it competes with Denis and Anton's patches: > https://lists.gnu.org/archive/html/qemu-devel/2017-05/msg04547.h

Re: [Qemu-devel] [PATCH] migration: remove register_savevm()

2017-05-24 Thread Dmitry Fleytman
> On 24 May 2017, at 15:10 PM, Laurent Vivier wrote: > > We can replace the four remaining calls of register_savevm() by > calls to register_savevm_live(). So we can remove the function and > as we don't allocate anymore the ops pointer with g_new0() > we don't have to free it then. > > Signed-

Re: [Qemu-devel] [PATCH v4 3/8] tpm-backend: Initialize and free data members in it's own methods

2017-05-24 Thread Stefan Berger
On 05/16/2017 03:58 AM, Amarnath Valluri wrote: Initialize and free TPMBackend data members in it's own instance_init() and instance_finalize methods. Took the opportunity to remove unneeded destroy() method from TpmDriverOps interface as TPMBackend is a Qemu Object, we can use object_unref() in

Re: [Qemu-devel] [PATCH v4 4/8] tpm-backend: Made few interface methods optional

2017-05-24 Thread Stefan Berger
On 05/16/2017 03:58 AM, Amarnath Valluri wrote: This allows backend implementations left optional interface methods. For mandatory methods assertion checks added. Took the opportunity to remove unused methods: tpm_backend_get_type() tpm_backend_get_desc() Signed-off-by: Amarnath Valluri

Re: [Qemu-devel] [RFC 0/3] qmp: Return extra information on qom-list-types

2017-05-24 Thread Eric Blake
On 05/24/2017 07:13 AM, Markus Armbruster wrote: >>> Might lead to more traffic rather than less. Depends on what >>> information the client needs to query. >> >> I think queries that return all available QOM types are likely to >> (should?) be cached by clients. > > Perhaps libvirt developers c

Re: [Qemu-devel] [PATCH] Fix nmi injection failure when vcpu got blocked

2017-05-24 Thread Radim Krčmář
Please use tags in patches. We usually begin the subject with "KVM: x86:" when touching arch/x86/kvm/x86.c. 2017-05-24 13:48+0800, Zhuangyanying: > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > @@ -8394,7 +8394,8 @@ static inline bool kvm_vcpu_has_events(struct kvm_vcpu > *vcpu) >

Re: [Qemu-devel] [PATCH v4 1/8] tpm-backend: Remove unneeded member variable from backend class

2017-05-24 Thread Marc-André Lureau
Hi On Tue, May 16, 2017 at 12:00 PM Amarnath Valluri < amarnath.vall...@intel.com> wrote: > TPMDriverOps inside TPMBackend is not required, as it is supposed to be a > class > member. The only possible reason for keeping in TPMBackend was, to get the > backend type in tpm.c where dedicated backen

Re: [Qemu-devel] [PATCH v4 5/8] tmp backend: Add new api to read backend TpmInfo

2017-05-24 Thread Stefan Berger
On 05/16/2017 03:58 AM, Amarnath Valluri wrote: TPM configuration options are backend implementation details and shall not be part of base TPMBackend object, and these shall not be accessed directly outside of the class, hence added a new interface method, get_tpm_options() to TPMDriverOps., whic

Re: [Qemu-devel] [PATCH 1/3] migration: Use savevm_handlers instead of loadvm copy

2017-05-24 Thread Juan Quintela
Laurent Vivier wrote: > On 24/05/2017 10:55, Juan Quintela wrote: >> From: Juan Quintela >> >> There is no reason for having the loadvm_handlers at all. There is >> only one use, and we can use the savevm handlers. >> >> We will remove the loadvm handlers on a following patch. >> >> Signed-of

Re: [Qemu-devel] [PATCH v4 6/8] tpm-backend: Move realloc_buffer() implementation to tpm-tis model

2017-05-24 Thread Stefan Berger
On 05/16/2017 03:58 AM, Amarnath Valluri wrote: buffer reallocation is very unlikely to be backend specific. Hence move inside the tis. Signed-off-by: Amarnath Valluri Reviewed-by: Stefan Berger

Re: [Qemu-devel] [PATCH v4 7/8] tpm-passthrough: move reusable code to utils

2017-05-24 Thread Stefan Berger
On 05/16/2017 03:58 AM, Amarnath Valluri wrote: Signed-off-by: Amarnath Valluri Reviewed-by: Stefan Berger

Re: [Qemu-devel] [PATCH 2/4] block: Guarantee that *file is set on bdrv_get_block_status()

2017-05-24 Thread Eric Blake
On 05/18/2017 09:32 PM, Eric Blake wrote: > We document that *file is valid if the return is not an error and > includes BDRV_BLOCK_OFFSET_VALID, but forgot to obey this contract > when a driver (such as blkdebug) lacks a callback. Broken in > commit 67a0fd2 (v2.6), when we added the file paramete

[Qemu-devel] Status of q35-lite?

2017-05-24 Thread Stefan Hajnoczi
Hi Chao, Last year there was an effort to make "built-in" hardware optional so that VMs can be launched with a minimal set of devices. You made SATA, PIT, and SMBus optional. What is the current status of this work? Are there more devices that could benefit from an optional switch? For referenc

Re: [Qemu-devel] VhostUserRequest # 20

2017-05-24 Thread Marc-André Lureau
Hi - Original Message - > * Marc-André Lureau (marcandre.lur...@redhat.com) wrote: > > HI > > > > - Original Message - > > > Hi, > > > libvhost-user.h defines: > > >VHOST_USER_INPUT_GET_CONFIG = 20, > > > > That slipped by mistake from my vhost-user-input series WIP, please

Re: [Qemu-devel] [PATCH v4 8/8] tpm: Added support for TPM emulator

2017-05-24 Thread Stefan Berger
On 05/16/2017 03:58 AM, Amarnath Valluri wrote: This change introduces a new TPM backend driver that can communicate with swtpm(software TPM emulator) using unix domain socket interface. Swtpm uses two unix sockets, one for plain TPM commands and responses, and one for out-of-band control messag

[Qemu-devel] [PATCH] kvmclock: update system_time_msr address forcibly

2017-05-24 Thread Denis Plotnikov
Do an update of system_time_msr address every time before reading the value of tsc_timestamp from guest's kvmclock page. It should be done in a forcible manner because there is a situation when system_time_msr has been set by kvm but qemu doesn't aware of it. This leads to updates of kvmclock_offs

Re: [Qemu-devel] [PATCH] kvmclock: update system_time_msr address forcibly

2017-05-24 Thread Denis Plotnikov
On 24.05.2017 17:09, Denis V. Lunev wrote: On 05/24/2017 05:07 PM, Denis Plotnikov wrote: Do an update of system_time_msr address every time before reading the value of tsc_timestamp from guest's kvmclock page. It should be done in a forcible manner because there is a situation when system_ti

[Qemu-devel] Monitor file path length limitation

2017-05-24 Thread Simon
Hello, It seems that the monitor file path length is limited to about 100 characters (107 to be precise). Currently I'm using the '-monitor' parameter to create the monitor file in a directory which gather all the files related to a given VM (monitor file, PID file, disk image, etc.): -mon

Re: [Qemu-devel] Monitor file path length limitation

2017-05-24 Thread Eric Blake
On 05/24/2017 10:16 AM, Simon wrote: > Hello, > > It seems that the monitor file path length is limited to about 100 > characters (107 to be precise). Welcome to the joy of Unix socket (AF_UNIX) files. The kernel imposes a hard length limit on sockaddr_un.sun_path[] (see 'man 7 unix') - and it i

Re: [Qemu-devel] Monitor file path length limitation

2017-05-24 Thread Simon
Thank you for your answer Eric, I've learned a new thing today :) !

Re: [Qemu-devel] [PATCH] migration: remove register_savevm()

2017-05-24 Thread Cornelia Huck
On Wed, 24 May 2017 14:10:48 +0200 Laurent Vivier wrote: > We can replace the four remaining calls of register_savevm() by > calls to register_savevm_live(). So we can remove the function and > as we don't allocate anymore the ops pointer with g_new0() > we don't have to free it then. > > Signed

[Qemu-devel] [PATCH] sockets: report error if UNIX socket path is too long

2017-05-24 Thread Daniel P. Berrange
The 'struct sockaddr_un' only allows 108 bytes for the socket path. Currently QEMU uses snprintf() and so silently truncates the socket path provided by the user. This is undesirable because the user will then be unable to connect to the path they asked for. This change makes QEMU bounds check and

Re: [Qemu-devel] Monitor file path length limitation

2017-05-24 Thread Daniel P. Berrange
On Wed, May 24, 2017 at 10:26:58AM -0500, Eric Blake wrote: > On 05/24/2017 10:16 AM, Simon wrote: > > Hello, > > > > It seems that the monitor file path length is limited to about 100 > > characters (107 to be precise). > > Welcome to the joy of Unix socket (AF_UNIX) files. The kernel imposes a

Re: [Qemu-devel] [svt-core] [PATCH] kvmclock: update system_time_msr address forcibly

2017-05-24 Thread Roman Kagan
On Wed, May 24, 2017 at 05:07:24PM +0300, Denis Plotnikov wrote: > Do an update of system_time_msr address every time before reading > the value of tsc_timestamp from guest's kvmclock page. > > It should be done in a forcible manner because there is a situation > when system_time_msr has been set

Re: [Qemu-devel] [PATCH] sockets: report error if UNIX socket path is too long

2017-05-24 Thread Eric Blake
On 05/24/2017 10:42 AM, Daniel P. Berrange wrote: > The 'struct sockaddr_un' only allows 108 bytes for the socket > path. Currently QEMU uses snprintf() and so silently truncates > the socket path provided by the user. This is undesirable because > the user will then be unable to connect to the pat

  1   2   3   >