David Gibson <da...@gibson.dropbear.id.au> wrote: > On Wed, May 24, 2017 at 08:28:59AM +0200, Juan Quintela wrote: >> Bharata B Rao <bhar...@linux.vnet.ibm.com> wrote: >> > Introduce a new function unregister_savevm_live() to unregister the vmstate >> > handlers registered via register_savevm_live(). >> > >> > register_savevm() allocates SaveVMHandlers while register_savevm_live() >> > gets passed with SaveVMHandlers. During unregistration, we want to >> > free SaveVMHandlers in the former case but not free in the latter case. >> > Hence this new API is needed to differentiate this. >> > >> > This new API will be needed by PowerPC to unregister the HTAB savevm >> > handlers. >> > >> > Signed-off-by: Bharata B Rao <bhar...@linux.vnet.ibm.com> >> > Reviewed-by: David Gibson <da...@gibson.dropbear.id.au> >> > Cc: Juan Quintela <quint...@redhat.com> >> > Cc: Dr. David Alan Gilbert <dgilb...@redhat.com> >> >> Hi >> >> How about this one? >> I just test compiled it. >> >> Advantage from my point of view is that we always do the right thing. >> And as migration code already knows if it has to be freed or not, I >> think it is a better API. >> >> What do you think? > > I think this is a better approach. Do you want to push this one > directly, Juan, or do you want me to take it through my tree?
I will push it on my next pull request. I mean, I will send it for review on own top level. Thanks, Juan.
