Re: [Qemu-devel] [PATCH] block migration: Allow compile time disable

2017-05-15 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" wrote: > > From: "Dr. David Alan Gilbert" > > > > Many users now prefer to use drive_mirror over NBD as an > > alternative to the older migrate -b option; drive_mirror is > > more complex to setup but gives you more opt

Re: [Qemu-devel] [PULL 0/9] pci, virtio, vhost: fixes

2017-05-15 Thread Michael S. Tsirkin
On Mon, May 15, 2017 at 01:58:40PM +0100, Stefan Hajnoczi wrote: > On Wed, May 10, 2017 at 10:07:58PM +0300, Michael S. Tsirkin wrote: > > The following changes since commit 76d20ea0f1b26ebd5da2f5fb2fdf3250cde887bb: > > > > Merge remote-tracking branch 'armbru/tags/pull-qapi-2017-05-04-v3' into

Re: [Qemu-devel] [PULL 00/23] ppc-for-2.10 queue 20170511

2017-05-15 Thread Stefan Hajnoczi
On Thu, May 11, 2017 at 02:14:03PM +1000, David Gibson wrote: > The following changes since commit 76d20ea0f1b26ebd5da2f5fb2fdf3250cde887bb: > > Merge remote-tracking branch 'armbru/tags/pull-qapi-2017-05-04-v3' into > staging (2017-05-09 15:49:14 -0400) > > are available in the git repository

Re: [Qemu-devel] [PATCH] qemu-iotests: Test streaming with missing job ID

2017-05-15 Thread Kevin Wolf
Am 15.05.2017 um 14:46 hat Alberto Garcia geschrieben: > On Mon 15 May 2017 02:39:40 PM CEST, Kevin Wolf wrote: > > This adds a small test for the image streaming error path for failing > > block_job_create(), which would have found the null pointer dereference > > in commit a170a91f. > > > > Signe

[Qemu-devel] [PATCH v9] migrate pending_events of spapr state

2017-05-15 Thread Daniel Henrique Barboza
This patch was detached from the patchset: "[PATCH v9 0/6] migration/ppc: migrating DRC, ccs_list and pending_events" Because it is independent and has use outside of the scope of the pseries DRC migration patchset. Change log: v9: no changes v8: no changes v7: no changes v6: - Rebased with

[Qemu-devel] [PATCH v9] migration: spapr: migrate pending_events of spapr state

2017-05-15 Thread Daniel Henrique Barboza
From: Jianjun Duan In racing situations between hotplug events and migration operation, a rtas hotplug event could have not yet be delivered to the source guest when migration is started. In this case the pending_events of spapr state need be transmitted to the target so that the hotplug event ca

Re: [Qemu-devel] [PULL 0/4] make display updates thread safe, batch #2

2017-05-15 Thread Stefan Hajnoczi
On Thu, May 11, 2017 at 04:43:35PM +0200, Gerd Hoffmann wrote: > Hi, > > Here is the vga patch queue, with the second patch batch to make display > updates thread-safe. > > please pull, > Gerd > > The following changes since commit 76d20ea0f1b26ebd5da2f5fb2fdf3250cde887bb: > > Merge remot

Re: [Qemu-devel] [PATCH] block migration: Allow compile time disable

2017-05-15 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> "Dr. David Alan Gilbert (git)" wrote: >> > From: "Dr. David Alan Gilbert" >> > >> > Many users now prefer to use drive_mirror over NBD as an >> > alternative to the older migrate -b option; drive_mirror is >> > mor

[Qemu-devel] [PATCH v10] migration: spapr: migrate pending_events of spapr state

2017-05-15 Thread Daniel Henrique Barboza
From: Jianjun Duan In racing situations between hotplug events and migration operation, a rtas hotplug event could have not yet be delivered to the source guest when migration is started. In this case the pending_events of spapr state need be transmitted to the target so that the hotplug event ca

[Qemu-devel] [PATCH v10] pseries: migrate pending_events of spapr state

2017-05-15 Thread Daniel Henrique Barboza
This patch was detached from the patchset: "[PATCH v9 0/6] migration/ppc: migrating DRC, ccs_list and pending_events" Because it is independent and has use outside of the scope of the pseries DRC migration patchset. Change log: v10: detached from DRC patch set v9: no changes v8: no changes

Re: [Qemu-devel] [Qemu-ppc] [PATCH v9] migrate pending_events of spapr state

2017-05-15 Thread Daniel Henrique Barboza
Please ignore this patch. I've resent it again as "v10" to help differentiate from the v9 version that is still included in the DRC patch set. Daniel On 05/15/2017 10:06 AM, Daniel Henrique Barboza wrote: This patch was detached from the patchset: "[PATCH v9 0/6] migration/ppc: migrating DRC

Re: [Qemu-devel] [RFC PATCH 2/8] iommu/vt-d: add bind_pasid_table function

2017-05-15 Thread jacob pan
On Fri, 12 May 2017 15:59:29 -0600 Alex Williamson wrote: > > + if (pasidt_binfo->size >= intel_iommu_get_pts(iommu)) { > > + pr_err("Invalid gPASID table size %llu, host size > > %lu\n", > > + pasidt_binfo->size, > > + intel_iommu_get_pts(iommu));

Re: [Qemu-devel] [PULL 00/29] x86 and machine queue, 2017-05-11

2017-05-15 Thread Stefan Hajnoczi
On Thu, May 11, 2017 at 04:18:14PM -0300, Eduardo Habkost wrote: > The following changes since commit 76d20ea0f1b26ebd5da2f5fb2fdf3250cde887bb: > > Merge remote-tracking branch 'armbru/tags/pull-qapi-2017-05-04-v3' into > staging (2017-05-09 15:49:14 -0400) > > are available in the git reposit

Re: [Qemu-devel] [PATCH 6/6] spapr: fix migration of ICP objects from/to older QEMU

2017-05-15 Thread Greg Kurz
On Mon, 15 May 2017 14:22:32 +0200 Cédric Le Goater wrote: > On 05/15/2017 01:40 PM, Greg Kurz wrote: > > Commit 5bc8d26de20c ("spapr: allocate the ICPState object from under > > sPAPRCPUCore") moved ICP objects from the machine to CPU cores. This > > is an improvement since we no longer allocate

[Qemu-devel] [PATCH] msi: remove return code for msi_init()

2017-05-15 Thread Peter Xu
MSI should be supported by all interrupt controllers. Switching the old check for msi_nonbroken into assertion. Do similar thing to pci_add_capability2() below that. Then time to remove *errp. Since msi_init() won't fail now, touch up all the callers to avoid checks against it. One side effect is

Re: [Qemu-devel] [PATCH] qemu-iotests: Test streaming with missing job ID

2017-05-15 Thread Alberto Garcia
On Mon 15 May 2017 03:05:00 PM CEST, Kevin Wolf wrote: >> Mmm... but does that trigger the bug? >> >> The bug happens if the user tries to create a stream job on a BDS that: >> >> a) exists >> b) is not the active node (i.e. needs reopening in read-write mode) >> c) its node name is not valid for

Re: [Qemu-devel] [PATCH] block migration: Allow compile time disable

2017-05-15 Thread Dr. David Alan Gilbert
* Kashyap Chamarthy (kcham...@redhat.com) wrote: > On Wed, May 03, 2017 at 11:42:57AM +0100, Dr. David Alan Gilbert (git) wrote: > > A small comment inline, in the 'ifndef' section. > > > From: "Dr. David Alan Gilbert" > > > > Many users now prefer to use drive_mirror over NBD as an > > alterna

Re: [Qemu-devel] [PULL 00/10] ui patch queue

2017-05-15 Thread Stefan Hajnoczi
On Fri, May 12, 2017 at 01:51:25PM +0200, Gerd Hoffmann wrote: > Hi, > > Here is the ui patch queue with some vnc cleanups, absolute event > support for input linux, egl bugfixes and the new eg-headless ui. > > please pull, > Gerd > > The following changes since commit 76d20ea0f1b26ebd5da2f5

Re: [Qemu-devel] [PULL 0/6] usb patch queue

2017-05-15 Thread Stefan Hajnoczi
On Fri, May 12, 2017 at 02:21:52PM +0200, Gerd Hoffmann wrote: > Hi, > > Here comes the usb patch queue, with a bugfix collection and a > documentation update. > > please pull, > Gerd > > The following changes since commit 76d20ea0f1b26ebd5da2f5fb2fdf3250cde887bb: > > Merge remote-trackin

Re: [Qemu-devel] [PATCH] ehci: fix overflow in frame timer code

2017-05-15 Thread Philippe Mathieu-Daudé
Hi Gerd, 李林, On 05/15/2017 07:45 AM, Gerd Hoffmann wrote: In case the frame timer doesn't run for a while due to the host being busy skipped_uframes can become big enough that UFRAME_TIMER_NS * skipped_uframes overflows. Which in turn throws off all subsequent ehci frame timer calculations. Re

[Qemu-devel] [PATCH] hmp / net: Mark host_net_add/remove as deprecated

2017-05-15 Thread Thomas Huth
The netdev_add and netdev_del commands should be used nowadays instead. Signed-off-by: Thomas Huth --- hmp-commands.hx | 8 net/net.c | 13 + 2 files changed, 17 insertions(+), 4 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 0aca984..baeac47 10064

Re: [Qemu-devel] [RFC PATCH] qemu-io: add drain/undrain cmd

2017-05-15 Thread Fam Zheng
On Mon, 05/15 15:01, Peter Lieven wrote: > Am 15.05.2017 um 14:52 schrieb Fam Zheng: > > On Mon, 05/15 14:32, Peter Lieven wrote: > > > Am 15.05.2017 um 14:28 schrieb Fam Zheng: > > > > On Mon, 05/15 13:58, Peter Lieven wrote: > > > > > Am 15.05.2017 um 13:53 schrieb Fam Zheng: > > > > > > On Mon,

Re: [Qemu-devel] [PATCH 1/6] ppc/xics: simplify prototype of xics_spapr_init()

2017-05-15 Thread Philippe Mathieu-Daudé
On 05/15/2017 08:39 AM, Greg Kurz wrote: This function only does hypercall and RTAS-call registration, and thus never returns an error. This patch adapt the prototype to reflect that. Signed-off-by: Greg Kurz Reviewed-by: Philippe Mathieu-Daudé --- hw/intc/xics_spapr.c |3 +-- hw/ppc

Re: [Qemu-devel] [PULL for-2.9 1/3] coroutine: remove GThread implementation

2017-05-15 Thread Stefan Hajnoczi
On Fri, May 12, 2017 at 03:19:18PM -0500, Eric Blake wrote: > On 05/12/2017 09:37 AM, Stefan Hajnoczi wrote: > > From: "Daniel P. Berrange" > > > > The GThread implementation is not functional enough to actually > > run QEMU reliably. While it was potentially useful for debugging, > > we have a s

Re: [Qemu-devel] [PULL for-2.9 0/1] Tracing patches

2017-05-15 Thread Stefan Hajnoczi
On Fri, May 12, 2017 at 10:38:11AM -0400, Stefan Hajnoczi wrote: > The following changes since commit ecc1f5adeec4e3324d1b695a7c54e3967c526949: > > maintainers: Add myself as linux-user reviewer (2017-05-11 13:31:11 -0400) > > are available in the git repository at: > > git://github.com/stef

Re: [Qemu-devel] [PULL for-2.9 0/3] Block patches

2017-05-15 Thread Stefan Hajnoczi
On Fri, May 12, 2017 at 10:37:14AM -0400, Stefan Hajnoczi wrote: > The following changes since commit ecc1f5adeec4e3324d1b695a7c54e3967c526949: > > maintainers: Add myself as linux-user reviewer (2017-05-11 13:31:11 -0400) > > are available in the git repository at: > > git://github.com/stef

Re: [Qemu-devel] [PATCH] block migration: Allow compile time disable

2017-05-15 Thread Eric Blake
On 05/15/2017 07:13 AM, Dr. David Alan Gilbert wrote: >>> +#ifndef CONFIG_LIVE_BLOCK_MIGRATION >>> +if (params.blk || params.shared) { >>> +error_setg(errp, "QEMU compiled without old-style block migration. >>> " >>> + "Use drive_mirror+NBD."); >> >> error_setg

[Qemu-devel] [PATCH] .gdbinit: load QEMU sub-commands when gdb starts

2017-05-15 Thread Stefan Hajnoczi
The scripts/qemu-gdb.py file is not easily discoverable. Add a .gdbinit file so GDB either loads qemu-gdb.py automatically or prints a message informing the user how to enable them (some systems disable ./.gdbinit loading for security reasons). Suggested-by: Eric Blake Signed-off-by: Stefan Hajn

Re: [Qemu-devel] [PATCH] .gdbinit: load QEMU sub-commands when gdb starts

2017-05-15 Thread Philippe Mathieu-Daudé
On 05/15/2017 10:47 AM, Stefan Hajnoczi wrote: The scripts/qemu-gdb.py file is not easily discoverable. Add a .gdbinit file so GDB either loads qemu-gdb.py automatically or prints a message informing the user how to enable them (some systems disable ./.gdbinit loading for security reasons). Sug

Re: [Qemu-devel] [PATCH] libvixl: Correct ordering of includes and fix NetBSD build

2017-05-15 Thread Eric Blake
On 05/13/2017 05:04 PM, Philippe Mathieu-Daudé wrote: > Hi Kamil, > > I think it is safer to add it in disas/libvixl/Makefile.objs where > QEMU_CFLAGS are tuned for libvixl. > This way you don't need to modify upstream libvixl. > Ah, right. disas/libvixl is one of the directories exempt from our

Re: [Qemu-devel] [PULL 0/5] Migration pull request

2017-05-15 Thread Stefan Hajnoczi
On Fri, May 12, 2017 at 05:52:44PM +0200, Juan Quintela wrote: > Hi > > This pull contains: > - Fix regression with compression threads (mea culpa) > - start of includes migration (creating of blocker.h header) > - Use Error** correctly after several iterations > - Rename of RAM_SAVE_FLAG_COMPRESS

Re: [Qemu-devel] [PATCH 07/17] json: learn to parse uint64 numbers

2017-05-15 Thread Markus Armbruster
Marc-André Lureau writes: > Switch strtoll() usage to qemu_strtoi64() helper while at it. > > Replace temporarily the error in qnum_get_int() with values >INT64_MAX > until the visitor is updated. > > Add a few tests for large numbers. > > Signed-off-by: Marc-André Lureau > --- > qobject/json-l

Re: [Qemu-devel] [RFC PATCH] qemu-io: add drain/undrain cmd

2017-05-15 Thread Peter Lieven
Am 15.05.2017 um 15:35 schrieb Fam Zheng: On Mon, 05/15 15:01, Peter Lieven wrote: Am 15.05.2017 um 14:52 schrieb Fam Zheng: On Mon, 05/15 14:32, Peter Lieven wrote: Am 15.05.2017 um 14:28 schrieb Fam Zheng: On Mon, 05/15 13:58, Peter Lieven wrote: Am 15.05.2017 um 13:53 schrieb Fam Zheng:

[Qemu-devel] [PATCH v9 0/4] Improve convert and dd commands

2017-05-15 Thread Daniel P. Berrange
Update to v1: https://lists.gnu.org/archive/html/qemu-devel/2017-01/msg05699.html v2: https://lists.gnu.org/archive/html/qemu-devel/2017-02/msg00728.html v3: https://lists.gnu.org/archive/html/qemu-devel/2017-02/msg04391.html v4: https://lists.gnu.org/archive/html/qemu-devel/2017-04/msg021

Re: [Qemu-devel] [RFC PATCH v4 1/6] coccinelle: add a script to optimize tcg op using tcg_gen_extract()

2017-05-15 Thread Eric Blake
On 05/12/2017 06:38 PM, Philippe Mathieu-Daudé wrote: > If you have coccinelle installed you can apply this script using: > > $ spatch \ > --macro-file scripts/cocci-macro-file.h \ > --dir target --in-place > > You can also use directly Peter Senna Tschudin docker image (easie

[Qemu-devel] [PATCH v9 3/4] qemu-img: introduce --target-image-opts for 'convert' command

2017-05-15 Thread Daniel P. Berrange
The '--image-opts' flag indicates whether the source filename includes options. The target filename has to remain in the plain filename format though, since it needs to be passed to bdrv_create(). When using --skip-create though, it would be possible to use image-opts syntax. This adds --target-im

[Qemu-devel] [PATCH v9 1/4] qemu-img: add support for --object with 'dd' command

2017-05-15 Thread Daniel P. Berrange
The qemu-img dd command added --image-opts support, but missed the corresponding --object support. This prevented passing secrets (eg auth passwords) needed by certain disk images. Reviewed-by: Fam Zheng Reviewed-by: Max Reitz Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- qemu

[Qemu-devel] [PATCH v9 2/4] qemu-img: fix --image-opts usage with dd command

2017-05-15 Thread Daniel P. Berrange
The --image-opts flag can only be used to affect the parsing of the source image. The target image has to be specified in the traditional style regardless, since it needs to be passed to the bdrv_create() API which does not support the new style opts. Reviewed-by: Fam Zheng Reviewed-by: Max Reitz

[Qemu-devel] [PATCH v2] block migration: Allow compile time disable

2017-05-15 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Many users now prefer to use drive_mirror over NBD as an alternative to the older migrate -b option; drive_mirror is more complex to setup but gives you more options (e.g. only migrating some of the disks if some of them are shared). Allow the large chunk of block

Re: [Qemu-devel] [PATCH] libvixl: Correct ordering of includes and fix NetBSD build

2017-05-15 Thread Kamil Rytarowski
On 15.05.2017 15:57, Eric Blake wrote: > On 05/13/2017 05:04 PM, Philippe Mathieu-Daudé wrote: >> Hi Kamil, >> >> I think it is safer to add it in disas/libvixl/Makefile.objs where >> QEMU_CFLAGS are tuned for libvixl. >> This way you don't need to modify upstream libvixl. >> > > Ah, right. disas/

[Qemu-devel] [PATCH v9 4/4] qemu-img: copy *key-secret opts when opening newly created files

2017-05-15 Thread Daniel P. Berrange
The qemu-img dd/convert commands will create an image file and then try to open it. Historically it has been possible to open new files without passing any options. With encrypted files though, the *key-secret options are mandatory, so we need to provide those options when opening the newly created

Re: [Qemu-devel] [RFC PATCH v4 1/6] coccinelle: add a script to optimize tcg op using tcg_gen_extract()

2017-05-15 Thread Paolo Bonzini
On 15/05/2017 16:04, Eric Blake wrote: > On 05/12/2017 06:38 PM, Philippe Mathieu-Daudé wrote: >> If you have coccinelle installed you can apply this script using: >> >> $ spatch \ >> --macro-file scripts/cocci-macro-file.h \ >> --dir target --in-place >> >> You can also use d

[Qemu-devel] [PATCH] qemu-img: Fix leakage of options on error

2017-05-15 Thread Fam Zheng
Reported by Coverity. Signed-off-by: Fam Zheng --- qemu-img.c | 1 + 1 file changed, 1 insertion(+) diff --git a/qemu-img.c b/qemu-img.c index b506839..8b0dfa7 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -294,6 +294,7 @@ static BlockBackend *img_open_opts(const char *optstr, if (qdict_

Re: [Qemu-devel] [RFC PATCH v4 1/6] coccinelle: add a script to optimize tcg op using tcg_gen_extract()

2017-05-15 Thread Laurent Vivier
On 15/05/2017 16:06, Paolo Bonzini wrote: > > > On 15/05/2017 16:04, Eric Blake wrote: >> On 05/12/2017 06:38 PM, Philippe Mathieu-Daudé wrote: >>> If you have coccinelle installed you can apply this script using: >>> >>> $ spatch \ >>> --macro-file scripts/cocci-macro-file.h \ >>>

Re: [Qemu-devel] [PULL 0/9] Queued s390 patches

2017-05-15 Thread Stefan Hajnoczi
On Fri, May 12, 2017 at 04:40:00PM -0700, Richard Henderson wrote: > This is a combination of my queued patches and those > posted by Aurelien this week. > > > r~ > > > The following changes since commit ecc1f5adeec4e3324d1b695a7c54e3967c526949: > > maintainers: Add myself as linux-user revi

Re: [Qemu-devel] [RFC PATCH] qemu-io: add drain/undrain cmd

2017-05-15 Thread Fam Zheng
On Mon, 05/15 16:02, Peter Lieven wrote: > > > do you have a pointer to the image locking mechanism? > > It hit qemu.git master just a moment ago. See raw_check_perm. > > which master are you looking at? > > $ git fetch upstream > $ git log upstream/master --oneline > 3a87606 Merge tag 'tracing-p

Re: [Qemu-devel] [PATCH] maintainers: Add myself as a NetBSD reviewer

2017-05-15 Thread Stefan Hajnoczi
On Sat, May 13, 2017 at 04:21:43AM +0200, Kamil Rytarowski wrote: > I volunteer to review NetBSD patches. > Adding myself will help to not miss some of them. > > Restore NetBSD as a maintained host. > > All patches to make qemu/pkgsrc building have been emitted to review. > > Signed-off-by: Kami

Re: [Qemu-devel] [PULL 00/15] Queued target/sh4 patches

2017-05-15 Thread Stefan Hajnoczi
On Sat, May 13, 2017 at 11:32:33AM +0200, Aurelien Jarno wrote: > The following changes since commit ecc1f5adeec4e3324d1b695a7c54e3967c526949: > > maintainers: Add myself as linux-user reviewer (2017-05-11 13:31:11 -0400) > > are available in the git repository at: > > git://git.aurel32.net/

Re: [Qemu-devel] [PATCH] .gdbinit: load QEMU sub-commands when gdb starts

2017-05-15 Thread Alex Bennée
Stefan Hajnoczi writes: > The scripts/qemu-gdb.py file is not easily discoverable. Add a .gdbinit > file so GDB either loads qemu-gdb.py automatically or prints a message > informing the user how to enable them (some systems disable ./.gdbinit > loading for security reasons). > > Suggested-by:

Re: [Qemu-devel] [PATCH] qemu-img: Fix documentation of convert

2017-05-15 Thread Eric Blake
On 05/15/2017 05:35 AM, Fam Zheng wrote: > It got lost in commit a8d16f9ca "qemu-img: Update documentation for -U". > > Reported-by: Max Reitz > Signed-off-by: Fam Zheng > --- > qemu-img-cmds.hx | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake -- Eric Blak

Re: [Qemu-devel] [RFC PATCH] qemu-io: add drain/undrain cmd

2017-05-15 Thread Peter Lieven
Am 15.05.2017 um 15:02 schrieb Kevin Wolf: Am 15.05.2017 um 14:52 hat Fam Zheng geschrieben: On Mon, 05/15 14:32, Peter Lieven wrote: Am 15.05.2017 um 14:28 schrieb Fam Zheng: On Mon, 05/15 13:58, Peter Lieven wrote: Am 15.05.2017 um 13:53 schrieb Fam Zheng: On Mon, 05/15 13:26, Peter Lieven

Re: [Qemu-devel] [PATCH 1/3] migration: Create block capabilities for shared and enable

2017-05-15 Thread Eric Blake
On 05/15/2017 04:46 AM, Dr. David Alan Gilbert wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> Eric Blake wrote: >>> On 05/11/2017 11:32 AM, Juan Quintela wrote: Those two capabilities were added through the command line. Notice that we just created them. This is just the boil

Re: [Qemu-devel] [PATCH 2/3] migration: Remove use of old MigrationParams

2017-05-15 Thread Eric Blake
[adding Markus] On 05/15/2017 04:48 AM, Juan Quintela wrote: > Eric Blake wrote: >> On 05/12/2017 05:55 AM, Juan Quintela wrote: > @@ -1239,6 +1240,7 @@ void qmp_migrate(const char *uri, bool has_blk, > bool blk, > } > > if (has_inc && inc) { > +migrat

Re: [Qemu-devel] [PATCH] maintainers: Add myself as a NetBSD reviewer

2017-05-15 Thread Kamil Rytarowski
On 15.05.2017 16:13, Stefan Hajnoczi wrote: > On Sat, May 13, 2017 at 04:21:43AM +0200, Kamil Rytarowski wrote: >> I volunteer to review NetBSD patches. >> Adding myself will help to not miss some of them. >> >> Restore NetBSD as a maintained host. >> >> All patches to make qemu/pkgsrc building hav

Re: [Qemu-devel] [PATCH] maintainers: Add myself as a NetBSD reviewer

2017-05-15 Thread Paolo Bonzini
On 15/05/2017 16:22, Kamil Rytarowski wrote: > On 15.05.2017 16:13, Stefan Hajnoczi wrote: >> On Sat, May 13, 2017 at 04:21:43AM +0200, Kamil Rytarowski wrote: >>> I volunteer to review NetBSD patches. >>> Adding myself will help to not miss some of them. >>> >>> Restore NetBSD as a maintained ho

Re: [Qemu-devel] [PATCH] virtio-net: keep the packet layout intact

2017-05-15 Thread Michael S. Tsirkin
On Mon, May 15, 2017 at 05:29:15PM +0800, Wei Wang wrote: > Ping for comments, thanks. > > On 05/11/2017 12:57 PM, Wei Wang wrote: > > The current implementation may change the packet layout when > > vnet_hdr needs an endianness swap. The layout change causes > > one more iov to be added to the io

Re: [Qemu-devel] [PULL 0/5] Migration pull request

2017-05-15 Thread Eric Blake
On 05/15/2017 08:58 AM, Stefan Hajnoczi wrote: >> >> Juan Quintela (5): >> migration: Fix regression with compression threads >> migration: Pass Error ** argument to {save,load}_vmstate >> ram: Rename RAM_SAVE_FLAG_

[Qemu-devel] [PATCH v2 00/16] Augment support for signal handling

2017-05-15 Thread Miloš Stojanović
Change from v1 to v2: tswapal_target_sigset() is no longer static since it was breaking the build. This patch set deals with QEMU Linux user mode functionalities related to signal handling. It is composed of four sections: A. Extend strace support (patches 1-2, 8-9): Strace support is added f

Re: [Qemu-devel] [PATCH v2] block migration: Allow compile time disable

2017-05-15 Thread Eric Blake
On 05/15/2017 09:05 AM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Many users now prefer to use drive_mirror over NBD as an > alternative to the older migrate -b option; drive_mirror is > more complex to setup but gives you more options (e.g. only > migrating some of

[Qemu-devel] [PATCH v2 02/16] linux-user: add tkill(), tgkill() and rt_sigqueueinfo() strace

2017-05-15 Thread Miloš Stojanović
Improve strace support for syscall tkill(), tgkill() and rt_sigqueueinfo() by implementing print functions that match arguments types of the system calls and add them to the corresponding starce.list entry. tkill: Prior to this commit, typical strace output used to look like this: 4886 tkill(4886,

[Qemu-devel] [PATCH v2 04/16] linux-user: fix mismatch of lock/unlock_user() invocations in rt_sigqueinfo() syscall

2017-05-15 Thread Miloš Stojanović
Change the unlock_user() argument from arg1 to arg3 to match with lock_user(), since arg3 contains the pointer to the siginfo_t structure. Signed-off-by: Miloš Stojanović --- linux-user/syscall.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/syscall.c b/linux-use

Re: [Qemu-devel] [PATCH] qemu-img: Fix leakage of options on error

2017-05-15 Thread Eric Blake
On 05/15/2017 09:10 AM, Fam Zheng wrote: > Reported by Coverity. > > Signed-off-by: Fam Zheng > --- > qemu-img.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | lib

[Qemu-devel] [PATCH v2 03/16] linux-user: fix ssetmask() system call

2017-05-15 Thread Miloš Stojanović
Fix the ssetmask() system call by removing the invocation of sigorset(). The ssetmask() system call should replace the old signal mask with the new and return the old mask. It shouldn't combine the old and the new mask with sigorset(). Fetching the old mask for sigorset() is also no longer needed.

[Qemu-devel] [PATCH v2 07/16] linux-user: add rt_tgsigqueueinfo() strace

2017-05-15 Thread Miloš Stojanović
This commit improves strace support for syscall rt_tgsigqueueinfo(). Prior to this commit, typical strace output used to look like this: 7775 rt_tgsigqueueinfo(7775,7775,50,1996483164,0,0) = 0 After this commit, it looks like this: 7775 rt_tgsigqueueinfo(7775,7775,50,0x76ffea5c) = 0 Signed-off-b

[Qemu-devel] [PATCH v2 05/16] linux-user: fix argument type declaration of rt_sigqueinfo() syscall

2017-05-15 Thread Miloš Stojanović
Change the type of the first argument of rt_sigqueinfo() from int to pid_t in the syscall declaration to match specifications of the system call. Proper spacing is added to satisfy checkpatch.pl. Signed-off-by: Miloš Stojanović --- linux-user/syscall.c | 2 +- 1 file changed, 1 insertion(+), 1

[Qemu-devel] [PATCH v2 01/16] linux-user: add strace for getuid(), gettid(), getppid(), geteuid()

2017-05-15 Thread Miloš Stojanović
Improve strace support for syscalls getuid(), gettid(), getppid() and geteuid(). Since these system calls don't have arguments, "%s()" is added in the corresponding strace.list entry so that no arguments are printed. getuid: Prior to this commit, typical strace output used to look like this: 4894

Re: [Qemu-devel] [PATCH] tcg/i386: 'nop' instruction with 'lock' prefix is illegal

2017-05-15 Thread Pranith Kumar
On Sun, May 14, 2017 at 5:12 PM, Richard Henderson wrote: >> > Surely you'd also want to make this change for 0x11a and 0x11b. Which would > also simplify that code a bit. > > That said, there's *lots* of missing LOCK prefix checks. What brings this > one in particular to your attention? > The

[Qemu-devel] [PATCH v2 10/16] [RFC] linux-user: add support for tracking the target signal mask

2017-05-15 Thread Miloš Stojanović
If TRACK_TARGET_SIGMASK is defined, add fields in the TaskState structure which will hold the target signal and suspend mask and add support for initialization and forking. No functional changes are being introduced in this commit. The TRACK_TARGET_SIGMASK will be defined in a later commit where th

[Qemu-devel] [PATCH v2 12/16] [RFC] linux-user: fix sigismember() check

2017-05-15 Thread Miloš Stojanović
Fix copying between the host and target signal sets for the case when the target set is larger than the host set. sigismember() returns 1 if the specified signal number is a member of the specified signal set, but it can also return -1 if an error occurs (e.g. an out of range signal number is spec

[Qemu-devel] [PATCH v2 09/16] linux-user: add strace support for uinfo structure of rt_sigqueueinfo() and rt_tgsigqueueinfo()

2017-05-15 Thread Miloš Stojanović
This commit adds support for printing the content of the target_siginfo_t structure in a similar way to how it is printed by the host strace. The pointer to this structure is sent as the last argument of the rt_sigqueueinfo() and rt_tgsigqueueinfo() system calls. For this purpose, print_siginfo() i

[Qemu-devel] [PATCH v2 06/16] linux-user: add support for rt_tgsigqueueinfo() system call

2017-05-15 Thread Miloš Stojanović
Add a new system call: rt_tgsigqueueinfo(). This system call is similar to rt_sigqueueinfo(), but instead of sending the signal and data to the whole thread group with the ID equal to the argument tgid, it sends it to a single thread within that thread group. The ID of the thread is specified by t

[Qemu-devel] [PATCH v2 08/16] linux-user: fix inconsistent spaces in print_siginfo() output

2017-05-15 Thread Miloš Stojanović
This patch improves the consistentcy of the output from print_siginfo() by removing spaces around the equal sign of si_pid, si_uid, si_timer1, si_timer2, si_band, si_fd, si_addr, si_status and si_sigval. This way they match si_signo and ci_code. Host strace was used as a reference for this chage.

[Qemu-devel] [PATCH v2 13/16] [RFC] linux-user: add functions for working with the target signal mask

2017-05-15 Thread Miloš Stojanović
Add functions tswapal_target_sigset(), target_to_abi_ulong_old_sigset() and abi_ulong_to_target_old_sigset(). The tswapal_target_sigset() function transforms target signal sets from target to host endianness. This is helpful for tracking and working with the target signal masks in the host endiann

[Qemu-devel] [PATCH v2 16/16] [RFC] linux-user: add support for multiplexing signals in rt_sigqueueinfo(), rt_tgsigqueueinfo(), kill() and tgkill() syscalls.

2017-05-15 Thread Miloš Stojanović
Add support for multiplexing in the host_signal_handler() function and in system calls rt_sigqueueinfo()/rt_tgsigqueueinfo(), tgkill(), kill() for the case when pid > 0. The rt_sigqueueinfo()/rt_tgsigqueueinfo() system calls multiplex target signals which are out of the host range by setting the s

[Qemu-devel] [PATCH v2 14/16] [RFC] linux-user: add functionality for tracking target signal mask

2017-05-15 Thread Miloš Stojanović
Add support for tracking the larger target signal mask in system calls sigprocmask()/rt_sigprocmask(), sigsuspend()/rt_sigsuspend(), sgetmask()/ssetmask() and in functions do_sigreturn(), do_rt_sigreturn(), handle_pending_signal(), process_pending_signals(). Add a new function do_target_sigprocmask

[Qemu-devel] [PATCH v2 11/16] [RFC] linux-user: add target_sigdelset() and target_sigorset()

2017-05-15 Thread Miloš Stojanović
Add two inline functions that work with the signal set of the target. target_sigdelset() removes a signal from target_sigset_t. target_sigorset() creates a union of two target_sigset_t. These functions will be used for introducing support for tracking the target signal set. Functions for emptying

[Qemu-devel] [PATCH v2 15/16] [RFC] linux-user: add support for multiplexing larger target signals

2017-05-15 Thread Miloš Stojanović
Add MUX_SIG as a multiplex signal number for all target signals which are out of the host range. Add support for multiplexing in do_sigaction(), process_pending_signals(), target_set_sigmask() and do_target_sigprocmask(). This patch solves the problem of unusable target signals which are out of th

Re: [Qemu-devel] [PATCH v2] block migration: Allow compile time disable

2017-05-15 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Many users now prefer to use drive_mirror over NBD as an > alternative to the older migrate -b option; drive_mirror is > more complex to setup but gives you more options (e.g. only > migrating some of the disks if some of

Re: [Qemu-devel] [PATCH 1/3] migration: Create block capabilities for shared and enable

2017-05-15 Thread Markus Armbruster
Eric Blake writes: > On 05/15/2017 04:46 AM, Dr. David Alan Gilbert wrote: >> * Juan Quintela (quint...@redhat.com) wrote: >>> Eric Blake wrote: On 05/11/2017 11:32 AM, Juan Quintela wrote: > Those two capabilities were added through the command line. Notice that > we just created

Re: [Qemu-devel] [PATCH 1/3] migration: Create block capabilities for shared and enable

2017-05-15 Thread Juan Quintela
Eric Blake wrote: > On 05/15/2017 04:46 AM, Dr. David Alan Gilbert wrote: >> * Juan Quintela (quint...@redhat.com) wrote: >>> Eric Blake wrote: On 05/11/2017 11:32 AM, Juan Quintela wrote: > Those two capabilities were added through the command line. Notice that > we just created th

Re: [Qemu-devel] [PATCH 2/3] migration: Remove use of old MigrationParams

2017-05-15 Thread Juan Quintela
Eric Blake wrote: > [adding Markus] > > On 05/15/2017 04:48 AM, Juan Quintela wrote: >> Eric Blake wrote: >>> On 05/12/2017 05:55 AM, Juan Quintela wrote: >> @@ -1239,6 +1240,7 @@ void qmp_migrate(const char *uri, bool has_blk, >> bool blk, >> } >> >> if (has_inc

Re: [Qemu-devel] [PATCH 2/3] migration: Remove use of old MigrationParams

2017-05-15 Thread Markus Armbruster
Juan Quintela writes: > Eric Blake wrote: >> On 05/12/2017 05:55 AM, Juan Quintela wrote: > @@ -1239,6 +1240,7 @@ void qmp_migrate(const char *uri, bool has_blk, > bool blk, > } > > if (has_inc && inc) { > +migrate_set_block_enabled(s, true); >

Re: [Qemu-devel] [PATCH 1/3] migration: Create block capabilities for shared and enable

2017-05-15 Thread Juan Quintela
Markus Armbruster wrote: > Eric Blake writes: > >> On 05/15/2017 04:46 AM, Dr. David Alan Gilbert wrote: >>> * Juan Quintela (quint...@redhat.com) wrote: Eric Blake wrote: > On 05/11/2017 11:32 AM, Juan Quintela wrote: >> Those two capabilities were added through the command line.

[Qemu-devel] [PATCH] 9pfs: local: forbid client access to metadata (CVE-2017-7493)

2017-05-15 Thread Greg Kurz
When using the mapped-file security mode, we shouldn't let the client mess with the metadata. The current code already tries to hide the metadata dir from the client by skipping it in local_readdir(). But the client can still access or modify it through several other operations. This can be used to

Re: [Qemu-devel] [PATCH 6/6] spapr: fix migration of ICP objects from/to older QEMU

2017-05-15 Thread Cédric Le Goater
On 05/15/2017 03:16 PM, Greg Kurz wrote: > On Mon, 15 May 2017 14:22:32 +0200 > Cédric Le Goater wrote: > >> On 05/15/2017 01:40 PM, Greg Kurz wrote: >>> Commit 5bc8d26de20c ("spapr: allocate the ICPState object from under >>> sPAPRCPUCore") moved ICP objects from the machine to CPU cores. This >

Re: [Qemu-devel] [PATCH 6/6] spapr: fix migration of ICP objects from/to older QEMU

2017-05-15 Thread Cédric Le Goater
>>> +int smt = kvmppc_smt_threads(); >>> +int nr_servers = DIV_ROUND_UP(max_cpus * smt, smp_threads); >> >> may be we should reintroduce nr_servers at the machine level ? >> > > I had reintroduced it but then I realized it was only used in this > function. nr_servers is also us

Re: [Qemu-devel] e1000e migration

2017-05-15 Thread Dmitry Fleytman
Hello Dave, It looks like we identified the problem. We are working on fix and will send it as soon as it is ready. ~Dmitry. Sent from my iPhone > On 15 May 2017, at 12:22, Dr. David Alan Gilbert wrote: > > * Dmitry Fleytman (dmi...@daynix.com) wrote: >> Hello Dave, > > Hi Dmitry, > Thanks

Re: [Qemu-devel] e1000e migration

2017-05-15 Thread Dr. David Alan Gilbert
* Dmitry Fleytman (dmi...@daynix.com) wrote: > Hello Dave, > > It looks like we identified the problem. > > We are working on fix and will send it as soon as it is ready. Thanks! Dave > ~Dmitry. > > Sent from my iPhone > > > On 15 May 2017, at 12:22, Dr. David Alan Gilbert > > wrote: > >

Re: [Qemu-devel] [RFC v1 6/9] virtio-crypto: rework virtio_crypto_handle_request

2017-05-15 Thread Halil Pasic
On 05/13/2017 03:16 AM, Gonglei (Arei) wrote: > >> From: Halil Pasic [mailto:pa...@linux.vnet.ibm.com] >> Sent: Friday, May 12, 2017 7:02 PM >> >> >> On 05/08/2017 01:38 PM, Gonglei wrote: >>> According to the new spec, we should use different >>> requst structure to store the data request based

Re: [Qemu-devel] [PATCH 6/6] spapr: fix migration of ICP objects from/to older QEMU

2017-05-15 Thread Greg Kurz
On Mon, 15 May 2017 18:09:04 +0200 Cédric Le Goater wrote: > On 05/15/2017 03:16 PM, Greg Kurz wrote: > > On Mon, 15 May 2017 14:22:32 +0200 > > Cédric Le Goater wrote: > > > >> On 05/15/2017 01:40 PM, Greg Kurz wrote: > >>> Commit 5bc8d26de20c ("spapr: allocate the ICPState object from und

Re: [Qemu-devel] [PATCH 6/6] spapr: fix migration of ICP objects from/to older QEMU

2017-05-15 Thread Greg Kurz
On Mon, 15 May 2017 18:11:27 +0200 Cédric Le Goater wrote: > >>> +int smt = kvmppc_smt_threads(); > >>> +int nr_servers = DIV_ROUND_UP(max_cpus * smt, smp_threads); > >> > >> may be we should reintroduce nr_servers at the machine level ? > >> > > > > I had reintroduced it

Re: [Qemu-devel] [PATCH 2/3] migration: Remove use of old MigrationParams

2017-05-15 Thread Juan Quintela
Markus Armbruster wrote: > Juan Quintela writes: > >> Eric Blake wrote: >>> Or is the proposal that we are also going to simplify the QMP 'migrate' >>> command to get rid of crufty parameters? >> >> I didn't read it that way, but I would not oppose O:-) >> >> Later, Juan. > > I'm not too famil

Re: [Qemu-devel] [PATCH 2/3] migration: Remove use of old MigrationParams

2017-05-15 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Markus Armbruster wrote: > > Juan Quintela writes: > > > >> Eric Blake wrote: > > > >>> Or is the proposal that we are also going to simplify the QMP 'migrate' > >>> command to get rid of crufty parameters? > >> > >> I didn't read it that way, but

[Qemu-devel] [PATCH] sockets: Plug memory leak in socket_address_flatten()

2017-05-15 Thread Markus Armbruster
socket_address_flatten() leaks a SocketAddress when its argument is null. Happens when opening a ChardevBackend of type 'udp' that is configured without a local address. Screwed up in commit bd269ebc due to last minute semantic conflict resolution. Spotted by Coverity. Signed-off-by: Markus Arm

Re: [Qemu-devel] Changes to Broadcom(BCM) files and Raspberry Pi files. Addition of PanelEmu

2017-05-15 Thread Alistair Francis
On Sat, May 13, 2017 at 5:42 PM, John Bradley via Qemu-devel wrote: > From 7f74f048f135d9c9c230a9e90f72451c841c6d35 Mon Sep 17 00:00:00 2001 > From: John Bradley > Date: Sat, 13 May 2017 23:07:47 +0100 > Subject: [PATCH] Changes to Broadcom(BCM) files and Raspberry Pi files. > Addition of PanelEm

[Qemu-devel] [PATCH v10 0/4] Improve convert and dd commands

2017-05-15 Thread Daniel P. Berrange
Update to v1: https://lists.gnu.org/archive/html/qemu-devel/2017-01/msg05699.html v2: https://lists.gnu.org/archive/html/qemu-devel/2017-02/msg00728.html v3: https://lists.gnu.org/archive/html/qemu-devel/2017-02/msg04391.html v4: https://lists.gnu.org/archive/html/qemu-devel/2017-04/msg021

[Qemu-devel] [PATCH v10 1/4] qemu-img: add support for --object with 'dd' command

2017-05-15 Thread Daniel P. Berrange
The qemu-img dd command added --image-opts support, but missed the corresponding --object support. This prevented passing secrets (eg auth passwords) needed by certain disk images. Reviewed-by: Fam Zheng Reviewed-by: Max Reitz Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- qemu

[Qemu-devel] [PATCH v10 3/4] qemu-img: introduce --target-image-opts for 'convert' command

2017-05-15 Thread Daniel P. Berrange
The '--image-opts' flag indicates whether the source filename includes options. The target filename has to remain in the plain filename format though, since it needs to be passed to bdrv_create(). When using --skip-create though, it would be possible to use image-opts syntax. This adds --target-im

[Qemu-devel] [PATCH v10 2/4] qemu-img: fix --image-opts usage with dd command

2017-05-15 Thread Daniel P. Berrange
The --image-opts flag can only be used to affect the parsing of the source image. The target image has to be specified in the traditional style regardless, since it needs to be passed to the bdrv_create() API which does not support the new style opts. Reviewed-by: Fam Zheng Reviewed-by: Max Reitz

[Qemu-devel] [PATCH v10 4/4] qemu-img: copy *key-secret opts when opening newly created files

2017-05-15 Thread Daniel P. Berrange
The qemu-img dd/convert commands will create an image file and then try to open it. Historically it has been possible to open new files without passing any options. With encrypted files though, the *key-secret options are mandatory, so we need to provide those options when opening the newly created

<    1   2   3   4   >