On 05/15/2017 07:13 AM, Dr. David Alan Gilbert wrote:
>>> +#ifndef CONFIG_LIVE_BLOCK_MIGRATION
>>> + if (params.blk || params.shared) {
>>> + error_setg(errp, "QEMU compiled without old-style block migration.
>>> "
>>> + "Use drive_mirror+NBD.");
>>
>> error_setg() should not be used with '.' (it should be a single phrase,
>> here you are trying to stuff in two sentences). error_append_hint() can
>> be used to supply the advice about using drive_mirror+NBD as the
>> alternative.
>>
>> Otherwise this looks reasonable to me.
>
> Done as:
> error_setg(errp, "QEMU compiled without old-style block migration");
> error_append_hint(errp, "Use drive_mirror+NBD.\n");
>
> (All the places I can see seem to have . and \n in append_hint)That's correct. The hint has to supply its own newline, because we have places where we construct the hint through several append calls in a row (only the last one adds the newline). Looks good to me! -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
