Re: [Qemu-devel] [PATCH v2 1/4] net/socket: Convert the non-blocking connection mechanism to QIOchannel

Hi Markus, Thanks for your reply. On 04/27/2017 11:46 PM, Markus Armbruster wrote: Mao Zhongyi writes: Currently, socket connection in net is realized by an old mechanism which is non-blocking. That old mechanism may cause net blocks on DNS lookups and QEmu has already replaced it with QIOc

Re: [Qemu-devel] [PATCH v2 1/4] net/socket: Convert the non-blocking connection mechanism to QIOchannel

Hi, Daniel On 04/28/2017 12:20 AM, Daniel P. Berrange wrote: On Wed, Apr 26, 2017 at 04:04:15PM +0800, Mao Zhongyi wrote: Currently, socket connection in net is realized by an old mechanism which is non-blocking. [...] NULL); return 0; You've not saved a copy of the QIOCh

Re: [Qemu-devel] [PATCH v2 2/4] net/socket: Improve -net socket error reporting

Hi, Markus On 04/28/2017 12:10 AM, Markus Armbruster wrote: Mao Zhongyi writes: When -net socket fails, it first reports a specific error, then a generic one, like this: $ qemu-system-x86_64 -net socket, qemu-system-x86_64: -net socket: exactly one of fd=, listen=, connect=, mcast=

Re: [Qemu-devel] [PATCH v2 3/4] net/socket: Convert error report message to Error

Hi, Markus,Daniel On 04/28/2017 04:02 PM, Markus Armbruster wrote: "Daniel P. Berrange" writes: On Thu, Apr 27, 2017 at 06:24:17PM +0200, Markus Armbruster wrote: No review, just an observation. Mao Zhongyi writes: Currently, net_socket_mcast_create(), net_socket_fd_init_dgram() and net_

Re: [Qemu-devel] [PATCH v2 0/4] Convert non-blocking connect and fix its error reporting

On 04/28/2017 12:25 AM, Markus Armbruster wrote: Mao Zhongyi writes: v2: * PATCH 02 reworking of patch 2 following Markus's suggestion that convert error_report() in the function called by net_socket_*_init() to Error. Also add many error handling information. * PATCH 03 net_socket_mca

[Qemu-devel] [PATCH] dump: Acquire BQL around vm_start() in dump thread

This fixes an assertion failure in the following backtrace: __GI___assert_fail memory_region_transaction_commit memory_region_add_eventfd virtio_pci_ioeventfd_assign virtio_bus_set_host_notifier virtio_blk_data_plane_start virtio_bus_start_ioeventfd virtio_vmstate_c

Re: [Qemu-devel] [PATCH] dump: Acquire BQL around vm_start() in dump thread

On Wed, 05/03 15:28, Fam Zheng wrote: > This fixes an assertion failure in the following backtrace: > > __GI___assert_fail > memory_region_transaction_commit > memory_region_add_eventfd > virtio_pci_ioeventfd_assign > virtio_bus_set_host_notifier > virtio_blk_data_plane_sta

Re: [Qemu-devel] [PATCH] Deprecate '-enable-kvm' and '-enable-hax' in favour of '-accel'

Paolo Bonzini writes: > On 02/05/2017 18:19, Thomas Huth wrote: >>> I don't like writing it so often, especially to someone who is a >>> relatively experienced contributor, but the common word in all these >>> reviews is "pointless". What is the *purpose* of this work? >> >> Marking the -enable-

Re: [Qemu-devel] [PATCH] dump: Acquire BQL around vm_start() in dump thread

Hi On Wed, May 3, 2017 at 11:42 AM Fam Zheng wrote: > On Wed, 05/03 15:28, Fam Zheng wrote: > > This fixes an assertion failure in the following backtrace: > > > Do you know if it's a regression? Is this a racy case? (I couldn't reproduce) > > __GI___assert_fail > > memory_region_tran

Re: [Qemu-devel] [PATCH v2 3/4] net/socket: Convert error report message to Error

On Wed, May 03, 2017 at 03:09:57PM +0800, Mao Zhongyi wrote: > Hi, Markus,Daniel > > On 04/28/2017 04:02 PM, Markus Armbruster wrote: > > "Daniel P. Berrange" writes: > > > > > On Thu, Apr 27, 2017 at 06:24:17PM +0200, Markus Armbruster wrote: > > > > No review, just an observation. > > > > > >

Re: [Qemu-devel] [PATCH v3 8/8] tpm: Added support for TPM emulator

On Tue, May 02, 2017 at 03:35:48PM -0400, Stefan Berger wrote: > On 05/02/2017 02:50 PM, Marc-André Lureau wrote: > > Hi > > > > On Tue, May 2, 2017 at 10:25 PM Patrick Ohly > > wrote: > > > > On Tue, 2017-05-02 at 13:19 -0400, Stefan Berger wrote: > > > On

Re: [Qemu-devel] [PATCH v2 3/4] net/socket: Convert error report message to Error

On 05/03/2017 04:37 PM, Daniel P. Berrange wrote: On Wed, May 03, 2017 at 03:09:57PM +0800, Mao Zhongyi wrote: Hi, Markus,Daniel On 04/28/2017 04:02 PM, Markus Armbruster wrote: "Daniel P. Berrange" writes: On Thu, Apr 27, 2017 at 06:24:17PM +0200, Markus Armbruster wrote: No review, jus

Re: [Qemu-devel] [PATCH v2 3/4] net/socket: Convert error report message to Error

Mao Zhongyi writes: > Hi, Markus,Daniel > > On 04/28/2017 04:02 PM, Markus Armbruster wrote: >> "Daniel P. Berrange" writes: >> >>> On Thu, Apr 27, 2017 at 06:24:17PM +0200, Markus Armbruster wrote: No review, just an observation. Mao Zhongyi writes: > Currently, net_soc

Re: [Qemu-devel] [PATCH RFC] xen/mapcache: store dma information in revmapcache entries for debugging

On 03/05/2017 02:08, Stefano Stabellini wrote: > The Xen mapcache is able to create long term mappings, they are called > "locked" mappings. The third parameter of the xen_map_cache call > specifies if a mapping is a "locked" mapping. > > > From the QEMU point of view there are two kinds of lon

[Qemu-devel] [Bug 1687653] Re: QEMU-KVM / detect_zeroes causes KVM to start unlimited number of threads on Guest-Sided High-IO with big Blocksize

Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: ubuntu Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1687653 Title: QEMU-KVM /

Re: [Qemu-devel] [PATCH v5 10/10] test-qga: Actually test 0xff sync bytes

Michael Roth writes: > Quoting Michael Roth (2017-05-02 11:46:36) >> Quoting Eric Blake (2017-04-27 16:58:21) >> > Commit 62c39b3 introduced test-qga, and at face value, appears >> > to be testing the 'guest-sync' behavior that is recommended for >> > guests in sending 0xff to QGA to force the pa

Re: [Qemu-devel] [PATCH v2 3/4] net/socket: Convert error report message to Error

On 05/03/2017 04:54 PM, Markus Armbruster wrote: Mao Zhongyi writes: Hi, Markus,Daniel On 04/28/2017 04:02 PM, Markus Armbruster wrote: "Daniel P. Berrange" writes: On Thu, Apr 27, 2017 at 06:24:17PM +0200, Markus Armbruster wrote: No review, just an observation. Mao Zhongyi writes:

Re: [Qemu-devel] [PATCH] maintainers: add maintainer for replay* files

On 03/05/2017 07:07, Pavel Dovgalyuk wrote: > Indeed. I missed these ones. Please also add myself as reviewer (R:). get_maintainers.pl doesn't support reviewers yet, but I'll backport it from Linux today. Paolo > ⁣Отправлено с помощью BlueMail ​ > > На 2 Май 2017 г., 17:37, в 17:37, Stefan H

[Qemu-devel] [PATCH] tests: acpi: extend cphp and memhp testcase with numa distance check

Signed-off-by: He Chen --- tests/bios-tables-test.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c index 88dbf97..c593165 100644 --- a/tests/bios-tables-test.c +++ b/tests/bios-tables-test.c @@ -710,7 +710,

[Qemu-devel] [PATCH 2/5] get_maintainer: Teach get_maintainer.pl about the new "R:" tag

From: Joe Perches We can now designate reviewers in the MAINTAINERS file with the new "R:" tag, so this commit teaches get_maintainers.pl to add their email addresses. Cherry picked from Linux commit c1c3f2c906e35bcb6e4cdf5b8e077660fead14fe, with fixes to avoid \C as in QEMU commit ba10f729f1 ("

[Qemu-devel] [PATCH 5/5] get_maintainer: add subsystem to reviewer output

From: Joe Perches Reviewer output currently does not include the subsystem that matched. Add it. Miscellanea: o Add a get_subsystem_name routine to centralize this Cherry picked from Linux commit 2a7cb1dc82fc2a52e747b4c496c13f6575fb1790. Signed-off-by: Joe Perches Signed-off-by: Paolo Bonzi

[Qemu-devel] [PATCH 1/5] MAINTAINERS: Add "R:" tag for self-appointed reviewers

From: "Paul E. McKenney" Some people are not content with the amount of mail they get, and would like to be CCed on patches for areas they do not maintain. Let them satisfy their own appetite for qemu-devel messages. Seriously: the purpose here is a bit different from the Linux kernel. While Li

[Qemu-devel] [PATCH 4/5] get_maintainer: --r (list reviewer) is on by default

From: Brian Norris We don't consistenly document the default value next to the option listing, but we do have a list of defaults here, so let's keep it up to date. Cherry picked from Linux commit 4f07510df2e8c47fd65b8ffaaf6c5d334d59d598. Signed-off-by: Brian Norris Signed-off-by: Paolo Bonzini

[Qemu-devel] [PATCH 0/5] MAINTAINERS/get_maintainers: add support for reviewers

I would like to use "R" so that people can delegate maintenance of some code while keeping some degree of oversight. In my case, this can be appropriate for record/replay and cpus.c. Other people are free to use "R" as in Linux, where it is used to designate non-maintainers for reviewing patches

[Qemu-devel] [PATCH 3/5] get_maintainer: it's '--pattern-depth', not '-pattern-depth'

From: Brian Norris Though it appears that Perl's GetOptions will take either, the latter is not documented in the options listing. Cherry picked from Linux commit cc7ff0ef6eca3deeea4a424ca47a67c8450d5424. Signed-off-by: Brian Norris Signed-off-by: Paolo Bonzini --- scripts/get_maintainer.pl

Re: [Qemu-devel] [PATCH V3 04/10] net/filter-mirror.c: Add filter-mirror and filter-redirector vnet support.

On 2017年05月03日 11:18, Zhang Chen wrote: On 05/02/2017 12:47 PM, Jason Wang wrote: On 2017年04月28日 17:47, Zhang Chen wrote: In this patch, we change the send packet format from struct {int size; const uint8_t buf[];} to {int size; int vnet_hdr_len; const uint8_t buf[];}. make other module(

[Qemu-devel] [PATCH] MAINTAINERS: Update paths for AioContext implementation

Signed-off-by: Paolo Bonzini --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 46cf4870f9..62d62a6675 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1177,8 +1177,8 @@ M: Stefan Hajnoczi M: Fam Zheng L: qemu-bl...@nongnu.org

[Qemu-devel] [Bug 1687653] Re: QEMU-KVM / detect_zeroes causes KVM to start unlimited number of threads on Guest-Sided High-IO with big Blocksize

I'm unable to reproduce this issue. The host stays responsive and the dd command completes in a reasonable amount of time. QEMU does not exceed the 64-thread pool size. Please post steps to reproduce the issue using a minimal command-line without libvirt. Here is information on my attempt to re

Re: [Qemu-devel] crash in vhost-user-bridge on migration

Hi On Tue, May 2, 2017 at 11:17 PM Dr. David Alan Gilbert wrote: > Hi, > I've started playing with vhost-user-bridge and have it > basically up and going, but I've just tried migration and > I've got a reliable crash for it; I'm not that sure I've > got it set up right, so suggestions please:

Re: [Qemu-devel] [PATCH V3 05/10] net/net.c: Add vnet header length to SocketReadState

On 2017年05月03日 11:43, Zhang Chen wrote: On 05/02/2017 12:53 PM, Jason Wang wrote: On 2017年04月28日 17:47, Zhang Chen wrote: Address Jason Wang's comments add vnet header length to SocketReadState. Instead of saying this, you can add "Suggested-by: Jason Wang " above your sign-off. OK.

[Qemu-devel] [PATCH] block migration: Allow compile time disable

From: "Dr. David Alan Gilbert" Many users now prefer to use drive_mirror over NBD as an alternative to the older migrate -b option; drive_mirror is more complex to setup but gives you more options (e.g. only migrating some of the disks if some of them are shared). Allow the large chunk of block

[Qemu-devel] [PATCH] jazz_led: fix bad snprintf

Detected by GCC 7's -Wformat-truncation. snprintf writes at most 2 bytes here including the terminating NUL, so the result is truncated. In addition, the newline at the end is pointless. Fix the buffer size and the format string. --- hw/display/jazz_led.c | 4 ++-- 1 file changed, 2 insertions(+

Re: [Qemu-devel] [Qemu-trivial] [PATCH] MAINTAINERS: Update paths for AioContext implementation

On 03/05/2017 12:30, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > MAINTAINERS | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 46cf4870f9..62d62a6675 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1177,8 +1177,8 @

Re: [Qemu-devel] [PATCH 2/5] get_maintainer: Teach get_maintainer.pl about the new "R:" tag

On 03.05.2017 11:43, Paolo Bonzini wrote: > From: Joe Perches > > We can now designate reviewers in the MAINTAINERS file with the new > "R:" tag, so this commit teaches get_maintainers.pl to add their > email addresses. > > Cherry picked from Linux commit c1c3f2c906e35bcb6e4cdf5b8e077660fead14fe

Re: [Qemu-devel] [Qemu-trivial] [PATCH] jazz_led: fix bad snprintf

On 03/05/2017 12:44, Paolo Bonzini wrote: > Detected by GCC 7's -Wformat-truncation. snprintf writes at most > 2 bytes here including the terminating NUL, so the result is > truncated. In addition, the newline at the end is pointless. > Fix the buffer size and the format string. > --- > hw/displ

[Qemu-devel] [PATCH 1/7] KVM: MMU: correct the behavior of mmu_spte_update_no_track

From: Xiao Guangrong Current behavior of mmu_spte_update_no_track() does not match the name of _no_track() as actually the A/D bits are tracked and returned to the caller This patch introduces the real _no_track() function to update the spte regardless of A/D bits and rename the original functio

[Qemu-devel] [PATCH 4/7] KVM: MMU: enable KVM_WRITE_PROTECT_ALL_MEM

From: Xiao Guangrong The functionality of write protection for all guest memory is ready, it is the time to make its usable for userspace which is indicated by KVM_CAP_X86_WRITE_PROTECT_ALL_MEM Signed-off-by: Xiao Guangrong --- arch/x86/kvm/x86.c | 6 ++ include/uapi/linux/kvm.h | 2

[Qemu-devel] [PATCH 0/7] KVM: MMU: fast write protect

From: Xiao Guangrong Background == The original idea of this patchset is from Avi who raised it in the mailing list during my vMMU development some years ago This patchset introduces a extremely fast way to write protect all the guest memory. Comparing with the ordinary algorithm which w

[Qemu-devel] [PATCH 3/7] KVM: MMU: introduce kvm_mmu_write_protect_all_pages

From: Xiao Guangrong The original idea is from Avi. kvm_mmu_write_protect_all_pages() is extremely fast to write protect all the guest memory. Comparing with the ordinary algorithm which write protects last level sptes based on the rmap one by one, it just simply updates the generation number to

[Qemu-devel] [Bug 1687653] Re: QEMU-KVM / detect_zeroes causes KVM to start unlimited number of threads on Guest-Sided High-IO with big Blocksize

Please be so kind and go for a 6G LVM-Vol and do "dd if=/dev/zero of=/dev/sdb bs=3G count=2 oflag=direct". Please keep an eye on your processor usage in comparison to the threads created. Its harder to knock-down an SSD-Backed system than one with spinners. -- You received this bug notification b

[Qemu-devel] [PATCH 6/7] KVM: MMU: clarify fast_pf_fix_direct_spte

From: Xiao Guangrong The writable spte can not be locklessly fixed and add a WARN_ON() to trigger the warning if something out of our mind happens, that is good for us to track if the log for writable spte is missed on the fast path Signed-off-by: Xiao Guangrong --- arch/x86/kvm/mmu.c | 11 +++

[Qemu-devel] [PATCH 2/7] KVM: MMU: introduce possible_writable_spte_bitmap

From: Xiao Guangrong It is used to track possible writable sptes on the shadow page on which the bit is set to 1 for the sptes that are already writable or can be locklessly updated to writable on the fast_page_fault path, also a counter for the number of possible writable sptes is introduced to

[Qemu-devel] [PATCH 7/7] KVM: MMU: stop using mmu_spte_get_lockless under mmu-lock

From: Xiao Guangrong mmu_spte_age() is under the protection of mmu-lock, no reason to use mmu_spte_get_lockless() Signed-off-by: Xiao Guangrong --- arch/x86/kvm/mmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c index f6a74e7..a8b9

[Qemu-devel] [PATCH 5/7] KVM: MMU: allow dirty log without write protect

From: Xiao Guangrong A new flag, KVM_DIRTY_LOG_WITHOUT_WRITE_PROTECT, is introduced which indicates the userspace just wants to get the snapshot of dirty bitmap During live migration, after all snapshot of dirty bitmap is fetched from KVM, the guest memory can be write protected by calling KVM_W

Re: [Qemu-devel] [PATCH v6 10/13] s390x/css: introduce and realize ccw-request callback

On Wed, 3 May 2017 10:18:50 +0800 Dong Jia Shi wrote: > * Cornelia Huck [2017-05-02 18:04:07 +0200]: > > > On Tue, 2 May 2017 10:15:19 +0800 > > Dong Jia Shi wrote: > > > > > * Auger Eric [2017-05-01 19:28:23 +0200]: > > > > > > > static void vfio_ccw_io_notifier_handler(void *opaque) > >

Re: [Qemu-devel] [PATCH v3 8/8] tpm: Added support for TPM emulator

* Daniel P. Berrange (berra...@redhat.com) wrote: > On Tue, May 02, 2017 at 03:35:48PM -0400, Stefan Berger wrote: > > On 05/02/2017 02:50 PM, Marc-André Lureau wrote: > > > Hi > > > > > > On Tue, May 2, 2017 at 10:25 PM Patrick Ohly > > > wrote: > > > > > > On

Re: [Qemu-devel] [PATCH v3 8/8] tpm: Added support for TPM emulator

Hi On Wed, May 3, 2017 at 3:17 PM Dr. David Alan Gilbert wrote: > * Daniel P. Berrange (berra...@redhat.com) wrote: > > On Tue, May 02, 2017 at 03:35:48PM -0400, Stefan Berger wrote: > > > On 05/02/2017 02:50 PM, Marc-André Lureau wrote: > > > > Hi > > > > > > > > On Tue, May 2, 2017 at 10:25 PM

Re: [Qemu-devel] [PATCH 1/1] monitor: increase amount of data for monitor to read

"Denis V. Lunev" writes: > On 05/02/2017 07:48 PM, Daniel P. Berrange wrote: >> On Tue, May 02, 2017 at 05:36:30PM +0100, Dr. David Alan Gilbert wrote: >>> * Markus Armbruster (arm...@redhat.com) wrote: "Denis V. Lunev" writes: > On 05/02/2017 05:43 PM, Markus Armbruster wrote: >>>

Re: [Qemu-devel] [PATCH v3 8/8] tpm: Added support for TPM emulator

On Wed, May 03, 2017 at 11:24:42AM +, Marc-André Lureau wrote: > Hi > > On Wed, May 3, 2017 at 3:17 PM Dr. David Alan Gilbert > wrote: > > > * Daniel P. Berrange (berra...@redhat.com) wrote: > > > On Tue, May 02, 2017 at 03:35:48PM -0400, Stefan Berger wrote: > > > > On 05/02/2017 02:50 PM,

Re: [Qemu-devel] [PATCH v2 for-2.10 1/8] chardev: Basic support for TN3270

On Fri, 28 Apr 2017 14:17:12 + Marc-André Lureau wrote: > Hi > > On Fri, Apr 7, 2017 at 3:19 PM Cornelia Huck > wrote: > > > From: Jing Liu > > > > This introduces basic support for TN3270, which needs to negotiate > > three Telnet options during handshake: > > - End of Record > > - B

[Qemu-devel] [PATCH v2] maintainers: add maintainer for replay* files

Updating MAINTAINERS to set Pavel Dovgalyuk as record/replay maintainer and Paolo Bonzini as a reviewer. Signed-off-by: Pavel Dovgalyuk --- MAINTAINERS | 12 1 file changed, 12 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index a1d2b3a4d3..4e8bbb07aa 100644 --- a/MAINTAIN

Re: [Qemu-devel] [PATCH 1/1] monitor: increase amount of data for monitor to read

On Wed, May 03, 2017 at 01:29:57PM +0200, Markus Armbruster wrote: > "Denis V. Lunev" writes: > > > On 05/02/2017 07:48 PM, Daniel P. Berrange wrote: > >> On Tue, May 02, 2017 at 05:36:30PM +0100, Dr. David Alan Gilbert wrote: > >>> * Markus Armbruster (arm...@redhat.com) wrote: > "Denis V.

Re: [Qemu-devel] [PATCH v3 8/8] tpm: Added support for TPM emulator

Hi On Wed, May 3, 2017 at 3:29 PM Daniel P. Berrange wrote: > On Wed, May 03, 2017 at 11:24:42AM +, Marc-André Lureau wrote: > > Hi > > > > On Wed, May 3, 2017 at 3:17 PM Dr. David Alan Gilbert < > dgilb...@redhat.com> > > wrote: > > > > > * Daniel P. Berrange (berra...@redhat.com) wrote: >

Re: [Qemu-devel] [PATCH] jazz_led: fix bad snprintf

Paolo Bonzini writes: > Detected by GCC 7's -Wformat-truncation. snprintf writes at most > 2 bytes here including the terminating NUL, so the result is > truncated. In addition, the newline at the end is pointless. > Fix the buffer size and the format string. > --- > hw/display/jazz_led.c | 4

Re: [Qemu-devel] [PATCH v2 3/4] net/socket: Convert error report message to Error

On 2017年05月03日 16:59, Mao Zhongyi wrote: On 05/03/2017 04:54 PM, Markus Armbruster wrote: Mao Zhongyi writes: Hi, Markus,Daniel On 04/28/2017 04:02 PM, Markus Armbruster wrote: "Daniel P. Berrange" writes: On Thu, Apr 27, 2017 at 06:24:17PM +0200, Markus Armbruster wrote: No review,

Re: [Qemu-devel] vhost-net - virtio - multiqueue - rx queue selection

On 2017年05月02日 21:07, Stefan Hajnoczi wrote: On Thu, Apr 20, 2017 at 10:07:33AM +0530, Sujith Sankar wrote: I have a question regarding the algorithm used to select rx queue of the VM in the case of multiqueue virtio-net on KVM. Given a 4-tuple, how can we calculate the index of the receive q

Re: [Qemu-devel] [PATCH 2/5] get_maintainer: Teach get_maintainer.pl about the new "R:" tag

On 03/05/2017 12:45, Thomas Huth wrote: > On 03.05.2017 11:43, Paolo Bonzini wrote: >> From: Joe Perches >> >> We can now designate reviewers in the MAINTAINERS file with the new >> "R:" tag, so this commit teaches get_maintainers.pl to add their >> email addresses. >> >> Cherry picked from Linu

Re: [Qemu-devel] [PATCH] jazz_led: fix bad snprintf

On 03/05/2017 13:38, Markus Armbruster wrote: > Paolo Bonzini writes: > >> Detected by GCC 7's -Wformat-truncation. snprintf writes at most >> 2 bytes here including the terminating NUL, so the result is >> truncated. In addition, the newline at the end is pointless. >> Fix the buffer size an

Re: [Qemu-devel] [PATCH 1/1] monitor: increase amount of data for monitor to read

Hi On Wed, May 3, 2017 at 3:36 PM Daniel P. Berrange wrote: > On Wed, May 03, 2017 at 01:29:57PM +0200, Markus Armbruster wrote: > > > The only difference to before that I can see is that we can read ahead. > > That's a feature. > > > > Looks safe to me. Opinions? > > Yes, I concur, it looks sa

[Qemu-devel] [PATCH] MAINTAINERS: Update paths for main loop

Moved by c2b38b2 ("block: move AioContext, QEMUTimer, main-loop to libqemuutil"), let's update MAINTAINERS too. Reported-by: Laurent Vivier Signed-off-by: Paolo Bonzini --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 62d62a

Re: [Qemu-devel] [PATCH v2 for-2.10 1/8] chardev: Basic support for TN3270

On Wed, May 3, 2017 at 3:32 PM Cornelia Huck wrote: > On Fri, 28 Apr 2017 14:17:12 + > Marc-André Lureau wrote: > > > Hi > > > > On Fri, Apr 7, 2017 at 3:19 PM Cornelia Huck > > wrote: > > > > > From: Jing Liu > > > > > > This introduces basic support for TN3270, which needs to negotiate >

[Qemu-devel] [Bug 1581936] Re: Frozen Windows 7 VMs with VGA CVE-2016-3712 fix (2.6.0 and 2.5.1.1)

** Also affects: qemu (Ubuntu) Importance: Undecided Status: New ** Tags added: regression-update -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1581936 Title: Frozen Windows 7 VMs with V

[Qemu-devel] [PATCH 1/2] libvhost-user: fix vu_queue_get_avail_bytes() crash

Calling vu_queue_get_avail_bytes() when the queue doesn't yet have addresses will result in the following crash: Program received signal SIGSEGV, Segmentation fault. 0x55c414112ce4 in vring_avail_idx (vq=0x55c41582fd68, vq=0x55c41582fd68) at /home/dgilbert/git/qemu/contrib/libvhost-user/li

Re: [Qemu-devel] [Qemu-trivial] [PATCH] jazz_led: fix bad snprintf

On 03/05/2017 13:54, Paolo Bonzini wrote: > > > On 03/05/2017 13:38, Markus Armbruster wrote: >> Paolo Bonzini writes: >> >>> Detected by GCC 7's -Wformat-truncation. snprintf writes at most >>> 2 bytes here including the terminating NUL, so the result is >>> truncated. In addition, the newlin

[Qemu-devel] [PATCH 2/2] libvhost-user: make vu_queue_empty() safer

Check if vring.avail != null before accessing it. Fix crashes from callers such a vu_queue_pop() when queue isn't ready. Fix documentation and return type while at it. Signed-off-by: Marc-André Lureau --- contrib/libvhost-user/libvhost-user.h | 6 +++--- contrib/libvhost-user/libvhost-user.c |

[Qemu-devel] [PATCH 19/25] qmp: add autoload parameter to block-dirty-bitmap-add

Optional. Default is false. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev Reviewed-by: Max Reitz Reviewed-by: John Snow --- blockdev.c | 18 -- qapi/block-core.json | 6 +- 2 files changed, 21 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH 17/25] qcow2: add .bdrv_can_store_new_dirty_bitmap

Realize .bdrv_can_store_new_dirty_bitmap interface. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow Reviewed-by: Max Reitz --- block/qcow2-bitmap.c | 51 +++ block/qcow2.c| 2 ++ block/qcow2.h| 4 3 files

[Qemu-devel] [PATCH 02/25] specs/qcow2: do not use wording 'bitmap header'

A bitmap directory entry is sometimes called a 'bitmap header'. This patch leaves only one name - 'bitmap directory entry'. The name 'bitmap header' creates misunderstandings with 'qcow2 header' and 'qcow2 bitmap header extension' (which is extension of qcow2 header) Signed-off-by: Vladimir Sement

[Qemu-devel] [PATCH 14/25] block/dirty-bitmap: add bdrv_dirty_bitmap_next()

Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Reviewed-by: John Snow --- block/dirty-bitmap.c | 7 +++ include/block/dirty-bitmap.h | 3 +++ 2 files changed, 10 insertions(+) diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c index bac4fe3008..df0d3cd954

[Qemu-devel] [PATCH 03/25] hbitmap: improve dirty iter

Make dirty iter resistant to resetting bits in corresponding HBitmap. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Reviewed-by: John Snow --- include/qemu/hbitmap.h | 26 -- util/hbitmap.c | 23 ++- 2 files changed, 26 i

[Qemu-devel] [PATCH 07/25] qcow2-refcount: rename inc_refcounts() and make it public

This is needed for the following patch, which will introduce refcounts checking for qcow2 bitmaps. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Reviewed-by: John Snow --- block/qcow2-refcount.c | 53 ++ block/qcow2.h

[Qemu-devel] [PATCH 21/25] iotests: test qcow2 persistent dirty bitmap

Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/165 | 105 + tests/qemu-iotests/165.out | 5 +++ tests/qemu-iotests/group | 1 + 3 files changed, 111 insertions(+) create mode 100755 tests/qemu-iotests/165 create mode 1006

[Qemu-devel] [PATCH 23/25] qcow2: add .bdrv_remove_persistent_dirty_bitmap

Realize .bdrv_remove_persistent_dirty_bitmap interface. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Reviewed-by: John Snow --- block/qcow2-bitmap.c | 41 + block/qcow2.c| 1 + block/qcow2.h| 3 +++ 3 files changed

[Qemu-devel] [PATCH 01/25] specs/qcow2: fix bitmap granularity qemu-specific note

Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow --- docs/specs/qcow2.txt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/docs/specs/qcow2.txt b/docs/specs/qcow2.txt index 80cdfd0e91..dda53dd2a3 100644 --- a/docs/specs/qcow2.txt +++ b/docs/specs/qcow2.txt

[Qemu-devel] [PATCH 05/25] block: fix bdrv_dirty_bitmap_granularity signature

Make getter signature const-correct. This allows other functions with const dirty bitmap parameter use bdrv_dirty_bitmap_granularity(). Reviewed-by: Eric Blake Reviewed-by: John Snow Reviewed-by: Kevin Wolf Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/dirty-bitmap.c | 2 +- i

[Qemu-devel] [PATCH 10/25] qcow2: autoloading dirty bitmaps

Auto loading bitmaps are bitmaps in Qcow2, with the AUTO flag set. They are loaded when the image is opened and become BdrvDirtyBitmaps for the corresponding drive. Extra data in bitmaps is not supported for now. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-bitmap.c | 387 +++

[Qemu-devel] [PATCH 20/25] qmp: add x-debug-block-dirty-bitmap-sha256

Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Reviewed-by: John Snow --- block/dirty-bitmap.c | 5 + blockdev.c | 29 + include/block/dirty-bitmap.h | 2 ++ include/qemu/hbitmap.h | 8 qapi/block-co

[Qemu-devel] [PATCH 15/25] qcow2: add persistent dirty bitmaps support

Store persistent dirty bitmaps in qcow2 image. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-bitmap.c | 475 +++ block/qcow2.c| 9 + block/qcow2.h| 1 + 3 files changed, 485 insertions(+) diff --git a/block/qcow2-

[Qemu-devel] [PATCH v18 00/25] qcow2: persistent dirty bitmaps

Hi all! There is a new update of qcow2-bitmap series - v18. web: https://src.openvz.org/users/vsementsov/repos/qemu/browse?at=qcow2-bitmap-v18 git: https://src.openvz.org/scm/~vsementsov/qemu.git (tag qcow2-bitmap-v18) v18: rebased on master (sorry for v17) 08: contextual: qcow2_do_open is ch

[Qemu-devel] [PATCH 22/25] block/dirty-bitmap: add bdrv_remove_persistent_dirty_bitmap

Interface for removing persistent bitmap from its storage. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Reviewed-by: John Snow --- block/dirty-bitmap.c | 18 ++ include/block/block_int.h| 3 +++ include/block/dirty-bitmap.h | 3 +++ 3 files c

[Qemu-devel] [PATCH 25/25] block: release persistent bitmaps on inactivate

We should release them here to reload on invalidate cache. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 4 block/dirty-bitmap.c | 29 +++-- include/block/dirty-bitmap.h | 1 + 3 files changed, 28 insertions(+), 6 deletions(

[Qemu-devel] [PATCH 06/25] block/dirty-bitmap: add deserialize_ones func

Add bdrv_dirty_bitmap_deserialize_ones() function, which is needed for qcow2 bitmap loading, to handle unallocated bitmap parts, marked as all-ones. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Kevin Wolf Reviewed-by: John Snow --- block/dirty-bitmap.c | 7 +++ include

[Qemu-devel] [PATCH 18/25] qmp: add persistent flag to block-dirty-bitmap-add

Add optional 'persistent' flag to qmp command block-dirty-bitmap-add. Default is false. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev Reviewed-by: Max Reitz Reviewed-by: John Snow --- blockdev.c | 18 +- qapi/block-core.json | 8 +++-

[Qemu-devel] [PATCH 12/25] block: bdrv_close: release bitmaps after drv->bdrv_close

Release bitmaps after 'if (bs->drv) { ... }' block. This will allow format driver to save persistent bitmaps, which will appear in following commits. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/block.c b/block.

[Qemu-devel] [PATCH 08/25] qcow2: add bitmaps extension

Add bitmap extension as specified in docs/specs/qcow2.txt. For now, just mirror extension header into Qcow2 state and check constraints. Also, calculate refcounts for qcow2 bitmaps, to not break qemu-img check. For now, disable image resize if it has bitmaps. It will be fixed later. Signed-off-by

[Qemu-devel] [PATCH 16/25] block: add bdrv_can_store_new_dirty_bitmap

This will be needed to check some restrictions before making bitmap persistent in qmp-block-dirty-bitmap-add (this functionality will be added by future patch) Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Reviewed-by: John Snow --- block.c | 22 +

[Qemu-devel] [PATCH 09/25] block/dirty-bitmap: add readonly field to BdrvDirtyBitmap

It will be needed in following commits for persistent bitmaps. If bitmap is loaded from read-only storage (and we can't mark it "in use" in this storage) corresponding BdrvDirtyBitmap should be read-only. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/dirty-bitmap.c | 16 +

Re: [Qemu-devel] [PATCH 0/7] KVM: MMU: fast write protect

So if I understand correctly this relies on userspace doing: 1) KVM_GET_DIRTY_LOG without write protect 2) KVM_WRITE_PROTECT_ALL_MEM Writes may happen between 1 and 2; they are not represented in the live dirty bitmap but it's okay because they are in the snapshot and wil

[Qemu-devel] [PATCH 11/25] block/dirty-bitmap: add autoload field to BdrvDirtyBitmap

Mirror AUTO flag from Qcow2 bitmap in BdrvDirtyBitmap. This will be needed in future, to save this flag back to Qcow2 for persistent bitmaps. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Reviewed-by: John Snow --- block/dirty-bitmap.c | 15 +++ block/q

Re: [Qemu-devel] [PATCH 2/2] libvhost-user: make vu_queue_empty() safer

On 05/03/2017 09:11 AM, Marc-André Lureau wrote: Check if vring.avail != null before accessing it. Fix crashes from callers such a vu_queue_pop() when queue isn't ready. Fix documentation and return type while at it. Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé --

[Qemu-devel] [PATCH 24/25] qmp: block-dirty-bitmap-remove: remove persistent

Remove persistent bitmap from the storage on block-dirty-bitmap-remove. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Reviewed-by: John Snow --- blockdev.c | 10 ++ qapi/block-core.json | 3 ++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --gi

[Qemu-devel] [Bug 1581936] Re: Frozen Windows 7 VMs with VGA CVE-2016-3712 fix (2.6.0 and 2.5.1.1)

The attachment "Proposed fix for trusty" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, an

Re: [Qemu-devel] [PATCH 1/2] libvhost-user: fix vu_queue_get_avail_bytes() crash

Hi - Original Message - > Hi Marc-André, > > On 05/03/2017 09:11 AM, Marc-André Lureau wrote: > > Calling vu_queue_get_avail_bytes() when the queue doesn't yet have > > addresses will result in the following crash: > > > > Program received signal SIGSEGV, Segmentation fault. > > 0x55c

[Qemu-devel] [PATCH 04/25] tests: add hbitmap iter test

Test that hbitmap iter is resistant to bitmap resetting. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev Reviewed-by: Max Reitz Reviewed-by: John Snow --- tests/test-hbitmap.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/tests/test-hbitmap

[Qemu-devel] [PATCH 13/25] block: introduce persistent dirty bitmaps

New field BdrvDirtyBitmap.persistent means, that bitmap should be saved by format driver in .bdrv_close and .bdrv_inactivate. No format driver supports it for now. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/dirty-bitmap.c | 26 ++ block/qcow2-bitmap.c

Re: [Qemu-devel] [PATCH 1/2] libvhost-user: fix vu_queue_get_avail_bytes() crash

Hi Marc-André, On 05/03/2017 09:11 AM, Marc-André Lureau wrote: Calling vu_queue_get_avail_bytes() when the queue doesn't yet have addresses will result in the following crash: Program received signal SIGSEGV, Segmentation fault. 0x55c414112ce4 in vring_avail_idx (vq=0x55c41582fd68, vq=0x55

Re: [Qemu-devel] [PATCH v2 00/21] chardev clean-ups & tests

On 27/02/2017 14:41, Marc-André Lureau wrote: > Hi, > > The following series contains various patches: > - replace "chardevs" list for a /chardevs container object > - add a few read-only socket properties mainly useful for testing > - some chardev related clean-ups > - add various chardev tests

Re: [Qemu-devel] [PATCH 0/5] MAINTAINERS/get_maintainers: add support for reviewers

On 03.05.2017 11:43, Paolo Bonzini wrote: > I would like to use "R" so that people can delegate maintenance of some > code while keeping some degree of oversight. In my case, this can be > appropriate for record/replay and cpus.c. > > Other people are free to use "R" as in Linux, where it is used

Re: [Qemu-devel] [PATCH] hw/virtio: fix vhost user fails to startup when MQ

Hi On Wed, May 3, 2017 at 7:09 AM Yang, Zhiyong wrote: > Hi，Maxime: > > > -Original Message- > > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > > Sent: Tuesday, May 2, 2017 8:23 PM > > To: Yang, Zhiyong ; qemu-devel@nongnu.org > > Cc: m...@redhat.com > > Subject: Re: [Qemu-d

Re: [Qemu-devel] [PATCH] mips: set CP0 Debug DExcCode for SDBBP instruction

On 05/02/2017 09:03 AM, Pavel Dovgalyuk wrote: From: Pavel Dovgalyuk This patch fixes setting DExcCode field of CP0 Debug register when SDBBP instruction is executed. According to EJTAG specification, this field must be set to the value 9 (Bp). Signed-off-by: Pavel Dovgalyuk Reviewed-by: Ph

  1   2   3   4   >