Hi On Wed, May 3, 2017 at 3:36 PM Daniel P. Berrange <berra...@redhat.com> wrote:
> On Wed, May 03, 2017 at 01:29:57PM +0200, Markus Armbruster wrote: > > > The only difference to before that I can see is that we can read ahead. > > That's a feature. > > > > Looks safe to me. Opinions? > > Yes, I concur, it looks safe for QMP. > > I might suggest putting an assert(!qmp) in monitor_suspend() to guarantee > no one accidentally introduces usage of the suspend feature in QMP in > future. > fwiw, in the qapi-async series, I added a bunch of related assert: https://github.com/elmarco/qemu/commit/48d0691fef7602b652b8e2a2a8c0c6665f8e7c14 -- Marc-André Lureau
