Re: [Qemu-devel] [PATCH 03/14] cg3: remove unused width and height variables

2017-04-21 Thread Mark Cave-Ayland
On 18/04/17 15:55, Richard Henderson wrote: > On 04/18/2017 07:38 AM, Mark Cave-Ayland wrote: >> On 15/04/17 11:54, Richard Henderson wrote: >> >>> On 04/05/2017 01:35 AM, Mark Cave-Ayland wrote: These aren't required since we can use the display width and height directly. Sign

Re: [Qemu-devel] Jailhouse on Ultrascale+ (ZCU102)

2017-04-21 Thread Constantin Petra
OK, Changed configs for inmate to UART0, and the messages appeared on the console (on the ZCU102 board, not QEMU), so it is indeed functional. root@plnx_aarch64:~# jailhouse/usr/local/sbin/jailhouse cell start ZynqMP-linux-demo Started cell "ZynqMP-linux-demo" Hello 1 from cell! Hello 2 from cell!

[Qemu-devel] [PATCH] MAINTAINERS: update my email address

2017-04-21 Thread Xie Changlong
From: Zhang Chen I'm leaving my job at Fujitsu, this email address will stop working this week. Update it to one that I will have access to later. Signed-off-by: Xie Changlong --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index c6

[Qemu-devel] [PATCH v7] Allow setting NUMA distance for different NUMA nodes

2017-04-21 Thread He Chen
This patch is going to add SLIT table support in QEMU, and provides additional option `dist` for command `-numa` to allow user set vNUMA distance by QEMU command. With this patch, when a user wants to create a guest that contains several vNUMA nodes and also wants to set distance among those nodes

[Qemu-devel] [PULL 00/11] s390x patches for 2.10

2017-04-21 Thread Cornelia Huck
The following changes since commit da92ada855036c55bd08b0b0c64c7551d56f3586: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20170420' into staging (2017-04-20 17:41:34 +0100) are available in the git repository at: git://github.com/cohuck/qemu tags/s390x-201

[Qemu-devel] [PULL 01/11] s390x: introduce 2.10 compat machine

2017-04-21 Thread Cornelia Huck
Signed-off-by: Cornelia Huck --- hw/s390x/s390-virtio-ccw.c | 17 - include/hw/compat.h| 3 +++ 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c index 40914fde6f..5ac315ac78 100644 --- a/hw/s390x/s390-v

[Qemu-devel] [PULL 03/11] s390x/pci: make printf always compile in debug output

2017-04-21 Thread Cornelia Huck
From: Danil Antonov Wrapped printf calls inside debug macros (DPRINTF) in `if` statement. This will ensure that printf function will always compile even if debug output is turned off and, in turn, will prevent bitrot of the format strings. Signed-off-by: Danil Antonov Message-Id: [CH: remove n

[Qemu-devel] [PULL 09/11] s390x/flic: cache flic in s390_get_flic

2017-04-21 Thread Cornelia Huck
From: Fei Li s390_get_flic() is called many times to obtain the flic. This wastes a lot of time as it calls object_resolve_path() every time. Let's cache S390FLICState by defining it as static. Signed-off-by: Fei Li Signed-off-by: Cornelia Huck --- hw/intc/s390_flic.c | 9 ++--- 1 file ch

[Qemu-devel] [PULL 02/11] s390x/kvm: make printf always compile in debug output

2017-04-21 Thread Cornelia Huck
From: Danil Antonov Wrapped printf calls inside debug macros (DPRINTF) in `if` statement. This will ensure that printf function will always compile even if debug output is turned off and, in turn, will prevent bitrot of the format strings. Signed-off-by: Danil Antonov Message-Id: Signed-off-by

[Qemu-devel] [PULL 07/11] s390x: use enum for adapter type and standardize its naming

2017-04-21 Thread Cornelia Huck
From: Fei Li Let's use an enum for io adapter type, and standardize its naming to CSS_IO_ADAPTER_* by changing S390_PCIPT_ADAPTER to CSS_IO_ADAPTER_PCI. Signed-off-by: Fei Li Reviewed-by: Cornelia Huck Signed-off-by: Cornelia Huck --- hw/s390x/css.c | 2 +- hw/s390x/s390-pci-bus.h

[Qemu-devel] [PULL 08/11] s390x: initialize flic before I/O subsystems

2017-04-21 Thread Cornelia Huck
From: Fei Li Let's have a flic before we move on to initialize more specific subsystems that make use of it. Signed-off-by: Fei Li Reviewed-by: Cornelia Huck Signed-off-by: Cornelia Huck --- hw/s390x/s390-virtio-ccw.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/s

[Qemu-devel] [PULL 04/11] s390x/css: introduce read-only property type for device ids

2017-04-21 Thread Cornelia Huck
From: Dong Jia Shi Let's introduce a read-only property type that handles device ids of the CssDevId type used for channel devices for future use. e.g. exposing the busid of an I/O subchannel that is assigned to a ccw device. Signed-off-by: Dong Jia Shi Signed-off-by: Cornelia Huck --- hw/s39

[Qemu-devel] [PULL 10/11] s390x: register I/O adapters per ISC during init

2017-04-21 Thread Cornelia Huck
From: Fei Li The I/O adapters should exist as soon as the bus/infrastructure exists, and not only when the guest is actually trying to do something with them. While the lazy allocation was not wrong, allocating at init time is cleaner, both for the architecture and the code. Let's adjust this by

[Qemu-devel] [PULL 05/11] s390x/css: provide introspection for virtual subchannel and device busid

2017-04-21 Thread Cornelia Huck
From: Dong Jia Shi Expose the busids of the virtual I/O subchannel and the virtual CCW device to ease debugging. This is needed because: 1. subchannel id are assigned dynamically, and cannot be set from outside. 2. device busid could possibly be auto generated. An example of using HMP to retr

[Qemu-devel] [PULL 06/11] s390x/css: consolidate the devno property for ccw devices

2017-04-21 Thread Cornelia Huck
From: Dong Jia Shi 'devno' should rather be a property of the ccw device, instead of a property of a specific virtio-ccw device. Let's consolidate it. While we are at here, also rename CcwDevice.bus_id to CcwDevice.devno to make things clearer. Signed-off-by: Dong Jia Shi Signed-off-by: Cornel

[Qemu-devel] [PULL 11/11] s390x: Drop useless casts

2017-04-21 Thread Cornelia Huck
From: Eric Blake An upcoming Coccinelle cleanup script wanted to reformat the casts present in this file - but on closer look, we don't need the casts at all because C automatically converts void* to any other pointer. Signed-off-by: Eric Blake Message-Id: <20170405194741.18956-4-ebl...@redhat.

[Qemu-devel] [PATCH] qemu_iotests: Remove _readlink()

2017-04-21 Thread Kevin Wolf
It is unused. Suggestetd-by: Fam Zheng Signed-off-by: Kevin Wolf --- tests/qemu-iotests/common.config | 18 -- 1 file changed, 18 deletions(-) diff --git a/tests/qemu-iotests/common.config b/tests/qemu-iotests/common.config index 1222e43..66f4e0b 100644 --- a/tests/qemu-iotests

Re: [Qemu-devel] CUSE-TPM : Win 10 reports TPM device doesn't have sufficient resources

2017-04-21 Thread Anshul Makkar
Yes, v2.8.0+tpm branch worked. Thanks Stefan. Anshul From: Stefan Berger [mailto:stef...@us.ibm.com] Sent: 18 April 2017 19:47 To: Anshul Makkar Cc: qemu-devel@nongnu.org Subject: Re: CUSE-TPM : Win 10 reports TPM device doesn't have sufficient resources You may want to try it from this versio

Re: [Qemu-devel] [PATCH 02/15] colo-compare: implement the process of checkpoint

2017-04-21 Thread Hailiang Zhang
On 2017/4/20 13:15, Jason Wang wrote: On 2017年04月18日 14:58, Hailiang Zhang wrote: On 2017/4/18 11:55, Jason Wang wrote: On 2017年04月17日 19:04, Hailiang Zhang wrote: Hi Jason, On 2017/4/14 14:38, Jason Wang wrote: On 2017年04月14日 14:22, Hailiang Zhang wrote: Hi Jason, On 2017/4/14 13:57, Jas

Re: [Qemu-devel] [PATCH v3 6/6] vmdk: Update metadata for multiple clusters

2017-04-21 Thread Fam Zheng
On Sat, 04/01 20:14, Ashijeet Acharya wrote: > Include a next pointer in VmdkMetaData struct to point to the previous > allocated L2 table. Modify vmdk_L2update to start updating metadata for > allocation of multiple clusters at once. > > Signed-off-by: Ashijeet Acharya This is the metadata part

Re: [Qemu-devel] [PATCH] qemu_iotests: Remove _readlink()

2017-04-21 Thread Fam Zheng
On Fri, 04/21 10:01, Kevin Wolf wrote: > It is unused. > > Suggestetd-by: Fam Zheng > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/common.config | 18 -- > 1 file changed, 18 deletions(-) > > diff --git a/tests/qemu-iotests/common.config > b/tests/qemu-iotests/common.c

Re: [Qemu-devel] [PATCH V2 1/2] COLO-compare: Optimize tcp compare for option field

2017-04-21 Thread Zhang Chen
On 04/21/2017 12:10 PM, Jason Wang wrote: On 2017年04月21日 11:48, Zhang Chen wrote: On 04/20/2017 02:43 PM, Jason Wang wrote: On 2017年04月18日 10:20, Zhang Chen wrote: In this patch we support packet that have tcp options field. Add tcp options field check, If the packet have options field

[Qemu-devel] [PATCH v2 05/13] tcx: ensure tcx_set_dirty() also invalidates the 24-bit plane and cplane

2017-04-21 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland Reviewed-by: Gerd Hoffmann --- hw/display/tcx.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/display/tcx.c b/hw/display/tcx.c index d24466f..6817bd2 100644 --- a/hw/display/tcx.c +++ b/hw/display/tcx.c @@ -96,6 +96,13 @@ typedef struct TCXState

[Qemu-devel] [PATCH v2 07/13] tcx: alter tcx24_reset_dirty() to accept address and length parameters

2017-04-21 Thread Mark Cave-Ayland
This can now be used by both the 8-bit and 24-bit display code, so rename to tcx_check_dirty(). Signed-off-by: Mark Cave-Ayland Reviewed-by: Gerd Hoffmann --- hw/display/tcx.c | 31 +++ 1 file changed, 11 insertions(+), 20 deletions(-) diff --git a/hw/display/tcx.

Re: [Qemu-devel] QEMU build breakage on ARM against Xen 4.9 caused by libxendevicemodel

2017-04-21 Thread Paul Durrant
> -Original Message- [snip] > > > > I think xencall should be part of the base xen_stable_libs anyway. > > Yes, you are right. However I noticed that -lxencall needs to come after > -lxendevicemodel. So, I'll have to move -lxendevicemodel before > $xen_stable_libs, see below. I'll merge th

[Qemu-devel] [PATCH v2 01/13] cg3: remove TARGET_PAGE_SIZE rounding on dirty page detection

2017-04-21 Thread Mark Cave-Ayland
This was an artifact from very early versions of the code from before the memory API and is no longer needed. Signed-off-by: Mark Cave-Ayland Reviewed-by: Gerd Hoffmann --- hw/display/cg3.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/display/cg3.c b/hw/displa

[Qemu-devel] [PATCH v2 08/13] tcx: remove page24 and cpage from tcx24_update_display()

2017-04-21 Thread Mark Cave-Ayland
Since all of the tcx_*_dirty() functions now calculate the 24-bit and cplane offsets themselves from the base address, these variables are no longer needed. Signed-off-by: Mark Cave-Ayland Reviewed-by: Gerd Hoffmann --- hw/display/tcx.c |7 ++- 1 file changed, 2 insertions(+), 5 deletio

[Qemu-devel] [PATCH v2 09/13] tcx: remove TARGET_PAGE_SIZE from tcx_update_display()

2017-04-21 Thread Mark Cave-Ayland
Now that page alignment is handled by the memory API, there is no need to duplicate the code 4 times (4 * 1024 == 4096 == TARGET_PAGE_SIZE). Signed-off-by: Mark Cave-Ayland Reviewed-by: Gerd Hoffmann --- hw/display/tcx.c | 36 1 file changed, 4 insertions(

[Qemu-devel] [PATCH v2 00/13] TCX/CG3 adapter cleanups

2017-04-21 Thread Mark Cave-Ayland
This started as part of the work on Gerd's thread-safe display patches but ended up turning into something a lot more comprehensive. It contains lots of cleanup and fixes for display invalidation (particularly on 24-bit TCX) exposed by testing the thread-safe patchset. Signed-off-by: Mark Cave-Ayl

[Qemu-devel] [PATCH v2 02/13] cg3: fix up size parameter for memory_region_get_dirty()

2017-04-21 Thread Mark Cave-Ayland
The code was incorrectly calculating the end address rather than the size of the required region. Signed-off-by: Mark Cave-Ayland Reviewed-by: Gerd Hoffmann --- hw/display/cg3.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/display/cg3.c b/hw/display/cg3.c index 7d43

[Qemu-devel] [PATCH v2 04/13] tcx: alter tcx_set_dirty() to accept address and length parameters

2017-04-21 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland Reviewed-by: Gerd Hoffmann --- hw/display/tcx.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/display/tcx.c b/hw/display/tcx.c index 8e26aae..d24466f 100644 --- a/hw/display/tcx.c +++ b/hw/display/tcx.c @@ -93,9 +93,9 @@ typ

Re: [Qemu-devel] [PATCH v14 01/20] block: Add, parse and store "force-shared-write" option

2017-04-21 Thread Kevin Wolf
Am 21.04.2017 um 05:55 hat Fam Zheng geschrieben: > Signed-off-by: Fam Zheng Reviewed-by: Kevin Wolf

[Qemu-devel] [PATCH v2 13/13] tcx: switch to load_image_mr() and remove prom_addr hack

2017-04-21 Thread Mark Cave-Ayland
Previous to the existence of load_image_mr(), the only way to load in the FCode ROM image was to pass in its physical address via qdev properties and use load_image_targphys(). Signed-off-by: Mark Cave-Ayland Reviewed-by: Gerd Hoffmann --- hw/display/tcx.c |4 +--- hw/sparc/sun4m.c |1 -

[Qemu-devel] [PATCH v2 03/13] cg3: switch to load_image_mr() and remove prom-addr hack

2017-04-21 Thread Mark Cave-Ayland
Previous to the existence of load_image_mr(), the only way to load in the FCode ROM image was to pass in its physical address via qdev properties and use load_image_targphys(). Signed-off-by: Mark Cave-Ayland Reviewed-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé --- hw/display/cg3.c |

[Qemu-devel] [PATCH v2 11/13] tcx: remove primitives for non-32-bit surfaces

2017-04-21 Thread Mark Cave-Ayland
As all surfaces in QEMU are now either shared or 32-bit ARGB regardless of the guest depth, remove all non-32-bit primitives from tcx_update_display() and consequence their implementation which are no longer required. Signed-off-by: Mark Cave-Ayland Reviewed-by: Gerd Hoffmann --- hw/display/tcx

[Qemu-devel] [PATCH v2 06/13] tcx: alter tcx24_check_dirty() to accept address and length parameters

2017-04-21 Thread Mark Cave-Ayland
This can now be used by both the 8-bit and 24-bit display code, so rename to tcx_check_dirty(). Signed-off-by: Mark Cave-Ayland Reviewed-by: Gerd Hoffmann --- hw/display/tcx.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/hw/display/tcx.c b/hw

Re: [Qemu-devel] [PATCH v14 02/20] qapi: Add 'force-shared-write' to blockdev-add arguments

2017-04-21 Thread Kevin Wolf
Am 21.04.2017 um 05:55 hat Fam Zheng geschrieben: > Signed-off-by: Fam Zheng Reviewed-by: Kevin Wolf As far as I am concerned, this could be squashed into patch 1, though. Adding a new field to the schema is an integral part of adding a new option, I think. Kevin

Re: [Qemu-devel] [PATCH v14 03/20] block: Respect "force-shared-write" in perm propagating

2017-04-21 Thread Kevin Wolf
Am 21.04.2017 um 05:55 hat Fam Zheng geschrieben: > Signed-off-by: Fam Zheng > --- > block.c | 31 +++ > 1 file changed, 23 insertions(+), 8 deletions(-) > > diff --git a/block.c b/block.c > index f5c4e97..6acf618 100644 > --- a/block.c > +++ b/block.c > @@ -1422,6 +1

Re: [Qemu-devel] [PATCH] sheepdog: Set error when connection fails

2017-04-21 Thread Daniel P. Berrange
On Fri, Apr 21, 2017 at 07:43:36AM +0200, Markus Armbruster wrote: > Kevin Wolf writes: > > > Am 20.04.2017 um 17:30 hat Daniel P. Berrange geschrieben: > >> On Thu, Apr 20, 2017 at 12:00:03PM +0800, Fam Zheng wrote: > >> > Signed-off-by: Fam Zheng > >> > --- > >> > block/sheepdog.c | 1 + > >>

[Qemu-devel] [PATCH v2 10/13] tcx: remove TARGET_PAGE_SIZE from tcx24_update_display()

2017-04-21 Thread Mark Cave-Ayland
Now that page alignment is handled by the memory API, there is no need to duplicate the code 4 times (4 * 1024 == 4096 == TARGET_PAGE_SIZE). Finally we have now removed all traces of TARGET_PAGE_SIZE. Signed-off-by: Mark Cave-Ayland Reviewed-by: Gerd Hoffmann --- hw/display/tcx.c | 46 ++

Re: [Qemu-devel] [PATCH v14 02/20] qapi: Add 'force-shared-write' to blockdev-add arguments

2017-04-21 Thread Fam Zheng
On Fri, 04/21 10:35, Kevin Wolf wrote: > Am 21.04.2017 um 05:55 hat Fam Zheng geschrieben: > > Signed-off-by: Fam Zheng > > Reviewed-by: Kevin Wolf > > As far as I am concerned, this could be squashed into patch 1, though. > Adding a new field to the schema is an integral part of adding a new >

[Qemu-devel] [PATCH v2 12/13] tcx: use tcx_set_dirty() for accelerated ops

2017-04-21 Thread Mark Cave-Ayland
Rather than calling memory_region_set_dirty() directly, make sure that we call tcx_set_dirty() instead. This ensures that the 24-bit plane and cplane are also invalidated correctly. Signed-off-by: Mark Cave-Ayland Reviewed-by: Gerd Hoffmann --- hw/display/tcx.c | 10 +- 1 file changed

Re: [Qemu-devel] [PATCH] sheepdog: Set error when connection fails

2017-04-21 Thread Fam Zheng
On Fri, 04/21 09:31, Daniel P. Berrange wrote: > On Fri, Apr 21, 2017 at 07:43:36AM +0200, Markus Armbruster wrote: > > Kevin Wolf writes: > > > > > Am 20.04.2017 um 17:30 hat Daniel P. Berrange geschrieben: > > >> On Thu, Apr 20, 2017 at 12:00:03PM +0800, Fam Zheng wrote: > > >> > Signed-off-by:

Re: [Qemu-devel] [PATCH] qemu-img: simplify img_convert

2017-04-21 Thread Peter Lieven
Am 20.04.2017 um 21:51 schrieb Kevin Wolf: > Am 20.04.2017 um 16:08 hat Peter Lieven geschrieben: >> Am 20.04.2017 um 16:05 schrieb Fam Zheng: >>> On Tue, 02/28 14:35, Peter Lieven wrote: img_convert has been around before there was an ImgConvertState or a block backend, but it has never

Re: [Qemu-devel] [PATCH] Drop QEMU_GNUC_PREREQ() checks for gcc older than 4.1

2017-04-21 Thread Peter Maydell
On 31 January 2017 at 16:14, Peter Maydell wrote: > We already require gcc 4.1 or newer (for the atomic > support), so the fallback codepaths for older gcc > versions than that are now dead code and we can > just delete them. > > NB: clang reports itself as gcc 4.2 (regardless of > clang version),

[Qemu-devel] [PATCH V2] qemu-img: simplify img_convert

2017-04-21 Thread Peter Lieven
img_convert has been around before there was an ImgConvertState or a block backend, but it has never been modified to directly use these structs. Change this by parsing parameters directly into the ImgConvertState and directly use BlockBackend where possible. Furthermore variable initialization has

[Qemu-devel] [PATCH 7/9] g364fb: make display updates thread safe

2017-04-21 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/display/g364fb.c | 28 +--- 1 file changed, 5 insertions(+), 23 deletions(-) diff --git a/hw/display/g364fb.c b/hw/display/g364fb.c index 8cdc205dd9..86557d14a9 100644 --- a/hw/display/g364fb.c +++ b/hw/display/g364fb.c @@ -64,17 +64,8

[Qemu-devel] [PATCH 2/9] memory: add support getting and using a dirty bitmap copy.

2017-04-21 Thread Gerd Hoffmann
This patch adds support for getting and using a local copy of the dirty bitmap. memory_region_snapshot_and_clear_dirty() will create a snapshot of the dirty bitmap for the specified range, clear the dirty bitmap and return the copy. The returned bitmap can be a bit larger than requested, the rang

[Qemu-devel] [PATCH 8/9] vmsvga: fix vmsvga_update_display

2017-04-21 Thread Gerd Hoffmann
Fix standard vga mode check: Both s->config and s->enabled must be set to enable vmware command fifo processing. Drop dirty tracking code from the fifo rendering code path, it isn't used anyway because vmsvga turns off dirty tracking when leaving standard vga mode. Signed-off-by: Gerd Hoffmann

[Qemu-devel] [PATCH 3/9] vga: add vga_scanline_invalidated helper

2017-04-21 Thread Gerd Hoffmann
Add vga_scanline_invalidated helper to check whenever a scanline was invalidated. Add a sanity check to fix OOB read access for display heights larger than 2048. Only cirrus uses this, for hardware cursor rendering, so having this work properly for the first 2048 scanlines only shouldn't be a pro

[Qemu-devel] [PATCH 4/9] vga: make display updates thread safe.

2017-04-21 Thread Gerd Hoffmann
The vga code clears the dirty bits *after* reading the framebuffer memory. So if the guest framebuffer updates hits the race window between vga reading the framebuffer and vga clearing the dirty bits vga will miss that update Fix it by using the new memory_region_copy_and_clear_dirty() memory_reg

[Qemu-devel] [PATCH 9/9] sm501: make display updates thread safe

2017-04-21 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/display/sm501.c | 23 ++- 1 file changed, 6 insertions(+), 17 deletions(-) diff --git a/hw/display/sm501.c b/hw/display/sm501.c index 040a0b93f2..1987a537c0 100644 --- a/hw/display/sm501.c +++ b/hw/display/sm501.c @@ -1259,6 +1259,7 @@ stat

[Qemu-devel] [PATCH 6/9] exynos: make display updates thread safe

2017-04-21 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/display/exynos4210_fimd.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/hw/display/exynos4210_fimd.c b/hw/display/exynos4210_fimd.c index e5be713406..fd0b2bec65 100644 --- a/hw/display/exynos4210_fimd.c +++ b/hw/display/exynos4

[Qemu-devel] [PATCH 5/9] framebuffer: make display updates thread safe

2017-04-21 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/display/framebuffer.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/hw/display/framebuffer.c b/hw/display/framebuffer.c index 25aa46c8c7..d7310d25f2 100644 --- a/hw/display/framebuffer.c +++ b/hw/display/framebuffer.c @@ -67,7

[Qemu-devel] [PATCH] virtio-gpu: add xres and yres properties

2017-04-21 Thread Gerd Hoffmann
So the default resolution is configurable. Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau --- include/hw/virtio/virtio-gpu.h | 2 ++ hw/display/virtio-gpu.c| 6 -- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/include/hw/virtio/virtio-gpu.h b/include/hw

[Qemu-devel] [PATCH 0/9] hw/display: make display updates thread safe, part 1

2017-04-21 Thread Gerd Hoffmann
Hi, Ok, 2.10 is open, lets start tackling the display update race conditions. This series adds the helper functions used to receive a dirty bitmap snapshot, which is used by the display adapters then. Also a bunch of display adapters are converted to use those helpers. Changes from previous ve

Re: [Qemu-devel] [PATCH 1/1] qemu-img: wait for convert coroutines to complete

2017-04-21 Thread Peter Lieven
Am 18.04.2017 um 12:27 schrieb Denis V. Lunev: > From: Anton Nefedov > > We should wait for other coroutines on error path, i.e. one of coroutines > terminates with i/o error, before cleaning the common structures. In the > other case we would crash in a lot of different places. This behaviour > w

[Qemu-devel] [PATCH 1/9] bitmap: add bitmap_copy_and_clear_atomic

2017-04-21 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/qemu/bitmap.h | 2 ++ util/bitmap.c | 11 +++ 2 files changed, 13 insertions(+) diff --git a/include/qemu/bitmap.h b/include/qemu/bitmap.h index 63ea2d0b1e..c318da12d7 100644 --- a/include/qemu/bitmap.h +++ b/include/qemu/bitmap.h @@ -220

Re: [Qemu-devel] [PATCH v2 1/2] migration: don't close a file descriptor while it can be in use

2017-04-21 Thread Juan Quintela
Laurent Vivier wrote: > If we close the QEMUFile descriptor in process_incoming_migration_co() > while it has been stopped by an error, the postcopy_ram_listen_thread() > can try to continue to use it. And as the memory has been freed > it is working with an invalid pointer and crashes. > > Fix th

Re: [Qemu-devel] [PATCH 49/59] ram: Remember last_page instead of last_offset

2017-04-21 Thread Juan Quintela
Philippe Mathieu-Daudé wrote: > Hi Juan, > > On 04/19/2017 05:59 PM, Juan Quintela wrote: >> Signed-off-by: Juan Quintela > > I think you missed Dave's Reviewed-by (he sent April 7) > > "Reviewed-by: Dr. David Alan Gilbert " thanks

[Qemu-devel] [PATCH] qxl: add xres and yres properties

2017-04-21 Thread Gerd Hoffmann
Add properties for the default display resolution, pass on that information to the guest so the driver can use it. Also move up qxl_crc32() function so we don't need a forward declaration. Additionally guest driver updates are needed so the guest driver will actually pick this up, which will prob

Re: [Qemu-devel] [PATCH v2 2/2] virtio-rng: stop virtqueue while the CPU is stopped

2017-04-21 Thread Juan Quintela
Laurent Vivier wrote: > If we modify the virtio-rng virqueue while the > vmstate is already migrated we can have some > inconsistencies between the virtqueue state and > the memory content. > > To avoid this, stop the virtqueue while the CPU > is stopped. > > Signed-off-by: Laurent Vivier > ---

Re: [Qemu-devel] [PATCH v2 1/4] migration: set current_active_state once

2017-04-21 Thread Juan Quintela
Peter Xu wrote: > We set it right above this one. No need to set it twice. > > CC: Juan Quintela > CC: Dr. David Alan Gilbert > Reviewed-by: Dr. David Alan Gilbert > Signed-off-by: Peter Xu Reviewed-by: Juan Quintela

Re: [Qemu-devel] [PATCH v2 2/4] migration: rename max_size to threshold_size

2017-04-21 Thread Juan Quintela
Peter Xu wrote: > In migration codes (especially in migration_thread()), max_size is used > in many place for the threshold value that we will start to do the final > flush and jump to the next stage to dump the whole rest things to > destination. However its name is confusing to first readers. Le

Re: [Qemu-devel] [PATCH v2 3/4] hmp: info migrate_capability format tunes

2017-04-21 Thread Juan Quintela
Peter Xu wrote: > Dump the info in a single line is hard to read. Do it one per line. > Also, the first "capabilities:" didn't help much. Let's remove it. > > CC: "Dr. David Alan Gilbert" > Reviewed-by: "Dr. David Alan Gilbert" > Signed-off-by: Peter Xu Reviewed-by: Juan Quintela

Re: [Qemu-devel] [PATCH v2 4/4] hmp: info migrate_parameters format tunes

2017-04-21 Thread Juan Quintela
Peter Xu wrote: > Do the same (one per line) to the parameter list. > > CC: "Dr. David Alan Gilbert" > Reviewed-by: "Dr. David Alan Gilbert" > Signed-off-by: Peter Xu Reviewed-by: Juan Quintela

Re: [Qemu-devel] [PATCH] tcg/i386: Do not display HT warning for TCG

2017-04-21 Thread Paolo Bonzini
On 20/04/2017 20:42, Eduardo Habkost wrote: >> -smp 4,threads=4 shows 4 cores > This means 1 socket with 1 core, 4 threads per core. But if > vendor ID is AMD, guests will probably ignore the hyperthreading > info and treat each thread as a separate core. That's why we have > a warning. I'm not

Re: [Qemu-devel] [PATCH v3 0/2] hw/i386: Update FADT to Revision 3 (ACPI 2.0)

2017-04-21 Thread Paolo Bonzini
On 15/03/2017 07:20, Phil Dennis-Jordan wrote: > This updates the FADT generated for x86/64 machine types from > Revision 1 to 3. (Based on ACPI standard 2.0 instead of 1.0) As > previously, the goal is to make running macOS/OS X guests smoother. > With a Rev1 FADT, rebooting such a guest doesn't

[Qemu-devel] [PULL for-2.9 2/6] throttle: do not use invalid config in test

2017-04-21 Thread Stefan Hajnoczi
The (burst) max parameter cannot be smaller than the avg parameter. There is a test case that uses avg = 56, max = 1 and gets away with it because no input validation is performed by the test case. This patch switches to valid test input parameters. Signed-off-by: Stefan Hajnoczi Reviewed-by: Al

[Qemu-devel] [PULL for-2.9 0/6] Block patches

2017-04-21 Thread Stefan Hajnoczi
The following changes since commit fa54abb8c298f892639ffc4bc2f61448ac3be4a1: Drop QEMU_GNUC_PREREQ() checks for gcc older than 4.1 (2017-04-20 18:33:33 +0100) are available in the git repository at: git://github.com/stefanha/qemu.git tags/block-pull-request for you to fetch changes up to 3

[Qemu-devel] [PULL for-2.9 1/6] qemu-options: explain disk I/O throttling options

2017-04-21 Thread Stefan Hajnoczi
The disk I/O throttling options have been listed for a long time but never explained on the QEMU man page. Suggested-by: Nini Gu Cc: Alberto Garcia Signed-off-by: Stefan Hajnoczi Reviewed-by: Alberto Garcia Reviewed-by: Greg Kurz Message-id: 20170301115026.22621-2-stefa...@redhat.com Signed-o

[Qemu-devel] [PULL for-2.9 3/6] throttle: make throttle_config(throttle_get_config()) symmetric

2017-04-21 Thread Stefan Hajnoczi
Throttling has a weird property that throttle_get_config() does not always return the same throttling settings that were given with throttle_config(). In other words, the set and get functions aren't symmetric. If .max is 0 then the throttling code assigns a default value of .avg / 10 in throttle

[Qemu-devel] [PULL for-2.9 4/6] migration/block: use blk_pwrite_zeroes for each zero cluster

2017-04-21 Thread Stefan Hajnoczi
From: Lidong Chen BLOCK_SIZE is (1 << 20), qcow2 cluster size is 65536 by default, this may cause the qcow2 file size to be bigger after migration. This patch checks each cluster, using blk_pwrite_zeroes for each zero cluster. [Initialize cluster_size to BLOCK_SIZE to prevent a gcc uninitialized

Re: [Qemu-devel] [PATCH v3 0/2] hw/i386: Update FADT to Revision 3 (ACPI 2.0)

2017-04-21 Thread Paolo Bonzini
On 15/03/2017 15:17, Michael S. Tsirkin wrote: > On Wed, Mar 15, 2017 at 07:20:25PM +1300, Phil Dennis-Jordan wrote: >> This updates the FADT generated for x86/64 machine types from Revision 1 to >> 3. (Based on ACPI standard 2.0 instead of 1.0) As previously, the goal is to >> make running mac

[Qemu-devel] [PULL for-2.9 5/6] MAINTAINERS: update Wen's email address

2017-04-21 Thread Stefan Hajnoczi
From: Changlong Xie So he can get CC'ed on future patches and bugs for this feature Signed-off-by: Changlong Xie Message-id: 1492484893-23435-1-git-send-email-xiecl.f...@cn.fujitsu.com Signed-off-by: Stefan Hajnoczi --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

[Qemu-devel] [PULL for-2.9 6/6] MAINTAINERS: update my email address

2017-04-21 Thread Stefan Hajnoczi
From: Zhang Chen I'm leaving my job at Fujitsu, this email address will stop working this week. Update it to one that I will have access to later. Signed-off-by: Xie Changlong Message-id: 1492758767-19716-1-git-send-email-xiecl.f...@cn.fujitsu.com Signed-off-by: Stefan Hajnoczi --- MAINTAINER

Re: [Qemu-devel] [PATCH v7] Allow setting NUMA distance for different NUMA nodes

2017-04-21 Thread Igor Mammedov
On Fri, 21 Apr 2017 15:32:15 +0800 He Chen wrote: > This patch is going to add SLIT table support in QEMU, and provides > additional option `dist` for command `-numa` to allow user set vNUMA > distance by QEMU command. > > With this patch, when a user wants to create a guest that contains > seve

[Qemu-devel] [PULL for-2.9 1/3] configure: eliminate Python dependency for --help

2017-04-21 Thread Stefan Hajnoczi
The ./configure script should produce --help output even if Python is not installed. Listing trace backends is simple: show the names of all Python modules in scripts/tracetool/backend/ whose source code contains 'PUBLIC = True'. Perform the backend enumeration in shell instead of Python so that

[Qemu-devel] [PULL for-2.9 3/3] simpletrace: document Analyzer method signatures

2017-04-21 Thread Stefan Hajnoczi
Users can inherit from the simpletrace.Analyzer class and receive callbacks when events of interest occur in a trace file. The method signature is a little magic because the timestamp and pid arguments are optional. Document this. Signed-off-by: Stefan Hajnoczi Reviewed-by: Alex Bennée Message

[Qemu-devel] [PULL for-2.9 0/3] Tracing patches

2017-04-21 Thread Stefan Hajnoczi
The following changes since commit fa54abb8c298f892639ffc4bc2f61448ac3be4a1: Drop QEMU_GNUC_PREREQ() checks for gcc older than 4.1 (2017-04-20 18:33:33 +0100) are available in the git repository at: git://github.com/stefanha/qemu.git tags/tracing-pull-request for you to fetch changes up to

[Qemu-devel] [PULL for-2.9 2/3] trace: Put all trace.o into libqemuutil.a

2017-04-21 Thread Stefan Hajnoczi
From: "Xu, Anthony" Currently all trace.o are linked into qemu-system, qemu-img, qemu-nbd, qemu-io etc., even the corresponding components are not included. Put all trace.o into libqemuutil.a that the linker would only pull in .o files containing symbols that are actually referenced by the progra

[Qemu-devel] [PATCH v2] qemu-img: use blk_co_pwrite_zeroes for zero sectors when compressed

2017-04-21 Thread jemmy858585
From: Lidong Chen when the buffer is zero, blk_co_pwrite_zeroes is more effectively than blk_co_pwritev with BDRV_REQ_WRITE_COMPRESSED. this patch can reduces the time when converts the qcow2 image with lots of zero. Signed-off-by: Lidong Chen --- v2 changelog: unify the compressed and non-

Re: [Qemu-devel] [PATCH 1/1] qemu-img: wait for convert coroutines to complete

2017-04-21 Thread Anton Nefedov
On 04/21/2017 12:18 PM, Peter Lieven wrote: Am 18.04.2017 um 12:27 schrieb Denis V. Lunev: From: Anton Nefedov We should wait for other coroutines on error path, i.e. one of coroutines terminates with i/o error, before cleaning the common structures. In the other case we would crash in a lot o

Re: [Qemu-devel] [PATCH 2/6] util: introduce glib-helper.c

2017-04-21 Thread Dr. David Alan Gilbert
* Philippe Mathieu-Daudé (f4...@amsat.org) wrote: > Hi Alexey, > > On 04/14/2017 10:17 AM, Alexey Perevalov wrote: > > There is a lack of g_int_cmp which compares pointers value in glib, > > xen_disk.c introduced its own, so the same function now requires > > in migration.c. So logically to move i

Re: [Qemu-devel] [PATCH v6] kvm: better MWAIT emulation for guests

2017-04-21 Thread Paolo Bonzini
On 12/04/2017 18:29, Michael S. Tsirkin wrote: > I don't really agree we do not need the PV flag. mwait on kvm is > different from mwait on bare metal in that you are heavily penalized by > scheduler for polling unless you configure the host just so. > HLT lets you give up the host CPU if you kno

Re: [Qemu-devel] [PATCH v6] kvm: better MWAIT emulation for guests

2017-04-21 Thread Alexander Graf
On 21.04.17 12:02, Paolo Bonzini wrote: On 12/04/2017 18:29, Michael S. Tsirkin wrote: I don't really agree we do not need the PV flag. mwait on kvm is different from mwait on bare metal in that you are heavily penalized by scheduler for polling unless you configure the host just so. HLT let

Re: [Qemu-devel] [PATCH 0/2] VFIO: Make 8-byte accesses atomic

2017-04-21 Thread Paolo Bonzini
On 20/04/2017 18:03, Alex Williamson wrote: > On Thu, 20 Apr 2017 00:19:23 -0700 > Richard Henderson wrote: > >> On 04/19/2017 12:44 PM, Jose Ricardo Ziviani wrote: >>> This patchset has two patches: >>> [1] 8-byte writes to non-mapped MMIO are broken into pairs of 4-byte >>> writes, this patc

Re: [Qemu-devel] [PATCH v3] char: Fix removing wrong GSource that be found by fd_in_tag

2017-04-21 Thread Paolo Bonzini
On 19/04/2017 03:15, zhanghailiang wrote: > We use fd_in_tag to find a GSource, fd_in_tag is return value of > g_source_attach(GSource *source, GMainContext *context), the return > value is unique only in the same context, so we may get the same > values with different 'context' parameters. > >

Re: [Qemu-devel] [PATCH] sheepdog: Set error when connection fails

2017-04-21 Thread Daniel P. Berrange
On Fri, Apr 21, 2017 at 04:50:34PM +0800, Fam Zheng wrote: > On Fri, 04/21 09:31, Daniel P. Berrange wrote: > > On Fri, Apr 21, 2017 at 07:43:36AM +0200, Markus Armbruster wrote: > > > Kevin Wolf writes: > > > > > > > Am 20.04.2017 um 17:30 hat Daniel P. Berrange geschrieben: > > > >> On Thu, Apr

Re: [Qemu-devel] [PATCH v6] kvm: better MWAIT emulation for guests

2017-04-21 Thread Paolo Bonzini
On 21/04/2017 12:05, Alexander Graf wrote: > > > On 21.04.17 12:02, Paolo Bonzini wrote: >> >> >> On 12/04/2017 18:29, Michael S. Tsirkin wrote: >>> I don't really agree we do not need the PV flag. mwait on kvm is >>> different from mwait on bare metal in that you are heavily penalized by >>> s

Re: [Qemu-devel] [PATCH v8 7/8] tests: Add unit tests for the VM Generation ID feature

2017-04-21 Thread Marc-André Lureau
Hi, Was this patch intentionally dropped from the series? On Mon, Feb 20, 2017 at 7:12 PM Igor Mammedov wrote: > On Thu, 16 Feb 2017 15:15:39 -0800 > b...@skyportsystems.com wrote: > > > From: Ben Warren > > > > The following tests are implemented: > > * test that a GUID passed in by command l

Re: [Qemu-devel] [PATCH v5 3/5] slirp: Common lhost/fhost union

2017-04-21 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > The socket structure has a pair of unions for lhost and fhost > addresses; the unions are identical so split them out into > a separate union declaration. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Juan Quint

Re: [Qemu-devel] [PATCH 3/6] migration: add UFFD_FEATURE_THREAD_ID feature support

2017-04-21 Thread Dr. David Alan Gilbert
* Alexey Perevalov (a.pereva...@samsung.com) wrote: > Userfaultfd mechanism is able to provide process thread id, > in case when client request it with UFDD_API ioctl. > > Signed-off-by: Alexey Perevalov There seem to be two parts to this: a) Adding the mis parameter to ufd_version_check b)

Re: [Qemu-devel] [PATCH v5 5/5] slirp: VMStatify remaining except for loop

2017-04-21 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > This converts the remaining components, except for the top level > loop, to VMState. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela I think that I had already reviewed previous version of this pat

Re: [Qemu-devel] [PATCH 2/6] util: introduce glib-helper.c

2017-04-21 Thread Peter Maydell
On 14 April 2017 at 14:17, Alexey Perevalov wrote: > There is a lack of g_int_cmp which compares pointers value in glib, > xen_disk.c introduced its own, so the same function now requires > in migration.c. So logically to move it into common place. > Futher: maybe extend glib. > > Also this commit

Re: [Qemu-devel] [PULL 00/15] Machine queue for 2.10

2017-04-21 Thread Peter Maydell
On 20 April 2017 at 19:46, Eduardo Habkost wrote: > This includes a few IOMMU fixes because Michael is away this > week. > > The following changes since commit da92ada855036c55bd08b0b0c64c7551d56f3586: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20170420' into stag

[Qemu-devel] [PATCH v6 10/13] sm501: Add support for panel layer

2017-04-21 Thread BALATON Zoltan
Signed-off-by: BALATON Zoltan Reviewed-by: Peter Maydell --- v2: Split off renaming a variable to separate clean up patch hw/display/sm501.c | 63 +++--- 1 file changed, 32 insertions(+), 31 deletions(-) diff --git a/hw/display/sm501.c b/hw/disp

[Qemu-devel] [PATCH v6 07/13] sm501: Fix device endianness

2017-04-21 Thread BALATON Zoltan
We only emulate the sysbus device in its default LE mode and PCI is LE as well so specify this for registers and framebuffer memory. Note that though the Linux kernel driver has code which claims to handle both big and little endian, it is obviously bogus for 16 bit and cannot be trusted as a sour

[Qemu-devel] [PATCH v6 13/13] ppc: Add SM501 device in ppc softmmu targets default configs

2017-04-21 Thread BALATON Zoltan
This is not used by default on any emulated machine yet but it is still useful to have it compiled so it can be added from the command line for clients that can use it (e.g. MorphOS has no driver for any other emulated video cards but can output via SM501) Signed-off-by: BALATON Zoltan Acked-by:

Re: [Qemu-devel] [PATCH 9/9] sm501: make display updates thread safe

2017-04-21 Thread BALATON Zoltan
On Fri, 21 Apr 2017, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann --- hw/display/sm501.c | 23 ++- 1 file changed, 6 insertions(+), 17 deletions(-) Hold on with this please too. I have a series pending that changes this. Regards, BALATON Zoltan

  1   2   3   4   >