[Qemu-devel] Dead code removal: removing code for unsupported DEPTH.

2017-03-16 Thread iwona260909
This time I looked for it in the mailing list archives, so I hope it wasn't done. It is removing code for DEPTH != 32, one of Bite Sized Tasks.

[Qemu-devel] [PATCH] Dead code removal: removing code for unsupported DEPTH.

2017-03-16 Thread iwona260909
From: Iwona Kotlarska Signed-off-by: Iwona Kotlarska --- hw/display/cirrus_vga.c | 3 --- hw/display/cirrus_vga_rop.h | 9 - hw/display/cirrus_vga_rop2.h | 46 ++-- 3 files changed, 2 insertions(+), 56 deletions(-) diff --git a/hw/display

[Qemu-devel] [PATCH] Dead code removal: removing code for unsupported DEPTH.

2017-03-16 Thread iwona260909
Removing code for unsupproted DEPTH. This time I looked for it in mailing list archive and haven't found, hope it wasn't done.

Re: [Qemu-devel] [PATCH] puv3: always compile-check debug printf

2017-03-16 Thread Alex Bennée
Anishka0107 writes: > To prevent bitrot of the format string of the debug statement, files with > conditional debug statements should ensure that printf is compiled always, > and enclosed within if(0) statements and not in #ifdef. > > Signed-off-by: Anishka Gupta > --- > include/hw/uni

Re: [Qemu-devel] [PULL 0/5] virtio, pci: fixes

2017-03-16 Thread Peter Maydell
On 16 March 2017 at 02:34, Michael S. Tsirkin wrote: > The following changes since commit 1883ff34b540daacae948f493b0ba525edf5f642: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2017-03-15 18:44:05 +) > > are available in the git repository at: > > git:/

Re: [Qemu-devel] [PATCH] Dead code removal: removing code for unsupported DEPTH.

2017-03-16 Thread Peter Maydell
On 16 March 2017 at 12:01, wrote: > From: Iwona Kotlarska > > Signed-off-by: Iwona Kotlarska Thanks -- cc'ing Gerd who's just done some cirrus patches and is probably best placed to review this. PS: if you put "cirrus_vga:" in your patch subject then it helps people to know what part of QEMU

Re: [Qemu-devel] [PATCH 01/31] ram: move more fields into RAMState

2017-03-16 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > last_seen_block, last_sent_block, last_offset, last_version and > ram_bulk_stage are globals that are really related together. > > Signed-off-by: Juan Quintela > --- > migration/ram.c | 136 >

Re: [Qemu-devel] [PATCH 02/31] ram: Add dirty_rate_high_cnt to RAMState

2017-03-16 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > We need to add a parameter to several functions to make this work. > > Signed-off-by: Juan Quintela > --- > migration/ram.c | 23 --- > 1 file changed, 12 insertions(+), 11 deletions(-) > > diff --git a/migration/ram.c b/migrati

Re: [Qemu-devel] [PATCH 03/31] ram: move bitmap_sync_count into RAMState

2017-03-16 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > migration/ram.c | 22 +++--- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/migration/ram.c b/migration/ram.c > index 9120755..c0bee94

Re: [Qemu-devel] [PATCH 04/31] ram: Move start time into RAMState

2017-03-16 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > migration/ram.c | 20 +++- > 1 file changed, 11 insertions(+), 9 deletions(-) > > diff --git a/migration/ram.c b/migration/ram.c > index c0bee94..f6ac503 100

Re: [Qemu-devel] [PATCH 05/31] ram: Move bytes_xfer_prev into RAMState

2017-03-16 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > migration/ram.c | 13 +++-- > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/migration/ram.c b/migration/ram.c > index f6ac503..2d288cc 100644 > --

Re: [Qemu-devel] [PATCH 06/31] ram: Move num_dirty_pages_period into RAMState

2017-03-16 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert (This series could be fewer patches...) > --- > migration/ram.c | 13 +++-- > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/migration/ram.c b/migration/r

Re: [Qemu-devel] [PATCH 07/31] ram: Move xbzrle_cache_miss_prev into RAMState

2017-03-16 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela > --- > migration/ram.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/migration/ram.c b/migration/ram.c > index b13d2d5..ae077c5 100644 > --- a/migration/ram.c > +++ b/migration/ram.c

Re: [Qemu-devel] [PATCH 08/31] ram: Move iterations_prev into RAMState

2017-03-16 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela > --- > migration/ram.c | 13 ++--- > 1 file changed, 6 insertions(+), 7 deletions(-) > > diff --git a/migration/ram.c b/migration/ram.c > index ae077c5..6cdad06 100644 > --- a/migration/ram.c > +++ b/migration/r

Re: [Qemu-devel] [PATCH v5] xen: don't save/restore the physmap on VM save/restore

2017-03-16 Thread Anthony PERARD
On Wed, Mar 15, 2017 at 04:01:19PM +, Igor Druzhinin wrote: > Saving/restoring the physmap to/from xenstore was introduced to > QEMU majorly in order to cover up the VRAM region restore issue. > The sequence of restore operations implies that we should know > the effective guest VRAM address *b

Re: [Qemu-devel] [PATCH 09/31] ram: Move dup_pages into RAMState

2017-03-16 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Once there rename it to its actual meaning, zero_pages. > > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > migration/ram.c | 26 +++--- > 1 file changed, 15 insertions(+), 11 deletions(-) > > diff --

Re: [Qemu-devel] [PATCH v3 0/2] hw/i386: Update FADT to Revision 3 (ACPI 2.0)

2017-03-16 Thread Laszlo Ersek
On 03/15/17 07:20, Phil Dennis-Jordan wrote: > This updates the FADT generated for x86/64 machine types from Revision 1 to > 3. (Based on ACPI standard 2.0 instead of 1.0) As previously, the goal is to > make running macOS/OS X guests smoother. With a Rev1 FADT, rebooting such a > guest doesn't

Re: [Qemu-devel] [PATCH v5] xen: don't save/restore the physmap on VM save/restore

2017-03-16 Thread Igor Druzhinin
On 16/03/17 12:26, Anthony PERARD wrote: > On Wed, Mar 15, 2017 at 04:01:19PM +, Igor Druzhinin wrote: >> Saving/restoring the physmap to/from xenstore was introduced to >> QEMU majorly in order to cover up the VRAM region restore issue. >> The sequence of restore operations implies that we sho

Re: [Qemu-devel] [PATCH] target-x86:Add GDB XML register description support

2017-03-16 Thread Abdallah Bouassida
ping http://patchwork.ozlabs.org/patch/709408/ Le 12/28/2016 à 5:34 PM, Abdallah Bouassida a écrit : [Qemu-devel] [PATCH] target-x86:Add GDB XML register description support This patch implements XML target description support for X86 and X86-64 architectures in the GDB stub, as the way with AR

Re: [Qemu-devel] [PATCH v3 00/11] MTTCG fix-ups for 2.9

2017-03-16 Thread Alex Bennée
Pavel Dovgalyuk writes: >> From: Alex Bennée [mailto:alex.ben...@linaro.org] >> Pavel Dovgalyuk writes: >> >> From: Alex Bennée [mailto:alex.ben...@linaro.org] >> >> Pavel Dovgalyuk writes: >> >> >> From: mttcg-requ...@listserver.greensocs.com [mailto:mttcg- >> >> requ...@listserver.greensocs.

Re: [Qemu-devel] [PATCH] target-x86:Add GDB XML register description support

2017-03-16 Thread Paolo Bonzini
On 16/03/2017 14:02, Abdallah Bouassida wrote: >> >> X86CPU *cpu_x86_init(const char *cpu_model) >> { >> return X86_CPU(cpu_generic_init(TYPE_X86_CPU, cpu_model)); >> @@ -3720,10 +3729,14 @@ static void >> x86_cpu_common_class_init(ObjectClass *oc, void *data) >> cc->write_elf32_qemun

Re: [Qemu-devel] [PATCH v2] target/s390x: Fix broken user mode

2017-03-16 Thread David Hildenbrand
On 02.03.2017 20:56, David Hildenbrand wrote: > Am 30.01.2017 um 14:15 schrieb Stefan Weil: >> Returning NULL from get_max_cpu_model results in a SIGSEGV runtime error. >> >> Signed-off-by: Stefan Weil >> --- >> >> v2: Re-sent as v1 was damaged by my mailer. >> >> This is also broken in Debian. >>

Re: [Qemu-devel] [PATCH v2] x86: Allow to set NUMA distance for different NUMA nodes

2017-03-16 Thread Andrew Jones
On Thu, Mar 16, 2017 at 04:38:24PM +0800, He Chen wrote: > Current, QEMU does not provide a clear command to set vNUMA distance for > guest although we already have `-numa` command to set vNUMA nodes. > > vNUMA distance makes sense in certain scenario. > But now, if we create a guest that has 4 vN

Re: [Qemu-devel] [PATCH for-2.10 6/8] ppc/pnv: Add cut down PSI bridge model and hookup external interrupt

2017-03-16 Thread Cédric Le Goater
On 03/15/2017 07:16 AM, David Gibson wrote: > On Wed, Mar 08, 2017 at 11:52:49AM +0100, Cédric Le Goater wrote: >> From: Benjamin Herrenschmidt >> >> The PSI (Processor Service Interface) Controller is one of the engines >> of the "Bridge" unit which connects the different interfaces to the >> Pow

[Qemu-devel] Adding our own nic model

2017-03-16 Thread Shirley Kotian
We are working on a project in QEMU wherein we want to add our own nic model userio. Can you please tell us how to go about it. Thanking you, Warm regards, Shirley Kotian

Re: [Qemu-devel] [PULL for-2.9 4/7] cirrus: add option to disable blitter

2017-03-16 Thread Gerd Hoffmann
Hi, > > +DEFINE_PROP_BOOL("blitter", struct PCICirrusVGAState, > > > + cirrus_vga.enable_blitter, true), > > > The default is 'ENABLE'? Yes. > I think there should be 'false'. Just flipping it to false isn't an option. At minimum we would have to keep it enabled b

Re: [Qemu-devel] [Xen-devel] [PATCH v5] xen: don't save/restore the physmap on VM save/restore

2017-03-16 Thread Igor Druzhinin
On 16/03/17 12:54, Igor Druzhinin wrote: > On 16/03/17 12:26, Anthony PERARD wrote: >> On Wed, Mar 15, 2017 at 04:01:19PM +, Igor Druzhinin wrote: >>> Saving/restoring the physmap to/from xenstore was introduced to >>> QEMU majorly in order to cover up the VRAM region restore issue. >>> The seq

Re: [Qemu-devel] [PULL 0/5] virtio, pci: fixes

2017-03-16 Thread Peter Maydell
On 16 March 2017 at 02:34, Michael S. Tsirkin wrote: > The following changes since commit 1883ff34b540daacae948f493b0ba525edf5f642: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2017-03-15 18:44:05 +) > > are available in the git repository at: > > git:/

Re: [Qemu-devel] [PATCH] Dead code removal: removing code for unsupported DEPTH.

2017-03-16 Thread Gerd Hoffmann
Hi, > > -#define DEPTH 8 > > -#include "cirrus_vga_rop2.h" > > - > > -#define DEPTH 16 > > -#include "cirrus_vga_rop2.h" > > - > > -#define DEPTH 24 > > -#include "cirrus_vga_rop2.h" > > - > > #define DEPTH 32 > > #include "cirrus_vga_rop2.h" No. It isn't *that* simple. The cirrus blitter o

[Qemu-devel] [PATCH 1/2] xen: use 5 digit xen versions

2017-03-16 Thread Juergen Gross
Today qemu is using e.g. the value 480 for Xen version 4.8.0. As some Xen version tests are using ">" relations this scheme will lead to problems when Xen version 4.10.0 is being reached. Instead of the 3 digit schem use a 5 digit scheme (e.g. 40800 for version 4.8.0). Signed-off-by: Juergen Gros

[Qemu-devel] [PATCH 2/2] configure: use pkg-config for obtaining xen version

2017-03-16 Thread Juergen Gross
Instead of trying to guess the Xen version to use by compiling various test programs first just ask the system via pkg-config. Only if it can't return the version fall back to the test program scheme. Signed-off-by: Juergen Gross --- configure | 31 +++ 1 file changed

[Qemu-devel] [PATCH 0/2] xen: use pkg-config for configure

2017-03-16 Thread Juergen Gross
This small patch set is to be applied on top of Paul's series for support of libxendevicemodel, or (maybe even better) it should be merged into this series. Juergen Gross (2): xen: use 5 digit xen versions configure: use pkg-config for obtaining xen version configure | 43 +

Re: [Qemu-devel] [Qemu-ppc] qemu-system-ppc video artifacts since "tcg: drop global lock during TCG code execution"

2017-03-16 Thread Paolo Bonzini
On 16/03/2017 08:35, Gerd Hoffmann wrote: > Hi, > Note that KVM has some similar hacks to avoid trapping all writes to video memory with its coalesced mmio mechanism however I'm not familiar with all the details. >>> >>> Normal linear framebuffer access doesn't use this. >> >> A

Re: [Qemu-devel] [PULL for 2.9 00/49] QAPI patches for 2017-03-16

2017-03-16 Thread Peter Maydell
On 16 March 2017 at 06:27, Markus Armbruster wrote: > Significant improvements to QMP documentation, fixing its regression. > > Note: only QAPI *generator* code changes, except for trailing space > removal in generated qmp-marshal.c and doc comments in QAPI schemas. > > The following changes since

Re: [Qemu-devel] [PATCH] Dead code removal: removing code for unsupported DEPTH.

2017-03-16 Thread Paolo Bonzini
On 16/03/2017 15:12, Gerd Hoffmann wrote: > Hi, > >>> -#define DEPTH 8 >>> -#include "cirrus_vga_rop2.h" >>> - >>> -#define DEPTH 16 >>> -#include "cirrus_vga_rop2.h" >>> - >>> -#define DEPTH 24 >>> -#include "cirrus_vga_rop2.h" >>> - >>> #define DEPTH 32 >>> #include "cirrus_vga_rop2.h" >

Re: [Qemu-devel] [PATCH v3 0/2] hw/i386: Update FADT to Revision 3 (ACPI 2.0)

2017-03-16 Thread Michael S. Tsirkin
On Wed, Mar 15, 2017 at 07:20:25PM +1300, Phil Dennis-Jordan wrote: > This updates the FADT generated for x86/64 machine types from Revision 1 to > 3. (Based on ACPI standard 2.0 instead of 1.0) As previously, the goal is to > make running macOS/OS X guests smoother. With a Rev1 FADT, rebooting s

[Qemu-devel] [PATCH v2 0/8] ppc/pnv: interrupt controller (POWER8)

2017-03-16 Thread Cédric Le Goater
Hello, Here is a series adding support for the interrupt controller as found on a POWER8 system. POWER9 uses a different interrupt controller called XIVE, still to be worked on. The initial patches are more cleanups of the XICS layer which move the IRQ 'server' number mapping under the machine ha

Re: [Qemu-devel] [PATCH] Dead Code Removal: removing support for DEPTH != 32.

2017-03-16 Thread Paolo Bonzini
On 16/03/2017 10:20, iwona260...@gmail.com wrote: > static draw_line_func * draw_line8_funcs[] = { > -draw_line8_8, > -draw_line8_15, > -draw_line8_16, > draw_line8_32, > draw_line8_32bgr, > -draw_line8_15bgr, > -draw_line8_16bgr, > }; > > static draw_line_func

[Qemu-devel] [PATCH v2 1/8] ppc/xics: introduce an ICPState backlink under PowerPCCPU

2017-03-16 Thread Cédric Le Goater
Today, the ICPState array of the sPAPR machine is indexed with 'cpu_index' of the CPUState. This numbering of CPUs is internal to QEMU and the guest only knows about what is exposed in the device tree, that is the 'cpu_dt_id'. This is why sPAPR uses the helper xics_get_cpu_index_by_dt_id() to do th

[Qemu-devel] [PATCH v2 2/8] spapr: move the IRQ server number mapping under the machine

2017-03-16 Thread Cédric Le Goater
This is the second step to abstract the IRQ 'server' number of the XICS layer. Now that the prereq cleanups have been done in the previous patch, we can move down the 'cpu_dt_id' to 'cpu_index' mapping in the sPAPR machine handler. Signed-off-by: Cédric Le Goater --- hw/intc/xics_spapr.c| 5

[Qemu-devel] [PATCH v2 4/8] ppc/pnv: add a PnvICPState object

2017-03-16 Thread Cédric Le Goater
This provides a new ICPState object for the PowerNV machine (POWER8). Access to the Interrupt Management area is done though a memory region. It contains the registers of the Interrupt Control Presenters of each thread which are used to accept, return, forward interrupts in the system. Signed-off-

[Qemu-devel] [PATCH v2 3/8] ppc/xics: add a realize() handler to ICPStateClass

2017-03-16 Thread Cédric Le Goater
It will be used by derived classes in PowerNV for customization. Signed-off-by: Cédric Le Goater --- hw/intc/xics.c| 5 + include/hw/ppc/xics.h | 1 + 2 files changed, 6 insertions(+) diff --git a/hw/intc/xics.c b/hw/intc/xics.c index 5cde86ceb3bc..7cd842102265 100644 --- a/hw/intc/

[Qemu-devel] [PATCH v2 7/8] ppc/pnv: link the CPUs to the machine XICSFabric

2017-03-16 Thread Cédric Le Goater
This assigns the ICPState object to the CPU using the PIR number for lookups before calling the XICS layer to finish the job. Signed-off-by: Cédric Le Goater --- hw/ppc/pnv.c | 2 ++ hw/ppc/pnv_core.c | 20 2 files changed, 18 insertions(+), 4 deletions(-) diff --git

[Qemu-devel] [PATCH v2 8/8] ppc/pnv: add memory regions for the ICP registers

2017-03-16 Thread Cédric Le Goater
This provides to a PowerNV chip (POWER8) access to the Interrupt Management area, which contains the registers of the Interrupt Control Presenters of each thread. These are used to accept, return, forward interrupts in the system. This area is modeled with a per-chip container memory region holdin

[Qemu-devel] [PATCH v2 5/8] ppc/pnv: create the ICP and ICS objects under the machine

2017-03-16 Thread Cédric Le Goater
Like this is done for the sPAPR machine, we use a simple array under the PowerNV machine to store the Interrupt Control Presenters (ICP) objects, one for each vCPU. This array is indexed by 'cpu_index' of the CPUState but the users will provide a core PIR number. The mapping is done in the icp_get(

[Qemu-devel] [PATCH v2 6/8] ppc/pnv: add a helper to calculate MMIO addresses registers

2017-03-16 Thread Cédric Le Goater
Some controllers (ICP, PSI) have a base register address which is calculated using the chip id. Signed-off-by: Cédric Le Goater --- include/hw/ppc/pnv.h | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/include/hw/ppc/pnv.h b/include/hw/ppc/pnv.h index d6ef04771aff

Re: [Qemu-devel] [Xen-devel] [PATCH v5] xen: don't save/restore the physmap on VM save/restore

2017-03-16 Thread Anthony PERARD
On Thu, Mar 16, 2017 at 02:06:21PM +, Igor Druzhinin wrote: > On 16/03/17 12:54, Igor Druzhinin wrote: > > On 16/03/17 12:26, Anthony PERARD wrote: > >> I've tried to migrate a guest with this patch, but once migrated, the > >> screen is black (via VNC, keyboard is working fine). > >> > > Hmm.

Re: [Qemu-devel] [PATCH v2] target/s390x: Fix broken user mode

2017-03-16 Thread Philippe Mathieu-Daudé
Hi Stefan, Richard. On 03/16/2017 10:28 AM, David Hildenbrand wrote: On 02.03.2017 20:56, David Hildenbrand wrote: Am 30.01.2017 um 14:15 schrieb Stefan Weil: Returning NULL from get_max_cpu_model results in a SIGSEGV runtime error. Signed-off-by: Stefan Weil --- v2: Re-sent as v1 was damag

Re: [Qemu-devel] [PATCH v3 00/11] MTTCG fix-ups for 2.9

2017-03-16 Thread Pavel Dovgalyuk
> From: Alex Bennée [mailto:alex.ben...@linaro.org] > Pavel Dovgalyuk writes: > >> From: Alex Bennée [mailto:alex.ben...@linaro.org] > >> Pavel Dovgalyuk writes: > > > >> I ran the following test on both pre-mttcg-merge and my current HEAD > >> which includes Paolo's fix series: > >> > >> ./arm-

Re: [Qemu-devel] [PATCH v2] target/s390x: Fix broken user mode

2017-03-16 Thread David Hildenbrand
On 16.03.2017 15:46, Philippe Mathieu-Daudé wrote: > Hi Stefan, Richard. > > On 03/16/2017 10:28 AM, David Hildenbrand wrote: >> On 02.03.2017 20:56, David Hildenbrand wrote: >>> Am 30.01.2017 um 14:15 schrieb Stefan Weil: Returning NULL from get_max_cpu_model results in a SIGSEGV runtime err

Re: [Qemu-devel] [PULL v2 0/8] target-mips queue

2017-03-16 Thread Peter Maydell
On 23 February 2017 at 12:46, Peter Maydell wrote: > On 22 February 2017 at 00:21, Yongbok Kim wrote: >> This is the v2 of the pull-req for target-mips. >> The warning treated as error has been fixed and the file is now isolated for >> mips64el only. >> Boston has further update to have default

Re: [Qemu-devel] [Xen-devel] [PATCH v5] xen: don't save/restore the physmap on VM save/restore

2017-03-16 Thread Anthony PERARD
On Thu, Mar 16, 2017 at 02:46:56PM +, Anthony PERARD wrote: > On Thu, Mar 16, 2017 at 02:06:21PM +, Igor Druzhinin wrote: > > On 16/03/17 12:54, Igor Druzhinin wrote: > > > On 16/03/17 12:26, Anthony PERARD wrote: > > >> I've tried to migrate a guest with this patch, but once migrated, the

[Qemu-devel] Proposal for deprecating unsupported host OSes & architecutures

2017-03-16 Thread Peter Maydell
OK, here's a concrete proposal for deprecating/dropping out of date host OS and architecture support. We'll put this in the ChangeLog 'Future incompatible changes' section: - * Removal of support for untested host OS and architectures: The QEMU Project intends to drop support in a future rele

Re: [Qemu-devel] [RFC v2 2/3] hw/intc/arm_gicv3_its: Implement state save/restore

2017-03-16 Thread Auger Eric
Hi Peter, On 13/03/2017 18:58, Peter Maydell wrote: > On 6 March 2017 at 12:48, Eric Auger wrote: >> We need to handle both registers and ITS tables. While >> register handling is standard, ITS table handling is more >> challenging since the kernel API is devised so that the >> tables are flushed

Re: [Qemu-devel] [RFC v2 3/3] hw/intc/arm_gicv3_its: Allow save/restore

2017-03-16 Thread Auger Eric
Hi Peter, On 13/03/2017 19:03, Peter Maydell wrote: > On 6 March 2017 at 12:48, Eric Auger wrote: >> We change the restoration priority of both the GICv3 and ITS. The >> GICv3 must be restored before the ITS and the ITS needs to be restored >> before PCIe devices since it translates their MSI tra

Re: [Qemu-devel] [PULL 0/3] Tracing patches

2017-03-16 Thread Peter Maydell
On 16 March 2017 at 07:04, Stefan Hajnoczi wrote: > The following changes since commit 1883ff34b540daacae948f493b0ba525edf5f642: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2017-03-15 18:44:05 +) > > are available in the git repository at: > > git://gi

Re: [Qemu-devel] [Qemu-ppc] qemu-system-ppc video artifacts since "tcg: drop global lock during TCG code execution"

2017-03-16 Thread Gerd Hoffmann
Hi, > >> least cg3.c is doing > >> > >>read dirty bitmap > >>read VRAM > >>clear dirty bitmap > >> > >> which has a race. > It's much simpler than that, just clear the dirty bitmap bit before > reading the memory. Well, not *that* simple. vga checks the dirty bitmap with scanline

Re: [Qemu-devel] Proposal for deprecating unsupported host OSes & architecutures

2017-03-16 Thread Daniel P. Berrange
On Thu, Mar 16, 2017 at 03:23:45PM +, Peter Maydell wrote: > OK, here's a concrete proposal for deprecating/dropping out of > date host OS and architecture support. > > We'll put this in the ChangeLog 'Future incompatible changes' > section: > - > * Removal of support for untested host OS

Re: [Qemu-devel] [PATCH 10/31] ram: Remove unused dump_mig_dbytes_transferred()

2017-03-16 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela Subject has a couple of typos; otherwise; Reviewed-by: Dr. David Alan Gilbert > --- > include/migration/migration.h | 1 - > migration/ram.c | 5 - > 2 files changed, 6 deletions(-) > > diff --git

Re: [Qemu-devel] Proposal for deprecating unsupported host OSes & architecutures

2017-03-16 Thread Peter Maydell
On 16 March 2017 at 15:46, Daniel P. Berrange wrote: > On Thu, Mar 16, 2017 at 03:23:45PM +, Peter Maydell wrote: >> OK, here's a concrete proposal for deprecating/dropping out of >> date host OS and architecture support. >> >> We'll put this in the ChangeLog 'Future incompatible changes' >> s

Re: [Qemu-devel] Proposal for deprecating unsupported host OSes & architecutures

2017-03-16 Thread Gerd Hoffmann
Hi, > I'm not sure here if we want to just have this as a bald list, > or to have some kind of two tier setup with OSes we expect to > dump in one tier and OSes where we're really trolling for a build > machine in the other tier (the "unlikely to dump" category would > get most of the BSD varian

Re: [Qemu-devel] [PATCH 11/31] ram: Remove unused pages_skiped variable

2017-03-16 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > For compatibility, we need to still send a value, but just specify it > and comment the fact. > > Signed-off-by: Juan Quintela Note missing p in subject, Reviewed-by: Dr. David Alan Gilbert > --- > include/migration/migration.h | 2 -- > migrat

Re: [Qemu-devel] Proposal for deprecating unsupported host OSes & architecutures

2017-03-16 Thread Daniel P. Berrange
On Thu, Mar 16, 2017 at 03:55:13PM +, Peter Maydell wrote: > On 16 March 2017 at 15:46, Daniel P. Berrange wrote: > > On Thu, Mar 16, 2017 at 03:23:45PM +, Peter Maydell wrote: > >> OK, here's a concrete proposal for deprecating/dropping out of > >> date host OS and architecture support. >

[Qemu-devel] [PATCH for-2.9] thread-pool: add missing qemu_bh_cancel in completion function

2017-03-16 Thread Peter Lieven
commit 3c80ca15 fixed a deadlock scenarion with nested aio_poll invocations. However, the rescheduling of the completion BH introcuded unnecessary spinning in the main-loop. On very fast file backends this can even lead to the "WARNING: I/O thread spun for 1000 iterations" message popping up. Cal

Re: [Qemu-devel] Proposal for deprecating unsupported host OSes & architecutures

2017-03-16 Thread Peter Maydell
On 16 March 2017 at 16:00, Daniel P. Berrange wrote: > I'm just pretty wary of gratuitously deleting stuff that still > has a reasonable chance of being functional, simply because > we lack CI testing. Well, me too, but I think that if nobody turns up to help us or donate a test machine despite c

Re: [Qemu-devel] [PATCH 12/31] ram: Move norm_pages to RAMState

2017-03-16 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > migration/ram.c | 26 ++ > 1 file changed, 14 insertions(+), 12 deletions(-) > > diff --git a/migration/ram.c b/migration/ram.c > index 468f042..58c7

Re: [Qemu-devel] Proposal for deprecating unsupported host OSes & architecutures

2017-03-16 Thread Daniel P. Berrange
On Thu, Mar 16, 2017 at 04:06:35PM +, Peter Maydell wrote: > On 16 March 2017 at 16:00, Daniel P. Berrange wrote: > > I'm just pretty wary of gratuitously deleting stuff that still > > has a reasonable chance of being functional, simply because > > we lack CI testing. > > Well, me too, but I

Re: [Qemu-devel] [PATCH 13/31] ram: Remove norm_mig_bytes_transferred

2017-03-16 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Its value can be calculated by other exported. > > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > include/migration/migration.h | 1 - > migration/migration.c | 3 ++- > migration/ram.c | 5 - >

[Qemu-devel] [PATCH] qemu-ga: obey LISTEN_PID when using systemd socket activation

2017-03-16 Thread Paolo Bonzini
qemu-ga's socket activation support was not obeying the LISTEN_PID environment variable, which avoids that a process uses a socket-activation file descriptor meant for its parent. Mess can for example ensue if a process forks a children before consuming the socket-activation file descriptor and th

Re: [Qemu-devel] Proposal for deprecating unsupported host OSes & architecutures

2017-03-16 Thread Daniel P. Berrange
On Thu, Mar 16, 2017 at 03:23:45PM +, Peter Maydell wrote: > OK, here's a concrete proposal for deprecating/dropping out of > date host OS and architecture support. > > We'll put this in the ChangeLog 'Future incompatible changes' > section: > - > * Removal of support for untested host OS

Re: [Qemu-devel] [PATCH for-2.9] thread-pool: add missing qemu_bh_cancel in completion function

2017-03-16 Thread Paolo Bonzini
On 16/03/2017 17:02, Peter Lieven wrote: > commit 3c80ca15 fixed a deadlock scenarion with nested aio_poll invocations. > > However, the rescheduling of the completion BH introcuded unnecessary spinning > in the main-loop. On very fast file backends this can even lead to the > "WARNING: I/O thre

Re: [Qemu-devel] [PATCH v2] x86: Allow to set NUMA distance for different NUMA nodes

2017-03-16 Thread Andrew Jones
On Thu, Mar 16, 2017 at 04:38:24PM +0800, He Chen wrote: > Current, QEMU does not provide a clear command to set vNUMA distance for > guest although we already have `-numa` command to set vNUMA nodes. > > vNUMA distance makes sense in certain scenario. > But now, if we create a guest that has 4 vN

Re: [Qemu-devel] [PATCH] qemu-ga: obey LISTEN_PID when using systemd socket activation

2017-03-16 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH] qemu-ga: obey LISTEN_PID when using systemd socket activation Message-id: 20170316161535.22157-1-pbonz...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash

Re: [Qemu-devel] [PATCH] qemu-ga: obey LISTEN_PID when using systemd socket activation

2017-03-16 Thread Daniel P. Berrange
On Thu, Mar 16, 2017 at 05:15:35PM +0100, Paolo Bonzini wrote: > qemu-ga's socket activation support was not obeying the LISTEN_PID > environment variable, which avoids that a process uses a socket-activation > file descriptor meant for its parent. > > Mess can for example ensue if a process forks

Re: [Qemu-devel] [PULL v2 0/8] target-mips queue

2017-03-16 Thread Yongbok Kim
I updated the section before? Build dependencies QEMU now requires a minimum dtc version of 1.4.2. Do you mean to update it like "dtc (libfdt)"? Regards, Yongbok On 16/03/2017 15:03, Peter Maydell wrote: > On 23 February 2017 at 12:46, Peter Maydell wrote: >> On 22 February 2017 at 00:21

Re: [Qemu-devel] [PATCH] qemu-ga: obey LISTEN_PID when using systemd socket activation

2017-03-16 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Subject: [Qemu-devel] [PATCH] qemu-ga: obey LISTEN_PID when using systemd socket activation Message-id: 20170316

Re: [Qemu-devel] [PATCH] puv3: always compile-check debug printf

2017-03-16 Thread Wei Huang
On 03/16/2017 07:04 AM, Alex Bennée wrote: > > Anishka0107 writes: > >> To prevent bitrot of the format string of the debug statement, files with >> conditional debug statements should ensure that printf is compiled always, >> and enclosed within if(0) statements and not in #ifdef. >>

Re: [Qemu-devel] Proposal for deprecating unsupported host OSes & architecutures

2017-03-16 Thread Peter Maydell
On 16 March 2017 at 16:16, Daniel P. Berrange wrote: > BTW, by "build & test system available", presumably you mean a system > that someone has committed to actively maintaining, not merely donation > of (or access to) hardware on which to install & run VMs ? My personal minimum is "something I c

Re: [Qemu-devel] [PULL v2 0/8] target-mips queue

2017-03-16 Thread Peter Maydell
On 16 March 2017 at 16:25, Yongbok Kim wrote: > I updated the section before? > > Build dependencies > > QEMU now requires a minimum dtc version of 1.4.2. > > Do you mean to update it like "dtc (libfdt)"? > No, that's fine. Sorry, I must have somehow been looking at a stale version of the pag

[Qemu-devel] [PATCH] 9pfs: don't try to flush self and avoid QEMU hang on reset

2017-03-16 Thread Greg Kurz
According to the 9P spec [*], when a client wants to cancel a pending I/O request identified by a given tag (uint16), it must send a Tflush message and wait for the server to respond with a Rflush message before reusing this tag for another I/O. The server may still send a completion message for th

Re: [Qemu-devel] [PATCH] qemu-ga: obey LISTEN_PID when using systemd socket activation

2017-03-16 Thread Paolo Bonzini
On 16/03/2017 17:19, Daniel P. Berrange wrote: > On Thu, Mar 16, 2017 at 05:15:35PM +0100, Paolo Bonzini wrote: >> qemu-ga's socket activation support was not obeying the LISTEN_PID >> environment variable, which avoids that a process uses a socket-activation >> file descriptor meant for its pare

[Qemu-devel] [PATCH v2] qemu-ga: obey LISTEN_PID when using systemd socket activation

2017-03-16 Thread Paolo Bonzini
qemu-ga's socket activation support was not obeying the LISTEN_PID environment variable, which avoids that a process uses a socket-activation file descriptor meant for its parent. Mess can for example ensue if a process forks a children before consuming the socket-activation file descriptor and th

Re: [Qemu-devel] [PULL 0/6] Migration fixes

2017-03-16 Thread Peter Maydell
#x27; into staging > (2017-03-15 18:44:05 +) > > are available in the git repository at: > > git://github.com/juanquintela/qemu.git tags/migration/20170316 > > for you to fetch changes up to 8679638b0e231f97ad3456c681bf56

Re: [Qemu-devel] Proposal for deprecating unsupported host OSes & architecutures

2017-03-16 Thread Paolo Bonzini
On 16/03/2017 16:55, Peter Maydell wrote: >> IOW, I think there is a reasonable 3 tier set here >> >> 1. Stuff we actively test builds & thus guarantee will work for >> any QEMU release going forward. >> >> 2. Stuff we don't actively test, but generally assume is mostly >> working, and

[Qemu-devel] Make qemu_thread_create return a flag to indicate if it succeeded

2017-03-16 Thread Achilles Benetopoulos
I am interested in working on the BiteSized Task mentioned in the subject line. However, I have a question: Since the current behaviour of qemu_thread_create is to fail in the case of an error, then it seems logical to make the caller exit (in the patched version) if the return value of the call t

Re: [Qemu-devel] [Qemu-ppc] qemu-system-ppc video artifacts since "tcg: drop global lock during TCG code execution"

2017-03-16 Thread Paolo Bonzini
On 16/03/2017 16:34, Gerd Hoffmann wrote: > Well, not *that* simple. vga checks the dirty bitmap with scanline > granularity, like that: > > foreach (scanline) { > if (get_dirty(scanline)) > update_scanline() > } > reset_dirty(framebuffer) > > I suspect simply transforming t

Re: [Qemu-devel] [PATCH] qemu-ga: obey LISTEN_PID when using systemd socket activation

2017-03-16 Thread Daniel P. Berrange
On Thu, Mar 16, 2017 at 05:34:30PM +0100, Paolo Bonzini wrote: > > > On 16/03/2017 17:19, Daniel P. Berrange wrote: > > On Thu, Mar 16, 2017 at 05:15:35PM +0100, Paolo Bonzini wrote: > >> qemu-ga's socket activation support was not obeying the LISTEN_PID > >> environment variable, which avoids th

Re: [Qemu-devel] [PATCH] qemu-ga: obey LISTEN_PID when using systemd socket activation

2017-03-16 Thread Richard W.M. Jones
On Thu, Mar 16, 2017 at 05:15:35PM +0100, Paolo Bonzini wrote: > qemu-ga's socket activation support was not obeying the LISTEN_PID > environment variable, which avoids that a process uses a socket-activation > file descriptor meant for its parent. > > Mess can for example ensue if a process forks

Re: [Qemu-devel] Make qemu_thread_create return a flag to indicate if it succeeded

2017-03-16 Thread Alex Bennée
Achilles Benetopoulos writes: > I am interested in working on the BiteSized Task mentioned in the > subject line. However, I have a question: Since the current behaviour > of qemu_thread_create is to fail in the case of an error, then it > seems logical to make the caller exit (in the patched ve

Re: [Qemu-devel] [PATCH v2] qemu-ga: obey LISTEN_PID when using systemd socket activation

2017-03-16 Thread Richard W.M. Jones
On Thu, Mar 16, 2017 at 05:36:40PM +0100, Paolo Bonzini wrote: > qemu-ga's socket activation support was not obeying the LISTEN_PID > environment variable, which avoids that a process uses a socket-activation > file descriptor meant for its parent. > > Mess can for example ensue if a process forks

Re: [Qemu-devel] Make qemu_thread_create return a flag to indicate if it succeeded

2017-03-16 Thread Daniel P. Berrange
On Thu, Mar 16, 2017 at 06:55:47PM +0200, Achilles Benetopoulos wrote: > I am interested in working on the BiteSized Task mentioned in the > subject line. However, I have a question: Since the current behaviour > of qemu_thread_create is to fail in the case of an error, then it > seems logical to m

Re: [Qemu-devel] Benchmarking linux-user performance

2017-03-16 Thread Emilio G. Cota
On Tue, Mar 14, 2017 at 17:06:57 +, Dr. David Alan Gilbert wrote: > * Emilio G. Cota (c...@braap.org) wrote: > > It seems that a good benchmark to take translation overhead into account > > would be gcc/perlbench from SPEC (see [1]; ~20% of exec time is spent > > on translation). Unfortunately,

Re: [Qemu-devel] [RFC patch 2/3] block-backend: add drained_begin / drained_end ops

2017-03-16 Thread Kevin Wolf
Am 16.03.2017 um 01:46 hat John Snow geschrieben: > Signed-off-by: John Snow > > --- > > RFC questions: > > - Does the presence of blk->quiesce_counter relieve the burden of needing > blk->public.io_limits_disabled? I could probably eliminate this counter > entirely and just spy on the root

Re: [Qemu-devel] [PULL 11/24] tcg: enable thread-per-vCPU

2017-03-16 Thread Alex Bennée
Laurent Vivier writes: > Le 27/02/2017 à 15:38, Alex Bennée a écrit : >> >> Laurent Vivier writes: >> >>> Le 24/02/2017 à 12:20, Alex Bennée a écrit : There are a couple of changes that occur at the same time here: - introduce a single vCPU qemu_tcg_cpu_thread_fn On

Re: [Qemu-devel] [RFC patch 3/3] blockjob: add devops to blockjob backends

2017-03-16 Thread Kevin Wolf
Am 16.03.2017 um 01:46 hat John Snow geschrieben: > This lets us hook into drained_begin and drained_end requests from the > backend level, which is particularly useful for making sure that all > jobs associated with a particular node (whether the source or the target) > receive a drain request. >

Re: [Qemu-devel] [PULL for-2.9 0/7] cirrus: more blitter security fixes.

2017-03-16 Thread Peter Maydell
ff34b540daacae948f493b0ba525edf5f642: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2017-03-15 18:44:05 +) > > are available in the git repository at: > > > git://git.kraxel.org/qemu tags/pull-cirrus-20170316-1 > > f

Re: [Qemu-devel] Proposal for deprecating unsupported host OSes & architecutures

2017-03-16 Thread Peter Maydell
On 16 March 2017 at 15:23, Peter Maydell wrote: > (Technically right this instant 'mips' and 's390' would be in the > 'dump' list, since I don't personally have access yet. But we have > a plan for s390, and it turns out there is a mips machine in the > gcc compile farm which I'm just checking out

Re: [Qemu-devel] Proposal for deprecating unsupported host OSes & architecutures

2017-03-16 Thread Daniel P. Berrange
On Thu, Mar 16, 2017 at 06:01:35PM +, Peter Maydell wrote: > On 16 March 2017 at 15:23, Peter Maydell wrote: > > (Technically right this instant 'mips' and 's390' would be in the > > 'dump' list, since I don't personally have access yet. But we have > > a plan for s390, and it turns out there

Re: [Qemu-devel] [PULL 11/24] tcg: enable thread-per-vCPU

2017-03-16 Thread Laurent Vivier
Le 16/03/2017 à 18:31, Alex Bennée a écrit : > > Laurent Vivier writes: > >> Le 27/02/2017 à 15:38, Alex Bennée a écrit : >>> >>> Laurent Vivier writes: >>> Le 24/02/2017 à 12:20, Alex Bennée a écrit : > There are a couple of changes that occur at the same time here: > > - in

Re: [Qemu-devel] Proposal for deprecating unsupported host OSes & architecutures

2017-03-16 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On 16 March 2017 at 15:46, Daniel P. Berrange wrote: > > On Thu, Mar 16, 2017 at 03:23:45PM +, Peter Maydell wrote: > >> OK, here's a concrete proposal for deprecating/dropping out of > >> date host OS and architecture support. > >> > >> We'l

<    1   2   3   >