[Qemu-devel] [PATCH] pl190: Fix off-by-one error in priority handling when reading VECTADDR

2017-02-27 Thread Marc Bommert
The "current" priority bit (1 << i) should also be set in s->prio_mask[i], if the interrupt is enabled. This will in turn cause the read operation of VECTADDR to return the correct vector of the pending interrupt. --- hw/intc/pl190.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

Re: [Qemu-devel] [PATCH 2/3] COLO-compare: Optimize colo_packet_compare_common

2017-02-27 Thread Hailiang Zhang
On 2017/2/27 15:34, Zhang Chen wrote: On 02/27/2017 03:28 PM, Hailiang Zhang wrote: On 2017/2/27 15:03, Zhang Chen wrote: On 02/25/2017 02:58 PM, Hailiang Zhang wrote: On 2017/2/25 11:32, Zhang Chen wrote: Add offset args for colo_packet_compare_common, optimize colo_packet_compare_icmp()

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 08/22] ppc/xics: use the QOM interface to resend irqs

2017-02-27 Thread Cédric Le Goater
void icp_set_cppr(ICPState *ss, uint8_t cppr) @@ -262,7 +261,7 @@ void icp_set_cppr(ICPState *ss, uint8_t cppr) } } else { if (!XISR(ss)) { -icp_resend(ss); +icp_resend(XICS_INTERFACE(qdev_get_machine()), ss); >>> >>

Re: [Qemu-devel] [PULL 00/24] MTTCG Base enabling patches with ARM enablement

2017-02-27 Thread Christian Borntraeger
On 02/25/2017 10:14 PM, Peter Maydell wrote: > On 24 February 2017 at 11:20, Alex Bennée wrote: >> The following changes since commit 2d896b454a0e19ec4c1ddbb0e0b65b7e54fcedf3: >> >> Revert "hw/mips: MIPS Boston board support" (2017-02-23 18:04:45 +) >> >> are available in the git repository

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 04/22] ppc/xics: add an InterruptStatsProvider interface to ICS and ICP objects

2017-02-27 Thread Cédric Le Goater
On 02/27/2017 12:43 AM, David Gibson wrote: > On Fri, Feb 24, 2017 at 11:52:01AM +0100, Cédric Le Goater wrote: >> On 02/23/2017 03:15 AM, David Gibson wrote: >>> On Thu, Feb 16, 2017 at 02:47:27PM +0100, Cédric Le Goater wrote: This is, again, to reduce the use of the list of ICS objects. Let

Re: [Qemu-devel] [PATCH] target-s390x: Implement lpp instruction

2017-02-27 Thread Miroslav Benes
On Sat, 25 Feb 2017, Richard Henderson wrote: > On 02/25/2017 12:50 AM, Miroslav Benes wrote: > > Linux arch/s390/kernel/head(64).S uses lpp instruction if it is > > available in facilities list provided by stfl/stfle instruction. This is > > the case of newer z/System generations and their qemu d

[Qemu-devel] [PATCH v2] target-s390x: Implement lpp instruction

2017-02-27 Thread Miroslav Benes
Linux arch/s390/kernel/head(64).S uses lpp instruction if it is available in facilities list provided by stfl/stfle instruction. This is the case of newer z/System generations and their qemu definition. Signed-off-by: Miroslav Benes --- v2 - remove potential_page_fault() target/s390x/insn-data.

Re: [Qemu-devel] [PATCH 2/3] COLO-compare: Optimize colo_packet_compare_common

2017-02-27 Thread Zhang Chen
On 02/27/2017 04:43 PM, Hailiang Zhang wrote: On 2017/2/27 15:34, Zhang Chen wrote: On 02/27/2017 03:28 PM, Hailiang Zhang wrote: On 2017/2/27 15:03, Zhang Chen wrote: On 02/25/2017 02:58 PM, Hailiang Zhang wrote: On 2017/2/25 11:32, Zhang Chen wrote: Add offset args for colo_packet_co

Re: [Qemu-devel] [PATCH v2 2/3] filter-rewriter: fix memory leak for connection in connection_track_table

2017-02-27 Thread Jason Wang
On 2017年02月27日 14:53, Hailiang Zhang wrote: I think the issue is that your code can not differ A from B. We have a parameter 'fin_ack_seq' recording the sequence of 'FIN=1,ACK=1,seq=w,ack=u+1' and if the ack value from the opposite side is is 'w+1', we can consider this connection is closed,

Re: [Qemu-devel] [PULL 0/5] slirp updates

2017-02-27 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On 26 February 2017 at 20:27, Samuel Thibault > wrote: > > The following changes since commit 685783c5b69c83c942d1fc21679311eeb8f79ab9: > > > > Merge remote-tracking branch 'remotes/thibault/tags/samuel-thibault' into > > staging (2017-02-26 1

Re: [Qemu-devel] [PULL 00/24] MTTCG Base enabling patches with ARM enablement

2017-02-27 Thread Alex Bennée
Christian Borntraeger writes: > On 02/25/2017 10:14 PM, Peter Maydell wrote: >> On 24 February 2017 at 11:20, Alex Bennée wrote: >>> The following changes since commit 2d896b454a0e19ec4c1ddbb0e0b65b7e54fcedf3: >>> >>> Revert "hw/mips: MIPS Boston board support" (2017-02-23 18:04:45 +) >>>

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-02-27 Thread Daniel P. Berrange
On Fri, Feb 24, 2017 at 03:30:21PM -0800, ashish mittal wrote: > Thanks! > > I hope the following is in line with what you suggested - Yes, that looks suitable for password auth > > We will error out in case either of username, secret-id, or password > are missing. > > Good case, passing passw

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 16/22] ppc/xics: register the reset handler of ICP objects

2017-02-27 Thread Cédric Le Goater
[ adding Peter for some insights ] On 02/27/2017 02:00 AM, David Gibson wrote: > On Fri, Feb 24, 2017 at 12:27:35PM +0100, Cédric Le Goater wrote: >> On 02/23/2017 03:42 AM, David Gibson wrote: >>> On Thu, Feb 16, 2017 at 02:47:39PM +0100, Cédric Le Goater wrote: The reset of the ICP objects

Re: [Qemu-devel] [PULL 00/24] MTTCG Base enabling patches with ARM enablement

2017-02-27 Thread Christian Borntraeger
On 02/27/2017 10:11 AM, Alex Bennée wrote: > > Christian Borntraeger writes: > >> On 02/25/2017 10:14 PM, Peter Maydell wrote: >>> On 24 February 2017 at 11:20, Alex Bennée wrote: The following changes since commit 2d896b454a0e19ec4c1ddbb0e0b65b7e54fcedf3: Revert "hw/mips

Re: [Qemu-devel] [PATCH] os: don't corrupt pre-existing memory-backend data with prealloc

2017-02-27 Thread Daniel P. Berrange
On Fri, Feb 24, 2017 at 09:33:05AM -0800, no-re...@patchew.org wrote: > === OUTPUT BEGIN === > Checking PATCH 1/1: os: don't corrupt pre-existing memory-backend data with > prealloc... > ERROR: Use of volatile is usually wrong: see > Documentation/volatile-considered-harmful.txt ERROR: checkpatc

Re: [Qemu-devel] [PATCH 2/4] block/rbd: code movement

2017-02-27 Thread Daniel P. Berrange
Describing this as "code movement" when the added & removed chunks are not identical is a bit misleading. Can you expand the commit message to explain why the extra options are being added On Mon, Feb 27, 2017 at 02:30:39AM -0500, Jeff Cody wrote: > Signed-off-by: Jeff Cody > --- > block/rbd.c

Re: [Qemu-devel] exec: Respect as_tranlsate_internal length clamp

2017-02-27 Thread Paolo Bonzini
On 27/02/2017 06:53, Alexey Kardashevskiy wrote: > There is a link to this one [1]: > http://git.qemu-project.org/?p=qemu.git;a=commitdiff;h=c3c1bb99d1c11978d9ce94d1bdcf0705378c1459 > > Which was reverted with a sensible explanation [2]: > http://git.qemu-project.org/?p=qemu.git;a=commitdiff;h=4

Re: [Qemu-devel] [PATCH 4/4] block/rbd: Add blockdev-add support

2017-02-27 Thread Daniel P. Berrange
On Mon, Feb 27, 2017 at 02:36:13AM -0500, Jeff Cody wrote: > On Mon, Feb 27, 2017 at 02:30:41AM -0500, Jeff Cody wrote: > > Signed-off-by: Jeff Cody > > --- > > qapi/block-core.json | 47 --- > > 1 file changed, 44 insertions(+), 3 deletions(-) > > > >

Re: [Qemu-devel] [PULL 00/24] MTTCG Base enabling patches with ARM enablement

2017-02-27 Thread Christian Borntraeger
On 02/27/2017 10:11 AM, Alex Bennée wrote: > > Christian Borntraeger writes: > >> On 02/25/2017 10:14 PM, Peter Maydell wrote: >>> On 24 February 2017 at 11:20, Alex Bennée wrote: The following changes since commit 2d896b454a0e19ec4c1ddbb0e0b65b7e54fcedf3: Revert "hw/mips

[Qemu-devel] [PATCH] Removed support for depth!=32

2017-02-27 Thread Suramya Shah
Signed-off-by: Suramya Shah --- hw/display/sm501_template.h | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/hw/display/sm501_template.h b/hw/display/sm501_template.h index f33e499..4e5801e 100644 --- a/hw/display/sm501_template.h +++ b/hw/display/sm501_template.h @@ -22

[Qemu-devel] Fail to start 2nd guest

2017-02-27 Thread Xiong Zhou
Hi, It worked fine on Linus tree commit: 7bb0338 Merge tag 'rodata-v4.11-rc1' of git://git.kernel.org/pub/scm/.. failed to start 2nd domain on this commit: 37c8596 Merge tag 'tty-4.11-rc1' of git://git.kernel.org/pub/scm/.. (this commit probably is not the first bad, i didn't do the bisecting)

Re: [Qemu-devel] [PATCH 3/4] savevm: fix savevm after migration

2017-02-27 Thread Denis V. Lunev
On 02/25/2017 10:31 PM, Vladimir Sementsov-Ogievskiy wrote: > After migration all drives are inactive and savevm will fail with > > qemu-kvm: block/io.c:1406: bdrv_co_do_pwritev: >Assertion `!(bs->open_flags & 0x0800)' failed. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/snap

Re: [Qemu-devel] [PULL 0/2] sun4v queue

2017-02-27 Thread Peter Maydell
On 26 February 2017 at 22:29, Artyom Tarasenko wrote: > The following changes since commit a951316b8a5c3c63254f20a826afeed940dd4cba: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2017-02-03 14:41:49 +) > > are available in the git repository at:

Re: [Qemu-devel] [PATCH] vhost-user: delay vhost_user_stop

2017-02-27 Thread Dr. David Alan Gilbert
* Marc-André Lureau (marcandre.lur...@redhat.com) wrote: > Since commit b0a335e351103bf92f3f9d0bd5759311be8156ac, a socket write > may trigger a disconnect events, calling vhost_user_stop() and clearing > all the vhost_dev strutures holding data that vhost.c functions expect > to remain valid. Dela

Re: [Qemu-devel] Fail to start 2nd guest

2017-02-27 Thread Stefan Hajnoczi
On Mon, Feb 27, 2017 at 05:40:50PM +0800, Xiong Zhou wrote: > It worked fine on Linus tree commit: > 7bb0338 Merge tag 'rodata-v4.11-rc1' of git://git.kernel.org/pub/scm/.. > > failed to start 2nd domain on this commit: > 37c8596 Merge tag 'tty-4.11-rc1' of git://git.kernel.org/pub/scm/.. > (thi

Re: [Qemu-devel] using fdt_setprop() to set properties to empty values

2017-02-27 Thread Peter Maydell
On 27 February 2017 at 01:05, David Gibson wrote: > On Fri, Feb 24, 2017 at 10:35:35AM +, Peter Maydell wrote: >> On 24 February 2017 at 00:16, David Gibson >> wrote: >> > Ok, I've pushed libfdt upstream patches to (a) make passing NULL to >> > setprop() with zero length explicitly safe and

Re: [Qemu-devel] [PATCH 2/2] risu_ppc64le: distinguish real illegal instruction

2017-02-27 Thread Peter Maydell
On 27 February 2017 at 05:33, Nikunj A Dadhania wrote: > Peter Maydell writes: > >> On 13 February 2017 at 08:59, Nikunj A Dadhania >> wrote: >>> While executing qemu_ppc64le, found an issue that the real illegal >>> instructions are handled as risu_op which results in wrong info at the >>> mast

[Qemu-devel] [Bug 1668103] Re: Possible off-by-one error in priority handling of hw/PL190.c

2017-02-27 Thread Peter Maydell
For a one-off one-liner bugfix patch it's easier for me to grab it from the bug tracker than require the submitter to resend, though... I'll have a look at it later today. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.l

[Qemu-devel] [PATCH v2] vhost-user: delay vhost_user_stop

2017-02-27 Thread Marc-André Lureau
Since commit b0a335e351103bf92f3f9d0bd5759311be8156ac, a socket write may trigger a disconnect events, calling vhost_user_stop() and clearing all the vhost_dev strutures holding data that vhost.c functions expect to remain valid. Delay the cleanup to keep the vhost_dev structure valid during the vh

Re: [Qemu-devel] [PATCH] vhost-user: delay vhost_user_stop

2017-02-27 Thread Marc-André Lureau
Hi - Original Message - > * Marc-André Lureau (marcandre.lur...@redhat.com) wrote: > > Since commit b0a335e351103bf92f3f9d0bd5759311be8156ac, a socket write > > may trigger a disconnect events, calling vhost_user_stop() and clearing > > all the vhost_dev strutures holding data that vhost.c

[Qemu-devel] [PATCH v4] target-s390x: Implement stfl and stfle

2017-02-27 Thread Michal Marek
Indicate the actual features in the STFL implementation and implement STFLE. Signed-off-by: Michal Marek --- v4: - Remove redundant buffer clearing in do_stfle() - Always store whole doublewords in STFLE - Use s390_cpu_virt_mem_write() to store the result - Raise a specification exception if

Re: [Qemu-devel] [PATCH 04/29] 9pfs: introduce openat_nofollow() helper

2017-02-27 Thread Stefan Hajnoczi
On Fri, Feb 24, 2017 at 11:17:44PM +0100, Greg Kurz wrote: > On Fri, 24 Feb 2017 17:17:30 + > Stefan Hajnoczi wrote: > [...] > > > > This function doesn't handle absolute paths? It ignores leading '/' and > > > > therefore treats all paths as relative paths. > > > > > > > > > > Yes becaus

Re: [Qemu-devel] [PATCH v2] vhost-user: delay vhost_user_stop

2017-02-27 Thread Paolo Bonzini
On 27/02/2017 11:18, Marc-André Lureau wrote: > Since commit b0a335e351103bf92f3f9d0bd5759311be8156ac, a socket write > may trigger a disconnect events, calling vhost_user_stop() and clearing > all the vhost_dev strutures holding data that vhost.c functions expect > to remain valid. Delay the cle

Re: [Qemu-devel] Non-flat command line option argument syntax

2017-02-27 Thread Markus Armbruster
Markus Armbruster writes: [...] > === Dotted keys === > > One sufficiently powerful syntax extension already exists: the dotted > key convention. It's syntactically unambiguous only when none of the > KEYs involved contains '.' To adopt it across the board, we'd have to > outlaw '.' in KEYs. Q

Re: [Qemu-devel] [PATCH v2 2/3] filter-rewriter: fix memory leak for connection in connection_track_table

2017-02-27 Thread Hailiang Zhang
On 2017/2/27 17:05, Jason Wang wrote: On 2017年02月27日 14:53, Hailiang Zhang wrote: I think the issue is that your code can not differ A from B. We have a parameter 'fin_ack_seq' recording the sequence of 'FIN=1,ACK=1,seq=w,ack=u+1' and if the ack value from the opposite side is is 'w+1', we

Re: [Qemu-devel] [PATCH] Removed support for depth!=32

2017-02-27 Thread Peter Maydell
On 27 February 2017 at 08:14, Suramya Shah wrote: > Signed-off-by: Suramya Shah > --- > hw/display/sm501_template.h | 8 +--- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/hw/display/sm501_template.h b/hw/display/sm501_template.h > index f33e499..4e5801e 100644 > --- a/hw

Re: [Qemu-devel] [PATCH 04/29] 9pfs: introduce openat_nofollow() helper

2017-02-27 Thread Greg Kurz
On Mon, 27 Feb 2017 10:20:58 + Stefan Hajnoczi wrote: > On Fri, Feb 24, 2017 at 11:17:44PM +0100, Greg Kurz wrote: > > On Fri, 24 Feb 2017 17:17:30 + > > Stefan Hajnoczi wrote: > > [...] > > > > > This function doesn't handle absolute paths? It ignores leading '/' > > > > > and > > >

Re: [Qemu-devel] [PATCH 4/4] migration: fix use-after-free of to_dst_file

2017-02-27 Thread Dr. David Alan Gilbert
* Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: > hmp_savevm calls qemu_savevm_state(f), which sets to_dst_file=f in > global migration state. Then hmp_savevm closes f (g_free called). > > Next access to to_dst_file in migration state (for example, > qmp_migrate_set_speed) will us

Re: [Qemu-devel] [PATCH] Adding support for LPD and LPDG instructions

2017-02-27 Thread Éric Bischoff
Le samedi 25 février 2017, 10:42:43 CET Richard Henderson a écrit : > On 02/23/2017 10:58 PM, Eric Bischoff wrote: > > +/* LOAD PAIR DISJOINT */ > > +C(0xc804, LPD, SSF, ILA, m1_32s, m2_32s, 0, r3_P32, movx, 0) > > +C(0xc805, LPDG,SSF, ILA, m1_64, m2_64, 0, r3_P64, movx, 0) > >

[Qemu-devel] [PATCH v3] vhost-user: delay vhost_user_stop

2017-02-27 Thread Marc-André Lureau
Since commit b0a335e351103bf92f3f9d0bd5759311be8156ac, a socket write may trigger a disconnect events, calling vhost_user_stop() and clearing all the vhost_dev strutures holding data that vhost.c functions expect to remain valid. Delay the cleanup to keep the vhost_dev structure valid during the vh

Re: [Qemu-devel] [PATCH v3] vhost-user: delay vhost_user_stop

2017-02-27 Thread Paolo Bonzini
On 27/02/2017 11:49, Marc-André Lureau wrote: > Since commit b0a335e351103bf92f3f9d0bd5759311be8156ac, a socket write > may trigger a disconnect events, calling vhost_user_stop() and clearing > all the vhost_dev strutures holding data that vhost.c functions expect > to remain valid. Delay the cle

Re: [Qemu-devel] Non-flat command line option argument syntax

2017-02-27 Thread Kevin Wolf
Am 27.02.2017 um 11:27 hat Markus Armbruster geschrieben: > Markus Armbruster writes: > > [...] > > === Dotted keys === > > > > One sufficiently powerful syntax extension already exists: the dotted > > key convention. It's syntactically unambiguous only when none of the > > KEYs involved contain

Re: [Qemu-devel] Question regarding Snapshots

2017-02-27 Thread Stefan Hajnoczi
On Wed, Feb 22, 2017 at 03:06:41PM -0600, Tim Cusack wrote: > I have a scenario that perhaps not many have attempted, but I still hope > that it is possible. > > Scenario: > > I would like to have a Base Windows 7 VM in KVM/QEMU. > > I would follow the following process (confirmed it works) > >

[Qemu-devel] [PATCH V2] qemu-img: make convert async

2017-02-27 Thread Peter Lieven
the convert process is currently completely implemented with sync operations. That means it reads one buffer and then writes it. No parallelism and each sync request takes as long as it takes until it is completed. This can be a big performance hit when the convert process reads and writes to devi

Re: [Qemu-devel] [PATCH v2 00/30] Various memory leak fixes

2017-02-27 Thread Marc-André Lureau
Hi On Tue, Feb 21, 2017 at 6:27 PM Marc-André Lureau < marcandre.lur...@redhat.com> wrote: > After this series removing a few memory leaks, make check with ASAN > enabled gives a "clean" run with x86_64-softmmu target (there are > warnings related to coroutine makecontext/swapcontext). > > This s

Re: [Qemu-devel] [PATCH v2 00/16] Postcopy: Hugepage support

2017-02-27 Thread Alexey Perevalov
Hi David, On Tue, Feb 21, 2017 at 10:03:14AM +, Dr. David Alan Gilbert wrote: > * Alexey Perevalov (a.pereva...@samsung.com) wrote: > > > > Hello David, > > Hi Alexey, > > > On Tue, Feb 14, 2017 at 07:34:26PM +, Dr. David Alan Gilbert wrote: > > > * Alexey Perevalov (a.pereva...@samsun

Re: [Qemu-devel] [PATCH] os: don't corrupt pre-existing memory-backend data with prealloc

2017-02-27 Thread Stefan Hajnoczi
On Thu, Feb 23, 2017 at 10:59:22AM +, Daniel P. Berrange wrote: > When using a memory-backend object with prealloc turned on, QEMU > will memset() the first byte in every memory page to zero. While > this might have been acceptable for memory backends associated > with RAM, this corrupts applic

[Qemu-devel] [PATCH] tests-aio-multithread: use atomic_read properly

2017-02-27 Thread Paolo Bonzini
nodes[id].next is written by other threads. If atomic_read is not used (matching atomic_set in mcs_mutex_lock!) the compiler can optimize the whole "if" away! Reported-by: Alex Bennée Signed-off-by: Paolo Bonzini --- tests/test-aio-multithread.c | 4 ++-- 1 file changed, 2 insertions(+), 2 del

[Qemu-devel] [PATCH 11/24] test-qobject-input-visitor: Abort earlier on bad test input

2017-02-27 Thread Markus Armbruster
visitor_input_test_init_internal() parses test input with qobject_from_jsonv(), and asserts it succeeds. Pass &error_abort for good measure. Signed-off-by: Markus Armbruster --- tests/test-qobject-input-visitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test-qob

[Qemu-devel] [PATCH 10/24] qjson: Abort earlier on qobject_from_jsonf() misuse

2017-02-27 Thread Markus Armbruster
Ignoring errors first, then asserting success is suboptimal. Pass &error_abort instead, so we abort earlier, and hopefully get more useful clues on what's wrong. Signed-off-by: Markus Armbruster --- qobject/qjson.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qobject/qjso

[Qemu-devel] [PATCH 02/24] tests: Fix gcov-files-test-qemu-opts-y, gcov-files-test-logging-y

2017-02-27 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- tests/Makefile.include | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index cb97473..fdf528c 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -

[Qemu-devel] [PATCH 01/24] test-qemu-opts: Cover qemu_opts_parse() of "no"

2017-02-27 Thread Markus Armbruster
qemu_opts_parse() interprets "no" as negated empty key. Consistent with its acceptance of empty keys elsewhere, whatever that's worth. Signed-off-by: Markus Armbruster --- tests/test-qemu-opts.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/test-qemu-opts.c b/tests/test-qemu-op

[Qemu-devel] [PATCH 15/24] test-visitor-serialization: Pass &error_abort to qobject_from_json()

2017-02-27 Thread Markus Armbruster
qmp_deserialize() calls qobject_from_json() ignoring errors. It passes the result to qobject_input_visitor_new(), which asserts it's not null. Therefore, we can just as well pass &error_abort to qobject_from_json(). Signed-off-by: Markus Armbruster --- tests/test-visitor-serialization.c | 2 +-

[Qemu-devel] [PATCH 16/24] monitor: Assert qmp_schema_json[] is sane

2017-02-27 Thread Markus Armbruster
qmp_query_qmp_schema() parses qmp_schema_json[] with qobject_from_json(). This must not fail, so pass &error_abort. Signed-off-by: Markus Armbruster --- monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/monitor.c b/monitor.c index 858bcda..13f6133 100644 --- a/monito

[Qemu-devel] [PATCH 07/24] qapi: Factor out common qobject_input_get_keyval()

2017-02-27 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- qapi/qobject-input-visitor.c | 87 ++-- 1 file changed, 35 insertions(+), 52 deletions(-) diff --git a/qapi/qobject-input-visitor.c b/qapi/qobject-input-visitor.c index e47615e..3db5850 100644 -

[Qemu-devel] [PATCH 08/24] qobject: Propagate parse errors through qobject_from_jsonv()

2017-02-27 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- include/qapi/qmp/qjson.h | 3 ++- qobject/qjson.c| 12 tests/libqtest.c | 2 +- tests/test-qobject-input-visitor.c | 2 +- 4 files changed, 12 insertions(+), 7 deletions(-) diff --git a/include/q

[Qemu-devel] [PATCH 21/24] test-qapi-util: New, covering qapi/qapi-util.c

2017-02-27 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- tests/.gitignore | 1 + tests/Makefile.include | 3 +++ tests/test-qapi-util.c | 51 ++ 3 files changed, 55 insertions(+) create mode 100644 tests/test-qapi-util.c diff --git a/tests/.gitignore b/tests/

[Qemu-devel] [PATCH 12/24] qobject: Propagate parse errors through qobject_from_json()

2017-02-27 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- block.c| 2 +- include/qapi/qmp/qjson.h | 5 +-- monitor.c | 2 +- qobject/qjson.c| 4 +-- tests/check-qjson.c| 62 +++--- te

[Qemu-devel] [PATCH 14/24] check-qjson: Test errors from qobject_from_json()

2017-02-27 Thread Markus Armbruster
Pass &error_abort with known-good input. Else pass &err and check what comes back. This demonstrates that the parser fails silently for many errors. Signed-off-by: Markus Armbruster --- tests/check-qjson.c | 88 ++--- 1 file changed, 56 insertion

[Qemu-devel] [PATCH 00/24] block: Command line option -blockdev

2017-02-27 Thread Markus Armbruster
Actually, the command line option is the least part of this series. Its bulk is about building infrastructure and getting errors out of the JSON parser[*]. The latter part could be spun out in its own series, if that helps. We'll see. The design of the command line interface was discussed here:

[Qemu-devel] [PATCH 17/24] qapi: New qobject_input_visitor_new_str() for convenience

2017-02-27 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- include/qapi/qobject-input-visitor.h | 12 qapi/qobject-input-visitor.c | 33 + 2 files changed, 45 insertions(+) diff --git a/include/qapi/qobject-input-visitor.h b/include/qapi/qobject-input-visitor.h in

[Qemu-devel] [PATCH 23/24] keyval: Restrict key components to valid QAPI names

2017-02-27 Thread Markus Armbruster
Restricting the key components to something sane leaves us room for evolving key syntax. Since they will be commonly used as QAPI member names by the QObject input visitor, we can just as well borrow the QAPI naming rules here. Signed-off-by: Markus Armbruster --- tests/test-keyval.c | 10 +

[Qemu-devel] [PATCH 13/24] block: More detailed syntax error reporting for JSON filenames

2017-02-27 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- block.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/block.c b/block.c index aa6790c..de7d530 100644 --- a/block.c +++ b/block.c @@ -1163,9 +1163,14 @@ static QDict *parse_json_filename(const char *filename, Error **errp)

[Qemu-devel] [PATCH 05/24] test-keyval: Cover use with qobject input visitor

2017-02-27 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- tests/test-keyval.c | 312 1 file changed, 312 insertions(+) diff --git a/tests/test-keyval.c b/tests/test-keyval.c index 27f6625..f6496d7 100644 --- a/tests/test-keyval.c +++ b/tests/test-keyval.c @@ -12,6

[Qemu-devel] [PATCH v2] Adding support for LPD and LPDG instructions

2017-02-27 Thread Eric Bischoff
Second version of the patch, setting CC to zero. I am not too satisfied, I had to create a cout_zero() helper, but I could not find a better solution.

[Qemu-devel] [PATCH 09/24] libqtest: Fix qmp() & friends to abort on JSON parse errors

2017-02-27 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- tests/libqtest.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/libqtest.c b/tests/libqtest.c index 683d5e3..bb444d5 100644 --- a/tests/libqtest.c +++ b/tests/libqtest.c @@ -21,6 +21,7 @@ #include #include +#include "qapi/err

[Qemu-devel] [PATCH 19/24] qapi: Improve how keyval input visitor reports unexpected dicts

2017-02-27 Thread Markus Armbruster
Incorrect option -blockdev node-name=foo,driver=file,filename=foo.img,aio.unmap is rejected with "Invalid parameter type for 'aio', expected: string". To make sense of this, you almost have to translate it into the equivalent QMP command { "execute": "blockdev-add", "arguments": { "node-

[Qemu-devel] [PATCH 20/24] docs/qapi-code-gen.txt: Clarify naming rules

2017-02-27 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- docs/qapi-code-gen.txt | 61 -- 1 file changed, 39 insertions(+), 22 deletions(-) diff --git a/docs/qapi-code-gen.txt b/docs/qapi-code-gen.txt index 6746c10..9514d93 100644 --- a/docs/qapi-code-gen.txt +++ b/doc

[Qemu-devel] [PATCH] Adding support for LPD and LPDG instructions

2017-02-27 Thread Eric Bischoff
From: Eric Bischoff LPD = LOAD PAIR DISJOINT --- target/s390x/insn-data.def | 4 +++- target/s390x/translate.c | 21 + 2 files changed, 24 insertions(+), 1 deletion(-) diff --git a/target/s390x/insn-data.def b/target/s390x/insn-data.def index 075ff59..e427988 100644 --- a

[Qemu-devel] [PATCH 06/24] qapi: Factor out common part of qobject input visitor creation

2017-02-27 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- qapi/qobject-input-visitor.c | 61 +++- 1 file changed, 26 insertions(+), 35 deletions(-) diff --git a/qapi/qobject-input-visitor.c b/qapi/qobject-input-visitor.c index d53bad3..e47615e 100644 --- a/qapi/qobject-input-v

[Qemu-devel] [PATCH 22/24] qapi: New parse_qapi_name()

2017-02-27 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- include/qapi/util.h| 2 ++ qapi/qapi-util.c | 47 +++ tests/test-qapi-util.c | 34 ++ 3 files changed, 83 insertions(+) diff --git a/include/qapi/util.h b/include/qapi/util

[Qemu-devel] [PATCH 03/24] keyval: New keyval_parse()

2017-02-27 Thread Markus Armbruster
keyval_parse() parses KEY=VALUE,... into a QDict. Works like qemu_opts_parse(), except: * Returns a QDict instead of a QemuOpts (d'oh). * Supports nesting, unlike QemuOpts: a KEY is split into key fragments at '.' (dotted key convention; the block layer does something similar on top of QemuO

Re: [Qemu-devel] [PATCH v8 0/2] docs: Improve sample configuration files

2017-02-27 Thread Andrea Bolognani
On Fri, 2017-02-17 at 11:14 +0100, Andrea Bolognani wrote: [...] > Andrea Bolognani (2): >   q35: Improve sample configuration files >   mach-virt: Provide sample configuration files >  >  docs/mach-virt-graphical.cfg  | 281 + >  docs/mach-virt-serial.cfg

[Qemu-devel] [PATCH 18/24] block: Initial implementation of -blockdev

2017-02-27 Thread Markus Armbruster
The new command line option -blockdev works like QMP command blockdev-add. The option argument may be given in JSON syntax, exactly as in QMP. Example usage: -blockdev '{"node-name": "foo", "driver": "raw", "file": {"driver": "file", "filename": "foo.img"} }' The JSON argument doesn't exact

[Qemu-devel] [PATCH 04/24] qapi: qobject input visitor variant for use with keyval_parse()

2017-02-27 Thread Markus Armbruster
From: "Daniel P. Berrange" Currently the QObjectInputVisitor assumes that all scalar values are directly represented as the final types declared by the thing being visited. i.e. it assumes an 'int' is using QInt, and a 'bool' is using QBool, etc. This is good when QObjectInputVisitor is fed a QO

Re: [Qemu-devel] [PATCH v2 00/16] Postcopy: Hugepage support

2017-02-27 Thread Dr. David Alan Gilbert
* Alexey Perevalov (a.pereva...@samsung.com) wrote: > Hi David, > > > On Tue, Feb 21, 2017 at 10:03:14AM +, Dr. David Alan Gilbert wrote: > > * Alexey Perevalov (a.pereva...@samsung.com) wrote: > > > > > > Hello David, > > > > Hi Alexey, > > > > > On Tue, Feb 14, 2017 at 07:34:26PM +,

Re: [Qemu-devel] [PATCH] null-machine: Add support for the "-kernel" parameter

2017-02-27 Thread Thomas Huth
On 25.01.2017 09:40, Thomas Huth wrote: > We can have basic support for the "-kernel" parameter quite easily > by using the generic loader device. This should be enough for most > boards which do not need special machine-specific magic for loading > a kernel (and for those that need special magic,

[Qemu-devel] [PATCH 24/24] keyval: Support lists

2017-02-27 Thread Markus Armbruster
Additionally permit non-negative integers as key components. A dictionary's keys must either be all integers or none. If all keys are integers, convert the dictionary to a list. The set of keys must be [0,N]. Examples: * list.1=goner,list.0=null,list.1=eins,list.2=zwei is equivalent to JSON

Re: [Qemu-devel] [PATCH v2 3/5] s390x/ipl: Load network boot image

2017-02-27 Thread Cornelia Huck
On Sat, 25 Feb 2017 07:18:29 +0100 Thomas Huth wrote: > On 23.02.2017 13:20, Cornelia Huck wrote: > > From: Farhan Ali > > > > Load the network boot image into guest RAM when the boot > > device selected is a network device. Use some of the reserved > > space in IplBlockCcw to store the start a

Re: [Qemu-devel] [PATCH] Removed support for depth!=32

2017-02-27 Thread Gerd Hoffmann
Hi, > (Gerd: can you remind me of the reason why we can assume that > depth is always 32 here? IIRC it's because the UI layer always > uses 32 bit depth now but I couldn't convince myself of that > with a quick look through the ui code...) qemu-allocated display surfaces (backed by host memory)

Re: [Qemu-devel] [PATCH v2 3/5] s390x/ipl: Load network boot image

2017-02-27 Thread Thomas Huth
On 27.02.2017 12:51, Cornelia Huck wrote: > On Sat, 25 Feb 2017 07:18:29 +0100 > Thomas Huth wrote: > >> On 23.02.2017 13:20, Cornelia Huck wrote: >>> From: Farhan Ali >>> >>> Load the network boot image into guest RAM when the boot >>> device selected is a network device. Use some of the reserv

Re: [Qemu-devel] [PATCH v3 0/4] bcm2835: add sdhost and gpio controllers

2017-02-27 Thread Peter Maydell
On 24 February 2017 at 16:40, Clement Deschamps wrote: > This patches add the Arasan SDHost controller and the GPIO controller to the > BCM2835/36 platforms. > > This patches have been tested with raspbian 2015-09-24 (which uses the SDHCI > controller), > and raspbian 2017-01-11 (which dynamical

Re: [Qemu-devel] [PATCH] tests-aio-multithread: use atomic_read properly

2017-02-27 Thread Greg Kurz
On Mon, 27 Feb 2017 12:17:26 +0100 Paolo Bonzini wrote: > nodes[id].next is written by other threads. If atomic_read is not used > (matching atomic_set in mcs_mutex_lock!) the compiler can optimize the > whole "if" away! > > Reported-by: Alex Bennée > Signed-off-by: Paolo Bonzini > --- Cool

Re: [Qemu-devel] [PATCH 1/3] block: implement bdrv_snapshot_goto for blkreplay

2017-02-27 Thread Pavel Dovgalyuk
> From: Kevin Wolf [mailto:kw...@redhat.com] > Am 31.01.2017 um 12:57 hat Pavel Dovgalyuk geschrieben: > > This patch enables making snapshots with blkreplay used in > > block devices. > > > > Signed-off-by: Pavel Dovgalyuk > > Specifically, I think it avoids the blkreplay_open/close sequence. Is

Re: [Qemu-devel] [PATCH v2 1/5] elf-loader: Allow late loading of elf

2017-02-27 Thread Cornelia Huck
On Sat, 25 Feb 2017 07:05:27 +0100 Thomas Huth wrote: > On 23.02.2017 13:20, Cornelia Huck wrote: > > From: Farhan Ali > > > > The current QEMU ROM infrastructure rejects late loading of ROMs. > > And ELFs are currently loaded as ROM, this prevents delayed loading > > of ELFs. So when loading E

Re: [Qemu-devel] [PATCH v16 08/22] qcow2: add bitmaps extension

2017-02-27 Thread Max Reitz
On 25.02.2017 18:07, Vladimir Sementsov-Ogievskiy wrote: > Add bitmap extension as specified in docs/specs/qcow2.txt. > For now, just mirror extension header into Qcow2 state and check > constraints. Also, calculate refcounts for qcow2 bitmaps, to not break > qemu-img check. > > For now, disable i

Re: [Qemu-devel] [PATCH 15/54] block: Involve block drivers in permission granting

2017-02-27 Thread Kevin Wolf
Am 22.02.2017 um 15:04 hat Max Reitz geschrieben: > > @@ -1390,6 +1565,7 @@ BdrvChild *bdrv_root_attach_child(BlockDriverState > > *child_bs, > > > > ret = bdrv_check_update_perm(child_bs, perm, shared_perm, NULL, errp); > > if (ret < 0) { > > +bdrv_abort_perm_update(child_bs);

Re: [Qemu-devel] [PATCH 15/54] block: Involve block drivers in permission granting

2017-02-27 Thread Max Reitz
On 27.02.2017 13:28, Kevin Wolf wrote: > Am 22.02.2017 um 15:04 hat Max Reitz geschrieben: >>> @@ -1390,6 +1565,7 @@ BdrvChild *bdrv_root_attach_child(BlockDriverState >>> *child_bs, >>> >>> ret = bdrv_check_update_perm(child_bs, perm, shared_perm, NULL, errp); >>> if (ret < 0) { >>> +

Re: [Qemu-devel] [PATCH 18/54] block: Default .bdrv_child_perm() for format drivers

2017-02-27 Thread Kevin Wolf
Am 25.02.2017 um 12:57 hat Max Reitz geschrieben: > On 21.02.2017 15:58, Kevin Wolf wrote: > > Almost all format drivers have the same characteristics as far as > > permissions are concerned: They have one or more children for storing > > their own data and, more importantly, metadata (can be writt

Re: [Qemu-devel] Question regarding Snapshots

2017-02-27 Thread Kashyap Chamarthy
On Mon, Feb 27, 2017 at 11:01:06AM +, Stefan Hajnoczi wrote: > On Wed, Feb 22, 2017 at 03:06:41PM -0600, Tim Cusack wrote: > > I have a scenario that perhaps not many have attempted, but I still hope > > that it is possible. > > > > Scenario: > > > > I would like to have a Base Windows 7 VM i

Re: [Qemu-devel] [PATCH] nios2: iic: Convert CPU prop to qom link

2017-02-27 Thread Igor Mammedov
On Sun, 26 Feb 2017 17:48:15 +0100 Marek Vasut wrote: > Add a const qom link between the CPU and the IIC instead > of passing the CPU link through a qom property. > > Signed-off-by: Marek Vasut > Cc: Alexander Graf > Cc: Chris Wulff > Cc: Jeff Da Silva > Cc: Ley Foon Tan > Cc: Markus Armbru

Re: [Qemu-devel] [PATCH 18/54] block: Default .bdrv_child_perm() for format drivers

2017-02-27 Thread Max Reitz
On 27.02.2017 13:33, Kevin Wolf wrote: > Am 25.02.2017 um 12:57 hat Max Reitz geschrieben: >> On 21.02.2017 15:58, Kevin Wolf wrote: >>> Almost all format drivers have the same characteristics as far as >>> permissions are concerned: They have one or more children for storing >>> their own data and

Re: [Qemu-devel] [PULL 00/24] MTTCG Base enabling patches with ARM enablement

2017-02-27 Thread Paolo Bonzini
On 24/02/2017 12:20, Alex Bennée wrote: > The following changes since commit 2d896b454a0e19ec4c1ddbb0e0b65b7e54fcedf3: > > Revert "hw/mips: MIPS Boston board support" (2017-02-23 18:04:45 +) > > are available in the git repository at: > > https://github.com/stsquad/qemu.git tags/pull-mtt

Re: [Qemu-devel] [PATCH 37/43] spapr: reuse machine->possible_cpus instead of cores[]

2017-02-27 Thread Igor Mammedov
On Mon, 27 Feb 2017 09:46:43 +1100 David Gibson wrote: > On Fri, Feb 24, 2017 at 02:29:21PM +0100, Igor Mammedov wrote: > > On Sat, 25 Feb 2017 00:03:57 +1100 > > David Gibson wrote: > > > > > On Wed, Feb 22, 2017 at 12:05:55PM +0100, Igor Mammedov wrote: > > > > Replace SPAPR specific core

Re: [Qemu-devel] [PATCH v2 04/28] 9pfs: introduce openat_nofollow() helper

2017-02-27 Thread Stefan Hajnoczi
On Sun, Feb 26, 2017 at 11:42:03PM +0100, Greg Kurz wrote: > +int openat_nofollow(int dirfd, const char *path, int flags, mode_t mode) > +{ > +int fd; > + > +fd = dup(dirfd); > +if (fd == -1) { > +return -1; > +} > + > +while (*path) { > +const char *c; > +

[Qemu-devel] [PATCH 03/17] cpu-exec: remove unnecessary check of cpu->exit_request

2017-02-27 Thread Paolo Bonzini
The cpu->exit_request check in cpu_loop_exec_tb is unnecessary, because cpu->tcg_exit_req is always set after cpu->exit_request. So let the TB exit and we will pick up the exit request later in cpu_handle_interrupt. Signed-off-by: Paolo Bonzini --- cpu-exec.c | 4 1 file changed, 4 deletion

[Qemu-devel] [PATCH 01/17] cpu-exec: unify icount_decr and tcg_exit_req

2017-02-27 Thread Paolo Bonzini
The icount interrupt flag and tcg_exit_req serve almost the same purpose, let's make them completely the same. The former TB_EXIT_REQUESTED and TB_EXIT_ICOUNT_EXPIRED cases are unified, since we can distinguish them from the value of the interrupt flag. Signed-off-by: Paolo Bonzini --- cpu-exec

[Qemu-devel] [PATCH 02/17] replay: check icount in cpu exec loop

2017-02-27 Thread Paolo Bonzini
From: Pavel Dovgalyuk This patch adds check to break cpu loop when icount expires without setting the TB_EXIT_ICOUNT_EXPIRED flag. It happens when there is no available translated blocks and all instructions were executed. In icount replay mode unnecessary tb_find will be called (which may cause

[Qemu-devel] [PULL v2 00/17] KVM and cpu-exec patches for 2.9 soft freeze

2017-02-27 Thread Paolo Bonzini
The following changes since commit d992f2f1368ceb92e6bfd8efece174110f4236ff: Merge remote-tracking branch 'remotes/artyom/tags/pull-sun4v-20170226' into staging (2017-02-26 22:40:23 +) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you t

[Qemu-devel] [PATCH 09/17] KVM: remove kvm_arch_on_sigbus

2017-02-27 Thread Paolo Bonzini
Build it on kvm_arch_on_sigbus_vcpu instead. They do the same for "action optional" SIGBUSes, and the main thread should never get "action required" SIGBUSes because it blocks the signal. Signed-off-by: Paolo Bonzini --- include/sysemu/kvm.h | 1 - kvm-all.c| 9 - target/a

  1   2   3   4   5   6   >