> From: Kevin Wolf [mailto:kw...@redhat.com] > Am 31.01.2017 um 12:57 hat Pavel Dovgalyuk geschrieben: > > This patch enables making snapshots with blkreplay used in > > block devices. > > > > Signed-off-by: Pavel Dovgalyuk <pavel.dovga...@ispras.ru> > > Specifically, I think it avoids the blkreplay_open/close sequence. Is > this what is needed to make it work?
Then I'll need to implement bdrv_open, because there is only bdrv_file_open for blkreplay now. Which way is better? > We should probably mention in the commit message the exact reason why > implementing .bdrv_snapshot_goto, but not the other snapshot related > callbacks, fixes things. If you confirm my assumption, I can add that > while applying. Pavel Dovgalyuk