[Qemu-devel] [PATCH 12/14] tests: Don't check qobject_type() before qobject_to_qbool()

2017-02-17 Thread Markus Armbruster
qobject_to_qbool(obj) returns NULL when obj isn't a QBool. Check that instead of qobject_type(obj) == QTYPE_QBOOL. Signed-off-by: Markus Armbruster --- tests/check-qjson.c | 24 ++-- tests/test-qobject-output-visitor.c | 12 +--- 2 files changed, 11 i

[Qemu-devel] [PATCH 03/14] check-qdict: Tighten qdict_crumple_test_recursive() some

2017-02-17 Thread Markus Armbruster
Consistently check for unexpected QDict entries, and qdict_get_qdict() success. The latter doesn't tighten the test, it only makes it fail more nicely. Signed-off-by: Markus Armbruster --- tests/check-qdict.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/check-qdict.c b/tests/c

[Qemu-devel] [PULL 16/23] vfio: introduce vfio_get_vaddr()

2017-02-17 Thread Michael S. Tsirkin
From: Peter Xu A cleanup for vfio_iommu_map_notify(). Now we will fetch vaddr even if the operation is unmap, but it won't hurt much. One thing to mention is that we need the RCU read lock to protect the whole translation and map/unmap procedure. Acked-by: Alex Williamson Reviewed-by: David Gi

[Qemu-devel] [PATCH V2 6/7] introduce mmio_interface

2017-02-17 Thread fred . konrad
From: KONRAD Frederic This introduces mmio_interface object which contains a MemoryRegion and can be hotplugged/hotunplugged. Signed-off-by: KONRAD Frederic V1 -> V2: * Fix the qemu_log format. --- hw/misc/Makefile.objs| 1 + hw/misc/mmio_interface.c | 128

[Qemu-devel] [PATCH 11/14] tests: Don't check qobject_type() before qobject_to_qfloat()

2017-02-17 Thread Markus Armbruster
qobject_to_qfloat(obj) returns NULL when obj isn't a QFloat. Check that instead of qobject_type(obj) == QTYPE_QFLOAT. Signed-off-by: Markus Armbruster --- tests/check-qjson.c | 12 ++-- tests/test-qobject-output-visitor.c | 8 2 files changed, 6 insertions(+),

[Qemu-devel] [PATCH 08/14] tests: Don't check qobject_type() before qobject_to_qlist()

2017-02-17 Thread Markus Armbruster
qobject_to_qlist(obj) returns NULL when obj isn't a QList. Check that instead of qobject_type(obj) == QTYPE_QLIST. Signed-off-by: Markus Armbruster --- tests/test-qobject-output-visitor.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/tests/test-qobject-output-visito

Re: [Qemu-devel] [PATCH] Changing error message of QMP 'migrate_set_downtime' to seconds

2017-02-17 Thread Markus Armbruster
Eric Blake writes: > On 02/17/2017 01:01 PM, Daniel Henrique Barboza wrote: > 200)) { +(params->downtime_limit < 0 || + params->downtime_limit > MAX_MIGRATE_SET_DOWNTIME)) { error_setg(errp, QERR_INVALID_PARAMETER_VALUE,

[Qemu-devel] [PULL 18/23] intel_iommu: add "caching-mode" option

2017-02-17 Thread Michael S. Tsirkin
From: Aviv Ben-David This capability asks the guest to invalidate cache before each map operation. We can use this invalidation to trap map operations in the hypervisor. Signed-off-by: Aviv Ben-David [peterx: using "caching-mode" instead of "cache-mode" to align with spec] [peterx: re-write the

[Qemu-devel] [PATCH 02/14] check-qdict: Simplify qdict_crumple_test_recursive()

2017-02-17 Thread Markus Armbruster
Use qdict_get_qdict(), qdict_get_qlist() instead of qdict_get() followed by qobject_to_qdict(), qobject_to_qlist(). While there, drop some redundant code. Signed-off-by: Markus Armbruster --- tests/check-qdict.c | 25 + 1 file changed, 9 insertions(+), 16 deletions(-) d

[Qemu-devel] [PATCH 06/14] test-qmp-event: Simplify and tighten event_test_emit()

2017-02-17 Thread Markus Armbruster
Use qdict_get_qdict() and qdict_get_try_int() to simplify. While there, add a sanity check for seconds. Signed-off-by: Markus Armbruster --- tests/test-qmp-event.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/tests/test-qmp-event.c b/tests/test-qmp-event.c

[Qemu-devel] [PATCH 05/14] libqtest: Clean up qmp_response() a bit

2017-02-17 Thread Markus Armbruster
Use qobject_to_qdict() instead of a type cast. Signed-off-by: Markus Armbruster --- tests/libqtest.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/libqtest.c b/tests/libqtest.c index d8fba66..e54354d 100644 --- a/tests/libqtest.c +++ b/tests/libqtest.c @@ -379,9 +

[Qemu-devel] [PULL 19/23] intel_iommu: simplify irq region translation

2017-02-17 Thread Michael S. Tsirkin
From: Peter Xu Now we have a standalone memory region for MSI, all the irq region requests should be redirected there. Cleaning up the block with an assertion instead. Reviewed-by: Jason Wang Signed-off-by: Peter Xu Reviewed-by: David Gibson Reviewed-by: Michael S. Tsirkin Signed-off-by: Mic

Re: [Qemu-devel] [PATCH] tests: Use error_free_or_abort() where appropriate

2017-02-17 Thread Eric Blake
On 02/17/2017 02:15 PM, Markus Armbruster wrote: > Done with this Coccinelle semantic patch: > > @@ > expression E; > @@ > -g_assert(E); > -error_free(E); > +error_free_or_abort(&E); > > Signed-off-by: Markus Armbruster > --- > tests/test-qemu-opts.c

[Qemu-devel] [PATCH 01/14] qdict: Make qdict_get_qlist() safe like qdict_get_qdict()

2017-02-17 Thread Markus Armbruster
Commit 89cad9f changed qdict_get_qdict() to return NULL instead of crash when the key doesn't exist or its value isn't a QDict. Commit 2d6421a neglected to do the same for qdict_get_qlist(). Correct that, and update the function comments. qdict_get_obj() is now unused, remove. Signed-off-by: Mark

[Qemu-devel] [PULL 22/23] intel_iommu: convert dbg macros to trace for trans

2017-02-17 Thread Michael S. Tsirkin
From: Peter Xu Another patch to convert the DPRINTF() stuffs. This patch focuses on the address translation path and caching. Signed-off-by: Peter Xu Reviewed-by: Jason Wang Reviewed-by: David Gibson Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/intel_iommu.

[Qemu-devel] [PATCH 14/14] block: Don't bother asserting type of output visitor's output

2017-02-17 Thread Markus Armbruster
After a visit of a complex QAPI type FOO ov = qobject_output_visitor_new(&foo); visit_type_FOO(ov, NULL, expr, &error_abort); visit_complete(ov, &foo); we can safely assume qobject_type(foo) is QTYPE_QDICT. We do in many places, but occasionally assert qobject_type(obj) == QTYPE_QDIC

[Qemu-devel] [Bug 1665389] Re: Nested kvm guest fails to start on a emulated Westmere CPU guest under a Broadwell CPU host

2017-02-17 Thread Dr. David Alan Gilbert
kvm_msr_entry_add: @8 index=9e value=3 kvm_msr_entry_add: @9 index=d90 value=0 kvm_msr_entry_add: @10 index=c083 value=0 kvm_put_msrs: ret=9 expected=90 OK, 9... so that's probably the d90; $ ag d90: 418:#define MSR_IA32_BNDCFGS0x0d90 The Intel book s

Re: [Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-17 Thread Laszlo Ersek
On 02/17/17 19:34, Ben Warren wrote: > >> On Feb 17, 2017, at 8:03 AM, Laszlo Ersek > > wrote: >> >> On 02/17/17 16:33, Ben Warren wrote: >>> On Feb 17, 2017, at 2:43 AM, Igor Mammedov >>> > wrote: >>

[Qemu-devel] [PATCH 04/14] check-qjson: Simplify around compare_litqobj_to_qobj()

2017-02-17 Thread Markus Armbruster
Make compare_litqobj_to_qobj() cope with null, and drop non-null assertions from callers. compare_litqobj_to_qobj() already checks the QType matches; drop the redundant assertions from callers. Signed-off-by: Markus Armbruster --- tests/check-qjson.c | 22 +- 1 file changed,

Re: [Qemu-devel] [PATCH 14/24] util/cutils: New qemu_strtosz_metric()

2017-02-17 Thread Eric Blake
On 02/14/2017 04:26 AM, Markus Armbruster wrote: > To parse numbers with metric suffixes, we use > > qemu_strtosz_suffix_unit(nptr, &eptr, QEMU_STRTOSZ_DEFSUFFIX_B, 1000) > > Capture this in a new function for legibility: > > qemu_strtosz_metric(nptr, &eptr) > > Replace test_qemu_strtos

[Qemu-devel] [PATCH V2 0/7] execute code from mmio area

2017-02-17 Thread fred . konrad
From: KONRAD Frederic This series allows to execute code from mmio areas. The main goal of this is to be able to run code for example from an SPI device. The three first patch fixes the way get_page_addr_code fills the TLB. The fourth patch implements the mmio execution helpers: the device must

Re: [Qemu-devel] [PATCH 17/24] util/cutils: Drop QEMU_STRTOSZ_DEFSUFFIX_* macros

2017-02-17 Thread Eric Blake
On 02/14/2017 04:26 AM, Markus Armbruster wrote: > Writing QEMU_STRTOSZ_DEFSUFFIX_* instead of '*' gains nothing. Get > rid of these eyesores. > > Signed-off-by: Markus Armbruster > --- > util/cutils.c | 28 ++-- > 1 file changed, 10 insertions(+), 18 deletions(-) > > d

[Qemu-devel] [PATCH 09/14] tests: Don't check qobject_type() before qobject_to_qstring()

2017-02-17 Thread Markus Armbruster
qobject_to_qstring(obj) returns NULL when obj isn't a QString. Check that instead of qobject_type(obj) == QTYPE_QSTRING. Signed-off-by: Markus Armbruster --- tests/check-qjson.c | 31 --- tests/test-qobject-output-visitor.c | 37 +-

Re: [Qemu-devel] [PATCH 16/24] util/cutils: New qemu_strtosz()

2017-02-17 Thread Eric Blake
On 02/14/2017 04:26 AM, Markus Armbruster wrote: > Most callers of qemu_strtosz_suffix() pass QEMU_STRTOSZ_DEFSUFFIX_B. > Capture the pattern in new qemu_strtosz(). > > Inline qemu_strtosz_suffix() into its only remaining caller. > > Signed-off-by: Markus Armbruster > --- > +++ b/util/cutils.c

[Qemu-devel] [PATCH 07/14] Don't check qobject_type() before qobject_to_qdict()

2017-02-17 Thread Markus Armbruster
qobject_to_qdict(obj) returns NULL when obj isn't a QDict. Check that instead of qobject_type(obj) == QTYPE_QDICT. Signed-off-by: Markus Armbruster --- block.c | 4 ++-- hw/pci/pcie_aer.c | 2 +- monitor.c | 10 -

[Qemu-devel] [PATCH 13/14] monitor: Clean up handle_hmp_command() a bit

2017-02-17 Thread Markus Armbruster
Leave checking qobject_type(req) to qmp_check_input_obj(). Rework handling of json_parser_parse_err() failing without setting an error. Signed-off-by: Markus Armbruster --- monitor.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/monitor.c b/monitor.c index 493bed9

[Qemu-devel] [PATCH 00/14] qobject: Cleanups, mostly in tests

2017-02-17 Thread Markus Armbruster
Markus Armbruster (14): qdict: Make qdict_get_qlist() safe like qdict_get_qdict() check-qdict: Simplify qdict_crumple_test_recursive() check-qdict: Tighten qdict_crumple_test_recursive() some check-qjson: Simplify around compare_litqobj_to_qobj() libqtest: Clean up qmp_response() a bit

Re: [Qemu-devel] [PATCH 19/24] tests/test-cutils: Drop suffix from test_qemu_strtosz_simple()

2017-02-17 Thread Eric Blake
On 02/14/2017 04:26 AM, Markus Armbruster wrote: > Leave testing unit suffixes to test_qemu_strtosz_units(). > > Signed-off-by: Markus Armbruster > --- > tests/test-cutils.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > Reviewed-by: Eric Blake -- Eric Blake eblake redh

[Qemu-devel] [PATCH 10/14] tests: Don't check qobject_type() before qobject_to_qint()

2017-02-17 Thread Markus Armbruster
qobject_to_qint(obj) returns NULL when obj isn't a QInt. Check that instead of qobject_type(obj) == QTYPE_QINT. Signed-off-by: Markus Armbruster --- tests/check-qjson.c | 24 +--- tests/test-qobject-output-visitor.c | 28 2 files

[Qemu-devel] [PATCH] Add missing fp_access_check() to aarch64 crypto instructions

2017-02-17 Thread Nick Reilly
The aarch64 crypto instructions for AES and SHA are missing the check for if the FPU is enabled. Signed-off-by: Nick Reilly --- target/arm/translate-a64.c | 12 1 file changed, 12 insertions(+) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index e61bbd6..8105

Re: [Qemu-devel] [PATCH 20/24] qemu-img: Wrap cvtnum() around qemu_strtosz()

2017-02-17 Thread Eric Blake
On 02/14/2017 04:26 AM, Markus Armbruster wrote: > Cc: Kevin Wolf > Cc: Max Reitz > Cc: qemu-bl...@nongnu.org > Signed-off-by: Markus Armbruster > --- > qemu-img.c | 58 +++--- > 1 file changed, 31 insertions(+), 27 deletions(-) > @@ -3858,1

Re: [Qemu-devel] [PATCH 15/24] util/cutils: Rename qemu_strtosz() to qemu_strtosz_mebi()

2017-02-17 Thread Eric Blake
On 02/14/2017 04:26 AM, Markus Armbruster wrote: > With qemu_strtosz(), no suffix means mebibytes. It's used rarely. > I'm going to add a similar function where no suffix means bytes. > Rename qemu_strtosz() to qemu_strtosz_mebi() to make the name > qemu_strtosz() available for the new function. >

Re: [Qemu-devel] [PATCH 21/24] util/cutils: Let qemu_strtosz*() optionally reject trailing crap

2017-02-17 Thread Eric Blake
On 02/14/2017 04:26 AM, Markus Armbruster wrote: > Change the qemu_strtosz() & friends to return -EINVAL when @endptr is > null and the conversion doesn't consume the string completely. > Matches how qemu_strtol() & friends work. > > Only test_qemu_strtosz_simple() passes a null @endptr. No funct

Re: [Qemu-devel] [PATCH 18/24] tests/test-cutils: Use qemu_strtosz() more often

2017-02-17 Thread Eric Blake
On 02/14/2017 04:26 AM, Markus Armbruster wrote: > Use qemu_strtosz() instead of qemu_strtosz_mebi() where it doesn't > really make a difference. Rebase churn to Paolo's naming suggestion on 15/24, but that shouldn't stop you from adding: Reviewed-by: Eric Blake > > Signed-off-by: Markus Armbr

[Qemu-devel] [PATCH] ARM i.MX timers: fix software reset

2017-02-17 Thread Kurban Mallachiev
Hello! i.MX6 RM says that setting software reset bit in CR register of GPT (general purpose timers) should resets all of the registers of GPT to their default reset values, except for the CLKSRC, EN, ENMOD, STOPEN, WAITEN, and DBGEN bits in CR. But current implementation does the opposite for

[Qemu-devel] [PATCH v3] linux-user: Add sockopts for IPv6 ping and IPv6 traceroute

2017-02-17 Thread Helge Deller
Add the neccessary sockopts for ping and traceroute on IPv6. This fixes the following qemu warnings with IPv6: Unsupported ancillary data: 0/2 Unsupported ancillary data: 0/11 Unsupported ancillary data: 41/25 Unsupported setsockopt level=0 optname=12 Unsupported setsockopt level=41 optname=16 Un

Re: [Qemu-devel] [PATCH v2 0/7] iscsi: Add blockdev-add support

2017-02-17 Thread Jeff Cody
On Wed, Jan 25, 2017 at 12:42:01PM -0500, Jeff Cody wrote: > This adds blockdev-add support to the iscsi block driver. > > Picked this series up from Kevin. I've tested it on my local iscsi setup. > > There are only a few minor changes: > > * In patch 2, fixed the segfault pointed out by Daniel

Re: [Qemu-devel] [PATCH v3] linux-user: Add sockopts for IPv6 ping and IPv6 traceroute

2017-02-17 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v3] linux-user: Add sockopts for IPv6 ping and IPv6 traceroute Message-id: 20170217210831.ga26...@ls3530.fritz.box === TEST SCRIPT BEGIN === #!/bin/bash BA

Re: [Qemu-devel] [PATCH 1/2] block/nfs: convert to preadv / pwritev

2017-02-17 Thread Jeff Cody
On Fri, Feb 17, 2017 at 05:39:00PM +0100, Peter Lieven wrote: > Signed-off-by: Peter Lieven > --- > block/nfs.c | 33 +++-- > 1 file changed, 15 insertions(+), 18 deletions(-) > > diff --git a/block/nfs.c b/block/nfs.c > index 689eaa7..ab5dcc2 100644 > --- a/block/nfs

Re: [Qemu-devel] [PATCH 2/2] block/nfs: try to avoid the bounce buffer in pwritev

2017-02-17 Thread Jeff Cody
On Fri, Feb 17, 2017 at 05:39:01PM +0100, Peter Lieven wrote: > if the passed qiov contains exactly one iov we can > pass the buffer directly. > > Signed-off-by: Peter Lieven > --- > block/nfs.c | 23 --- > 1 file changed, 16 insertions(+), 7 deletions(-) > > diff --git a/bl

Re: [Qemu-devel] [PATCH v2 6/7] iscsi: Add blockdev-add support

2017-02-17 Thread Eric Blake
On 01/25/2017 11:42 AM, Jeff Cody wrote: > From: Kevin Wolf > > This adds blockdev-add support for iscsi devices. > > Reviewed-by: Daniel P. Berrange > Signed-off-by: Kevin Wolf > Signed-off-by: Jeff Cody > --- > block/iscsi.c| 14 ++ > qapi/block-core.json | 74 > ++

[Qemu-devel] [Bug 1665789] [NEW] More resolutions for vga displays

2017-02-17 Thread Phil Troy
Public bug reported: Would it be possible to add more resolutions for vga displays (which I am accessing via vnc instead of spice)? In particular: - 1080 wide x 1920 high (rotate 1920 x 1080 screen) - 1920 wide x 1080 + 1980 high (1920 x 1080 screen on top of 1600 x 900 screen) ** Affects: qem

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-02-17 Thread Jeff Cody
On Thu, Feb 16, 2017 at 02:24:19PM -0800, ashish mittal wrote: > Hi, > > I am getting the following error with checkpatch.pl > > ERROR: externs should be avoided in .c files > #78: FILE: block/vxhs.c:28: > +QemuUUID qemu_uuid __attribute__ ((weak)); > > Is there any way to get around this, or do

Re: [Qemu-devel] [PATCH 2/2] block/nfs: try to avoid the bounce buffer in pwritev

2017-02-17 Thread Eric Blake
On 02/17/2017 03:37 PM, Jeff Cody wrote: > On Fri, Feb 17, 2017 at 05:39:01PM +0100, Peter Lieven wrote: >> if the passed qiov contains exactly one iov we can >> pass the buffer directly. >> >> Signed-off-by: Peter Lieven >> --- >> block/nfs.c | 23 --- >> 1 file changed, 16 i

[Qemu-devel] [Bug 1665791] [NEW] Multiple displays each attached to a separate vnc connection

2017-02-17 Thread Phil Troy
Public bug reported: Would it be possible to create two displays in qemu (for windows 10) with each accessible by a separate vnc connection? I think this already exists for spice (and I would like it because vnc works better for me than does spice) ** Affects: qemu Importance: Undecided

Re: [Qemu-devel] [PATCH v2 6/7] iscsi: Add blockdev-add support

2017-02-17 Thread Jeff Cody
On Fri, Feb 17, 2017 at 03:40:21PM -0600, Eric Blake wrote: > On 01/25/2017 11:42 AM, Jeff Cody wrote: > > From: Kevin Wolf > > > > This adds blockdev-add support for iscsi devices. > > > > Reviewed-by: Daniel P. Berrange > > Signed-off-by: Kevin Wolf > > Signed-off-by: Jeff Cody > > --- > >

Re: [Qemu-devel] [PATCH 2/2] block/nfs: try to avoid the bounce buffer in pwritev

2017-02-17 Thread Jeff Cody
On Fri, Feb 17, 2017 at 03:42:52PM -0600, Eric Blake wrote: > On 02/17/2017 03:37 PM, Jeff Cody wrote: > > On Fri, Feb 17, 2017 at 05:39:01PM +0100, Peter Lieven wrote: > >> if the passed qiov contains exactly one iov we can > >> pass the buffer directly. > >> > >> Signed-off-by: Peter Lieven > >>

Re: [Qemu-devel] [PATCH v4 4/4] sd: sdhci: Remove block count enable check in single block transfers

2017-02-17 Thread Alistair Francis
On Tue, Feb 14, 2017 at 10:52 AM, P J P wrote: > From: Prasad J Pandit > > In SDHCI protocol, the 'Block count enable' bit of the Transfer > Mode register is relevant only in multi block transfers. We need > not check it in single block transfers. > > Signed-off-by: Prasad J Pandit Reviewed-by:

Re: [Qemu-devel] [PATCH v4 0/4] sd: sdhci: correct transfer mode register usage

2017-02-17 Thread Alistair Francis
On Fri, Feb 17, 2017 at 5:21 AM, Peter Maydell wrote: > On 14 February 2017 at 18:52, P J P wrote: >> From: Prasad J Pandit >> >> Hello, >> >> In SDHCI protocol, the 'Block Count Enable' bit of the Transfer Mode >> register is used to control 's->blkcnt' value. This bit is not relevant >> in sin

Re: [Qemu-devel] [PATCH 22/24] util/cutils: Return qemu_strtosz*() error and value separately

2017-02-17 Thread Eric Blake
On 02/14/2017 04:26 AM, Markus Armbruster wrote: > This makes qemu_strtosz(), qemu_strtosz_mebi() and > qemu_strtosz_metric() similar to qemu_strtoi64(), except negative > values are rejected. Yay. It also opens the door to allowing them to return an unsigned 64 bit value ;) > > Cc: Dr. David Al

Re: [Qemu-devel] [PATCH 23/24] util/cutils: Change qemu_strtosz*() from int64_t to uint64_t

2017-02-17 Thread Eric Blake
On 02/14/2017 04:26 AM, Markus Armbruster wrote: > This will permit its use in parse_option_size(). Progress! (not that it matters - off_t is a signed value, so you are STILL limited to 2^63, not 2^64, as the maximum theoretical size storage that you can target - and it's not like we have that mu

Re: [Qemu-devel] [PATCH 24/24] QemuOpts: Fix checking of sizes for overflow and trailing crap

2017-02-17 Thread Eric Blake
On 02/14/2017 04:26 AM, Markus Armbruster wrote: > parse_option_size()'s checking for overflow and trailing crap is > wrong. Has always been that way. qemu_strtosz() gets it right, so > use that. > > This adds support for size suffixes 'P', 'E', and ignores case for all > suffixes, not just 'k'.

Re: [Qemu-devel] [PATCH 01/14] qdict: Make qdict_get_qlist() safe like qdict_get_qdict()

2017-02-17 Thread Eric Blake
On 02/17/2017 02:38 PM, Markus Armbruster wrote: > Commit 89cad9f changed qdict_get_qdict() to return NULL instead of > crash when the key doesn't exist or its value isn't a QDict. > Commit 2d6421a neglected to do the same for qdict_get_qlist(). > Correct that, and update the function comments. >

Re: [Qemu-devel] [PATCH 02/14] check-qdict: Simplify qdict_crumple_test_recursive()

2017-02-17 Thread Eric Blake
On 02/17/2017 02:38 PM, Markus Armbruster wrote: > Use qdict_get_qdict(), qdict_get_qlist() instead of qdict_get() > followed by qobject_to_qdict(), qobject_to_qlist(). Worth a Coccinelle script to make sure we catch it all? > > While there, drop some redundant code. > > Signed-off-by: Markus A

[Qemu-devel] [Bug 1490611] Re: Using qemu >=2.2.1 to convert raw->VHD (fixed) adds extra padding to the result file, which Microsoft Azure rejects as invalid

2017-02-17 Thread Nish Aravamudan
Hello Alexandre, Yes, sorry, there have been several qemu SRUs pending and this one kept getting pushed back. Note that as far as end-users are concerned wrt. qemu, 16.04.2 is not really a relevant milestone. You'd still need to `apt update; apt upgrade` to get the latest from the repositories --

Re: [Qemu-devel] [PATCH] linux-user: fix fork()

2017-02-17 Thread Philippe Mathieu-Daudé
On 02/16/2017 02:37 PM, Laurent Vivier wrote: Since commit 5ea2fc8 ("linux-user: Sanity check clone flags"), trying to run fork() fails with old distro on some architectures. This is the case with HP-PA and Debian 5 (Lenny). It fails on: if ((flags & CSIGNAL) != TARGET_SIGCHLD) {

Re: [Qemu-devel] [Qemu-trivial] [PATCH] lm32: milkymist-tmu2: fix a third integer overflow

2017-02-17 Thread Philippe Mathieu-Daudé
On 02/16/2017 02:26 PM, Peter Maydell wrote: Don't truncate the multiplication and do a 64 bit one instead because the result is stored in a 64 bit variable. This fixes a similar coverity warning to commits 237a8650d640 and 4382fa655498, in a similar way, and is the final third of the fix for co

Re: [Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-17 Thread Ben Warren
> On Feb 17, 2017, at 12:07 PM, Laszlo Ersek wrote: > > On 02/17/17 17:03, Laszlo Ersek wrote: >> On 02/17/17 16:33, Ben Warren wrote: >>> On Feb 17, 2017, at 2:43 AM, Igor Mammedov >>> > wrote: On Thu, 16 Feb 2017 15:15:36 -0800 b...@skyportsyst

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-02-17 Thread Ketan Nilangekar
On 2/17/17, 1:42 PM, "Jeff Cody" wrote: On Thu, Feb 16, 2017 at 02:24:19PM -0800, ashish mittal wrote: > Hi, > > I am getting the following error with checkpatch.pl > > ERROR: externs should be avoided in .c files > #78: FILE: block/vxhs.c:28: > +QemuUUID qemu_uu

[Qemu-devel] [Bug 1665791] Re: Multiple displays each attached to a separate vnc connection

2017-02-17 Thread pranith
Questions like this are better directed to the mailing list. Please email qemu-disc...@nongnu.org and/or qemu-devel@nongnu.org. Thanks! ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [Bug 697510] Re: Machine shut off after tons of lsi_scsi: error: MSG IN data too long

2017-02-17 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/697510 Title: Machine shut

[Qemu-devel] [Bug 682360] Re: Unaccessible memory

2017-02-17 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/682360 Title: Unaccessible

[Qemu-devel] [Bug 682326] Re: linux-user/mmap exhaustion

2017-02-17 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/682326 Title: linux-user/m

[Qemu-devel] [Bug 597575] Re: Hangs on HTTP errors when using the curl block driver

2017-02-17 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/597575 Title: Hangs on HTT

<    1   2   3