On 02/14/2017 04:26 AM, Markus Armbruster wrote: > Most callers of qemu_strtosz_suffix() pass QEMU_STRTOSZ_DEFSUFFIX_B. > Capture the pattern in new qemu_strtosz(). > > Inline qemu_strtosz_suffix() into its only remaining caller. > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > ---
> +++ b/util/cutils.c > @@ -178,6 +178,14 @@ int fcntl_setfl(int fd, int flag) > } > #endif > > +#define QEMU_STRTOSZ_DEFSUFFIX_EB 'E' > +#define QEMU_STRTOSZ_DEFSUFFIX_PB 'P' > +#define QEMU_STRTOSZ_DEFSUFFIX_TB 'T' > +#define QEMU_STRTOSZ_DEFSUFFIX_GB 'G' > +#define QEMU_STRTOSZ_DEFSUFFIX_MB 'M' > +#define QEMU_STRTOSZ_DEFSUFFIX_KB 'K' > +#define QEMU_STRTOSZ_DEFSUFFIX_B 'B' 5/7 of these #defines are useless, now that all callers are limited to file scope. With that cleaned up, Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
