Re: [Qemu-devel] [PATCH v3 02/16] softloat: disable floatx80_invalid_encoding() for m68k

2017-02-09 Thread Laurent Vivier
Le 08/02/2017 à 23:58, Peter Maydell a écrit : > On 7 February 2017 at 00:59, Laurent Vivier wrote: >> According to the comment, this definition of invalid encoding is given >> by intel developer's manual, and doesn't work with the behavior >> of 680x0 FPU. >> >> CC: Andreas Schwab >> Signed-off-

Re: [Qemu-devel] [PULL v2 00/13] target-arm queue

2017-02-09 Thread Peter Maydell
On 7 February 2017 at 19:45, Peter Maydell wrote: > A random mix of items here, nothing very major. v2 is just > squashing in the fix for the clang unused-function error. > > thanks > -- PMM > > > The following changes since commit d0dff238a87fa81393ed72754d4dc8b09e50b08b: > > Merge remote-track

[Qemu-devel] [PATCH] virtio: Report real progress in VQ aio poll handler

2017-02-09 Thread Fam Zheng
In virtio_queue_host_notifier_aio_poll, not all "!virtio_queue_empty()" cases are making true progress. Currently the offending one is virtio-scsi event queue, whose handler does nothing if no event is pending. As a result aio_poll() will spin on the "non-empty" VQ and take 100% host CPU. Fix thi

Re: [Qemu-devel] [PATCH v3 1/1] nios2: Add Altera JTAG UART emulation

2017-02-09 Thread Marek Vasut
On 02/09/2017 01:54 AM, Bystricky, Juro wrote: [...] >>> +static uint64_t altera_juart_read(void *opaque, hwaddr addr, unsigned >> int size) >>> +{ >>> +AlteraJUARTState *s = opaque; >>> +uint32_t r; >>> + >>> +addr >>= 2; >> >> Hm, how will unaligned read from one of these regist

Re: [Qemu-devel] [RFC] virtio-pci: Allow PCIe virtio devices on root bus

2017-02-09 Thread Laszlo Ersek
On 02/09/17 05:16, David Gibson wrote: > On Wed, Feb 08, 2017 at 11:40:50AM +0100, Laszlo Ersek wrote: >> On 02/08/17 07:16, David Gibson wrote: >>> Marcel, >>> >>> Your original patch adding PCIe support to virtio-pci.c has the >>> limitation noted below that PCIe won't be enabled if the device is

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-02-09 Thread ashish mittal
On Wed, Feb 8, 2017 at 10:29 PM, Jeff Cody wrote: > On Wed, Feb 08, 2017 at 09:23:33PM -0800, Ashish Mittal wrote: >> From: Ashish Mittal >> >> Source code for the qnio library that this code loads can be downloaded from: >> https://github.com/VeritasHyperScale/libqnio.git >> >> Sample command li

Re: [Qemu-devel] [PATCH v3 0/3] scsi-generic and BLKSECTGET

2017-02-09 Thread Paolo Bonzini
On 08/02/2017 23:33, Max Reitz wrote: > Noticed now that Paolo has already merged this. Well, then out it goes. > Too bad the swap of BDRV_REQUEST_MAX_BYTES and BDRV_REQUEST_MAX_SECTORS > is not in his tree. > > Well, I'll make it an own patch then. Sorry, that was by mistake. :( Paolo

Re: [Qemu-devel] [PATCH v5 2/2] mach-virt: Provide sample configuration files

2017-02-09 Thread Andrew Jones
Hi Andrea, Thanks for this! I see there's already been plenty of discussion and comments (you guys work too late...). I'll try to add my own couple of cents now too. On Wed, Feb 08, 2017 at 06:35:31PM +0100, Andrea Bolognani wrote: > These are very much like the sample configuration files > for

Re: [Qemu-devel] [PATCH v5 2/2] mach-virt: Provide sample configuration files

2017-02-09 Thread Andrew Jones
On Wed, Feb 08, 2017 at 07:11:42PM +0100, Laszlo Ersek wrote: > > +# RHEL: > > +# /usr/share/AAVMF/AAVMF_CODE.fd > > +# /usr/share/AAVMF/AAVMF_VARS.fd > > Looks legit. (Might want to call "RHEL" "RHELSA" though, in this context > -- no clue. Ask Drew :)) > The first choice "RHEL" is correct.

Re: [Qemu-devel] [PATCH v5 2/2] mach-virt: Provide sample configuration files

2017-02-09 Thread Peter Maydell
On 9 February 2017 at 09:42, Andrew Jones wrote: > I see Peter and you are discussing what to document here. IMO, > we should simply state -nodefaults provides us a base mach-virt > board with no peripherals. The thing about saying that is that it's not actually correct -- you get the UART, etc e

Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support

2017-02-09 Thread Igor Mammedov
On Wed, 8 Feb 2017 12:19:24 -0800 Ben Warren wrote: > Thanks for reviewing Igor. > > > On Feb 7, 2017, at 5:48 AM, Igor Mammedov wrote: > > > > On Sun, 5 Feb 2017 01:12:00 -0800 > > b...@skyportsystems.com wrote: > > > >> From: Ben Warren > >> > >> This imp

Re: [Qemu-devel] Question about add AF_ALG backend for virtio-crypto

2017-02-09 Thread Daniel P. Berrange
On Thu, Feb 09, 2017 at 10:58:55AM +0800, Longpeng (Mike) wrote: > Hi Daniel, > > On 2017/2/8 18:53, Daniel P. Berrange wrote: > > > On Wed, Feb 08, 2017 at 06:46:04PM +0800, Longpeng (Mike) wrote: > >> Hi Daniel, > >> > >> I was writing AF_ALG-backed for QEMU crypto these days, I think there're

Re: [Qemu-devel] virtio-scsi-pci iothread spins at 100%

2017-02-09 Thread Fam Zheng
On Wed, 02/08 19:44, Ed Swierk wrote: > On Wed, Feb 8, 2017 at 6:52 PM, Fam Zheng wrote: > > This means virtio-scsi event vq handler is returning true but actually no > > progress is made. Can you try the following patch to see if it's because a > > stalled cache of VQ index? > > > > diff --git a/

[Qemu-devel] [PATCH 6/6] target-ppc: add mcrxrx instruction

2017-02-09 Thread Nikunj A Dadhania
mcrxrx: Move to CR from XER Extended Signed-off-by: Nikunj A Dadhania --- target/ppc/translate.c | 24 1 file changed, 24 insertions(+) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index 724ad17..72c8a46 100644 --- a/target/ppc/translate.c +++ b/target/p

[Qemu-devel] [PATCH 0/6] POWER9 TCG enablements - part15

2017-02-09 Thread Nikunj A Dadhania
This series contains 6 new instructions for POWER9 ISA3.0 Nikunj A Dadhania (6): target-ppc: generate exception for copy/paste target-ppc: add slbieg instruction target-ppc: add slbsync implementation target-ppc: add wait instruction target-ppc: support for 32-bit carry and overflow ta

[Qemu-devel] [PATCH 5/6] target-ppc: support for 32-bit carry and overflow

2017-02-09 Thread Nikunj A Dadhania
POWER ISA 3.0 adds CA32 and OV32 status in 64-bit mode. Add the flags and corresponding defines. Moreover, CA32 is set when CA is set and OV32 is set when OV is set, there is no need to have a new fields in the CPUPPCState structure. Signed-off-by: Nikunj A Dadhania --- target/ppc/cpu.h |

[Qemu-devel] [PATCH 3/6] target-ppc: add slbsync implementation

2017-02-09 Thread Nikunj A Dadhania
slbsync: SLB Synchoronize The instruction provides an ordering function for the effects of all slbieg instructions executed by the thread executing the slbsync instruction. Signed-off-by: Nikunj A Dadhania --- target/ppc/translate.c | 12 1 file changed, 12 insertions(+) diff --gi

[Qemu-devel] [PATCH 4/6] target-ppc: add wait instruction

2017-02-09 Thread Nikunj A Dadhania
Use the available wait instruction implementation. Signed-off-by: Nikunj A Dadhania --- target/ppc/translate.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index b1a6aee..3ba2616 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate

[Qemu-devel] [PATCH 1/6] target-ppc: generate exception for copy/paste

2017-02-09 Thread Nikunj A Dadhania
Signed-off-by: Nikunj A Dadhania --- target/ppc/translate.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index 255735a..80f9f15 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate.c @@ -6132,6 +6132,19 @@ static in

Re: [Qemu-devel] [Qemu-arm] [PATCH] target-arm: Declare virtio-mmio as dma-coherent in dt

2017-02-09 Thread Ard Biesheuvel
(+Leif, Graeme) On 8 February 2017 at 18:23, Peter Maydell wrote: > On 8 February 2017 at 16:27, Ard Biesheuvel wrote: >> The _CCA property is mandatory on arm64, and there is no default. > > Is there a tool that can check this kind of requirement > and complain about issues in the ACPI tables (

Re: [Qemu-devel] [PULL 0/6] Migration pull

2017-02-09 Thread Peter Maydell
On 8 February 2017 at 08:47, Thomas Huth wrote: > How fast is that aarch64 machine? It's a juno board, so it's not very fast, but I wouldn't have expected it to hit a 100 second timeout assuming the test isn't trying to do a ludicrous amount of work. > The timeout of the prom-env test is > alrea

[Qemu-devel] [PATCH 2/6] target-ppc: add slbieg instruction

2017-02-09 Thread Nikunj A Dadhania
slbieg: SLB Invalidate Entry Global Signed-off-by: Nikunj A Dadhania --- target/ppc/helper.h | 1 + target/ppc/mmu-hash64.c | 16 ++-- target/ppc/translate.c | 14 ++ 3 files changed, 29 insertions(+), 2 deletions(-) diff --git a/target/ppc/helper.h b/target/ppc/he

Re: [Qemu-devel] [PATCH v5 2/2] mach-virt: Provide sample configuration files

2017-02-09 Thread Andrea Bolognani
On Thu, 2017-02-09 at 09:57 +, Peter Maydell wrote: > > I see Peter and you are discussing what to document here. IMO, > > we should simply state -nodefaults provides us a base mach-virt > > board with no peripherals. >  > The thing about saying that is that it's not actually > correct -- you g

Re: [Qemu-devel] [PATCH v5 2/2] mach-virt: Provide sample configuration files

2017-02-09 Thread Andrea Bolognani
On Thu, 2017-02-09 at 10:49 +0100, Andrew Jones wrote: > > > +# RHEL: > > > +#   /usr/share/AAVMF/AAVMF_CODE.fd > > > +#   /usr/share/AAVMF/AAVMF_VARS.fd > >  > > Looks legit. (Might want to call "RHEL" "RHELSA" though, in this context > > -- no clue. Ask Drew :)) >  > The first choice "RHEL" is co

Re: [Qemu-devel] Question about add AF_ALG backend for virtio-crypto

2017-02-09 Thread Longpeng (Mike)
Hi Daniel, On 2017/2/9 18:11, Daniel P. Berrange wrote: > On Thu, Feb 09, 2017 at 10:58:55AM +0800, Longpeng (Mike) wrote: >> Hi Daniel, >> >> So...you prefer approach 1 with a driver-table dispatch layer, right? >> And this implies that we must either rename some public methods in >> cipher-gc

[Qemu-devel] [PATCH 3/7] pc: calculate topology only once when possible_cpus is initialised

2017-02-09 Thread Igor Mammedov
Fill in CpuInstanceProperties once at board init time and just copy them whenever query_hotpluggable_cpus() is called. It will keep topology info always available without need to recalculate it every time it's needed. Considering it has NUMA node id, it will be used to keep NUMA node to cpu mapping

[Qemu-devel] [PATCH 0/7] pc/spapr: unify handling of possible CPUs

2017-02-09 Thread Igor Mammedov
Series is prerequsite split of from NUMA cpu mapping refactoring and includes only possible_cpus[] generalization to make it reusable for SPAPR and virt-arm targets as has been requested by Eduardo [1]. Since virt-arm doesn't support -device based CPUs, ARM patches are not included here and will

[Qemu-devel] [PATCH 4/7] pc: pass apic_id to pc_find_cpu_slot() directly so lookup could be done without CPU object

2017-02-09 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/i386/pc.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index f03a555..ec6dded 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -1783,12 +1783,11 @@ static int pc_apic_cmp(const void *a, const vo

[Qemu-devel] [PATCH 1/7] machine: move possible_cpus to MachineState

2017-02-09 Thread Igor Mammedov
so that it would be possible to reuse it with spapr/virt-aarch64 targets. Signed-off-by: Igor Mammedov --- include/hw/boards.h | 1 + include/hw/i386/pc.h | 1 - hw/i386/pc.c | 57 ++-- 3 files changed, 30 insertions(+), 29 deletions(-)

[Qemu-devel] [PATCH 2/7] pc: move pcms->possible_cpus init out of pc_cpus_init()

2017-02-09 Thread Igor Mammedov
possible_cpus could be initialized earlier then cpu objects, i.e. when -smp is parsed so move init code to possible_cpu_arch_ids() interface func and do initialization on the first call. it should help later with making -numa cpu/-smp parsing a machine state properties. Signed-off-by: Igor Mammed

[Qemu-devel] [PATCH 5/7] change CPUArchId.cpu type to Object*

2017-02-09 Thread Igor Mammedov
so it could be reused for SPAPR cores as well Signed-off-by: Igor Mammedov --- include/hw/boards.h | 2 +- hw/acpi/cpu.c | 2 +- hw/i386/pc.c| 8 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/include/hw/boards.h b/include/hw/boards.h index 4023b38..60209df

[Qemu-devel] [PATCH 7/7] machine: unify [pc_|spapr_]query_hotpluggable_cpus() callbacks

2017-02-09 Thread Igor Mammedov
All callbacks FOO_query_hotpluggable_cpus() are practically the same except of setting vcpus_count to different values. Convert them to a generic machine_query_hotpluggable_cpus() callback by moving vcpus_count initialization to per machine specific callback possible_cpu_arch_ids(). Signed-off-by:

[Qemu-devel] [PATCH 6/7] spapr: reuse machine->possible_cpus instead of cores[]

2017-02-09 Thread Igor Mammedov
Replace SPAPR specific cores[] array with generic machine->possible_cpus and store core objects there. It makes cores bookkeeping similar to x86 cpus and will allow to unify similar code. It would allow to replace cpu_index based NUMA node mapping with iproperty based one (for -device created cores

[Qemu-devel] [PATCH] hw/pci-host/prep: Do not use hw_error() in realize function

2017-02-09 Thread Thomas Huth
hw_error() is for CPU related errors only (it prints out a register dump and calls abort()), so we should not use it if we just failed to load the bios image. Apart from that, realize() functions should not exit directly but always set the errp with error_setg() in case of errors instead. Additiona

Re: [Qemu-devel] Question about add AF_ALG backend for virtio-crypto

2017-02-09 Thread Daniel P. Berrange
On Thu, Feb 09, 2017 at 07:03:57PM +0800, Longpeng (Mike) wrote: > Hi Daniel, > > On 2017/2/9 18:11, Daniel P. Berrange wrote: > > > On Thu, Feb 09, 2017 at 10:58:55AM +0800, Longpeng (Mike) wrote: > >> Hi Daniel, > > > >> > >> So...you prefer approach 1 with a driver-table dispatch layer, righ

[Qemu-devel] How can I exercise the CPU reset code for iMX boards?

2017-02-09 Thread Alex Bennée
Hi Jean-Christophe, As part of the MTTCG work I've been tweaking the reset handling code in imx6_src.c to handle the fact the reset is now asynchronous: https://github.com/stsquad/qemu/commit/ef8e78e7adccb8c881a1772ac01cd78c6b436de3 The only image I currently have is from Peter's image zoo w

Re: [Qemu-devel] [Qemu-block] [PATCH v3 04/18] qcow: require image size to be > 1 for new images

2017-02-09 Thread Alberto Garcia
On Wed 08 Feb 2017 08:29:27 PM CET, Eric Blake wrote: >> The qcow driver refuses to open images which are less than 2 bytes in >> size, but will happily create such images. Add a check in the create >> path to avoid this discrepancy. > > I agree that we have the 2-byte limit: [...] > But why 2 by

Re: [Qemu-devel] [Qemu-block] [PATCH v3 05/18] iotests: skip 042 with qcow which dosn't support zero sized images

2017-02-09 Thread Alberto Garcia
On Thu 26 Jan 2017 11:18:14 AM CET, Daniel P. Berrange wrote: > Test 042 is designed to verify operation with zero sized images. > Such images are not supported with qcow (v1), so this test has > always failed. > > Reviewed-by: Max Reitz > Signed-off-by: Daniel P. Berrange Reviewed-by: Alberto G

Re: [Qemu-devel] [PATCH qemu 1/2] exec, kvm, target-ppc: Move getrampagesize() to common code

2017-02-09 Thread Paolo Bonzini
On 09/02/2017 06:43, Alexey Kardashevskiy wrote: > On 03/01/17 10:34, David Gibson wrote: >> On Thu, Dec 22, 2016 at 04:22:11PM +1100, Alexey Kardashevskiy wrote: >>> getrampagesize() returns the largest supported page size and mainly >>> used to know if huge pages are enabled. >>> >>> However is

Re: [Qemu-devel] [Qemu-block] [PATCH v3 06/18] iotests: skip 048 with qcow which doesn't support resize

2017-02-09 Thread Alberto Garcia
On Thu 26 Jan 2017 11:18:15 AM CET, Daniel P. Berrange wrote: > Test 048 is designed to verify data preservation during an > image resize. The qcow (v1) format impl has never supported > resize so always fails. > > Reviewed-by: Max Reitz > Signed-off-by: Daniel P. Berrange Reviewed-by: Alberto G

[Qemu-devel] [PATCH] qemu-options: Fix broken sheepdog URL

2017-02-09 Thread Thomas Huth
The sheepdog URL is broken twice: First it uses a duplicated http:// prefix, second the website seems to have moved to https://sheepdog.github.io/sheepdog/ instead. Signed-off-by: Thomas Huth --- qemu-options.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-options.hx

Re: [Qemu-devel] [Help] Windows2012 as Guest 64+cores on KVM Halts

2017-02-09 Thread Yan Vugenfirer
Hi, First off all to use more than 64 CPUs on Windows you should use CPU grouping. Each group can contain maximum 64 CPUs. Here is a good article explaining possible configurations: https://msdn.microsoft.com/en-us/windows/hardware/drivers/devtest/boot-parameters-to-test-drivers-for-multiple-pro

Re: [Qemu-devel] [PATCH] target-arm: Declare virtio-mmio as dma-coherent in dt

2017-02-09 Thread Alexander Graf
On 08/02/2017 17:17, Laszlo Ersek wrote: On 02/08/17 17:12, Alexander Graf wrote: On 02/08/2017 04:29 PM, Laszlo Ersek wrote: CC'ing Ard and Shannon (I recall this property from earlier): On 02/08/17 14:31, Alexander Graf wrote: QEMU emulated hardware is always dma coherent with its guest.

Re: [Qemu-devel] [PATCH v5 2/2] mach-virt: Provide sample configuration files

2017-02-09 Thread Andrew Jones
On Thu, Feb 09, 2017 at 11:51:13AM +0100, Andrea Bolognani wrote: > On Thu, 2017-02-09 at 09:57 +, Peter Maydell wrote: > > > I see Peter and you are discussing what to document here. IMO, > > > we should simply state -nodefaults provides us a base mach-virt > > > board with no peripherals. > >

Re: [Qemu-devel] [PATCH] target-arm: Declare virtio-mmio as dma-coherent in dt

2017-02-09 Thread Alexander Graf
On 08/02/2017 17:17, Laszlo Ersek wrote: On 02/08/17 17:12, Alexander Graf wrote: On 02/08/2017 04:29 PM, Laszlo Ersek wrote: CC'ing Ard and Shannon (I recall this property from earlier): On 02/08/17 14:31, Alexander Graf wrote: QEMU emulated hardware is always dma coherent with its guest.

Re: [Qemu-devel] [PATCH] target-arm: Declare virtio-mmio as dma-coherent in dt

2017-02-09 Thread Ard Biesheuvel
On 9 February 2017 at 12:24, Alexander Graf wrote: > > > On 08/02/2017 17:17, Laszlo Ersek wrote: >> >> On 02/08/17 17:12, Alexander Graf wrote: >>> >>> On 02/08/2017 04:29 PM, Laszlo Ersek wrote: CC'ing Ard and Shannon (I recall this property from earlier): On 02/08/17 14:31,

Re: [Qemu-devel] [PATCH] target-arm: Declare virtio-mmio as dma-coherent in dt

2017-02-09 Thread Ard Biesheuvel
On 9 February 2017 at 12:29, Alexander Graf wrote: > > > On 08/02/2017 17:17, Laszlo Ersek wrote: >> >> On 02/08/17 17:12, Alexander Graf wrote: >>> >>> On 02/08/2017 04:29 PM, Laszlo Ersek wrote: CC'ing Ard and Shannon (I recall this property from earlier): On 02/08/17 14:31,

Re: [Qemu-devel] [PATCH] target-arm: Declare virtio-mmio as dma-coherent in dt

2017-02-09 Thread Andrew Jones
On Thu, Feb 09, 2017 at 01:24:02PM +0100, Alexander Graf wrote: > > > On 08/02/2017 17:17, Laszlo Ersek wrote: > > On 02/08/17 17:12, Alexander Graf wrote: > > > On 02/08/2017 04:29 PM, Laszlo Ersek wrote: > > > > CC'ing Ard and Shannon (I recall this property from earlier): > > > > > > > > On 0

Re: [Qemu-devel] [PATCH] target-arm: Declare virtio-mmio as dma-coherent in dt

2017-02-09 Thread Alexander Graf
On 09/02/2017 13:30, Ard Biesheuvel wrote: On 9 February 2017 at 12:24, Alexander Graf wrote: On 08/02/2017 17:17, Laszlo Ersek wrote: On 02/08/17 17:12, Alexander Graf wrote: On 02/08/2017 04:29 PM, Laszlo Ersek wrote: CC'ing Ard and Shannon (I recall this property from earlier): On

Re: [Qemu-devel] Call for GSoC 2017 mentors & project ideas

2017-02-09 Thread Peter Maydell
On 18 January 2017 at 10:52, Stefan Hajnoczi wrote: > QEMU will be applying to Google Summer of Code again this year. > > Do you want to help some of the most talented university students > begin contributing to open source by working on our codebase and > joining our community? > > We need to put

Re: [Qemu-devel] [virtio-dev] [PATCH v16 1/2] virtio-crypto: Add virtio crypto device specification

2017-02-09 Thread Cornelia Huck
On Wed, 8 Feb 2017 03:46:53 + "Gonglei (Arei)" wrote: > Hi Cornelia, > > > > > On Tue, 7 Feb 2017 12:39:44 +0100 > > Halil Pasic wrote: > > > > > On 01/18/2017 09:22 AM, Gonglei wrote: > > > > > +The following services are defined: > > > > + > > > > +\begin{lstlisting} > > > > +/* CIPHER

[Qemu-devel] [PATCH v2 0/4] target-arm: Add some omitted dma cache coherency flags

2017-02-09 Thread Alexander Graf
ARM is amazing when it comes to cache coherency and VMs. While any sane architecture allows the host to override the guest's caching attributes, that's very hard to do on ARM. That means that the guest may directly access guest memory bypassing the cache while QEMU happily writes to / reads from c

[Qemu-devel] [PATCH v2 2/4] hw/arm/virt: Declare virtio-mmio as dma cache coherent in ACPI

2017-02-09 Thread Alexander Graf
Virtio-mmio devices can directly access guest memory and do so in cache coherent fashion. Tell the guest about that fact when it's using ACPI. Signed-off-by: Alexander Graf --- hw/arm/virt-acpi-build.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acp

[Qemu-devel] [PATCH v2 3/4] hw/arm/virt: Declare fwcfg as dma cache coherent in ACPI

2017-02-09 Thread Alexander Graf
Fw-cfg recently learned how to directly access guest memory and does so in cache coherent fashion. Tell the guest about that fact when it's using ACPI. Signed-off-by: Alexander Graf --- hw/arm/virt-acpi-build.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm

[Qemu-devel] [PATCH v2 4/4] hw/arm/virt: Declare fwcfg as dma cache coherent in dt

2017-02-09 Thread Alexander Graf
Fw-cfg recently learned how to directly access guest memory and does so in cache coherent fashion. Tell the guest about that fact when it's using DT. Signed-off-by: Alexander Graf --- hw/arm/virt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 14881fa..d

[Qemu-devel] [PATCH v2 1/4] target-arm: Declare virtio-mmio as dma-coherent in dt

2017-02-09 Thread Alexander Graf
QEMU emulated hardware is always dma coherent with its guest. We do annotate that correctly on the PCI host controller, but left out virtio-mmio. Recent kernels have started to interpret that flag rather than take dma coherency as granted with virtio-mmio. While that is considered a kernel bug, as

[Qemu-devel] [PULL 01/10] ui/vnc: Drop unused vnc_has_job() and vnc_jobs_clear()

2017-02-09 Thread Gerd Hoffmann
From: Peter Maydell The functions vnc_has_job() and vnc_jobs_clear() are never used; remove them. Signed-off-by: Peter Maydell Reviewed-by: Gonglei Message-id: 1486146260-8092-1-git-send-email-peter.mayd...@linaro.org Signed-off-by: Gerd Hoffmann --- ui/vnc-jobs.c | 23 --

[Qemu-devel] [PULL 05/10] ui: refactor VncDisplay to allow multiple listening sockets

2017-02-09 Thread Gerd Hoffmann
From: "Daniel P. Berrange" Currently there is only a single listener for plain VNC and a single listener for websockets VNC. This means that if getaddrinfo() returns multiple IP addresses, for a hostname, the VNC server can only listen on one of them. This is just bearable if listening on wildcar

[Qemu-devel] [PULL 03/10] ui: fix regression handling bare 'websocket' option to -vnc

2017-02-09 Thread Gerd Hoffmann
From: "Daniel P. Berrange" The -vnc argument is documented as accepting two syntaxes for the 'websocket' option, either a bare option name, or a port number. If using the bare option name, it is supposed to apply the display number as an offset to base port 5700. e.g. -vnc localhost:3,websocke

[Qemu-devel] [PULL 07/10] ui: extract code to connect/listen from vnc_display_open

2017-02-09 Thread Gerd Hoffmann
From: "Daniel P. Berrange" The code which takes a SocketAddress and connects/listens on the network is going to get more complicated to deal with multiple listeners. Pull it out into a separate method to avoid making the vnc_display_open method even more complex. Reviewed-by: Eric Blake Signed-

[Qemu-devel] [PULL 06/10] ui: refactor code for populating SocketAddress from vnc_display_open

2017-02-09 Thread Gerd Hoffmann
From: "Daniel P. Berrange" The code which interprets the CLI args to populate the SocketAddress objects for plain & websockets VNC is quite complex already and will need further enhancements shortly. Refactor it into separate methods to avoid vnc_display_open getting even larger. As a side effect

[Qemu-devel] [PULL 00/10] vnc: add support for multiple listening sockets.

2017-02-09 Thread Gerd Hoffmann
-tracking branch 'remotes/juanquintela/tags/migration/20170206' into staging (2017-02-07 15:29:26 +) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-ui-20170209-1 for you to fetch changes up to 7448e761356799d4e445e6ea3891a8067233465d: ui: add

[Qemu-devel] [PULL 04/10] ui: fix reporting of VNC auth in query-vnc-servers

2017-02-09 Thread Gerd Hoffmann
From: "Daniel P. Berrange" Currently the VNC authentication info is emitted at the top level of the query-vnc-servers data. This is wrong because the authentication scheme differs between plain and websockets when TLS is enabled. We should instead report auth against the individual servers. e.g.

[Qemu-devel] [PULL 08/10] ui: let VNC server listen on all resolved IP addresses

2017-02-09 Thread Gerd Hoffmann
From: "Daniel P. Berrange" Remove the limitation that the VNC server can only listen on a single resolved IP address. This uses the new DNS resolver API to resolve a SocketAddress struct into an array of SocketAddress structs containing raw IP addresses. The VNC server will then attempt to listen

[Qemu-devel] [PATCH 2/2] Revert "cirrus: allow zero source pitch in pattern fill rops"

2017-02-09 Thread Gerd Hoffmann
This reverts commit 5858dd1801883309bdd208d72ddb81c4e9fee30c. Conflicts: hw/display/cirrus_vga.c Cc: Wolfgang Bumiller Cc: Dr. David Alan Gilbert Signed-off-by: Gerd Hoffmann --- hw/display/cirrus_vga.c | 26 -- 1 file changed, 8 insertions(+), 18 deletions(-)

[Qemu-devel] [PULL 10/10] ui: add ability to specify multiple VNC listen addresses

2017-02-09 Thread Gerd Hoffmann
From: "Daniel P. Berrange" This change allows the listen address and websocket address options for -vnc to be repeated. This causes the VNC server to listen on multiple addresses. e.g. $ $QEMU -vnc vnc=localhost:1,vnc=unix:/tmp/vnc,\ websocket=127.0.0.1:8080,websocket=[::]:8081 r

[Qemu-devel] [PULL 09/10] util: add iterators for QemuOpts values

2017-02-09 Thread Gerd Hoffmann
From: "Daniel P. Berrange" To iterate over all QemuOpts currently requires using a callback function which is inconvenient for control flow. Add support for using iterator functions more directly QemuOptsIter iter; QemuOpt *opt; qemu_opts_iter_init(&iter, opts, "repeated-key"); while ((

[Qemu-devel] [PULL 02/10] vnc: do not disconnect on EAGAIN

2017-02-09 Thread Gerd Hoffmann
From: Michael Tokarev When qemu vnc server is trying to send large update to clients, there might be a situation when system responds with something like EAGAIN, indicating that there's no system memory to send that much data (depending on the network speed, client and server and what is happenin

Re: [Qemu-devel] [Qemu-ppc] [PULL 0/6] Migration pull

2017-02-09 Thread Thomas Huth
On 09.02.2017 11:43, Peter Maydell wrote: > On 8 February 2017 at 08:47, Thomas Huth wrote: >> How fast is that aarch64 machine? > > It's a juno board, so it's not very fast, but I wouldn't > have expected it to hit a 100 second timeout assuming > the test isn't trying to do a ludicrous amount of

[Qemu-devel] [PATCH 1/2] cirrus: fix patterncopy checks

2017-02-09 Thread Gerd Hoffmann
The blit_region_is_unsafe checks don't work correctly for the patterncopy source. It's a fixed-sized region, which doesn't depend on cirrus_blt_{width,height}. So go do the check in cirrus_bitblt_common_patterncopy instead, then tell blit_is_unsafe that it doesn't need to verify the source. Also

Re: [Qemu-devel] [PULL 095/107] spapr: clock should count only if vm is running

2017-02-09 Thread Mark Cave-Ayland
On 07/02/17 15:46, Laurent Vivier wrote: >> If you do this enough times (maybe 10 or so?) you'll see the progress >> bars stop working correctly and get out of sync, i.e. it will freeze for >> long periods of time and then "jump" to catch-up but not all the way. >> >> With my above patch applied t

Re: [Qemu-devel] [PULL 00/10] vnc: add support for multiple listening sockets.

2017-02-09 Thread Peter Maydell
gt; > The following changes since commit d0dff238a87fa81393ed72754d4dc8b09e50b08b: > > Merge remote-tracking branch 'remotes/juanquintela/tags/migration/20170206' > into staging (2017-02-07 15:29:26 +) > > are available in the git repository at: > > >

Re: [Qemu-devel] [PATCH v2 0/4] target-arm: Add some omitted dma cache coherency flags

2017-02-09 Thread Laszlo Ersek
On 02/09/17 13:53, Alexander Graf wrote: > ARM is amazing when it comes to cache coherency and VMs. While any sane > architecture allows the host to override the guest's caching attributes, > that's very hard to do on ARM. > > That means that the guest may directly access guest memory bypassing th

Re: [Qemu-devel] [PATCH v2.1 10/21] target/arm: use vector opcode to handle vadd. instruction

2017-02-09 Thread Philippe Mathieu-Daudé
On 02/02/2017 11:34 AM, Kirill Batuzov wrote: Signed-off-by: Kirill Batuzov --- target/arm/translate.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/target/arm/translate.c b/target/arm/translate.c index d7578e2..90e14df 100644 --- a/target/arm/translate.

Re: [Qemu-devel] [PATCH v5 2/2] mach-virt: Provide sample configuration files

2017-02-09 Thread Andrea Bolognani
On Thu, 2017-02-09 at 10:42 +0100, Andrew Jones wrote: > > +[machine] > > +  type = "virt" > > +  accel = "kvm" > > + > > +[memory] > > +  size = "1024" >  > So I'm not sure about providing this, at least not in this > config file. I think we should expect the user to provide ram > size explicitly,

Re: [Qemu-devel] [Qemu-block] [PATCH v3 02/18] block: add ability to set a prefix for opt names

2017-02-09 Thread Alberto Garcia
On Thu 26 Jan 2017 11:18:11 AM CET, Daniel P. Berrange wrote: > When integrating the crypto support with qcow/qcow2, we don't > want to use the bare LUKS option names "hash-alg", "key-secret", > etc. We want to namespace them "luks-hash-alg", "luks-key-secret" > so that they don't clash with any ge

[Qemu-devel] [PATCH 1/4] aspeed: check for negative values returned by blk_getlength()

2017-02-09 Thread Cédric Le Goater
write_boot_rom() does not check for negative values. This is more a problem for coverity than the actual code as the size of the flash device is checked when the m25p80 object is created. If there is anything wrong with the backing file, we should not even reach that path. Signed-off-by: Cédric Le

[Qemu-devel] [PATCH 0/4] aspeed: miscellaneous small fixes

2017-02-09 Thread Cédric Le Goater
Hello, Here is a short series fixing small issues in the SMC controller model of the Aspeed SoC. Thanks, C. Cédric Le Goater (4): aspeed: check for negative values returned by blk_getlength() aspeed: remove useless comment on controller segment size aspeed/smc: handle dummies only in fas

[Qemu-devel] [PATCH 3/4] aspeed/smc: handle dummies only in fast read mode

2017-02-09 Thread Cédric Le Goater
HW works fine in normal read mode with dummy bytes being set. So let's check this case to not transfer bytes. Signed-off-by: Cédric Le Goater --- hw/ssi/aspeed_smc.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/ssi/aspeed_smc.c b/hw/ssi/aspeed_smc.c index 087b2

[Qemu-devel] [PATCH 2/4] aspeed: remove useless comment on controller segment size

2017-02-09 Thread Cédric Le Goater
The flash devices used for the FMC controller (BMC firmware) are well defined for each Aspeed machine and are all smaller than the default mapping window size, at least for CE0 which is the chip the SoC boots from. Signed-off-by: Cédric Le Goater --- hw/arm/aspeed.c | 8 +++- 1 file changed,

Re: [Qemu-devel] [PATCH v5 2/2] mach-virt: Provide sample configuration files

2017-02-09 Thread Andrea Bolognani
On Wed, 2017-02-08 at 19:36 +, Peter Maydell wrote: > > When -nodefaults is missing, a default virtio-net-pci > > plugged into 00:01.0 is automatically added. >  > Ah, right, default -net commands. Is that it? I believe so, but double checking is never the wrong thing to do ;) > > On the othe

[Qemu-devel] [PATCH 4/4] aspeed/smc: use a modulo to check segment limits

2017-02-09 Thread Cédric Le Goater
The size of a segment is not necessarily a power of 2. Signed-off-by: Cédric Le Goater --- hw/ssi/aspeed_smc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ssi/aspeed_smc.c b/hw/ssi/aspeed_smc.c index 70177078a8f2..cb515730c5ad 100644 --- a/hw/ssi/aspeed_smc.c +++ b

Re: [Qemu-devel] virtio-scsi-pci iothread spins at 100%

2017-02-09 Thread Ed Swierk
On Thu, Feb 9, 2017 at 2:12 AM, Fam Zheng wrote: > This should fix it: > > https://lists.gnu.org/archive/html/qemu-devel/2017-02/msg01874.html I tested this patch and found it fixes the problem. Thanks for the speedy response! --Ed

Re: [Qemu-devel] [PULL 00/10] vnc: add support for multiple listening sockets.

2017-02-09 Thread Daniel P. Berrange
ation/20170206' into staging (2017-02-07 > > 15:29:26 +) > > > > are available in the git repository at: > > > > > > git://git.kraxel.org/qemu tags/pull-ui-20170209-1 > > > > for you to fetch changes up to 7

Re: [Qemu-devel] [PATCH v5 2/2] mach-virt: Provide sample configuration files

2017-02-09 Thread Andrew Jones
On Thu, Feb 09, 2017 at 02:27:45PM +0100, Andrea Bolognani wrote: > On Thu, 2017-02-09 at 10:42 +0100, Andrew Jones wrote: > > > +[machine] > > > +  type = "virt" > > > +  accel = "kvm" > > > + > > > +[memory] > > > +  size = "1024" > >  > > So I'm not sure about providing this, at least not in thi

Re: [Qemu-devel] [PATCH 00/22] target/openrisc updates

2017-02-09 Thread G 3
On Feb 8, 2017, at 11:52 PM, qemu-devel-requ...@nongnu.org wrote: Message: 6 Date: Wed, 8 Feb 2017 20:51:32 -0800 From: Richard Henderson To: qemu-devel@nongnu.org Cc: sho...@gmail.com Subject: [Qemu-devel] [PATCH 00/22] target/openrisc updates Message-ID: <20170209045154.16868-1-...@twiddle.

[Qemu-devel] [PATCH] tests/prom-env: Ease time-out problems on slow hosts

2017-02-09 Thread Thomas Huth
Peter Maydell recently ran into time-out problems with the prom-env test on a rather slow ARM board. To tackle this issue, we can speed up the test by running QEMU with "-nodefaults" here, so that SLOF has less devices to scan during boot, and by using the "nvramrc" environment variable instead of

Re: [Qemu-devel] [PATCH v5 2/2] mach-virt: Provide sample configuration files

2017-02-09 Thread Andrew Jones
On Thu, Feb 09, 2017 at 02:53:52PM +0100, Andrea Bolognani wrote: > On Wed, 2017-02-08 at 19:36 +, Peter Maydell wrote: > > The trouble with using virtconsole is that you have to > > get quite a long way forward (probing and setting up > > PCI, etc) before you can get any kind of console output

Re: [Qemu-devel] virtio-scsi-pci iothread spins at 100%

2017-02-09 Thread Fam Zheng
On Thu, 02/09 05:52, Ed Swierk wrote: > On Thu, Feb 9, 2017 at 2:12 AM, Fam Zheng wrote: > > This should fix it: > > > > https://lists.gnu.org/archive/html/qemu-devel/2017-02/msg01874.html > > I tested this patch and found it fixes the problem. Thanks for the > speedy response! Thanks for the te

Re: [Qemu-devel] [PATCH] virtio: Report real progress in VQ aio poll handler

2017-02-09 Thread Ed Swierk
On Thu, Feb 9, 2017 at 12:40 AM, Fam Zheng wrote: > In virtio_queue_host_notifier_aio_poll, not all "!virtio_queue_empty()" > cases are making true progress. > > Currently the offending one is virtio-scsi event queue, whose handler > does nothing if no event is pending. As a result aio_poll() will

Re: [Qemu-devel] [Qemu-block] [PATCH v3 10/18] qcow2: make qcow2_encrypt_sectors encrypt in place

2017-02-09 Thread Alberto Garcia
On Thu 26 Jan 2017 11:18:19 AM CET, Daniel P. Berrange wrote: > Instead of requiring separate input/output buffers for > encrypting data, change qcow2_encrypt_sectors() to assume > use of a single buffer, encrypting in place. The current > callers all used the same buffer for input/output already.

Re: [Qemu-devel] [PATCH] qemu-options: Fix broken sheepdog URL

2017-02-09 Thread Jeff Cody
On Thu, Feb 09, 2017 at 01:10:18PM +0100, Thomas Huth wrote: > The sheepdog URL is broken twice: First it uses a duplicated > http:// prefix, second the website seems to have moved to > https://sheepdog.github.io/sheepdog/ instead. > > Signed-off-by: Thomas Huth > --- > qemu-options.hx | 2 +- >

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2017-02-09 Thread Jeff Cody
On Thu, Feb 09, 2017 at 01:24:58AM -0800, ashish mittal wrote: > On Wed, Feb 8, 2017 at 10:29 PM, Jeff Cody wrote: > > On Wed, Feb 08, 2017 at 09:23:33PM -0800, Ashish Mittal wrote: > >> From: Ashish Mittal > >> > >> Source code for the qnio library that this code loads can be downloaded > >> fr

Re: [Qemu-devel] [PULL 095/107] spapr: clock should count only if vm is running

2017-02-09 Thread Laurent Vivier
On 09/02/2017 14:11, Mark Cave-Ayland wrote: > On 07/02/17 15:46, Laurent Vivier wrote: > >>> If you do this enough times (maybe 10 or so?) you'll see the progress >>> bars stop working correctly and get out of sync, i.e. it will freeze for >>> long periods of time and then "jump" to catch-up but

Re: [Qemu-devel] [PATCH] tests/prom-env: Ease time-out problems on slow hosts

2017-02-09 Thread Peter Maydell
On 9 February 2017 at 14:13, Thomas Huth wrote: > Peter Maydell recently ran into time-out problems with the > prom-env test on a rather slow ARM board. To tackle this issue, > we can speed up the test by running QEMU with "-nodefaults" here, > so that SLOF has less devices to scan during boot, an

[Qemu-devel] kvm bug in __rmap_clear_dirty during live migration

2017-02-09 Thread Herongguang (Stephen)
Hi. I had a problem when I just repeatedly live migrate a vm between two compute nodes. The phenomenon was that the KVM module was crashed and then the host rebooted. However I cannot reliably trigger this BUG. The backtrace is the same as http://www.spinics.net/lists/kvm/msg138475.html. The cr

Re: [Qemu-devel] [PATCH 04/18] nbd/client: refactor nbd_receive_starttls

2017-02-09 Thread Eric Blake
On 02/09/2017 12:20 AM, Vladimir Sementsov-Ogievskiy wrote: > 07.02.2017 19:32, Eric Blake wrote: >> On 02/03/2017 09:47 AM, Vladimir Sementsov-Ogievskiy wrote: >>> Split out nbd_receive_simple_option to be reused for structured reply >>> option. >>> +return ""; >> Can you please consider maki

Re: [Qemu-devel] [PATCH v3 0/5] Improve I/O tests coverage of LUKS

2017-02-09 Thread Daniel P. Berrange
ping ? On Tue, Jan 24, 2017 at 11:57:43AM +, Daniel P. Berrange wrote: > The main goal of this series is to get the I/O tests passing > 100% with LUKS when run with './check -luks'. It also adds a > few more combinations to the LUKS/dmcrypt interoperability > test. > > To make LUKS testing no

Re: [Qemu-devel] [PATCH 1/2] cirrus: fix patterncopy checks

2017-02-09 Thread Dr. David Alan Gilbert
* Gerd Hoffmann (kra...@redhat.com) wrote: > The blit_region_is_unsafe checks don't work correctly for the > patterncopy source. It's a fixed-sized region, which doesn't > depend on cirrus_blt_{width,height}. So go do the check in > cirrus_bitblt_common_patterncopy instead, then tell blit_is_unsa

Re: [Qemu-devel] [PATCH 2/2] Revert "cirrus: allow zero source pitch in pattern fill rops"

2017-02-09 Thread Dr. David Alan Gilbert
* Gerd Hoffmann (kra...@redhat.com) wrote: > This reverts commit 5858dd1801883309bdd208d72ddb81c4e9fee30c. > > Conflicts: > hw/display/cirrus_vga.c > > Cc: Wolfgang Bumiller > Cc: Dr. David Alan Gilbert > Signed-off-by: Gerd Hoffmann Reviewed-by: Dr. David Alan Gilbert > --- > hw/dis

  1   2   3   4   >