On Tue, Feb 07, 2017 at 01:42:55PM +0800, Jason Wang wrote:
>
>
> On 2017年02月03日 16:22, Peter Xu wrote:
> >This helps in debugging incorrect level passed in.
> >
> >Signed-off-by: Peter Xu
> >---
> > hw/i386/intel_iommu.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> >diff --git a/hw/i386/int
float128_to_uint32_round_to_zero() is needed by xscvqpuwz instruction
of PowerPC ISA 3.0.
Signed-off-by: Bharata B Rao
---
fpu/softfloat.c | 28
include/fpu/softfloat.h | 1 +
2 files changed, 29 insertions(+)
diff --git a/fpu/softfloat.c b/fpu/softfloat.c
This series introduces two conversion routines:
float128_to_uint64_round_to_zero() and float128_to_uint32_round_to_zero().
float128_to_uint64_round_to_zero() uses the newly added
float128_to_uint64() whose implementation is based on float64_to_uint64().
float128_to_uint32_round_to_zero() uses fl
On Tue, Feb 07, 2017 at 02:10:45PM +0800, Jason Wang wrote:
>
>
> On 2017年02月03日 16:22, Peter Xu wrote:
> >+trace_vtd_replay_ce_valid(bus_n, PCI_SLOT(vtd_as->devfn),
> >+ PCI_FUNC(vtd_as->devfn),
> >+ VTD_CONTEXT_ENTRY_DID(
Implement float128_to_uint64() and use that to implement
float128_to_uint64_round_to_zero()
This is required by xscvqpudz instruction of PowerPC ISA 3.0.
Signed-off-by: Bharata B Rao
---
fpu/softfloat.c | 59 +
include/fpu/softfloat.h | 2
On Tue, Feb 07, 2017 at 02:16:15PM +0800, Jason Wang wrote:
>
>
> On 2017年02月03日 16:22, Peter Xu wrote:
> >Before this one we only invalidate context cache when we receive context
> >entry invalidations. However it's possible that the invalidation also
> >contains a domain switch (only if cache-m
On 2017/2/7 15:57, Jason Wang wrote:
On 2017年02月07日 15:54, Hailiang Zhang wrote:
Hi Jason,
On 2017/2/6 20:53, Jason Wang wrote:
On 2017年02月06日 19:11, Hailiang Zhang wrote:
On 2017/2/6 17:35, Jason Wang wrote:
On 2017年02月06日 16:13, Hailiang Zhang wrote:
On 2017/2/3 11:47, Jason Wang wr
This is v7 of vt-d vfio enablement series.
v7:
- for the two traces patches: Change subjects. Remove vtd_err() and
vtd_err_nonzero_rsvd() tracers, instead using standalone trace for
each of the places. Don't remove any DPRINTF() if there is no
replacement. [Jason]
- add r-b and a-b for Alex/
Now we have a standalone memory region for MSI, all the irq region
requests should be redirected there. Cleaning up the block with an
assertion instead.
Reviewed-by: Jason Wang
Signed-off-by: Peter Xu
---
hw/i386/intel_iommu.c | 28 ++--
1 file changed, 6 insertions(+),
A cleanup for vfio_iommu_map_notify(). Now we will fetch vaddr even if
the operation is unmap, but it won't hurt much.
One thing to mention is that we need the RCU read lock to protect the
whole translation and map/unmap procedure.
Acked-by: Alex Williamson
Reviewed-by: David Gibson
Signed-off-
The default replay() don't work for VT-d since vt-d will have a huge
default memory region which covers address range 0-(2^64-1). This will
normally consumes a lot of time (which looks like a dead loop).
The solution is simple - we don't walk over all the regions. Instead, we
jump over the regions
Another patch to convert the DPRINTF() stuffs. This patch focuses on the
address translation path and caching.
Signed-off-by: Peter Xu
---
hw/i386/intel_iommu.c | 69 ++-
hw/i386/trace-events | 10
2 files changed, 34 insertions(+), 45 de
We traces its range, but we don't know whether it's a MAP/UNMAP. Let's
dump it as well.
Acked-by: Alex Williamson
Reviewed-by: David Gibson
Signed-off-by: Peter Xu
---
hw/vfio/common.c | 3 ++-
hw/vfio/trace-events | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/v
Linux vfio driver supports to do VFIO_IOMMU_UNMAP_DMA for a very big
region. This can be leveraged by QEMU IOMMU implementation to cleanup
existing page mappings for an entire iova address space (by notifying
with an IOTLB with extremely huge addr_mask). However current
vfio_iommu_map_notify() does
There are lots of places in current intel_iommu.c codes that named
"iova" as "gpa". It is really confusing to use a name "gpa" in these
places (which is very easily to be understood as "Guest Physical
Address", while it's not). To make the codes (much) easier to be read, I
decided to do this once a
From: Aviv Ben-David
This capability asks the guest to invalidate cache before each map operation.
We can use this invalidation to trap map operations in the hypervisor.
Signed-off-by: Aviv Ben-David
[peterx: using "caching-mode" instead of "cache-mode" to align with spec]
[peterx: re-write the
In this patch, IOMMUNotifier.{start|end} are introduced to store section
information for a specific notifier. When notification occurs, we not
only check the notification type (MAP|UNMAP), but also check whether the
notified iova range overlaps with the range of specific IOMMU notifier,
and skip th
VT-d codes are still using static DEBUG_INTEL_IOMMU macro. That's not
good, and we should end the day when we need to recompile the code
before getting useful debugging information for vt-d. Time to switch to
the trace system. This is the first patch to do it.
Signed-off-by: Peter Xu
---
hw/i386
This is an "global" version of exising memory_region_iommu_replay() - we
announce the translations to all the registered notifiers, instead of a
specific one.
Signed-off-by: Peter Xu
---
include/exec/memory.h | 8
memory.c | 9 +
2 files changed, 17 insertions(+)
d
This helps in debugging incorrect level passed in.
Reviewed-by: Jason Wang
Signed-off-by: Peter Xu
---
hw/i386/intel_iommu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
index ad304f6..22d8226 100644
--- a/hw/i386/intel_iommu.c
+++ b/hw/i386/
Originally we have one memory_region_iommu_replay() function, which is
the default behavior to replay the translations of the whole IOMMU
region. However, on some platform like x86, we may want our own replay
logic for IOMMU regions. This patch add one more hook for IOMMUOps for
the callback, and i
Signed-off-by: Peter Xu
---
include/exec/memory.h | 3 +++
memory.c | 4 ++--
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/include/exec/memory.h b/include/exec/memory.h
index 805a88a..f76e174 100644
--- a/include/exec/memory.h
+++ b/include/exec/memory.h
@@ -239,6 +
This patch is based on Aviv Ben-David ()'s patch
upstream:
"IOMMU: enable intel_iommu map and unmap notifiers"
https://lists.gnu.org/archive/html/qemu-devel/2016-11/msg01453.html
However I removed/fixed some content, and added my own codes.
Instead of translate() every page for iotlb invalid
Generalizing the notify logic in memory_region_notify_iommu() into a
single function. This can be further used in customized replay()
functions for IOMMUs.
Signed-off-by: Peter Xu
---
include/exec/memory.h | 15 +++
memory.c | 40
This is preparation work to finally enabled dynamic switching ON/OFF for
VT-d protection. The old VT-d codes is using static IOMMU address space,
and that won't satisfy vfio-pci device listeners.
Let me explain.
vfio-pci devices depend on the memory region listener and IOMMU replay
mechanism to m
On 02/05/2017 04:25 PM, Cédric Le Goater wrote:
> ello Frederic,
Hi Cédric,
Thanks for taking a look at this!
>
> On 01/26/2017 10:47 AM, fred.kon...@greensocs.com wrote:
>> From: KONRAD Frederic
>>
>> This introduces qemu-clk qom object.
>>
>> Signed-off-by: KONRAD Frederic
>> ---
>> Makefi
On 2017年02月07日 16:19, Hailiang Zhang wrote:
On 2017/2/7 15:57, Jason Wang wrote:
On 2017年02月07日 15:54, Hailiang Zhang wrote:
Hi Jason,
On 2017/2/6 20:53, Jason Wang wrote:
On 2017年02月06日 19:11, Hailiang Zhang wrote:
On 2017/2/6 17:35, Jason Wang wrote:
On 2017年02月06日 16:13, Hailiang
On 02/06/2017 03:20 PM, Cédric Le Goater wrote:
> On 01/26/2017 10:47 AM, fred.kon...@greensocs.com wrote:
>> From: KONRAD Frederic
>>
>> This allows to add a clock to a DeviceState.
>> Contrary to gpios, the clock pins are not contained in the DeviceState but
>> with the child property so they ca
Am 06.02.2017 um 16:36 hat Markus Armbruster geschrieben:
> >> === Structured values ===
> >>
> >> The dotted key convention messes with KEY syntax to permit structured
> >> values. Works, but the more conventional way to support structured
> >> values is a syntax for structured values.
> >>
>
On 02/07/2017 10:22 AM, Frederic Konrad wrote:
>> I see how these routines are used in patch 10/10. But if we were
>> open coding device CRF_APB, I don't think we would need them at
>> all and it would make the code a little simple IMHO.
> What do you mean by open coding?
I mean to externalize the
On 2017/2/7 17:21, Jason Wang wrote:
On 2017年02月07日 16:19, Hailiang Zhang wrote:
On 2017/2/7 15:57, Jason Wang wrote:
On 2017年02月07日 15:54, Hailiang Zhang wrote:
Hi Jason,
On 2017/2/6 20:53, Jason Wang wrote:
On 2017年02月06日 19:11, Hailiang Zhang wrote:
On 2017/2/6 17:35, Jason Wang wr
From: Li Qiang
This issue is the same as e1000 network card in this commit:
e1000: eliminate infinite loops on out-of-bounds transfer start.
Signed-off-by: Li Qiang
---
hw/net/e1000e_core.c | 17 -
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/hw/net/e1000e_core
On 02/06/2017 04:58 PM, Cédric Le Goater wrote:
> Hello,
>
> On 01/26/2017 10:47 AM, fred.kon...@greensocs.com wrote:
>> From: KONRAD Frederic
>>
>> This introduces the clock binding and the update part.
>> When the qemu_clk_rate_update(qemu_clk, int) function is called:
>> * The clock callback
On 02/07/2017 10:31 AM, Cédric Le Goater wrote:
> On 02/07/2017 10:22 AM, Frederic Konrad wrote:
>>> I see how these routines are used in patch 10/10. But if we were
>>> open coding device CRF_APB, I don't think we would need them at
>>> all and it would make the code a little simple IMHO.
>> What
On 02/04/2017 02:59 PM, Frederic Konrad wrote:
> On 02/04/2017 01:41 PM, Paolo Bonzini wrote:
>>
> ...
>>>
>>> Doesn't hotplug use dynamic MemoryRegion? In which case we better
>>> make that work with MTTCG. I wonder if we can't simply handle that
>>> with a safe_work for this case?
>>
>> Hot-unplu
On 06/02/17 11:00, Paolo Bonzini wrote:
>
>
> On 27/01/2017 19:11, Claudio Imbrenda wrote:
>> +/* mark valid CPUs with 1 */
>> +CPU_FOREACH(cpu) {
>> +newstates[cpu_index(cpu) - 1] = 1;
>> +}
>
> Sorry I didn't notice this before: CPU indices are zero-based in QEMU,
> so you
2016-11-08 3:41 GMT+08:00 Marcelo Tosatti :
> On Mon, Nov 07, 2016 at 03:46:11PM +, Dr. David Alan Gilbert wrote:
>> * Marcelo Tosatti (mtosa...@redhat.com) wrote:
>> > This patch, relative to pre-copy migration codepath,
>> > measures the time between vm_stop() and pre_save(),
>> > which inclu
Pranith Kumar writes:
> Hi Alex,
>
> I just spotted this:
>
> On Mon, Feb 6, 2017 at 10:30 AM, Alex Bennée wrote:
>
>> From: KONRAD Frederic
>>
>> We know there will be cases where MTTCG won't work until additional work
>> is done in the front/back ends to support. It will however be useful to
On Wed, 01/25 12:42, Jeff Cody wrote:
> From: Kevin Wolf
>
> This introduces a .bdrv_parse_filename handler for iscsi which parses an
> URL if given and translates it to individual options.
>
> Signed-off-by: Kevin Wolf
> Signed-off-by: Jeff Cody
> ---
> block/iscsi.c | 189
> +++
Pranith Kumar writes:
> Hi Alex,
>
> On Mon, Feb 6, 2017 at 10:30 AM, Alex Bennée wrote:
>> Hi Richard/Peter,
>>
>> This is a mostly ARM focused update to last weeks v9.
>>
>> It has necessitated one change to the cputlb API. It was pointed out
>> that translators often have to special case a b
Public bug reported:
Since qemu-img convert is a long-running operation, it would be nice if
it reported progress in response to control-T (SIGINFO) to show progress
information, much like dd, fsck, dump, cp, etc.
** Affects: qemu
Importance: Undecided
Status: New
** Tags: feature
On Fri, Jan 27, 2017 at 11:41:54AM +0200, Alberto Garcia wrote:
> The QEMU manual page states that Cirrus Logic is the default video
> card if the user doesn't specify any. However this is not true since
> QEMU 2.2.
>
> Signed-off-by: Alberto Garcia
Ping
Berto
On Wed, 01/25 12:42, Jeff Cody wrote:
> From: Kevin Wolf
>
> This splits the logic in the old parse_chap() function into a part that
> parses the -iscsi options into the new driver-specific options, and
> another part that actually applies those options (called apply_chap()
> now).
>
> Note that
On 02/04/2017 03:32 PM, Fam Zheng wrote:
> We install this file to data dir but since 0ab8ed18 it's no longer
> required by any objects during "make". List it explicitly as a depended
> target of install and fix the broken "make install" command.
>
> Signed-off-by: Fam Zheng
Tested-by: Christian
On Wed, 01/25 12:42, Jeff Cody wrote:
> From: Kevin Wolf
>
> This was previously only available with -iscsi. Again, after this patch,
> the -iscsi option only takes effect if an URL is given. New users are
> supposed to use the new driver-specific option.
>
> Reviewed-by: Daniel P. Berrange
> S
On Wed, 01/25 12:42, Jeff Cody wrote:
> From: Kevin Wolf
>
> This was previously only available with -iscsi. Again, after this patch,
> the -iscsi option only takes effect if an URL is given. New users are
> supposed to use the new driver-specific option.
>
> Reviewed-by: Daniel P. Berrange
> S
On Wed, 01/25 12:42, Jeff Cody wrote:
> From: Kevin Wolf
>
> This was previously only available with -iscsi. Again, after this patch,
> the -iscsi option only takes effect if an URL is given. New users are
> supposed to use the new driver-specific option.
>
> All -iscsi options have a correspond
The W3 HTML validator (https://validator.w3.org/) complains about
missing "alt" attributes and a missing "" tag for the
new QEMU website. Here are two patches to fix the issues.
Thomas Huth (2):
Add missing HTML tag to close the screenshots section
Add "alt" attributes to the img tags
_inclu
From: Li Qiang
The guest may builds an infinite loop with link eds. This patch
limit the number of linked ed to avoid this.
Signed-off-by: Li Qiang
---
hw/usb/hcd-ohci.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c
index c82a
On Wed, 01/25 12:42, Jeff Cody wrote:
> From: Kevin Wolf
>
> This adds blockdev-add support for iscsi devices.
>
> Reviewed-by: Daniel P. Berrange
> Signed-off-by: Kevin Wolf
> Signed-off-by: Jeff Cody
> ---
> block/iscsi.c| 14 ++
> qapi/block-core.json | 74
> +
The "alt" attribute is mandatory for the img tags according to
the HTML standard, so we need this to get valid HTML.
Signed-off-by: Thomas Huth
---
_includes/screenshot.html | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/_includes/screenshot.html b/_includes/screenshot.html
The final "" tag is missing here.
Signed-off-by: Thomas Huth
---
index.html | 1 +
1 file changed, 1 insertion(+)
diff --git a/index.html b/index.html
index cf31912..ab33b8a 100644
--- a/index.html
+++ b/index.html
@@ -59,6 +59,7 @@ $('.colorbox').on("click.random-namespace", function() {
})
On Wed, 01/25 12:42, Jeff Cody wrote:
> Signed-off-by: Jeff Cody
> ---
> qapi/block-core.json | 18 +-
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 4ebb8d8..adc089f 100644
> --- a/qapi/block-core.json
> +++
On Tue, 7 Feb 2017 00:15:33 +0100
Greg Kurz wrote:
> On Mon, 6 Feb 2017 13:36:43 -0600
> Eric Blake wrote:
>
> > On 02/03/2017 05:57 AM, Pradeep Jagadeesh wrote:
> > > This patchset adds the throttle support for the 9p-local driver.
> > > For now this functionality can be enabled only through
On 2/6/2017 8:36 PM, Eric Blake wrote:
On 02/03/2017 05:57 AM, Pradeep Jagadeesh wrote:
This patchset adds the throttle support for the 9p-local driver.
For now this functionality can be enabled only through qemu cli options.
QMP interface and support to other drivers need further extensions.
On 07/02/2017 11:23, Thomas Huth wrote:
> The W3 HTML validator (https://validator.w3.org/) complains about
> missing "alt" attributes and a missing "" tag for the
> new QEMU website. Here are two patches to fix the issues.
>
> Thomas Huth (2):
> Add missing HTML tag to close the screenshots s
On 07.02.2017 11:40, Paolo Bonzini wrote:
>
>
> On 07/02/2017 11:23, Thomas Huth wrote:
>> The W3 HTML validator (https://validator.w3.org/) complains about
>> missing "alt" attributes and a missing "" tag for the
>> new QEMU website. Here are two patches to fix the issues.
>>
>> Thomas Huth (2):
Le 07/02/2017 à 04:21, Sam Bobroff a écrit :
> Programs run under qemu-ppc64 on an x86_64 host currently segfault
> if they use pthread_create() due to the adjustment made to the NIP in
> commit bd6fefe71cec5a0c7d2be4ac96307f25db56abf9.
>
> This patch changes cpu_loop() to set the NIP back to the
On 7 February 2017 at 03:21, Sam Bobroff wrote:
> Programs run under qemu-ppc64 on an x86_64 host currently segfault
> if they use pthread_create() due to the adjustment made to the NIP in
> commit bd6fefe71cec5a0c7d2be4ac96307f25db56abf9.
>
> This patch changes cpu_loop() to set the NIP back to t
From: Li Qiang
It should return 1 if an error occurs when reading iso td.
This will avoid an infinite loop issue in ohci_service_ed_list.
Signed-off-by: Li Qiang
---
hw/usb/hcd-ohci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c
inde
On 01/18/2017 09:22 AM, Gonglei wrote:
> The virtio crypto device is a virtual crypto device (ie. hardware
> crypto accelerator card). Currently, the virtio crypto device provides
> the following crypto services: CIPHER, MAC, HASH, and AEAD.
>
> In this patch, CIPHER, MAC, HASH, AEAD services ar
On 21 January 2017 at 08:45, Alessandro Di Federico
wrote:
> This series of patches introduce a set of changes, mainly to the QEMU
> build system, to open the way to implementing "libtcg", i.e., using
> QEMU's tiny code generator frontends as a library.
>
> For the initial proposal, please see the
On 02/06/2017 07:19 PM, Michael S. Tsirkin wrote:
> On Mon, Feb 06, 2017 at 03:46:25PM +, Stefan Hajnoczi wrote:
>> On Mon, Feb 06, 2017 at 01:48:09AM +, Gonglei (Arei) wrote:
> +\item The device MUST set \field{max_size} to show the maximum size of
crypto request the device supp
On Fri, 02/03 18:47, Vladimir Sementsov-Ogievskiy wrote:
> ##
> +# @block-dirty-bitmap-load:
> +#
> +# Load a dirty bitmap from the storage (qcow2 file or nbd export)
> +#
> +# Returns: nothing on success
> +# If @node is not a valid block device, DeviceNotFound
> +# If @name is
On 6 February 2017 at 11:29, Daniel P. Berrange wrote:
> In
>
> commit ba78db44f6532d66a1e704bd44613e841baa2fc5
> Author: Daniel P. Berrange
> Date: Wed Jan 25 16:14:10 2017 +
>
> make: move top level dir to end of include search path
>
> The dir $(BUILD_DIR)/$(@D) was added to the
On Mon, 6 Feb 2017 19:31:24 +0200
"Michael S. Tsirkin" wrote:
> On Mon, Feb 06, 2017 at 09:16:25AM -0800, Ben Warren wrote:
> > >> @@ -257,8 +263,11 @@ void bios_linker_loader_add_pointer(BIOSLinker
> > >> *linker,
> > >> const BiosLinkerFileEntry *source_file =
> > >> bios_linker_fi
On Tue, Feb 07, 2017 at 06:02:13PM +0800, Wanpeng Li wrote:
> 2016-11-08 3:41 GMT+08:00 Marcelo Tosatti :
> > On Mon, Nov 07, 2016 at 03:46:11PM +, Dr. David Alan Gilbert wrote:
> >> * Marcelo Tosatti (mtosa...@redhat.com) wrote:
> >> > This patch, relative to pre-copy migration codepath,
> >>
** Changed in: qemu
Importance: Undecided => Wishlist
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1662468
Title:
[feature request] qemu-img convert should respond to control-T like dd
Status
Can't you simply do a "cp delta.qcow2 new.qcow2" ?
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1662050
Title:
qemu-img convert a overlay qcow2 image into a entire image
Status in QEMU:
Incompl
Sounds like your problem only occurs on older versions of Ubuntu, so
moving this to the QEMU-Ubuntu bug tracker.
** Project changed: qemu => qemu (Ubuntu)
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bug
24.01.2017 12:48, Juan Quintela wrote:
Vladimir Sementsov-Ogievskiy wrote:
Only-postcopy savevm states (dirty-bitmap) don't need live iteration, so
to disable them and stop transporting empty sections there is a new
savevm handler.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
include/mig
Can you still reproduce this issue with the latest version of QEMU
(currently v2.8)?
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/855800
Title:
QEMU 0.12 is completely outdated nowadays ... can you still reproduce
this issue with the latest version of QEMU (currently v2.8)? If yes,
which graphical backend are you using? SDL1? SDL2? GTK?
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because yo
On 07.02.2017 03:56, Sam Bobroff wrote:
> This provides some new definitions needed by ISA 3.00 guests.
>
> It is a large change because this is the first import since
> some kernel header files have become autogenerated.
>
> Note: update-linux-headers.sh currently generates a change that
> (inco
Can you still reproduce this issue with the latest version of QEMU
(currently v2.8), or could we close this ticket nowadays?
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https:/
On Tue, 7 Feb 2017 12:39:44 +0100
Halil Pasic wrote:
> On 01/18/2017 09:22 AM, Gonglei wrote:
> > +\section{Crypto Device}\label{sec:Device Types / Crypto Device}
> > +
> > +The virtio crypto device is a virtual cryptography device as well as a
> > kind of
> > +virtual hardware accelerator for
On Mon, Feb 6, 2017 at 5:10 PM, Alexey Kostyushko wrote:
> This info is more about pvpanic patch, but may be relevant here also.
>
> Consider that KeInitializeCrashDumpHeader is not enough to create dumps
> because it copy only primary header
You mean that the secondary data area is missing? That
These are used in each request handling, inline them.
Signed-off-by: Fam Zheng
---
hw/block/virtio-blk.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index 2858c31..1da9570 100644
--- a/hw/block/virtio-blk.c
+++ b/hw/b
Laszlo spotted and studied this wasteful "if". He pointed out:
The original virtio_blk_free_request needed an "if" as it accesses one
field, since 671ec3f05655 ("virtio-blk: Convert VirtIOBlockReq.elem to
pointer", 2014-06-11); later on in f897bf751fbd ("virtio-blk: embed
VirtQueueElement in VirtI
Fam Zheng (2):
virtio-blk: Remove useless condition around g_free()
virtio-blk: Inline request init, complete and free functions
hw/block/virtio-blk.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
--
2.9.3
On 4 February 2017 at 02:17, Jose Ricardo Ziviani
wrote:
> This patchset contains some fixes and improvements for ppc64le.
>
> Jose Ricardo Ziviani (7):
> risu_ppc64le: improve xsrqpi[x] and xsrqpxp instructions
> risu_ppc64le: fix 32-bit mov immediate
> risu_ppc64le: implement sign extend f
On 02/07/17 14:27, Fam Zheng wrote:
> Laszlo spotted and studied this wasteful "if". He pointed out:
>
> The original virtio_blk_free_request needed an "if" as it accesses one
> field, since 671ec3f05655 ("virtio-blk: Convert VirtIOBlockReq.elem to
> pointer", 2014-06-11); later on in f897bf751fbd
hi
On Sun, 5 Feb 2017 01:12:00 -0800
b...@skyportsystems.com wrote:
> From: Ben Warren
>
> This implements the VM Generation ID feature by passing a 128-bit
> GUID to the guest via a fw_cfg blob.
> Any time the GUID changes, an ACPI notify event is sent to the guest
>
> The user interface is a si
On Sun, 5 Feb 2017 01:11:56 -0800
b...@skyportsystems.com wrote:
> From: Ben Warren
>
> This is initially used to patch a 64-bit address into
> the VM Generation ID SSDT
>
> Signed-off-by: Ben Warren
> ---
...
> +int
> +build_append_named_qword(GArray *array, const char *name_format, ...)
it
On Sun, 5 Feb 2017 01:12:02 -0800
b...@skyportsystems.com wrote:
> From: Igor Mammedov
>
> Add set-vm-generation-id command to set Virtual Machine
> Generation ID counter.
>
> QMP command example:
> { "execute": "set-vm-generation-id",
> "arguments": {
> "guid": "32
On 02/07/17 14:27, Fam Zheng wrote:
> These are used in each request handling, inline them.
>
> Signed-off-by: Fam Zheng
> ---
> hw/block/virtio-blk.c | 9 +
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
> index 2858c31.
Spotted by ASAN.
Signed-off-by: Marc-André Lureau
Reviewed-by: Stefan Hajnoczi
---
qtest.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/qtest.c b/qtest.c
index 1446719e8d..6f4d26832a 100644
--- a/qtest.c
+++ b/qtest.c
@@ -240,6 +240,7 @@ static void GCC_FMT_ATTR(2, 3) qtest_sendf(CharBac
Hi,
After this series removing a few memory leaks, make check with ASAN
enabled gives a "clean" run with x86_64-softmmu target (there are
warnings related to coroutine makecontext/swapcontext).
This should help spot memory related regressions when introducing one.
Note: some of these patches wer
Spotted by ASAN.
Signed-off-by: Marc-André Lureau
---
tests/endianness-test.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/endianness-test.c b/tests/endianness-test.c
index cf8d41b7b4..ed0bf52019 100644
--- a/tests/endianness-test.c
+++ b/tests/endianness-test.c
@@ -295,14 +295,1
Spotted by ASAN.
Signed-off-by: Marc-André Lureau
---
tests/tco-test.c | 35 +--
1 file changed, 21 insertions(+), 14 deletions(-)
diff --git a/tests/tco-test.c b/tests/tco-test.c
index ef02ec5903..c4c264eb3d 100644
--- a/tests/tco-test.c
+++ b/tests/tco-test.c
@
No need for strdup, fix leaks when socat is missing.
Spotted by ASAN.
Cc: "Daniel P. Berrange"
Signed-off-by: Marc-André Lureau
---
tests/test-io-channel-command.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/tests/test-io-channel-command.c b/tests/test-io-channel-
Spotted by ASAN.
Signed-off-by: Marc-André Lureau
Reviewed-by: Stefan Hajnoczi
---
tests/libqos/usb.c | 1 +
tests/postcopy-test.c | 2 +-
tests/pvpanic-test.c | 1 +
tests/test-filter-mirror.c | 2 +-
tests/test-filter-redirector.c | 4 ++--
tests/virtio
Spotted by ASAN.
Cc: John Snow
Signed-off-by: Marc-André Lureau
---
tests/ide-test.c | 12
1 file changed, 12 insertions(+)
diff --git a/tests/ide-test.c b/tests/ide-test.c
index fb541f88b5..2fa97bc36b 100644
--- a/tests/ide-test.c
+++ b/tests/ide-test.c
@@ -339,6 +339,7 @@ static
Spotted by ASAN.
Signed-off-by: Marc-André Lureau
---
tests/i440fx-test.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/tests/i440fx-test.c b/tests/i440fx-test.c
index da2d5a53f0..e9d05c87d1 100644
--- a/tests/i440fx-test.c
+++ b/tests/i440fx-test.c
@@ -134,6 +134,8 @@ static void tes
Similarly to allocation, do it from an inline function. This allows
tests to only use the headers for allocation/free of timer.
Cc: Paolo Bonzini
Signed-off-by: Marc-André Lureau
---
include/qemu/timer.h | 5 -
qemu-timer.c | 5 -
2 files changed, 4 insertions(+), 6 deletions(-)
Spotted by ASAN.
Signed-off-by: Marc-André Lureau
---
tests/e1000e-test.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tests/e1000e-test.c b/tests/e1000e-test.c
index 8c42ca919f..c612dc64ec 100644
--- a/tests/e1000e-test.c
+++ b/tests/e1000e-test.c
@@ -99,7 +99,10 @@
Spotted by ASAN.
Signed-off-by: Marc-André Lureau
---
tests/ipmi-kcs-test.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/ipmi-kcs-test.c b/tests/ipmi-kcs-test.c
index 9cf0b34a33..178ffc1797 100644
--- a/tests/ipmi-kcs-test.c
+++ b/tests/ipmi-kcs-test.c
@@ -279,6 +279,7 @@ int main(i
Spotted by ASAN.
Signed-off-by: Marc-André Lureau
---
tests/hd-geo-test.c | 47 +++
1 file changed, 31 insertions(+), 16 deletions(-)
diff --git a/tests/hd-geo-test.c b/tests/hd-geo-test.c
index 6176e81ab2..88f8d76d32 100644
--- a/tests/hd-geo-test.c
Spotted by ASAN.
Signed-off-by: Marc-André Lureau
---
tests/q35-test.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/q35-test.c b/tests/q35-test.c
index 763fe3d6ae..e010d781e7 100644
--- a/tests/q35-test.c
+++ b/tests/q35-test.c
@@ -71,6 +71,9 @@ static void test_smram_lock(void)
1 - 100 of 291 matches
Mail list logo
