Re: [Qemu-devel] [PATCH] Change name of live migration thread

2017-01-23 Thread Juan Quintela
Pankaj Gupta wrote: > Change the name of live migration thread from 'migration' > to 'qemu_vm_migration' to identify it clearly. 'migration' > is a generic word and kernel also has tasks for process > migration with the name 'migration/cpu#'. > > Signed-off-by: Pankaj Gupta Reviewed-by: Juan Q

[Qemu-devel] [PATCH] 9pfs: local: trivial cosmetic fix in pwritev op

2017-01-23 Thread Greg Kurz
Signed-off-by: Greg Kurz --- hw/9pfs/9p-local.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/9pfs/9p-local.c b/hw/9pfs/9p-local.c index 845675e7a1bb..7de07e1ba67f 100644 --- a/hw/9pfs/9p-local.c +++ b/hw/9pfs/9p-local.c @@ -436,8 +436,7 @@ static ssize_t local_pwrit

Re: [Qemu-devel] [PATCH] virtio-gpu: fix memory leak in set scanout

2017-01-23 Thread Marc-André Lureau
On Sun, Jan 22, 2017 at 11:43 AM Li Qiang wrote: > From: Li Qiang > > In virtio_gpu_set_scanout function, when creating the 'rect' > its refcount is set to 2, by pixman_image_create_bits and > qemu_create_displaysurface_pixman function. This can lead > a memory leak issues. This patch avoid this

Re: [Qemu-devel] [PATCH] Change name of live migration thread

2017-01-23 Thread Dr. David Alan Gilbert
* Pankaj Gupta (pagu...@redhat.com) wrote: > Change the name of live migration thread from 'migration' > to 'qemu_vm_migration' to identify it clearly. 'migration' > is a generic word and kernel also has tasks for process > migration with the name 'migration/cpu#'. > > Signed-off-by: Pankaj Gupt

Re: [Qemu-devel] [PATCH] Change name of live migration thread

2017-01-23 Thread Paolo Bonzini
On 23/01/2017 06:40, Amit Shah wrote: > On (Sun) 22 Jan 2017 [12:47:51], Pankaj Gupta wrote: >> Change the name of live migration thread from 'migration' >> to 'qemu_vm_migration' to identify it clearly. 'migration' >> is a generic word and kernel also has tasks for process >> migration with th

[Qemu-devel] [PATCH V1] throttle:Removed duplicate throtlle code from block and 9p files

2017-01-23 Thread Pradeep Jagadeesh
This will allow other subsystems (i.e. fsdev) to implement throttling without duplicating the command line options. Signed-off-by: Pradeep Jagadeesh --- blockdev.c | 80 ++- fsdev/qemu-fsdev-opts.c | 80 ++--

Re: [Qemu-devel] Question about io mode & cache mode

2017-01-23 Thread Stefan Hajnoczi
On Mon, Jan 23, 2017 at 8:59 AM, morgenlette madeBy wrote: Please keep qemu-devel@nongnu.org CCed so the discussion stays on the mailing list where others can follow it. > I am sorry to bother you. > > so, Where is the part that I have to check additionally? Failing syscalls can be debugged usi

Re: [Qemu-devel] [PATCH V12] fsdev: add IO throttle support to fsdev devices

2017-01-23 Thread Pradeep Kiruvale
On 23 January 2017 at 10:32, Greg Kurz wrote: > On Thu, 12 Jan 2017 11:57:25 -0500 > Pradeep Jagadeesh wrote: > > > Signed-off-by: Pradeep Jagadeesh > > --- > > fsdev/Makefile.objs | 2 +- > > fsdev/file-op-9p.h | 3 ++ > > fsdev/qemu-fsdev-opts.c | 77 +++

Re: [Qemu-devel] qemu-2.8-rc4 is broken

2017-01-23 Thread Alex Bennée
Pavel Dovgalyuk writes: >> From: Alex Bennée [mailto:alex.ben...@linaro.org] >> Pavel Dovgalyuk writes: >> >> >> From: Alex Bennée [mailto:alex.ben...@linaro.org] >> > >> > Sorry, this is another problem which occurs only in icount replay mode: >> > 1. cpu_handle_exception tries to force except

Re: [Qemu-devel] [PATCH V12] fsdev: add IO throttle support to fsdev devices

2017-01-23 Thread Greg Kurz
On Thu, 12 Jan 2017 11:57:25 -0500 Pradeep Jagadeesh wrote: > Signed-off-by: Pradeep Jagadeesh > --- > fsdev/Makefile.objs | 2 +- > fsdev/file-op-9p.h | 3 ++ > fsdev/qemu-fsdev-opts.c | 77 - > fsdev/qemu-fsdev-throttle.c | 118 >

[Qemu-devel] [PATCH 6/6] hw/i386/i386: Stop auto-creating lsi53c895a SCSI HBAs

2017-01-23 Thread Markus Armbruster
The PC machines (pc-q35-* pc-i440fx-* pc-* isapc xenfv) automatically create lsi53c895a SCSI HBAs and SCSI devices to honor -drive if=scsi. For giggles, try -drive if=scsi,bus=25,media=cdrom --- this makes QEMU create 25 of them. The lsi53c895a is thoroughly obsolete (PCI Ultra2 SCSI, ca. 2000), a

[Qemu-devel] [PATCH 0/6] More sensible default for -drive interface type

2017-01-23 Thread Markus Armbruster
Block backends defined with -drive if=T, T!=none are meant to be picked up by machine initialization code: a suitable frontend gets created and wired up automatically. if=T drives not picked up that way can still be used with -device as if they had if=none, but that's unclean and best avoided. Un

[Qemu-devel] [PATCH 5/6] hw/arm/highbank: Default -drive to if=ide instead of if=scsi

2017-01-23 Thread Markus Armbruster
These machines have no onboard SCSI HBA, and no way to plug one. -drive if=scsi therefore cannot work. They do have an onboard IDE controller (sysbus-ahci), but fail to honor if=ide. Change their default to if=ide, and add a TODO comment on what needs to be done to actually honor -drive if=ide.

[Qemu-devel] [PATCH 4/6] hw: Default -drive to if=none instead of scsi when scsi cannot work

2017-01-23 Thread Markus Armbruster
Block backends defined with -drive if=scsi are meant to be picked up by machine initialization code: a suitable frontend gets created and wired up automatically. if=scsi drives not picked up that way can still be used with -device as if they had if=none, but that's unclean and best avoided. Unuse

[Qemu-devel] [PATCH 2/6] hw/arm/cubieboard hw/arm/xlnx-ep108: Fix units_per_default_bus

2017-01-23 Thread Markus Armbruster
Machine types cubieboard, xlnx-ep108, xlnx-zcu102 have an onboard AHCI controller, but neglect to set their MachineClass member units_per_default_bus = 1. This permits -drive if=ide,unit=1, which makes no sense for AHCI. It also screws up index=N for odd N, because it gets desugared to unit=1,bus

[Qemu-devel] [PATCH 1/6] hw: Default -drive to if=ide explicitly where it works

2017-01-23 Thread Markus Armbruster
Block backends defined with -drive if=ide are meant to be picked up by machine initialization code: a suitable frontend gets created and wired up automatically. if=ide drives not picked up that way can still be used with -device as if they had if=none, but that's unclean and best avoided. Unused

[Qemu-devel] [PATCH 3/6] hw: Default -drive to if=none instead of ide when ide cannot work

2017-01-23 Thread Markus Armbruster
Block backends defined with -drive if=ide are meant to be picked up by machine initialization code: a suitable frontend gets created and wired up automatically. if=ide drives not picked up that way can still be used with -device as if they had if=none, but that's unclean and best avoided. Unused

Re: [Qemu-devel] [PATCH V1] throttle:Removed duplicate throtlle code from block and 9p files

2017-01-23 Thread Greg Kurz
On Mon, 23 Jan 2017 04:19:55 -0500 Pradeep Jagadeesh wrote: > This will allow other subsystems (i.e. fsdev) to implement throttling > without duplicating the command line options. > > Signed-off-by: Pradeep Jagadeesh > --- This patch depends on your other patch "[PATCH V12] fsdev: add IO throt

Re: [Qemu-devel] [PATCH V1] throttle:Removed duplicate throtlle code from block and 9p files

2017-01-23 Thread Pradeep Jagadeesh
On 1/23/2017 10:47 AM, Greg Kurz wrote: On Mon, 23 Jan 2017 04:19:55 -0500 Pradeep Jagadeesh wrote: This will allow other subsystems (i.e. fsdev) to implement throttling without duplicating the command line options. Signed-off-by: Pradeep Jagadeesh --- This patch depends on your other patc

Re: [Qemu-devel] [PATCH V12] fsdev: add IO throttle support to fsdev devices

2017-01-23 Thread Greg Kurz
On Mon, 23 Jan 2017 10:38:21 +0100 Pradeep Kiruvale wrote: > On 23 January 2017 at 10:32, Greg Kurz wrote: > > > On Thu, 12 Jan 2017 11:57:25 -0500 > > Pradeep Jagadeesh wrote: > > > > > Signed-off-by: Pradeep Jagadeesh > > > --- > > > fsdev/Makefile.objs | 2 +- > > > fsdev/file-o

Re: [Qemu-devel] [PATCH v3] aspeed/smc: handle dummy bytes when doing fast reads in command mode

2017-01-23 Thread Cédric Le Goater
On 01/18/2017 07:23 PM, mar.krzeminski wrote: > W dniu 18.01.2017 o 16:01, Cédric Le Goater pisze: >> When doing fast read, a certain amount of dummy bytes should be sent >> before the read. This number is configurable in the controler CE0 >> Control Register and needs to be modeled using fake tran

Re: [Qemu-devel] [PULL v3 00/32] Misc patches for 2017-01-11

2017-01-23 Thread Peter Maydell
On 20 January 2017 at 13:31, Paolo Bonzini wrote: > The following changes since commit 2ccede18bd24fce5db83fef3674563a1f256717b: > > Merge remote-tracking branch > 'remotes/vivier/tags/m68k-for-2.9-pull-request' into staging (2017-01-16 > 12:41:35 +) > > are available in the git repository

[Qemu-devel] [Bug 1658634] [NEW] Can't get correct display with latest QEMU and OVMF BIOS

2017-01-23 Thread Kai Cong
Public bug reported: I tried to install a Ubuntu 16.04.1 Desktop 64bits with latest QEMU and OVMF UEFI BIOS, however I can't get correct display output with default vga configuration (-vga std). However, qemu works with a couple of different configurations: 1. "-vga cirrus" + "-bios OVMF.fd": w

Re: [Qemu-devel] Towards an ivshmem 2.0?

2017-01-23 Thread Måns Rullgård
"Wang, Wei W" writes: > On Saturday, January 21, 2017 12:38 AM, Jan Kiszka wrote: >> On 2017-01-20 12:54, Wang, Wei W wrote: >>> Having a theoretical analysis on the performance: The traditional >>> shared memory mechanism, sharing an intermediate memory, requires 2 >>> copies to get the packet t

Re: [Qemu-devel] [PATCH RFC v4 18/20] intel_iommu: enable vfio devices

2017-01-23 Thread Jason Wang
On 2017年01月23日 11:34, Peter Xu wrote: On Mon, Jan 23, 2017 at 09:55:39AM +0800, Jason Wang wrote: On 2017年01月22日 17:04, Peter Xu wrote: On Sun, Jan 22, 2017 at 04:08:04PM +0800, Jason Wang wrote: [...] +static void vtd_iotlb_page_invalidate_notify(IntelIOMMUState *s, +

[Qemu-devel] [PATCH] virtio-gpu: fix resource leak in virgl_cmd_resource_unref

2017-01-23 Thread Gerd Hoffmann
When the guest sends VIRTIO_GPU_CMD_RESOURCE_UNREF without detaching the backing storage beforehand (VIRTIO_GPU_CMD_RESOURCE_DETACH_BACKING) we'll leak memory. This patch fixes it for 3d mode, simliar to the 2d mode fix in commit "b8e2392 virtio-gpu: call cleanup mapping function in resource destr

Re: [Qemu-devel] [PATCH RFC v4 18/20] intel_iommu: enable vfio devices

2017-01-23 Thread Jason Wang
On 2017年01月23日 11:40, Peter Xu wrote: On Mon, Jan 23, 2017 at 10:01:11AM +0800, Jason Wang wrote: On 2017年01月20日 21:08, Peter Xu wrote: This patch is based on Aviv Ben-David ()'s patch upstream: "IOMMU: enable intel_iommu map and unmap notifiers" https://lists.gnu.org/archive/html/qem

Re: [Qemu-devel] [PATCH V1] throttle:Removed duplicate throtlle code from block and 9p files

2017-01-23 Thread Greg Kurz
On Mon, 23 Jan 2017 10:58:19 +0100 Pradeep Jagadeesh wrote: > On 1/23/2017 10:47 AM, Greg Kurz wrote: > > On Mon, 23 Jan 2017 04:19:55 -0500 > > Pradeep Jagadeesh wrote: > > > >> This will allow other subsystems (i.e. fsdev) to implement throttling > >> without duplicating the command line opt

Re: [Qemu-devel] [PATCH 01/18] tcg: add support for 128bit vector type

2017-01-23 Thread Kirill Batuzov
On Sat, 21 Jan 2017, Richard Henderson wrote: > On 01/19/2017 08:54 AM, Kirill Batuzov wrote: > > > > Wrappers issue emulation code instead of operation if it is not supported by > > host. > > > > tcg_gen_add_i32x4 looks like this: > > > > if (TCG_TARGET_HAS_add_i32x4) { > > tcg_gen_op3_v12

Re: [Qemu-devel] QEMU website (wiki) improvements

2017-01-23 Thread Stefan Hajnoczi
On Sun, Jan 22, 2017 at 04:19:43PM +0100, Stefan Weil wrote: > On 03/02/15 23:12, Stefan Hajnoczi wrote: > > On Sat, Feb 28, 2015 at 04:29:44PM +0100, Stefan Weil wrote: > > > * It does not support secure access (https), so each login is insecure. > > > Can we get a free server certificate? > >

Re: [Qemu-devel] [PULL 00/26] New hppa-linux target support

2017-01-23 Thread Peter Maydell
On 23 January 2017 at 02:17, Richard Henderson wrote: > This is a linux-user only port, emulating a 32-bit only version of a > pa-2.0 cpu. This is good enough to do well with both the gcc and glibc > testsuites. Helge Deller has provided invaluable assistance testing > with a more complete debia

Re: [Qemu-devel] [PATCH RFC v4 19/20] intel_iommu: unmap existing pages before replay

2017-01-23 Thread Jason Wang
On 2017年01月23日 15:30, Peter Xu wrote: On Mon, Jan 23, 2017 at 09:57:23AM +0800, Jason Wang wrote: On 2017年01月22日 17:09, Peter Xu wrote: On Sun, Jan 22, 2017 at 04:13:32PM +0800, Jason Wang wrote: On 2017年01月20日 21:08, Peter Xu wrote: Previous replay works for domain switch only if the orig

Re: [Qemu-devel] [PATCH] hw/i386: check if nvdimm is enabled before plugging

2017-01-23 Thread Stefan Hajnoczi
On Fri, Jan 13, 2017 at 07:56:51PM +0800, Haozhong Zhang wrote: > The missing of 'nvdimm' in the machine type option '-M' means NVDIMM > is disabled. QEMU should refuse to plug any NVDIMM device in this case > and report the misconfiguration. > > Reported-by: Stefan Hajnoczi > Signed-off-by: Haoz

Re: [Qemu-devel] [PATCH 00/16] aio_context_acquire/release pushdown, part 2

2017-01-23 Thread Stefan Hajnoczi
On Fri, Jan 20, 2017 at 05:39:40PM +0100, Paolo Bonzini wrote: > > > On 19/01/2017 18:01, Stefan Hajnoczi wrote: > >>> This is a big and somewhat risky change. Have you run any performance > >>> benchmarks? > >> > >> Not recently; I ran them a year ago and there was no measurable difference. > >

Re: [Qemu-devel] [PATCH RFC v4 16/20] intel_iommu: do replay when context invalidate

2017-01-23 Thread Jason Wang
On 2017年01月20日 21:08, Peter Xu wrote: Before this one we only invalidate context cache when we receive context entry invalidations. However it's possible that the invalidation also contains a domain switch (only if cache-mode is enabled for vIOMMU). In that case we need to notify all the regist

Re: [Qemu-devel] [PATCH RFC v4 19/20] intel_iommu: unmap existing pages before replay

2017-01-23 Thread Jason Wang
On 2017年01月20日 21:08, Peter Xu wrote: static int vtd_replay_hook(IOMMUTLBEntry *entry, void *private) { memory_region_notify_one((IOMMUNotifier *)private, entry); @@ -2711,13 +2768,16 @@ static void vtd_iommu_replay(MemoryRegion *mr, IOMMUNotifier *n) if (vtd_dev_to_context_

Re: [Qemu-devel] VM Hung issue

2017-01-23 Thread Stefan Hajnoczi
On Thu, Jan 19, 2017 at 10:22:57PM +0500, Umar Draz wrote: > Yes the display is blank, and network also not responding, it means vm > somewhere hung. Try "gstack $PID_OF_QEMU" when the VM is hung. This will output a backtrace for all threads in QEMU. You might need to install the gdb package to

Re: [Qemu-devel] [PATCH v3 1/1] block/vmdk: Fix the endian problem of buf_len and lba

2017-01-23 Thread Fam Zheng
On Mon, 01/16 13:26, Fam Zheng wrote: > On Mon, 01/16 10:38, liujing wrote: > > Dears, > > > > We would like to know if this patch will be pulled > > > > into upstream or what else we need to do for it? > > > > Because for upstream, the qemu-iotests case 055 still failed. > > Kevin, would you l

Re: [Qemu-devel] [PATCH v2 00/25] qmp: add async command type

2017-01-23 Thread Stefan Hajnoczi
On Wed, Jan 18, 2017 at 08:03:07PM +0400, Marc-André Lureau wrote: > Hi, CCing Jeff Cody and John Snow, who have been working on generalizing Block Job APIs to generic background jobs. There is some overlap between async commands and background jobs. > > One of initial design goals of QMP was t

Re: [Qemu-devel] [PATCH] Change name of live migration thread

2017-01-23 Thread Pankaj Gupta
Hi Dave, > > Change the name of live migration thread from 'migration' > > to 'qemu_vm_migration' to identify it clearly. 'migration' > > is a generic word and kernel also has tasks for process > > migration with the name 'migration/cpu#'. > > > > Signed-off-by: Pankaj Gupta > > --- > > migra

Re: [Qemu-devel] [PATCH] Change name of live migration thread

2017-01-23 Thread Pankaj Gupta
Hi Paolo, > > On (Sun) 22 Jan 2017 [12:47:51], Pankaj Gupta wrote: > >> Change the name of live migration thread from 'migration' > >> to 'qemu_vm_migration' to identify it clearly. 'migration' > >> is a generic word and kernel also has tasks for process > >> migration with the name 'migration/cp

Re: [Qemu-devel] [PATCH RFC] acpi: add reset register to fadt

2017-01-23 Thread Igor Mammedov
On Thu, 19 Jan 2017 19:09:47 +0100 Phil Dennis-Jordan wrote: > On 18 January 2017 at 17:30, Michael S. Tsirkin wrote: > > I think what's important is the Fadt format revision. That one was 1 for > > 1.0b and 3 for 2.0. > > > > See page 112, Table 5-5 Fixed ACPI Description Table Format in acpi

[Qemu-devel] [Bug 804517] Re: qemu crashes on Darwin in qemu_iohandler_poll

2017-01-23 Thread Thomas Huth
Can you still reproduce this issue with the latest version of QEMU, or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.n

[Qemu-devel] [Bug 886147] Re: Cannot make program Icon on my desktop with rightmouse key

2017-01-23 Thread Thomas Huth
This apparently has nothing to do with QEMU. Closing. ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/886147 Title: Cannot make program Icon on my d

[Qemu-devel] [Bug 1192499] Re: virsh migration copy-storage-all fails with "Unable to read from monitor: Connection reset by peer"

2017-01-23 Thread Thomas Huth
Is there still something left to do here, or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1192499 Title:

Re: [Qemu-devel] [PATCH v2 00/25] qmp: add async command type

2017-01-23 Thread Marc-André Lureau
Hi - Original Message - > On Wed, Jan 18, 2017 at 08:03:07PM +0400, Marc-André Lureau wrote: > > Hi, > > CCing Jeff Cody and John Snow, who have been working on generalizing > Block Job APIs to generic background jobs. There is some overlap > between async commands and background jobs.

Re: [Qemu-devel] [PATCH V1] throttle:Removed duplicate throtlle code from block and 9p files

2017-01-23 Thread Stefan Hajnoczi
On Mon, Jan 23, 2017 at 04:19:55AM -0500, Pradeep Jagadeesh wrote: > This will allow other subsystems (i.e. fsdev) to implement throttling > without duplicating the command line options. > > Signed-off-by: Pradeep Jagadeesh > --- > blockdev.c | 80 ++-

Re: [Qemu-devel] [PATCH] hmp: fix block_set_io_throttle

2017-01-23 Thread Stefan Hajnoczi
On Fri, Jan 20, 2017 at 05:03:59PM -0600, Eric Blake wrote: > Commit 7a9877a made the 'device' parameter to BlockIOThrottle > optional, favoring 'id' instead. But it forgot to update the > HMP usage to set has_device, which makes all attempts to change > throttling via HMP fail with "Need exactly

[Qemu-devel] ping2 Re: [PATCH v4 00/17] Dirty bitmaps postcopy migration

2017-01-23 Thread Vladimir Sementsov-Ogievskiy
Ping Hi all! What about this? 22.11.2016 20:54, Vladimir Sementsov-Ogievskiy wrote: Hi all! There is a new version of dirty bitmap postcopy migration series. v4: clone: tag postcopy-v4 from https://src.openvz.org/scm/~vsementsov/qemu.git online: https://src.openvz.org/users/vsementsov/repos/

Re: [Qemu-devel] [PATCH] display: cirrus: check vga bits per pixel(bpp) value

2017-01-23 Thread Gerd Hoffmann
Hi, > > > What seems to happen is that blit_is_unsafe() is also called for > > > CIRRUS_BLTMODE_PATTERNCOPY, but in this case cirrus_blt_srcpitch is > > > not used. However, because of this new check if its value is 0 then > > > cirrus_bitblt_common_patterncopy() returns early and becomes a no-o

Re: [Qemu-devel] [PATCH v2 23/25] console: make screendump async

2017-01-23 Thread Gerd Hoffmann
Hi, > > If you only ref, you could have the image being modified while it is > being saved asynchronously, this could result in tearing artefacts, > no? Yes, but you have that problem _anyway_. screendump qmp command can run in parallel to guest vcpu, so it can race with guest display updates

[Qemu-devel] [PATCH 08/24] block: introduce auto-loading bitmaps

2017-01-23 Thread Vladimir Sementsov-Ogievskiy
Auto loading bitmaps are bitmaps stored in the disk image, which should be loaded when the image is opened and become BdrvDirtyBitmaps for the corresponding drive. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow --- block.c | 14 ++ include/block

[Qemu-devel] [PATCH 12/24] block/dirty-bitmap: add bdrv_dirty_bitmap_next()

2017-01-23 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- block/dirty-bitmap.c | 7 +++ include/block/dirty-bitmap.h | 3 +++ 2 files changed, 10 insertions(+) diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c index 4d026df1bd..fe34d488aa 100644 --- a/block/dirty

[Qemu-devel] [PATCH 01/24] specs/qcow2: fix bitmap granularity qemu-specific note

2017-01-23 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow --- docs/specs/qcow2.txt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/docs/specs/qcow2.txt b/docs/specs/qcow2.txt index 80cdfd0e91..dda53dd2a3 100644 --- a/docs/specs/qcow2.txt +++ b/docs/specs/qcow2.txt

[Qemu-devel] [PATCH 05/24] block: fix bdrv_dirty_bitmap_granularity signature

2017-01-23 Thread Vladimir Sementsov-Ogievskiy
Make getter signature const-correct. This allows other functions with const dirty bitmap parameter use bdrv_dirty_bitmap_granularity(). Reviewed-by: Eric Blake Reviewed-by: John Snow Reviewed-by: Kevin Wolf Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/dirty-bitmap.c | 2 +- i

[Qemu-devel] [PATCH 03/24] hbitmap: improve dirty iter

2017-01-23 Thread Vladimir Sementsov-Ogievskiy
Make dirty iter resistant to resetting bits in corresponding HBitmap. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Reviewed-by: John Snow --- include/qemu/hbitmap.h | 26 -- util/hbitmap.c | 23 ++- 2 files changed, 26 i

[Qemu-devel] [PATCH 16/24] qmp: add persistent flag to block-dirty-bitmap-add

2017-01-23 Thread Vladimir Sementsov-Ogievskiy
Add optional 'persistent' flag to qmp command block-dirty-bitmap-add. Default is false. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev Reviewed-by: Max Reitz --- blockdev.c| 18 +- docs/qmp-commands.txt | 3 +++ qapi/block-core.json | 7

[Qemu-devel] [PATCH 04/24] tests: add hbitmap iter test

2017-01-23 Thread Vladimir Sementsov-Ogievskiy
Test that hbitmap iter is resistant to bitmap resetting. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev Reviewed-by: Max Reitz Reviewed-by: John Snow --- tests/test-hbitmap.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/tests/test-hbitmap

[Qemu-devel] [PATCH 02/24] specs/qcow2: do not use wording 'bitmap header'

2017-01-23 Thread Vladimir Sementsov-Ogievskiy
A bitmap directory entry is sometimes called a 'bitmap header'. This patch leaves only one name - 'bitmap directory entry'. The name 'bitmap header' creates misunderstandings with 'qcow2 header' and 'qcow2 bitmap header extension' (which is extension of qcow2 header) Signed-off-by: Vladimir Sement

[Qemu-devel] [PATCH 22/24] block/dirty-bitmap: deep release dirty bitmaps

2017-01-23 Thread Vladimir Sementsov-Ogievskiy
Remove persistent bitmap from its storage on bdrv_release_dirty_bitmap. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/dirty-bitmap.c | 21 ++--- include/block/block_int.h | 3 +++ 2 files changed, 21 insertions(+), 3 deletions(-) diff --git a/block/dirty-bitmap.c b

[Qemu-devel] [PATCH 23/24] qcow2: add .bdrv_remove_persistent_dirty_bitmap

2017-01-23 Thread Vladimir Sementsov-Ogievskiy
Realize .bdrv_remove_persistent_dirty_bitmap interface. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-bitmap.c | 40 block/qcow2.c| 1 + block/qcow2.h| 3 +++ 3 files changed, 44 insertions(+) diff --git a/block/qcow2-bitm

[Qemu-devel] [PATCH 11/24] block: introduce persistent dirty bitmaps

2017-01-23 Thread Vladimir Sementsov-Ogievskiy
New field BdrvDirtyBitmap.persistent means, that bitmap should be saved on bdrv_close, using format driver. Format driver should maintain bitmap storing. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- block.c | 32 bl

[Qemu-devel] [PATCH 21/24] qcow2-bitmap: refcounts

2017-01-23 Thread Vladimir Sementsov-Ogievskiy
Calculate refcounts for qcow2 bitmaps. It is needed for qcow2's qemu-img check implementation. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-bitmap.c | 80 ++ block/qcow2-refcount.c | 6 block/qcow2.h | 3 ++ 3 files

[Qemu-devel] [PATCH 17/24] qmp: add autoload parameter to block-dirty-bitmap-add

2017-01-23 Thread Vladimir Sementsov-Ogievskiy
Optional. Default is false. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev Reviewed-by: Max Reitz --- blockdev.c| 18 -- docs/qmp-commands.txt | 4 qapi/block-core.json | 6 +- 3 files changed, 25 insertions(+), 3 deletions(-)

[Qemu-devel] [PATCH 19/24] iotests: test qcow2 persistent dirty bitmap

2017-01-23 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- tests/qemu-iotests/165 | 89 ++ tests/qemu-iotests/165.out | 5 +++ tests/qemu-iotests/group | 1 + 3 files changed, 95 insertions(+) create mode 100755 tests/qemu-iotests/

[Qemu-devel] [PATCH 18/24] qmp: add x-debug-block-dirty-bitmap-sha256

2017-01-23 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/dirty-bitmap.c | 5 + blockdev.c | 29 + include/block/dirty-bitmap.h | 2 ++ include/qemu/hbitmap.h | 8 qapi/block-core.json | 27 +++

[Qemu-devel] [PATCH 10/24] block/dirty-bitmap: add autoload field to BdrvDirtyBitmap

2017-01-23 Thread Vladimir Sementsov-Ogievskiy
Mirror AUTO flag from Qcow2 bitmap in BdrvDirtyBitmap. This will be needed in future, to save this flag back to Qcow2 for persistent bitmaps. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- block/dirty-bitmap.c | 16 block/qcow2-bitmap.c |

[Qemu-devel] [PATCH 24/24] qcow2-bitmap: cache bitmap list in BDRVQcow2State

2017-01-23 Thread Vladimir Sementsov-Ogievskiy
Do not reload bitmap list every time it is needed. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-bitmap.c | 125 ++- block/qcow2.c| 2 + block/qcow2.h| 4 ++ 3 files changed, 89 insertions(+), 42 deletions(-) diff

[Qemu-devel] [PATCH 20/24] qcow2-refcount: rename inc_refcounts() and make it public

2017-01-23 Thread Vladimir Sementsov-Ogievskiy
This is needed for the following patch, which will introduce refcounts checking for qcow2 bitmaps. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- block/qcow2-refcount.c | 53 ++ block/qcow2.h | 4 2 files cha

[Qemu-devel] [PATCH 06/24] block/dirty-bitmap: add deserialize_ones func

2017-01-23 Thread Vladimir Sementsov-Ogievskiy
Add bdrv_dirty_bitmap_deserialize_ones() function, which is needed for qcow2 bitmap loading, to handle unallocated bitmap parts, marked as all-ones. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Kevin Wolf Reviewed-by: John Snow --- block/dirty-bitmap.c | 7 +++ include

Re: [Qemu-devel] [PATCH 01/21] backup: move from done_bitmap to copy_bitmap

2017-01-23 Thread Vladimir Sementsov-Ogievskiy
23.12.2016 17:28, Vladimir Sementsov-Ogievskiy wrote: Use HBitmap copy_bitmap instead of done_bitmap. This is needed to unify backup loop for full/incremental modes in future patches. We reset bit of the copy_bitmap immediately after checking it in backup_do_cow(). It is safe, because all other

[Qemu-devel] [PATCH 09/24] qcow2: add .bdrv_load_autoloading_dirty_bitmaps

2017-01-23 Thread Vladimir Sementsov-Ogievskiy
Auto loading bitmaps are bitmaps in Qcow2, with the AUTO flag set. They are loaded when the image is opened and become BdrvDirtyBitmaps for the corresponding drive. Extra data in bitmaps is not supported for now. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/Makefile.objs | 2 +- blo

Re: [Qemu-devel] [PATCH 3/6] hw: Default -drive to if=none instead of ide when ide cannot work

2017-01-23 Thread Artyom Tarasenko
On Mon, Jan 23, 2017 at 10:48 AM, Markus Armbruster wrote: > Block backends defined with -drive if=ide are meant to be picked up by > machine initialization code: a suitable frontend gets created and > wired up automatically. > > if=ide drives not picked up that way can still be used with -device

[Qemu-devel] [PATCH 13/24] qcow2: add .bdrv_store_persistent_dirty_bitmaps()

2017-01-23 Thread Vladimir Sementsov-Ogievskiy
Realize block bitmap storing interface, to allow qcow2 images store persistent bitmaps. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-bitmap.c | 509 +-- block/qcow2.c| 1 + block/qcow2.h| 1 + 3 files changed, 496

[Qemu-devel] [PATCH v12 04/16] qemu-img: Set "share-rw" flag in read-only commands

2017-01-23 Thread Fam Zheng
Checking the status of an image when it is being used by guest is usually useful, and there is no risk of corrupting data, so don't let the upcoming image locking feature limit this use case. Signed-off-by: Fam Zheng --- qemu-img.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-)

[Qemu-devel] [PATCH 15/24] qcow2: add .bdrv_can_store_new_dirty_bitmap

2017-01-23 Thread Vladimir Sementsov-Ogievskiy
Realize .bdrv_can_store_new_dirty_bitmap interface. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-bitmap.c | 40 block/qcow2.c| 1 + block/qcow2.h| 4 3 files changed, 45 insertions(+) diff --git a/block/qcow2-bitmap.

[Qemu-devel] [PATCH 14/24] block: add bdrv_can_store_new_dirty_bitmap

2017-01-23 Thread Vladimir Sementsov-Ogievskiy
This will be needed to check some restrictions before making bitmap persistent in qmp-block-dirty-bitmap-add (this functionality will be added by future patch) Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- block.c | 22 ++ include/b

[Qemu-devel] [PATCH v12 02/16] block: Define BDRV_O_SHARE_RW

2017-01-23 Thread Fam Zheng
Signed-off-by: Fam Zheng --- include/block/block.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/block/block.h b/include/block/block.h index 8b0dcda..243839d 100644 --- a/include/block/block.h +++ b/include/block/block.h @@ -97,6 +97,8 @@ typedef struct HDGeometry {

[Qemu-devel] [PATCH v12 06/16] iotests: 055: Don't attach the drive to vm for drive-backup

2017-01-23 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/qemu-iotests/055 | 32 ++-- 1 file changed, 18 insertions(+), 14 deletions(-) diff --git a/tests/qemu-iotests/055 b/tests/qemu-iotests/055 index 1d3fd04..20a7596 100755 --- a/tests/qemu-iotests/055 +++ b/tests/qemu-iotests/055 @@ -45

[Qemu-devel] [PATCH v11 00/24] qcow2: persistent dirty bitmaps

2017-01-23 Thread Vladimir Sementsov-Ogievskiy
Hi all! There is a new update of qcow2-bitmap series - v11. web: https://src.openvz.org/users/vsementsov/repos/qemu/browse?at=qcow2-bitmap-v11 git: https://src.openvz.org/scm/~vsementsov/qemu.git (tag qcow2-bitmap-v11) v11: Fix automatic build test fail. 18: wording - "ASCII representation of

[Qemu-devel] [PATCH 07/24] qcow2: add bitmaps extension

2017-01-23 Thread Vladimir Sementsov-Ogievskiy
Add bitmap extension as specified in docs/specs/qcow2.txt. For now, just mirror extension header into Qcow2 state and check constraints. For now, disable image resize if it has bitmaps. It will be fixed later. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.c | 119 +

[Qemu-devel] [PATCH v12 07/16] iotests: 030: Read-only open image for getting map

2017-01-23 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/qemu-iotests/030 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/030 b/tests/qemu-iotests/030 index 54db54a..fe0c73f 100755 --- a/tests/qemu-iotests/030 +++ b/tests/qemu-iotests/030 @@ -114,7 +114,7 @@ class TestSingleD

[Qemu-devel] [PATCH v12 14/16] file-posix: Implement image locking

2017-01-23 Thread Fam Zheng
This implements open flag sensible image locking for local file and host device protocol. virtlockd in libvirt locks the first byte, so we start looking at the file bytes from 1. Quoting what was proposed by Kevin Wolf , there are four locking modes by combining two bits (BDRV_O_RDWR and BDRV_O_S

[Qemu-devel] [PATCH v12 00/16] block: Image locking series

2017-01-23 Thread Fam Zheng
v12: Fix test cases on old systems that doesn't have F_OFD_SETLK, such as RHEL 6. [Patchew] Trim the commit message of patch 15 to avoid bitrotting. v11: Move lock bytes from 1-2 to 0x10-0x12. [Daniel] v10: While we still don't have comprehensive propagation mechanism that will be provi

[Qemu-devel] [PATCH v12 11/16] iotests: 172: Use separate images for multiple devices

2017-01-23 Thread Fam Zheng
To avoid image lock failures. Signed-off-by: Fam Zheng --- tests/qemu-iotests/172 | 53 -- tests/qemu-iotests/172.out | 50 ++- 2 files changed, 54 insertions(+), 49 deletions(-) diff --git a/tests/qemu-iote

[Qemu-devel] [PATCH v12 05/16] block: Set "share-rw" flag in drive-backup when sync=none

2017-01-23 Thread Fam Zheng
In this case we may open the source's backing image chain multiple times. Setting share flag means the new open won't try to acquire or check any lock, once we implement image locking. Signed-off-by: Fam Zheng --- blockdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/blockdev.c b/blo

Re: [Qemu-devel] [PATCH v2 23/25] console: make screendump async

2017-01-23 Thread Marc-André Lureau
Hi On Mon, Jan 23, 2017 at 4:04 PM Gerd Hoffmann wrote: > Hi, > > > > If you only ref, you could have the image being modified while it is > > being saved asynchronously, this could result in tearing artefacts, > > no? > > Yes, but you have that problem _anyway_. screendump qmp command can ru

Re: [Qemu-devel] [PATCH v2 0/2] hw/usb/dev-hid: Make usb-tablet work with OS X/macOS guests

2017-01-23 Thread Gerd Hoffmann
Hi, > works like a charm on Sierra (10.12.1). Also tried it with > Fedora-Workstation-Live-x86_64-25-1.3.iso, where it behaves > identically with or without the mac_compat option. All tests > used qemu in SDL/X11-client mode. > > Tested-by: Gabriel Somlo Cool. Given that windows guests are

[Qemu-devel] [PATCH v12 15/16] qcow2: Force "no other writer" lock on bs->file

2017-01-23 Thread Fam Zheng
Writing to the same qcow2 file from two QEMU processes at the same time will never work correctly, so disable it even when the caller specifies BDRV_O_RDWR. Other formats are less vulnerable because they don't have internal snapshots thus qemu-img is less often misused to create live snapshot. Si

[Qemu-devel] [PATCH v12 16/16] tests: Add test-image-lock

2017-01-23 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/Makefile.include | 2 + tests/test-image-lock.c | 206 +++ tests/test-replication.c | 6 +- 3 files changed, 211 insertions(+), 3 deletions(-) create mode 100644 tests/test-image-lock.c diff --git a/tests/Make

[Qemu-devel] [PATCH v12 01/16] osdep: Add qemu_lock_fd and qemu_unlock_fd

2017-01-23 Thread Fam Zheng
They are wrappers of POSIX fcntl "file private locking", with a convenient "try lock" wrapper implemented with F_OFD_GETLK. Signed-off-by: Fam Zheng --- include/qemu/osdep.h | 3 +++ util/osdep.c | 48 2 files changed, 51 insertions(+) d

[Qemu-devel] [PATCH v12 03/16] qemu-io: Set "share-rw" flag together with read-only

2017-01-23 Thread Fam Zheng
qemu-io is a low level tool to read or modify guest visible data, which implies the user knows very well what is being done. Allowing reading from a locked image is harmless in most cases, so do it. Signed-off-by: Fam Zheng --- qemu-io.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qemu

[Qemu-devel] [PATCH v12 08/16] iotests: 087: Don't attach test image twice

2017-01-23 Thread Fam Zheng
The test scenario doesn't require the same image, instead it focuses on the duplicated node-name, so use null-co to avoid locking conflict. Signed-off-by: Fam Zheng --- tests/qemu-iotests/087 | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tests/qemu-iotests/087 b/tests

[Qemu-devel] [PATCH v12 09/16] iotests: 085: Avoid image locking conflict

2017-01-23 Thread Fam Zheng
In the case where we test the expected error when a blockdev-snapshot target already has a backing image, backing chain is opened multiple times. This will be a problem when we use image locking, so use a different backing file that is not already open. Signed-off-by: Fam Zheng --- tests/qemu-io

[Qemu-devel] [PATCH v12 10/16] iotests: 091: Quit QEMU before checking image

2017-01-23 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/qemu-iotests/091 | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/qemu-iotests/091 b/tests/qemu-iotests/091 index 32bbd56..10ac4a8 100755 --- a/tests/qemu-iotests/091 +++ b/tests/qemu-iotests/091 @@ -95,7 +95,9 @@ echo "vm2: qemu process running succe

[Qemu-devel] [PATCH v12 12/16] tests: Use null-co:// instead of /dev/null as the dummy image

2017-01-23 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/drive_del-test.c| 2 +- tests/nvme-test.c | 2 +- tests/usb-hcd-uhci-test.c | 2 +- tests/usb-hcd-xhci-test.c | 2 +- tests/virtio-blk-test.c | 2 +- tests/virtio-scsi-test.c | 4 ++-- 6 files changed, 7 insertions(+), 7 deletions(-) diff --git a

[Qemu-devel] [PATCH v12 13/16] tests: Disable image lock in test-replication

2017-01-23 Thread Fam Zheng
The COLO block replication architecture requires one disk to be shared between primary and secondary, in the test both processes use posix file protocol (instead of over NBD) so it is affected by image locking. Disable the lock. Signed-off-by: Fam Zheng --- tests/test-replication.c | 9 +++--

Re: [Qemu-devel] [PULL 30/30] target-sparc: fix up niagara machine

2017-01-23 Thread Peter Maydell
On 18 January 2017 at 22:38, Artyom Tarasenko wrote: > Remove the Niagara stub implementation from sun4u.c and add a machine, > compatible with Legion simulator from the OpenSPARC T1 project. > > The machine uses the firmware supplied with the OpenSPARC T1 project, > http://download.oracle.com/tec

Re: [Qemu-devel] [PULL v2 000/180] QAPI patches for 2017-01-16

2017-01-23 Thread Alex Bennée
Peter Maydell writes: > On 20 January 2017 at 15:46, Markus Armbruster wrote: >> Peter Maydell writes: >> >>> On 17 January 2017 at 16:43, Peter Maydell wrote: In any case, applied this pullreq to master. >>> >>> Although it works fine on my OSX box (with warnings) it seems >>> to have b

[Qemu-devel] [Bug 1658634] Re: Can't get correct display with latest QEMU and OVMF BIOS

2017-01-23 Thread Laszlo Ersek (Red Hat)
(1) What phase of the guest do you get invalid video output in? Do you see the TianoCore splash screen? Does the grub2 menu appear? (2) I cannot reproduce the issue (with a different guest OS anyway); I just tried QEMU (at d1c82f7cc344) and OVMF (built from edk2 at 7cf59c854f35), with stdvga; this

  1   2   3   4   >