On Sun, Jan 22, 2017 at 11:43 AM Li Qiang <liq...@gmail.com> wrote: > From: Li Qiang <liqiang...@360.cn> > > In virtio_gpu_set_scanout function, when creating the 'rect' > its refcount is set to 2, by pixman_image_create_bits and > qemu_create_displaysurface_pixman function. This can lead > a memory leak issues. This patch avoid this issue. > > Signed-off-by: Li Qiang <liqiang...@360.cn> >
Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com> > --- > hw/display/virtio-gpu.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c > index 7a15c61..4aecea3 100644 > --- a/hw/display/virtio-gpu.c > +++ b/hw/display/virtio-gpu.c > @@ -608,6 +608,7 @@ static void virtio_gpu_set_scanout(VirtIOGPU *g, > cmd->error = VIRTIO_GPU_RESP_ERR_UNSPEC; > return; > } > + pixman_image_unref(rect); > dpy_gfx_replace_surface(g->scanout[ss.scanout_id].con, > scanout->ds); > } > > -- > 1.8.3.1 > > > -- Marc-André Lureau
