[Qemu-devel] [Bug 1354279] Re: The guest will be destroyed after hot remove the VF from the guest.

2017-01-19 Thread Thomas Huth
** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1354279 Title: The guest will be destroyed after hot remove the VF from the guest. St

[Qemu-devel] [PATCH v10 07/16] iotests: 030: Read-only open image for getting map

2017-01-19 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/qemu-iotests/030 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/030 b/tests/qemu-iotests/030 index 54db54a..fe0c73f 100755 --- a/tests/qemu-iotests/030 +++ b/tests/qemu-iotests/030 @@ -114,7 +114,7 @@ class TestSingleD

Re: [Qemu-devel] [PATCH 0/3] cpu: numa: Fix the mapping initialization of VCPUs and NUMA nodes

2017-01-19 Thread Eduardo Habkost
On Thu, Jan 19, 2017 at 08:17:02PM +0800, Dou Liyang wrote: > Hi, Eduardo > > At 01/19/2017 01:06 AM, Eduardo Habkost wrote: > > On Wed, Jan 18, 2017 at 09:26:36PM +0800, Dou Liyang wrote: > > > Hi, All > > > > > > > ** > > > > ERROR:/tmp/qemu-test/src/tests/vhost-user-test.c:668:test_migrate: >

[Qemu-devel] [Bug 1422285] Re: The guest will be destroyed when hot plug the VF to guest for the second time.

2017-01-19 Thread Thomas Huth
** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1422285 Title: The guest will be destroyed when hot plug the VF to guest for the sec

Re: [Qemu-devel] [PATCH 0/2] block: Fix iotests 059

2017-01-19 Thread Eric Blake
On 01/19/2017 07:07 AM, Fam Zheng wrote: > The 059.out went out of sync, bring it back in line. > > Fam Zheng (2): > qapi: Tweak error message of bdrv_query_image_info > iotests: Fix reference output for 059 > Reviewed-by: Eric Blake > block/qapi.c | 4 ++-- > tests/qemu-iot

[Qemu-devel] [PULL 04/36] block: m25p80: Improve 1GiB Micron flash definition

2017-01-19 Thread Peter Maydell
From: Marcin Krzeminski n25q00 and mt25q01 devices share the same JEDEC ID. The difference between those two devices is number of dies and one bit in extended JEDEC bytes. This commit adds proper entry for both devices by introduction the number of dies and and new 25q00 entries. Signed-off-by:

[Qemu-devel] [PATCH v10 03/16] qemu-io: Set "share-rw" flag together with read-only

2017-01-19 Thread Fam Zheng
qemu-io is a low level tool to read or modify guest visible data, which implies the user knows very well what is being done. Allowing reading from a locked image is harmless in most cases, so do it. Signed-off-by: Fam Zheng --- qemu-io.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qemu

Re: [Qemu-devel] [PATCH v6 0/2] allow blockdev-add for NFS

2017-01-19 Thread Peter Lieven
Am 18.01.2017 um 10:59 schrieb Kevin Wolf: Am 17.01.2017 um 16:14 hat Peter Lieven geschrieben: Am 31.10.2016 um 18:20 schrieb Kevin Wolf: Am 31.10.2016 um 16:05 hat Ashijeet Acharya geschrieben: Previously posted series patches: v5: https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg075

Re: [Qemu-devel] [RFC PATCH v0] softfloat: Add round-to-odd rounding mode

2017-01-19 Thread Eric Blake
On 01/18/2017 11:14 PM, Bharata B Rao wrote: > Power ISA 3.0 introduces a few quadruple precision floating point > instructions that support round-to-add rounding mode. The s/add/odd/ > round-to-odd mode is explained as under: > > Let Z be the intermediate arithmetic result or the operand of a c

[Qemu-devel] [Bug 1587535] Re: Incorrect MAS1_TSIZE_SHIFT in ppce500_spin.c causes incorrectly sized TLB.

2017-01-19 Thread Thomas Huth
Patch had been released with QEMU 2.7 ** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1587535 Title: Incorrect MAS1_TSIZE_SHIFT in pp

[Qemu-devel] [Bug 1006655] Re: Can't convert to vmdk with the streamOptimized subformat

2017-01-19 Thread Thomas Huth
Patch 3efffc3292d9427 had been released with QEMU 2.5 ** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1006655 Title: Can't convert to

[Qemu-devel] [PATCH v10 04/16] qemu-img: Set "share-rw" flag in read-only commands

2017-01-19 Thread Fam Zheng
Checking the status of an image when it is being used by guest is usually useful, and there is no risk of corrupting data, so don't let the upcoming image locking feature limit this use case. Signed-off-by: Fam Zheng --- qemu-img.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-)

Re: [Qemu-devel] [PATCH] i386: Support "-cpu host" on TCG too

2017-01-19 Thread Cornelia Huck
On Tue, 17 Jan 2017 18:43:40 +0100 David Hildenbrand wrote: > Uncompiled and untested. @Jason: have you given this a try? > @Conny and Christian, feel free to pick up and modify if this makes > sense > > From 4a2af1ca47421b68eb7677cd91af350dd9be4e0e Mon Sep 17 00:00:00 2001 > From: David Hild

[Qemu-devel] [Bug 1066909] Re: App-level clone emulation for microblaze is broken

2017-01-19 Thread Thomas Huth
** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1066909 Title: App-level clone emulation for microblaze is broken Status in QEMU: F

[Qemu-devel] [PATCH] migration: re-active images while migration been canceled after inactive them

2017-01-19 Thread zhanghailiang
commit fe904ea8242cbae2d7e69c052c754b8f5f1ba1d6 fixed a case which migration aborted QEMU because it didn't regain the control of images while some errors happened. Actually, there are another two cases can trigger the same error reports: " bdrv_co_do_pwritev: Assertion `!(bs->open_flags & 0x0800)

[Qemu-devel] [PATCH v10 05/16] block: Set "share-rw" flag in drive-backup when sync=none

2017-01-19 Thread Fam Zheng
In this case we may open the source's backing image chain multiple times. Setting share flag means the new open won't try to acquire or check any lock, once we implement image locking. Signed-off-by: Fam Zheng --- blockdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/blockdev.c b/blo

Re: [Qemu-devel] [RFC 11/13] numa: use new machine.cpu property with -numa cpus=... CLI

2017-01-19 Thread Igor Mammedov
On Wed, 18 Jan 2017 16:46:37 -0200 Eduardo Habkost wrote: > On Wed, Jan 18, 2017 at 06:13:27PM +0100, Igor Mammedov wrote: > > add compat layer to legacy cpu_index based '-numa cpus=...' > > CLI option, which will use new machine.cpu property to set > > numa mapping if that propety is available.

[Qemu-devel] [PATCH v10 00/16] block: Image locking series

2017-01-19 Thread Fam Zheng
v10: While we still don't have comprehensive propagation mechanism that will be provided by new op blocker system for "permissive modes", the locking enabled by default is regardlessly useful and long overdue. So I think we should merge this for 2.9 and build user options on top later when the op b

Re: [Qemu-devel] [PATCH v3 1/2] linux-user: fix settime old value location

2017-01-19 Thread Laurent Vivier
Le 19/01/2017 à 15:23, Pranith Kumar a écrit : > From: Marc-André Lureau > > old_value is the 4th argument of timer_settime(), not the 2nd. > > Signed-off-by: Marc-André Lureau > Signed-off-by: Pranith Kumar > --- > linux-user/syscall.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 delet

[Qemu-devel] [PATCH v10 06/16] iotests: 055: Don't attach the drive to vm for drive-backup

2017-01-19 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/qemu-iotests/055 | 32 ++-- 1 file changed, 18 insertions(+), 14 deletions(-) diff --git a/tests/qemu-iotests/055 b/tests/qemu-iotests/055 index 1d3fd04..20a7596 100755 --- a/tests/qemu-iotests/055 +++ b/tests/qemu-iotests/055 @@ -45

[Qemu-devel] [PATCH v10 02/16] block: Define BDRV_O_SHARE_RW

2017-01-19 Thread Fam Zheng
Signed-off-by: Fam Zheng --- include/block/block.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/block/block.h b/include/block/block.h index 8b0dcda..243839d 100644 --- a/include/block/block.h +++ b/include/block/block.h @@ -97,6 +97,8 @@ typedef struct HDGeometry {

[Qemu-devel] [PATCH v10 12/16] tests: Use null-co:// instead of /dev/null as the dummy image

2017-01-19 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/drive_del-test.c| 2 +- tests/nvme-test.c | 2 +- tests/usb-hcd-uhci-test.c | 2 +- tests/usb-hcd-xhci-test.c | 2 +- tests/virtio-blk-test.c | 2 +- tests/virtio-scsi-test.c | 4 ++-- 6 files changed, 7 insertions(+), 7 deletions(-) diff --git a

Re: [Qemu-devel] [PATCH v2 4/4] ARRAY_SIZE: check that argument is an array

2017-01-19 Thread Michael S. Tsirkin
On Thu, Jan 19, 2017 at 08:53:34AM -0600, Eric Blake wrote: > On 01/18/2017 02:55 PM, Michael S. Tsirkin wrote: > > It's a familiar pattern: some code uses ARRAY_SIZE, then refactoring > > changes the argument from an array to a pointer to a dynamically > > allocated buffer. Code keeps compiling b

[Qemu-devel] [PATCH v10 08/16] iotests: 087: Don't attach test image twice

2017-01-19 Thread Fam Zheng
The test scenario doesn't require the same image, instead it focuses on the duplicated node-name, so use null-co to avoid locking conflict. Signed-off-by: Fam Zheng --- tests/qemu-iotests/087 | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tests/qemu-iotests/087 b/tests

Re: [Qemu-devel] [PATCH v2 2/6] qdict: Add convenience helpers for wrapped puts

2017-01-19 Thread Eric Blake
On 01/19/2017 03:25 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Quite a few users of qdict_put() were manually wrapping a >> non-QObject. We can make such call-sites shorter, by providing >> common macros to do the tedious work. Also shorten nearby >> qdict_put_obj(,,QOBJECT()) sequen

[Qemu-devel] [PATCH v10 11/16] iotests: 172: Use separate images for multiple devices

2017-01-19 Thread Fam Zheng
To avoid image lock failures. Signed-off-by: Fam Zheng --- tests/qemu-iotests/172 | 53 -- tests/qemu-iotests/172.out | 50 ++- 2 files changed, 54 insertions(+), 49 deletions(-) diff --git a/tests/qemu-iote

[Qemu-devel] [PATCH v10 09/16] iotests: 085: Avoid image locking conflict

2017-01-19 Thread Fam Zheng
In the case where we test the expected error when a blockdev-snapshot target already has a backing image, backing chain is opened multiple times. This will be a problem when we use image locking, so use a different backing file that is not already open. Signed-off-by: Fam Zheng --- tests/qemu-io

Re: [Qemu-devel] [PATCH v3 1/2] linux-user: fix settime old value location

2017-01-19 Thread Pranith Kumar
On Thu, Jan 19, 2017 at 10:05 AM, Laurent Vivier wrote: > Le 19/01/2017 à 15:23, Pranith Kumar a écrit : >> From: Marc-André Lureau >> >> old_value is the 4th argument of timer_settime(), not the 2nd. >> >> Signed-off-by: Marc-André Lureau >> Signed-off-by: Pranith Kumar >> --- >> linux-user/s

[Qemu-devel] [PATCH v10 10/16] iotests: 091: Quit QEMU before checking image

2017-01-19 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/qemu-iotests/091 | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/qemu-iotests/091 b/tests/qemu-iotests/091 index 32bbd56..10ac4a8 100755 --- a/tests/qemu-iotests/091 +++ b/tests/qemu-iotests/091 @@ -95,7 +95,9 @@ echo "vm2: qemu process running succe

[Qemu-devel] [PATCH v10 15/16] qcow2: Force "no other writer" lock on bs->file

2017-01-19 Thread Fam Zheng
Writing to the same qcow2 file from two QEMU processes at the same time will never work correctly, so disable it even when the caller specifies BDRV_O_RDWR. Other formats are less vulnerable because they don't have internal snapshots thus qemu-img is less often misused to create live snapshot. Si

Re: [Qemu-devel] [PATCH v4 1/2] linux-user: fix settime old value location

2017-01-19 Thread Laurent Vivier
Le 19/01/2017 à 16:15, Pranith Kumar a écrit : > From: Marc-André Lureau > > old_value is the 4th argument of timer_settime(), not the 2nd. > > Signed-off-by: Marc-André Lureau > Signed-off-by: Pranith Kumar Reviewed-by: Laurent Vivier > --- > linux-user/syscall.c | 8 ++-- > 1 file ch

[Qemu-devel] [PATCH v10 13/16] tests: Disable image lock in test-replication

2017-01-19 Thread Fam Zheng
The COLO block replication architecture requires one disk to be shared between primary and secondary, in the test both processes use posix file protocol (instead of over NBD) so it is affected by image locking. Disable the lock. Signed-off-by: Fam Zheng --- tests/test-replication.c | 9 +++--

Re: [Qemu-devel] [PATCH v2 4/6] fdc-test: Avoid deprecated 'change' command

2017-01-19 Thread Eric Blake
On 01/19/2017 03:30 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Use the preferred blockdev-change-medium command instead. >> >> Signed-off-by: Eric Blake >> Reviewed-by: John Snow >> --- >> tests/fdc-test.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --g

[Qemu-devel] [PATCH v10 16/16] tests: Add test-image-lock

2017-01-19 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/Makefile.include | 2 + tests/test-image-lock.c | 200 +++ tests/test-replication.c | 6 +- 3 files changed, 205 insertions(+), 3 deletions(-) create mode 100644 tests/test-image-lock.c diff --git a/tests/Make

Re: [Qemu-devel] [RFC PATCH v0] softfloat: Add round-to-odd rounding mode

2017-01-19 Thread Richard Henderson
On 01/18/2017 09:14 PM, Bharata B Rao wrote: Power ISA 3.0 introduces a few quadruple precision floating point instructions that support round-to-add rounding mode. The round-to-odd mode is explained as under: Let Z be the intermediate arithmetic result or the operand of a convert operation. If

Re: [Qemu-devel] [RFC 01/13] numa: access CPU's node id via property in hmp_info_numa()

2017-01-19 Thread Igor Mammedov
On Wed, 18 Jan 2017 16:18:20 -0200 Eduardo Habkost wrote: > On Wed, Jan 18, 2017 at 06:13:17PM +0100, Igor Mammedov wrote: > > Move vcpu's assocciated numa_node field out of generic CPUState > > into inherited classes that actually care about cpu<->numa mapping > > and make monitor 'info numa' ge

[Qemu-devel] [PATCH v10 14/16] file-posix: Implement image locking

2017-01-19 Thread Fam Zheng
This implements open flag sensible image locking for local file and host device protocol. virtlockd in libvirt locks the first byte, so we start looking at the file bytes from 1. Quoting what was proposed by Kevin Wolf , there are four locking modes by combining two bits (BDRV_O_RDWR and BDRV_O_S

Re: [Qemu-devel] [PATCH v2 6/6] qapi: Promote blockdev-change-medium arguments to QAPI type

2017-01-19 Thread Eric Blake
On 01/19/2017 03:48 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Having a named rather than anonymous C type will make it easier >> to improve the testsuite in a later patch. > > Post it together with said later patch then. It was that way in the v1 series, but I had enough else going

Re: [Qemu-devel] [PATCH v6 0/2] allow blockdev-add for NFS

2017-01-19 Thread Kevin Wolf
Am 19.01.2017 um 16:34 hat Peter Lieven geschrieben: > Am 19.01.2017 um 16:20 schrieb Kevin Wolf: > >Am 19.01.2017 um 15:59 hat Eric Blake geschrieben: > >>On 01/19/2017 08:30 AM, Peter Lieven wrote: > >qemu-img: Could not open > >'nfs://172.21.200.61/vcore-dev-cdrom/templates/VC_debian8-20

Re: [Qemu-devel] [RFC 08/13] pc: add writeonly 'cpu' property to PCMachine

2017-01-19 Thread Igor Mammedov
On Wed, 18 Jan 2017 16:27:21 -0200 Eduardo Habkost wrote: > On Wed, Jan 18, 2017 at 06:13:24PM +0100, Igor Mammedov wrote: > > it will allow generic numa code to set cpu to numa node mapping > > in target independent manner in the next patch. > > > > Signed-off-by: Igor Mammedov > > This loo

[Qemu-devel] [Bug 1588328] Re: Qemu 2.6 Solaris 9 Sparc Segmentation Fault

2017-01-19 Thread Thomas Huth
** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1588328 Title: Qemu 2.6 Solaris 9 Sparc Segmentation Fault Status in QEMU: Fix Rele

[Qemu-devel] [PULL 2/2] error: Report certain hints on stderr when no monitor

2017-01-19 Thread Markus Armbruster
From: Marc-André Lureau Hints printed with error_printf_unless_qmp() are suppressed outside monitor context. Reproducer: $ qemu-system-x86_64 -m 1Z qemu-system-x86_64: -m 1Z: Parameter 'size' expects a size Print to stderr instead. The reproducer now additionally prints: You may

Re: [Qemu-devel] [PATCH v6 0/2] allow blockdev-add for NFS

2017-01-19 Thread Peter Lieven
Am 19.01.2017 um 16:42 schrieb Kevin Wolf: Am 19.01.2017 um 16:34 hat Peter Lieven geschrieben: Am 19.01.2017 um 16:20 schrieb Kevin Wolf: Am 19.01.2017 um 15:59 hat Eric Blake geschrieben: On 01/19/2017 08:30 AM, Peter Lieven wrote: qemu-img: Could not open 'nfs://172.21.200.61/vcore-dev-cdr

[Qemu-devel] [PULL 0/2] Error reporting patches for 2017-01-19

2017-01-19 Thread Markus Armbruster
The following changes since commit ab4b92760498e097ff668f0e9c83aa87a2ec1128: Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' into staging (2017-01-17 16:54:09 +) are available in the git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-error-2017-01-19

Re: [Qemu-devel] [PATCH v2 4/4] ARRAY_SIZE: check that argument is an array

2017-01-19 Thread Eric Blake
On 01/18/2017 02:55 PM, Michael S. Tsirkin wrote: > It's a familiar pattern: some code uses ARRAY_SIZE, then refactoring > changes the argument from an array to a pointer to a dynamically > allocated buffer. Code keeps compiling but any ARRAY_SIZE calls now > return the size of the pointer divided

Re: [Qemu-devel] [PATCH v6 0/2] allow blockdev-add for NFS

2017-01-19 Thread Peter Lieven
Am 19.01.2017 um 16:42 schrieb Kevin Wolf: Am 19.01.2017 um 16:34 hat Peter Lieven geschrieben: Am 19.01.2017 um 16:20 schrieb Kevin Wolf: Am 19.01.2017 um 15:59 hat Eric Blake geschrieben: On 01/19/2017 08:30 AM, Peter Lieven wrote: qemu-img: Could not open 'nfs://172.21.200.61/vcore-dev-cdr

[Qemu-devel] [PULL 1/2] error: error_setg_errno(): errno gets preserved

2017-01-19 Thread Markus Armbruster
From: Sascha Silbe C11 allows errno to be clobbered by pretty much any library function call, so in general callers need to take care to save errno before calling other functions. However, for error reporting functions this is rather awkward and can make the code on the caller side more complica

Re: [Qemu-devel] [PATCH v2 1/6] Add cfgend parameter for ARM CPU selection.

2017-01-19 Thread Peter Maydell
On 18 January 2017 at 16:52, Eduardo Habkost wrote: > On Tue, Jan 17, 2017 at 11:52:24AM +, Peter Maydell wrote: >> Oops, I'd forgotten there was board-specific code for handling >> cpu feature flags. I think we want to change the other boards >> to do it like the virt board does, but maybe I'

Re: [Qemu-devel] [RFC 09/13] numa: introduce '-numa cpu' cpu option

2017-01-19 Thread Igor Mammedov
On Wed, 18 Jan 2017 12:22:01 -0600 Eric Blake wrote: > On 01/18/2017 11:13 AM, Igor Mammedov wrote: > > It allows to specify mapping of a CPU to NUMA node on CLI. > > Option should be repeated for each present/possible CPU. > > Example for PC machine: > > -numa node,nodeid=0 -numa node,nodeid=1

Re: [Qemu-devel] [RFC 08/13] pc: add writeonly 'cpu' property to PCMachine

2017-01-19 Thread Igor Mammedov
On Wed, 18 Jan 2017 16:57:13 -0200 Eduardo Habkost wrote: > On Wed, Jan 18, 2017 at 06:13:24PM +0100, Igor Mammedov wrote: > > it will allow generic numa code to set cpu to numa node mapping > > in target independent manner in the next patch. > > > > Signed-off-by: Igor Mammedov > > --- > > hw

[Qemu-devel] [Bug 1524546] Re: qemu-img rebase error message mentions wrong file name

2017-01-19 Thread Elaye Karstadt
I'm pretty sure this is working as intended. If you observe the code, qemu-img first opens filename. When qemu opens a file, it needs full access to it's chain of backing files - Hence, if the old backing file does not exist, opening filename fails. (Not an active qemu dev, just passing through)

Re: [Qemu-devel] [PATCH 01/18] tcg: add support for 128bit vector type

2017-01-19 Thread Richard Henderson
On 01/19/2017 05:04 AM, Kirill Batuzov wrote: On Wed, 18 Jan 2017, Richard Henderson wrote: On 01/17/2017 01:07 AM, Kirill Batuzov wrote: +static inline TCGv_v128 tcg_global_mem_new_v128(TCGv_ptr reg, intptr_t offset, +const char *name) +{ +i

[Qemu-devel] [PATCH v4 2/2] linux-user: fix tcg/mmap test

2017-01-19 Thread Pranith Kumar
From: Marc-André Lureau tests/tcg/mmap test fails with values other than default target page size. When creating a map beyond EOF, extra anonymous pages are added up to the target page boundary. Currently, this operation is performed only when qemu_real_host_page_size < TARGET_PAGE_SIZE, but it s

Re: [Qemu-devel] [PATCH v6 0/2] allow blockdev-add for NFS

2017-01-19 Thread Eric Blake
On 01/19/2017 08:30 AM, Peter Lieven wrote: >>> qemu-img: Could not open >>> 'nfs://172.21.200.61/vcore-dev-cdrom/templates/VC_debian8-20170116.qcow2,linux?readahead=131072': >>> Block protocol 'nfs' doesn't support the option 'readahead-size' >>> >>> Please let me know if the below fix would be co

Re: [Qemu-devel] [Bug 645662] Re: Python 3.1.2 math errors with Qemu 0.12.5

2017-01-19 Thread Arno Wagner
Hi, I just tried for about 2 hours without success or getting any useful diagnostic to compile and run current qemu 2.8. No console, no window opens, -curses does not work in .configure, despite ncurses-dev being installed, etc. Quite frankly, as I have not used qemu for several years now, I c

[Qemu-devel] [PATCH v4 1/2] linux-user: fix settime old value location

2017-01-19 Thread Pranith Kumar
From: Marc-André Lureau old_value is the 4th argument of timer_settime(), not the 2nd. Signed-off-by: Marc-André Lureau Signed-off-by: Pranith Kumar --- linux-user/syscall.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c

Re: [Qemu-devel] [PATCH v6 0/2] allow blockdev-add for NFS

2017-01-19 Thread Kevin Wolf
Am 19.01.2017 um 16:44 hat Peter Lieven geschrieben: > Am 19.01.2017 um 16:42 schrieb Kevin Wolf: > >Am 19.01.2017 um 16:34 hat Peter Lieven geschrieben: > >>Am 19.01.2017 um 16:20 schrieb Kevin Wolf: > >>>Am 19.01.2017 um 15:59 hat Eric Blake geschrieben: > On 01/19/2017 08:30 AM, Peter Lieven

Re: [Qemu-devel] [PATCH v6 0/2] allow blockdev-add for NFS

2017-01-19 Thread Kevin Wolf
Am 19.01.2017 um 15:59 hat Eric Blake geschrieben: > On 01/19/2017 08:30 AM, Peter Lieven wrote: > >>> qemu-img: Could not open > >>> 'nfs://172.21.200.61/vcore-dev-cdrom/templates/VC_debian8-20170116.qcow2,linux?readahead=131072': > >>> Block protocol 'nfs' doesn't support the option 'readahead-si

[Qemu-devel] [Bug 1626972] Re: QEMU memfd_create fallback mechanism change for security drivers

2017-01-19 Thread Launchpad Bug Tracker
This bug was fixed in the package qemu - 1:2.6.1+dfsg-0ubuntu5.2 --- qemu (1:2.6.1+dfsg-0ubuntu5.2) yakkety; urgency=medium [ Rafael David Tinoco ] * Fixed wrong migration blocker when vhost is used (LP: #1626972) - d/p/vhost_migration-blocker-only-if-shared-log-is-used.patch

[Qemu-devel] [PATCH] qemu-img: optimize is_allocated_sectors_min

2017-01-19 Thread Peter Lieven
the current implementation always splits requests if a buffer begins or ends with zeroes independent of the length of the zero area. Change this to really only split off zero areas that have at least a length of 'min' bytes. Signed-off-by: Peter Lieven --- qemu-img.c | 38 ---

Re: [Qemu-devel] [RFC PATCH v0] softfloat: Add round-to-odd rounding mode

2017-01-19 Thread Peter Maydell
On 19 January 2017 at 14:47, Eric Blake wrote: > On 01/18/2017 11:14 PM, Bharata B Rao wrote: >> round-to-odd mode is explained as under: >> >> Let Z be the intermediate arithmetic result or the operand of a convert >> operation. If Z can be represented exactly in the target format, the >> result

[Qemu-devel] [Bug 1626972] Update Released

2017-01-19 Thread Brian Murray
The verification of the Stable Release Update for qemu has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a reg

Re: [Qemu-devel] [PATCH v6 0/2] allow blockdev-add for NFS

2017-01-19 Thread Peter Lieven
Am 19.01.2017 um 16:20 schrieb Kevin Wolf: Am 19.01.2017 um 15:59 hat Eric Blake geschrieben: On 01/19/2017 08:30 AM, Peter Lieven wrote: qemu-img: Could not open 'nfs://172.21.200.61/vcore-dev-cdrom/templates/VC_debian8-20170116.qcow2,linux?readahead=131072': Block protocol 'nfs' doesn't suppo

Re: [Qemu-devel] [Qemu-block] [PATCH v10 14/16] file-posix: Implement image locking

2017-01-19 Thread Eric Blake
On 01/19/2017 09:49 AM, Daniel P. Berrange wrote: > On Thu, Jan 19, 2017 at 10:38:14PM +0800, Fam Zheng wrote: >> This implements open flag sensible image locking for local file >> and host device protocol. >> >> virtlockd in libvirt locks the first byte, so we start looking at the >> file bytes fr

Re: [Qemu-devel] [RFC PATCH v0] softfloat: Add round-to-odd rounding mode

2017-01-19 Thread Peter Maydell
On 19 January 2017 at 15:29, Richard Henderson wrote: > The description in see in the manual on page 387 is more precise than what > you quote above: > > # If IR is exact, choose IR. > # Otherwise choose NL, and if Guard=1, Round=1 or Sticky=1, > # the least significant bit of the result is

Re: [Qemu-devel] VM Hung issue

2017-01-19 Thread Stefan Hajnoczi
On Wed, Jan 18, 2017 at 10:46 AM, Umar Draz wrote: > Well yes, whenever vm hung, then there is nothing on vnc display, and > network of that vm is also down. I can not ping the vm that time. Are you saying the VNC client connects successfully to a hung VM but the display is blank? Stefan

Re: [Qemu-devel] [PATCH v10 14/16] file-posix: Implement image locking

2017-01-19 Thread Daniel P. Berrange
On Thu, Jan 19, 2017 at 10:38:14PM +0800, Fam Zheng wrote: > This implements open flag sensible image locking for local file > and host device protocol. > > virtlockd in libvirt locks the first byte, so we start looking at the > file bytes from 1. > > Quoting what was proposed by Kevin Wolf , the

Re: [Qemu-devel] Call for GSoC 2017 mentors & project ideas

2017-01-19 Thread Stefan Hajnoczi
On Wed, Jan 18, 2017 at 11:12 AM, Alex Bennée wrote: > > Stefan Hajnoczi writes: > >> QEMU will be applying to Google Summer of Code again this year. >> >> Do you want to help some of the most talented university students >> begin contributing to open source by working on our codebase and >> join

[Qemu-devel] qemu-img: complains about missing iscsi option group

2017-01-19 Thread Peter Lieven
Hi all, since commit f57b4b5 (blockdev: prepare iSCSI block driver for dynamic loading) qemu-img complains about a missing option group several times. ~/git/qemu$ ./qemu-img info iscsi://172.21.200.56:3260/iqn.2001-05.com.equallogic:0-8a0906-69d384e0a-aa3004e55e15878d-00lieven-data/0 qemu-im

Re: [Qemu-devel] [PATCH] qemu-img: optimize is_allocated_sectors_min

2017-01-19 Thread Peter Lieven
Please ignore this one The code was suboptimal. Will send v2. Peter Am 19.01.2017 um 16:56 schrieb Peter Lieven: the current implementation always splits requests if a buffer begins or ends with zeroes independent of the length of the zero area. Change this to really only split off zero areas t

Re: [Qemu-devel] [PATCH v6 0/2] allow blockdev-add for NFS

2017-01-19 Thread Peter Lieven
Am 19.01.2017 um 16:55 schrieb Kevin Wolf: Am 19.01.2017 um 16:44 hat Peter Lieven geschrieben: Am 19.01.2017 um 16:42 schrieb Kevin Wolf: Am 19.01.2017 um 16:34 hat Peter Lieven geschrieben: Am 19.01.2017 um 16:20 schrieb Kevin Wolf: Am 19.01.2017 um 15:59 hat Eric Blake geschrieben: On 01/

[Qemu-devel] [PATCH V2] qemu-img: optimize is_allocated_sectors_min

2017-01-19 Thread Peter Lieven
the current implementation always splits requests if a buffer begins or ends with zeroes independent of the length of the zero area. Change this to really only split off zero areas that have at least a length of 'min' bytes. Signed-off-by: Peter Lieven --- qemu-img.c | 44 ++-

Re: [Qemu-devel] qemu-img: complains about missing iscsi option group

2017-01-19 Thread Daniel P. Berrange
On Thu, Jan 19, 2017 at 05:30:20PM +0100, Peter Lieven wrote: > Hi all, > > > since commit f57b4b5 (blockdev: prepare iSCSI block driver for dynamic > loading) > > qemu-img complains about a missing option group several times. > > > ~/git/qemu$ ./qemu-img info > iscsi://172.21.200.56:3260/iq

[Qemu-devel] [PATCH] bitmap: assert that start and nr are non negative

2017-01-19 Thread Peter Lieven
commit e1123a3b introduced a data corruption regression in the iscsi driver because it passed -1 as nr to bitmap_set and bitmap_clear. Add an assertion to catch such flaws earlier. Suggested-by: Fam Zheng Signed-off-by: Peter Lieven --- util/bitmap.c | 8 1 file changed, 8 insertions(+

Re: [Qemu-devel] [PATCH 01/16] aio: introduce aio_co_schedule and aio_co_wake

2017-01-19 Thread Stefan Hajnoczi
On Wed, Jan 18, 2017 at 04:40:29PM +0100, Paolo Bonzini wrote: > On 18/01/2017 15:33, Stefan Hajnoczi wrote: > > On Fri, Jan 13, 2017 at 02:17:16PM +0100, Paolo Bonzini wrote: > >> +static void co_schedule_bh_cb(void *opaque) > >> +{ > >> +AioContext *ctx = opaque; > >> +QSLIST_HEAD(, Corou

Re: [Qemu-devel] [PATCH RFC v2 1/6] docs/block-replication: Add description for shared-disk case

2017-01-19 Thread Stefan Hajnoczi
On Thu, Jan 19, 2017 at 10:50:19AM +0800, Hailiang Zhang wrote: > On 2017/1/13 21:41, Stefan Hajnoczi wrote: > > On Mon, Dec 05, 2016 at 04:34:59PM +0800, zhanghailiang wrote: > > > +Issue qmp command: > > > + { 'execute': 'blockdev-add', > > > +'arguments': { > > > +'driver': 'replica

Re: [Qemu-devel] [PATCH 01/18] tcg: add support for 128bit vector type

2017-01-19 Thread Kirill Batuzov
On 19.01.2017 18:09, Richard Henderson wrote: On 01/19/2017 05:04 AM, Kirill Batuzov wrote: On Wed, 18 Jan 2017, Richard Henderson wrote: On 01/17/2017 01:07 AM, Kirill Batuzov wrote: +static inline TCGv_v128 tcg_global_mem_new_v128(TCGv_ptr reg, intptr_t offset, +

Re: [Qemu-devel] qemu-img: complains about missing iscsi option group

2017-01-19 Thread Peter Lieven
Am 19.01.2017 um 17:38 schrieb Daniel P. Berrange: On Thu, Jan 19, 2017 at 05:30:20PM +0100, Peter Lieven wrote: Hi all, since commit f57b4b5 (blockdev: prepare iSCSI block driver for dynamic loading) qemu-img complains about a missing option group several times. ~/git/qemu$ ./qemu-img info

Re: [Qemu-devel] [PATCH 10/16] block: explicitly acquire aiocontext in timers that need it

2017-01-19 Thread Stefan Hajnoczi
On Wed, Jan 18, 2017 at 05:44:24PM +0100, Paolo Bonzini wrote: > On 18/01/2017 16:43, Stefan Hajnoczi wrote: > > On Fri, Jan 13, 2017 at 02:17:25PM +0100, Paolo Bonzini wrote: > >> diff --git a/block/null.c b/block/null.c > >> index b300390..356209a 100644 > >> --- a/block/null.c > >> +++ b/block/n

Re: [Qemu-devel] [PATCH 00/16] aio_context_acquire/release pushdown, part 2

2017-01-19 Thread Stefan Hajnoczi
On Wed, Jan 18, 2017 at 05:31:03PM +0100, Paolo Bonzini wrote: > > > On 18/01/2017 17:03, Stefan Hajnoczi wrote: > > On Fri, Jan 13, 2017 at 02:17:15PM +0100, Paolo Bonzini wrote: > >> This series pushes down aio_context_acquire/release to the point > >> where we can actually reason on using diff

Re: [Qemu-devel] qemu-img: complains about missing iscsi option group

2017-01-19 Thread Daniel P. Berrange
On Thu, Jan 19, 2017 at 05:57:45PM +0100, Peter Lieven wrote: > Am 19.01.2017 um 17:38 schrieb Daniel P. Berrange: > > On Thu, Jan 19, 2017 at 05:30:20PM +0100, Peter Lieven wrote: > > > Hi all, > > > > > > > > > since commit f57b4b5 (blockdev: prepare iSCSI block driver for dynamic > > > loadin

[Qemu-devel] [PATCH v7 03/27] mttcg: Add missing tb_lock/unlock() in cpu_exec_step()

2017-01-19 Thread Alex Bennée
From: Pranith Kumar The recent patch enabling lock assertions uncovered the missing lock acquisition in cpu_exec_step(). This patch adds them. CC: Richard Henderson CC: Alex Bennée Signed-off-by: Pranith Kumar --- cpu-exec.c | 4 1 file changed, 4 insertions(+) diff --git a/cpu-exec.c

[Qemu-devel] [PATCH v7 06/27] tcg: add kick timer for single-threaded vCPU emulation

2017-01-19 Thread Alex Bennée
Currently we rely on the side effect of the main loop grabbing the iothread_mutex to give any long running basic block chains a kick to ensure the next vCPU is scheduled. As this code is being re-factored and rationalised we now do it explicitly here. Signed-off-by: Alex Bennée Reviewed-by: Richa

[Qemu-devel] [PATCH v7 05/27] tcg: add options for enabling MTTCG

2017-01-19 Thread Alex Bennée
From: KONRAD Frederic We know there will be cases where MTTCG won't work until additional work is done in the front/back ends to support. It will however be useful to be able to turn it on. As a result MTTCG will default to off unless the combination is supported. However the user can turn it on

[Qemu-devel] [PATCH v7 07/27] tcg: rename tcg_current_cpu to tcg_current_rr_cpu

2017-01-19 Thread Alex Bennée
..and make the definition local to cpus. In preparation for MTTCG the concept of a global tcg_current_cpu will no longer make sense. However we still need to keep track of it in the single-threaded case to be able to exit quickly when required. qemu_cpu_kick_no_halt() moves and becomes qemu_cpu_ki

[Qemu-devel] [PATCH v7 01/27] docs: new design document multi-thread-tcg.txt

2017-01-19 Thread Alex Bennée
This documents the current design for upgrading TCG emulation to take advantage of modern CPUs by running a thread-per-CPU. The document goes through the various areas of the code affected by such a change and proposes design requirements for each part of the solution. The text marked with (Curren

[Qemu-devel] [PATCH v7 04/27] tcg: move TCG_MO/BAR types into own file

2017-01-19 Thread Alex Bennée
We'll be using the memory ordering definitions to define values for both the host and guest. To avoid fighting with circular header dependencies just move these types into their own minimal header. Signed-off-by: Alex Bennée --- tcg/tcg-mo.h | 45 + tc

[Qemu-devel] [PATCH v7 02/27] mttcg: translate-all: Enable locking debug in a debug build

2017-01-19 Thread Alex Bennée
From: Pranith Kumar Enable tcg lock debug asserts in a debug build by default instead of relying on DEBUG_LOCKING. None of the other DEBUG_* macros have asserts, so this patch removes DEBUG_LOCKING and enable these asserts in a debug build. CC: Richard Henderson Signed-off-by: Pranith Kumar [A

[Qemu-devel] [PATCH v7 20/27] target-arm: ensure BQL taken for ARM_CP_IO register access

2017-01-19 Thread Alex Bennée
Most ARMCPRegInfo structures just allow updating of the CPU field. However some have more complex operations that *may* be have cross vCPU effects therefor need to be serialised. The most obvious examples at the moment are things that affect the GICv3 IRQ controller. To avoid applying this requirem

[Qemu-devel] [PATCH v7 08/27] tcg: drop global lock during TCG code execution

2017-01-19 Thread Alex Bennée
From: Jan Kiszka This finally allows TCG to benefit from the iothread introduction: Drop the global mutex while running pure TCG CPU code. Reacquire the lock when entering MMIO or PIO emulation, or when leaving the TCG loop. We have to revert a few optimization for the current TCG threading mode

[Qemu-devel] [PATCH v7 10/27] tcg: enable tb_lock() for SoftMMU

2017-01-19 Thread Alex Bennée
tb_lock() has long been used for linux-user mode to protect code generation. By enabling it now we prepare for MTTCG and ensure all code generation is serialised by this lock. The other major structure that needs protecting is the l1_map and its PageDesc structures. For the SoftMMU case we also use

[Qemu-devel] [PATCH v7 00/27] Remaining MTTCG Base patches and ARM enablement

2017-01-19 Thread Alex Bennée
Hi, Here we go with another iteration of the MTTCG patches and I think it is feature complete for at least ARMv7/v8 on x86 hosts. One of the big changes was to address the concerns about TLB flush semantics. We introduce a number of new tlb_flush_*_all helpers which the guests can call instead of

[Qemu-devel] [PATCH v7 23/27] target-arm/cpu.h: make ARM_CP defined consistent

2017-01-19 Thread Alex Bennée
This is a purely mechanical change to make the ARM_CP flags neatly align and use a consistent format so it is easier to see which bit each flag is. Signed-off-by: Alex Bennée --- target/arm/cpu.h | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/t

[Qemu-devel] [PATCH v7 12/27] tcg: handle EXCP_ATOMIC exception for system emulation

2017-01-19 Thread Alex Bennée
From: Pranith Kumar The patch enables handling atomic code in the guest. This should be preferably done in cpu_handle_exception(), but the current assumptions regarding when we can execute atomic sections cause a deadlock. Signed-off-by: Pranith Kumar [AJB: tweak title] Signed-off-by: Alex Benn

[Qemu-devel] [PATCH v7 11/27] tcg: enable thread-per-vCPU

2017-01-19 Thread Alex Bennée
There are a couple of changes that occur at the same time here: - introduce a single vCPU qemu_tcg_cpu_thread_fn One of these is spawned per vCPU with its own Thread and Condition variables. qemu_tcg_rr_cpu_thread_fn is the new name for the old single threaded function. - the TLS curre

[Qemu-devel] [PATCH v7 22/27] target-arm: don't generate WFE/YIELD calls for MTTCG

2017-01-19 Thread Alex Bennée
The WFE and YIELD instructions are really only hints and in TCG's case they were useful to move the scheduling on from one vCPU to the next. In the parallel context (MTTCG) this just causes an unnecessary cpu_exit and contention of the BQL. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderso

[Qemu-devel] [PATCH v7 09/27] tcg: remove global exit_request

2017-01-19 Thread Alex Bennée
There are now only two uses of the global exit_request left. The first ensures we exit the run_loop when we first start to process pending work and in the kick handler. This is just as easily done by setting the first_cpu->exit_request flag. The second use is in the round robin kick routine. The

[Qemu-devel] [PATCH v7 19/27] target-arm/powerctl: defer cpu reset work to CPU context

2017-01-19 Thread Alex Bennée
When switching a new vCPU on we want to complete a bunch of the setup work before we start scheduling the vCPU thread. To do this cleanly we defer vCPU setup to async work which will run the vCPUs execution context as the thread is woken up. The scheduling of the work will kick the vCPU awake. Thi

[Qemu-devel] [PATCH v7 26/27] tcg: enable MTTCG by default for ARM on x86 hosts

2017-01-19 Thread Alex Bennée
This enables the multi-threaded system emulation by default for ARMv7 and ARMv8 guests using the x86_64 TCG backend. This is because on the guest side: - The ARM translate.c/translate-64.c have been converted to - use MTTCG safe atomic primitives - emit the appropriate barrier ops - Th

[Qemu-devel] [PATCH v7 13/27] cputlb: add assert_cpu_is_self checks

2017-01-19 Thread Alex Bennée
For SoftMMU the TLB flushes are an example of a task that can be triggered on one vCPU by another. To deal with this properly we need to use safe work to ensure these changes are done safely. The new assert can be enabled while debugging to catch these cases. Signed-off-by: Alex Bennée Reviewed-b

<    1   2   3   4   >