On 01/19/2017 03:48 AM, Markus Armbruster wrote: > Eric Blake <ebl...@redhat.com> writes: > >> Having a named rather than anonymous C type will make it easier >> to improve the testsuite in a later patch. > > Post it together with said later patch then.
It was that way in the v1 series, but I had enough else going on with removal of dynamic JSON parsing that I thought I could pick this one early. But I have no problems omitting it in a v3 respin, and saving it for the dynamic JSON work (if we even want to revisit that discussion). > # @format: #optional, format to open the new image with (defaults > to > # the probed format) > # > # @read-only-mode: #optional, change the read-only mode of the device; > defaults > # to 'retain' > # > # Since: 2.5 > > Isn't Since: 2.5 misleading? The anonymous type goes back to 2.5, but > the name doesn't. It matches what we've done elsewhere - when refactoring .json files to create a new type, but where the new type doesn't represent anything different over the wire than what was previously sent, we've documented the new struct name as of the older release where the wire format was introduced. But as long as the command says 'since 2.5', I'm okay if we want to mark the struct as 'since 2.9', if that's easier to think about. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
