Re: [Qemu-devel] [PATCH v5 0/3] Add litmus tests for MTTCG consistency tests

2017-01-18 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Message-id: 20161201052844.31819-1-bobby.pr...@gmail.com Subject: [Qemu-devel] [PATCH v5 0/3] Add litmus tests for MTTCG consistency tests Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=ba

Re: [Qemu-devel] [Nbd] [Qemu-block] How to online resize qemu disk with nbd protocol?

2017-01-18 Thread Wouter Verhelst
On Mon, Jan 16, 2017 at 01:36:21PM -0600, Eric Blake wrote: > Maybe the structured reply proposal can be extended into this (reserve a > "reply" header that can be issued as many times as desired by the server > without the client ever having issued the request first, and where the > reply never us

[Qemu-devel] [PATCH v5 1/2] gdbstub.c: fix GDB connection segfault caused by empty machines

2017-01-18 Thread Ziyue Yang
From: Ziyue Yang This patch is to fix the segmentation fault caused by attaching GDB to a QEMU instance initialized with "-M none" option. The bug can be reproduced by > ./qemu-system-x86_64 -M none -nographic -S -s and attach a GDB to it by > gdb -ex 'target remote :1234 The segmentation fa

[Qemu-devel] [PATCH v5 2/2] gdbstub.c: update old error report statements

2017-01-18 Thread Ziyue Yang
From: Ziyue Yang Some updates from fprintf(stderr, ...) to error_report. Signed-off-by: Ziyue Yang --- gdbstub.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 426d55e..959f6dc 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -637,8 +637,8 @

Re: [Qemu-devel] [PATCH v5 1/2] gdbstub.c: fix GDB connection segfault caused by empty machines

2017-01-18 Thread Thomas Huth
On 18.01.2017 09:02, Ziyue Yang wrote: > From: Ziyue Yang > > This patch is to fix the segmentation fault caused by attaching > GDB to a QEMU instance initialized with "-M none" option. > > The bug can be reproduced by > >> ./qemu-system-x86_64 -M none -nographic -S -s > > and attach a GDB to

Re: [Qemu-devel] [PATCH v5 2/2] gdbstub.c: update old error report statements

2017-01-18 Thread Thomas Huth
On 18.01.2017 09:03, Ziyue Yang wrote: > From: Ziyue Yang > > Some updates from fprintf(stderr, ...) to error_report. > > Signed-off-by: Ziyue Yang > --- > gdbstub.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/gdbstub.c b/gdbstub.c > index 426d55e..959f

Re: [Qemu-devel] [PATCH RFC v3 14/14] intel_iommu: enable vfio devices

2017-01-18 Thread Peter Xu
On Wed, Jan 18, 2017 at 11:10:53AM +0800, Jason Wang wrote: > > > On 2017年01月17日 22:45, Peter Xu wrote: > >On Mon, Jan 16, 2017 at 05:54:55PM +0800, Jason Wang wrote: > >> > >>On 2017年01月16日 17:18, Peter Xu wrote: > > static void vtd_iotlb_page_invalidate(IntelIOMMUState *s, uint16_t >

Re: [Qemu-devel] [PATCH 3/3] COLO: Don't process failover request while loading VM's state

2017-01-18 Thread Hailiang Zhang
On 2017/1/18 2:24, Eric Blake wrote: On 01/17/2017 06:57 AM, zhanghailiang wrote: We should not do failover work while the main thread is loading VM's state. Otherwise the consistent of VM's memory and device state will be broken. We will restart the loading process after jump over the stage, T

[Qemu-devel] [PATCH v16 0/2] virtio-crypto: virtio crypto device specification

2017-01-18 Thread Gonglei
Changes since v15: - use feature bits for non-session mode in order to keep compatibility with pre-existing code. [Halil & Michael] - introduce VIRTIO_CRYPTO_F_ NON_SESSION_MODE feature bit to control all other non-session mode feature bits. - fix some typos. [Stefan] - introduce struct v

[Qemu-devel] [PATCH v16 2/2] virtio-crypto: Add conformance clauses

2017-01-18 Thread Gonglei
Add the conformance targets and clauses for virtio-crypto device. Signed-off-by: Gonglei --- conformance.tex | 30 ++ 1 file changed, 30 insertions(+) diff --git a/conformance.tex b/conformance.tex index f59e360..3bde4b6 100644 --- a/conformance.tex +++ b/conformance

[Qemu-devel] [PATCH v16 1/2] virtio-crypto: Add virtio crypto device specification

2017-01-18 Thread Gonglei
The virtio crypto device is a virtual crypto device (ie. hardware crypto accelerator card). Currently, the virtio crypto device provides the following crypto services: CIPHER, MAC, HASH, and AEAD. In this patch, CIPHER, MAC, HASH, AEAD services are introduced. VIRTIO-153 Signed-off-by: Gonglei

Re: [Qemu-devel] [PATCH RFC v3 14/14] intel_iommu: enable vfio devices

2017-01-18 Thread Jason Wang
On 2017年01月18日 16:11, Peter Xu wrote: On Wed, Jan 18, 2017 at 11:10:53AM +0800, Jason Wang wrote: On 2017年01月17日 22:45, Peter Xu wrote: On Mon, Jan 16, 2017 at 05:54:55PM +0800, Jason Wang wrote: On 2017年01月16日 17:18, Peter Xu wrote: static void vtd_iotlb_page_invalidate(IntelIOMMUState

Re: [Qemu-devel] [PATCH v2 6/6] PC: Support dynamic sysbus on pc_i440fx

2017-01-18 Thread Igor Mammedov
On Mon, 16 Jan 2017 11:20:58 -0800 b...@skyportsystems.com wrote: > From: Ben Warren commit message should give a reason why it's need. > > Signed-off-by: Ben Warren > --- > hw/i386/pc_piix.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c > ind

Re: [Qemu-devel] [PATCH RFC v3 14/14] intel_iommu: enable vfio devices

2017-01-18 Thread Peter Xu
On Wed, Jan 18, 2017 at 04:36:05PM +0800, Jason Wang wrote: > > > On 2017年01月18日 16:11, Peter Xu wrote: > >On Wed, Jan 18, 2017 at 11:10:53AM +0800, Jason Wang wrote: > >> > >>On 2017年01月17日 22:45, Peter Xu wrote: > >>>On Mon, Jan 16, 2017 at 05:54:55PM +0800, Jason Wang wrote: > On 2017年01月1

[Qemu-devel] VM Hung issue

2017-01-18 Thread Umar Draz
Hello, I am running qemu-kvm on CentOS 7.3, I have few vms of CentOS and Windows 2012 servers. Randomly they are hung, but the status of virtual machine keep running, vnc and network not responding. I have checked all /var/log/messages and /var/log/libvirt/qemu/vm.log but nothing found anything

Re: [Qemu-devel] [PATCH v2 5/6] qmp/hmp: add set-vm-generation-id commands

2017-01-18 Thread Igor Mammedov
On Mon, 16 Jan 2017 11:20:57 -0800 b...@skyportsystems.com wrote: > From: Igor Mammedov > > Add set-vm-generation-id command to set Virtual Machine > Generation ID counter. > > QMP command example: > { "execute": "set-vm-generation-id", > "arguments": { > "guid": "32

Re: [Qemu-devel] [PATCH v9 07/11] megasas: undo the overwrites of msi user configuration

2017-01-18 Thread Hannes Reinecke
On 01/17/2017 07:18 AM, Cao jin wrote: > Commit afea4e14 seems forgetting to undo the overwrites, which is > unsuitable. > > CC: Hannes Reinecke > CC: Paolo Bonzini > CC: Markus Armbruster > CC: Marcel Apfelbaum > CC: Michael S. Tsirkin > > Reviewed-by: Markus Armbruster > Acked-by: Marcel

Re: [Qemu-devel] [PATCH v9 05/11] megasas: change behaviour of msix switch

2017-01-18 Thread Hannes Reinecke
On 01/17/2017 07:18 AM, Cao jin wrote: > Resolve the TODO, msix=auto means msix on; if user specify msix=on, > then device creation fail on msix_init failure. > Also undo the overwrites of user configuration of msix. > > CC: Michael S. Tsirkin > CC: Hannes Reinecke > CC: Paolo Bonzini > CC: Mar

Re: [Qemu-devel] [PATCH v9 03/11] pci: Convert msix_init() to Error and fix callers

2017-01-18 Thread Hannes Reinecke
On 01/17/2017 07:18 AM, Cao jin wrote: > msix_init() reports errors with error_report(), which is wrong when > it's used in realize(). The same issue was fixed for msi_init() in > commit 1108b2f. In order to make the API change as small as possible, > leave the return value check to later patch. >

Re: [Qemu-devel] [PATCH v4 0/2] memory: extend "info mtree" with flat view dump

2017-01-18 Thread Paolo Bonzini
On 16/01/2017 09:40, Peter Xu wrote: > v4: > - do unref of flatview when no view is there [Dave] > > v3: > - rather than dump flatview directly in "info mtree", provide a new > parameter "-f" for it. [Paolo] > - replace "RW" chars with the type of memory region [Paolo] > - (cc dave as well sin

Re: [Qemu-devel] [PATCH 0/3] Remove arch_init SMBIOS and ACPI code

2017-01-18 Thread Paolo Bonzini
On 17/01/2017 20:30, Eduardo Habkost wrote: > This creates stubs for SMBIOS and ACPI option parsing functions, > so that we don't need arch-specific #ifdefs in arch_init just for > calling the option parsers. > > Eduardo Habkost (3): > stubs: Add smbios_entry_add() stub > stubs: acpi_table_a

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 00/18] arm: Add virtualization to GICv3, and enable EL2 on 64-bit CPUs

2017-01-18 Thread Edgar E. Iglesias
Hi Peter, I'm on holidays and won't have time to review for a couple of weeks at least... Cheers, Edgar --- Sent from my phone On 17 Jan 2017 14:08, "Peter Maydell" wrote: > On 9 January 2017 at 16:05, Peter Maydell > wrote: > > This patchset adds support for the Virtualization extensions to

Re: [Qemu-devel] [PATCH] arch_init: Remove unnecessary default_config_files table

2017-01-18 Thread Paolo Bonzini
On 17/01/2017 19:00, Eduardo Habkost wrote: > The existing default_config_files table in arch_init.c has a > single entry, making it completely unnecessary. The whole code > can be replaced by a single qemu_read_config_file() call in vl.c. > > Signed-off-by: Eduardo Habkost > --- > include/qem

Re: [Qemu-devel] [PATCH RFC v3 14/14] intel_iommu: enable vfio devices

2017-01-18 Thread Tian, Kevin
> From: Peter Xu [mailto:pet...@redhat.com] > Sent: Wednesday, January 18, 2017 4:46 PM > > On Wed, Jan 18, 2017 at 04:36:05PM +0800, Jason Wang wrote: > > > > > > On 2017年01月18日 16:11, Peter Xu wrote: > > >On Wed, Jan 18, 2017 at 11:10:53AM +0800, Jason Wang wrote: > > >> > > >>On 2017年01月17日 22:

Re: [Qemu-devel] [PATCH 9/9] tests: Test case for query-cpu-model-expansion

2017-01-18 Thread David Hildenbrand
Am 17.01.2017 um 02:02 schrieb Eduardo Habkost: +def checkExpansions(self, model, msg): +"""Perform multiple expansion operations on model, validate results + +@model is a CpuModelExpansionInfo struct, with some extra keys: +* model['runnable'] should be set to True if

Re: [Qemu-devel] [PATCH v5 0/3] Add litmus tests for MTTCG consistency tests

2017-01-18 Thread Fam Zheng
On Wed, 01/18 00:00, no-re...@patchew.org wrote: > Hi, > > Your series seems to have some coding style problems. See output below for > more information: Sorry for the noise, looks like it's a network issue during preparation, unrelated to this series. I'll look into suppressing such errors in th

[Qemu-devel] [Bug 788881] Re: i386-bsd-user and similar don't build on Mac OS X

2017-01-18 Thread Thomas Huth
The bsd-user target is currently unmainted in QEMU, and I think it is not meant for Mac OS X, but rather for FreeBSD and friends. So let's close this ticket now... ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml,

[Qemu-devel] [Bug 788886] Re: Crash with -m32 and gcc-4.2 on Mac OS X 64bit

2017-01-18 Thread Thomas Huth
Which version of QEMU were you using? Can you still reproduce this problem with the latest version of QEMU and the latest version of macOS? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed t

[Qemu-devel] [Bug 735752] Re: qemu squeeze crashes "BUG: unable to handle kernel NULL pointer dereference at (null)"

2017-01-18 Thread Thomas Huth
Sounds like this was a kernel bug ... you should report those to the right kernel mailing lists instead. Anyway, closing this ticket now since there hasn't been any activity since a long time. ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are

Re: [Qemu-devel] [PATCH v5 2/2] gdbstub.c: update old error report statements

2017-01-18 Thread Fam Zheng
On Wed, 01/18 16:03, Ziyue Yang wrote: > From: Ziyue Yang > > Some updates from fprintf(stderr, ...) to error_report. In the future, please use "git format-patch --cover-letter" and "git send-email --thread" to make sure the patches form a thread. See also: http://wiki.qemu.org/Contribute/Submi

Re: [Qemu-devel] [PATCH v6 0/2] allow blockdev-add for NFS

2017-01-18 Thread Kevin Wolf
Am 17.01.2017 um 16:14 hat Peter Lieven geschrieben: > Am 31.10.2016 um 18:20 schrieb Kevin Wolf: > >Am 31.10.2016 um 16:05 hat Ashijeet Acharya geschrieben: > >>Previously posted series patches: > >>v5: https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg07580.html > >>v4: https://lists.gnu.o

Re: [Qemu-devel] [PATCH v6 wave 2 2/3] hw/isa/lpc_ich9: add broadcast SMI feature

2017-01-18 Thread Igor Mammedov
On Tue, 17 Jan 2017 19:53:21 +0100 Laszlo Ersek wrote: > On 01/17/17 15:20, Igor Mammedov wrote: > > On Tue, 17 Jan 2017 14:46:05 +0100 > > Laszlo Ersek wrote: > > > >> On 01/17/17 14:20, Igor Mammedov wrote: > >>> On Tue, 17 Jan 2017 13:06:13 +0100 > >>> Laszlo Ersek wrote: > >>> > >

Re: [Qemu-devel] [PATCH RFC v3 14/14] intel_iommu: enable vfio devices

2017-01-18 Thread Jason Wang
On 2017年01月18日 17:38, Tian, Kevin wrote: From: Peter Xu [mailto:pet...@redhat.com] Sent: Wednesday, January 18, 2017 4:46 PM On Wed, Jan 18, 2017 at 04:36:05PM +0800, Jason Wang wrote: On 2017年01月18日 16:11, Peter Xu wrote: On Wed, Jan 18, 2017 at 11:10:53AM +0800, Jason Wang wrote: On 2017

Re: [Qemu-devel] [PATCH v6 kernel 0/5] Extend virtio-balloon for fast (de)inflating & fast live migration

2017-01-18 Thread David Hildenbrand
Am 21.12.2016 um 07:52 schrieb Liang Li: This patch set contains two parts of changes to the virtio-balloon. One is the change for speeding up the inflating & deflating process, the main idea of this optimization is to use {pfn|length} to present the page information instead of the PFNs, to redu

Re: [Qemu-devel] [PATCH v6 wave 2 2/3] hw/isa/lpc_ich9: add broadcast SMI feature

2017-01-18 Thread Laszlo Ersek
On 01/18/17 11:03, Igor Mammedov wrote: > On Tue, 17 Jan 2017 19:53:21 +0100 > Laszlo Ersek wrote: > >> On 01/17/17 15:20, Igor Mammedov wrote: >>> On Tue, 17 Jan 2017 14:46:05 +0100 >>> Laszlo Ersek wrote: >>> On 01/17/17 14:20, Igor Mammedov wrote: > On Tue, 17 Jan 2017 13:06:13

Re: [Qemu-devel] [PATCH v6 wave 2 2/3] hw/isa/lpc_ich9: add broadcast SMI feature

2017-01-18 Thread Laszlo Ersek
On 01/18/17 11:19, Laszlo Ersek wrote: > On 01/18/17 11:03, Igor Mammedov wrote: >> On Tue, 17 Jan 2017 19:53:21 +0100 >> Laszlo Ersek wrote: >> [snip] >>> This is the code I wrote (extracting a new ich9_apm_broadcast_smi() >>> function from ich9_apm_ctrl_changed(), due to size reasons): >>> >>>

Re: [Qemu-devel] VM Hung issue

2017-01-18 Thread Stefan Hajnoczi
On Wed, Jan 18, 2017 at 01:51:26PM +0500, Umar Draz wrote: > I am running qemu-kvm on CentOS 7.3, I have few vms of CentOS and Windows > 2012 servers. > > Randomly they are hung, but the status of virtual machine keep running, vnc > and network not responding. It's not clear whether the guest is

Re: [Qemu-devel] [RFC PATCH] throttle: move throttling cmdline options to a separate header file

2017-01-18 Thread Pradeep Kiruvale
On 22 November 2016 at 13:55, wrote: > Hi, > > Your series seems to have some coding style problems. See output below for > more information: > > Subject: [Qemu-devel] [RFC PATCH] throttle: move throttling cmdline > options to a separate header file > Type: series > Message-id: 147981681351.30309

Re: [Qemu-devel] VM Hung issue

2017-01-18 Thread Umar Draz
Hello Stefan, Well yes, whenever vm hung, then there is nothing on vnc display, and network of that vm is also down. I can not ping the vm that time. Mostly my Windows VMs are affected due to this and sometime same thing happen with Linux vm. On Wed, Jan 18, 2017 at 3:29 PM, Stefan Hajnoczi wro

Re: [Qemu-devel] [PATCH 13/14] raw-posix: Implement image locking

2017-01-18 Thread Fam Zheng
On Fri, 12/02 03:58, Max Reitz wrote: > On 31.10.2016 16:38, Fam Zheng wrote: > > This implements open flag sensible image locking for local file > > and host device protocol. > > > > virtlockd in libvirt locks the first byte, so we start looking at the > > file bytes from 1. > > > > Quoting what

[Qemu-devel] Call for GSoC 2017 mentors & project ideas

2017-01-18 Thread Stefan Hajnoczi
QEMU will be applying to Google Summer of Code again this year. Do you want to help some of the most talented university students begin contributing to open source by working on our codebase and joining our community? We need to put together a list of project ideas by February 9: http://qemu-proj

Re: [Qemu-devel] [PATCH 2/3] COLO: Shutdown related socket fd while do failover

2017-01-18 Thread Dr. David Alan Gilbert
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > If the net connection between primary host and secondary host breaks > while COLO/COLO incoming threads are doing read() or write(). > It will block until connection is timeout, and the failover process > will be blocked because of it. > >

Re: [Qemu-devel] Call for GSoC 2017 mentors & project ideas

2017-01-18 Thread Alex Bennée
Stefan Hajnoczi writes: > QEMU will be applying to Google Summer of Code again this year. > > Do you want to help some of the most talented university students > begin contributing to open source by working on our codebase and > joining our community? > > We need to put together a list of projec

Re: [Qemu-devel] [Qemu-stable] Data corruption in Qemu 2.7.1

2017-01-18 Thread Fabian Grünbichler
On 17/01/2017 16:03, Paolo Bonzini wrote: > On 17/01/2017 12:22, Fabian Grünbichler wrote: >> 6) repeat 3-5 until md5sum does not match, kernel spews error >> messages, or you are convinced that everything is OK >> >> sample kernel message (for ext3): >> Jan 17 11:39:32 ubuntu kernel: sd 2:0:0:0: [

Re: [Qemu-devel] [PULL 04/41] virtio: convert to use DMA api

2017-01-18 Thread Paolo Bonzini
On 10/01/2017 06:39, Michael S. Tsirkin wrote: > -void virtqueue_map(VirtQueueElement *elem) > +void virtqueue_map(VirtIODevice *vdev, VirtQueueElement *elem) > { > -virtqueue_map_iovec(elem->in_sg, elem->in_addr, &elem->in_num, > -VIRTQUEUE_MAX_SIZE, 1); > -virtq

Re: [Qemu-devel] TSC frequency configuration & invtsc migration (was Re: [PATCH 4/4] kvm: Allow migration with invtsc)

2017-01-18 Thread Marcelo Tosatti
On Tue, Jan 10, 2017 at 05:36:48PM +0100, Paolo Bonzini wrote: > > > On 05/01/2017 11:48, Marcelo Tosatti wrote: > >> Host A has TSC scaling, host B doesn't have TSC scaling. We want > >> to be able to start the VM on host A, and migrate to B. In this > >> case, the only possible solution is to u

Re: [Qemu-devel] [PULL 08/41] intel_iommu: support device iotlb descriptor

2017-01-18 Thread Paolo Bonzini
On 10/01/2017 06:39, Michael S. Tsirkin wrote: > From: Jason Wang > > This patch enables device IOTLB support for intel iommu. The major > work is to implement QI device IOTLB descriptor processing and notify > the device through iommu notifier. > > Cc: Paolo Bonzini > Cc: Richard Henderson

Re: [Qemu-devel] [PATCH v3 0/2] Allow migration with invtsc if TSC frequency is explicitly set

2017-01-18 Thread Marcelo Tosatti
On Sun, Jan 08, 2017 at 03:32:32PM -0200, Eduardo Habkost wrote: > This series makes QEMU accept migration if tsc-frequency is > explicitly set on configuration. As management software is > required to keep device configuration the same on migration > source or destination, explicit tsc-frequency w

Re: [Qemu-devel] Proposal PCI/PCIe device placement on PAPR guests

2017-01-18 Thread Marcel Apfelbaum
On 01/12/2017 07:53 PM, Laine Stump wrote: On 01/12/2017 11:35 AM, Michael Roth wrote: Quoting Laine Stump (2017-01-12 08:52:10) [...] Yeah you're right, I'm probably remembering the wrong problem and wrong reason for the problem. I just remember there was *some* issue about hotplugging n

Re: [Qemu-devel] [PATCH V2 0/3] hw/pcie: Introduce Generic PCI Express Root Port

2017-01-18 Thread Marcel Apfelbaum
On 01/16/2017 06:46 PM, Andrea Bolognani wrote: On Wed, 2017-01-11 at 14:18 +0200, Marcel Apfelbaum wrote: v1 -> v2: - Rebased on master. The Generic Root Port behaves the same as the Intel's IOH device with id 3420, without having Intel specific attributes. The device has two purposes: (1

Re: [Qemu-devel] [PATCH v6 wave 2 2/3] hw/isa/lpc_ich9: add broadcast SMI feature

2017-01-18 Thread Igor Mammedov
On Wed, 18 Jan 2017 11:23:48 +0100 Laszlo Ersek wrote: > On 01/18/17 11:19, Laszlo Ersek wrote: > > On 01/18/17 11:03, Igor Mammedov wrote: > >> On Tue, 17 Jan 2017 19:53:21 +0100 > >> Laszlo Ersek wrote: > >> > > [snip] > > >>> This is the code I wrote (extracting a new ich9_apm_broadcast

Re: [Qemu-devel] [PATCH 9/9] tests: Test case for query-cpu-model-expansion

2017-01-18 Thread Eduardo Habkost
On Wed, Jan 18, 2017 at 10:39:46AM +0100, David Hildenbrand wrote: > Am 17.01.2017 um 02:02 schrieb Eduardo Habkost: > > +def checkExpansions(self, model, msg): > > +"""Perform multiple expansion operations on model, validate results > > + > > +@model is a CpuModelExpansionInfo

[Qemu-devel] [PATCH 1/3] cpu: Make the mapping of CPUs and NUMA nodes in cpu_common_realizefn

2017-01-18 Thread Dou Liyang
Current default way of seting the CPUState::numa_node might be wrong in case on cold/hot-plug CPUs. Making the users confused why the NUMA info is different beetween the guests and monitor. Make the mapping of CPUs and NUMA nodes in qom/cpu.c: cpu_common_realizefn(), where each VCPUs need to reali

Re: [Qemu-devel] [PATCH 9/9] tests: Test case for query-cpu-model-expansion

2017-01-18 Thread David Hildenbrand
Am 18.01.2017 um 13:39 schrieb Eduardo Habkost: > On Wed, Jan 18, 2017 at 10:39:46AM +0100, David Hildenbrand wrote: >> Am 17.01.2017 um 02:02 schrieb Eduardo Habkost: >>> +def checkExpansions(self, model, msg): >>> +"""Perform multiple expansion operations on model, validate results >>

[Qemu-devel] [PATCH 2/3] numa: Remove the numa_post_machine_init function

2017-01-18 Thread Dou Liyang
Current default way of seting the CPUState::numa_node in the numa_post_machine_init() and calling it in vl.c:main() would make the data incorrect in case on cold/hot-plug CPUs. Now, we move it to the qom/cpu.c:cpu_common_realizefn(). So, Here we remove it. Signed-off-by: Dou Liyang --- include/

Re: [Qemu-devel] [PATCH RFC v2 02/12] vfio: linux-headers update for vfio-ccw

2017-01-18 Thread Cornelia Huck
On Wed, 18 Jan 2017 10:51:17 +0800 Dong Jia Shi wrote: > * Alex Williamson [2017-01-17 14:51:42 -0700]: > > > On Thu, 12 Jan 2017 08:25:03 +0100 > > Dong Jia Shi wrote: > > > > > From: Xiao Feng Ren > > > > > > This is a placeholder for a linux-headers update. > > > > > > Signed-off-by: Xi

Re: [Qemu-devel] TSC frequency configuration & invtsc migration (was Re: [PATCH 4/4] kvm: Allow migration with invtsc)

2017-01-18 Thread Eduardo Habkost
On Wed, Jan 18, 2017 at 09:55:43AM -0200, Marcelo Tosatti wrote: > On Tue, Jan 10, 2017 at 05:36:48PM +0100, Paolo Bonzini wrote: > > > > > > On 05/01/2017 11:48, Marcelo Tosatti wrote: > > >> Host A has TSC scaling, host B doesn't have TSC scaling. We want > > >> to be able to start the VM on ho

[Qemu-devel] [PATCH 0/3] cpu: numa: Fix the mapping initialization of VCPUs and NUMA nodes

2017-01-18 Thread Dou Liyang
As we fixed a bug(Bug 1) in below links, Named "Method-A": https://lists.nongnu.org/archive/html/qemu-devel/2017-01/msg03354.html Then, Eduardo gave us many suggests. Thanks very much! when we try them, we also find another bugs named "Bug 2". [Problem] - As I use this command: ./x86_6

Re: [Qemu-devel] [PATCH 1/2] vl: Ensure the numa_post_machine_init func in the appropriate location

2017-01-18 Thread Eduardo Habkost
On Wed, Jan 18, 2017 at 12:02:35PM +0800, Dou Liyang wrote: > Hi, Eduardo > > At 01/18/2017 04:09 AM, Eduardo Habkost wrote: > > On Tue, Jan 17, 2017 at 10:42:31PM +0800, Dou Liyang wrote: > > > In the numa_post_machine_init(), we use CPU_FOREACH macro to set all > > > CPUs' namu_node. So, we shou

[Qemu-devel] [PATCH 3/3] cpu: make the function of cpu_common_map_numa_node more efficiently

2017-01-18 Thread Dou Liyang
Current function does some unnecessary operations, such as it makes the assert() in the loop, and the loop was not stopped in time. This patch moves the assert() out the loop and stops the loop in time. Signed-off-by: Dou Liyang --- qom/cpu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion

Re: [Qemu-devel] [PATCH v1 07/15] iotests: fix 097 when run with qcow

2017-01-18 Thread Max Reitz
On 17.01.2017 10:59, Daniel P. Berrange wrote: > On Mon, Jan 16, 2017 at 09:04:31PM +0100, Max Reitz wrote: >> On 03.01.2017 19:27, Daniel P. Berrange wrote: >>> The previous commit: >>> >>> commit a3e1505daec31ef56f0489f8c8fff1b8e4ca92bd >>> Author: Eric Blake >>> Date: Mon Dec 5 09:49:34

Re: [Qemu-devel] [PATCH] arch_init: Remove unnecessary default_config_files table

2017-01-18 Thread Paolo Bonzini
On 18/01/2017 13:52, Eduardo Habkost wrote: >> >> Though maybe we should just remove .conf file support completely... >> who's using it?!? > You mean removing /etc/qemu.conf, or removing -readconfig > completely? > > The former doesn't seem to be used often. The latter looks very > useful for pe

[Qemu-devel] [PATCH v3] hw/core/null-machine: Add the possibility to instantiate a CPU and RAM

2017-01-18 Thread Thomas Huth
Sometimes it is useful to have just a machine with CPU and RAM, without any further hardware in it, e.g. if you just want to do some instruction debugging for TCG with a remote GDB attached to QEMU, or run some embedded code with the "-semihosting" QEMU parameter. qemu-system-m68k already features

Re: [Qemu-devel] [PATCH 1/3] cpu: Make the mapping of CPUs and NUMA nodes in cpu_common_realizefn

2017-01-18 Thread Eduardo Habkost
On Wed, Jan 18, 2017 at 08:40:05PM +0800, Dou Liyang wrote: > Current default way of seting the CPUState::numa_node might be wrong > in case on cold/hot-plug CPUs. Making the users confused why the > NUMA info is different beetween the guests and monitor. > > Make the mapping of CPUs and NUMA node

Re: [Qemu-devel] [PATCH] arch_init: Remove unnecessary default_config_files table

2017-01-18 Thread Eduardo Habkost
On Wed, Jan 18, 2017 at 01:55:21PM +0100, Paolo Bonzini wrote: > > > On 18/01/2017 13:52, Eduardo Habkost wrote: > >> > >> Though maybe we should just remove .conf file support completely... > >> who's using it?!? > > You mean removing /etc/qemu.conf, or removing -readconfig > > completely? > >

Re: [Qemu-devel] [PATCH 0/3] cpu: numa: Fix the mapping initialization of VCPUs and NUMA nodes

2017-01-18 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 1484743207-10721-1-git-send-email-douly.f...@cn.fujitsu.com Subject: [Qemu-devel] [PATCH 0/3] cpu: numa: Fix the m

Re: [Qemu-devel] [PATCH] arch_init: Remove unnecessary default_config_files table

2017-01-18 Thread Eduardo Habkost
On Wed, Jan 18, 2017 at 10:17:17AM +0100, Paolo Bonzini wrote: > > > On 17/01/2017 19:00, Eduardo Habkost wrote: > > The existing default_config_files table in arch_init.c has a > > single entry, making it completely unnecessary. The whole code > > can be replaced by a single qemu_read_config_fil

Re: [Qemu-devel] [PATCH] arch_init: Remove unnecessary default_config_files table

2017-01-18 Thread Eduardo Habkost
On Wed, Jan 18, 2017 at 10:17:17AM +0100, Paolo Bonzini wrote: > > > On 17/01/2017 19:00, Eduardo Habkost wrote: > > The existing default_config_files table in arch_init.c has a > > single entry, making it completely unnecessary. The whole code > > can be replaced by a single qemu_read_config_fil

[Qemu-devel] [PATCH RFC] acpi: add reset register to fadt

2017-01-18 Thread Phil Dennis-Jordan
About 2 years ago, Reza Jelveh submitted essentially this same patch: https://lists.gnu.org/archive/html/qemu-devel/2015-03/msg05832.html It adds the reset register defined in ACPI 2.0 to the x86 FADT, which fixes rebooting for Darwin/OS X/macOS guests. I'm trying to revive this as part of an ef

Re: [Qemu-devel] [PATCH 10/18] tcg/i386: add support for vector opcodes

2017-01-18 Thread Kirill Batuzov
On Tue, 17 Jan 2017, Richard Henderson wrote: > On 01/17/2017 01:07 AM, Kirill Batuzov wrote: > > To be able to generate vector operations in a TCG backend we need to do > > several things. > > > > 1. We need to tell the register allocator about vector target's register. > >In case of x86 we'

Re: [Qemu-devel] [PATCH 2/3] numa: Remove the numa_post_machine_init function

2017-01-18 Thread Eduardo Habkost
On Wed, Jan 18, 2017 at 08:40:06PM +0800, Dou Liyang wrote: > Current default way of seting the CPUState::numa_node in the > numa_post_machine_init() and calling it in vl.c:main() would > make the data incorrect in case on cold/hot-plug CPUs. > > Now, we move it to the qom/cpu.c:cpu_common_realize

Re: [Qemu-devel] [PATCH 3/3] cpu: make the function of cpu_common_map_numa_node more efficiently

2017-01-18 Thread Eduardo Habkost
On Wed, Jan 18, 2017 at 08:40:07PM +0800, Dou Liyang wrote: > Current function does some unnecessary operations, such as it makes > the assert() in the loop, and the loop was not stopped in time. > > This patch moves the assert() out the loop and stops the loop in > time. > > Signed-off-by: Dou L

Re: [Qemu-devel] [PATCH 13/14] raw-posix: Implement image locking

2017-01-18 Thread Max Reitz
On 18.01.2017 11:48, Fam Zheng wrote: > On Fri, 12/02 03:58, Max Reitz wrote: >> On 31.10.2016 16:38, Fam Zheng wrote: >>> This implements open flag sensible image locking for local file >>> and host device protocol. >>> >>> virtlockd in libvirt locks the first byte, so we start looking at the >>>

Re: [Qemu-devel] [PATCH] arch_init: Remove unnecessary default_config_files table

2017-01-18 Thread Paolo Bonzini
On 18/01/2017 13:58, Eduardo Habkost wrote: > On Wed, Jan 18, 2017 at 01:55:21PM +0100, Paolo Bonzini wrote: >> >> >> On 18/01/2017 13:52, Eduardo Habkost wrote: Though maybe we should just remove .conf file support completely... who's using it?!? >>> You mean removing /etc/qemu.co

Re: [Qemu-devel] [PATCH 1/3] cpu: Make the mapping of CPUs and NUMA nodes in cpu_common_realizefn

2017-01-18 Thread Dou Liyang
Hi, Eduardo At 01/18/2017 08:56 PM, Eduardo Habkost wrote: On Wed, Jan 18, 2017 at 08:40:05PM +0800, Dou Liyang wrote: Current default way of seting the CPUState::numa_node might be wrong in case on cold/hot-plug CPUs. Making the users confused why the NUMA info is different beetween the guests

Re: [Qemu-devel] [PATCH 13/14] raw-posix: Implement image locking

2017-01-18 Thread Fam Zheng
On Wed, 01/18 14:02, Max Reitz wrote: > >> Testing whether something is locked would be easier by using F_OFD_GETLK > >> instead of actually creating an exclusive lock and then releasing it. > > > > My attempt to do this shows it doesn't work: fcntl forces the tested lock > > type > > to read loc

Re: [Qemu-devel] [PATCH 0/3] cpu: numa: Fix the mapping initialization of VCPUs and NUMA nodes

2017-01-18 Thread Dou Liyang
Hi, All ** ERROR:/tmp/qemu-test/src/tests/vhost-user-test.c:668:test_migrate: assertion failed: (qdict_haskey(rsp, "return")) GTester: last random seed: R02Sf52546c4daff8087416f43fa7c146db8 ftruncate: Permission denied ftruncate: Permission denied qemu-system-aarch64: /tmp/qemu-test/src/qom/cpu

Re: [Qemu-devel] [PATCH v6 kernel 0/5] Extend virtio-balloon for fast (de)inflating & fast live migration

2017-01-18 Thread Li, Liang Z
> Am 21.12.2016 um 07:52 schrieb Liang Li: > > This patch set contains two parts of changes to the virtio-balloon. > > > > One is the change for speeding up the inflating & deflating process, > > the main idea of this optimization is to use {pfn|length} to present > > the page information instead o

Re: [Qemu-devel] [PATCH v4 10/25] block: Add bdrv_dirname()

2017-01-18 Thread Max Reitz
On 17.01.2017 00:02, Eric Blake wrote: > On 01/16/2017 02:49 PM, Max Reitz wrote: >> This function may be implemented by block drivers to derive a directory >> name from a BDS. Concatenating this g_free()-able string with a relative >> filename must result in a valid (not necessarily existing) file

Re: [Qemu-devel] [PATCH v4 13/25] block/nbd: Implement bdrv_dirname()

2017-01-18 Thread Max Reitz
On 17.01.2017 00:21, Eric Blake wrote: > On 01/16/2017 02:49 PM, Max Reitz wrote: >> The idea behind this implementation is that the export name might be >> interpreted as a path (which is the only apparent interpretation of >> relative filenames for NBD paths). >> >> The default implementation of

[Qemu-devel] [PATCH v2] vl: Ensure the cpu_synchronize_all_post_init() in the appropriate location

2017-01-18 Thread Dou Liyang
At the Qemu initialization, we call the cpu_synchronize_all_post_init() to synchronize All CPU states to KVM in the ./vl.c::main(). Currently, it is called before we initialize the CPUs, which created by "-device" command, So, these CPUs may be ignored to synchronize. The patch moves the numa_pos

Re: [Qemu-devel] [PATCH 0/3] cpu: numa: Fix the mapping initialization of VCPUs and NUMA nodes

2017-01-18 Thread Igor Mammedov
On Wed, 18 Jan 2017 20:40:04 +0800 Dou Liyang wrote: > As we fixed a bug(Bug 1) in below links, Named "Method-A": > > https://lists.nongnu.org/archive/html/qemu-devel/2017-01/msg03354.html > > Then, Eduardo gave us many suggests. Thanks very much! > when we try them, we also find another bugs n

[Qemu-devel] [PATCH 2/2] vl: Print warning when a default config file is loaded

2017-01-18 Thread Eduardo Habkost
In case there were options set in the default config file, print a warning so users can update their scripts. If somebody wants to keep the config file as-is, avoid the warning and use a command-line that will work in future QEMU versions, they can use: $QEMU -nodefconfig -readconfig /etc/qemu/q

[Qemu-devel] [PATCH 0/2] vl: Print warning if a non-empty default config-file is found

2017-01-18 Thread Eduardo Habkost
We plan to remove support for /etc/qemu/qemu.conf in the near future. Make QEMU print a warning in case there a non-empty /etc/qemu/qemu.conf is loaded, so users have time to adapt. This series is based on my machine-next branch, at: https://github.com/ehabkost/qemu.git machine-next Eduardo Hab

[Qemu-devel] [PATCH 1/2] config: qemu_config_parse() return number of config groups

2017-01-18 Thread Eduardo Habkost
Change qemu_config_parse() to return the number of config groups in success and -EINVAL on error. This will allow callers of qemu_config_parse() to check if something was really loaded from the config file. All existing callers of qemu_config_parse() and qemu_read_config_file() only check if the r

[Qemu-devel] [PATCH] x86-KVM: Supply TSC and APIC clock rates to guest like VMWare

2017-01-18 Thread Phil Dennis-Jordan
This fixes timekeeping of x86-64 Darwin/OS X/macOS guests when using KVM. Darwin/OS X/macOS for x86-64 uses the TSC for timekeeping; it normally calibrates this by querying various clock frequency scaling MSRs. Details depend on the exact CPU model detected. The local APIC timer frequency is ex

[Qemu-devel] [PATCH] hw/usb/dev-hid: add a Mac guest compatibility option to usb-tablet

2017-01-18 Thread Phil Dennis-Jordan
Darwin/OS X/macOS's HID driver stack does not correctly drive Qemu's simulated USB Tablet. This adds a boolean option "mac_compat" which subtly changes the device so it behaves in a way that Mac guests can handle. The specific incompatibilities with the regular Qemu USB tablet are: 1. Absolute

Re: [Qemu-devel] [PATCH 01/16] aio: introduce aio_co_schedule and aio_co_wake

2017-01-18 Thread Stefan Hajnoczi
On Fri, Jan 13, 2017 at 02:17:16PM +0100, Paolo Bonzini wrote: > +static void co_schedule_bh_cb(void *opaque) > +{ > +AioContext *ctx = opaque; > +QSLIST_HEAD(, Coroutine) straight, reversed; > + > +QSLIST_MOVE_ATOMIC(&reversed, &ctx->scheduled_coroutines); > +QSLIST_INIT(&straight)

Re: [Qemu-devel] [PATCH 02/16] block-backend: allow blk_prw from coroutine context

2017-01-18 Thread Stefan Hajnoczi
On Fri, Jan 13, 2017 at 02:17:17PM +0100, Paolo Bonzini wrote: > qcow2_create2 calls this. Do not run a nested event loop, as that > breaks when aio_co_wake tries to queue the coroutine on the co_queue_wakeup > list of the currently running one. > > Signed-off-by: Paolo Bonzini > --- > block/bl

Re: [Qemu-devel] [PATCH 03/16] test-thread-pool: use generic AioContext infrastructure

2017-01-18 Thread Stefan Hajnoczi
On Fri, Jan 13, 2017 at 02:17:18PM +0100, Paolo Bonzini wrote: > Once the thread pool starts using aio_co_wake, it will also need > qemu_get_current_aio_context(). Make test-thread-pool create > an AioContext with qemu_init_main_loop, so that stubs/iothread.c > and tests/iothread.c can provide the

Re: [Qemu-devel] [PATCH 04/16] io: add methods to set I/O handlers on AioContext

2017-01-18 Thread Stefan Hajnoczi
On Fri, Jan 13, 2017 at 02:17:19PM +0100, Paolo Bonzini wrote: > This is in preparation for making qio_channel_yield work on > AioContexts other than the main one. > > Signed-off-by: Paolo Bonzini > --- > include/io/channel.h | 30 ++ > io/channel-command.c | 13 +

Re: [Qemu-devel] [PATCH 05/16] io: make qio_channel_yield aware of AioContexts

2017-01-18 Thread Stefan Hajnoczi
On Mon, Jan 16, 2017 at 12:55:59PM +, Daniel P. Berrange wrote: > On Mon, Jan 16, 2017 at 07:38:24PM +0800, Fam Zheng wrote: > > On Fri, 01/13 14:17, Paolo Bonzini wrote: > > > Support separate coroutines for reading and writing, and place the > > > read/write handlers on the AioContext that th

[Qemu-devel] [PATCH] numa: access CPU's node id via property in hmp_info_numa()

2017-01-18 Thread Igor Mammedov
Move vcpu's assocciated numa_node field out of generic CPUState into inherited classes that actually care about cpu<->numa mapping and make monitor 'info numa' get vcpu's assocciated node id via node-id property. It allows to drop implicit node id intialization in numa_post_machine_init() and would

Re: [Qemu-devel] [PATCH v2] hw/arm/virt-acpi - reserve ECAM space as PNP0C02 device

2017-01-18 Thread Ard Biesheuvel
On 17 January 2017 at 09:49, Andrew Jones wrote: > On Mon, Jan 16, 2017 at 07:31:33PM +, Ard Biesheuvel wrote: >> On 16 January 2017 at 18:20, Peter Maydell wrote: >> > On 16 January 2017 at 17:30, Ard Biesheuvel >> > wrote: >> >> On 16 January 2017 at 17:25, Peter Maydell >> >> wrote: >>

Re: [Qemu-devel] [PATCH 05/16] io: make qio_channel_yield aware of AioContexts

2017-01-18 Thread Stefan Hajnoczi
On Fri, Jan 13, 2017 at 02:17:20PM +0100, Paolo Bonzini wrote: > /** > + * qio_channel_set_aio_context: > + * @ioc: the channel object > + * @ctx: the #AioContext to set the handlers on > + * > + * Request that qio_channel_yield() sets I/O handlers on > + * the given #AioContext. If @ctx is %NULL

Re: [Qemu-devel] [PATCH v2 09/11] aspeed/smc: extend tests for Command mode

2017-01-18 Thread Cédric Le Goater
On 01/17/2017 06:34 PM, mar.krzeminski wrote: +static void test_write_page_mem(void) +{ +uint32_t my_page_addr = 0x15000 * PAGE_SIZE; +uint32_t page[PAGE_SIZE / 4]; +int i; + +/* Enable 4BYTE mode for controller. This is should be strapped by

[Qemu-devel] [PATCH v3] aspeed/smc: handle dummy bytes when doing fast reads in command mode

2017-01-18 Thread Cédric Le Goater
When doing fast read, a certain amount of dummy bytes should be sent before the read. This number is configurable in the controler CE0 Control Register and needs to be modeled using fake transfers to the flash module. This only supports command mode. User mode requires more work and a possible ext

[Qemu-devel] [PATCH 1/2] linux-user: fix settime old value location

2017-01-18 Thread Pranith Kumar
From: Marc-André Lureau old_value is the 4th argument of timer_settime(), not the 2nd. Signed-off-by: Marc-André Lureau Signed-off-by: Pranith Kumar --- linux-user/syscall.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 7

[Qemu-devel] [PATCH 2/2] linux-user: fix tcg/mmap test

2017-01-18 Thread Pranith Kumar
From: Marc-André Lureau tests/tcg/mmap test fails with values other than default target page size. When creating a map beyond EOF, extra anonymous pages are added up to the target page boundary. Currently, this operation is performed only when qemu_real_host_page_size < TARGET_PAGE_SIZE, but it s

[Qemu-devel] [PATCH] configure: allow enabling seccomp on s390x

2017-01-18 Thread Christian Ehrhardt
Allow enabling seccomp support on s390x if sufficient build dependencies are provided. Signed-off-by: Christian Ehrhardt --- configure | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configure b/configure index 86f5214..5056ba9 100755 --- a/configure +++ b/configure @@ -1927,6 +1927,9 @@

  1   2   3   4   >