Am 17.01.2017 um 16:14 hat Peter Lieven geschrieben: > Am 31.10.2016 um 18:20 schrieb Kevin Wolf: > >Am 31.10.2016 um 16:05 hat Ashijeet Acharya geschrieben: > >>Previously posted series patches: > >>v5: https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg07580.html > >>v4: https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg07449.html > >>v3: https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg06903.html > >>v2: https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg05844.html > >>v1: https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg04487.html > >> > >>This series adds blockdev-add support for NFS block driver. > >Thanks, fixed as commented on patch 1 and applied. > > Hi, > > it seems this series breaks passing options via URI. > > 1) in nfs_parse_uri > > parse_uint_full(qp->p[i].value, NULL, 0) > > segfaults, as the routine wants to set *NULL = val.
Yes, you're right. > 2) all parameters that have a different names in options and qdict > e.g. readahead-size vs. readahead cannot be passed via URI. > > $ qemu-img convert -p > nfs://172.21.200.61/templates/VC_debian8-20170116.qcow2,linux\?readahead=131072 > > iscsi://172.21.200.56:3260/iqn.2001-05.com.equallogic:0-8a0906-69d384e0a-aa3004e55e15878d-XXX/0 > > qemu-img: Could not open > 'nfs://172.21.200.61/vcore-dev-cdrom/templates/VC_debian8-20170116.qcow2,linux?readahead=131072': > Block protocol 'nfs' doesn't support the option 'readahead-size' > > Please let me know if the below fix would be correct: No, this needs to be fixed the other way round: runtime_opts must use the names as specified in the schema, and nfs_client_open() must access them as such. Without that, blockdev-add can't work (and the command line only with the "wrong" old option names from the URL, whereas it should be using the same names as the QAPI schema). Kevin
