Again v3 turned into v2... what happened ?
On Sun, 8 Jan 2017 12:55:51 +0530
Ashijeet Acharya wrote:
> On Friday, January 6, 2017, Greg Kurz > wrote:
>
> > On Wed, 4 Jan 2017 18:02:29 +0530
> > Ashijeet Acharya wrote:
> >
> > > migrate_add_blocker should rightly fail if the '--only-migratabl
On 01/08/2017 09:38 AM, Marcin Krzeminski wrote:
> n25q00 and mt25q01 devices share the same JEDEC ID. The difference
> between those two devices is number of dies and one bit in extended
> JEDEC bytes. This commit adds proper entry for both devices by
> introduction the number of dies and and new
On 01/08/2017 09:38 AM, Marcin Krzeminski wrote:
> Modern big flash nor devices consist from more than one die.
> Some of them do not support chip erase and instead have die
> erase command that can erase one die only. This commit adds
> possibility to define number of dies in the chip and adds
> s
On 06/01/2017 17:01, Sean Bruno wrote:
>
>
> On 01/06/17 01:14, Paolo Bonzini wrote:
>>
>>
>> On 05/01/2017 23:41, Sean Bruno wrote:
>>> I don't suppose it would be possible to have configure check/change the
>>> interpreter path for scripts so that operating systems that don't have
>>> /usr/bi
On Mon, Jan 09, 2017 at 10:18:45AM +0800, Peter Xu wrote:
> On Fri, Jan 06, 2017 at 01:27:38PM +, Dr. David Alan Gilbert wrote:
>
> [...]
>
> > > (P.S. I found that split irqchip cannot work well with migration. Is
> > > this an known issue?)
> >
> > How did it fail?
>
> The keyboard hangs
Signed-off-by: Peter Xu
---
hw/intc/ioapic_common.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/intc/ioapic_common.c b/hw/intc/ioapic_common.c
index 1b7ec5e..97c4f9c 100644
--- a/hw/intc/ioapic_common.c
+++ b/hw/intc/ioapic_common.c
@@ -58,7 +58,8 @@ void ioapic_print
>From time to time, there are issues with ioapic, either on guest side or
on hypervisor side. Good to have some persistent traces for better
triaging and debugging.
Signed-off-by: Peter Xu
---
hw/intc/ioapic.c | 17 +++--
hw/intc/trace-events | 7 +++
2 files changed, 22 ins
Split irqchip works based on the fact that we kept the first 24 gsi
routing entries inside KVM for userspace ioapic's use. When system
boot, we'll reserve these MSI routing entries before hand. However,
after migration, we forgot to re-configure it up in the destination
side. The result is, we'll g
Signed-off-by: Peter Xu
---
hw/intc/ioapic.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/hw/intc/ioapic.c b/hw/intc/ioapic.c
index d1254f8..9047b89 100644
--- a/hw/intc/ioapic.c
+++ b/hw/intc/ioapic.c
@@ -439,6 +439,11 @@ static void ioapic_class_init(ObjectClass *klass, void
*data)
* Fam Zheng (f...@redhat.com) wrote:
> On Fri, 01/06 18:59, Dr. David Alan Gilbert wrote:
> > * no-re...@patchew.org (no-re...@patchew.org) wrote:
> > > Hi,
> > > Checking PATCH 14/15: postcopy: Check for userfault+hugepage feature...
> > > ERROR: trailing whitespace
> > > #21: FILE: migration/post
On 09/01/2017 09:55, Peter Xu wrote:
> Split irqchip works based on the fact that we kept the first 24 gsi
> routing entries inside KVM for userspace ioapic's use. When system
> boot, we'll reserve these MSI routing entries before hand. However,
> after migration, we forgot to re-configure it up
>
> From: Hangaohuai
> Sent: Monday, December 19, 2016 2:04 PM
> To: qemu-devel@nongnu.org
> Cc: m...@redhat.com; pbonz...@redhat.com; Gonglei (Arei); Hangaohuai
> Subject: [PATCH v4] bugfix: vm halt when in reset looping
>
> reset mc146818rtc device when RESET event happens.
>
> Fix the problem:
Triaging old bug tickets ... can you still reproduce this issue with the
latest version of QEMU (currently version 2.8)?
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bug
Triaging old bug tickets ... can you still reproduce this issue with the
latest version of QEMU (currently version 2.8)?
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bug
Since it has been fixed in Precise ... I assume this has also been fixed
in upstream QEMU? Or is there still anything left to do here?
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEM
Markus Armbruster writes:
> Sascha Silbe writes:
>
>> Dear Eric,
>>
>> Eric Blake writes:
>>
+++ b/include/qapi/error.h
@@ -170,6 +170,9 @@ void error_setg_internal(Error **errp,
* Just like error_setg(), with @os_error info added to the message.
* If @os_error is non-ze
* in configure, the default optimization level is changed to O3.
* Tested successfully on following machines:
| Host machine | Host OS | qemu-system | Debian ISO |
|-|
| x86 64 | Fedora25 |i386 |i386 |
| mips 64 le
For better performance.
Signed-off-by: Jin Guojie
---
configure | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index 218df87..8ebc286 100755
--- a/configure
+++ b/configure
@@ -4753,9 +4753,9 @@ if test "$gcov" = "yes" ; then
CFLAGS="-fprofile-ar
* Eduardo Habkost (ehabk...@redhat.com) wrote:
> On Fri, Jan 06, 2017 at 08:31:27AM -0200, Marcelo Tosatti wrote:
> > On Thu, Jan 05, 2017 at 10:19:50AM -0200, Eduardo Habkost wrote:
> > > On Thu, Jan 05, 2017 at 08:48:32AM -0200, Marcelo Tosatti wrote:
> > > > On Wed, Jan 04, 2017 at 11:36:31PM -0
On 9 January 2017 at 10:01, Jin Guojie wrote:
> * in configure, the default optimization level is changed to O3.
> * Tested successfully on following machines:
>
> | Host machine | Host OS | qemu-system | Debian ISO |
> |-|
> | x86 64
On Fri, Jan 06, 2017 at 03:12:28PM +, Peter Maydell wrote:
> On 4 January 2017 at 14:51, Stefan Hajnoczi wrote:
> > On Tue, Jan 03, 2017 at 05:06:13PM +0100, Paolo Bonzini wrote:
> >> On 03/01/2017 16:53, Stefan Hajnoczi wrote:
> >> > On Fri, Dec 23, 2016 at 03:15:58PM +0100, Paolo Bonzini wro
On 4 January 2017 at 22:06, Jean-Christophe Dubois wrote:
> The i.MX SPI device was not de-asserting the CS line at the end of
> memory access.
>
> This triggered a SIGSEGV in Qemu when the sabrelite emulator was acessing
> a SPI flash memory.
>
> Whith this path the CS signal is correctly asserte
Hi
- Original Message -
> Marc-André Lureau writes:
>
> > Add a qapi2texi script to generate the documentation from the qapi
> > schemas.
> >
> > The SQUASHED patch in this series is a squashed version of the
> > documentation move from qmp-commands.txt to the schemas. The whole
> > vers
On 7 January 2017 at 11:16, Jean-Christophe Dubois wrote:
> When we overrun the internal data buffer it is suspected that the SPI
> controler (either Qemu emulator og guest driver) is misbehaving.
>
> Therefore we reset the flash internal state and issue a log.
>
> Signed-off-by: Jean-Christophe D
On 7 January 2017 at 12:20, Jean-Christophe Dubois wrote:
> From the documentation it is not clear what this SPI register is about.
>
> Moreover, neither linux driver nor xvisor driver are using this SPI register.
>
> For now we just remove it and issue a log on register write access.
>
> Signed-o
On Fri, Dec 23, 2016 at 05:28:43PM +0300, Vladimir Sementsov-Ogievskiy wrote:
Jeff or John: are you reviewing this?
> This is a new architecture for backup. It solves some current problems:
> 1. intersecting requests: for now at request start we wait for all
> intersecting requests, which means
On 01/09/2017 11:01 AM, Jin Guojie wrote:
> * in configure, the default optimization level is changed to O3.
> * Tested successfully on following machines:
>
> | Host machine | Host OS | qemu-system | Debian ISO |
> |-|
> | x86 64 |
rcu_read_unlock was not called if the address_space_access_valid result is
negative.
This caused (at least) a problem when qemu on PPC/E500+TAP failed to terminate
properly and instead got stuck in a deadlock.
Signed-off-by: Roman Kapl
---
exec.c | 1 +
1 file changed, 1 insertion(+)
diff --gi
On 9 January 2017 at 10:41, Stefan Hajnoczi wrote:
> On Fri, Jan 06, 2017 at 03:12:28PM +, Peter Maydell wrote:
>> On 4 January 2017 at 14:51, Stefan Hajnoczi wrote:
>> > On Tue, Jan 03, 2017 at 05:06:13PM +0100, Paolo Bonzini wrote:
>> >> On 03/01/2017 16:53, Stefan Hajnoczi wrote:
>> >> > O
On Mon, Jan 09, 2017 at 06:01:23PM +0800, Jin Guojie wrote:
> For better performance.
The commit message needs to have actual data on what the
measured performance improvements are really.
>
> Signed-off-by: Jin Guojie
> ---
> configure | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(
If the DECAR register is set to 0, QEMU tries to reload the decrementer with
zero in an inifinite loop. According to PPC documentation, the decrementer is
triggered on 1->0 transition, so avoid reloading the decrementer if if is
already zero.
The problem does not manifest under Linux, but it is va
Hi,
Your series seems to have some coding style problems. See output below for
more information:
Message-id: 20170109112338.5629-1-...@sysgo.com
Type: series
Subject: [Qemu-devel] [PATCH] ppc: Prevent inifnite loop in decrementer
auto-reload.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
On Monday, 9 January 2017, Greg Kurz wrote:
> Again v3 turned into v2... what happened ?
I am suspecting that my email client is at fault for this :(
>
> On Sun, 8 Jan 2017 12:55:51 +0530
> Ashijeet Acharya > wrote:
>
> > On Friday, January 6, 2017, Greg Kurz
> > ');>> wrote:
> >
> > > On Wed
* Eduardo Habkost (ehabk...@redhat.com) wrote:
> A recent glibc commit[1] added a blacklist to ensure it won't use
> TSX on hosts that are known to have a broken TSX implementation.
>
> Our existing Haswell CPU model has a blacklisted
> family/model/stepping combination, so it has to be updated to
2017-01-09 12:10 GMT+01:00 Edgar E. Iglesias :
> On Sun, Jan 08, 2017 at 09:38:53AM +0100, Marcin Krzeminski wrote:
>> Modern big flash nor devices consist from more than one die.
>> Some of them do not support chip erase and instead have die
>> erase command that can erase one die only. This commi
On 09/01/2017 12:09, Roman Kapl wrote:
> rcu_read_unlock was not called if the address_space_access_valid result is
> negative.
>
> This caused (at least) a problem when qemu on PPC/E500+TAP failed to terminate
> properly and instead got stuck in a deadlock.
>
> Signed-off-by: Roman Kapl
> ---
ing (2017-01-06 15:18:09 +)
are available in the git repository at:
git://git.linaro.org/people/pmaydell/qemu-arm.git
tags/pull-target-arm-20170109
for you to fetch changes up to 556899fc1965d82f5c4a3ba6a0be3b1193e2c4b2:
hw/ssi/imx_spi.c: Remove MSGDATA register support (2017-01-09
From: Jean-Christophe Dubois
In normal operation we should never attempt to put more
data into the data[] array than it can hold. However if the
SPI controller connected to us misbehaves then it can send
us a sequence of commands that attempt this. Since the
controller might be in the guest (if t
From: Andrew Jones
by moving VirtGuestInfo.fw_cfg to VirtMachineState. This is the
mach-virt equivalent of "pc: Move PcGuestInfo.fw_cfg to
PCMachineState" and "pc: Eliminate PcGuestInfo struct" combined.
Signed-off-by: Andrew Jones
Acked-by: Michael S. Tsirkin
Message-id: 20170102200153.28864-
From: Andrew Jones
Some simple cleanups made possible by "hw/arm/virt: Merge
VirtBoardInfo and VirtMachineState"
Signed-off-by: Andrew Jones
Reviewed-by: Igor Mammedov
Acked-by: Michael S. Tsirkin
Message-id: 20170102200153.28864-6-drjo...@redhat.com
Signed-off-by: Peter Maydell
---
hw/arm/
From: Andrew Jones
This is the ACPI equivalent to "hw/arm/virt: Don't incorrectly claim
architectural timer to be edge-triggered" which fixes the DT for
machine types 2.9 and later.
Signed-off-by: Andrew Jones
Acked-by: Michael S. Tsirkin
Message-id: 20170102200153.28864-15-drjo...@redhat.com
From: Jean-Christophe Dubois
>From the documentation it is not clear what this SPI register is about.
Moreover, neither linux driver nor xvisor driver are using this SPI register.
For now we just remove it and issue a log on register write access.
Signed-off-by: Jean-Christophe Dubois
Message
From: Andrew Jones
include/hw/arm/virt-acpi-build.h is only used for VirtGuestInfo,
which doesn't even necessarily have to be ACPI specific. Move
VirtGuestInfo to include/hw/arm/virt.h, allowing us to remove
include/hw/arm/virt-acpi-build.h, and to prepare for even more
code motion.
Signed-off-b
From: Andrew Jones
Also move the enabled flag definition from mach-virt code to
acpi common.
Signed-off-by: Andrew Jones
Message-id: 20170102200153.28864-3-drjo...@redhat.com
Reviewed-by: Peter Maydell
Signed-off-by: Peter Maydell
---
include/hw/acpi/acpi-defs.h | 9 ++---
include/h
From: Andrew Jones
We can get to VirtMachineState without the need for saving a pointer
on AcpiBuildState. This is the mach-virt equivalent to "acpi: Don't save
PcGuestInfo on AcpiBuildState"
Signed-off-by: Andrew Jones
Acked-by: Michael S. Tsirkin
Message-id: 20170102200153.28864-13-drjo...@r
From: Andrew Jones
machvirt_init may need to probe for the gic version. If so, then
make sure the result is written to VirtMachineState. With the
state up to date, use it instead of a local variable. This is a
cleanup that prepares for VirtMachineState to be passed to functions
even outside hw/ar
From: Andrew Jones
Instead of allocating a new struct just for VirtGuestInfo and the
machine_done Notifier, place them inside VirtMachineState. This
is the mach-virt equivalent of "pc: Eliminate struct
PcGuestInfoState"
Suggested-by: Eduardo Habkost
Signed-off-by: Andrew Jones
Reviewed-by: Igo
The architectural timers in ARM CPUs all have level triggered interrupts
(unless you're using KVM on a host kernel before 4.4, which misimplemented
them as edge-triggered).
We were incorrectly describing them in the device tree as edge triggered.
This can cause problems for guest kernels in 4.8 be
From: Andrew Jones
Also remove all unused flags.
Signed-off-by: Andrew Jones
Message-id: 20170102200153.28864-4-drjo...@redhat.com
Reviewed-by: Peter Maydell
Signed-off-by: Peter Maydell
---
include/hw/acpi/acpi-defs.h | 17 ++---
hw/arm/virt-acpi-build.c| 10 +-
2 fi
From: Andrew Jones
Only two functions take VirtGuestInfo parameters. Now that guest-info
is part of VirtMachineState, and VirtMachineState is defined in the
virt header, pass that instead.
Signed-off-by: Andrew Jones
Reviewed-by: Igor Mammedov
Acked-by: Michael S. Tsirkin
Message-id: 20170102
From: Andrew Jones
Signed-off-by: Andrew Jones
Message-id: 20170102200153.28864-2-drjo...@redhat.com
Signed-off-by: Peter Maydell
---
hw/arm/virt-acpi-build.c | 27 ++-
1 file changed, 14 insertions(+), 13 deletions(-)
diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/vir
From: Andrew Jones
In preparation to share more Virt machine state than just guest-info
with other mach-virt source files, move the State and Class structures
to virt.h
Signed-off-by: Andrew Jones
Reviewed-by: Igor Mammedov
Acked-by: Michael S. Tsirkin
Message-id: 20170102200153.28864-10-drjo
From: xiaoqiang zhao
Drop the old Sysbus init and use instance_init and
DeviceClass::realize instead
Signed-off-by: xiaoqiang zhao
Reviewed-by: Peter Maydell
Signed-off-by: Peter Maydell
---
hw/char/exynos4210_uart.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
di
One of the purposes of VirtBoardInfo was to hold various
bits of state about the board. Now we have MachineState
and the subclass VirtMachineState to do this. Fold the
VirtBoardInfo into VirtMachineState rather than having
some flags in one struct and some in another with no
useful way to get betwe
From: Andrew Jones
Now that we pass VirtMachineState, and guest-info is just part of
that state, we can remove all the redundant members and access
the VirtMachineState directly.
Signed-off-by: Andrew Jones
Reviewed-by: Igor Mammedov
Acked-by: Michael S. Tsirkin
Message-id: 20170102200153.288
Rename all the variables which used to be VirtBoardInfo*
and are now VirtMachineState* so their names are in line
with the type being used.
Apart from the removal of the line 'VirtMachineState *vbi = vms;'
this commit is purely a search-and-replace of 'vbi' with 'vms'.
Signed-off-by: Peter Maydel
From: Corey Minyard
Add a return value to the event handler. Some I2C devices will
NAK if they have no data, so allow them to do this. This required
the following changes:
Go through all the event handlers and change them to return int
and return 0.
Modify i2c_start_transfer to terminate the
From: Andrew Jones
Signed-off-by: Andrew Jones
Message-id: 20170102200153.28864-5-drjo...@redhat.com
Reviewed-by: Peter Maydell
Signed-off-by: Peter Maydell
---
include/hw/acpi/acpi-defs.h | 6 ++
hw/arm/virt-acpi-build.c| 4 ++--
2 files changed, 4 insertions(+), 6 deletions(-)
diff
On 09/01/2017 10:08, Gonglei (Arei) wrote:
>>
>> From: Hangaohuai
>> Sent: Monday, December 19, 2016 2:04 PM
>> To: qemu-devel@nongnu.org
>> Cc: m...@redhat.com; pbonz...@redhat.com; Gonglei (Arei); Hangaohuai
>> Subject: [PATCH v4] bugfix: vm halt when in reset looping
>>
>> reset mc146818rtc de
If the guest sets the sglist size to a value >=2GB, megasas_handle_dcmd
will return MFI_STAT_MEMORY_NOT_AVAILABLE without freeing the memory.
Avoid this by returning only the status from map_dcmd, and loading
cmd->iov_size in the caller.
Reported-by: Li Qiang
Signed-off-by: Paolo Bonzini
---
hw
Marc-André Lureau writes:
> Report the error hint when running from the command line and reaching an
Not just any hint, only the ones printed with error_printf_unless_qmp().
> error, ex:
>
> $ qemu-system-x86_64 -m 1Z
> qemu-system-x86_64: -m 1Z: Parameter 'size' expects a size
> You may use k,
Marc-André Lureau writes:
> Hi
>
> - Original Message -
>> Hi Pranith,
>>
>> Here is a proof-of-concept series for you to consider rolling into the TCG
>> tests
>> cleanup. It uses the existing docker make machinery to build a Debian
>> image which has arm, arm64 and ppc64el cross compil
Paolo Bonzini writes:
> Remove the colon, and add it in qemu-options-wrapper.h instead.
> The introduction of @subsection also found a case where the table
> was not closed and reopened around a heading, so fix it.
>
> Signed-off-by: Paolo Bonzini
Reviewed-by: Markus Armbruster
On 7 January 2017 at 12:20, Jean-Christophe Dubois wrote:
> From the documentation it is not clear what this SPI register is about.
>
> Moreover, neither linux driver nor xvisor driver are using this SPI register.
>
> For now we just remove it and issue a log on register write access.
By the way,
On 01/08/17 20:40, Eduardo Habkost wrote:
> Cc: "Michael S. Tsirkin"
> Cc: Laszlo Ersek
> Cc: Igor Mammedov
> Signed-off-by: Eduardo Habkost
> ---
> Changes v1 -> v2:
> * Added extra backslash to PC_COMPAT_2_8 definition
> * Suggested-by: Laszlo Ersek
> ---
> include/hw/i386/pc.h | 2 ++
>
On 09/01/2017 12:11, Peter Maydell wrote:
> On 9 January 2017 at 10:41, Stefan Hajnoczi wrote:
>> On Fri, Jan 06, 2017 at 03:12:28PM +, Peter Maydell wrote:
>>> On 4 January 2017 at 14:51, Stefan Hajnoczi wrote:
On Tue, Jan 03, 2017 at 05:06:13PM +0100, Paolo Bonzini wrote:
> On 03
Hi,
On 07.01.2017 16:23, Hervé Poussineau wrote:
> Machine supports both Open Hack'Ware and OpenBIOS.
> Open Hack'Ware is the default because OpenBIOS is currently unable to boot
> PReP boot partitions or PReP kernels.
>
> Signed-off-by: Hervé Poussineau
> ---
> default-configs/ppc-softmmu.mak
Hi
On Mon, Jan 9, 2017 at 1:23 PM Markus Armbruster wrote:
> Marc-André Lureau writes:
>
> > Report the error hint when running from the command line and reaching an
>
> Not just any hint, only the ones printed with error_printf_unless_qmp().
>
> > error, ex:
> >
> > $ qemu-system-x86_64 -m 1Z
On Sun, Jan 08, 2017 at 09:38:53AM +0100, Marcin Krzeminski wrote:
> Modern big flash nor devices consist from more than one die.
> Some of them do not support chip erase and instead have die
> erase command that can erase one die only. This commit adds
> possibility to define number of dies in the
Hervé Poussineau writes:
> 'ide-hd', 'ide-cd' and 'scsi-cd' devices already disable default cdrom.
> Make it the same for 'scsi-hd'.
>
> That way, we can add/replace the device on lun=2 without using -nodefaults.
Yes, but it might upset existing usage that relies on the default
CD-ROM. In my op
Running "qemu-system-ppc64 -M pseries -cpu POWER9" currently does not work
yet and results in this error message:
qemu-system-ppc64: Unable to find sPAPR CPU Core definition
Since we want to support the pseries machine with POWER9 in the future,
allow using POWER9 as hot-pluggable CPU there, too
On 06/01/2017 15:08, Vincent Palatin wrote:
> Apart from the above change, can you check if there are some less
> heavyeight methods to force an exit? I can think of QueueUserAPC with
> an empty pfnAPC here, and SleepEx(0, TRUE) in qemu_hax_cpu_thread_fn
> before qemu_wait_io_eve
If the DECAR register is set to 0, QEMU tries to reload the decrementer with
zero in an inifinite loop. According to PPC documentation, the decrementer is
triggered on 1->0 transition, so avoid reloading the decrementer if if is
already zero.
The problem does not manifest under Linux, but it is va
copying in Stefan since it's his commit.
* Doug Goldstein (car...@cardoe.com) wrote:
> I'm currently hitting an assert on master. I've bisected the change down
> to aff8fd18f1786fc5af259a9bc0077727222f51ca but obviously that's a false
> positive because that adds the assert for the condition. So o
From: Samuel Thibault
This adds two console functions, qemu_console_set_window_id and
qemu_graphic_console_get_window_id, to let graphical backend record the
window id in the QemuConsole structure, and let the baum driver read it.
Signed-off-by: Samuel Thibault
Message-id: 20161221003806.22412-
:
Merge remote-tracking branch 'remotes/vivier/tags/m68k-for-2.9-pull-request'
into staging (2016-12-28 17:11:11 +)
are available in the git repository at:
git://git.kraxel.org/qemu tags/pull-ui-20170109-1
for you to fetch changes up to f46c4259f489d2e7742890ddfaa862bde3731e3e:
From: Hervé Poussineau
This patch fixes a segfault at QEMU startup, introduced in
a08156321ab9a7d2fed9ee77dbfeea2a61ffd153.
gd_vc_find_current() return NULL, which is dereferenced without checking it.
While at it, disable the whole 'View' menu if no console exists.
Reproducer: qemu-system-i386
From: "Daniel P. Berrange"
Wayland always uses evdev as its input source, so QEMU
can use the existing evdev keymap data
Signed-off-by: Daniel P. Berrange
Tested-by: Stefan Hajnoczi
Message-id: 20161201094117.16407-1-berra...@redhat.com
Signed-off-by: Gerd Hoffmann
---
include/ui/gtk.h | 4 +
From: Samuel Thibault
This moves the SDL bits for window ID from the baum driver to SDL, as
well as fixing the build for non-X11.
Signed-off-by: Samuel Thibault
Message-id: 20161221003806.22412-3-samuel.thiba...@ens-lyon.org
Signed-off-by: Gerd Hoffmann
---
backends/baum.c | 31 --
From: Frediano Ziglio
The relicense permits sharing the code with Spice which
is LGPL.
All people listed below have agreed to the
relicense:
- Arei Gonglei;
- Cole Robinson;
- Gerd Hoffmann;
- Peter Maydell.
Signed-off-by: Frediano Ziglio
Acked-by: Cole Robinson
Acked-by: Gonglei
Acked-by: P
From: Samuel Thibault
This uses the console API to record the window ID of the SDL2 windows.
Signed-off-by: Samuel Thibault
Message-id: 20161221003806.22412-4-samuel.thiba...@ens-lyon.org
Signed-off-by: Gerd Hoffmann
---
ui/sdl2.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/ui/
From: Marc-André Lureau
When too many consoles are created, vcs[] may be write out-of-bounds.
Signed-off-by: Marc-André Lureau
Message-id: 20161207105511.25173-1-marcandre.lur...@redhat.com
Signed-off-by: Gerd Hoffmann
---
ui/gtk.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/ui/g
From: Thomas Huth
If the buffer is not big enough, snprintf() does not return the number
of bytes that have been written to the buffer, but the number of bytes
that would be needed for writing the whole string. By using this value
for the following vnc_write() calls, we send some junk at the end
Also update comment to make clear this
is for legacy mouse emulation only.
Signed-off-by: Gerd Hoffmann
Message-id: 1480409632-6163-1-git-send-email-kra...@redhat.com
---
include/ui/console.h | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/include/ui/console.h b/include/u
Marc-André Lureau writes:
> Hi
>
> On Mon, Jan 9, 2017 at 1:23 PM Markus Armbruster wrote:
>
>> Marc-André Lureau writes:
>>
>> > Report the error hint when running from the command line and reaching an
>>
>> Not just any hint, only the ones printed with error_printf_unless_qmp().
>>
>> > error
From: Stefan Weil
For builds with Mingw-w64 as it is included in Cygwin, there are two
header files which define KEY_EVENT with different values.
This results in lots of compiler warnings like this one:
CC vl.o
In file included from /qemu/include/ui/console.h:340:0,
from
From: OGAWA Hirofumi
With "ps2: use QEMU qcodes instead of scancodes", key handling was
changed to qcode base. But all scancodes are not converted to new one.
This adds some missing qcodes/scancodes what I found in using.
[set1 and set3 are from ]
Signed-off-by: OGAWA Hirofumi
Reviewed-by: Her
These patches fix a couple of issues with the VM load code
which I noticed while investigating a coverity warning.
The first patch fixes a problem with the accounting for
host pixmap memory usage -- we didn't recalculate the
current usage following a VM migration, but instead
started again at zero
Instead of calling quorum_aio_finalize() deeply nested in what used
to be an AIO callback, do it in the same functions that allocated the
AIOCB.
Signed-off-by: Kevin Wolf
Reviewed-by: Alberto Garcia
Reviewed-by: Eric Blake
---
block/quorum.c | 15 +--
1 file changed, 9 insertions(+
There is no point in passing the value of bs->opaque in order to
overwrite it with itself.
Signed-off-by: Kevin Wolf
Reviewed-by: Eric Blake
Reviewed-by: Paolo Bonzini
Reviewed-by: Alberto Garcia
---
block/quorum.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/b
remote-tracking branch 'remotes/gonglei/tags/cryptodev-next-20161224'
> into staging (2017-01-06 15:18:09 +)
>
> are available in the git repository at:
>
> git://git.linaro.org/people/pmaydell/qemu-arm.git
> tags/pull-target-arm-20170109
>
> for you to fetc
In the context of asynchronous work, if we have a worker coroutine that
didn't yield, the parent coroutine cannot be reentered because it hasn't
yielded yet. In this case we don't even have to reenter the parent
because it will see that the work is already done and won't even yield.
Signed-off-by:
From: Paolo Bonzini
With aio=native (qemu-img bench -n) one or more requests can be completed
when a new request is submitted. This in turn can cause bench_cb to
recurse before b->in_flight is updated. This causes multiple I/Os
to be submitted with the same offset and, furthermore, the blk_aio_
This converts the quorum block driver from implementing callback-based
interfaces for read/write to coroutine-based ones. This is the first
step that will allow us further simplification of the code.
Signed-off-by: Kevin Wolf
Reviewed-by: Eric Blake
Reviewed-by: Alberto Garcia
---
block/quorum
The following changes since commit ffe22bf51065dd33022cf91f77a821d1f11c250d:
Merge remote-tracking branch 'remotes/gonglei/tags/cryptodev-next-20161224'
into staging (2017-01-06 15:18:09 +)
are available in the git repository at:
git://repo.or.cz/qemu/kevin.git tags/for-upstream
for y
This enables byte granularity requests on quorum nodes.
Note that the QMP events emitted by the driver are an external API that
we were careless enough to define as sector based. The offset and length
of requests reported in events are rounded therefore.
Signed-off-by: Kevin Wolf
Reviewed-by: Er
This is a conversion to a more natural coroutine style and improves the
readability of the driver.
Signed-off-by: Kevin Wolf
Reviewed-by: Alberto Garcia
Reviewed-by: Eric Blake
---
block/quorum.c | 128 ++---
1 file changed, 59 insertions(+),
Replacing it with bdrv_co_pwritev() prepares us for byte granularity
requests and gets us rid of the last bdrv_aio_*() user in quorum.
Signed-off-by: Kevin Wolf
Reviewed-by: Alberto Garcia
Reviewed-by: Eric Blake
---
block/quorum.c | 46 +++---
1 file ch
e pull,
> Gerd
>
> The following changes since commit dbe2b65566e76d3c3a0c3358285c0336ac61e757:
>
> Merge remote-tracking branch
> 'remotes/vivier/tags/m68k-for-2.9-pull-request' into staging (2016-12-28
> 17:11:11 +)
>
> are available in the git repository
Inlining the function removes some boilerplace code and replaces
recursion by a simple loop, so the code becomes somewhat easier to
understand.
Signed-off-by: Kevin Wolf
Reviewed-by: Alberto Garcia
Reviewed-by: Eric Blake
---
block/quorum.c | 42 +-
1 fi
1 - 100 of 348 matches
Mail list logo
