Hervé Poussineau <hpous...@reactos.org> writes:
> 'ide-hd', 'ide-cd' and 'scsi-cd' devices already disable default cdrom.
> Make it the same for 'scsi-hd'.
>
> That way, we can add/replace the device on lun=2 without using -nodefaults.
Yes, but it might upset existing usage that relies on the default
CD-ROM. In my opinion, making your needs explicit is better than
relying on defaults, but that doesn't mean we can change the defaults
unthinkingly. Definitely not qemu-trivial.
Opinions on the change?
> Signed-off-by: Hervé Poussineau <hpous...@reactos.org>
> ---
> vl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/vl.c b/vl.c
> index d77dd86..da97fe2 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -223,6 +223,7 @@ static struct {
> { .driver = "ide-hd", .flag = &default_cdrom },
> { .driver = "ide-drive", .flag = &default_cdrom },
> { .driver = "scsi-cd", .flag = &default_cdrom },
> + { .driver = "scsi-hd", .flag = &default_cdrom },
> { .driver = "virtio-serial-pci", .flag = &default_virtcon },
> { .driver = "virtio-serial", .flag = &default_virtcon },
> { .driver = "VGA", .flag = &default_vga },
