Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-12-16 Thread Stefan Hajnoczi
On Fri, Dec 16, 2016 at 1:42 AM, Buddhi Madhav wrote: > Does this authentication scheme works? > > 1) Pass the encrypted password to qemu-kvm as follows: > > # . /qemu-io --object secret,id=secmaster0,format=base64,file=key.b64 >--object > secret,id=password-secret,keyid=secmaster

[Qemu-devel] [PATCH v3] bugfix: vm halt when in reset looping

2016-12-16 Thread hangaohuai
reset mc146818rtc device when RESET event happens. Fix the problem: 1. Guest boot the second cpu, set CMOS_RESET_CODE 0x0a to protect selfboot; 2. VM being reset by others, hmp_system_reset; 3. seabios resume check the CMOS_RESET_CODE, if 0x0a, jump to the BDA resume execution by jump v

Re: [Qemu-devel] regression in 2.8: unable to exit screen grab in SDL mode

2016-12-16 Thread Thomas Huth
On 15.12.2016 20:19, Michael S. Tsirkin wrote: > On Thu, Dec 15, 2016 at 09:15:27PM +0200, Michael S. Tsirkin wrote: >> On Thu, Dec 15, 2016 at 05:25:50PM +0100, Gerd Hoffmann wrote: >>> Hi, >>> >>> The problem always reproduces for me: >>> - start qemu with -sdl >>> - wait for guest

[Qemu-devel] [Bug 922076] Re: doesn't clear screen on boot

2016-12-16 Thread Thomas Huth
** Changed in: qemu Status: Incomplete => Triaged -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/922076 Title: doesn't clear screen on boot Status in QEMU: Triaged Bug description: When

[Qemu-devel] [PATCH 1/1] scsi-disk: passthrough VERIFY command

2016-12-16 Thread Junlian Bell
When a scsi-disk object receives VERIFY command with BYTCHK bit being zero, scsi_block_is_passthrough returns false and finally makes req being proceeded by scsi_block_dma_command. Because scsi_block_dma_command has removed process of VERIFY, QEMU will abort in this function. This patch makes all

Re: [Qemu-devel] regression in 2.8: unable to exit screen grab in SDL mode

2016-12-16 Thread Liviu Ionescu
> On 16 Dec 2016, at 10:26, Thomas Huth wrote: > > ... so I would recommend to keep the SDL code in QEMU. SDL 1.2 is largely deprecated now, when I upgraded to macOS 10.12 I suddenly started to have various problems. so I decided to upgrade GNU ARM Eclipse to SDL 2. if all graphic calls are

Re: [Qemu-devel] [PATCH v3] audio: ac97: add exit function

2016-12-16 Thread Marc-André Lureau
On Thu, Dec 15, 2016 at 5:30 AM Li Qiang wrote: > From: Li Qiang > > Currently the ac97 device emulation doesn't have a exit function, > hot unplug this device will leak some memory. Add a exit function to > avoid this. > > Signed-off-by: Li Qiang > Reviewed-by: Marc-André Lureau > --- >

Re: [Qemu-devel] [PATCH v3] audio: es1370: add exit function

2016-12-16 Thread Marc-André Lureau
On Thu, Dec 15, 2016 at 5:32 AM Li Qiang wrote: > From: Li Qiang > > Currently the es1370 device emulation doesn't have a exit function, > hot unplug this device will leak some memory. Add a exit function to > avoid this. > > Signed-off-by: Li Qiang > > --- > > Changes since the v2: > take ou

Re: [Qemu-devel] regression in 2.8: unable to exit screen grab in SDL mode

2016-12-16 Thread Kevin Wolf
Am 16.12.2016 um 09:26 hat Thomas Huth geschrieben: > On 15.12.2016 20:19, Michael S. Tsirkin wrote: > > On Thu, Dec 15, 2016 at 09:15:27PM +0200, Michael S. Tsirkin wrote: > >> On Thu, Dec 15, 2016 at 05:25:50PM +0100, Gerd Hoffmann wrote: > Do we fix this or disable SDL altogether? > >>> > >

Re: [Qemu-devel] [PATCH] vnc: track LED state separately

2016-12-16 Thread Pierre Ossman
On 15/12/16 17:41, Gerd Hoffmann wrote: -caps = ledstate & QEMU_CAPS_LOCK_LED ? 1 : 0; -num = ledstate & QEMU_NUM_LOCK_LED ? 1 : 0; -scr = ledstate & QEMU_SCROLL_LOCK_LED ? 1 : 0; +if (ledstate != vd->ledstate) +return; Hmm? Shouldn't that be (ledstate == vd->ledsta

Re: [Qemu-devel] [PATCH for-2.9 00/10] pc: acpi: memory hotplug cleanup/consolidation

2016-12-16 Thread Igor Mammedov
On Tue, 6 Dec 2016 00:32:19 +0100 Igor Mammedov wrote: > Series cleanups and consolidates scattered memory hotplug > code so it could be easily reused by ARM target later. > > As result: > * added memory hotplug variant to bios tables test > * all ACPI related parts of memory hotplug are cons

Re: [Qemu-devel] [PATCH 07/11] hw/arm/virt: pass VirtMachineState instead of VirtGuestInfo

2016-12-16 Thread Igor Mammedov
On Thu, 15 Dec 2016 17:24:05 +0100 Andrew Jones wrote: > On Thu, Dec 15, 2016 at 03:45:55PM +0100, Igor Mammedov wrote: > > On Tue, 13 Dec 2016 22:45:18 +0100 > > Andrew Jones wrote: > > > > > Only two functions take VirtGuestInfo parameters. Now that guest-info > > > is part of VirtMachineSt

Re: [Qemu-devel] [PATCH v7 3/5] IOMMU: enable intel_iommu map and unmap notifiers

2016-12-16 Thread Liu, Yi L
> From: "Aviv Ben-David" > > Adds a list of registered vtd_as's to intel iommu state to save > iteration over each PCI device in a search of the corrosponding domain. > > Signed-off-by: Aviv Ben-David > --- > hw/i386/intel_iommu.c | 94 > ++ >

[Qemu-devel] [Bug 1042561] Re: Guest has no "xsave" feature with parameter "-cpu qemu64, +xsave" in qemu command line.

2016-12-16 Thread Thomas Huth
** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1042561 Title: Guest has no "xsave" feature with parameter "-cpu qemu64,+xsave" in qemu command lin

Re: [Qemu-devel] regression in 2.8: unable to exit screen grab in SDL mode

2016-12-16 Thread Howard Spoelstra
On Fri, Dec 16, 2016 at 10:00 AM, Kevin Wolf wrote: > Am 16.12.2016 um 09:26 hat Thomas Huth geschrieben: >> On 15.12.2016 20:19, Michael S. Tsirkin wrote: >> > On Thu, Dec 15, 2016 at 09:15:27PM +0200, Michael S. Tsirkin wrote: >> >> On Thu, Dec 15, 2016 at 05:25:50PM +0100, Gerd Hoffmann wrote:

[Qemu-devel] [Bug 1068900] Re: Thread cancellation broken in app-level emulation

2016-12-16 Thread Thomas Huth
The URL from comment #1 is unfortunately not valid anymore. If this issue is still pending, could you please post your patch again to the qemu-devel mailing list to get it discussed and included? Thanks! ** Changed in: qemu Status: New => Incomplete -- You received this bug notification b

Re: [Qemu-devel] regression in 2.8: unable to exit screen grab in SDL mode

2016-12-16 Thread Kevin Wolf
Am 15.12.2016 um 23:30 hat Michael S. Tsirkin geschrieben: > On Thu, Dec 15, 2016 at 05:25:50PM +0100, Gerd Hoffmann wrote: > > Hi, > > > > > > > > The problem always reproduces for me: > > > > > > - start qemu with -sdl > > > > > > - wait for guest to boot > > > > > > - click anywhere within gu

[Qemu-devel] [Bug 1063807] Re: KVM crashes when booting a PointSec encrypted Windows 7

2016-12-16 Thread Thomas Huth
Since this is very likely rather a KVM kernel bug than a QEMU userspace bug, could you please report it to the KVM mailing list / bug tracker instead (see http://www.linux-kvm.org/page/Bugs)? Thanks! ** Changed in: qemu Status: New => Invalid -- You received this bug notification because

Re: [Qemu-devel] [RFC] PCI/migration merge vmstate_pci_device and vmstate_pcie_device

2016-12-16 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > On Wed, Dec 14, 2016 at 07:58:29PM +, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > The vmstate_pci_device and vmstate_pcie_devices differ > > just in the size of one buffer; combine the two using a _TEST > > mac

Re: [Qemu-devel] regression in 2.8: unable to exit screen grab in SDL mode

2016-12-16 Thread Gerd Hoffmann
> > [ 2.6 good, 2.7, 2.8 bad ] > > It doesn't reproduce here. There must be some other factor which is > > needed to trigger this. What desktop you are using? gnome? kde? > > something else? Xorg or wayland? > > > > Can you try to bisect it? > > > > cheers, > > Gerd > > > Looks like 2.6

Re: [Qemu-devel] [RFC] qmp: query-device-slots command

2016-12-16 Thread Markus Armbruster
Laine Stump writes: > On 12/15/2016 05:12 AM, Marcel Apfelbaum wrote: >> On 12/14/2016 10:10 PM, Laine Stump wrote: >>> On 12/14/2016 12:17 PM, Marcel Apfelbaum wrote: Be aware that 1 slot doesn't necessarily refer to only one device, we can have a multi-function device. >>> >>> Is that

Re: [Qemu-devel] Lock contention in QEMU

2016-12-16 Thread Stefan Hajnoczi
On Thu, Dec 15, 2016 at 11:04:23AM -0500, Weiwei Jia wrote: > On Thu, Dec 15, 2016 at 3:06 AM, Stefan Hajnoczi wrote: > > On Thu, Dec 15, 2016 at 12:17:09AM -0500, Weiwei Jia wrote: > >> BTW, do we have an example to show users how to config following > >> virtio-blk dataplane commands into XML co

Re: [Qemu-devel] regression in 2.8: unable to exit screen grab in SDL mode

2016-12-16 Thread Gerd Hoffmann
Hi, > One strange thing - I only see it when guest is in graphical mode. > If guest is in text mode it works ok. grabbing works slightly different depending on whenever the mouse is in absolute or relative mode, which is probably the reason for that. With absolute mouse mode being active (usin

[Qemu-devel] [PATCH v2 0/4] Introduce a new --only-migratable option

2016-12-16 Thread Ashijeet Acharya
Previously posted series patches: http://lists.nongnu.org/archive/html/qemu-devel/2016-12/msg02062.html This series adds a new command line option "--only-migratable" which will only allow addition of those devices to a QEMU instance which are migratable and do not abruptly fail QEMU after migrati

[Qemu-devel] [PATCH v2 1/4] migration: Add a new option to enable only-migratable

2016-12-16 Thread Ashijeet Acharya
Add a new option "--only-migratable" in qemu which will allow to add only those devices which will not fail qemu after migration. Devices set with the flag 'unmigratable' cannot be added when this option will be used. Signed-off-by: Ashijeet Acharya --- include/migration/migration.h | 3 +++ qem

[Qemu-devel] [PATCH v2 2/4] migration: Allow "device add" options to only add migratable devices

2016-12-16 Thread Ashijeet Acharya
Introduce checks for the unmigratable flag in the VMStateDescription structs of respective devices when user attempts to add them. If the "--only-migratable" was specified, all unmigratable devices will rightly fail to add. This feature is made compatible for both "-device" and "-usbdevice" command

[Qemu-devel] [PATCH v2 3/4] migration: disallow migrate_add_blocker during migration

2016-12-16 Thread Ashijeet Acharya
If a migration is already in progress and somebody attempts to add a migration blocker, this should rightly fail. Add an errp parameter and a retcode return value to migrate_add_blocker. Signed-off-by: John Snow Signed-off-by: Ashijeet Acharya --- block/qcow.c | 6 +- blo

[Qemu-devel] [PATCH v2 4/4] migration: Fail migration blocker for --only-migratble

2016-12-16 Thread Ashijeet Acharya
migrate_add_blocker should rightly fail if the '--only-migratable' option was specified and the device in use should not be able to perform the action which results in an unmigratable VM. Make migrate_add_blocker return -EACCES in this case. Signed-off-by: Ashijeet Acharya --- block/qcow.c

Re: [Qemu-devel] [qemu patch V4 2/2] kvmclock: reduce kvmclock difference on migration

2016-12-16 Thread Paolo Bonzini
I'd like to make a few cleanups and add more documentation: diff --git a/hw/i386/kvm/clock.c b/hw/i386/kvm/clock.c index eacc9dc..f767ea9 100644 --- a/hw/i386/kvm/clock.c +++ b/hw/i386/kvm/clock.c @@ -37,7 +37,7 @@ typedef struct KVMClockState { uint64_t clock; bool clock_valid; -/

Re: [Qemu-devel] [PATCH v2 0/4] Introduce a new --only-migratable option

2016-12-16 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v2 0/4] Introduce a new --only-migratable option Message-id: 1481882024-10016-1-git-send-email-ashijeetacha...@gmail.com === TEST SCRIPT BEGIN === #!/bin/bas

Re: [Qemu-devel] [PATCH 1/1] scsi-disk: passthrough VERIFY command

2016-12-16 Thread Paolo Bonzini
On 16/12/2016 08:55, Junlian Bell wrote: > When a scsi-disk object receives VERIFY command with BYTCHK bit being zero, > scsi_block_is_passthrough returns false and finally makes req being proceeded > by scsi_block_dma_command. Because scsi_block_dma_command has removed process > of VERIFY, QEMU

Re: [Qemu-devel] [PATCH v3 08/25] block: Add bdrv_make_absolute_filename()

2016-12-16 Thread Alberto Garcia
On Wed 30 Nov 2016 02:18:34 AM CET, Max Reitz wrote: > This is a general function for making a filename that is relative to a > certain BDS absolute. > > It calls bdrv_get_full_backing_filename_from_filename() for now, but > that will be changed in a follow-up patch. > > Signed-off-by: Max Reitz

Re: [Qemu-devel] [PATCH] virtio: fix vring->inuse recalc after migr

2016-12-16 Thread Stefan Hajnoczi
On Thu, Dec 15, 2016 at 04:43:30PM +0100, Halil Pasic wrote: > Correct recalculation of vring->inuse after migration for > the corner case where the avail_idx has already wrapped > but used_idx not yet. > > Signed-off-by: Halil Pasic > Fixes: bccdef6b ("virtio: recalculate vq->inuse after migrati

Re: [Qemu-devel] [RFC] qmp: query-device-slots command

2016-12-16 Thread Markus Armbruster
Eduardo Habkost writes: > On Wed, Dec 14, 2016 at 09:11:10PM +0100, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > On Wed, Dec 14, 2016 at 04:34:04PM +0100, Markus Armbruster wrote: >> >> Eduardo Habkost writes: >> >> >> >> > On Tue, Dec 13, 2016 at 08:51:34PM +0100, Markus Armbr

Re: [Qemu-devel] [PATCH v2 3/4] migration: disallow migrate_add_blocker during migration

2016-12-16 Thread Greg Kurz
On Fri, 16 Dec 2016 15:23:43 +0530 Ashijeet Acharya wrote: > If a migration is already in progress and somebody attempts > to add a migration blocker, this should rightly fail. > > Add an errp parameter and a retcode return value to migrate_add_blocker. > > Signed-off-by: John Snow > Signed-of

Re: [Qemu-devel] Measure virtio-vsock speed

2016-12-16 Thread Stefan Hajnoczi
On Thu, Dec 15, 2016 at 05:00:35PM +0800, Zhang Shuaiyi wrote: > I used kernel 4.8 and qemu v2.8.0-rc3. > Qemu command line: > -device vhost-vsock-pci,id=vhost-vsock-pci0,guest-cid=3 > > I try to use nc-vsock to test vsock speed. > 1. In host: > # modprobe vhost-vsock > # ./nc-vsock -l 1234

Re: [Qemu-devel] [PATCH 1/1] scsi-disk: passthrough VERIFY command

2016-12-16 Thread zhong...@sangfor.com.cn
Yes, it's also work. So you prefer the latter? zhong...@sangfor.com.cn From: Paolo Bonzini Date: 2016-12-16 18:10 To: Junlian Bell CC: qemu-devel Subject: Re: [PATCH 1/1] scsi-disk: passthrough VERIFY command On 16/12/2016 08:55, Junlian Bell wrote: > When a scsi-disk object receives VERIF

Re: [Qemu-devel] [PATCH v3] bugfix: vm halt when in reset looping

2016-12-16 Thread Paolo Bonzini
On 16/12/2016 09:23, hangaohuai wrote: > reset mc146818rtc device when RESET event happens. > > Fix the problem: > 1. Guest boot the second cpu, set CMOS_RESET_CODE 0x0a to protect selfboot; > 2. VM being reset by others, hmp_system_reset; > 3. seabios resume check the CMOS_RESET_CODE, if

[Qemu-devel] [Bug 691424] Re: qemu/kvm SDL over ssh -X broken

2016-12-16 Thread Bernhard M. Wiedemann
It seems to be working now with current versions, so has probably been fixed somewhere. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/691424 Title: qemu/kvm SDL over ssh -X broken Status in QEMU:

Re: [Qemu-devel] [PATCH] target-i386: Fix eflags.TF/#DB handling of syscall/sysret insns

2016-12-16 Thread Paolo Bonzini
On 07/12/2016 00:06, Doug Evans wrote: > Hi. > > While qemu's behaviour matches what one would expect from reading > the docs, it does not match what I'm seeing on h/w. > Can anyone else confirm what the correct behaviour is here? > > --- > > The syscall and sysret instructions behave a bit di

Re: [Qemu-devel] [PATCH v2 4/4] migration: Fail migration blocker for --only-migratble

2016-12-16 Thread Greg Kurz
On Fri, 16 Dec 2016 15:23:44 +0530 Ashijeet Acharya wrote: > migrate_add_blocker should rightly fail if the '--only-migratable' > option was specified and the device in use should not be able to > perform the action which results in an unmigratable VM. > > Make migrate_add_blocker return -EACCES

[Qemu-devel] [Bug 691424] Re: qemu/kvm SDL over ssh -X broken

2016-12-16 Thread Thomas Huth
OK, thanks a lot for testing it again! ** Changed in: qemu Status: Incomplete => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/691424 Title: qemu/kvm SDL over ssh -X broken St

Re: [Qemu-devel] [PATCH v2 4/4] migration: Fail migration blocker for --only-migratble

2016-12-16 Thread Peter Maydell
On 16 December 2016 at 09:53, Ashijeet Acharya wrote: > migrate_add_blocker should rightly fail if the '--only-migratable' > option was specified and the device in use should not be able to > perform the action which results in an unmigratable VM. > > Make migrate_add_blocker return -EACCES in thi

[Qemu-devel] [for 2.9] balloon: Don't balloon roms

2016-12-16 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" A broken guest can specify physical addresses that correspond to any memory region, but it shouldn't be able to change ROM. Signed-off-by: Dr. David Alan Gilbert --- hw/virtio/trace-events | 2 ++ hw/virtio/virtio-balloon.c | 7 ++- 2 files changed, 8 ins

Re: [Qemu-devel] Making TCG configurable in system mode

2016-12-16 Thread Alvise Rigo
On Wed, Dec 14, 2016 at 10:51 PM, Paolo Bonzini wrote: > >> I am looking at the possibility to add a new QEMU configuration option >> to make TCG optional (in qemu-system-*). What I am exploring is a way >> to exclude any of the TCG code not needed by KVM from the QEMU binary. >> There has been a

Re: [Qemu-devel] Making TCG configurable in system mode

2016-12-16 Thread Peter Maydell
On 16 December 2016 at 11:49, Alvise Rigo wrote: > On Wed, Dec 14, 2016 at 10:51 PM, Paolo Bonzini wrote: >> The hardest part is making sure that it doesn't bitrot, and it's hard >> because we don't have CI for architectures other than x86. But at least >> Peter builds on ARM, and target submain

Re: [Qemu-devel] [PATCH 2/2] vmxnet3: VMStatify rx/tx q_descr and int_state

2016-12-16 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (git) (dgilb...@redhat.com) wrote: > From: "Dr. David Alan Gilbert" > > Fairly simple mechanical conversion of all fields. > > TODO > The problem is vmxnet3-ring size/cell_size/next are declared as size_t > but written as 32bit. Oops, I should have removed that warn

Re: [Qemu-devel] [for 2.9] balloon: Don't balloon roms

2016-12-16 Thread Paolo Bonzini
On 16/12/2016 12:41, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > A broken guest can specify physical addresses that correspond > to any memory region, but it shouldn't be able to change ROM. > > Signed-off-by: Dr. David Alan Gilbert > --- > hw/virtio/trace-events

Re: [Qemu-devel] [PATCH v4 5/8] hw/i2c: Tidy up NULL check for i2c slave init callbacks

2016-12-16 Thread Peter Maydell
On 15 December 2016 at 05:48, Alastair D'Silva wrote: > From: Alastair D'Silva > > Remove unnecessary syntax > > Signed-off-by: Alastair D'Silva > --- > hw/i2c/core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/i2c/core.c b/hw/i2c/core.c > index ae3ca94..e407

Re: [Qemu-devel] [PATCH] x86: implement la57 paging mode

2016-12-16 Thread Paolo Bonzini
On 15/12/2016 01:13, Kirill A. Shutemov wrote: > The new paging more is extension of IA32e mode with more additional page > table level. > > It brings support of 57-bit vitrual address space (128PB) and 52-bit > physical address space (4PB). > > The structure of new page table level is identica

Re: [Qemu-devel] [PATCH v4 1/8] arm: Uniquely name imx25 I2C buses.

2016-12-16 Thread Peter Maydell
On 15 December 2016 at 05:48, Alastair D'Silva wrote: > From: Alastair D'Silva > > The imx25 chip provides 3 i2c buses, but they have all been named > "i2c", which makes it difficult to predict which bus a device will > be connected to when specified on the command line. > > This patch addresses

Re: [Qemu-devel] [PATCH v3] target-arm: Add VBAR support to ARM1176 CPUs

2016-12-16 Thread Peter Maydell
On 15 December 2016 at 14:09, Cédric Le Goater wrote: > ARM1176 CPUs have TrustZone support and can use the Vector Base > Address Register, but currently, qemu only adds VBAR support to ARMv7 > CPUs. Fix this by adding a new feature ARM_FEATURE_VBAR which can used > for ARMv7 and ARM1176 CPUs. > >

Re: [Qemu-devel] [PATCH] x86: implement la57 paging mode

2016-12-16 Thread Kirill A. Shutemov
On Fri, Dec 16, 2016 at 01:59:36PM +0100, Paolo Bonzini wrote: > > > On 15/12/2016 01:13, Kirill A. Shutemov wrote: > > The new paging more is extension of IA32e mode with more additional page > > table level. > > > > It brings support of 57-bit vitrual address space (128PB) and 52-bit > > physi

Re: [Qemu-devel] [PATCH v3 07/25] block: bdrv_get_full_backing_filename's ret. val.

2016-12-16 Thread Max Reitz
On 15.12.2016 17:39, Alberto Garcia wrote: > On Wed 30 Nov 2016 02:18:33 AM CET, Max Reitz wrote: >> int bdrv_open_backing_file(BlockDriverState *bs, QDict *parent_options, >> const char *bdref_key, Error **errp) >> { >> -char *backing_filename = g_malloc0(PATH_MAX

Re: [Qemu-devel] [RFC] qmp: query-device-slots command

2016-12-16 Thread Eduardo Habkost
On Fri, Dec 16, 2016 at 11:37:00AM +0100, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Wed, Dec 14, 2016 at 09:11:10PM +0100, Markus Armbruster wrote: > >> Eduardo Habkost writes: > >> > >> > On Wed, Dec 14, 2016 at 04:34:04PM +0100, Markus Armbruster wrote: > >> >> Eduardo Habko

[Qemu-devel] [RFC 1/3] nvic: Add CPU numebr property

2016-12-16 Thread marcin.krzeminski
From: Marcin Krzeminski In case of MultiCPU SoC M3 is not always CPU0. This commit add cpu_id property to allow set CPU number for NVIC model. Also address space that this used by NVIC is updated to mach CPU's one. Signed-off-by: Marcin Krzeminski --- hw/intc/armv7m_nvic.c | 24 +++

[Qemu-devel] [RFC 0/3] MultiCPU changes

2016-12-16 Thread marcin.krzeminski
From: Marcin Krzeminski Those are changes that I made to create SoC model with 2xCortexA9 and Cortex-M3. Generally all are done to allow move work further, not to upstreaming (especially patch 3). I would like to start discossion if those modification could be upstreamed. Marcin Krzeminski (3):

Re: [Qemu-devel] [qemu patch V4 2/2] kvmclock: reduce kvmclock difference on migration

2016-12-16 Thread Eduardo Habkost
On Fri, Dec 16, 2016 at 11:03:33AM +0100, Paolo Bonzini wrote: > I'd like to make a few cleanups and add more documentation: > Looks good to me. Reviewed-by: Eduardo Habkost > diff --git a/hw/i386/kvm/clock.c b/hw/i386/kvm/clock.c > index eacc9dc..f767ea9 100644 > --- a/hw/i386/kvm/clock.c > +

Re: [Qemu-devel] [PATCH v3 07/25] block: bdrv_get_full_backing_filename's ret. val.

2016-12-16 Thread Alberto Garcia
On Fri 16 Dec 2016 02:26:29 PM CET, Max Reitz wrote: >>> int bdrv_open_backing_file(BlockDriverState *bs, QDict *parent_options, >>> const char *bdref_key, Error **errp) >>> { >>> -char *backing_filename = g_malloc0(PATH_MAX); >>> +char *backing_filename = NUL

[Qemu-devel] [RFC 2/3] ARM: boot: Add option to skip FDT memory node update

2016-12-16 Thread marcin.krzeminski
From: Marcin Krzeminski When Qemu boots directly ARM kernel the memory node in device tree is automatically updated to mach guest RAM size assigned to Qemu. This commit allow use case when user do not want to pass all guest RAM to linux kernel by skipping device tree mmory node update. Signed-of

[Qemu-devel] [RFC 3/3] exec: Allow to change Address Space from board level

2016-12-16 Thread marcin.krzeminski
From: Marcin Krzeminski By introduction of CPUAddressSpace table it is not possible to change address space for CPU from board code. In my case Cortex-M3 core has it own address space that is created at board level, then updated by changing cpu->as. For current code cpu->as is used only at init,

[Qemu-devel] [PATCH 2/2] block: m25p80: Introduce Die Erase command

2016-12-16 Thread marcin.krzeminski
From: Marcin Krzeminski Big flash chips (like mt25qu01g) are consisted from dies. Because of that some manufactures remove support for Chip Erase giving Die Erase command instead.To avoid unnecessary code complication, support for chip erase for mt25qu01g is not removed. Signed-off-by: Marcin Kr

Re: [Qemu-devel] [PATCH v5 2/3] utils: Add helper to read arm MIDR_EL1 register

2016-12-16 Thread Peter Maydell
On 7 December 2016 at 17:06, wrote: > From: Vijaya Kumar K > > Add helper API to read MIDR_EL1 registers to fetch > cpu identification information. This helps in > adding errata's and architecture specific features. > > This is implemented only for arm architecture. > > Signed-off-by: Vijaya Kum

Re: [Qemu-devel] [RFC 0/3] MultiCPU changes

2016-12-16 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [RFC 0/3] MultiCPU changes Message-id: 1481894559-13974-1-git-send-email-marcin.krzemin...@nokia.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(gi

Re: [Qemu-devel] Making TCG configurable in system mode

2016-12-16 Thread Alex Bennée
Laurent Vivier writes: > On 14/12/2016 20:30, Alvise Rigo wrote: >> Hi all, >> >> I am looking at the possibility to add a new QEMU configuration option >> to make TCG optional (in qemu-system-*). What I am exploring is a way >> to exclude any of the TCG code not needed by KVM from the QEMU bina

Re: [Qemu-devel] [RFC 1/3] nvic: Add CPU numebr property

2016-12-16 Thread Peter Maydell
On 16 December 2016 at 13:22, wrote: > From: Marcin Krzeminski > > In case of MultiCPU SoC M3 is not always CPU0. > This commit add cpu_id property to allow set CPU > number for NVIC model. Also address space that this used > by NVIC is updated to mach CPU's one. > > Signed-off-by: Marcin Krzemi

Re: [Qemu-devel] [PATCH 07/21] qcow2: add bitmaps extension

2016-12-16 Thread Max Reitz
On 14.12.2016 13:23, Vladimir Sementsov-Ogievskiy wrote: > 07.12.2016 21:25, Max Reitz wrote: >> On 22.11.2016 18:26, Vladimir Sementsov-Ogievskiy wrote: >>> Add bitmap extension as specified in docs/specs/qcow2.txt. >>> For now, just mirror extension header into Qcow2 state and check >>> constrain

Re: [Qemu-devel] [PATCH v2 5/7] linux-user: Fix readahead

2016-12-16 Thread Peter Maydell
On 24 November 2016 at 16:08, Lena Djokic wrote: > Calculation of 64-bit offset was not correct for all cases. > > Signed-off-by: Lena Djokic > --- > linux-user/syscall.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/linux-user/syscall.c b/linux-user/syscall.c > index

Re: [Qemu-devel] [Qemu-block] [PATCH v1 1/1] iotests: Fix a problem in common.filter

2016-12-16 Thread Eric Blake
[adding qemu-devel, ALL patches should include the main list] On 12/15/2016 11:47 PM, QingFeng Hao wrote: > If TEST_DIR is set to /tmp, test case 144 will fail. The reason is that > TEST_DIR duplicates with 144's test image name tmp.qcow2. s/duplicates with/resembles/ > when 144 is testing $TEST

Re: [Qemu-devel] Lock contention in QEMU

2016-12-16 Thread Weiwei Jia
On Fri, Dec 16, 2016 at 4:48 AM, Stefan Hajnoczi wrote: > On Thu, Dec 15, 2016 at 11:04:23AM -0500, Weiwei Jia wrote: >> On Thu, Dec 15, 2016 at 3:06 AM, Stefan Hajnoczi wrote: >> > On Thu, Dec 15, 2016 at 12:17:09AM -0500, Weiwei Jia wrote: >> >> BTW, do we have an example to show users how to c

Re: [Qemu-devel] [PATCH 09/21] qcow2: add .bdrv_load_autoloading_dirty_bitmaps

2016-12-16 Thread Max Reitz
On 14.12.2016 16:54, Vladimir Sementsov-Ogievskiy wrote: > 07.12.2016 23:51, Max Reitz wrote: >> On 22.11.2016 18:26, Vladimir Sementsov-Ogievskiy wrote: >>> Auto loading bitmaps are bitmaps in Qcow2, with the AUTO flag set. They >>> are loaded when the image is opened and become BdrvDirtyBitmaps f

Re: [Qemu-devel] [PATCH v2 6/7] linux-user: Fix syslog

2016-12-16 Thread Peter Maydell
On 24 November 2016 at 16:08, Lena Djokic wrote: > Third argument represents lenght not second. typo: "length" > If second argument is NULL it should be passed without > using lock_user function which would, in that case, return > EFAULT, and system call supports passing NULL as second argument.

Re: [Qemu-devel] [PATCH v2 7/7] linux-user: Fix mq_open

2016-12-16 Thread Peter Maydell
On 24 November 2016 at 16:08, Lena Djokic wrote: > If fourth argument is NULL it should be passed without > using lock_user function which would, in that case, return > EFAULT, and system call supports passing NULL as fourth argument. > > Signed-off-by: Lena Djokic > --- > linux-user/syscall.c |

Re: [Qemu-devel] [PATCH v2 4/7] linux-user: Fix fcnt

2016-12-16 Thread Peter Maydell
On 24 November 2016 at 16:08, Lena Djokic wrote: Making the subject line "linux-user: fix F_GETSIG and F_SETSIG fcntls" would be a bit more precise about what we're fixing here and I think that will be helpful for people looking back in the git log later. > F_GETSIG and F_SETSIG were implemented

Re: [Qemu-devel] [PATCH v2 3/7] linux-user: Fix flock definition for mips64

2016-12-16 Thread Peter Maydell
On 24 November 2016 at 16:08, Lena Djokic wrote: > Mips64 uses generic flock structure. > See /arch/mips/include/uapi/asm/fcntl.h#L63 for reference. > > Signed-off-by: Lena Djokic > --- > linux-user/syscall_defs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/linux-use

Re: [Qemu-devel] [PATCH v2 2/7] linux-user: Fix inotify_init1 support

2016-12-16 Thread Peter Maydell
On 24 November 2016 at 16:08, Lena Djokic wrote: > This commit adds necessary conversion of argument passed to inotify_init1. > inotify_init1 flags can be IN_NONBLOCK and IN_CLOEXEC which rely on O_NONBLOCK > and O_CLOEXEC and those can have different values on different platforms. > > Signed-off-

[Qemu-devel] [PATCH 1/2] block: m25p80: Add Quad Page Program 4byte version op

2016-12-16 Thread marcin.krzeminski
From: Marcin Krzeminski Some flash chips has additional page program opcode that takes only 4 byte address. This commit adds support for such command in Qemu. Signed-off-by: Marcin Krzeminski --- hw/block/m25p80.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/block/m25p80.c b/hw/b

[Qemu-devel] [PATCH] smbios: stop ignoring command line options for TARGET_ARM

2016-12-16 Thread Leif Lindholm
Commit c30e1565 ("smbios: implement smbios support for mach-virt") enabled automatic generation of SMBIOS tables for TARGET_ARM, and actually provides data for the "virt" machine. However, do_smbios_option() still had an #ifdef TARGET_I386, preventing any -smbios command line options from being pa

[Qemu-devel] [PATCH for-2.9 v3] qapi: add explicit null to string input and output visitors

2016-12-16 Thread Greg Kurz
This may be used for deprecated object properties that are kept for backwards compatibility. Signed-off-by: Greg Kurz --- v3: - input visitor to error out if !siv->string v2: - input visitor to reject non-empty strings --- qapi/string-input-visitor.c | 11 +++ qapi/string-output-visi

Re: [Qemu-devel] [PATCH] smbios: stop ignoring command line options for TARGET_ARM

2016-12-16 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH] smbios: stop ignoring command line options for TARGET_ARM Message-id: 20161216152319.12494-1-leif.lindh...@linaro.org === TEST SCRIPT BEGIN === #!/bin/bash

[Qemu-devel] Issue with librte_vhost backed virtio and device plug/unplug

2016-12-16 Thread Osman, Dahir
Hi, We are using dpdk's librte_vhost for the vhost-user backend of Virtio. If the guest's memory map changes after the virtio device was started, qemu can send the vhost-user backend a VHOST_USER_SET_MEM_TABLE message. We observed this case in the following scenarios: - We have a PCI pa

Re: [Qemu-devel] [PATCH kernel v5 0/5] Extend virtio-balloon for fast (de)inflating & fast live migration

2016-12-16 Thread Andrea Arcangeli
On Fri, Dec 16, 2016 at 01:12:21AM +, Li, Liang Z wrote: > There still exist the case if the MAX_ORDER is configured to a large value, > e.g. 36 for a system > with huge amount of memory, then there is only 28 bits left for the pfn, > which is not enough. Not related to the balloon but how w

Re: [Qemu-devel] [PATCH] virtio: fix vring->inuse recalc after migr

2016-12-16 Thread Halil Pasic
On 12/16/2016 11:25 AM, Stefan Hajnoczi wrote: > On Thu, Dec 15, 2016 at 04:43:30PM +0100, Halil Pasic wrote: >> Correct recalculation of vring->inuse after migration for >> the corner case where the avail_idx has already wrapped >> but used_idx not yet. >> >> Signed-off-by: Halil Pasic >> Fixes

Re: [Qemu-devel] [Nbd] [PATCH] Further tidy-up on block status

2016-12-16 Thread Wouter Verhelst
On Thu, Dec 15, 2016 at 05:34:48PM +, Alex Bligh wrote: > > > On 15 Dec 2016, at 16:49, Wouter Verhelst wrote: > > > >> Because the namespaces and leaf-names are already restricted to > >> non-whitespace characters. I thought having tabs, line feeds, > >> returns, em-space, en-space etc. was

Re: [Qemu-devel] [RFC PATCH v2 6/8] migration/vmstate: split up vmstate_base_addr

2016-12-16 Thread Halil Pasic
On 12/15/2016 02:29 PM, Dr. David Alan Gilbert wrote: >> +vmstate_handle_alloc(first_elem, field, opaque); >> +if (field->flags & VMS_POINTER) { >> +first_elem = *(void **)first_elem; >> +assert(first_elem); >> +} >>

[Qemu-devel] [PATCH 0/2]block: m25p80: Improve mt25qu01g chip model

2016-12-16 Thread marcin.krzeminski
From: Marcin Krzeminski This series introduce some improvememnt targeting mt25qu01g. Marcin Krzeminski (2): block: m25p80: Add Quad Page Program 4byte version op block: m25p80: Introduce Die Erase command hw/block/m25p80.c | 37 + 1 file changed, 33 inse

Re: [Qemu-devel] [PATCH kernel v5 0/5] Extend virtio-balloon for fast (de)inflating & fast live migration

2016-12-16 Thread Andrea Arcangeli
On Thu, Dec 15, 2016 at 05:40:45PM -0800, Dave Hansen wrote: > On 12/15/2016 05:38 PM, Li, Liang Z wrote: > > > > Use 52 bits for 'pfn', 12 bits for 'length', when the 12 bits is not long > > enough for the 'length' > > Set the 'length' to a special value to indicate the "actual length in next >

Re: [Qemu-devel] [PATCH for-2.9 15/17] target-i386: Define static "base" CPU model

2016-12-16 Thread Jiri Denemark
On Mon, Dec 05, 2016 at 21:57:45 -0200, Eduardo Habkost wrote: > On Mon, Dec 05, 2016 at 07:18:47PM +0100, David Hildenbrand wrote: > > Am 02.12.2016 um 22:18 schrieb Eduardo Habkost: > > > The query-cpu-model-expand QMP command needs at least one static > > > model, to allow the "static" expansion

Re: [Qemu-devel] [PATCH 0/2]block: m25p80: Improve mt25qu01g chip model

2016-12-16 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH 0/2]block: m25p80: Improve mt25qu01g chip model Message-id: 1481894862-14102-1-git-send-email-marcin.krzemin...@nokia.com === TEST SCRIPT BEGIN === #!/bin/ba

Re: [Qemu-devel] [PATCH] virtio: fix vring->inuse recalc after migr

2016-12-16 Thread Stefan Hajnoczi
On Fri, Dec 16, 2016 at 3:41 PM, Halil Pasic wrote: > On 12/16/2016 11:25 AM, Stefan Hajnoczi wrote: >> On Thu, Dec 15, 2016 at 04:43:30PM +0100, Halil Pasic wrote: >>> Correct recalculation of vring->inuse after migration for >>> the corner case where the avail_idx has already wrapped >>> but use

Re: [Qemu-devel] [PATCH 1/2] block: m25p80: Add Quad Page Program 4byte version op

2016-12-16 Thread Edgar E. Iglesias
On Fri, Dec 16, 2016 at 02:27:41PM +0100, marcin.krzemin...@nokia.com wrote: > From: Marcin Krzeminski > > Some flash chips has additional page program opcode that > takes only 4 byte address. This commit adds support > for such command in Qemu. > > Signed-off-by: Marcin Krzeminski Reviewed-by

Re: [Qemu-devel] [Qemu-arm] [PATCH 2/2] block: m25p80: Introduce Die Erase command

2016-12-16 Thread Edgar E. Iglesias
On Fri, Dec 16, 2016 at 02:27:42PM +0100, marcin.krzemin...@nokia.com wrote: > From: Marcin Krzeminski > > Big flash chips (like mt25qu01g) are consisted from dies. > Because of that some manufactures remove support for Chip > Erase giving Die Erase command instead.To avoid unnecessary > code com

[Qemu-devel] Is block_save_iterate() dead code? (was: migration: Fix return code of ram_save_iterate() )

2016-12-16 Thread Thomas Huth
On 18.11.2016 09:13, Thomas Huth wrote: > On 17.11.2016 04:45, David Gibson wrote: >> On Mon, Nov 14, 2016 at 07:34:59PM +0100, Juan Quintela wrote: >>> Thomas Huth wrote: qemu_savevm_state_iterate() expects the iterators to return 1 when they are done, and 0 if there is still something

Re: [Qemu-devel] Is block_save_iterate() dead code? (was: migration: Fix return code of ram_save_iterate() )

2016-12-16 Thread Dr. David Alan Gilbert
* Thomas Huth (th...@redhat.com) wrote: > On 18.11.2016 09:13, Thomas Huth wrote: > > On 17.11.2016 04:45, David Gibson wrote: > >> On Mon, Nov 14, 2016 at 07:34:59PM +0100, Juan Quintela wrote: > >>> Thomas Huth wrote: > qemu_savevm_state_iterate() expects the iterators to return 1 > wh

Re: [Qemu-devel] [PATCH] virtio: fix vring->inuse recalc after migr

2016-12-16 Thread Halil Pasic
On 12/16/2016 05:12 PM, Stefan Hajnoczi wrote: >> You are not the first one complaining, so the sentence is definitively >> bad. What disturbs me regarding your formulation is that we do not use >> uint16_t to represent neither the ring size nor inuse. >> >> How about "Since max ring size < UINT1

Re: [Qemu-devel] [Nbd] [PATCH] Further tidy-up on block status

2016-12-16 Thread Alex Bligh
> On 16 Dec 2016, at 15:52, Wouter Verhelst wrote: > > On Thu, Dec 15, 2016 at 05:34:48PM +, Alex Bligh wrote: >> >>> On 15 Dec 2016, at 16:49, Wouter Verhelst wrote: >>> Because the namespaces and leaf-names are already restricted to non-whitespace characters. I thought having

Re: [Qemu-devel] [PATCH v2 1/7] linux-user: Add fanotify implementation

2016-12-16 Thread Peter Maydell
On 24 November 2016 at 16:08, Lena Djokic wrote: > This commit adds implementation of fanotify_init and fanotify_mark. > Second argument for fanotify_init needs conversion because of flags > which can be FAN_NONBLOCK and FAN_CLOEXEC which rely on O_NONBLOCK > and O_CLOEXEC and those can have diffe

Re: [Qemu-devel] [RFC PATCH 0/4] FTGMAC100 model for the Aspeed SoCs

2016-12-16 Thread Peter Maydell
On 29 November 2016 at 17:41, Cédric Le Goater wrote: > The Aspeed SoCs AST2400 and AST2500 have two FTGMAC100 ethernet > controllers. This serie proposes a model for this device and a way to > customize the bit definitions which are slightly different from the > Faraday definitions. > > The last

Re: [Qemu-devel] [RFC PATCH 0/4] FTGMAC100 model for the Aspeed SoCs

2016-12-16 Thread Cédric Le Goater
On 12/16/2016 05:48 PM, Peter Maydell wrote: > On 29 November 2016 at 17:41, Cédric Le Goater wrote: >> The Aspeed SoCs AST2400 and AST2500 have two FTGMAC100 ethernet >> controllers. This serie proposes a model for this device and a way to >> customize the bit definitions which are slightly diffe

Re: [Qemu-devel] [PATCH v1 0/2] Add Atmel I2C TPM AT97SC3204T emulated device

2016-12-16 Thread Peter Maydell
(added a couple of people to cc who might have an opinion on the i2c protocol questions below) On 29 November 2016 at 19:30, Fabio Urquiza wrote: > ### Overview ### > > The TPM passthrough feature allow a developer to test TPM functionalities, > like Measure Boot, without the need to tamper with

  1   2   >