Hi,
Your series seems to have some coding style problems. See output below for
more information:
Type: series
Subject: [Qemu-devel] [PATCH 0/2]block: m25p80: Improve mt25qu01g chip model
Message-id: 1481894862-14102-1-git-send-email-marcin.krzemin...@nokia.com
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag]
patchew/1481894862-14102-1-git-send-email-marcin.krzemin...@nokia.com ->
patchew/1481894862-14102-1-git-send-email-marcin.krzemin...@nokia.com
Switched to a new branch 'test'
44ae298 block: m25p80: Introduce Die Erase command
1c50e2e block: m25p80: Add Quad Page Program 4byte version op
=== OUTPUT BEGIN ===
Checking PATCH 1/2: block: m25p80: Add Quad Page Program 4byte version op...
Checking PATCH 2/2: block: m25p80: Introduce Die Erase command...
ERROR: spaces required around that '-' (ctx:VxV)
#63: FILE: hw/block/m25p80.c:522:
+ offset = offset & (~(len-1));
^
WARNING: line over 80 characters
#65: FILE: hw/block/m25p80.c:524:
+ qemu_log_mask(LOG_GUEST_ERROR, "M25P80: %d die erase not supported
by"
WARNING: line over 80 characters
#94: FILE: hw/block/m25p80.c:734:
+ s->ear = ( s->size > MAX_3BYTES_SIZE ? s->size / MAX_3BYTES_SIZE -
1 : 0);
ERROR: space prohibited after that open parenthesis '('
#94: FILE: hw/block/m25p80.c:734:
+ s->ear = ( s->size > MAX_3BYTES_SIZE ? s->size / MAX_3BYTES_SIZE -
1 : 0);
ERROR: braces {} are necessary for all arms of this statement
#99: FILE: hw/block/m25p80.c:739:
+ if (s->pi->id[4] & BIT(6))
[...]
+ else
[...]
total: 3 errors, 2 warnings, 93 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@freelists.org
