Re: [Qemu-devel] [PATCH v7 3/5] IOMMU: enable intel_iommu map and unmap notifiers

2016-11-29 Thread Aviv B.D.
On Tue, Nov 29, 2016 at 5:23 AM 蓝天宇 wrote: > 2016-11-28 23:51 GMT+08:00 Aviv B.D : > > From: "Aviv Ben-David" > > > > Adds a list of registered vtd_as's to intel iommu state to save > > iteration over each PCI device in a search of the corrosponding domain. > > > > Signed-off-by: Aviv Ben-David

Re: [Qemu-devel] [dpdk-dev] dpdk/vpp and cross-version migration for vhost

2016-11-29 Thread Maxime Coquelin
On 11/28/2016 11:18 PM, Thomas Monjalon wrote: 2016-11-28 16:28, Maxime Coquelin: On 11/24/2016 04:24 PM, Kavanagh, Mark B wrote: DPDK v16.04 added support for vHost User TSO; as such, by default, TSO is advertised to guest devices as an available feature during feature negotiation with QEMU.

Re: [Qemu-devel] Linux kernel polling for QEMU

2016-11-29 Thread Christian Borntraeger
On 11/24/2016 04:12 PM, Stefan Hajnoczi wrote: > I looked through the socket SO_BUSY_POLL and blk_mq poll support in > recent Linux kernels with an eye towards integrating the ongoing QEMU > polling work. The main missing feature is eventfd polling support which > I describe below. > > Background

Re: [Qemu-devel] [PATCH v2 for-2.8 0/4] Fix MacOS runtime failure of qobject_from_jsonf()

2016-11-29 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH v2 for-2.8 0/4] Fix MacOS runtime failure of qobject_from_jsonf() Type: series Message-id: 14799

Re: [Qemu-devel] [PATCH v3] crypto: add virtio-crypto driver

2016-11-29 Thread Gonglei (Arei)
Hi, > > > > +source "drivers/crypto/virtio/Kconfig" > > > > + > > > > endif # CRYPTO_HW > > > > diff --git a/drivers/crypto/Makefile b/drivers/crypto/Makefile > > > > index ad7250f..bc53cb8 100644 > > > > --- a/drivers/crypto/Makefile > > > > +++ b/drivers/crypto/Makefile > > > > @@ -32,3 +32,4 @

Re: [Qemu-devel] [PATCH v2 0/5] SLIRP VMStatification [ for 2.9 ]

2016-11-29 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH v2 0/5] SLIRP VMStatification [ for 2.9 ] Type: series Message-id: 20161123185258.771-1-dgilb...@

Re: [Qemu-devel] [PATCH] watchdog: 6300esb: add exit function

2016-11-29 Thread Richard W.M. Jones
On Mon, Nov 28, 2016 at 05:49:04PM -0800, Li Qiang wrote: > From: Li Qiang > > When the Intel 6300ESB watchdog is hot unplug. The timer allocated > in realize isn't freed thus leaking memory leak. This patch avoid > this through adding the exit function. I will just note that the real hardware i

[Qemu-devel] [PATCH] ui: drop unused MOUSE_EVENT_WHEEL{UP, DN} defines

2016-11-29 Thread Gerd Hoffmann
Also update comment to make clear this is for legacy mouse emulation only. Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/include/ui/console.h b/include/ui/console.h index e2589e2..718e5cb 100644 --- a/include/ui/cons

Re: [Qemu-devel] [PATCH] watchdog: 6300esb: add exit function

2016-11-29 Thread Li Qiang
Hi 2016-11-29 16:39 GMT+08:00 Richard W.M. Jones : > On Mon, Nov 28, 2016 at 05:49:04PM -0800, Li Qiang wrote: > > From: Li Qiang > > > > When the Intel 6300ESB watchdog is hot unplug. The timer allocated > > in realize isn't freed thus leaking memory leak. This patch avoid > > this through addi

Re: [Qemu-devel] [PATCH] watchdog: 6300esb: add exit function

2016-11-29 Thread Richard W.M. Jones
On Tue, Nov 29, 2016 at 04:56:55PM +0800, Li Qiang wrote: > Hi > > 2016-11-29 16:39 GMT+08:00 Richard W.M. Jones : > > > On Mon, Nov 28, 2016 at 05:49:04PM -0800, Li Qiang wrote: > > > From: Li Qiang > > > > > > When the Intel 6300ESB watchdog is hot unplug. The timer allocated > > > in realize

Re: [Qemu-devel] [PATCH] watchdog: 6300esb: add exit function

2016-11-29 Thread Li Qiang
2016-11-29 17:00 GMT+08:00 Richard W.M. Jones : > On Tue, Nov 29, 2016 at 04:56:55PM +0800, Li Qiang wrote: > > Hi > > > > 2016-11-29 16:39 GMT+08:00 Richard W.M. Jones : > > > > > On Mon, Nov 28, 2016 at 05:49:04PM -0800, Li Qiang wrote: > > > > From: Li Qiang > > > > > > > > When the Intel 6300

[Qemu-devel] GNU ARM Eclipse QEMU: support for active graphical buttons added

2016-11-29 Thread Liviu Ionescu
For those interested in Cortex-M boards emulation: http://gnuarmeclipse.github.io/blog/2016/11/28/qemu-v2-7-0-20161128-released/ Any feedback is highly appreciated. Regards, Liviu

Re: [Qemu-devel] [Nbd] [PATCH v3] doc: Add NBD_CMD_BLOCK_STATUS extension

2016-11-29 Thread Stefan Hajnoczi
On Mon, Nov 28, 2016 at 06:33:24PM +0100, Wouter Verhelst wrote: > Hi Stefan, > > On Mon, Nov 28, 2016 at 11:19:44AM +, Stefan Hajnoczi wrote: > > On Sun, Nov 27, 2016 at 08:17:14PM +0100, Wouter Verhelst wrote: > > > Quickly: the reason I haven't merged this yes is twofold: > > > - I wasn't t

Re: [Qemu-devel] [PATCH v3] crypto: add virtio-crypto driver

2016-11-29 Thread Stefan Hajnoczi
On Tue, Nov 29, 2016 at 08:22:58AM +, Gonglei (Arei) wrote: > Hi, > > > > > > +source "drivers/crypto/virtio/Kconfig" > > > > > + > > > > > endif # CRYPTO_HW > > > > > diff --git a/drivers/crypto/Makefile b/drivers/crypto/Makefile > > > > > index ad7250f..bc53cb8 100644 > > > > > --- a/driver

Re: [Qemu-devel] [PULL 0/2] target-arm queue

2016-11-29 Thread Stefan Hajnoczi
On Mon, Nov 28, 2016 at 01:51:09PM +, Peter Maydell wrote: > target-arm queue for 2.8 rc2: just two bugfixes. > > thanks > -- PMM > > The following changes since commit 00227fefd2059464cd2f59aed29944874c630e2f: > > Update version for v2.8.0-rc1 release (2016-11-22 22:29:08 +) > > are

Re: [Qemu-devel] [PULL for-2.8 0/4] tags/xen-20161128-tag

2016-11-29 Thread Stefan Hajnoczi
On Mon, Nov 28, 2016 at 11:42:14AM -0800, Stefano Stabellini wrote: > The following changes since commit 00227fefd2059464cd2f59aed29944874c630e2f: > > Update version for v2.8.0-rc1 release (2016-11-22 22:29:08 +) > > are available in the git repository at: > > git://xenbits.xen.org/peopl

Re: [Qemu-devel] [PATCH v3] crypto: add virtio-crypto driver

2016-11-29 Thread Gonglei (Arei)
> > On Tue, Nov 29, 2016 at 08:22:58AM +, Gonglei (Arei) wrote: > > Hi, > > > > > > > > +source "drivers/crypto/virtio/Kconfig" > > > > > > + > > > > > > endif # CRYPTO_HW > > > > > > diff --git a/drivers/crypto/Makefile b/drivers/crypto/Makefile > > > > > > index ad7250f..bc53cb8 100644 > >

Re: [Qemu-devel] [PATCH v3] crypto: add virtio-crypto driver

2016-11-29 Thread Cornelia Huck
On Tue, 29 Nov 2016 09:25:49 + Stefan Hajnoczi wrote: > On Tue, Nov 29, 2016 at 08:22:58AM +, Gonglei (Arei) wrote: > > Hi, > > > > > > > > +source "drivers/crypto/virtio/Kconfig" > > > > > > + > > > > > > endif # CRYPTO_HW > > > > > > diff --git a/drivers/crypto/Makefile b/drivers/cryp

Re: [Qemu-devel] [PATCH v2 for-2.8 0/4] Fix MacOS runtime failure of qobject_from_jsonf()

2016-11-29 Thread Markus Armbruster
no-re...@patchew.org writes: > Hi, > > Your series failed automatic build test. Please find the testing commands and > their output below. If you have docker installed, you can probably reproduce > it > locally. > > Subject: [Qemu-devel] [PATCH v2 for-2.8 0/4] Fix MacOS runtime failure of > qobj

Re: [Qemu-devel] [PATCH] rules.mak: Use -r instead of -Wl, -r to fix building when PIE is default

2016-11-29 Thread Stefan Hajnoczi
On Mon, Nov 28, 2016 at 04:42:54PM +0100, Paolo Bonzini wrote: > > > On 28/11/2016 16:38, Paolo Bonzini wrote: > > > > > > On 28/11/2016 16:24, Adrian Bunk wrote: > >> On Mon, Nov 28, 2016 at 04:05:33PM +0100, Paolo Bonzini wrote: > >>> > >>> > >>> On 27/11/2016 17:28, Adrian Bunk wrote: >

Re: [Qemu-devel] [PATCH v2 5/9] quorum: Inline quorum_aio_cb()

2016-11-29 Thread Paolo Bonzini
On 22/11/2016 13:24, Kevin Wolf wrote: > + > +assert(rewrite == !!acb->rewrite_count); I think this might actually trigger if none of the rewrite coroutines yields. Paolo > +while (acb->rewrite_count) { > qemu_coroutine_yield(); > }

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v3] crypto: add virtio-crypto driver

2016-11-29 Thread Cornelia Huck
On Tue, 29 Nov 2016 01:37:44 + "Gonglei (Arei)" wrote: > > On Mon, 28 Nov 2016 20:08:23 +0800 > > Gonglei wrote: > > > > > +static int virtcrypto_update_status(struct virtio_crypto *vcrypto) > > > +{ > > > + u32 status; > > > + int err; > > > + > > > + virtio_cread(vcrypto->vdev, > > > +

Re: [Qemu-devel] [PATCH for-2.8 v2] hbitmap: Fix shifts of constants by granularity

2016-11-29 Thread Fam Zheng
On Tue, 11/15 23:47, Max Reitz wrote: > An hbitmap's granularity may be anything from 0 to 63, so when shifting > constants by its value, they should not be plain ints. > > Even having changed the types, hbitmap_serialization_granularity() still > tries to shift 64 to the right by the granularity.

Re: [Qemu-devel] [PATCH] configure: fix LTTng UST tracing backend detection

2016-11-29 Thread Stefan Hajnoczi
On Mon, Nov 28, 2016 at 10:52:17AM -0500, Francis Deslauriers wrote: > The detection program needs to be linked with -ldl to build succesfully > with recent versions of LTTng-UST. > > We also need to add -ldl to the libs required to build the LTTng-UST > backend (lttng_ust_libs). > > Signed-off-b

Re: [Qemu-devel] [PULL 0/6] More patches for QEMU 2.8-rc2

2016-11-29 Thread Stefan Hajnoczi
On Mon, Nov 28, 2016 at 11:40:31PM +0100, Paolo Bonzini wrote: > The following changes since commit 00227fefd2059464cd2f59aed29944874c630e2f: > > Update version for v2.8.0-rc1 release (2016-11-22 22:29:08 +) > > are available in the git repository at: > > git://github.com/bonzini/qemu.gi

Re: [Qemu-devel] [PATCH] blkdebug: Implement bdrv_co_preadv/pwritev/flush

2016-11-29 Thread Paolo Bonzini
On 22/11/2016 13:39, Kevin Wolf wrote: > This enables byte granularity requests for blkdebug, and at the same > time gets us rid of another user of the BDS-level AIO emulation. > > Note that unless align=512 is specified, this can behave subtly > different from the old behaviour because bdrv_co_

Re: [Qemu-devel] [PULL 0/6] More patches for QEMU 2.8-rc2

2016-11-29 Thread Stefan Hajnoczi
On Mon, Nov 28, 2016 at 11:40:31PM +0100, Paolo Bonzini wrote: > The following changes since commit 00227fefd2059464cd2f59aed29944874c630e2f: > > Update version for v2.8.0-rc1 release (2016-11-22 22:29:08 +) > > are available in the git repository at: > > git://github.com/bonzini/qemu.gi

[Qemu-devel] [PULL 1/1] configure: fix LTTng UST tracing backend detection

2016-11-29 Thread Stefan Hajnoczi
From: Francis Deslauriers The detection program needs to be linked with -ldl to build succesfully with recent versions of LTTng-UST. We also need to add -ldl to the libs required to build the LTTng-UST backend (lttng_ust_libs). Signed-off-by: Francis Deslauriers Message-id: 1480348337-24271-1-

Re: [Qemu-devel] [PATCH v2 5/9] quorum: Inline quorum_aio_cb()

2016-11-29 Thread Alberto Garcia
On Tue 29 Nov 2016 10:39:12 AM CET, Paolo Bonzini wrote: > On 22/11/2016 13:24, Kevin Wolf wrote: >> + >> +assert(rewrite == !!acb->rewrite_count); > > I think this might actually trigger if none of the rewrite coroutines > yields. I think you're right. Good catch, Paolo. Actually in the new c

[Qemu-devel] [PULL 0/1] Tracing patches

2016-11-29 Thread Stefan Hajnoczi
The following changes since commit 00227fefd2059464cd2f59aed29944874c630e2f: Update version for v2.8.0-rc1 release (2016-11-22 22:29:08 +) are available in the git repository at: git://github.com/stefanha/qemu.git tags/tracing-pull-request for you to fetch changes up to c79ed23df5090294

Re: [Qemu-devel] [Nbd] [PATCH v3] doc: Add NBD_CMD_BLOCK_STATUS extension

2016-11-29 Thread Kevin Wolf
Am 27.11.2016 um 20:17 hat Wouter Verhelst geschrieben: > > 3. Q: selecting of dirty bitmap to export > >A: several variants: > > 1: id of bitmap is in flags field of request > > pros: - simple > > cons: - it's a hack. flags field is for other uses. > >

Re: [Qemu-devel] [PULL 0/1] Tracing patches

2016-11-29 Thread Stefan Hajnoczi
On Tue, Nov 29, 2016 at 10:07:23AM +, Stefan Hajnoczi wrote: > The following changes since commit 00227fefd2059464cd2f59aed29944874c630e2f: > > Update version for v2.8.0-rc1 release (2016-11-22 22:29:08 +) > > are available in the git repository at: > > git://github.com/stefanha/qemu

Re: [Qemu-devel] Linux kernel polling for QEMU

2016-11-29 Thread Fam Zheng
On Thu, 11/24 15:12, Stefan Hajnoczi wrote: > QEMU and KVM-specific polling > - > There are a few QEMU/KVM-specific items that require polling support: > > QEMU's event loop aio_notify() mechanism wakes up the event loop from a > blocking poll(2) or epoll call. It is u

[Qemu-devel] [PATCH] audio: ac97: add exit function

2016-11-29 Thread Li Qiang
From: Li Qiang Currently the ac97 device emulation doesn't have a exit function, hot unplug this device will leak some leak. Add a exit function to avoid this. Signed-off-by: Li Qiang --- hw/audio/ac97.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/audio/ac97.c b/hw/audio/ac9

[Qemu-devel] [PULL 0/1] hbitmap fix for 2.8

2016-11-29 Thread Fam Zheng
The following changes since commit 00227fefd2059464cd2f59aed29944874c630e2f: Update version for v2.8.0-rc1 release (2016-11-22 22:29:08 +) are available in the git repository at: git://github.com/famz/qemu.git tags/for-upstream for you to fetch changes up to 6725f887acc023fc8850d62e1aae

[Qemu-devel] [PULL 1/1] hbitmap: Fix shifts of constants by granularity

2016-11-29 Thread Fam Zheng
From: Max Reitz An hbitmap's granularity may be anything from 0 to 63, so when shifting constants by its value, they should not be plain ints. Even having changed the types, hbitmap_serialization_granularity() still tries to shift 64 to the right by the granularity. This operation is undefined i

Re: [Qemu-devel] Linux kernel polling for QEMU

2016-11-29 Thread Stefan Hajnoczi
On Mon, Nov 28, 2016 at 04:41:13PM +0100, Paolo Bonzini wrote: > On 28/11/2016 16:29, Stefan Hajnoczi wrote: > > Thanks for sharing the link. I'll let you know before embarking on an > > effort to make epoll support busy_loop. > > > > At the moment I'm still evaluating whether the good results we

[Qemu-devel] [PATCH] audio: es1370: add exit function

2016-11-29 Thread Li Qiang
From: Li Qiang Currently the es1370 device emulation doesn't have a exit function, hot unplug this device will leak some leak. Add a exit function to avoid this. Signed-off-by: Li Qiang --- hw/audio/es1370.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/audio/es1370.c b/hw/aud

Re: [Qemu-devel] [PATCH] watchdog: 6300esb: add exit function

2016-11-29 Thread Markus Armbruster
Li Qiang writes: > Hi > > 2016-11-29 16:39 GMT+08:00 Richard W.M. Jones : > >> On Mon, Nov 28, 2016 at 05:49:04PM -0800, Li Qiang wrote: >> > From: Li Qiang >> > >> > When the Intel 6300ESB watchdog is hot unplug. The timer allocated >> > in realize isn't freed thus leaking memory leak. This pat

Re: [Qemu-devel] [Nbd] [PATCH v3] doc: Add NBD_CMD_BLOCK_STATUS extension

2016-11-29 Thread Wouter Verhelst
Hi, On Mon, Nov 28, 2016 at 06:33:24PM +0100, Wouter Verhelst wrote: > However, I'm arguing that if we're going to provide information about > snapshots, we should be able to properly refer to these snapshots from > within an NBD context. My previous mail suggested adding a negotiation > message t

Re: [Qemu-devel] [qemu patch V3 2/2] kvmclock: reduce kvmclock difference on migration

2016-11-29 Thread Marcelo Tosatti
On Mon, Nov 28, 2016 at 03:12:01PM -0200, Eduardo Habkost wrote: > On Mon, Nov 28, 2016 at 02:45:24PM -0200, Marcelo Tosatti wrote: > > On Mon, Nov 28, 2016 at 12:13:22PM -0200, Eduardo Habkost wrote: > > > Sorry for not noticing the following issues on the previous > > > reviews. I was only paying

Re: [Qemu-devel] Linux kernel polling for QEMU

2016-11-29 Thread Stefan Hajnoczi
On Tue, Nov 29, 2016 at 09:19:22AM +0100, Christian Borntraeger wrote: > On 11/24/2016 04:12 PM, Stefan Hajnoczi wrote: > > I looked through the socket SO_BUSY_POLL and blk_mq poll support in > > recent Linux kernels with an eye towards integrating the ongoing QEMU > > polling work. The main missi

Re: [Qemu-devel] [PATCH] watchdog: 6300esb: add exit function

2016-11-29 Thread Li Qiang
2016-11-29 18:49 GMT+08:00 Markus Armbruster : > Li Qiang writes: > > > Hi > > > > 2016-11-29 16:39 GMT+08:00 Richard W.M. Jones : > > > >> On Mon, Nov 28, 2016 at 05:49:04PM -0800, Li Qiang wrote: > >> > From: Li Qiang > >> > > >> > When the Intel 6300ESB watchdog is hot unplug. The timer alloc

Re: [Qemu-devel] Linux kernel polling for QEMU

2016-11-29 Thread Paolo Bonzini
On 29/11/2016 11:32, Fam Zheng wrote: > > The kernel change will be a new prctl operation (should it be a different > syscall to extend?) to register a new type of eventfd called "idle eventfd": > > prctl(PR_ADD_IDLE_EVENTFD, int eventfd); > prctl(PR_DEL_IDLE_EVENTFD, int eventfd); > >

[Qemu-devel] [PATCH 1/5] sheepdog: remove unused cancellation support

2016-11-29 Thread Paolo Bonzini
SheepdogAIOCB is internal to sheepdog.c, hence it is never canceled. Signed-off-by: Paolo Bonzini --- block/sheepdog.c | 52 1 file changed, 52 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index 4c9af89..0b30524 100644 --- a/

[Qemu-devel] [PATCH for-2.9 v3 0/5] Sheepdog cleanups

2016-11-29 Thread Paolo Bonzini
Cleaning up the code and removing duplication makes it simpler to later adapt it for the multiqueue work. Tested against sheepdog 1.0. I also tested taking snapshots and reverting to older snapshots, but the latter only worked with "dog vdi rollback". Neither loadvm nor qemu-img worked for me. P

[Qemu-devel] [PATCH 4/5] sheepdog: simplify inflight_aio_head management

2016-11-29 Thread Paolo Bonzini
Add to the list in add_aio_request and, indirectly, resend_aioreq. Inline free_aio_req in the caller, it does not simply undo alloc_aio_req's job. Signed-off-by: Paolo Bonzini --- block/sheepdog.c | 23 ++- 1 file changed, 6 insertions(+), 17 deletions(-) diff --git a/block

[Qemu-devel] [PATCH 1/5] sheepdog: remove unused cancellation support

2016-11-29 Thread Paolo Bonzini
SheepdogAIOCB is internal to sheepdog.c, hence it is never canceled. Signed-off-by: Paolo Bonzini --- block/sheepdog.c | 52 1 file changed, 52 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index 4c9af89..0b30524 100644 --- a/

[Qemu-devel] [PATCH 5/5] sheepdog: reorganize check for overlapping requests

2016-11-29 Thread Paolo Bonzini
Wrap the code that was copied repeatedly in the two functions, sd_aio_setup and sd_aio_complete. Signed-off-by: Paolo Bonzini --- block/sheepdog.c | 66 ++-- 1 file changed, 30 insertions(+), 36 deletions(-) diff --git a/block/sheepdog.c b/blo

[Qemu-devel] [PATCH 2/5] sheepdog: reorganize coroutine flow

2016-11-29 Thread Paolo Bonzini
Delimit co_recv's lifetime clearly in aio_read_response. Do a simple qemu_coroutine_enter in aio_read_response, letting sd_co_writev call sd_write_done. Handle nr_pending in the same way in sd_co_rw_vector, sd_write_done and sd_co_flush_to_disk. Remove sd_co_rw_vector's return value; just leave

[Qemu-devel] [PATCH 3/5] sheepdog: do not use BlockAIOCB

2016-11-29 Thread Paolo Bonzini
Sheepdog's AIOCB are completely internal entities for a group of requests and do not need dynamic allocation. Signed-off-by: Paolo Bonzini --- block/sheepdog.c | 99 ++-- 1 file changed, 39 insertions(+), 60 deletions(-) diff --git a/block/she

[Qemu-devel] [PATCH 2/5] sheepdog: reorganize coroutine flow

2016-11-29 Thread Paolo Bonzini
Delimit co_recv's lifetime clearly in aio_read_response. Do a simple qemu_coroutine_enter in aio_read_response, letting sd_co_writev call sd_write_done. Handle nr_pending in the same way in sd_co_rw_vector, sd_write_done and sd_co_flush_to_disk. Remove sd_co_rw_vector's return value; just leave

[Qemu-devel] [PATCH 3/5] sheepdog: do not use BlockAIOCB

2016-11-29 Thread Paolo Bonzini
Sheepdog's AIOCB are completely internal entities for a group of requests and do not need dynamic allocation. Signed-off-by: Paolo Bonzini --- block/sheepdog.c | 99 ++-- 1 file changed, 39 insertions(+), 60 deletions(-) diff --git a/block/she

Re: [Qemu-devel] [Nbd] [PATCH v3] doc: Add NBD_CMD_BLOCK_STATUS extension

2016-11-29 Thread Vladimir Sementsov-Ogievskiy
29.11.2016 13:18, Kevin Wolf wrote: Am 27.11.2016 um 20:17 hat Wouter Verhelst geschrieben: 3. Q: selecting of dirty bitmap to export A: several variants: 1: id of bitmap is in flags field of request pros: - simple cons: - it's a hack. flags field is for other us

[Qemu-devel] [PATCH 01/10] aio: rename bh_lock to list_lock

2016-11-29 Thread Paolo Bonzini
This will be used for AioHandlers too. There is going to be little or no contention, so it is better to reuse the same lock. Signed-off-by: Paolo Bonzini --- async.c | 20 ++-- include/block/aio.h | 2 +- 2 files changed, 11 insertions(+), 11 deletions(-) diff --gi

[Qemu-devel] [PATCH for-2.9 00/10] aio_context_acquire/release pushdown, part 1

2016-11-29 Thread Paolo Bonzini
This is the first step of pushing down the AioContext lock. Bottom halves are already protected by their own lock, use it also for walking_bh and for the handlers list (including walking_handlers). The (lock, walking_foo) pair is wrapped into the QemuLockCnt primitive. Paolo Paolo Bonzini (10):

[Qemu-devel] [PATCH 02/10] qemu-thread: introduce QemuLockCnt

2016-11-29 Thread Paolo Bonzini
A QemuLockCnt comprises a counter and a mutex, with primitives to increment and decrement the counter, and to take and release the mutex. It can be used to do lock-free visits to a data structure whenever mutexes would be too heavy-weight and the critical section is too long for RCU. This could b

[Qemu-devel] [PATCH for-2.9] block: get rid of bdrv_io_unplugged_begin/end

2016-11-29 Thread Paolo Bonzini
bdrv_io_plug and bdrv_io_unplug are only called (via their BlockBackend equivalents) after starting asynchronous I/O. bdrv_drain is not going to be called while they are running, because---even if a coroutine runs for some reason---it will only drain in the next iteration of the event loop through

[Qemu-devel] [PATCH 05/10] aio: tweak walking in dispatch phase

2016-11-29 Thread Paolo Bonzini
Preparing for the following patch, use QLIST_FOREACH_SAFE and modify the placement of walking_handlers increment/decrement. Signed-off-by: Paolo Bonzini --- aio-posix.c | 27 +-- aio-win32.c | 26 -- 2 files changed, 25 insertions(+), 28 deletions(

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v3] crypto: add virtio-crypto driver

2016-11-29 Thread Gonglei (Arei)
> > Subject: Re: [virtio-dev] Re: [PATCH v3] crypto: add virtio-crypto driver > > On Tue, 29 Nov 2016 01:37:44 + > "Gonglei (Arei)" wrote: > > > > On Mon, 28 Nov 2016 20:08:23 +0800 > > > Gonglei wrote: > > > > > > > +static int virtcrypto_update_status(struct virtio_crypto *vcrypto) > > >

[Qemu-devel] [PATCH 03/10] aio: make ctx->list_lock a QemuLockCnt, subsuming ctx->walking_bh

2016-11-29 Thread Paolo Bonzini
This will make it possible to walk the list of bottom halves without holding the AioContext lock---and in turn to call bottom half handlers without holding the lock. Signed-off-by: Paolo Bonzini --- async.c | 35 --- include/block/aio.h | 12 +-

[Qemu-devel] [PATCH 04/10] qemu-thread: optimize QemuLockCnt with futexes on Linux

2016-11-29 Thread Paolo Bonzini
This is complex, but I think it is reasonably documented in the source. Signed-off-by: Paolo Bonzini --- docs/lockcnt.txt | 9 +- include/qemu/futex.h | 36 ++ include/qemu/thread.h| 2 + util/lockcnt.c | 282 +++ uti

Re: [Qemu-devel] [PATCH v3] crypto: add virtio-crypto driver

2016-11-29 Thread Gonglei (Arei)
> > > On Tue, Nov 29, 2016 at 08:22:58AM +, Gonglei (Arei) wrote: > > > Hi, > > > > > > > > > > +source "drivers/crypto/virtio/Kconfig" > > > > > > > + > > > > > > > endif # CRYPTO_HW > > > > > > > diff --git a/drivers/crypto/Makefile b/drivers/crypto/Makefile > > > > > > > index ad7250f..bc5

[Qemu-devel] [PATCH 08/10] aio: document locking

2016-11-29 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- docs/multiple-iothreads.txt | 5 ++--- include/block/aio.h | 32 2 files changed, 18 insertions(+), 19 deletions(-) diff --git a/docs/multiple-iothreads.txt b/docs/multiple-iothreads.txt index 0e7cdb2..a03f887 100644 ---

Re: [Qemu-devel] Linux kernel polling for QEMU

2016-11-29 Thread Christian Borntraeger
On 11/29/2016 12:00 PM, Stefan Hajnoczi wrote: > On Tue, Nov 29, 2016 at 09:19:22AM +0100, Christian Borntraeger wrote: >> On 11/24/2016 04:12 PM, Stefan Hajnoczi wrote: >>> I looked through the socket SO_BUSY_POLL and blk_mq poll support in >>> recent Linux kernels with an eye towards integrating

[Qemu-devel] [PATCH 06/10] aio-posix: remove walking_handlers, protecting AioHandler list with list_lock

2016-11-29 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- aio-posix.c | 51 ++- 1 file changed, 30 insertions(+), 21 deletions(-) diff --git a/aio-posix.c b/aio-posix.c index 93a50ad..c64d36d 100644 --- a/aio-posix.c +++ b/aio-posix.c @@ -16,7 +16,7 @@ #include "qemu/osde

[Qemu-devel] [PATCH for-2.9 00/10] aio_context_acquire/release pushdown, part 1

2016-11-29 Thread Paolo Bonzini
This is the first step of pushing down the AioContext lock. Bottom halves are already protected by their own lock, use it also for walking_bh and for the handlers list (including walking_handlers). The (lock, walking_foo) pair is wrapped into the QemuLockCnt primitive. Paolo Paolo Bonzini (10):

[Qemu-devel] [PATCH 07/10] aio-win32: remove walking_handlers, protecting AioHandler list with list_lock

2016-11-29 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- aio-win32.c | 82 + 1 file changed, 50 insertions(+), 32 deletions(-) diff --git a/aio-win32.c b/aio-win32.c index f27b56b..7ae2c14 100644 --- a/aio-win32.c +++ b/aio-win32.c @@ -20,6 +20,7 @@ #include

[Qemu-devel] [PATCH 10/10] async: optimize aio_bh_poll

2016-11-29 Thread Paolo Bonzini
Avoid entering the slow path of qemu_lockcnt_dec_and_lock if no bottom half has to be deleted. Signed-off-by: Paolo Bonzini --- async.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/async.c b/async.c index 95927fc..6f8184b 100644 --- a/async.c +++ b/async.c @@ -92

Re: [Qemu-devel] [PATCH] rules.mak: Use -r instead of -Wl, -r to fix building when PIE is default

2016-11-29 Thread Paolo Bonzini
On 29/11/2016 10:33, Stefan Hajnoczi wrote: > On Mon, Nov 28, 2016 at 04:42:54PM +0100, Paolo Bonzini wrote: >> >> >> On 28/11/2016 16:38, Paolo Bonzini wrote: >>> >>> >>> On 28/11/2016 16:24, Adrian Bunk wrote: On Mon, Nov 28, 2016 at 04:05:33PM +0100, Paolo Bonzini wrote: > > >

[Qemu-devel] [PATCH 09/10] aio: push aio_context_acquire/release down to dispatching

2016-11-29 Thread Paolo Bonzini
The AioContext data structures are now protected by list_lock and/or they are walked with FOREACH_RCU primitives. There is no need anymore to acquire the AioContext for the entire duration of aio_dispatch. Instead, just acquire it before and after invoking the callbacks. The next step is then to p

[Qemu-devel] [Bug 1645287] Re: Option "split" does not available for kernel_irqchip flag in qemu-system-x86_64

2016-11-29 Thread Thomas Huth
** Project changed: qemu => qemu (Ubuntu) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1645287 Title: Option "split" does not available for kernel_irqchip flag in qemu- system-x86_64 Status in

Re: [Qemu-devel] [PATCH] watchdog: 6300esb: add exit function

2016-11-29 Thread Markus Armbruster
Li Qiang writes: > 2016-11-29 18:49 GMT+08:00 Markus Armbruster : [...] >> Method exit() is deprecated, please use unrealize() in new code. >> >> [...] >> > > Hello, > > IIUC in the PCIDeviceClass definition, there is just an exit member not a > unrealize. > The DeviceClass has an unrealize membe

Re: [Qemu-devel] [qemu patch V3 2/2] kvmclock: reduce kvmclock difference on migration

2016-11-29 Thread Eduardo Habkost
On Tue, Nov 29, 2016 at 08:56:00AM -0200, Marcelo Tosatti wrote: > On Mon, Nov 28, 2016 at 03:12:01PM -0200, Eduardo Habkost wrote: > > On Mon, Nov 28, 2016 at 02:45:24PM -0200, Marcelo Tosatti wrote: > > > On Mon, Nov 28, 2016 at 12:13:22PM -0200, Eduardo Habkost wrote: > > > > Sorry for not notic

Re: [Qemu-devel] [Nbd] [PATCH v3] doc: Add NBD_CMD_BLOCK_STATUS extension

2016-11-29 Thread Vladimir Sementsov-Ogievskiy
Hi, 29.11.2016 13:50, Wouter Verhelst wrote: Hi, On Mon, Nov 28, 2016 at 06:33:24PM +0100, Wouter Verhelst wrote: However, I'm arguing that if we're going to provide information about snapshots, we should be able to properly refer to these snapshots from within an NBD context. My previous mail

[Qemu-devel] [PATCH] virtio-gpu: track and limit host memory allocations

2016-11-29 Thread Gerd Hoffmann
This patch makes virtio-gpu track host memory allocations for ressources and applies a limit (configurable 256M by default). When exceeding the limit virtio-gpu throws VIRTIO_GPU_RESP_ERR_OUT_OF_MEMORY errors (like it already does today when pixman image allocations fail). This patch covers 2d mo

[Qemu-devel] [PATCH v4 1/1] crypto: add virtio-crypto driver

2016-11-29 Thread Gonglei
This patch introduces virtio-crypto driver for Linux Kernel. The virtio crypto device is a virtual cryptography device as well as a kind of virtual hardware accelerator for virtual machines. The encryption anddecryption requests are placed in the data queue and are ultimately handled by thebackend

[Qemu-devel] [PATCH v4 0/1] virtio-crypto: add Linux driver

2016-11-29 Thread Gonglei
v4: - rework unknow status bit handler by calling virtio_break_device(). [Cornelia] - convert space to tab in Kconfig. [Stefan] - rename virtio_crypto.c to virtio_crypto_core.c and then make the moudle named virtio_crypto.ko for consistency. [Stefan] - don't call virtcrypto_dev_stop() on fai

Re: [Qemu-devel] [PATCH v3] doc: Add NBD_CMD_BLOCK_STATUS extension

2016-11-29 Thread Alex Bligh
Vladimir, I went back to April to reread the previous train of conversation then found you had helpfully summarised some if it. Comments below. Rather than comment on many of the points individual, the root of my confusion and to some extent uncomfortableness about this proposal is 'who owns the

Re: [Qemu-devel] [Nbd] [PATCH v3] doc: Add NBD_CMD_BLOCK_STATUS extension

2016-11-29 Thread Alex Bligh
> On 29 Nov 2016, at 10:50, Wouter Verhelst wrote: > > +- `NBD_OPT_ALLOC_CONTEXT` (10) > + > +Return a list of `NBD_REP_ALLOC_CONTEXT` replies, one per context, > +followed by an `NBD_REP_ACK`. If a server replies to such a request > +with no error message, clients MAY send NBD_CMD_B

Re: [Qemu-devel] [Nbd] [PATCH v3] doc: Add NBD_CMD_BLOCK_STATUS extension

2016-11-29 Thread Wouter Verhelst
Hi Vladimir, On Tue, Nov 29, 2016 at 03:41:10PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Hi, > > 29.11.2016 13:50, Wouter Verhelst wrote: > > Hi, > > On Mon, Nov 28, 2016 at 06:33:24PM +0100, Wouter Verhelst wrote: > > However, I'm arguing that if we're going to provide inf

Re: [Qemu-devel] Linux kernel polling for QEMU

2016-11-29 Thread Fam Zheng
On Tue, 11/29 12:17, Paolo Bonzini wrote: > > > On 29/11/2016 11:32, Fam Zheng wrote: > > > > The kernel change will be a new prctl operation (should it be a different > > syscall to extend?) to register a new type of eventfd called "idle eventfd": > > > > prctl(PR_ADD_IDLE_EVENTFD, int eve

Re: [Qemu-devel] [libvirt] [RFC v2 00/20] qmp: Report bus information on 'query-machines'

2016-11-29 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [libvirt] [RFC v2 00/20] qmp: Report bus information on 'query-machines' Type: series Message-id: 1480111556-32586-1-git-send-email-ehabk...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash

Re: [Qemu-devel] Linux kernel polling for QEMU

2016-11-29 Thread Paolo Bonzini
On 29/11/2016 14:24, Fam Zheng wrote: > On Tue, 11/29 12:17, Paolo Bonzini wrote: >> >> >> On 29/11/2016 11:32, Fam Zheng wrote: >>> >>> The kernel change will be a new prctl operation (should it be a different >>> syscall to extend?) to register a new type of eventfd called "idle eventfd": >>> >

Re: [Qemu-devel] [PATCH] include: Add roundup_pow_of_two helper function

2016-11-29 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] include: Add roundup_pow_of_two helper function Type: series Message-id: 1480317522-5950-1-git-send-email-yuval.sh...@oracle.com === TEST SCRIPT BEGIN === #!/bin/bash B

Re: [Qemu-devel] [PATCH 0/2] Add Atmel I2C TPM AT97SC3204T emulated device

2016-11-29 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH 0/2] Add Atmel I2C TPM AT97SC3204T emulated device Type: series Message-id: 20161123194605.94717-1-f...@cesar.org.br === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PATCH] {disas, slirp}: Replace min/max with MIN/MAX macros

2016-11-29 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] {disas, slirp}: Replace min/max with MIN/MAX macros Type: series Message-id: 1480108791-16178-1-git-send-email-yuval.sh...@oracle.com === TEST SCRIPT BEGIN === #!/bin/b

Re: [Qemu-devel] [PATCH v10 00/10] vfio-pci: pass the aer error to guest

2016-11-29 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v10 00/10] vfio-pci: pass the aer error to guest Type: series Message-id: 1480246353-10297-1-git-send-email-caoj.f...@cn.fujitsu.com === TEST SCRIPT BEGIN === #!/bin/bash

Re: [Qemu-devel] [PATCH v2 0/5] SLIRP VMStatification [ for 2.9 ]

2016-11-29 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v2 0/5] SLIRP VMStatification [ for 2.9 ] Type: series Message-id: 20161123185258.771-1-dgilb...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(g

Re: [Qemu-devel] [PATCH v4 00/64] tcg 2.9 patch queue

2016-11-29 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v4 00/64] tcg 2.9 patch queue Type: series Message-id: 1479906121-12211-1-git-send-email-...@twiddle.net === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git

Re: [Qemu-devel] [PATCH for-2.8 0/2] loader fixes

2016-11-29 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH for-2.8 0/2] loader fixes Type: series Message-id: 20161128195701.24912-1-ler...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline

Re: [Qemu-devel] [PATCH v2 5/9] quorum: Inline quorum_aio_cb()

2016-11-29 Thread Kevin Wolf
Am 29.11.2016 um 11:06 hat Alberto Garcia geschrieben: > On Tue 29 Nov 2016 10:39:12 AM CET, Paolo Bonzini wrote: > > On 22/11/2016 13:24, Kevin Wolf wrote: > >> + > >> +assert(rewrite == !!acb->rewrite_count); > > > > I think this might actually trigger if none of the rewrite coroutines > > yi

Re: [Qemu-devel] [PATCH v4 00/10] tcg mips64 and mips r6 improvements

2016-11-29 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v4 00/10] tcg mips64 and mips r6 improvements Type: series Message-id: 1480399628-14419-1-git-send-email-jinguo...@loongson.cn === TEST SCRIPT BEGIN === #!/bin/bash BASE

Re: [Qemu-devel] [PATCH v1] slirp, disas: Replace min/max with MIN/MAX macros

2016-11-29 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v1] slirp, disas: Replace min/max with MIN/MAX macros Type: series Message-id: 1480324926-24761-1-git-send-email-yuval.sh...@oracle.com === TEST SCRIPT BEGIN === #!/bin/

Re: [Qemu-devel] [RFC v2 06/20] qdev: Add 'accepted-device-types' property to BusClass

2016-11-29 Thread Cornelia Huck
On Fri, 25 Nov 2016 20:05:42 -0200 Eduardo Habkost wrote: > Each bus class will now be aware of the specific device types > that can be plugged on it. That will be useful for: > > * Runtime check for which devices types can be plugged to the > machine; > * Validation of query-machines output b

Re: [Qemu-devel] [PULL 0/1] hbitmap fix for 2.8

2016-11-29 Thread Stefan Hajnoczi
On Tue, Nov 29, 2016 at 06:34:37PM +0800, Fam Zheng wrote: > The following changes since commit 00227fefd2059464cd2f59aed29944874c630e2f: > > Update version for v2.8.0-rc1 release (2016-11-22 22:29:08 +) > > are available in the git repository at: > > git://github.com/famz/qemu.git tags/

Re: [Qemu-devel] Linux kernel polling for QEMU

2016-11-29 Thread Fam Zheng
On Tue, 11/29 14:27, Paolo Bonzini wrote: > > > On 29/11/2016 14:24, Fam Zheng wrote: > > On Tue, 11/29 12:17, Paolo Bonzini wrote: > >> > >> > >> On 29/11/2016 11:32, Fam Zheng wrote: > >>> > >>> The kernel change will be a new prctl operation (should it be a different > >>> syscall to extend?)

Re: [Qemu-devel] [RFC v2 06/20] qdev: Add 'accepted-device-types' property to BusClass

2016-11-29 Thread Eduardo Habkost
On Tue, Nov 29, 2016 at 02:57:07PM +0100, Cornelia Huck wrote: > On Fri, 25 Nov 2016 20:05:42 -0200 > Eduardo Habkost wrote: > > > Each bus class will now be aware of the specific device types > > that can be plugged on it. That will be useful for: > > > > * Runtime check for which devices types

Re: [Qemu-devel] [PATCH v3] doc: Add NBD_CMD_BLOCK_STATUS extension

2016-11-29 Thread Vladimir Sementsov-Ogievskiy
29.11.2016 15:57, Alex Bligh wrote: Vladimir, I went back to April to reread the previous train of conversation then found you had helpfully summarised some if it. Comments below. Rather than comment on many of the points individual, the root of my confusion and to some extent uncomfortableness

Re: [Qemu-devel] Linux kernel polling for QEMU

2016-11-29 Thread Willem de Bruijn
On Mon, Nov 28, 2016 at 4:31 AM, Eliezer Tamir wrote: > + Eric, Willem > > On 24/11/2016 17:12, Stefan Hajnoczi wrote: >> I looked through the socket SO_BUSY_POLL and blk_mq poll support in >> recent Linux kernels with an eye towards integrating the ongoing QEMU >> polling work. The main missing

  1   2   3   >