Hi,
Your series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH v4 00/64] tcg 2.9 patch queue
Type: series
Message-id: 1479906121-12211-1-git-send-email-...@twiddle.net
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
d9cf44b tcg/i386: Handle ctpop opcode
2135740 tcg/ppc: Handle ctpop opcode
01fe85d tcg: Use ctpop to generate ctz if needed
50c5255 qemu/host-utils.h: Reduce the operation count in the fallback ctpop
d3a1e47 target-i386: Use ctpop helper
bfb17b0 target-tilegx: Use ctpop helper
62f5c57 target-sparc: Use ctpop helper
235a776 target-s390x: Avoid a loop for popcnt
f06956a target-ppc: Use ctpop helper
a34a8e2 target-alpha: Use ctpop helper
da33f5a tcg: Add opcode for ctpop
55e9496 target-xtensa: Use clrsb helper
af0a1ac target-tricore: Use clrsb helper
f5ef084 target-arm: Use clrsb helper
30810b8 tcg: Add helpers for clrsb
3789563 tcg/i386: Rely on undefined/undocumented behaviour of BSF/BSR
d619f8b tcg/i386: Handle ctz and clz opcodes
e933f33 tcg/i386: Allow bmi2 shiftx to have non-matching operands
6ec3b09 tcg/i386: Hoist common arguments in tcg_out_op
1aeb285 tcg/i386: Fuly convert tcg_target_op_def
79d13c2 tcg/s390: Handle clz opcode
9dde0af tcg/mips: Handle clz opcode
2a5b955 tcg/arm: Handle ctz and clz opcodes
3bdff99 tcg/aarch64: Handle ctz and clz opcodes
328af62 tcg/ppc: Handle ctz and clz opcodes
e87ef0c target-i386: Use clz and ctz opcodes
d655fb7 target-arm: Use clz opcode
ececb9b target-xtensa: Use clz opcode
cd2de8a target-unicore32: Use clz opcode
a642147 target-tricore: Use clz opcode
ef908df target-tilegx: Use clz and ctz opcodes
9befbbf target-s390x: Use clz opcode
08c3fec target-ppc: Use clz and ctz opcodes
02399d7 target-openrisc: Use clz and ctz opcodes
1c3d6ee target-mips: Use clz opcode
02d3b77 target-microblaze: Use clz opcode
a529119 target-cris: Use clz opcode
b3fcec6 target-alpha: Use the ctz and clz opcodes
fec845f disas/ppc: Handle popcnt and cnttz
56b7fce disas/i386.c: Handle tzcnt
fb98cd3 tcg: Add clz and ctz opcodes
6714ebd tcg: Allow an operand to be matching or a constant
5e21b56 tcg: Pass the opcode width to target_parse_constraint
8027172 tcg: Transition flat op_defs array to a target callback
f2ca9f9 tcg: Add markup for output requires new register
edd62f8 tcg/optimize: Fold movcond 0/1 into setcond
73c88ab target-s390x: Use the new deposit and extract ops
34a03f9 target-ppc: Use the new deposit and extract ops
9ce784b target-mips: Use the new extract op
b1a7872 target-i386: Use new deposit and extract ops
af37128 target-arm: Use new deposit and extract ops
7b44604 target-alpha: Use deposit and extract ops
941d1b3 tcg/s390: Support deposit into zero
2817b7a tcg/s390: Implement field extraction opcodes
d96c84d tcg/s390: Expose host facilities to tcg-target.h
0b19a3e tcg/ppc: Implement field extraction opcodes
ee17a4a tcg/mips: Implement field extraction opcodes
1c241a4 tcg/i386: Implement field extraction opcodes
8e64b7a tcg/arm: Implement field extraction opcodes
cf7b4c2 tcg/arm: Move isa detection to tcg-target.h
2580ec1 tcg/aarch64: Implement field extraction opcodes
1d8166c tcg: Add deposit_z expander
0850885 tcg: Minor adjustments to deposit expanders
886686d tcg: Add field extraction primitives
=== OUTPUT BEGIN ===
Checking PATCH 1/64: tcg: Add field extraction primitives...
ERROR: spaces required around that ':' (ctx:VxE)
#139: FILE: tcg/optimize.c:881:
+ CASE_OP_32_64(extract):
^
ERROR: spaces required around that ':' (ctx:VxE)
#145: FILE: tcg/optimize.c:887:
+ CASE_OP_32_64(sextract):
^
ERROR: spaces required around that ':' (ctx:VxE)
#159: FILE: tcg/optimize.c:1064:
+ CASE_OP_32_64(extract):
^
ERROR: spaces required around that ':' (ctx:VxE)
#167: FILE: tcg/optimize.c:1072:
+ CASE_OP_32_64(sextract):
^
ERROR: space prohibited after that '&&' (ctx:ExW)
#271: FILE: tcg/tcg-op.c:582:
+ && TCG_TARGET_extract_i32_valid(ofs, len)) {
^
ERROR: space prohibited after that '&&' (ctx:ExW)
#334: FILE: tcg/tcg-op.c:645:
+ && TCG_TARGET_extract_i32_valid(ofs, len)) {
^
ERROR: space prohibited after that '&&' (ctx:ExW)
#420: FILE: tcg/tcg-op.c:1799:
+ && TCG_TARGET_extract_i64_valid(ofs, len)) {
^
ERROR: space prohibited after that '&&' (ctx:ExW)
#526: FILE: tcg/tcg-op.c:1905:
+ && TCG_TARGET_extract_i64_valid(ofs, len)) {
^
total: 8 errors, 0 warnings, 599 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 2/64: tcg: Minor adjustments to deposit expanders...
Checking PATCH 3/64: tcg: Add deposit_z expander...
ERROR: space prohibited after that '&&' (ctx:ExW)
#33: FILE: tcg/tcg-op.c:577:
+ && TCG_TARGET_deposit_i32_valid(ofs, len)) {
^
ERROR: space prohibited after that '&&' (ctx:ExW)
#98: FILE: tcg/tcg-op.c:1836:
+ && TCG_TARGET_deposit_i64_valid(ofs, len)) {
^
total: 2 errors, 0 warnings, 185 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 4/64: tcg/aarch64: Implement field extraction opcodes...
Checking PATCH 5/64: tcg/arm: Move isa detection to tcg-target.h...
WARNING: architecture specific defines should be avoided
#18: FILE: tcg/arm/tcg-target.h:30:
+#ifndef __ARM_ARCH
WARNING: architecture specific defines should be avoided
#19: FILE: tcg/arm/tcg-target.h:31:
+# if defined(__ARM_ARCH_7__) || defined(__ARM_ARCH_7A__) \
WARNING: architecture specific defines should be avoided
#38: FILE: tcg/arm/tcg-target.h:50:
+#if defined(__ARM_ARCH_5T__) \
total: 0 errors, 3 warnings, 107 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 6/64: tcg/arm: Implement field extraction opcodes...
Checking PATCH 7/64: tcg/i386: Implement field extraction opcodes...
Checking PATCH 8/64: tcg/mips: Implement field extraction opcodes...
Checking PATCH 9/64: tcg/ppc: Implement field extraction opcodes...
Checking PATCH 10/64: tcg/s390: Expose host facilities to tcg-target.h...
Checking PATCH 11/64: tcg/s390: Implement field extraction opcodes...
ERROR: spaces required around that ':' (ctx:VxE)
#52: FILE: tcg/s390/tcg-target.inc.c:2162:
+ OP_32_64(extract):
^
total: 1 errors, 0 warnings, 51 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 12/64: tcg/s390: Support deposit into zero...
Checking PATCH 13/64: target-alpha: Use deposit and extract ops...
Checking PATCH 14/64: target-arm: Use new deposit and extract ops...
Checking PATCH 15/64: target-i386: Use new deposit and extract ops...
Checking PATCH 16/64: target-mips: Use the new extract op...
Checking PATCH 17/64: target-ppc: Use the new deposit and extract ops...
Checking PATCH 18/64: target-s390x: Use the new deposit and extract ops...
Checking PATCH 19/64: tcg/optimize: Fold movcond 0/1 into setcond...
Checking PATCH 20/64: tcg: Add markup for output requires new register...
Checking PATCH 21/64: tcg: Transition flat op_defs array to a target callback...
Checking PATCH 22/64: tcg: Pass the opcode width to target_parse_constraint...
ERROR: space required before the open parenthesis '('
#102: FILE: tcg/i386/tcg-target.inc.c:172:
+ switch(*ct_str++) {
ERROR: space required before the open parenthesis '('
#136: FILE: tcg/ia64/tcg-target.inc.c:727:
+ switch(*ct_str++) {
ERROR: space required before the open parenthesis '('
#170: FILE: tcg/mips/tcg-target.inc.c:173:
+ switch(*ct_str++) {
total: 3 errors, 0 warnings, 289 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 23/64: tcg: Allow an operand to be matching or a constant...
ERROR: space required before the open parenthesis '('
#51: FILE: tcg/tcg.c:1260:
+ switch(*ct_str) {
total: 1 errors, 0 warnings, 76 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 24/64: tcg: Add clz and ctz opcodes...
ERROR: spaces required around that ':' (ctx:VxE)
#188: FILE: tcg/optimize.c:1077:
+ CASE_OP_32_64(clz):
^
ERROR: spaces required around that ':' (ctx:VxE)
#189: FILE: tcg/optimize.c:1078:
+ CASE_OP_32_64(ctz):
^
ERROR: space prohibited after that '&&' (ctx:ExW)
#378: FILE: tcg/tcg-op.c:1798:
+ && arg2 <= 0xffffffffu) {
^
ERROR: space prohibited after that '&&' (ctx:ExW)
#415: FILE: tcg/tcg-op.c:1835:
+ && arg2 <= 0xffffffffu) {
^
total: 4 errors, 0 warnings, 446 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 25/64: disas/i386.c: Handle tzcnt...
ERROR: Macros with complex values should be enclosed in parenthesis
#17: FILE: disas/i386.c:685:
+#define PREGRP107 NULL, { { NULL, USE_PREFIX_USER_TABLE }, { NULL, 107 } }
ERROR: space required after that ',' (ctx:VxV)
#35: FILE: disas/i386.c:1435:
+ /* b0 */ 0,0,0,0,0,0,0,0,1,0,0,0,1,1,0,0, /* bf */
^
ERROR: space required after that ',' (ctx:VxV)
#35: FILE: disas/i386.c:1435:
+ /* b0 */ 0,0,0,0,0,0,0,0,1,0,0,0,1,1,0,0, /* bf */
^
ERROR: space required after that ',' (ctx:VxV)
#35: FILE: disas/i386.c:1435:
+ /* b0 */ 0,0,0,0,0,0,0,0,1,0,0,0,1,1,0,0, /* bf */
^
ERROR: space required after that ',' (ctx:VxV)
#35: FILE: disas/i386.c:1435:
+ /* b0 */ 0,0,0,0,0,0,0,0,1,0,0,0,1,1,0,0, /* bf */
^
ERROR: space required after that ',' (ctx:VxV)
#35: FILE: disas/i386.c:1435:
+ /* b0 */ 0,0,0,0,0,0,0,0,1,0,0,0,1,1,0,0, /* bf */
^
ERROR: space required after that ',' (ctx:VxV)
#35: FILE: disas/i386.c:1435:
+ /* b0 */ 0,0,0,0,0,0,0,0,1,0,0,0,1,1,0,0, /* bf */
^
ERROR: space required after that ',' (ctx:VxV)
#35: FILE: disas/i386.c:1435:
+ /* b0 */ 0,0,0,0,0,0,0,0,1,0,0,0,1,1,0,0, /* bf */
^
ERROR: space required after that ',' (ctx:VxV)
#35: FILE: disas/i386.c:1435:
+ /* b0 */ 0,0,0,0,0,0,0,0,1,0,0,0,1,1,0,0, /* bf */
^
ERROR: space required after that ',' (ctx:VxV)
#35: FILE: disas/i386.c:1435:
+ /* b0 */ 0,0,0,0,0,0,0,0,1,0,0,0,1,1,0,0, /* bf */
^
ERROR: space required after that ',' (ctx:VxV)
#35: FILE: disas/i386.c:1435:
+ /* b0 */ 0,0,0,0,0,0,0,0,1,0,0,0,1,1,0,0, /* bf */
^
ERROR: space required after that ',' (ctx:VxV)
#35: FILE: disas/i386.c:1435:
+ /* b0 */ 0,0,0,0,0,0,0,0,1,0,0,0,1,1,0,0, /* bf */
^
ERROR: space required after that ',' (ctx:VxV)
#35: FILE: disas/i386.c:1435:
+ /* b0 */ 0,0,0,0,0,0,0,0,1,0,0,0,1,1,0,0, /* bf */
^
ERROR: space required after that ',' (ctx:VxV)
#35: FILE: disas/i386.c:1435:
+ /* b0 */ 0,0,0,0,0,0,0,0,1,0,0,0,1,1,0,0, /* bf */
^
ERROR: space required after that ',' (ctx:VxV)
#35: FILE: disas/i386.c:1435:
+ /* b0 */ 0,0,0,0,0,0,0,0,1,0,0,0,1,1,0,0, /* bf */
^
ERROR: space required after that ',' (ctx:VxV)
#35: FILE: disas/i386.c:1435:
+ /* b0 */ 0,0,0,0,0,0,0,0,1,0,0,0,1,1,0,0, /* bf */
^
ERROR: code indent should never use tabs
#45: FILE: disas/i386.c:2806:
+ { "bsfS",^I{ Gv, Ev } },$
ERROR: code indent should never use tabs
#46: FILE: disas/i386.c:2807:
+ { "tzcntS",^I{ Gv, Ev } },$
ERROR: code indent should never use tabs
#47: FILE: disas/i386.c:2808:
+ { "bsfS",^I{ Gv, Ev } },$
ERROR: code indent should never use tabs
#48: FILE: disas/i386.c:2809:
+ { "(bad)",^I{ XX } },$
total: 20 errors, 0 warnings, 36 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 26/64: disas/ppc: Handle popcnt and cnttz...
ERROR: space required after that ',' (ctx:VxV)
#27: FILE: disas/ppc.c:3595:
+{ "popcntw", X(31,378), XRB_MASK, POWER7, { RA, RS } },
^
ERROR: space required after that ',' (ctx:VxV)
#28: FILE: disas/ppc.c:3596:
+{ "popcntd", X(31,506), XRB_MASK, POWER7, { RA, RS } },
^
ERROR: space required after that ',' (ctx:VxV)
#30: FILE: disas/ppc.c:3598:
+{ "cnttzw", XRC(31,538,0), XRB_MASK, POWER9, { RA, RS } },
^
ERROR: space required after that ',' (ctx:VxV)
#30: FILE: disas/ppc.c:3598:
+{ "cnttzw", XRC(31,538,0), XRB_MASK, POWER9, { RA, RS } },
^
ERROR: space required after that ',' (ctx:VxV)
#31: FILE: disas/ppc.c:3599:
+{ "cnttzw.", XRC(31,538,1), XRB_MASK, POWER9, { RA, RS } },
^
ERROR: space required after that ',' (ctx:VxV)
#31: FILE: disas/ppc.c:3599:
+{ "cnttzw.", XRC(31,538,1), XRB_MASK, POWER9, { RA, RS } },
^
ERROR: space required after that ',' (ctx:VxV)
#32: FILE: disas/ppc.c:3600:
+{ "cnttzd", XRC(31,570,0), XRB_MASK, POWER9, { RA, RS } },
^
ERROR: space required after that ',' (ctx:VxV)
#32: FILE: disas/ppc.c:3600:
+{ "cnttzd", XRC(31,570,0), XRB_MASK, POWER9, { RA, RS } },
^
ERROR: space required after that ',' (ctx:VxV)
#33: FILE: disas/ppc.c:3601:
+{ "cnttzd.", XRC(31,570,1), XRB_MASK, POWER9, { RA, RS } },
^
ERROR: space required after that ',' (ctx:VxV)
#33: FILE: disas/ppc.c:3601:
+{ "cnttzd.", XRC(31,570,1), XRB_MASK, POWER9, { RA, RS } },
^
total: 10 errors, 0 warnings, 22 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 27/64: target-alpha: Use the ctz and clz opcodes...
Checking PATCH 28/64: target-cris: Use clz opcode...
Checking PATCH 29/64: target-microblaze: Use clz opcode...
Checking PATCH 30/64: target-mips: Use clz opcode...
Checking PATCH 31/64: target-openrisc: Use clz and ctz opcodes...
Checking PATCH 32/64: target-ppc: Use clz and ctz opcodes...
Checking PATCH 33/64: target-s390x: Use clz opcode...
Checking PATCH 34/64: target-tilegx: Use clz and ctz opcodes...
Checking PATCH 35/64: target-tricore: Use clz opcode...
Checking PATCH 36/64: target-unicore32: Use clz opcode...
Checking PATCH 37/64: target-xtensa: Use clz opcode...
Checking PATCH 38/64: target-arm: Use clz opcode...
ERROR: trailing statements should be on next line
#122: FILE: target-arm/translate.c:7040:
+ case 2: tcg_gen_clzi_i32(tmp, tmp, 32); break;
total: 1 errors, 0 warnings, 100 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 39/64: target-i386: Use clz and ctz opcodes...
Checking PATCH 40/64: tcg/ppc: Handle ctz and clz opcodes...
Checking PATCH 41/64: tcg/aarch64: Handle ctz and clz opcodes...
Checking PATCH 42/64: tcg/arm: Handle ctz and clz opcodes...
Checking PATCH 43/64: tcg/mips: Handle clz opcode...
Checking PATCH 44/64: tcg/s390: Handle clz opcode...
Checking PATCH 45/64: tcg/i386: Fuly convert tcg_target_op_def...
Checking PATCH 46/64: tcg/i386: Hoist common arguments in tcg_out_op...
Checking PATCH 47/64: tcg/i386: Allow bmi2 shiftx to have non-matching
operands...
Checking PATCH 48/64: tcg/i386: Handle ctz and clz opcodes...
ERROR: spaces required around that ':' (ctx:VxE)
#219: FILE: tcg/i386/tcg-target.inc.c:2071:
+ OP_32_64(ctz):
^
ERROR: spaces required around that ':' (ctx:VxE)
#222: FILE: tcg/i386/tcg-target.inc.c:2074:
+ OP_32_64(clz):
^
total: 2 errors, 0 warnings, 237 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 49/64: tcg/i386: Rely on undefined/undocumented behaviour of
BSF/BSR...
ERROR: spaces required around that ':' (ctx:VxW)
#50: FILE: tcg/i386/tcg-target.inc.c:1171:
+ TCGType type = rexw ? TCG_TYPE_I64: TCG_TYPE_I32;
^
total: 1 errors, 0 warnings, 65 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 50/64: tcg: Add helpers for clrsb...
Checking PATCH 51/64: target-arm: Use clrsb helper...
Checking PATCH 52/64: target-tricore: Use clrsb helper...
Checking PATCH 53/64: target-xtensa: Use clrsb helper...
Checking PATCH 54/64: tcg: Add opcode for ctpop...
ERROR: spaces required around that ':' (ctx:VxE)
#146: FILE: tcg/optimize.c:1047:
+ CASE_OP_32_64(ctpop):
^
total: 1 errors, 0 warnings, 252 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 55/64: target-alpha: Use ctpop helper...
Checking PATCH 56/64: target-ppc: Use ctpop helper...
Checking PATCH 57/64: target-s390x: Avoid a loop for popcnt...
Checking PATCH 58/64: target-sparc: Use ctpop helper...
Checking PATCH 59/64: target-tilegx: Use ctpop helper...
Checking PATCH 60/64: target-i386: Use ctpop helper...
Checking PATCH 61/64: qemu/host-utils.h: Reduce the operation count in the
fallback ctpop...
Checking PATCH 62/64: tcg: Use ctpop to generate ctz if needed...
ERROR: space prohibited after that '&&' (ctx:ExW)
#140: FILE: tcg/tcg-op.c:1886:
+ && TCG_TARGET_HAS_ctpop_i64
^
ERROR: space prohibited after that '&&' (ctx:ExW)
#141: FILE: tcg/tcg-op.c:1887:
+ && arg2 == 64) {
^
total: 2 errors, 0 warnings, 132 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 63/64: tcg/ppc: Handle ctpop opcode...
Checking PATCH 64/64: tcg/i386: Handle ctpop opcode...
ERROR: spaces required around that ':' (ctx:VxE)
#67: FILE: tcg/i386/tcg-target.inc.c:2088:
+ OP_32_64(ctpop):
^
total: 1 errors, 0 warnings, 67 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@freelists.org
