Re: [Qemu-devel] [PATCH v1 09/10] target-ppc: add vextu[bhw]lx instructions

2016-11-24 Thread Richard Henderson
On 11/24/2016 06:53 AM, Nikunj A Dadhania wrote: David Gibson writes: [ Unknown signature status ] On Wed, Nov 23, 2016 at 05:07:18PM +0530, Nikunj A Dadhania wrote: From: Avinesh Kumar vextublx: Vector Extract Unsigned Byte Left vextuhlx: Vector Extract Unsigned Halfword Left vextuwlx:

Re: [Qemu-devel] [PATCH v1 09/10] target-ppc: add vextu[bhw]lx instructions

2016-11-24 Thread Nikunj A Dadhania
Richard Henderson writes: > On 11/24/2016 06:53 AM, Nikunj A Dadhania wrote: >> David Gibson writes: >> >>> [ Unknown signature status ] >>> On Wed, Nov 23, 2016 at 05:07:18PM +0530, Nikunj A Dadhania wrote: From: Avinesh Kumar vextublx: Vector Extract Unsigned Byte Left ve

Re: [Qemu-devel] [PATCH 1/4] 9pfs: move pdus to V9fsState

2016-11-24 Thread Greg Kurz
On Mon, 21 Nov 2016 13:39:29 -0800 Stefano Stabellini wrote: > pdus are initialized and used in 9pfs common code. Move the array from > V9fsVirtioState to V9fsState. > > Signed-off-by: Stefano Stabellini > --- Reviewed-by: Greg Kurz > hw/9pfs/9p.c| 7 +++ > hw/9pfs/9p.h|

Re: [Qemu-devel] [PATCH 2/4] 9pfs: introduce transport specific callbacks

2016-11-24 Thread Greg Kurz
On Mon, 21 Nov 2016 13:39:30 -0800 Stefano Stabellini wrote: > Don't call virtio functions from 9pfs generic code, use generic function > callbacks instead. > > Signed-off-by: Stefano Stabellini > --- Just a couple of indentation and line over 80 characters nits. I'll fix them before pushing t

Re: [Qemu-devel] [PATCH v3 for-2.9 0/3] q35: add negotiable broadcast SMI

2016-11-24 Thread Laszlo Ersek
On 11/24/16 05:29, Michael S. Tsirkin wrote: > On Wed, Nov 23, 2016 at 07:38:35PM -0500, Kevin O'Connor wrote: >> As a general comment - it does seem unfortunate that we keep building >> adhoc interfaces to communicate information from firmware to QEMU. We >> have a generic mechanism (fw_cfg) for

[Qemu-devel] [PATCH for-2.8] target-m68k: fix muluw/mulsw

2016-11-24 Thread Laurent Vivier
"The multiplier and multiplicand are both word operands, and the result is a long-word operand." So compute flags on a long-word result, not on a word result. Signed-off-by: Laurent Vivier --- target-m68k/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-m68

[Qemu-devel] [Bug 1626972] Re: QEMU memfd_create fallback mechanism change for security drivers

2016-11-24 Thread Thomas Huth
Commit 0d34fbabc13 is upstream, so setting this to "Fix committed", too. ** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1626972 Title:

[Qemu-devel] Asynchronous / synchronous IO emulation

2016-11-24 Thread Dong, Eddie
Hi: Under certain situation, we have a requirement to apply the virtual DMA event in a deterministic way. Current Qemu uses asynchronous approach to emulate the virtual IO events since quite long time ago. I am wondering if we still have an option to choose the synchronous emulation sol

Re: [Qemu-devel] [dpdk-dev] dpdk/vpp and cross-version migration for vhost

2016-11-24 Thread Kevin Traynor
On 11/24/2016 06:31 AM, Yuanhan Liu wrote: > On Tue, Nov 22, 2016 at 04:53:05PM +0200, Michael S. Tsirkin wrote: You keep assuming that you have the VM started first and figure out things afterwards, but this does not work. Think about a cluster of machines. You want to start a

Re: [Qemu-devel] [RFC 00/15] qmp: Report supported device types on 'query-machines'

2016-11-24 Thread Marcel Apfelbaum
On 11/23/2016 07:35 PM, Eduardo Habkost wrote: On Wed, Nov 23, 2016 at 06:43:16PM +0200, Marcel Apfelbaum wrote: On 11/22/2016 03:11 AM, Eduardo Habkost wrote: The Problem === Currently management software has no way to find out which device types can be plugged in a machine, unless th

Re: [Qemu-devel] [PATCH] hw/pci: disable pci-bridge's shpc by default

2016-11-24 Thread Marcel Apfelbaum
On 11/24/2016 06:06 AM, David Gibson wrote: On Wed, Nov 23, 2016 at 01:08:46PM +0200, Marcel Apfelbaum wrote: On 11/22/2016 10:25 PM, Laurent Vivier wrote: On 22/11/2016 18:26, Marcel Apfelbaum wrote: On 11/18/2016 05:52 PM, Andrew Jones wrote: On Wed, Nov 16, 2016 at 07:05:25PM +0200, Marc

Re: [Qemu-devel] [PATCH for-2.8] target-m68k: fix muluw/mulsw

2016-11-24 Thread Richard Henderson
On 11/24/2016 09:40 AM, Laurent Vivier wrote: "The multiplier and multiplicand are both word operands, and the result is a long-word operand." So compute flags on a long-word result, not on a word result. Signed-off-by: Laurent Vivier --- target-m68k/translate.c | 2 +- 1 file changed, 1 inse

Re: [Qemu-devel] [PULL 00/11] ppc-for-2.8 queue 20161123

2016-11-24 Thread Stefan Hajnoczi
On Tue, Nov 22, 2016 at 07:06:11PM -0800, no-re...@patchew.org wrote: > === OUTPUT BEGIN === > Checking PATCH 1/11: tests/postcopy: Use KVM on ppc64 only if it is KVM-HV... > Checking PATCH 2/11: spapr: migration support for CAS-negotiated option > vectors... > ERROR: spaces required around that '

Re: [Qemu-devel] [PULL for-2.8] target-alpha: fix smp interrupts

2016-11-24 Thread Stefan Hajnoczi
On Wed, Nov 23, 2016 at 01:46:34PM +0100, Richard Henderson wrote: > This is such a minor typo, let's fix it for 2.8 please. > > > r~ > > The following changes since commit c36ed06e9159fa484b711dfdd27ec64d7ac3d17a: > > Merge remote-tracking branch 'mst/tags/for_upstream' into staging > (2016

Re: [Qemu-devel] [kvm-unit-tests PATCH v7 09/11] arm/arm64: add initial gicv3 support

2016-11-24 Thread Auger Eric
Hi Drew, On 23/11/2016 17:54, Andrew Jones wrote: > Reviewed-by: Alex Bennée > Reviewed-by: Eric Auger > Signed-off-by: Andrew Jones > > --- > v7: split lib/arm/gic.c into gic-v2/3.c [Eric] > v6: > - added comments [Alex] > - added stride parameter to gicv3_set_redist_base [Andre] > - redis

Re: [Qemu-devel] [kvm-unit-tests PATCH v7 10/11] arm/arm64: gicv3: add an IPI test

2016-11-24 Thread Auger Eric
Hi Drew, On 23/11/2016 17:54, Andrew Jones wrote: > Signed-off-by: Andrew Jones > > --- > v7: > - add common ipi_send_single/mask (replacing ipi_send). >Note, the arg order irq,cpu got swapped. [Eric] > - comment rewording [Eric] > - make enable_defaults a common op [Eric] > - gic_enable

Re: [Qemu-devel] [kvm-unit-tests PATCH v7 11/11] arm/arm64: gic: don't just use zero

2016-11-24 Thread Auger Eric
Hi, On 23/11/2016 17:54, Andrew Jones wrote: > Allow user to select who sends ipis and with which irq, > rather than just always sending irq=0 from cpu0. > > Signed-off-by: Andrew Jones Reviewed-by: Eric Auger Tested-by: Eric Auger Eric > > --- > v7: cleanup cmdline parsing and add compla

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-11-24 Thread Daniel P. Berrange
On Wed, Nov 23, 2016 at 02:09:50PM -0800, ashish mittal wrote: > On the topic of protocol security - > > Would it be enough for the first patch to implement only > authentication and not encryption? Yes, authentication is the only critical thing from my POV. While encryption is a nice to have, th

Re: [Qemu-devel] [for-2.8 0/4] 9p patches for 2.8 20161123

2016-11-24 Thread Stefan Hajnoczi
On Wed, Nov 23, 2016 at 05:58:14PM +0100, Greg Kurz wrote: > The following changes since commit 00227fefd2059464cd2f59aed29944874c630e2f: > > Update version for v2.8.0-rc1 release (2016-11-22 22:29:08 +) > > are available in the git repository at: > > https://github.com/gkurz/qemu.git ta

[Qemu-devel] [PATCH for-2.8] pci-assign: sync MSI/MSI-X cap and table with PCIDevice

2016-11-24 Thread Peter Xu
Since commit e1d4fb2d ("kvm-irqchip: x86: add msi route notify fn"), kvm_irqchip_add_msi_route() starts to use pci_get_msi_message() to fetch MSI info. This requires that we setup MSI related fields in PCIDevice. For most devices, that won't be a problem, as long as we are using general interfaces

Re: [Qemu-devel] [PATCH 2/3] xen: slightly simplify bufioreq handling

2016-11-24 Thread Jan Beulich
>>> On 23.11.16 at 19:13, wrote: > On Wed, 23 Nov 2016, Jan Beulich wrote: >> There's no point setting fields always receiving the same value on each >> iteration, as handle_ioreq() doesn't alter them anyway. Set state and >> count once ahead of the loop, drop the redundant clearing of >> data_is_

Re: [Qemu-devel] [for-2.8 0/4] 9p patches for 2.8 20161123

2016-11-24 Thread Greg Kurz
On Thu, 24 Nov 2016 10:19:58 + Stefan Hajnoczi wrote: > On Wed, Nov 23, 2016 at 05:58:14PM +0100, Greg Kurz wrote: > > The following changes since commit 00227fefd2059464cd2f59aed29944874c630e2f: > > > > Update version for v2.8.0-rc1 release (2016-11-22 22:29:08 +) > > > > are availab

Re: [Qemu-devel] [PATCH] blkverify: Implement bdrv_co_preadv/pwritev/flush

2016-11-24 Thread Stefan Hajnoczi
On Tue, Nov 22, 2016 at 01:42:44PM +0100, Kevin Wolf wrote: > -static BlockAIOCB *blkverify_aio_flush(BlockDriverState *bs, > - BlockCompletionFunc *cb, > - void *opaque) > +static int blkverify_co_flush(BlockDriverState *b

[Qemu-devel] [Bug 992067] Re: Windows 2008R2 very slow cold boot when >4GB memory

2016-11-24 Thread Thomas Huth
Triaging old bug tickets... QEMU 0.12/0.14/0.15 is pretty outdated nowadays. Can you still reproduce this behavior with the latest version of QEMU? If not, I think we should close this bug... -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

[Qemu-devel] [Bug 1308381] Re: illegal instructions for AArch64 ARMv8

2016-11-24 Thread Thomas Huth
Patch had been included here: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=e44a90c59697cf98 ==> Fix released ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launch

Re: [Qemu-devel] [PATCH v2 1/4] qmp-event: Avoid qobject_from_jsonf("%"PRId64)

2016-11-24 Thread Markus Armbruster
Eric Blake writes: > The qobject_from_jsonf() function implements a pseudo-printf > language for creating a QObject; however, it is hard-coded to > only parse a subset of formats understood by -Wformat, and is > not a straight synonym to bare printf(). In particular, any > use of an int64_t inte

Re: [Qemu-devel] [PATCH v2 3/4] tests: Avoid qobject_from_jsonf("%"PRId64)

2016-11-24 Thread Markus Armbruster
Eric Blake writes: > The qobject_from_jsonf() function implements a pseudo-printf > language for creating a QObject; however, it is hard-coded to > only parse a subset of formats understood by -Wformat, and is > not a straight synonym to bare printf(). In particular, any > use of an int64_t inte

Re: [Qemu-devel] [PATCH v2 for-2.8 0/4] Fix MacOS runtime failure of qobject_from_jsonf()

2016-11-24 Thread Markus Armbruster
Eric Blake writes: > programmingk...@gmail.com[*] reported a runtime failure on a > 32-bit Mac OS compilation, where "%"PRId64 expands to "%qd". > Fortunately, we had very few spots that were relying on our > pseudo-printf JSON parsing of int64_t numbers, so it was > easier to just convert caller

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-11-24 Thread Stefan Hajnoczi
On Thu, Nov 24, 2016 at 05:44:37AM +, Ketan Nilangekar wrote: > On 11/24/16, 4:07 AM, "Paolo Bonzini" wrote: > >On 23/11/2016 23:09, ashish mittal wrote: > >> On the topic of protocol security - > >> > >> Would it be enough for the first patch to implement only > >> authentication and not enc

Re: [Qemu-devel] Asynchronous / synchronous IO emulation

2016-11-24 Thread Stefan Hajnoczi
On Thu, Nov 24, 2016 at 08:44:06AM +, Dong, Eddie wrote: > Under certain situation, we have a requirement to apply the virtual > DMA event in a deterministic way. Current Qemu uses asynchronous approach to > emulate the virtual IO events since quite long time ago. I am wondering if w

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-11-24 Thread Ketan Nilangekar
On 11/24/16, 4:41 PM, "Stefan Hajnoczi" wrote: On Thu, Nov 24, 2016 at 05:44:37AM +, Ketan Nilangekar wrote: > On 11/24/16, 4:07 AM, "Paolo Bonzini" wrote: > >On 23/11/2016 23:09, ashish mittal wrote: > >> On the topic of protocol security - > >> > >> Would it be e

[Qemu-devel] [PATCH ppc-for-2.9 v2 0/2] POWER9 TCG enablements - part8

2016-11-24 Thread Nikunj A Dadhania
This series contains 6 new instructions for POWER9 ISA3.0 Vector Extract Left/Right Indexed Changelog: v1: * Rebase * Implement vextub[r,l]x using int128_rshift v0: * Change dq/ds-form decoding for primary opcode 0x3D * Rename CR Field defines, as at every place it was using bit shifts. * U

[Qemu-devel] [PATCH v2 2/2] target-ppc: add vextu[bhw]rx instructions

2016-11-24 Thread Nikunj A Dadhania
From: "Hariharan T.S" vextubrx: Vector Extract Unsigned Byte Right-Indexed VX-form vextuhrx: Vector Extract Unsigned Halfword Right-Indexed VX-form vextuwrx: Vector Extract Unsigned Word Right-Indexed VX-form Signed-off-by: Hariharan T.S. Signed-off-by: Avinesh Kumar [ Implement using int128_

[Qemu-devel] [PATCH v2 1/2] target-ppc: add vextu[bhw]lx instructions

2016-11-24 Thread Nikunj A Dadhania
From: Avinesh Kumar vextublx: Vector Extract Unsigned Byte Left vextuhlx: Vector Extract Unsigned Halfword Left vextuwlx: Vector Extract Unsigned Word Left Signed-off-by: Avinesh Kumar [ implement using int128_rshift ] Signed-off-by: Nikunj A Dadhania --- target-ppc/helper.h

Re: [Qemu-devel] [PATCH v1 05/18] tests/test-rbcache: add test cases

2016-11-24 Thread Kevin Wolf
Am 15.11.2016 um 07:37 hat Pavel Butsykin geschrieben: > Signed-off-by: Pavel Butsykin > --- > tests/Makefile.include | 3 + > tests/test-rbcache.c | 308 > + > 2 files changed, 311 insertions(+) > create mode 100644 tests/test-rbcache.c > >

[Qemu-devel] [PATCH 0/2] fix memory leak in virtio_gpu_resource_destroy

2016-11-24 Thread Li Qiang
If the guest destroy the resource before detach banking, the 'iov' and 'addrs' field in resource is not freed thus leading memory leak issue. This patchset address this. Li Qiang (2): virtio-gpu: add declaration for virtio_gpu_cleanup_mapping function virtio-gpu: call cleanup mapping function

[Qemu-devel] [PATCH 2/2] virtio-gpu: call cleanup mapping function in resource destroy

2016-11-24 Thread Li Qiang
If the guest destroy the resource before detach banking, the 'iov' and 'addrs' field in resource is not freed thus leading memory leak issue. This patch avoid this. Signed-off-by: Li Qiang --- hw/display/virtio-gpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/display/virtio-gpu.c b/h

[Qemu-devel] [PATCH 1/2] virtio-gpu: add declaration for virtio_gpu_cleanup_mapping function

2016-11-24 Thread Li Qiang
The virtio_gpu_resource_destroy function is before the definition of the cleanup mapping function and it should call this cleanup mapping function, so we should add a declaration for it. Signed-off-by: Li Qiang --- hw/display/virtio-gpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/

Re: [Qemu-devel] [PATCH for-2.8] pci-assign: sync MSI/MSI-X cap and table with PCIDevice

2016-11-24 Thread Peter Xu
CC Limin. Limin, could you please help test this patch as well to see whether it can solve your issue? This one is slightly cleaner IMHO. Thanks, On Thu, Nov 24, 2016 at 06:25:13PM +0800, Peter Xu wrote: > Since commit e1d4fb2d ("kvm-irqchip: x86: add msi route notify fn"), > kvm_irqchip_add_msi

Re: [Qemu-devel] [dpdk-dev] dpdk/vpp and cross-version migration for vhost

2016-11-24 Thread Yuanhan Liu
On Thu, Nov 24, 2016 at 09:30:49AM +, Kevin Traynor wrote: > On 11/24/2016 06:31 AM, Yuanhan Liu wrote: > > On Tue, Nov 22, 2016 at 04:53:05PM +0200, Michael S. Tsirkin wrote: > You keep assuming that you have the VM started first and > figure out things afterwards, but this does not

Re: [Qemu-devel] [PATCH v1 01/18] block/io: add bdrv_aio_{preadv, pwritev}

2016-11-24 Thread Kevin Wolf
Am 24.11.2016 um 11:58 hat Pavel Butsykin geschrieben: > On 23.11.2016 17:28, Kevin Wolf wrote: > >Am 15.11.2016 um 07:36 hat Pavel Butsykin geschrieben: > >>It's just byte-based wrappers over bdrv_co_aio_prw_vector(), which provide > >> a byte-based interface for AIO read/write. > >> > >>Signed-o

Re: [Qemu-devel] [PATCH] memory: add section range info for IOMMU notifier

2016-11-24 Thread Peter Xu
On Thu, Nov 24, 2016 at 03:04:35PM +1100, David Gibson wrote: [...] > > diff --git a/hw/vfio/common.c b/hw/vfio/common.c > > index 801578b..c3db115 100644 > > --- a/hw/vfio/common.c > > +++ b/hw/vfio/common.c > > @@ -455,6 +455,10 @@ static void vfio_listener_region_add(MemoryListener > > *liste

Re: [Qemu-devel] [dpdk-dev] dpdk/vpp and cross-version migration for vhost

2016-11-24 Thread Maxime Coquelin
On 11/24/2016 01:33 PM, Yuanhan Liu wrote: On Thu, Nov 24, 2016 at 09:30:49AM +, Kevin Traynor wrote: > On 11/24/2016 06:31 AM, Yuanhan Liu wrote: > > On Tue, Nov 22, 2016 at 04:53:05PM +0200, Michael S. Tsirkin wrote: > You keep assuming that you have the VM started first and > >>>

[Qemu-devel] [PATCH v2] memory: add section range info for IOMMU notifier

2016-11-24 Thread Peter Xu
In this patch, IOMMUNotifier.{start|end} are introduced to store section information for a specific notifier. When notification occurs, we not only check the notification type (MAP|UNMAP), but also check whether the notified iova is in the range of specific IOMMU notifier, and skip those notifiers

[Qemu-devel] [PATCH] ps2: add support for mice with extra/side buttons

2016-11-24 Thread Fabian Lesniak
This patch introduces the SIDE and EXTRA mouse buttons and implements appropriate event generation for gtk and input-linux input methods. The naming was borrowed from evdev since it is more descriptive than BUTTON4/5. Note that the guest has to switch the ps2 mouse into IMEX mode, otherwise even

[Qemu-devel] [PATCH] 9pfs: add missing coroutine_fn annotations

2016-11-24 Thread Greg Kurz
Signed-off-by: Greg Kurz --- hw/9pfs/9p.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c index aea7e9d39206..e4815a97922d 100644 --- a/hw/9pfs/9p.c +++ b/hw/9pfs/9p.c @@ -1571,7 +1571,7 @@ out_nofid: v9fs_string_free(&name); } -stati

Re: [Qemu-devel] [RFC 00/15] qmp: Report supported device types on 'query-machines'

2016-11-24 Thread Markus Armbruster
Eduardo Habkost writes: > On Wed, Nov 23, 2016 at 06:43:16PM +0200, Marcel Apfelbaum wrote: >> On 11/22/2016 03:11 AM, Eduardo Habkost wrote: >> > The Problem >> > === >> > >> > Currently management software has no way to find out which device >> > types can be plugged in a machine, unle

Re: [Qemu-devel] -nodefaults and available buses (was Re: [RFC 00/15] qmp: Report supported device types on 'query-machines')

2016-11-24 Thread Markus Armbruster
Eduardo Habkost writes: > (CCing the maintainers of the machines that crash when using > -nodefaults) > > On Tue, Nov 22, 2016 at 08:34:50PM -0200, Eduardo Habkost wrote: > [...] >> "default defaults" vs "-nodefault defaults" >> --- >> >> Two bad news: >>

Re: [Qemu-devel] [kvm-unit-tests PATCH v7 09/11] arm/arm64: add initial gicv3 support

2016-11-24 Thread Andrew Jones
On Thu, Nov 24, 2016 at 10:54:35AM +0100, Auger Eric wrote: > Hi Drew, > > On 23/11/2016 17:54, Andrew Jones wrote: > > Reviewed-by: Alex Bennée > > Reviewed-by: Eric Auger > > Signed-off-by: Andrew Jones > > > > --- > > v7: split lib/arm/gic.c into gic-v2/3.c [Eric] > > v6: > > - added comme

Re: [Qemu-devel] [kvm-unit-tests PATCH v7 10/11] arm/arm64: gicv3: add an IPI test

2016-11-24 Thread Andrew Jones
On Thu, Nov 24, 2016 at 10:54:55AM +0100, Auger Eric wrote: > Hi Drew, > > On 23/11/2016 17:54, Andrew Jones wrote: > > Signed-off-by: Andrew Jones > > > > --- > > v7: > > - add common ipi_send_single/mask (replacing ipi_send). > >Note, the arg order irq,cpu got swapped. [Eric] > > - comme

Re: [Qemu-devel] [kvm-unit-tests PATCH v7 11/11] arm/arm64: gic: don't just use zero

2016-11-24 Thread Andrew Jones
On Thu, Nov 24, 2016 at 10:57:01AM +0100, Auger Eric wrote: > Hi, > > On 23/11/2016 17:54, Andrew Jones wrote: > > Allow user to select who sends ipis and with which irq, > > rather than just always sending irq=0 from cpu0. > > > > Signed-off-by: Andrew Jones > > Reviewed-by: Eric Auger > Test

Re: [Qemu-devel] [RFC 00/15] qmp: Report supported device types on 'query-machines'

2016-11-24 Thread Eduardo Habkost
On Thu, Nov 24, 2016 at 02:34:05PM +0100, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Wed, Nov 23, 2016 at 06:43:16PM +0200, Marcel Apfelbaum wrote: > >> On 11/22/2016 03:11 AM, Eduardo Habkost wrote: > >> > The Problem > >> > === > >> > > >> > Currently management softwa

Re: [Qemu-devel] [RFC 00/15] qmp: Report supported device types on 'query-machines'

2016-11-24 Thread Marcel Apfelbaum
On 11/24/2016 03:34 PM, Markus Armbruster wrote: Eduardo Habkost writes: On Wed, Nov 23, 2016 at 06:43:16PM +0200, Marcel Apfelbaum wrote: On 11/22/2016 03:11 AM, Eduardo Habkost wrote: The Problem [...] Our decision to have hybrid PCI/PCIe devices and buses breeds considerable complex

Re: [Qemu-devel] [PATCH 2/4] 9pfs: introduce transport specific callbacks

2016-11-24 Thread Greg Kurz
On Thu, 24 Nov 2016 09:31:52 +0100 Greg Kurz wrote: > On Mon, 21 Nov 2016 13:39:30 -0800 > Stefano Stabellini wrote: > > > Don't call virtio functions from 9pfs generic code, use generic function > > callbacks instead. > > > > Signed-off-by: Stefano Stabellini > > --- > > Just a couple of

Re: [Qemu-devel] [PATCH] target-arm: Add VBAR support to ARM1176 CPUs

2016-11-24 Thread Cédric Le Goater
On 09/05/2016 04:39 PM, Peter Maydell wrote: > On 23 August 2016 at 10:59, Cédric Le Goater wrote: >> ARM1176 CPUs support the Vector Base Address Register but currently, >> qemu only supports VBAR on ARMv7 CPUs. Fix this by adding a new >> feature ARM_FEATURE_VBAR which is used for ARMv7 and ARM1

Re: [Qemu-devel] [PATCH v2 1/2] target-ppc: add vextu[bhw]lx instructions

2016-11-24 Thread Richard Henderson
On 11/24/2016 12:32 PM, Nikunj A Dadhania wrote: +#if defined(HOST_WORDS_BIGENDIAN) +# if defined(CONFIG_INT128) +# define VEXTULX_DO(name, size) \ +target_ulong glue(helper_, name)(target_ulong a, ppc_avr_t *b) \ +{

Re: [Qemu-devel] [PATCH 2/4] 9pfs: introduce transport specific callbacks

2016-11-24 Thread Greg Kurz
On Thu, 24 Nov 2016 15:23:10 +0100 Greg Kurz wrote: > On Thu, 24 Nov 2016 09:31:52 +0100 > Greg Kurz wrote: > > > On Mon, 21 Nov 2016 13:39:30 -0800 > > Stefano Stabellini wrote: > > > > > Don't call virtio functions from 9pfs generic code, use generic function > > > callbacks instead. > >

Re: [Qemu-devel] [PATCH 3/4] 9pfs: use v9fs_init_qiov_from_pdu instead of v9fs_pack

2016-11-24 Thread Greg Kurz
On Mon, 21 Nov 2016 13:39:31 -0800 Stefano Stabellini wrote: > v9fs_xattr_read should not access VirtQueueElement elems directly. > Move v9fs_init_qiov_from_pdu up in the file and call > v9fs_init_qiov_from_pdu instead of v9fs_pack. > instead of ? I see v9fs_init_qiov_from_pdu() gets called bef

Re: [Qemu-devel] [PATCH v3 for-2.9 0/3] q35: add negotiable broadcast SMI

2016-11-24 Thread Igor Mammedov
On Thu, 24 Nov 2016 01:01:58 +0100 Laszlo Ersek wrote: > CC Jordan & Mike > > On 11/23/16 23:35, Paolo Bonzini wrote: > > > > > > On 18/11/2016 11:36, Laszlo Ersek wrote: > >> This is v3 of the series, with updates based on the v2 discussion: > >>

Re: [Qemu-devel] [RFC 00/15] qmp: Report supported device types on 'query-machines'

2016-11-24 Thread Markus Armbruster
Eduardo Habkost writes: > On Thu, Nov 24, 2016 at 02:34:05PM +0100, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > On Wed, Nov 23, 2016 at 06:43:16PM +0200, Marcel Apfelbaum wrote: >> >> On 11/22/2016 03:11 AM, Eduardo Habkost wrote: >> >> > The Problem >> >> > === >> >> >

Re: [Qemu-devel] [dpdk-dev] dpdk/vpp and cross-version migration for vhost

2016-11-24 Thread Kevin Traynor
On 11/24/2016 12:47 PM, Maxime Coquelin wrote: > > > On 11/24/2016 01:33 PM, Yuanhan Liu wrote: >> On Thu, Nov 24, 2016 at 09:30:49AM +, Kevin Traynor wrote: >>> > On 11/24/2016 06:31 AM, Yuanhan Liu wrote: > > On Tue, Nov 22, 2016 at 04:53:05PM +0200, Michael S. Tsirkin wrote: >>> >

[Qemu-devel] Linux kernel polling for QEMU

2016-11-24 Thread Stefan Hajnoczi
I looked through the socket SO_BUSY_POLL and blk_mq poll support in recent Linux kernels with an eye towards integrating the ongoing QEMU polling work. The main missing feature is eventfd polling support which I describe below. Background -- We're experimenting with polling in QEMU so I w

Re: [Qemu-devel] [for-2.8 0/4] 9p patches for 2.8 20161123

2016-11-24 Thread Stefan Hajnoczi
On Thu, Nov 24, 2016 at 11:36:29AM +0100, Greg Kurz wrote: > On Thu, 24 Nov 2016 10:19:58 + > Stefan Hajnoczi wrote: > > On Wed, Nov 23, 2016 at 05:58:14PM +0100, Greg Kurz wrote: > > Your PGP key has only one signature. Can you key sign with other > > IBMers? That may allow us to get the We

[Qemu-devel] [PULL 0/3] M68k for 2.8 patches

2016-11-24 Thread Laurent Vivier
The following changes since commit 00227fefd2059464cd2f59aed29944874c630e2f: Update version for v2.8.0-rc1 release (2016-11-22 22:29:08 +) are available in the git repository at: git://github.com/vivier/qemu-m68k.git tags/m68k-for-2.8-pull-request for you to fetch changes up to 4a18cd44

[Qemu-devel] [PULL 1/3] target-m68k: fix EXG instruction

2016-11-24 Thread Laurent Vivier
opcodes of "EXG Ax,Ay" and "EXG Dx,Dy" have been swapped Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson --- target-m68k/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target-m68k/translate.c b/target-m68k/translate.c index 9ad974f..8e522db 1006

[Qemu-devel] [PULL 2/3] target-m68k: Fix cmpa operand size

2016-11-24 Thread Laurent Vivier
"The size of the operation can be specified as word or long. Word length source operands are sign-extended to 32 bits for comparison." So comparison is always done using OS_LONG. Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson --- target-m68k/translate.c | 2 +- 1 file changed, 1

[Qemu-devel] [PULL 3/3] target-m68k: fix muluw/mulsw

2016-11-24 Thread Laurent Vivier
"The multiplier and multiplicand are both word operands, and the result is a long-word operand." So compute flags on a long-word result, not on a word result. Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson --- target-m68k/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 dele

Re: [Qemu-devel] [RFC 00/15] qmp: Report supported device types on 'query-machines'

2016-11-24 Thread Markus Armbruster
Marcel Apfelbaum writes: > On 11/24/2016 03:34 PM, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >>> On Wed, Nov 23, 2016 at 06:43:16PM +0200, Marcel Apfelbaum wrote: On 11/22/2016 03:11 AM, Eduardo Habkost wrote: > The Problem >>> > > [...] > >> Our decision to have hybrid PCI

Re: [Qemu-devel] [PATCH v1 02/18] block/pcache: empty pcache driver filter

2016-11-24 Thread Pavel Butsykin
On 23.11.2016 18:15, Kevin Wolf wrote: Am 15.11.2016 um 07:36 hat Pavel Butsykin geschrieben: The basic version of pcache driver for easy preparation of a patch set. Signed-off-by: Pavel Butsykin --- block/Makefile.objs | 1 + block/pcache.c | 144

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-11-24 Thread Stefan Hajnoczi
On Thu, Nov 24, 2016 at 11:31:14AM +, Ketan Nilangekar wrote: > > > On 11/24/16, 4:41 PM, "Stefan Hajnoczi" wrote: > > On Thu, Nov 24, 2016 at 05:44:37AM +, Ketan Nilangekar wrote: > > On 11/24/16, 4:07 AM, "Paolo Bonzini" wrote: > > >On 23/11/2016 23:09, ashish mittal wrot

[Qemu-devel] [PATCH v2 7/7] linux-user: Fix mq_open

2016-11-24 Thread Lena Djokic
If fourth argument is NULL it should be passed without using lock_user function which would, in that case, return EFAULT, and system call supports passing NULL as fourth argument. Signed-off-by: Lena Djokic --- linux-user/syscall.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-

[Qemu-devel] [PATCH v2 2/7] linux-user: Fix inotify_init1 support

2016-11-24 Thread Lena Djokic
This commit adds necessary conversion of argument passed to inotify_init1. inotify_init1 flags can be IN_NONBLOCK and IN_CLOEXEC which rely on O_NONBLOCK and O_CLOEXEC and those can have different values on different platforms. Signed-off-by: Lena Djokic --- linux-user/syscall.c | 3 ++- 1 file

[Qemu-devel] [kvm-unit-tests PATCH v7 03/11] run_tests: allow passing of options to QEMU

2016-11-24 Thread Alex Bennée
This introduces a the option -o for passing of options directly to QEMU which is useful. In my case I'm using it to toggle MTTCG on an off: ./run_tests.sh -t -o "-tcg mttcg=on" Signed-off-by: Alex Bennée --- run_tests.sh | 10 +++--- scripts/functions.bash | 13 +++-- 2

[Qemu-devel] [PATCH v2 5/7] linux-user: Fix readahead

2016-11-24 Thread Lena Djokic
Calculation of 64-bit offset was not correct for all cases. Signed-off-by: Lena Djokic --- linux-user/syscall.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 1b59a71..61c4126 100644 --- a/linux-user/syscall.c +++ b/linux-use

[Qemu-devel] [PATCH v2 0/7] Improvements of qemu linux-user

2016-11-24 Thread Lena Djokic
v2: added 6 patches This patch series contains implementation of support for two new system calls, and fixes for 5 existing system calls, and fix for a structure definition as well. Lena Djokic (7): linux-user: Add fanotify implementation linux-user: Fix inotify_init1 support linux-user: Fi

[Qemu-devel] [PATCH v2 4/7] linux-user: Fix fcnt

2016-11-24 Thread Lena Djokic
F_GETSIG and F_SETSIG were implemented with default behaviour which simply passes given arguments to fcntl syscall, but since those arguments are signals used for communication between taget and host we need conversion which is done by using host_to_target_signal and taget_to_host_signal functions.

[Qemu-devel] [kvm-unit-tests PATCH v7 10/11] arm/barrier-litmus-tests: add simple mp and sal litmus tests

2016-11-24 Thread Alex Bennée
This adds a framework for adding simple barrier litmus tests against ARM. The litmus tests aren't as comprehensive as the academic exercises which will attempt to do all sorts of things to keep racing CPUs synced up. These tests do honour the "sync" parameter to do a poor-mans equivalent. The two

Re: [Qemu-devel] [PATCH 4/4] 9pfs: add a size parameter to init_iov_from_pdu

2016-11-24 Thread Greg Kurz
On Mon, 21 Nov 2016 13:39:32 -0800 Stefano Stabellini wrote: > Not all 9pfs transports share memory between request and response. For > those who don't, it is necessary to know how much memory is required in > the response. > > Signed-off-by: Stefano Stabellini > --- IIUC the transport used in

[Qemu-devel] [PATCH v2 3/7] linux-user: Fix flock definition for mips64

2016-11-24 Thread Lena Djokic
Mips64 uses generic flock structure. See /arch/mips/include/uapi/asm/fcntl.h#L63 for reference. Signed-off-by: Lena Djokic --- linux-user/syscall_defs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h index 0b15466..099fd0

[Qemu-devel] [PATCH v2 6/7] linux-user: Fix syslog

2016-11-24 Thread Lena Djokic
Third argument represents lenght not second. If second argument is NULL it should be passed without using lock_user function which would, in that case, return EFAULT, and system call supports passing NULL as second argument. Signed-off-by: Lena Djokic --- linux-user/syscall.c | 16 --

[Qemu-devel] [kvm-unit-tests PATCH v7 08/11] arm/tlbflush-data: Add TLB flush during data writes test

2016-11-24 Thread Alex Bennée
This test is the cousin of the tlbflush-code test. Instead of flushing running code it re-maps virtual addresses while a buffer is being filled up. It then audits the results checking for writes that have ended up in the wrong place. While tlbflush-code exercises QEMU's translation invalidation lo

[Qemu-devel] [kvm-unit-tests PATCH v7 04/11] libcflat: add PRI(dux)32 format types

2016-11-24 Thread Alex Bennée
So we can have portable formatting of uint32_t types. Signed-off-by: Alex Bennée --- lib/libcflat.h | 5 + 1 file changed, 5 insertions(+) diff --git a/lib/libcflat.h b/lib/libcflat.h index bdcc561..6dab5be 100644 --- a/lib/libcflat.h +++ b/lib/libcflat.h @@ -55,12 +55,17 @@ typedef _Bool

[Qemu-devel] [PATCH v2 1/7] linux-user: Add fanotify implementation

2016-11-24 Thread Lena Djokic
This commit adds implementation of fanotify_init and fanotify_mark. Second argument for fanotify_init needs conversion because of flags which can be FAN_NONBLOCK and FAN_CLOEXEC which rely on O_NONBLOCK and O_CLOEXEC and those can have different values on different platforms. For fanotify_mark argu

[Qemu-devel] [kvm-unit-tests PATCH v7 02/11] run_tests: allow disabling of timeouts

2016-11-24 Thread Alex Bennée
Certainly during development of the tests and MTTCG there are times when the timeout just gets in the way. Signed-off-by: Alex Bennée --- run_tests.sh | 8 ++-- scripts/runtime.bash | 4 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/run_tests.sh b/run_tests.sh

[Qemu-devel] [kvm-unit-tests PATCH v7 00/11] QEMU MTTCG Test cases

2016-11-24 Thread Alex Bennée
Hi, Looking at my records it seems as though it has been a while since I last posted these tests. As I'm hoping to get the final bits of MTTCG merged upstream on the next QEMU development cycle I've been re-basing these and getting them cleaned up for merging. Some of the patches might be worth t

[Qemu-devel] [kvm-unit-tests PATCH v7 01/11] run_tests: allow forcing of acceleration mode

2016-11-24 Thread Alex Bennée
While tests can be pegged to tcg it is useful to override this from time to time, especially when testing correctness on real systems. --- run_tests.sh | 8 ++-- scripts/runtime.bash | 4 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/run_tests.sh b/run_tests.sh i

[Qemu-devel] [kvm-unit-tests PATCH v7 09/11] arm/locking-tests: add comprehensive locking test

2016-11-24 Thread Alex Bennée
This test has been written mainly to stress multi-threaded TCG behaviour but will demonstrate failure by default on real hardware. The test takes the following parameters: - "lock" use GCC's locking semantics - "atomic" use GCC's __atomic primitives - "wfelock" use WaitForEvent sleep - "ex

Re: [Qemu-devel] -nodefaults and available buses (was Re: [RFC 00/15] qmp: Report supported device types on 'query-machines')

2016-11-24 Thread Cornelia Huck
On Thu, 24 Nov 2016 12:51:19 +1100 David Gibson wrote: > On Wed, Nov 23, 2016 at 03:10:47PM -0200, Eduardo Habkost wrote: > > (CCing the maintainers of the machines that crash when using > > -nodefaults) > > > > On Tue, Nov 22, 2016 at 08:34:50PM -0200, Eduardo Habkost wrote: > > [...] > > > "de

Re: [Qemu-devel] [PATCH v2 for-2.8 0/4] Fix MacOS runtime failure of qobject_from_jsonf()

2016-11-24 Thread Eric Blake
On 11/24/2016 05:07 AM, Markus Armbruster wrote: > Eric Blake writes: > >> programmingk...@gmail.com[*] reported a runtime failure on a >> 32-bit Mac OS compilation, where "%"PRId64 expands to "%qd". >> Fortunately, we had very few spots that were relying on our >> pseudo-printf JSON parsing of i

[Qemu-devel] [kvm-unit-tests PATCH v7 06/11] arm/Makefile.common: force -fno-pic

2016-11-24 Thread Alex Bennée
As distro compilers move towards defaults for build hardening for things like ASLR we need to force -fno-pic. Failure to do can lead to weird relocation problems when we build our "lat" binaries. Signed-off-by: Alex Bennée --- arm/Makefile.common | 1 + 1 file changed, 1 insertion(+) diff --git

[Qemu-devel] [kvm-unit-tests PATCH v7 07/11] arm/tlbflush-code: Add TLB flush during code execution test

2016-11-24 Thread Alex Bennée
This adds a fairly brain dead torture test for TLB flushes intended for stressing the MTTCG QEMU build. It takes the usual -smp option for multiple CPUs. By default it CPU0 will do a TLBIALL flush after each cycle. You can pass options via -append to control additional aspects of the test: - "p

Re: [Qemu-devel] [PATCH v2 1/4] qmp-event: Avoid qobject_from_jsonf("%"PRId64)

2016-11-24 Thread Eric Blake
On 11/24/2016 05:00 AM, Markus Armbruster wrote: > Eric Blake writes: > >> +/* Put -1 to indicate failure of getting host time */ >> +obj = qobject_from_jsonf("{ 'seconds': %lld, 'microseconds': %lld }", >> + err < 0 ? -1LL : tv.tv_sec, >> +

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 1/4] target-ppc: Implement bcdcfsq. instruction

2016-11-24 Thread joserz
Hello Richard, Thank you for your review, please read my answer below. On Thu, Nov 24, 2016 at 01:43:18AM +0100, Richard Henderson wrote: > On 11/23/2016 05:21 PM, Jose Ricardo Ziviani wrote: > >bcdcfsq.: Decimal convert from signed quadword. It is not possible > >to convert values less than 10^

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 0/4] POWER9 TCG enablements - BCD functions part II

2016-11-24 Thread joserz
David, Thank you again for reviewing my code, I'm making the changes. I only have a question about patch 1/4 which I didn't find the issue so I'm waiting for Richard's answer. Thanks! On Thu, Nov 24, 2016 at 12:28:32PM +1100, David Gibson wrote: > On Wed, Nov 23, 2016 at 02:21:41PM -0200, Jos

[Qemu-devel] [kvm-unit-tests PATCH v7 11/11] arm/tcg-test: some basic TCG exercising tests

2016-11-24 Thread Alex Bennée
These tests are not really aimed at KVM at all but exist to stretch QEMU's TCG code generator. In particular these exercise the ability of the TCG to: * Chain TranslationBlocks together (tight) * Handle heavy usage of the tb_jump_cache (paged) * Pathological case of computed local jumps (com

Re: [Qemu-devel] [PATCH v1 02/18] block/pcache: empty pcache driver filter

2016-11-24 Thread Kevin Wolf
Am 24.11.2016 um 16:48 hat Pavel Butsykin geschrieben: > On 23.11.2016 18:15, Kevin Wolf wrote: > >Am 15.11.2016 um 07:36 hat Pavel Butsykin geschrieben: > >>+static QemuOptsList runtime_opts = { > >>+.name = "pcache", > >>+.head = QTAILQ_HEAD_INITIALIZER(runtime_opts.head), > >>+.desc

Re: [Qemu-devel] [RFC 00/15] qmp: Report supported device types on 'query-machines'

2016-11-24 Thread Marcel Apfelbaum
On 11/24/2016 05:41 PM, Markus Armbruster wrote: Marcel Apfelbaum writes: On 11/24/2016 03:34 PM, Markus Armbruster wrote: Eduardo Habkost writes: On Wed, Nov 23, 2016 at 06:43:16PM +0200, Marcel Apfelbaum wrote: On 11/22/2016 03:11 AM, Eduardo Habkost wrote: The Problem [...] Our

Re: [Qemu-devel] [RFC 06/15] qdev: Add device_type field to BusClass

2016-11-24 Thread Cornelia Huck
On Mon, 21 Nov 2016 23:12:04 -0200 Eduardo Habkost wrote: > diff --git a/hw/pci/pci.c b/hw/pci/pci.c > index 24fae16..74b8fef 100644 > --- a/hw/pci/pci.c > +++ b/hw/pci/pci.c > @@ -152,6 +152,7 @@ static void pci_bus_class_init(ObjectClass *klass, void > *data) > k->realize = pci_bus_real

Re: [Qemu-devel] [PATCH v3 for-2.9 0/3] q35: add negotiable broadcast SMI

2016-11-24 Thread Paolo Bonzini
> > Okay, this does plug the hole I sketched out above. This logic (the > > QEMU-specific unparking) can be done in another platform API in OVMF I > > guess (like those in SmmCpuFeaturesLib), but I wonder if we have to > > provide the infrastructure in platform code up to the separate SMI > > comm

Re: [Qemu-devel] [kvm-unit-tests PATCH v7 11/11] arm/arm64: gic: don't just use zero

2016-11-24 Thread Auger Eric
Hi Drew, On 24/11/2016 15:11, Andrew Jones wrote: > On Thu, Nov 24, 2016 at 10:57:01AM +0100, Auger Eric wrote: >> Hi, >> >> On 23/11/2016 17:54, Andrew Jones wrote: >>> Allow user to select who sends ipis and with which irq, >>> rather than just always sending irq=0 from cpu0. >>> >>> Signed-off-

  1   2   >