Re: [Qemu-devel] [PULL for-2.8 0/2] target-alpha update

2016-11-22 Thread Richard Henderson
On 11/21/2016 08:43 PM, Andreas Schwab wrote: Fetched in submodule path 'roms/qemu-palcode', but it did not contain f3c7e44c70254975df2a00af39701eafbac4d471. Direct fetching of that commit failed. That's strange. I do see the commit upstream. https://github.com/rth7680/qemu-palcode/commit/f3

Re: [Qemu-devel] [PATCH] pci: relax pci_msi_get_message()

2016-11-22 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH] pci: relax pci_msi_get_message() Type: series Message-id: 1479800932-16685-1-git-send-email-pet.

Re: [Qemu-devel] [PATCH] pci: relax pci_msi_get_message()

2016-11-22 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] pci: relax pci_msi_get_message() Type: series Message-id: 1479800932-16685-1-git-send-email-pet...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=

[Qemu-devel] [PATCH] pci: relax pci_msi_get_message()

2016-11-22 Thread Peter Xu
We are very strict in the past getting MSIs from commit d1f6af6a1 ("kvm-irqchip: simplify kvm_irqchip_add_msi_route"), assuming that MSI should be configured before hand when fetching. When we have unrecognized configurations, we panic the system. However looks like this is too strict to be working

Re: [Qemu-devel] [PATCH] pci: relax pci_msi_get_message()

2016-11-22 Thread Peter Xu
On Mon, Nov 21, 2016 at 11:52:05PM -0800, no-re...@patchew.org wrote: [...] > === OUTPUT BEGIN === > Checking PATCH 1/1: pci: relax pci_msi_get_message()... > ERROR: use memset() instead of bzero() > #47: FILE: hw/pci/pci.c:2613: > +bzero(&msg, sizeof(msg)); > > total: 1 errors, 0 warnin

[Qemu-devel] [PATCH v2] pci: relax pci_msi_get_message()

2016-11-22 Thread Peter Xu
We are very strict in the past getting MSIs from commit d1f6af6a1 ("kvm-irqchip: simplify kvm_irqchip_add_msi_route"), assuming that MSI should be configured before hand when fetching. When we have unrecognized configurations, we panic the system. However looks like this is too strict to be working

[Qemu-devel] [PATCH v2 1/2] virtio: introduce little edian functions for virtio_cread/write# family

2016-11-22 Thread Gonglei
Virtio modern devices are always little edian, let's introduce the LE functions for read/write configuration space for virtio modern devices, which avoid complaint by Sparse when we use the virtio_creaed/virtio_cwrite in VIRTIO_1 devices. Signed-off-by: Gonglei --- include/linux/virtio_config.h

[Qemu-devel] [PATCH v2 2/2] crypto: add virtio-crypto driver

2016-11-22 Thread Gonglei
This patch introduces virtio-crypto driver for Linux Kernel. The virtio crypto device is a virtual cryptography device as well as a kind of virtual hardware accelerator for virtual machines. The encryption anddecryption requests are placed in the data queue and are ultimately handled by thebackend

[Qemu-devel] [PATCH v2 0/2] virtio-crypto: add Linux driver

2016-11-22 Thread Gonglei
The virtio crypto device is a virtual cryptography device as well as a kind of virtual hardware accelerator for virtual machines. The encryption anddecryption requests are placed in the data queue and are ultimately handled by thebackend crypto accelerators. The second queue is the control queue us

Re: [Qemu-devel] [PATCHv2 5/5] spapr: Fix 2.7<->2.8 migration of PCI host bridge

2016-11-22 Thread Alexey Kardashevskiy
On 21/11/16 16:31, David Gibson wrote: > daa2369 "spapr_pci: Add a 64-bit MMIO window" subtly broke migration > from qemu-2.7 to the current version. It split the device's MMIO > window into two pieces for 32-bit and 64-bit MMIO. > > The patch included backwards compatibility code to convert the

Re: [Qemu-devel] [RFC 00/15] qmp: Report supported device types on 'query-machines'

2016-11-22 Thread David Hildenbrand
Considered alternatives === Indirect mapping (machine => bus => device) --- This RFC implements a mechanism to implement ax machine-type => supported-device-types mapping. An alternative solution I considered was to expose an indir

Re: [Qemu-devel] [PATCHv2 1/5] target-ppc: Fix CPU migration from qemu-2.6 <-> later versions

2016-11-22 Thread Alexey Kardashevskiy
On 21/11/16 16:31, David Gibson wrote: > When migration for target-ppc was converted to vmstate, several > VMSTATE_EQUAL() checks were foolishly included of things that really > should be internal state. Specifically we verified equality of the > insns_flags and insns_flags2 fields, which are used

Re: [Qemu-devel] [PATCH] slirp: support dynamic block size for TFTP transfers

2016-11-22 Thread Thomas Huth
On 21.11.2016 20:51, H. Peter Anvin wrote: > On 11/21/16 11:45, Hervé Poussineau wrote: >> The blocksize option is defined in RFC 1783. >> We now support block sizes between 1 and 1432 bytes, instead of 512 only. > > It ought to be 1476: Ethernet MTU = 1500, minus a minimum of 20 bytes > for an IP

Re: [Qemu-devel] [PATCHv2 3/5] target-ppc: Allow eventual removal of old migration mistakes

2016-11-22 Thread Alexey Kardashevskiy
On 21/11/16 16:31, David Gibson wrote: > Until very recently, the vmstate for ppc cpus included some poorly > thought out VMSTATE_EQUAL() components, that can easily break > migration compatibility, and did so between qemu-2.6 and later > versions. A hack was recently added which fixes this migrat

Re: [Qemu-devel] [PATCHv2 4/5] Revert "spapr: Fix migration of PCI host bridges from qemu-2.7"

2016-11-22 Thread Alexey Kardashevskiy
On 21/11/16 16:31, David Gibson wrote: > This reverts commit 9b54ca0ba781012eeea4237b7c4832ba2ea81d89. > > The commit above corrected a migration breakage between qemu-2.7 and > qemu-2.8. However it did so by advancing the migration version for > the PCI host bridge, which obviously breaks migrat

[Qemu-devel] [PULL 1/1] seabios: update to 1.10.1 stable release

2016-11-22 Thread Gerd Hoffmann
git shortlog rel-1.10.0..rel-1.10.1 === Igor Mammedov (1): drop "etc/boot-cpus" fw_cfg file and reuse legacy QEMU_CFG_NB_CPUS Signed-off-by: Gerd Hoffmann --- pc-bios/bios-256k.bin | Bin 262144 -> 262144 bytes pc-bios/bios.bin | Bin 131072 -

[Qemu-devel] [PULL 0/1] seabios: update to 1.10.1 stable release

2016-11-22 Thread Gerd Hoffmann
to staging (2016-11-21 11:09:58 +) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-seabios-20161122-1 for you to fetch changes up to cae41fda0f22b31f873fdc3e916f4d2580dedb09: seabios: update to 1.10.1 stable release (2016-11-22 10:1

[Qemu-devel] [PATCH] target-mips: Implement Loongson 3A processor.

2016-11-22 Thread r
From: Heiher Signed-off-by: Heiher --- target-mips/mips-defs.h | 2 + target-mips/translate.c | 449 ++- target-mips/translate_init.c | 24 +++ 3 files changed, 469 insertions(+), 6 deletions(-) diff --git a/target-mips/mips-defs.h b/target-

Re: [Qemu-devel] [PATCH 8/8] quorum: Inline quorum_fifo_aio_cb()

2016-11-22 Thread Alberto Garcia
On Mon 21 Nov 2016 09:08:06 PM CET, Eric Blake wrote: > Back to my comments earlier in the series - We may want to think about > a parallel FIFO mode, where we kick off all reads, but then are > prepared to cancel reads on later children once we have a positive > answer on an earlier child. And

Re: [Qemu-devel] [PATCH] target-mips: Implement Loongson 3A processor.

2016-11-22 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] target-mips: Implement Loongson 3A processor. Type: series Message-id: 20161122091907.13034-...@hev.cc === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git l

Re: [Qemu-devel] [Qemu-ppc] [PATCHv2 5/5] spapr: Fix 2.7<->2.8 migration of PCI host bridge

2016-11-22 Thread Greg Kurz
On Tue, 22 Nov 2016 10:15:59 +1100 David Gibson wrote: > On Mon, Nov 21, 2016 at 05:02:20PM +0100, Greg Kurz wrote: > > On Mon, 21 Nov 2016 13:02:53 +0100 > > Thomas Huth wrote: > > > > > On 21.11.2016 06:31, David Gibson wrote: > > > > daa2369 "spapr_pci: Add a 64-bit MMIO window" subtly b

[Qemu-devel] [PATCH] drm: update MAINTAINERS for qemu drivers (bochs, cirrus, qxl, virtio-gpu)

2016-11-22 Thread Gerd Hoffmann
Changes: * add myself as maintainer, so patches land in my inbox. * add qemu-devel mailing list. * add drm-qemu git repo. * flip bochs and qxl status to "Maintained". Signed-off-by: Gerd Hoffmann --- MAINTAINERS | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --gi

[Qemu-devel] [PATCH] drm: flip cirrus driver status to "obsolete".

2016-11-22 Thread Gerd Hoffmann
Also update Kconfig help text, explaining things: Cirrus is obsolete, the hardware was designed in the 90ies and can't keep up with todays needs. More background: https://www.kraxel.org/blog/2014/10/qemu-using-cirrus-considered-harmful/ Better alternatives are: - stdvga (DRM_BOCHS, qemu -vga s

Re: [Qemu-devel] qobject/qjson.c:69: failed assertion `obj != NULL'

2016-11-22 Thread Markus Armbruster
Eric Blake writes: > On 11/21/2016 02:36 PM, Eric Blake wrote: >> The source of your problem is that your platform defines PRId64 as 'qd', >> but the qemu JSON parser only recognizes lld (POSIX) or I64d (mingw) for >> parsing 64-bit numbers. We could enhance the JSON parser to recognize >> the n

Re: [Qemu-devel] [Qemu-block] [PATCH] block/mirror: enable detect zeroes when driving mirror

2016-11-22 Thread Kevin Wolf
Am 22.11.2016 um 04:45 hat wyang geschrieben: > On 2016年11月21日 19:34, Kevin Wolf wrote: > >Am 21.11.2016 um 02:24 hat Yang Wei geschrieben: > >>In order to preserve sparse disk image, detect_zeroes > >>should also be enabled when bdrv_get_block_status_above() > >>returns BDRV_BLOCK_DATA > >> > >>Si

[Qemu-devel] [Bug 1626972] Re: QEMU memfd_create fallback mechanism change for security drivers

2016-11-22 Thread Rafael David Tinoco
** Patch added: "xenial_qemu_2.5+dfsg-5ubuntu10.7.debdiff" https://bugs.launchpad.net/qemu/+bug/1626972/+attachment/4781425/+files/xenial_qemu_2.5+dfsg-5ubuntu10.7.debdiff -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bu

[Qemu-devel] [Bug 1626972] Re: QEMU memfd_create fallback mechanism change for security drivers

2016-11-22 Thread Rafael David Tinoco
Thanks Christian, Then I'll finish this SRU first. Will work in the vhost mmap log file right after. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1626972 Title: QEMU memfd_create fallback mechani

Re: [Qemu-devel] [PATCH for-2.8 1/3] migration: alternative way to set instance_id in SaveStateEntry

2016-11-22 Thread David Gibson
On Thu, Nov 17, 2016 at 07:40:25PM -0600, Michael Roth wrote: > From: Jianjun Duan > > Currently migrated Devices are identified with an idstr which is > calculated automatically using their path in the QOM composition > tree. In some cases these Devices may have a more reliable > identifier that

Re: [Qemu-devel] [PATCH for-2.8 1/3] migration: alternative way to set instance_id in SaveStateEntry

2016-11-22 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: > On Thu, Nov 17, 2016 at 07:40:25PM -0600, Michael Roth wrote: > > From: Jianjun Duan > > > > Currently migrated Devices are identified with an idstr which is > > calculated automatically using their path in the QOM composition > > tree. In som

[Qemu-devel] [Bug 902413] Re: qemu-i386-user on ARM host: wine hangs/spins when trying to run anything

2016-11-22 Thread Riku Voipio
You might want to retry wine with qemu-i386-static again now with qemu 2.7, which has a major thread/signal rework done. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/902413 Title: qemu-i386-user o

Re: [Qemu-devel] [Qemu-block] [PATCH RFC 0/7] COLO block replication supports shared disk case

2016-11-22 Thread Stefan Hajnoczi
On Thu, Oct 20, 2016 at 09:57:33PM +0800, zhanghailiang wrote: > COLO block replication doesn't support the shared disk case, > Here we try to implement it. > > Just as the scenario of non-shared disk block replication, > we are going to implement block replication from many basic > blocks that ar

Re: [Qemu-devel] [PATCH 18/25] tcg/aarch64: Handle ctz and clz opcodes

2016-11-22 Thread Alex Bennée
Richard Henderson writes: > On 11/16/2016 08:25 PM, Richard Henderson wrote: >> @@ -206,6 +206,9 @@ static int tcg_target_const_match(tcg_target_long val, >> TCGType type, >> if ((ct & TCG_CT_CONST_MONE) && val == -1) { >> return 1; >> } >> +if ((ct & TCG_CT_CONST_WSZ) &&

Re: [Qemu-devel] [v2] tftp: fake support for netascii protocol

2016-11-22 Thread Stefan Hajnoczi
On Mon, Nov 21, 2016 at 04:05:41PM +0100, Samuel Thibault wrote: > Stefan Hajnoczi, on Mon 21 Nov 2016 14:46:16 +, wrote: > > On Sun, Nov 20, 2016 at 09:41:36AM +0100, Vincent Bernat wrote: > > > From: Vincent Bernat > > > > > > Some network equipments are requesting a file using the netascii

Re: [Qemu-devel] [PATCH] drm: update MAINTAINERS for qemu drivers (bochs, cirrus, qxl, virtio-gpu)

2016-11-22 Thread Thomas Huth
On 22.11.2016 10:58, Gerd Hoffmann wrote: > Changes: > * add myself as maintainer, so patches land in my inbox. > * add qemu-devel mailing list. > * add drm-qemu git repo. > * flip bochs and qxl status to "Maintained". > > Signed-off-by: Gerd Hoffmann > --- > MAINTAINERS | 14 --

Re: [Qemu-devel] [Qemu-block] [PULL for-2.8 0/1] Block patches for 2.8

2016-11-22 Thread Stefan Hajnoczi
On Mon, Nov 21, 2016 at 05:14:58PM -0500, Jeff Cody wrote: > The following changes since commit c36ed06e9159fa484b711dfdd27ec64d7ac3d17a: > > Merge remote-tracking branch 'mst/tags/for_upstream' into staging > (2016-11-21 11:09:58 +) > > are available in the git repository at: > > https

Re: [Qemu-devel] [PATCH] Fix FreeBSD (10.x) build after 7dc9ae43

2016-11-22 Thread Stefan Hajnoczi
On Mon, Nov 21, 2016 at 08:32:45PM -0500, Ed Maste wrote: > Include sys/user.h for declaration of 'struct kinfo_proc'. > Add -lutil to qemu-ga link for kinfo_getproc. > > Signed-off-by: Ed Maste > --- > configure | 2 ++ > util/oslib-posix.c | 1 + > 2 files changed, 3 insertions(+) Th

Re: [Qemu-devel] [PULL 1/1] seabios: update to 1.10.1 stable release

2016-11-22 Thread Stefan Hajnoczi
On Tue, Nov 22, 2016 at 10:15:44AM +0100, Gerd Hoffmann wrote: > diff --git a/roms/seabios b/roms/seabios > index d7adf60..8891697 16 > --- a/roms/seabios > +++ b/roms/seabios > @@ -1 +1 @@ > -Subproject commit d7adf6044a4c772b497e97272adf97426b34a249 > +Subproject commit 8891697e3f7d8435542057

Re: [Qemu-devel] [PATCH 3/8] quorum: Implement .bdrv_co_readv/writev

2016-11-22 Thread Kevin Wolf
Am 21.11.2016 um 18:58 hat Eric Blake geschrieben: > On 11/21/2016 11:31 AM, Kevin Wolf wrote: > > This converts the quorum block driver from implementing callback-based > > interfaces for read/write to coroutine-based ones. This is the first > > step that will allow us further simplification of th

Re: [Qemu-devel] [PATCH 7/8] quorum: Implement .bdrv_co_preadv/pwritev()

2016-11-22 Thread Kevin Wolf
Am 21.11.2016 um 21:04 hat Eric Blake geschrieben: > On 11/21/2016 11:31 AM, Kevin Wolf wrote: > > This enables byte granularity requests on quorum nodes. > > > > Note that the QMP events emitted by the driver are an external API that > > we were careless enough to define as sector based. The offs

[Qemu-devel] [PATCH 2/9] target-ppc: Fix xscmpodp and xscmpudp instructions

2016-11-22 Thread Nikunj A Dadhania
From: Bharata B Rao - xscmpodp & xscmpudp are missing flags reset. - In xscmpodp, VXCC should be set only if VE is 0 for signalling NaN case and VXCC should be set by explicitly checking for quiet NaN case. - Comparison is being done only if the operands are not NaNs. However as per ISA, it s

[Qemu-devel] [PATCH ppc-for-2.9 0/9] POWER9 TCG enablements - part8

2016-11-22 Thread Nikunj A Dadhania
This series contains 18 new instructions for POWER9 ISA3.0 Vector Extract Left/Right Indexed VSX Scalar Compare Exponents VSX Scalar Compare Quad-Precision Load/Store VSX Vector Load/Store VSX Scalar Patches === 01-02: Consolidation/Fixes 03: xscmpexpdp: VSX Scal

[Qemu-devel] [PATCH 1/9] target-ppc: Consolidate instruction decode helpers

2016-11-22 Thread Nikunj A Dadhania
From: Bharata B Rao Move instruction decode helpers to target-ppc/internal.h so that some of these can be used from outside of translate.c. This movement also helps to get rid of some duplicate helpers from target-ppc/fpu_helper.c. Suggested-by: Nikunj A Dadhania Signed-off-by: Bharata B Rao S

[Qemu-devel] [PATCH 3/9] target-ppc: Add xscmpexp[dp, qp] instructions

2016-11-22 Thread Nikunj A Dadhania
From: Bharata B Rao xscmpexpdp: VSX Scalar Compare Exponents Double-Precision xscmpexpqp: VSX Scalar Compare Exponents Quad-Precision Signed-off-by: Bharata B Rao Signed-off-by: Nikunj A Dadhania --- target-ppc/fpu_helper.c | 64 + target-ppc/he

[Qemu-devel] [Bug 1626972] Re: QEMU memfd_create fallback mechanism change for security drivers

2016-11-22 Thread Rafael David Tinoco
Took some more time here because of LP: #1621269. ** Patch added: "yakkety_qemu_2.6.1+dfsg-0ubuntu5.2.debdiff" https://bugs.launchpad.net/qemu/+bug/1626972/+attachment/4781464/+files/yakkety_qemu_2.6.1+dfsg-0ubuntu5.2.debdiff -- You received this bug notification because you are a member of

[Qemu-devel] [PATCH 9/9] target-ppc: add vextu[bhw]rx instructions

2016-11-22 Thread Nikunj A Dadhania
From: "Hariharan T.S" vextubrx: Vector Extract Unsigned Byte Right-Indexed VX-form vextuhrx: Vector Extract Unsigned Halfword Right-Indexed VX-form vextuwrx: Vector Extract Unsigned Word Right-Indexed VX-form Signed-off-by: Hariharan T.S. Signed-off-by: Avinesh Kumar Signed-off-by: Nikunj A D

Re: [Qemu-devel] [RFC v2 3/3] virtio-net: Add MTU feature support

2016-11-22 Thread Maxime Coquelin
On 11/21/2016 05:48 PM, Michael S. Tsirkin wrote: > > > @@ -1695,6 +1706,7 @@ static void virtio_net_set_config_size(VirtIONet *n, uint64_t host_features) > > > { > > > int i, config_size = 0; > > > virtio_add_feature(&host_features, VIRTIO_NET_F_MAC); > > > +virtio_add_feature(

[Qemu-devel] [Bug 1626972] Re: QEMU memfd_create fallback mechanism change for security drivers

2016-11-22 Thread Rafael David Tinoco
Right now Zesty is behind Yakkety because of a Security Update. Not sure you need me to attach a debdiff for Zesty as well. Let me know. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1626972 Title:

Re: [Qemu-devel] [Bug 1626972] Re: QEMU memfd_create fallback mechanism change for security drivers

2016-11-22 Thread ChristianEhrhardt
On Tue, Nov 22, 2016 at 1:02 PM, Rafael David Tinoco < rafael.tin...@canonical.com> wrote: > Right now Zesty is behind Yakkety because of a Security Update. Not sure > you need me to attach a debdiff for Zesty as well. Let me know. > Arr - bad timing It got an upload about 5 minutes ago. So yes a

[Qemu-devel] [Bug 1626972] Re: QEMU memfd_create fallback mechanism change for security drivers

2016-11-22 Thread Rafael David Tinoco
** Description changed: - And, when libvirt starts using apparmor, and creating apparmor profiles - for every virtual machine created in the compute nodes, mitaka qemu (2.5 - - and upstream also) uses a fallback mechanism for creating shared - memory for live-migrations. This fall back mechanism,

[Qemu-devel] [PATCH v2 0/9] quorum: Implement .bdrv_co_preadv/pwritev()

2016-11-22 Thread Kevin Wolf
This is part of my work that aims to remove the bdrv_aio_*() emulation in io.c. After the series, quorum doesn't only use the preferred interfaces, but the code becomes a little easier to follow and byte granularity requests are supported. There is probably still some potential for additional clea

[Qemu-devel] [PATCH v2 6/9] quorum: Avoid bdrv_aio_writev() for rewrites

2016-11-22 Thread Kevin Wolf
Replacing it with bdrv_co_pwritev() prepares us for byte granularity requests and gets us rid of the last bdrv_aio_*() user in quorum. Signed-off-by: Kevin Wolf Reviewed-by: Alberto Garcia Reviewed-by: Eric Blake --- block/quorum.c | 46 +++--- 1 file ch

[Qemu-devel] [PATCH v2 1/9] coroutine: Introduce qemu_coroutine_enter_if_inactive()

2016-11-22 Thread Kevin Wolf
In the context of asynchronous work, if we have a worker coroutine that didn't yield, the parent coroutine cannot be reentered because it hasn't yielded yet. In this case we don't even have to reenter the parent because it will see that the work is already done and won't even yield. Signed-off-by:

[Qemu-devel] [PATCH v2 8/9] quorum: Inline quorum_fifo_aio_cb()

2016-11-22 Thread Kevin Wolf
Inlining the function removes some boilerplace code and replaces recursion by a simple loop, so the code becomes somewhat easier to understand. Signed-off-by: Kevin Wolf Reviewed-by: Alberto Garcia Reviewed-by: Eric Blake --- block/quorum.c | 42 +- 1 fi

[Qemu-devel] [PATCH v2 3/9] quorum: Implement .bdrv_co_readv/writev

2016-11-22 Thread Kevin Wolf
This converts the quorum block driver from implementing callback-based interfaces for read/write to coroutine-based ones. This is the first step that will allow us further simplification of the code. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Reviewed-by: Alberto Garcia --- block/quorum

[Qemu-devel] [PATCH v2 9/9] quorum: Clean up quorum_aio_get()

2016-11-22 Thread Kevin Wolf
Make sure that all fields of the new QuorumAIOCB are zeroed when the function returns even without explicitly setting them. This will protect us when new fields are added, removes some explicit zero assignment and makes the code a little nicer to read. Suggested-by: Eric Blake Signed-off-by: Kevi

[Qemu-devel] [PATCH v2 2/9] quorum: Remove s from quorum_aio_get() arguments

2016-11-22 Thread Kevin Wolf
There is no point in passing the value of bs->opaque in order to overwrite it with itself. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Reviewed-by: Paolo Bonzini Reviewed-by: Alberto Garcia --- block/quorum.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/b

[Qemu-devel] [PATCH v2 5/9] quorum: Inline quorum_aio_cb()

2016-11-22 Thread Kevin Wolf
This is a conversion to a more natural coroutine style and improves the readability of the driver. Signed-off-by: Kevin Wolf Reviewed-by: Alberto Garcia Reviewed-by: Eric Blake --- block/quorum.c | 118 - 1 file changed, 57 insertions(+),

[Qemu-devel] [PATCH v2 4/9] quorum: Do cleanup in caller coroutine

2016-11-22 Thread Kevin Wolf
Instead of calling quorum_aio_finalize() deeply nested in what used to be an AIO callback, do it in the same functions that allocated the AIOCB. Signed-off-by: Kevin Wolf Reviewed-by: Alberto Garcia Reviewed-by: Eric Blake --- block/quorum.c | 15 +-- 1 file changed, 9 insertions(+

Re: [Qemu-devel] [RFC] dirty bitmap state uncertainty under certain conditions

2016-11-22 Thread Vladimir Sementsov-Ogievskiy
22.11.2016 15:01, Nikolay Shirokovskiy wrote: Hi, everyone. There is a problem with current incremental backups. Imagine I ask qemu to make an incremental backup then go away and return back when backup job is finished. Qemu process dismisses the job completely and I missed all the events so

[Qemu-devel] [PATCH v2 7/9] quorum: Implement .bdrv_co_preadv/pwritev()

2016-11-22 Thread Kevin Wolf
This enables byte granularity requests on quorum nodes. Note that the QMP events emitted by the driver are an external API that we were careless enough to define as sector based. The offset and length of requests reported in events are rounded therefore. Signed-off-by: Kevin Wolf --- block/quor

Re: [Qemu-devel] [PATCH 7/8] quorum: Implement .bdrv_co_preadv/pwritev()

2016-11-22 Thread Eric Blake
On 11/22/2016 05:45 AM, Kevin Wolf wrote: >> >> Is it worth adding assert(!flags)? For now, the block layer doesn't >> have any defined flags (and if it did, we'd probably want to add a >> .supported_read_flags to parallel the existing .supported_write_flags). > > I don't think we need to assert

[Qemu-devel] [RFC PATCH] throttle: move throttling cmdline options to a separate header file

2016-11-22 Thread Greg Kurz
This will allow other subsystems (i.e. fsdev) to implement throttling without duplicating the command line options. Signed-off-by: Greg Kurz --- Hi, Pradeep has been working on enabling throttling in 9p/fsdev. The latest version (v11) of the patch is: Message-Id: <1478854467-25061-1-git-send-em

Re: [Qemu-devel] [PATCH v2 7/9] quorum: Implement .bdrv_co_preadv/pwritev()

2016-11-22 Thread Eric Blake
On 11/22/2016 06:24 AM, Kevin Wolf wrote: > This enables byte granularity requests on quorum nodes. > > Note that the QMP events emitted by the driver are an external API that > we were careless enough to define as sector based. The offset and length > of requests reported in events are rounded th

Re: [Qemu-devel] [PATCH 8/8] quorum: Inline quorum_fifo_aio_cb()

2016-11-22 Thread Eric Blake
On 11/22/2016 03:23 AM, Alberto Garcia wrote: > On Mon 21 Nov 2016 09:08:06 PM CET, Eric Blake wrote: > >> Back to my comments earlier in the series - We may want to think about >> a parallel FIFO mode, where we kick off all reads, but then are >> prepared to cancel reads on later children once w

[Qemu-devel] [Bug 1626972] Re: QEMU memfd_create fallback mechanism change for security drivers

2016-11-22 Thread Rafael David Tinoco
** Patch added: "zesty_qemu_2.6.1+dfsg-0ubuntu7.debdiff" https://bugs.launchpad.net/qemu/+bug/1626972/+attachment/4781485/+files/zesty_qemu_2.6.1+dfsg-0ubuntu7.debdiff -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.l

Re: [Qemu-devel] qobject/qjson.c:69: failed assertion `obj != NULL'

2016-11-22 Thread Eric Blake
On 11/22/2016 04:06 AM, Markus Armbruster wrote: > Eric Blake writes: > >> On 11/21/2016 02:36 PM, Eric Blake wrote: >>> The source of your problem is that your platform defines PRId64 as 'qd', >>> but the qemu JSON parser only recognizes lld (POSIX) or I64d (mingw) for >>> parsing 64-bit numbers

[Qemu-devel] [PATCH] blkverify: Implement bdrv_co_preadv/pwritev/flush

2016-11-22 Thread Kevin Wolf
This enables byte granularity requests for blkverify, and at the same time gets us rid of another user of the BDS-level AIO emulation. The reference output of a test case must be changed because the verification failure message reports byte offsets instead of sectors now. Signed-off-by: Kevin Wol

Re: [Qemu-devel] [PATCH v2 9/9] quorum: Clean up quorum_aio_get()

2016-11-22 Thread Eric Blake
On 11/22/2016 06:24 AM, Kevin Wolf wrote: > Make sure that all fields of the new QuorumAIOCB are zeroed when the > function returns even without explicitly setting them. This will protect > us when new fields are added, removes some explicit zero assignment and > makes the code a little nicer to re

[Qemu-devel] [PATCH] blkdebug: Implement bdrv_co_preadv/pwritev/flush

2016-11-22 Thread Kevin Wolf
This enables byte granularity requests for blkdebug, and at the same time gets us rid of another user of the BDS-level AIO emulation. Note that unless align=512 is specified, this can behave subtly different from the old behaviour because bdrv_co_preadv/pwritev don't have to perform alignment adju

[Qemu-devel] [PATCH] xen: fix ioreq handling

2016-11-22 Thread Jan Beulich
Avoid double fetches and bounds check size to avoid overflowing internal variables. This is CVE-2016-9381 / XSA-197. Reported-by: yanghongke Signed-off-by: Jan Beulich Reviewed-by: Stefano Stabellini --- a/xen-hvm.c +++ b/xen-hvm.c @@ -810,6 +810,10 @@ static void cpu_ioreq_pio(ioreq_t *req)

Re: [Qemu-devel] qobject/qjson.c:69: failed assertion `obj != NULL'

2016-11-22 Thread Paolo Bonzini
> > I kind of like the %-escapes, because they provide a compact and legible > > way to build QObjects. But with so little use, they're hardly earning > > their keep. > > What drives me most insane about them is that they are NOT the same > escapes as printf(), so the compiler can't help us with

Re: [Qemu-devel] [PATCH] blkdebug: Implement bdrv_co_preadv/pwritev/flush

2016-11-22 Thread Eric Blake
On 11/22/2016 06:39 AM, Kevin Wolf wrote: > This enables byte granularity requests for blkdebug, and at the same > time gets us rid of another user of the BDS-level AIO emulation. > > Note that unless align=512 is specified, this can behave subtly > different from the old behaviour because bdrv_co

Re: [Qemu-devel] [RFC PATCH] throttle: move throttling cmdline options to a separate header file

2016-11-22 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [RFC PATCH] throttle: move throttling cmdline options to a separate header file Type: series Message-id: 147981681351.30309.4854065801791462661.st...@bahia.lab.toulouse-stg.fr.

Re: [Qemu-devel] dpdk/vpp and cross-version migration for vhost

2016-11-22 Thread Yuanhan Liu
On Thu, Nov 17, 2016 at 07:37:09PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 17, 2016 at 05:49:36PM +0800, Yuanhan Liu wrote: > > On Thu, Nov 17, 2016 at 09:47:09AM +0100, Maxime Coquelin wrote: > > > > > > > > > On 11/17/2016 09:29 AM, Yuanhan Liu wrote: > > > >As usaual, sorry for late res

Re: [Qemu-devel] [PATCH] blkverify: Implement bdrv_co_preadv/pwritev/flush

2016-11-22 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH] blkverify: Implement bdrv_co_preadv/pwritev/flush Type: series Message-id: 1479818564-9084-1-git

Re: [Qemu-devel] [PATCH 07/21] qcow2: add dirty bitmaps extension

2016-11-22 Thread Vladimir Sementsov-Ogievskiy
16.11.2016 00:42, John Snow wrote: On 11/09/2016 01:17 PM, Vladimir Sementsov-Ogievskiy wrote: Add dirty bitmap extension as specified in docs/specs/qcow2.txt. For now, just mirror extension header into Qcow2 state and check constraints. For now, disable image resize if it has bitmaps. It wil

Re: [Qemu-devel] [PATCH] blkdebug: Implement bdrv_co_preadv/pwritev/flush

2016-11-22 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH] blkdebug: Implement bdrv_co_preadv/pwritev/flush Type: series Message-id: 1479818357-8752-1-git-

Re: [Qemu-devel] [PULL for-2.8 0/2] target-alpha update

2016-11-22 Thread Stefan Hajnoczi
On Tue, Nov 22, 2016 at 08:55:58AM +0100, Richard Henderson wrote: > On 11/21/2016 08:43 PM, Andreas Schwab wrote: > > Fetched in submodule path 'roms/qemu-palcode', but it did not contain > > f3c7e44c70254975df2a00af39701eafbac4d471. Direct fetching of that commit > > failed. > > That's strange

Re: [Qemu-devel] [RFC 00/15] qmp: Report supported device types on 'query-machines'

2016-11-22 Thread Eduardo Habkost
On Tue, Nov 22, 2016 at 09:18:21AM +0100, David Hildenbrand wrote: > > > > > Considered alternatives > > === > > > > Indirect mapping (machine => bus => device) > > --- > > > > This RFC implements a mechanism to implement ax > > mach

Re: [Qemu-devel] [PATCH v6 1/3] IOMMU: add option to enable VTD_CAP_CM to vIOMMU capility exposoed to guest

2016-11-22 Thread Aviv B.D.
On Tue, Nov 22, 2016 at 6:11 AM, Jason Wang wrote: > > > On 2016年11月21日 21:35, Michael S. Tsirkin wrote: > >> On Fri, Nov 11, 2016 at 12:15:48PM +0800, Jason Wang wrote: >> >>> > >>> > >>> >On 2016年11月11日 11:39, Michael S. Tsirkin wrote: >>> > >On Fri, Nov 11, 2016 at 10:32:42AM +0800, Jason

Re: [Qemu-devel] [PATCH v3 3/9] block: Let write zeroes fallback work even with small max_transfer

2016-11-22 Thread Kevin Wolf
Am 17.11.2016 um 21:13 hat Eric Blake geschrieben: > Commit 443668ca rewrote the write_zeroes logic to guarantee that > an unaligned request never crosses a cluster boundary. But > in the rewrite, the new code assumed that at most one iteration > would be needed to get to an alignment boundary. >

Re: [Qemu-devel] [PATCH v2 7/9] quorum: Implement .bdrv_co_preadv/pwritev()

2016-11-22 Thread Alberto Garcia
On Tue 22 Nov 2016 01:24:02 PM CET, Kevin Wolf wrote: > This enables byte granularity requests on quorum nodes. > > Note that the QMP events emitted by the driver are an external API that > we were careless enough to define as sector based. The offset and length > of requests reported in events are

[Qemu-devel] [PATCH 6/9] target-ppc: implement stxsd and stxssp

2016-11-22 Thread Nikunj A Dadhania
stxsd: Store VSX Scalar Dword stxssp: Store VSX Scalar SP Moreover, DQ-Form/DS-FORM instructions shares the same primary opcode(0x3D), bits 29:31 are used to decode the instruction. Us e a common routine to decode primary opcode(0x3D) - ds-form/dq-form instructions. Signed-off-by: Nikunj A Dadha

[Qemu-devel] [PATCH 7/9] target-ppc: implement lxv/lxvx and stxv/stxvx

2016-11-22 Thread Nikunj A Dadhania
lxv: Load VSX Vector lxvx: Load VSX Vector Indexed Little/Big-endian Storage +--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+ |F0|F1|F2|F3|F4|F5|F6|F7|E0|E1|E2|E3|E4|E5|E6|E7| +--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+ Vector load results: BE: +--+--+--+--+--+

[Qemu-devel] [PATCH 4/9] target-ppc: Add xscmpoqp and xscmpuqp instructions

2016-11-22 Thread Nikunj A Dadhania
From: Bharata B Rao xscmpoqp - VSX Scalar Compare Ordered Quad-Precision xscmpuqp - VSX Scalar Compare Unordered Quad-Precision Signed-off-by: Bharata B Rao Signed-off-by: Nikunj A Dadhania --- target-ppc/fpu_helper.c | 52 + target-ppc/helper.h

[Qemu-devel] [PATCH 8/9] target-ppc: add vextu[bhw]lx instructions

2016-11-22 Thread Nikunj A Dadhania
From: Avinesh Kumar vextublx: Vector Extract Unsigned Byte Left vextuhlx: Vector Extract Unsigned Halfword Left vextuwlx: Vector Extract Unsigned Word Left Signed-off-by: Avinesh Kumar Signed-off-by: Nikunj A Dadhania --- target-ppc/helper.h | 3 ++ target-ppc/int_helper.c

Re: [Qemu-devel] [PATCH v3 3/9] block: Let write zeroes fallback work even with small max_transfer

2016-11-22 Thread Eric Blake
On 11/22/2016 07:16 AM, Kevin Wolf wrote: > Am 17.11.2016 um 21:13 hat Eric Blake geschrieben: >> Commit 443668ca rewrote the write_zeroes logic to guarantee that >> an unaligned request never crosses a cluster boundary. But >> in the rewrite, the new code assumed that at most one iteration >> wou

[Qemu-devel] [PATCH 5/9] target-ppc: implement lxsd and lxssp instructions

2016-11-22 Thread Nikunj A Dadhania
lxsd: Load VSX Scalar Dword lxssp: Load VSX Scalar Single Moreover, DS-Form instructions shares the same primary opcode, bits 30:31 are used to decode the instruction. Use a common routine to decode primary opcode(0x39) - ds-form instructions and branch-out depending on bits 30:31. Signed-off-by:

Re: [Qemu-devel] [PATCH v3 3/9] block: Let write zeroes fallback work even with small max_transfer

2016-11-22 Thread Kevin Wolf
Am 22.11.2016 um 14:22 hat Eric Blake geschrieben: > On 11/22/2016 07:16 AM, Kevin Wolf wrote: > > Am 17.11.2016 um 21:13 hat Eric Blake geschrieben: > >> Commit 443668ca rewrote the write_zeroes logic to guarantee that > >> an unaligned request never crosses a cluster boundary. But > >> in the re

Re: [Qemu-devel] [PATCH v2 9/9] quorum: Clean up quorum_aio_get()

2016-11-22 Thread Alberto Garcia
On Tue 22 Nov 2016 01:24:04 PM CET, Kevin Wolf wrote: > Make sure that all fields of the new QuorumAIOCB are zeroed when the > function returns even without explicitly setting them. This will protect > us when new fields are added, removes some explicit zero assignment and > makes the code a little

Re: [Qemu-devel] [RFC 05/15] tests: Add rules to non-gtester qtest test cases

2016-11-22 Thread Eduardo Habkost
On Mon, Nov 21, 2016 at 11:12:03PM -0200, Eduardo Habkost wrote: [...] > +define qtest-target = This breaks on old GNU Make versions. Both patchew and travis-ci reported similar errors: make: *** No rule to make target `check-simpleqtest-x86_64', needed by `check-simpleqtest'. Stop. Old mak

Re: [Qemu-devel] [PATCH] blkverify: Implement bdrv_co_preadv/pwritev/flush

2016-11-22 Thread Eric Blake
On 11/22/2016 06:42 AM, Kevin Wolf wrote: > This enables byte granularity requests for blkverify, and at the same > time gets us rid of another user of the BDS-level AIO emulation. > > The reference output of a test case must be changed because the > verification failure message reports byte offse

[Qemu-devel] [Bug 1626972] Re: QEMU memfd_create fallback mechanism change for security drivers

2016-11-22 Thread ChristianEhrhardt
Thanks Rafael - the upstream work on this is excellent! I already built all those fine and I'm now looking into some regression checks before considering/doing an upload to Dev-Release & SRU-queue -- You received this bug notification because you are a member of qemu- devel-ml, which is subscrib

Re: [Qemu-devel] [PATCH] block/mirror: enable detect zeroes when driving mirror

2016-11-22 Thread Eric Blake
On 11/21/2016 08:31 PM, wyang wrote: > On 2016年11月21日 14:51, Vasiliy Tolstov wrote: >> >> 21 Ноя 2016 г. 4:27 пользователь "Yang Wei" > > написал: >> > >> > In order to preserve sparse disk image, detect_zeroes >> > should also be enabled when bdrv_get_block_status_above()

Re: [Qemu-devel] [RFC PATCH] throttle: move throttling cmdline options to a separate header file

2016-11-22 Thread Alberto Garcia
On Tue 22 Nov 2016 01:49:51 PM CET, Greg Kurz wrote: > This will allow other subsystems (i.e. fsdev) to implement throttling > without duplicating the command line options. > > Signed-off-by: Greg Kurz Did you check if it's possible / easy to do defining a normal array instead of a macro and usi

Re: [Qemu-devel] [RFC PATCH] throttle: move throttling cmdline options to a separate header file

2016-11-22 Thread Greg Kurz
On Tue, 22 Nov 2016 14:51:12 +0100 Alberto Garcia wrote: > On Tue 22 Nov 2016 01:49:51 PM CET, Greg Kurz wrote: > > > This will allow other subsystems (i.e. fsdev) to implement throttling > > without duplicating the command line options. > > > > Signed-off-by: Greg Kurz > > Did you check if

Re: [Qemu-devel] [PATCH v2 5/9] block: Pass unaligned discard requests to drivers

2016-11-22 Thread Kevin Wolf
Am 17.11.2016 um 21:13 hat Eric Blake geschrieben: > Discard is advisory, so rounding the requests to alignment > boundaries is never semantically wrong from the data that > the guest sees. But at least the Dell Equallogic iSCSI SANs > has an interesting property that its advertised discard > alig

Re: [Qemu-devel] [libvirt] [Qemu-ppc] [RFC PATCH qemu] spapr_pci: Create PCI-express root bus by default

2016-11-22 Thread Eric Blake
On 11/21/2016 07:08 AM, Andrea Bolognani wrote: >> If libvirt is using a specific version of pseries, then it already knows >> that <=2.7 has pci.0 as a root, pcie.0 otherwise. libvirt has a knowledge >> what QEMU version has what, right? > > It doesn't yet, that's the point :) > > We *could* ad

Re: [Qemu-devel] [PATCH v2 5/9] block: Pass unaligned discard requests to drivers

2016-11-22 Thread Eric Blake
On 11/22/2016 08:03 AM, Kevin Wolf wrote: > Am 17.11.2016 um 21:13 hat Eric Blake geschrieben: >> Discard is advisory, so rounding the requests to alignment >> boundaries is never semantically wrong from the data that >> the guest sees. But at least the Dell Equallogic iSCSI SANs >> has an interes

Re: [Qemu-devel] [RFC v2 3/3] virtio-net: Add MTU feature support

2016-11-22 Thread Michael S. Tsirkin
On Tue, Nov 22, 2016 at 01:11:50PM +0100, Maxime Coquelin wrote: > > > On 11/21/2016 05:48 PM, Michael S. Tsirkin wrote: > > > > > > > > @@ -1695,6 +1706,7 @@ static void > > > > > > > > virtio_net_set_config_size(VirtIONet *n, uint64_t host_features) > > > > > > > > { > > > > > > > > int

  1   2   3   >