Re: [Qemu-devel] [PATCH v11 10/22] vfio iommu type1: Add support for mediated devices

2016-11-15 Thread Kirti Wankhede
On 11/15/2016 12:57 PM, Alexey Kardashevskiy wrote: > On 15/11/16 17:33, Kirti Wankhede wrote: >> >> >> On 11/15/2016 10:47 AM, Alexey Kardashevskiy wrote: >>> On 08/11/16 17:52, Alexey Kardashevskiy wrote: On 05/11/16 08:10, Kirti Wankhede wrote: > VFIO IOMMU drivers are designed for th

[Qemu-devel] [Bug 1641861] [NEW] fail to correctly emulate FPSCR register on arm

2016-11-15 Thread Jie
Public bug reported: Hi all, we systematically tested the QEMU implementation for emulating arm user mode programs. We found that QEMU incorrectly emulate the FPSCR register. The following the proof of code: /*** Beginning of the bug: arm.c **/ int printf(const char *format, ...)

Re: [Qemu-devel] [PATCH v12 12/22] vfio: Add notifier callback to parent's ops structure of mdev

2016-11-15 Thread Kirti Wankhede
On 11/15/2016 12:15 PM, Jike Song wrote: > On 11/14/2016 11:42 PM, Kirti Wankhede wrote: >> Add a notifier calback to parent's ops structure of mdev device so that per >> device notifer for vfio module is registered through vfio_mdev module. >> >> Signed-off-by: Kirti Wankhede >> Signed-off-by:

Re: [Qemu-devel] [PULL 12/47] virtio: remove ioeventfd_disabled altogether

2016-11-15 Thread Christian Borntraeger
On 11/10/2016 03:48 PM, Christian Borntraeger wrote: > On 11/10/2016 03:38 PM, Paolo Bonzini wrote: >> >> >> On 10/11/2016 15:35, Christian Borntraeger wrote: >>> On 10/30/2016 10:23 PM, Michael S. Tsirkin wrote: From: Paolo Bonzini Now that there is not anymore a switch from the ge

Re: [Qemu-devel] [PATCH v12 01/22] vfio: Mediated device Core driver

2016-11-15 Thread Dong Jia Shi
* Kirti Wankhede [2016-11-14 21:12:15 +0530]: Hi Kirti, [...] > diff --git a/drivers/vfio/mdev/mdev_core.c b/drivers/vfio/mdev/mdev_core.c > new file mode 100644 > index ..613e8a8a3b2a > --- /dev/null > +++ b/drivers/vfio/mdev/mdev_core.c > @@ -0,0 +1,374 @@ > +/* > + * Mediated dev

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] qapi-schema: clarify 'colo' state for MigrationStatus

2016-11-15 Thread Laurent Vivier
Le 14/11/2016 à 14:54, Stefan Hajnoczi a écrit : > On Mon, Nov 14, 2016 at 10:36:45AM +0800, Hailiang Zhang wrote: >> ping ? >> >> Anyone pick this up? > > The original patch that added these lines went through Amit Shah and > David Gilbert. I have CCed them. If it is needed, I can also send a p

Re: [Qemu-devel] [PATCH] hw/misc/ivshmem:fix misconfig of not_legacy_32bit

2016-11-15 Thread Marc-André Lureau
Hi On Mon, Nov 14, 2016 at 4:44 PM Zhuangyanying wrote: > From: ZhuangYanying > > After "ivshmem: Split ivshmem-plain, ivshmem-doorbell off ivshmem", > ivshmem_64bit renamed to not_legacy_32bit, and changed the implementation > of this property. > Then use64 = not_legacy_32bit = 1, then PCI att

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] qapi-schema: clarify 'colo' state for MigrationStatus

2016-11-15 Thread Zhang Chen
On 11/15/2016 04:44 PM, Laurent Vivier wrote: Le 14/11/2016 à 14:54, Stefan Hajnoczi a écrit : On Mon, Nov 14, 2016 at 10:36:45AM +0800, Hailiang Zhang wrote: ping ? Anyone pick this up? The original patch that added these lines went through Amit Shah and David Gilbert. I have CCed them.

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] qapi-schema: clarify 'colo' state for MigrationStatus

2016-11-15 Thread Hailiang Zhang
On 2016/11/15 16:58, Zhang Chen wrote: On 11/15/2016 04:44 PM, Laurent Vivier wrote: Le 14/11/2016 à 14:54, Stefan Hajnoczi a écrit : On Mon, Nov 14, 2016 at 10:36:45AM +0800, Hailiang Zhang wrote: ping ? Anyone pick this up? The original patch that added these lines went through Amit Shah

Re: [Qemu-devel] [PATCH] hw/misc/ivshmem:fix misconfig of not_legacy_32bit

2016-11-15 Thread Markus Armbruster
Zhuangyanying writes: > From: ZhuangYanying > > After "ivshmem: Split ivshmem-plain, ivshmem-doorbell off ivshmem", > ivshmem_64bit renamed to not_legacy_32bit, and changed the implementation of > this property. > Then use64 = not_legacy_32bit = 1, then PCI attribute configuration ~ > PCI_BAS

Re: [Qemu-devel] [PATCH] hw/misc/ivshmem:fix misconfig of not_legacy_32bit

2016-11-15 Thread Gonglei
On 2016/11/15 16:47, Marc-André Lureau wrote: > Hi > > On Mon, Nov 14, 2016 at 4:44 PM Zhuangyanying > wrote: > > From: ZhuangYanying > > > After "ivshmem: Split ivshmem-plain, ivshmem-doorbell off ivshmem", >

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] qapi-schema: clarify 'colo' state for MigrationStatus

2016-11-15 Thread Zhang Chen
On 11/15/2016 05:03 PM, Hailiang Zhang wrote: On 2016/11/15 16:58, Zhang Chen wrote: On 11/15/2016 04:44 PM, Laurent Vivier wrote: Le 14/11/2016 à 14:54, Stefan Hajnoczi a écrit : On Mon, Nov 14, 2016 at 10:36:45AM +0800, Hailiang Zhang wrote: ping ? Anyone pick this up? The original pa

Re: [Qemu-devel] [PATCH] hw/misc/ivshmem:fix misconfig of not_legacy_32bit

2016-11-15 Thread Gonglei (Arei)
> -Original Message- > From: Markus Armbruster [mailto:arm...@redhat.com] > Sent: Tuesday, November 15, 2016 5:05 PM > To: Zhuangyanying > Cc: pbonz...@redhat.com; Gonglei (Arei); Huangweidong (C); > qemu-devel@nongnu.org > Subject: Re: [Qemu-devel] [PATCH] hw/misc/ivshmem:fix misconfig of

Re: [Qemu-devel] [PATCH V11 1/1] fsdev: add IO throttle support to fsdev devices

2016-11-15 Thread Pradeep Jagadeesh
On 11/14/2016 6:57 PM, Greg Kurz wrote: On Mon, 14 Nov 2016 10:03:40 +0100 Pradeep Jagadeesh wrote: On 11/12/2016 3:13 PM, Greg Kurz wrote: On Fri, 11 Nov 2016 03:54:27 -0500 Pradeep Jagadeesh wrote: Uses throttling APIs to limit I/O bandwidth and number of operations on the devices which

Re: [Qemu-devel] [PATCH v12 12/22] vfio: Add notifier callback to parent's ops structure of mdev

2016-11-15 Thread Jike Song
On 11/15/2016 04:11 PM, Kirti Wankhede wrote: > > > On 11/15/2016 12:15 PM, Jike Song wrote: >> On 11/14/2016 11:42 PM, Kirti Wankhede wrote: >>> Add a notifier calback to parent's ops structure of mdev device so that per >>> device notifer for vfio module is registered through vfio_mdev module.

Re: [Qemu-devel] QEMU postcopy-test failing on ppc64

2016-11-15 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@gmail.com) wrote: > I hit a failure running "make check" on ppc64 for the first time. Ideas? Hmm shouldn't happen; cc'ing in lvivier, I've not checked it since Laurent got the test working on PPC. > Stefan > > commit 682df581c65ed2c1b9e77093e332214ecaa1ee93 > > GT

Re: [Qemu-devel] [PATCH 1/3] migration: create Migration Incoming State at init time

2016-11-15 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela > --- > include/migration/migration.h | 1 - > migration/migration.c | 38 +- > migration/savevm.c| 4 ++-- > 3 files changed, 19 insertions(+), 24 deletions(-) R

Re: [Qemu-devel] [PATCH 2/3] migration: Test for disabled features on reception

2016-11-15 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Right now, if we receive a compressed page or a xbzrle page while this > features are disabled, Bad Things (TM) can happen. Just add a test for > them. This confuses me; I didn't think until recently we could guarantee anything about having the capab

Re: [Qemu-devel] QEMU postcopy-test failing on ppc64

2016-11-15 Thread Laurent Vivier
On 14/11/2016 21:52, Stefan Hajnoczi wrote: > I hit a failure running "make check" on ppc64 for the first time. Ideas? > > Stefan > > commit 682df581c65ed2c1b9e77093e332214ecaa1ee93 > > GTESTER check-qtest-ppc64 > Memory content inconsistency at 5af4000 first_byte = 1b last_byte = 1a > curr

Re: [Qemu-devel] [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

2016-11-15 Thread Paolo Bonzini
On 15/11/2016 06:06, Michael S. Tsirkin wrote: > On Tue, Nov 15, 2016 at 01:50:21PM +0900, Namhyung Kim wrote: >> Hi Michael, >> >> On Thu, Nov 10, 2016 at 06:39:55PM +0200, Michael S. Tsirkin wrote: >>> On Sat, Aug 20, 2016 at 05:07:42PM +0900, Namhyung Kim wrote: The virtio pstore driver p

Re: [Qemu-devel] [PATCH V11 1/1] fsdev: add IO throttle support to fsdev devices

2016-11-15 Thread Greg Kurz
On Tue, 15 Nov 2016 10:13:59 +0100 Pradeep Jagadeesh wrote: > On 11/14/2016 6:57 PM, Greg Kurz wrote: > > On Mon, 14 Nov 2016 10:03:40 +0100 > > Pradeep Jagadeesh wrote: > > > >> On 11/12/2016 3:13 PM, Greg Kurz wrote: > >>> On Fri, 11 Nov 2016 03:54:27 -0500 > >>> Pradeep Jagadeesh wrote:

Re: [Qemu-devel] [PULL 12/47] virtio: remove ioeventfd_disabled altogether

2016-11-15 Thread Paolo Bonzini
On 15/11/2016 09:27, Christian Borntraeger wrote: > hmm, not quite. > This patch on top of > commit 6bbcb76301a72dc80c8d29af13d40bb9a759c9c6 MAINTAINERS: Remove obsolete > stable branches > still triggers > > qemu-system-s390x: hw/s390x/virtio-ccw.c:1076: virtio_ccw_remove_irqfd: > Assertio

Re: [Qemu-devel] [PATCH 2/3] migration: Test for disabled features on reception

2016-11-15 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> Right now, if we receive a compressed page or a xbzrle page while this >> features are disabled, Bad Things (TM) can happen. Just add a test for >> them. > > This confuses me; I didn't think until recently we could

Re: [Qemu-devel] QEMU postcopy-test failing on ppc64

2016-11-15 Thread Greg Kurz
On Tue, 15 Nov 2016 10:53:35 +0100 Laurent Vivier wrote: > On 14/11/2016 21:52, Stefan Hajnoczi wrote: > > I hit a failure running "make check" on ppc64 for the first time. Ideas? > > > > Stefan > > > > commit 682df581c65ed2c1b9e77093e332214ecaa1ee93 > > > > GTESTER check-qtest-ppc64 > > Me

[Qemu-devel] [PATCH v1 10/18] block/pcache: skip readahead for unallocated clusters

2016-11-15 Thread Pavel Butsykin
Typically, data for unallocated clusters is filled with zeros, so it makes no sense to store it in the cache. Signed-off-by: Pavel Butsykin --- block/pcache.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/block/pcache.c b/block/pcache.c index 3717037..1f3800d 10

[Qemu-devel] [PATCH v1 05/18] tests/test-rbcache: add test cases

2016-11-15 Thread Pavel Butsykin
Signed-off-by: Pavel Butsykin --- tests/Makefile.include | 3 + tests/test-rbcache.c | 308 + 2 files changed, 311 insertions(+) create mode 100644 tests/test-rbcache.c diff --git a/tests/Makefile.include b/tests/Makefile.include index 8162f6f

Re: [Qemu-devel] [PATCH] 9pfs: adjust the order of resource cleanup in device unrealize

2016-11-15 Thread Greg Kurz
Hi Li, Please incorporate this patch in your cleanup series since it depends on it. On Mon, 14 Nov 2016 20:38:57 -0500 Li Qiang wrote: > From: Li Qiang > > Unrealize should undo things that were set during realize in > reverse order. This is what this patch does. > So should do the error pa

Re: [Qemu-devel] [PATCH v2 0/3] 9pfs: add cleanup operation in handle/proxy backend

2016-11-15 Thread Greg Kurz
On Mon, 14 Nov 2016 21:13:50 -0500 Li Qiang wrote: > Currently, the backend of VirtFS doesn't have a cleanup > function. This will leak some resources in handle and proxy > backend driver. This patchset addresses this issue. > > Li Qiang (3): > 9pfs: add cleanup operation in FileOperations >

Re: [Qemu-devel] [PATCH v6 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2016-11-15 Thread Stefan Hajnoczi
On Tue, Nov 15, 2016 at 10:04:05AM +0800, Fam Zheng wrote: > On Mon, 11/14 13:06, Eric Blake wrote: > > So I guess you have to determine if libqnio is something that should > > compile completely independent from qemu, or whether it is so closely > > tied to the rest of qemu that it should follow q

Re: [Qemu-devel] [PATCH v2 0/3] 9pfs: add cleanup operation in handle/proxy backend

2016-11-15 Thread Li Qiang
It is caused by the git config. remove the "From x" section in git [sendemail] will solve the message ID issue. 2016-11-15 18:16 GMT+08:00 Greg Kurz : > On Mon, 14 Nov 2016 21:13:50 -0500 > Li Qiang wrote: > > > Currently, the backend of VirtFS doesn't have a cleanup > > function. This will

Re: [Qemu-devel] [PATCH v2 2/3] 9pfs: add cleanup operation for handle backend driver

2016-11-15 Thread Greg Kurz
On Mon, 14 Nov 2016 21:13:52 -0500 Li Qiang wrote: > In the init operation of handle backend dirver, it allocates a > handle_data struct and opens a mount file. We should free these > resources when the 9pfs device is unrealized. This is what this > patch does. > > Signed-off-by: Li Qiang > ---

Re: [Qemu-devel] [PATCH for-2.8 0/2] pc: remove redundant fw_cfg file "etc/boot-cpus"

2016-11-15 Thread Gerd Hoffmann
Hi, > I agree we shouldn't commit to a bad host/guest API > but I think we need to format it differently. > First revert the boot-cpus patch for 2.8. > On top of that, add a patch fixing FW_CFG_NB_CPUS. Agree, doing a plain revert of 080ac219cc7d9c55adf925c3545b7450055ad625 is better. cheers,

[Qemu-devel] Ballooning in Qemu-KVM

2016-11-15 Thread Chandra Maloo
Hello, I am new to the Qemu Developer Community. I learned about ballooning technique in my undergrad course and want to explore ballooning in detail. I was thinking about using the memory usage data of different VMs running on the same hypervisor and use some predictions (like regression analysis)

Re: [Qemu-devel] [PATCH v2 3/3] 9pfs: add cleanup operation for proxy backend driver

2016-11-15 Thread Greg Kurz
On Mon, 14 Nov 2016 21:13:53 -0500 Li Qiang wrote: > In the init operation of proxy backend dirver, it allocates a > V9fsProxy struct and some other resources. We should free these > resources when the 9pfs device is unrealized. This is what this > patch does. > > Signed-off-by: Li Qiang > ---

Re: [Qemu-devel] [PATCH V11 1/1] fsdev: add IO throttle support to fsdev devices

2016-11-15 Thread Pradeep Jagadeesh
On 11/15/2016 10:58 AM, Greg Kurz wrote: On Tue, 15 Nov 2016 10:13:59 +0100 Pradeep Jagadeesh wrote: On 11/14/2016 6:57 PM, Greg Kurz wrote: On Mon, 14 Nov 2016 10:03:40 +0100 Pradeep Jagadeesh wrote: On 11/12/2016 3:13 PM, Greg Kurz wrote: On Fri, 11 Nov 2016 03:54:27 -0500 Pradeep Jagad

Re: [Qemu-devel] Qemu 2.6 => Qemu 2.7 migration: error while loading state for instance 0x0 of device '0000:00:03.0/virtio-balloon'

2016-11-15 Thread Dr. David Alan Gilbert
* Stefan Priebe - Profihost AG (s.pri...@profihost.ag) wrote: > Hello, > > today i did a first live migration from Qemu 2.6.2 to Qemu 2.7.0. The VM > is running windows and virtio-balloon and with machine type pc-i440fx-2.5. > > The output of the target qemu process was: > kvm_apic_post_load: Yeh

Re: [Qemu-devel] [RFC 0/3] aio: experimental virtio-blk polling mode

2016-11-15 Thread Stefan Hajnoczi
On Mon, Nov 14, 2016 at 09:52:00PM +0100, Paolo Bonzini wrote: > On 14/11/2016 21:12, Karl Rister wrote: > > 25646,929 > > 51235,627 > >1,02446,477 > >2,00035,247 > >2,04846,322 > >

Re: [Qemu-devel] Qemu 2.6 => Qemu 2.7 migration: error while loading state for instance 0x0 of device '0000:00:03.0/virtio-balloon'

2016-11-15 Thread Stefan Priebe - Profihost AG
Hello, Am 15.11.2016 um 11:30 schrieb Dr. David Alan Gilbert: > * Stefan Priebe - Profihost AG (s.pri...@profihost.ag) wrote: >> Hello, >> >> today i did a first live migration from Qemu 2.6.2 to Qemu 2.7.0. The VM >> is running windows and virtio-balloon and with machine type pc-i440fx-2.5. >> >>

Re: [Qemu-devel] [PATCH 2/3] migration: Test for disabled features on reception

2016-11-15 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert" wrote: > > * Juan Quintela (quint...@redhat.com) wrote: > >> Right now, if we receive a compressed page or a xbzrle page while this > >> features are disabled, Bad Things (TM) can happen. Just add a test for > >> them. > > >

Re: [Qemu-devel] [RFC 0/3] aio: experimental virtio-blk polling mode

2016-11-15 Thread Stefan Hajnoczi
On Mon, Nov 14, 2016 at 06:15:46PM +0100, Paolo Bonzini wrote: > > > On 14/11/2016 18:06, Stefan Hajnoczi wrote: > >>> > > Very interesting that QEMU_AIO_POLL_MAX_NS=1 performs so well without > >>> > > much CPU overhead. > >> > > >> > That basically means "avoid a syscall if you already know th

[Qemu-devel] [PATCH v2 2/2] ivshmem: set not_legacy_32bit to 1 for ivshmem_doorbell and ivshmem-plain

2016-11-15 Thread Zhuangyanying
From: ZhuangYanying Signed-off-by: Zhuang Yanying --- hw/misc/ivshmem.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index b897685..abeaf3d 100644 --- a/hw/misc/ivshmem.c +++ b/hw/misc/ivshmem.c @@ -1045,6 +1045,7 @@ static void ivshmem_plain_init(

[Qemu-devel] [PATCH v2 0/2] ivshmem: fix misconfig of not_legacy_32bit

2016-11-15 Thread Zhuangyanying
From: ZhuangYanying Recently, I tested ivshmem, found that use64, that is not_legacy_32bit implementation is odd, or even the opposite. Previous use64 = ivshmem_64bit = 1, then attr |= PCI_BASE_ADDRESS_MEM_TYPE_64, ivshmem support 1G and above packaged into bar2, presented to the virtual machi

[Qemu-devel] [PATCH v2 1/2] ivshmem: fix misconfig of not_legacy_32bit

2016-11-15 Thread Zhuangyanying
From: ZhuangYanying After commit 5400c02, ivshmem_64bit renamed to not_legacy_32bit, and changed the implementation of this property. Then use64 = 1, ~PCI_BASE_ADDRESS_MEM_TYPE_64 (default for ivshmem), the actual use is the legacy model, can not support greater than or equal 1G mapping, which

Re: [Qemu-devel] [PATCH v2 2/2] ivshmem: set not_legacy_32bit to 1 for ivshmem_doorbell and ivshmem-plain

2016-11-15 Thread Marc-André Lureau
- Original Message - > From: ZhuangYanying > > Signed-off-by: Zhuang Yanying Reviewed-by: Marc-André Lureau > --- > hw/misc/ivshmem.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c > index b897685..abeaf3d 100644 > --- a/hw/misc/iv

Re: [Qemu-devel] [PATCH v2 1/2] ivshmem: fix misconfig of not_legacy_32bit

2016-11-15 Thread Marc-André Lureau
Hi - Original Message - > From: ZhuangYanying > > After commit 5400c02, ivshmem_64bit renamed to not_legacy_32bit, > and changed the implementation of this property. > Then use64 = 1, ~PCI_BASE_ADDRESS_MEM_TYPE_64 (default for ivshmem), > the actual use is the legacy model, > can not sup

Re: [Qemu-devel] [PULL v2 00/34] virtio, vhost, pc, pci: tests, documentation, fixes and cleanups

2016-11-15 Thread Stefan Hajnoczi
On Tue, Nov 15, 2016 at 01:19:40AM +0200, Michael S. Tsirkin wrote: > Well I feel bad about it. > It was ready in time, I deferred it because there was so much other > stuff that I did not want it to interfere with. > > I was sure it's ok - it's just a test change, I don't really see why we > need

Re: [Qemu-devel] Qemu 2.6 => Qemu 2.7 migration: error while loading state for instance 0x0 of device '0000:00:03.0/virtio-balloon'

2016-11-15 Thread Stefan Hajnoczi
On Mon, Nov 14, 2016 at 07:57:47PM +0100, Stefan Priebe - Profihost AG wrote: > today i did a first live migration from Qemu 2.6.2 to Qemu 2.7.0. The VM > is running windows and virtio-balloon and with machine type pc-i440fx-2.5. > > The output of the target qemu process was: > kvm_apic_post_load:

Re: [Qemu-devel] [PULL 0/4] Migration pull

2016-11-15 Thread Stefan Hajnoczi
On Mon, Nov 14, 2016 at 08:57:50PM +0100, Juan Quintela wrote: > The following changes since commit 83c83f9a5266ff113060f887f106a47920fa6974: > > Merge remote-tracking branch 'bonzini/tags/for-upstream' into staging > (2016-11-11 12:51:50 +) > > are available in the git repository at: > >

Re: [Qemu-devel] Qemu 2.6 => Qemu 2.7 migration: error while loading state for instance 0x0 of device '0000:00:03.0/virtio-balloon'

2016-11-15 Thread Ladi Prosek
Hi, On Tue, Nov 15, 2016 at 11:37 AM, Stefan Priebe - Profihost AG wrote: > Hello, > > Am 15.11.2016 um 11:30 schrieb Dr. David Alan Gilbert: >> * Stefan Priebe - Profihost AG (s.pri...@profihost.ag) wrote: >>> Hello, >>> >>> today i did a first live migration from Qemu 2.6.2 to Qemu 2.7.0. The V

[Qemu-devel] [PATCH v1 08/18] block/pcache: updating statistics for overlapping requests

2016-11-15 Thread Pavel Butsykin
When updating the statistics sometimes i/O requests can overlap each other, in this case the requests are not stored in the statistics. It's not very good, especially when the requests have a small range of intersection. We can cut the requests in the intersection and add the pieces of requests in

Re: [Qemu-devel] [PATCH for-2.8 0/2] pc: remove redundant fw_cfg file "etc/boot-cpus"

2016-11-15 Thread Igor Mammedov
On Mon, 14 Nov 2016 22:46:14 +0200 "Michael S. Tsirkin" wrote: > On Fri, Nov 11, 2016 at 04:21:10PM +0100, Igor Mammedov wrote: > > > > Commit 080ac219cc7d9c55adf925c3545b7450055ad625 > >pc: Add 'etc/boot-cpus' fw_cfg file for machine with more than 255 CPUs > > > > added "etc/boot-cpus" fw

[Qemu-devel] [PATCH v1 06/18] block/pcache: statistics collection read requests

2016-11-15 Thread Pavel Butsykin
Here the rbcache is used as a repository statistics requests, in fact, data requests are not cached, so we have the ability to store a large number of requests. We need statistics requests to determine the sequential requests. Signed-off-by: Pavel Butsykin --- block/pcache.c | 31 ++

[Qemu-devel] [PATCH v1 03/18] util/rbtree: add rbtree from linux kernel

2016-11-15 Thread Pavel Butsykin
Why don't we use rbtree from glib? We need pointer to the parent node. For optimal implementation storing of cached chunks in the rbtree need to get next and previous nodes and content of parent node is very useful for effective implementation of these functions. In this implementation of rbtree (

Re: [Qemu-devel] [PULL] slirp: Fix access to freed memory

2016-11-15 Thread Stefan Hajnoczi
On Mon, Nov 14, 2016 at 09:20:29PM +0100, Samuel Thibault wrote: > The following changes since commit 83c83f9a5266ff113060f887f106a47920fa6974: > > Merge remote-tracking branch 'bonzini/tags/for-upstream' into staging > (2016-11-11 12:51:50 +) > > are available in the git repository at: >

[Qemu-devel] [PATCH v1 00/18] I/O prefetch cache

2016-11-15 Thread Pavel Butsykin
The prefetch cache aims to improve the performance of sequential read data. Of most interest here are the requests of a small size of data for sequential read, such requests can be optimized by extending them and moving into the prefetch cache. However, there are 2 issues: - In aggregate only a s

[Qemu-devel] [PATCH v1 02/18] block/pcache: empty pcache driver filter

2016-11-15 Thread Pavel Butsykin
The basic version of pcache driver for easy preparation of a patch set. Signed-off-by: Pavel Butsykin --- block/Makefile.objs | 1 + block/pcache.c | 144 2 files changed, 145 insertions(+) create mode 100644 block/pcache.c diff --git

[Qemu-devel] [PATCH v1 14/18] backup/pcache: pick up parts of the cache

2016-11-15 Thread Pavel Butsykin
Provided that the request size is less than the readahead size, a partial cache hit can occur in the following three cases: 1. The request covers the bottom part of the node 2. The request covers the upper part of the node 3. The request is between two nodes and partially covers both of them The f

[Qemu-devel] [PATCH v1 15/18] block/pcache: drop used pcache nodes

2016-11-15 Thread Pavel Butsykin
The pcache is directed to certain situations to sequential reads. This concept allows to drop parts of the cache that were already used, which will reduce the size of cache and the number of displaced nodes. Signed-off-by: Pavel Butsykin --- block/pcache.c | 12 1 file changed, 12 i

Re: [Qemu-devel] Qemu 2.6 => Qemu 2.7 migration: error while loading state for instance 0x0 of device '0000:00:03.0/virtio-balloon'

2016-11-15 Thread Stefan Priebe - Profihost AG
Am 15.11.2016 um 12:07 schrieb Ladi Prosek: > Hi, > > On Tue, Nov 15, 2016 at 11:37 AM, Stefan Priebe - Profihost AG > wrote: >> Hello, >> >> Am 15.11.2016 um 11:30 schrieb Dr. David Alan Gilbert: >>> * Stefan Priebe - Profihost AG (s.pri...@profihost.ag) wrote: Hello, today i did

[Qemu-devel] [PATCH v1 11/18] block/pcache: cache invalidation on AIO write requests

2016-11-15 Thread Pavel Butsykin
In AIO write request completion we just drop all the intersecting nodes in the cache, it's a simple way to keep the cache up-to-date. Signed-off-by: Pavel Butsykin --- block/pcache.c | 39 ++- 1 file changed, 38 insertions(+), 1 deletion(-) diff --git a/block

[Qemu-devel] [PATCH v1 12/18] block/pcache: add reading data from the cache

2016-11-15 Thread Pavel Butsykin
Added read_cache_data() allowing to read data from node to qiov. And the simplest use case - read data from node provided that the node is not in flight and fully covers read request. Signed-off-by: Pavel Butsykin --- block/pcache.c | 91 +++--

[Qemu-devel] [PATCH v1 17/18] block/pcache: add tracepoints

2016-11-15 Thread Pavel Butsykin
Signed-off-by: Pavel Butsykin --- block/pcache.c | 21 + block/trace-events | 9 + 2 files changed, 30 insertions(+) diff --git a/block/pcache.c b/block/pcache.c index a592ea0..1821557 100644 --- a/block/pcache.c +++ b/block/pcache.c @@ -14,6 +14,7 @@ #include "

Re: [Qemu-devel] [Qemu-block] [PULL for-2.8 00/13] Block patches for 2.8

2016-11-15 Thread Stefan Hajnoczi
On Mon, Nov 14, 2016 at 11:14:38PM -0500, Jeff Cody wrote: > The following changes since commit 682df581c65ed2c1b9e77093e332214ecaa1ee93: > > Merge remote-tracking branch 'jsnow/tags/ide-pull-request' into staging > (2016-11-14 17:07:16 +) > > are available in the git repository at: > >

Re: [Qemu-devel] QEMU postcopy-test failing on ppc64

2016-11-15 Thread Stefan Hajnoczi
On Tue, Nov 15, 2016 at 10:09 AM, Greg Kurz wrote: > On Tue, 15 Nov 2016 10:53:35 +0100 > Laurent Vivier wrote: > >> On 14/11/2016 21:52, Stefan Hajnoczi wrote: >> > I hit a failure running "make check" on ppc64 for the first time. Ideas? >> > >> > Stefan >> > >> > commit 682df581c65ed2c1b9e7709

Re: [Qemu-devel] [PULL V3 0/3] Net patches

2016-11-15 Thread Stefan Hajnoczi
On Tue, Nov 15, 2016 at 03:43:47PM +0800, Jason Wang wrote: > The following changes since commit 682df581c65ed2c1b9e77093e332214ecaa1ee93: > > Merge remote-tracking branch 'jsnow/tags/ide-pull-request' into staging > (2016-11-14 17:07:16 +) > > are available in the git repository at: > >

Re: [Qemu-devel] [PULL 00/19] ppc-for-2.8 queue 20161115

2016-11-15 Thread Stefan Hajnoczi
ble in the git repository at: > > git://github.com/dgibson/qemu.git tags/ppc-for-2.8-20161115 > > for you to fetch changes up to 859c397e57a4c0f8be2e2be011892b7d81b72e8c: > > boot-serial-test: Add a test for the

Re: [Qemu-devel] Help wanted: QEMU Advent Calendar 2016

2016-11-15 Thread Thomas Huth
Dear QEMU community, the website for the QEMU Advent Calendar 2016 is now online: http://www.qemu-advent-calendar.org/2016/ (thanks to Jeff Cody and Stefan Hajnoczi for the help with getting started!) Note that we still need some more disk images to be able to complete the calendar this year,

[Qemu-devel] [PATCH v1 18/18] block/pcache: debug build

2016-11-15 Thread Pavel Butsykin
This debug patch will help to identify problems with the leakage of the cache memory. Signed-off-by: Pavel Butsykin --- block/pcache.c | 36 +--- 1 file changed, 33 insertions(+), 3 deletions(-) diff --git a/block/pcache.c b/block/pcache.c index 1821557..7c3a71b

[Qemu-devel] [PATCH v1 01/18] block/io: add bdrv_aio_{preadv, pwritev}

2016-11-15 Thread Pavel Butsykin
It's just byte-based wrappers over bdrv_co_aio_prw_vector(), which provide a byte-based interface for AIO read/write. Signed-off-by: Pavel Butsykin --- block/io.c| 16 include/block/block.h | 7 +++ 2 files changed, 23 insertions(+) diff --git a/block/io.c b/b

[Qemu-devel] [PATCH v1 09/18] block/pcache: add AIO readahead

2016-11-15 Thread Pavel Butsykin
This patch adds readahead data to the cache. Here the readahead is a separate asynchronous request, which doesn't depend on completion of filtered read requests. The readahead is done only by the condition, if before the current request there's sequential read data enough size. This information can

[Qemu-devel] [PATCH for-2.8 v2 0/3] pc: remove redundant fw_cfg file "etc/boot-cpus"

2016-11-15 Thread Igor Mammedov
Changes since v1: revert commit 080ac219cc7d9 and redo FW_CFG_NB_CPUS fixes on top of it Commit 080ac219cc7d9c55adf925c3545b7450055ad625 pc: Add 'etc/boot-cpus' fw_cfg file for machine with more than 255 CPUs added "etc/boot-cpus" fw_cfg file durung 2.8 merge window, however QEMU alredy ha

[Qemu-devel] [PATCH for-2.8 v2 3/3] pc: fix FW_CFG_NB_CPUS to account for -device added CPUs

2016-11-15 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- include/hw/i386/pc.h | 2 ++ hw/i386/pc.c | 42 +- 2 files changed, 27 insertions(+), 17 deletions(-) diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h index e32e957..67a1a9e 100644 --- a/include/hw/i386/pc.

[Qemu-devel] [PATCH for-2.8 v2 1/3] Revert "pc: Add 'etc/boot-cpus' fw_cfg file for machine with more than 255 CPUs"

2016-11-15 Thread Igor Mammedov
This reverts commit 080ac219cc7d9c55adf925c3545b7450055ad625. Legacy FW_CFG_NB_CPUS will be reused instead of 'etc/boot-cpus' fw_cfg file since it does the same and there is no point to maintaing duplicate guest ABI, if it can be helped. Signed-off-by: Igor Mammedov --- include/hw/i386/pc.h |

[Qemu-devel] [PATCH for-2.8 v2 2/3] fw_cfg: move FW_CFG_NB_CPUS out of fw_cfg_init1()

2016-11-15 Thread Igor Mammedov
PC will use this field in other way, so move it outside the common code so PC could set a different value, i.e. all CPUs regardless of where they are coming from (-smp X | -device cpu...). It's quick and dirty hack as it could be implemented in more generic way in MashineClass. But do it in simple

Re: [Qemu-devel] QEMU postcopy-test failing on ppc64

2016-11-15 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@gmail.com) wrote: > On Tue, Nov 15, 2016 at 10:09 AM, Greg Kurz wrote: > > On Tue, 15 Nov 2016 10:53:35 +0100 > > Laurent Vivier wrote: > > > >> On 14/11/2016 21:52, Stefan Hajnoczi wrote: > >> > I hit a failure running "make check" on ppc64 for the first time. Ideas?

Re: [Qemu-devel] [PATCH v6 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2016-11-15 Thread Fam Zheng
On Tue, 11/15 10:18, Stefan Hajnoczi wrote: > Fam, Markus: Unfortunately neither the clean-includes script nor its > patch series cover letter explains *why* osdep.h should be included > before system headers. I don't know Peter's exact intention either, but AFAICT it is about the few quirks in os

Re: [Qemu-devel] Qemu 2.6 => Qemu 2.7 migration: error while loading state for instance 0x0 of device '0000:00:03.0/virtio-balloon'

2016-11-15 Thread Ladi Prosek
On Tue, Nov 15, 2016 at 12:19 PM, Stefan Priebe - Profihost AG wrote: > Am 15.11.2016 um 12:07 schrieb Ladi Prosek: >> Hi, >> >> On Tue, Nov 15, 2016 at 11:37 AM, Stefan Priebe - Profihost AG >> wrote: >>> Hello, >>> >>> Am 15.11.2016 um 11:30 schrieb Dr. David Alan Gilbert: * Stefan Priebe

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.8] block: Let write zeroes fallback work even with small max_transfer

2016-11-15 Thread Stefan Hajnoczi
On Mon, Nov 14, 2016 at 09:50:33AM -0600, Eric Blake wrote: > On 11/10/2016 02:03 AM, Kevin Wolf wrote: > > > Test case: > > > > $ qemu-img create -f qcow2 -o cluster_size=1M file 10M > > $ losetup /dev/loop2 /path/to/file > > $ qemu-io -f qcow2 /dev/loop2 > > qemu-io> w 7m

Re: [Qemu-devel] QEMU postcopy-test failing on ppc64

2016-11-15 Thread Laurent Vivier
On 15/11/2016 13:20, Dr. David Alan Gilbert wrote: > * Stefan Hajnoczi (stefa...@gmail.com) wrote: >> On Tue, Nov 15, 2016 at 10:09 AM, Greg Kurz wrote: >>> On Tue, 15 Nov 2016 10:53:35 +0100 >>> Laurent Vivier wrote: >>> On 14/11/2016 21:52, Stefan Hajnoczi wrote: > I hit a failure ru

Re: [Qemu-devel] [PATCH v1] qemu: command: rework cpu feature argument support

2016-11-15 Thread Eduardo Habkost
CCing qemu-devel. CCing Markus, in case he has any insights about the interface introspection. On Tue, Nov 15, 2016 at 08:42:12AM +0100, Jiri Denemark wrote: > On Mon, Nov 14, 2016 at 18:02:29 -0200, Eduardo Habkost wrote: > > On Mon, Nov 14, 2016 at 02:26:03PM -0500, Collin L. Walling wrote: > >

[Qemu-devel] [PATCH for-2.8 0/3] virtio fixes

2016-11-15 Thread Paolo Bonzini
Patch 1 fixes vhost, patches 2-3 fix Windows hibernation. Paolo Paolo Bonzini (3): virtio: introduce grab/release_ioeventfd to fix vhost virtio: access ISR atomically virtio: set ISR on dataplane notifications hw/block/dataplane/virtio-blk.c | 4 +-- hw/scsi/virtio-scsi-dataplane.c | 7

[Qemu-devel] [PATCH 3/3] virtio: set ISR on dataplane notifications

2016-11-15 Thread Paolo Bonzini
Dataplane has been omitting forever the step of setting ISR when an interrupt is raised. This causes surprisingly little breakage, because most polling-mode drivers look at the used ring's index field rather than the ISR register. Some versions of the Windows drivers are an exception---and they u

[Qemu-devel] [PATCH 1/3] virtio: introduce grab/release_ioeventfd to fix vhost

2016-11-15 Thread Paolo Bonzini
Following the recent refactoring of virtio notifiers [1], more specifically the patch ed08a2a0b ("virtio: use virtio_bus_set_host_notifier to start/stop ioeventfd") that uses virtio_bus_set_host_notifier [2] by default, core virtio code requires 'ioeventfd_started' to be set to true/false when the

[Qemu-devel] [PATCH 2/3] virtio: access ISR atomically

2016-11-15 Thread Paolo Bonzini
This will be needed once dataplane will be able to set it outside the big QEMU lock. Signed-off-by: Paolo Bonzini --- hw/virtio/virtio-mmio.c | 6 +++--- hw/virtio/virtio-pci.c | 9 +++-- hw/virtio/virtio.c | 18 +- 3 files changed, 19 insertions(+), 14 deletions(-)

Re: [Qemu-devel] [PATCH v2] hw/isa/lpc_ich9: inject SMI on all VCPUs if APM_STS == 'Q'

2016-11-15 Thread Paolo Bonzini
On 15/11/2016 02:50, Laszlo Ersek wrote: > The generic edk2 SMM infrastructure prefers > EFI_SMM_CONTROL2_PROTOCOL.Trigger() to inject an SMI on each processor. If > Trigger() only brings the current processor into SMM, then edk2 handles it > in the following ways: > > (1) If Trigger() is execut

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH qemu] spapr_pci: Create PCI-express root bus by default

2016-11-15 Thread Andrea Bolognani
On Tue, 2016-11-01 at 13:46 +1100, David Gibson wrote: > On Mon, Oct 31, 2016 at 03:10:23PM +1100, Alexey Kardashevskiy wrote: > >  > > On 31/10/16 13:53, David Gibson wrote: > > >  > > > On Fri, Oct 28, 2016 at 12:07:12PM +0200, Greg Kurz wrote: > > > >  > > > > On Fri, 28 Oct 2016 18:56:40 +1100

Re: [Qemu-devel] [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

2016-11-15 Thread Michael S. Tsirkin
On Tue, Nov 15, 2016 at 02:50:11PM +0900, Namhyung Kim wrote: > On Tue, Nov 15, 2016 at 07:06:28AM +0200, Michael S. Tsirkin wrote: > > On Tue, Nov 15, 2016 at 01:50:21PM +0900, Namhyung Kim wrote: > > > On Thu, Nov 10, 2016 at 06:39:55PM +0200, Michael S. Tsirkin wrote: > > > [SNIP] > > > > > +str

Re: [Qemu-devel] [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

2016-11-15 Thread Namhyung Kim
Hi, On Tue, Nov 15, 2016 at 10:57:29AM +0100, Paolo Bonzini wrote: > > > On 15/11/2016 06:06, Michael S. Tsirkin wrote: > > On Tue, Nov 15, 2016 at 01:50:21PM +0900, Namhyung Kim wrote: > >> Hi Michael, > >> > >> On Thu, Nov 10, 2016 at 06:39:55PM +0200, Michael S. Tsirkin wrote: > >>> On Sat, A

Re: [Qemu-devel] [PATCH 2/3] qemu: Implement virtio-pstore device

2016-11-15 Thread Michael S. Tsirkin
On Tue, Nov 15, 2016 at 03:23:36PM +0900, Namhyung Kim wrote: > On Fri, Nov 11, 2016 at 12:50:03AM +0200, Michael S. Tsirkin wrote: > > On Fri, Sep 16, 2016 at 07:05:47PM +0900, Namhyung Kim wrote: > > > On Tue, Sep 13, 2016 at 06:57:10PM +0300, Michael S. Tsirkin wrote: > > > > On Sat, Aug 20, 201

Re: [Qemu-devel] virsh dump (qemu guest memory dump?): KASLR enabled linux guest support

2016-11-15 Thread Dave Anderson
- Original Message - > > > On 09/11/2016 16:28, Dave Anderson wrote: > > I'm not sure whether this "guest userspace agent" is still in play here, > > but if there were such a thing, it could theoretically do the same > > thing that crash currently does when running on a live system. > >

Re: [Qemu-devel] [PATCH v6 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2016-11-15 Thread Stefan Hajnoczi
On Tue, Nov 15, 2016 at 08:44:17PM +0800, Fam Zheng wrote: > On Tue, 11/15 10:18, Stefan Hajnoczi wrote: > > Fam, Markus: Unfortunately neither the clean-includes script nor its > > patch series cover letter explains *why* osdep.h should be included > > before system headers. > > I don't know Pete

Re: [Qemu-devel] [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

2016-11-15 Thread Paolo Bonzini
On 15/11/2016 15:36, Namhyung Kim wrote: > Hi, > > On Tue, Nov 15, 2016 at 10:57:29AM +0100, Paolo Bonzini wrote: >> >> >> On 15/11/2016 06:06, Michael S. Tsirkin wrote: >>> On Tue, Nov 15, 2016 at 01:50:21PM +0900, Namhyung Kim wrote: Hi Michael, On Thu, Nov 10, 2016 at 06:39:55P

Re: [Qemu-devel] QEMU postcopy-test failing on ppc64

2016-11-15 Thread Stefan Hajnoczi
On Tue, Nov 15, 2016 at 01:58:38PM +0100, Laurent Vivier wrote: > > > On 15/11/2016 13:20, Dr. David Alan Gilbert wrote: > > * Stefan Hajnoczi (stefa...@gmail.com) wrote: > >> On Tue, Nov 15, 2016 at 10:09 AM, Greg Kurz wrote: > >>> On Tue, 15 Nov 2016 10:53:35 +0100 > >>> Laurent Vivier wrote:

Re: [Qemu-devel] QEMU postcopy-test failing on ppc64

2016-11-15 Thread Greg Kurz
On Tue, 15 Nov 2016 11:14:57 + Stefan Hajnoczi wrote: > On Tue, Nov 15, 2016 at 10:09 AM, Greg Kurz wrote: > > On Tue, 15 Nov 2016 10:53:35 +0100 > > Laurent Vivier wrote: > > > >> On 14/11/2016 21:52, Stefan Hajnoczi wrote: > >> > I hit a failure running "make check" on ppc64 for the f

Re: [Qemu-devel] [PATCH v6 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2016-11-15 Thread Fam Zheng
On Tue, 11/15 14:45, Stefan Hajnoczi wrote: > On Tue, Nov 15, 2016 at 08:44:17PM +0800, Fam Zheng wrote: > > On Tue, 11/15 10:18, Stefan Hajnoczi wrote: > > > Fam, Markus: Unfortunately neither the clean-includes script nor its > > > patch series cover letter explains *why* osdep.h should be includ

Re: [Qemu-devel] [PATCH for-2.8 0/3] virtio fixes

2016-11-15 Thread Stefan Hajnoczi
On Tue, Nov 15, 2016 at 02:46:26PM +0100, Paolo Bonzini wrote: > Patch 1 fixes vhost, patches 2-3 fix Windows hibernation. > > Paolo > > Paolo Bonzini (3): > virtio: introduce grab/release_ioeventfd to fix vhost > virtio: access ISR atomically > virtio: set ISR on dataplane notifications >

Re: [Qemu-devel] QEMU postcopy-test failing on ppc64

2016-11-15 Thread Greg Kurz
On Tue, 15 Nov 2016 14:48:30 + Stefan Hajnoczi wrote: > On Tue, Nov 15, 2016 at 01:58:38PM +0100, Laurent Vivier wrote: > > > > > > On 15/11/2016 13:20, Dr. David Alan Gilbert wrote: > > > * Stefan Hajnoczi (stefa...@gmail.com) wrote: > > >> On Tue, Nov 15, 2016 at 10:09 AM, Greg Kurz

Re: [Qemu-devel] [PATCH 2/3] virtio: access ISR atomically

2016-11-15 Thread Christian Borntraeger
On 11/15/2016 02:46 PM, Paolo Bonzini wrote: > This will be needed once dataplane will be able to set it outside > the big QEMU lock. > > Signed-off-by: Paolo Bonzini This is fixed by the followup patch, but this patch alone gives me /home/cborntra/REPOS/qemu/hw/virtio/virtio.c: In function ‘v

Re: [Qemu-devel] [PATCH 2/3] virtio: access ISR atomically

2016-11-15 Thread Paolo Bonzini
On 15/11/2016 16:03, Christian Borntraeger wrote: > On 11/15/2016 02:46 PM, Paolo Bonzini wrote: >> This will be needed once dataplane will be able to set it outside >> the big QEMU lock. >> >> Signed-off-by: Paolo Bonzini > > This is fixed by the followup patch, but this patch alone gives me >

Re: [Qemu-devel] [PATCH v12 05/22] vfio iommu: Added pin and unpin callback functions to vfio_iommu_driver_ops

2016-11-15 Thread Kirti Wankhede
On 11/15/2016 1:13 AM, Alex Williamson wrote: > On Mon, 14 Nov 2016 21:12:19 +0530 > Kirti Wankhede wrote: > >> Added APIs for pining and unpining set of pages. These call back into >> backend iommu module to actually pin and unpin pages. >> Added two new callback functions to struct vfio_iommu

  1   2   3   >