[Qemu-devel] [PATCH v12 17/22] vfio_platform: Updated to use vfio_set_irqs_validate_and_prepare()

2016-11-14 Thread Kirti Wankhede
Updated vfio_platform_common.c file to use vfio_set_irqs_validate_and_prepare() Signed-off-by: Kirti Wankhede Signed-off-by: Neo Jia Change-Id: Id87cd6b78ae901610b39bf957974baa6f40cd7b0 --- drivers/vfio/platform/vfio_platform_common.c | 31 +++- 1 file changed, 8 inserti

[Qemu-devel] [PATCH v12 10/22] vfio iommu type1: Add support for mediated devices

2016-11-14 Thread Kirti Wankhede
VFIO IOMMU drivers are designed for the devices which are IOMMU capable. Mediated device only uses IOMMU APIs, the underlying hardware can be managed by an IOMMU domain. Aim of this change is: - To use most of the code of TYPE1 IOMMU driver for mediated devices - To support direct assigned device

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.8] block: Let write zeroes fallback work even with small max_transfer

2016-11-14 Thread Eric Blake
On 11/10/2016 02:03 AM, Kevin Wolf wrote: > Test case: > > $ qemu-img create -f qcow2 -o cluster_size=1M file 10M > $ losetup /dev/loop2 /path/to/file > $ qemu-io -f qcow2 /dev/loop2 > qemu-io> w 7m 1k > qemu-io> w -z 8003584 2093056 Please include a qemu-iote

[Qemu-devel] [PATCH v12 12/22] vfio: Add notifier callback to parent's ops structure of mdev

2016-11-14 Thread Kirti Wankhede
Add a notifier calback to parent's ops structure of mdev device so that per device notifer for vfio module is registered through vfio_mdev module. Signed-off-by: Kirti Wankhede Signed-off-by: Neo Jia Change-Id: Iafa6f1721aecdd6e50eb93b153b5621e6d29b637 --- drivers/vfio/mdev/vfio_mdev.c | 19 +++

Re: [Qemu-devel] [PULL v2 00/34] virtio, vhost, pc, pci: tests, documentation, fixes and cleanups

2016-11-14 Thread Stefan Hajnoczi
On Fri, Nov 11, 2016 at 08:09:58PM +0200, Michael S. Tsirkin wrote: > libvhost-user is the only thing that might be controvertial here, but it's > only > affecting contrib/ and tests so I think it's still fair game, and several > people were asking for it. I am being firm about the freeze policy.

[Qemu-devel] [PATCH v12 14/22] vfio_pci: Update vfio_pci to use vfio_info_add_capability()

2016-11-14 Thread Kirti Wankhede
Update msix_sparse_mmap_cap() to use vfio_info_add_capability() Update region type capability to use vfio_info_add_capability() Signed-off-by: Kirti Wankhede Signed-off-by: Neo Jia Change-Id: I52bb28c7875a6da5a79ddad1843e6088aff58a45 --- drivers/vfio/pci/vfio_pci.c | 49 ++--

[Qemu-devel] [PATCH v12 15/22] vfio: Introduce vfio_set_irqs_validate_and_prepare()

2016-11-14 Thread Kirti Wankhede
Vendor driver using mediated device framework would use same mechnism to validate and prepare IRQs. Introducing this function to reduce code replication in multiple drivers. Signed-off-by: Kirti Wankhede Signed-off-by: Neo Jia Change-Id: Ie201f269dda0713ca18a07dc4852500bd8b48309 --- drivers/vfi

[Qemu-devel] [Bug 1641637] [NEW] incorrect illegal SSE3 instructions reporting on x86_64

2016-11-14 Thread Jie
Public bug reported: Hi all, we found 28 differently encoded illegal SSE3 instructions reporting on the most recent x86_64 user mode linux qemu (version 2.7.0). We believe these reporting should be incorrect because the same code can be executed on a real machine. The instructions are the followin

Re: [Qemu-devel] Assertion failure on qcow2 disk with cluster_size != 64k

2016-11-14 Thread Eric Blake
On 11/14/2016 03:50 AM, Kevin Wolf wrote: > Am 24.10.2016 um 22:32 hat Eric Blake geschrieben: >> On 10/21/2016 08:14 AM, Ed Swierk wrote: >>> On Thu, Oct 20, 2016 at 6:38 PM, Eric Blake wrote: On 10/20/2016 07:24 PM, Ed Swierk wrote: > Changing max_transfer in the normal write case to >>

Re: [Qemu-devel] TCP performance problems - GSO/TSO, MSS, 8139cp related

2016-11-14 Thread Stefan Hajnoczi
On Mon, Nov 14, 2016 at 09:29:48AM +, Dr. David Alan Gilbert wrote: > * Russell King - ARM Linux (li...@armlinux.org.uk) wrote: > > On Fri, Nov 11, 2016 at 09:23:43PM +, David Woodhouse wrote: > > > It's also *fairly* unlikely that the kernel in the guest has developed > > > a bug and isn't

[Qemu-devel] [PULL v2 0/9] Ide patches

2016-11-14 Thread John Snow
The following changes since commit 83c83f9a5266ff113060f887f106a47920fa6974: Merge remote-tracking branch 'bonzini/tags/for-upstream' into staging (2016-11-11 12:51:50 +) are available in the git repository at: https://github.com/jnsnow/qemu.git tags/ide-pull-request for you to fetch c

[Qemu-devel] [PULL v2 1/9] atapi: classify read_cd as conditionally returning data

2016-11-14 Thread John Snow
For the purposes of byte_count_limit verification, add a new flag that identifies read_cd as sometimes returning data, then check the BCL in its command handler after we know that it will indeed return data. Reported-by: Hervé Poussineau Signed-off-by: John Snow Reviewed-by: Kevin Wolf Message-

Re: [Qemu-devel] Assertion failure on qcow2 disk with cluster_size != 64k

2016-11-14 Thread Kevin Wolf
Am 14.11.2016 um 16:46 hat Eric Blake geschrieben: > On 11/14/2016 03:50 AM, Kevin Wolf wrote: > > Am 24.10.2016 um 22:32 hat Eric Blake geschrieben: > >> On 10/21/2016 08:14 AM, Ed Swierk wrote: > >>> On Thu, Oct 20, 2016 at 6:38 PM, Eric Blake wrote: > On 10/20/2016 07:24 PM, Ed Swierk wrot

[Qemu-devel] [PULL v2 2/9] ahci-test: Create smaller test ISO images

2016-11-14 Thread John Snow
These can simply be the size of the number of sectors we're reading, plus one for a buffer. We don't need them to be any larger. Signed-off-by: John Snow Reviewed-by: Kevin Wolf Message-id: 1477970211-25754-3-git-send-email-js...@redhat.com Signed-off-by: John Snow --- tests/ahci-test.c | 3 ++

[Qemu-devel] [PULL v2 6/9] libqos/ahci: Support expected errors

2016-11-14 Thread John Snow
Sometimes we know we'll get back an error, so let's have the test framework understand that. Signed-off-by: John Snow Reviewed-by: Kevin Wolf Message-id: 1478553214-497-4-git-send-email-js...@redhat.com Signed-off-by: John Snow --- tests/libqos/ahci.c | 16 tests/libqos/ahci.h

[Qemu-devel] [PULL v2 7/9] libqos/ahci: Add ATAPI tray macros

2016-11-14 Thread John Snow
(1) Add START_STOP_UNIT command to ahci-test suite (2) Add eject/start macro commands; this is not a data transfer command so it is not well-served by the existing generic pipeline. Signed-off-by: John Snow Reviewed-by: Kevin Wolf Message-id: 1478553214-497-5-git-send-email-js...@redhat.com

[Qemu-devel] [PULL v2 5/9] libqtest: add qmp_eventwait_ref

2016-11-14 Thread John Snow
Wait for an event, but return a copy so we can investigate parameters. Signed-off-by: John Snow Reviewed-by: Eric Blake Reviewed-by: Kevin Wolf Message-id: 1478553214-497-3-git-send-email-js...@redhat.com Signed-off-by: John Snow --- tests/libqtest.c | 13 ++--- tests/libqtest.h | 22

Re: [Qemu-devel] [PATCH] slirp: Fix access to freed memory

2016-11-14 Thread Stefan Hajnoczi
On Mon, Nov 14, 2016 at 12:01:02AM +0100, Samuel Thibault wrote: > if_start() goes through the slirp->if_fastq and slirp->if_batchq > list of pending messages, and accesses ifm->ifq_so->so_nqueued of its > elements if ifm->ifq_so != NULL. When freeing a socket, we thus need > to make sure that any

[Qemu-devel] [PULL v2 4/9] block-backend: Always notify on blk_eject

2016-11-14 Thread John Snow
blk_eject is only used by scsi-disk and atapi, and in both cases we only attempt to invoke blk_eject if we have a bona-fide change in tray state. The "issue" here is that the tray state does not generate a QMP event unless there is a medium/BDS attached to the device, so if libvirt et al are waiti

[Qemu-devel] [PULL v2 3/9] ahci-test: test atapi read_cd with bcl, nb_sectors = 0

2016-11-14 Thread John Snow
Commit 9ef2e93f introduced the concept of tagging ATAPI commands as NONDATA, but this introduced a regression for certain commands better described as CONDDATA. read_cd is such a command that both requires a non-zero BCL if a transfer size is set, but is perfectly content to accept a zero BCL if th

Re: [Qemu-devel] virtIO question

2016-11-14 Thread Stefan Hajnoczi
On Mon, Nov 14, 2016 at 08:36:39PM +0800, zhun...@gmail.com wrote: > I have a question about qemu.is it a bug in qemu version 1.2? > in qemu version 1.2 ,it set avail event by the code : > if (vq->vdev->guest_features & (1 << VIRTIO_RING_F_EVENT_IDX)) { > vring_avail_event(vq, vring_avail_

Re: [Qemu-devel] [PATCH] tcg/mips: Add support for mips64el backend

2016-11-14 Thread Aurelien Jarno
Hi, On 2016-11-14 17:33, Jin Guojie wrote: > Richard, > > I have studied your V2 patch > > https://lists.nongnu.org/archive/html/qemu-devel/2016-02/msg02969.html > > . Though I have not tested this patch on Loongson machine, I feel this > patch has implemented MIPS64 ISA very completely, inclu

Re: [Qemu-devel] [PULL V2 0/3] Net patches

2016-11-14 Thread Stefan Hajnoczi
On Mon, Nov 14, 2016 at 10:54:23AM +0800, Jason Wang wrote: > Pavel Dovgalyuk (1): > record/replay: add network support QEMU is in soft freeze. The policy has changed this release and only bug fixes are being accepted during soft freeze. Please don't include new features. http://qemu-proj

[Qemu-devel] [PULL v2 8/9] libqos/ahci: Add get_sense and test_ready

2016-11-14 Thread John Snow
Required for tray tests once a medium may have changed. Signed-off-by: John Snow Reviewed-by: Kevin Wolf Message-id: 1478553214-497-6-git-send-email-js...@redhat.com [Line length edit --js] Signed-off-by: John Snow --- tests/libqos/ahci.c | 50 ++

[Qemu-devel] [Bug 1563152] Re: general protection fault running VirtualBox in KVM guest

2016-11-14 Thread Launchpad Bug Tracker
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: qemu (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1563152 Title: gene

[Qemu-devel] [PULL v2 9/9] ahci-test: add QMP tray test for ATAPI

2016-11-14 Thread John Snow
Test QMP events for a CDROM device with or without a media inserted, including both guest-initiated and hw-initiated eject/load requests. Signed-off-by: John Snow Reviewed-by: Kevin Wolf Message-id: 1478553214-497-7-git-send-email-js...@redhat.com Signed-off-by: John Snow --- tests/ahci-test.c

Re: [Qemu-devel] [qemu patch 2/2] kvmclock: reduce kvmclock difference on migration

2016-11-14 Thread Paolo Bonzini
On 14/11/2016 16:40, Marcelo Tosatti wrote: > static bool kvmclock_src_use_reliable_get_clock(void *opaque) > { > KVMClockState *s = opaque; > > /* > * On machine types that support reliable KVM_GET_CLOCK, > * if host kernel does provide reliable KVM_GET_CLOCK, > * set src

Re: [Qemu-devel] [PATCH v6 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2016-11-14 Thread Stefan Hajnoczi
On Mon, Nov 14, 2016 at 11:49:06PM +0800, Fam Zheng wrote: > On Mon, 11/14 15:07, Stefan Hajnoczi wrote: > > On Mon, Nov 07, 2016 at 04:59:44PM -0800, Ashish Mittal wrote: > > > diff --git a/block/vxhs.c b/block/vxhs.c > > > new file mode 100644 > > > index 000..8913e8f > > > --- /dev/null > >

Re: [Qemu-devel] [RFC 0/3] aio: experimental virtio-blk polling mode

2016-11-14 Thread Stefan Hajnoczi
On Mon, Nov 14, 2016 at 03:59:32PM +0100, Christian Borntraeger wrote: > On 11/09/2016 06:13 PM, Stefan Hajnoczi wrote: > > Recent performance investigation work done by Karl Rister shows that the > > guest->host notification takes around 20 us. This is more than the > > "overhead" > > of QEMU it

Re: [Qemu-devel] [PATCH 0/3] add cleanup operation in handle/proxy backend

2016-11-14 Thread Greg Kurz
Hi Li, On Mon, 14 Nov 2016 07:32:55 -0500 Li Qiang wrote: > From: Li Qiang > > Currently, the backend of VirtFS doesn't have a cleanup > function. This will leak some resources in handle and proxy > backend driver. This patchset addresses this issue. > > Li Qiang (3): > 9pfs: add cleanup op

Re: [Qemu-devel] [RFC 0/3] aio: experimental virtio-blk polling mode

2016-11-14 Thread Stefan Hajnoczi
On Mon, Nov 14, 2016 at 03:51:18PM +0100, Christian Borntraeger wrote: > On 11/09/2016 06:13 PM, Stefan Hajnoczi wrote: > > Recent performance investigation work done by Karl Rister shows that the > > guest->host notification takes around 20 us. This is more than the > > "overhead" > > of QEMU it

Re: [Qemu-devel] [PULL v2 0/9] Ide patches

2016-11-14 Thread John Snow
On 11/14/2016 11:59 AM, no-re...@patchew.org wrote: Hi, Your series seems to have some coding style problems. See output below for more information: All failures below are intentional deviations. Type: series Subject: [Qemu-devel] [PULL v2 0/9] Ide patches Message-id: 1479140746-22142-1-g

Re: [Qemu-devel] [RFC 0/3] aio: experimental virtio-blk polling mode

2016-11-14 Thread Stefan Hajnoczi
On Mon, Nov 14, 2016 at 08:52:21AM -0600, Karl Rister wrote: > On 11/14/2016 07:53 AM, Fam Zheng wrote: > > On Fri, 11/11 13:59, Karl Rister wrote: > >> > >> Stefan > >> > >> I ran some quick tests with your patches and got some pretty good gains, > >> but also some seemingly odd behavior. > >> > >

Re: [Qemu-devel] Assertion failure on qcow2 disk with cluster_size != 64k

2016-11-14 Thread Eric Blake
On 11/14/2016 09:54 AM, Kevin Wolf wrote: Our qcow2 support is currently limited to a maximum of 2M clusters; while MAX_WRITE_ZEROES_BOUNCE_BUFFER is 32k * 512, or 16M. The maximum-size bounce buffer should not be the problem here; but for some reason, it looks like alignment

Re: [Qemu-devel] [PULL v2 0/9] Ide patches

2016-11-14 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PULL v2 0/9] Ide patches Message-id: 1479140746-22142-1-git-send-email-js...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --onel

Re: [Qemu-devel] [PULL v2 0/9] Ide patches

2016-11-14 Thread Stefan Hajnoczi
On Mon, Nov 14, 2016 at 11:25:37AM -0500, John Snow wrote: > The following changes since commit 83c83f9a5266ff113060f887f106a47920fa6974: > > Merge remote-tracking branch 'bonzini/tags/for-upstream' into staging > (2016-11-11 12:51:50 +) > > are available in the git repository at: > > h

Re: [Qemu-devel] [RFC 0/3] aio: experimental virtio-blk polling mode

2016-11-14 Thread Fam Zheng
On Mon, 11/14 17:06, Stefan Hajnoczi wrote: > On Mon, Nov 14, 2016 at 04:29:49PM +0100, Paolo Bonzini wrote: > > On 14/11/2016 16:26, Stefan Hajnoczi wrote: > > > On Fri, Nov 11, 2016 at 01:59:25PM -0600, Karl Rister wrote: > > >> QEMU_AIO_POLL_MAX_NS IOPs > > >>unset31,383

Re: [Qemu-devel] [RFC 0/3] aio: experimental virtio-blk polling mode

2016-11-14 Thread Stefan Hajnoczi
On Mon, Nov 14, 2016 at 04:29:49PM +0100, Paolo Bonzini wrote: > On 14/11/2016 16:26, Stefan Hajnoczi wrote: > > On Fri, Nov 11, 2016 at 01:59:25PM -0600, Karl Rister wrote: > >> QEMU_AIO_POLL_MAX_NS IOPs > >>unset31,383 > >>146,860 > >>

Re: [Qemu-devel] [PATCH 07/13] virtio-scsi: always use dataplane path if ioeventfd is active

2016-11-14 Thread Alex Williamson
On Mon, 14 Nov 2016 14:41:42 +0100 Paolo Bonzini wrote: > On 11/11/2016 22:03, Alex Williamson wrote: > > On Fri, 11 Nov 2016 21:24:33 +0100 > > Paolo Bonzini wrote: > >> If you can post a backtrace of all threads at the time of the hang, from > >> origin/master (so without vhost, and not at a

Re: [Qemu-devel] [qemu patch 2/2] kvmclock: reduce kvmclock difference on migration

2016-11-14 Thread Marcelo Tosatti
On Mon, Nov 14, 2016 at 05:43:33PM +0100, Paolo Bonzini wrote: > > > On 14/11/2016 16:40, Marcelo Tosatti wrote: > > static bool kvmclock_src_use_reliable_get_clock(void *opaque) > > { > > KVMClockState *s = opaque; > > > > /* > > * On machine types that support reliable KVM_GET_CLO

Re: [Qemu-devel] [RFC 0/3] aio: experimental virtio-blk polling mode

2016-11-14 Thread Paolo Bonzini
On 14/11/2016 18:06, Stefan Hajnoczi wrote: >>> > > Very interesting that QEMU_AIO_POLL_MAX_NS=1 performs so well without >>> > > much CPU overhead. >> > >> > That basically means "avoid a syscall if you already know there's >> > something to do", so in retrospect it's not that surprising. Stil

Re: [Qemu-devel] [qemu patch 2/2] kvmclock: reduce kvmclock difference on migration

2016-11-14 Thread Paolo Bonzini
On 14/11/2016 18:13, Marcelo Tosatti wrote: > On Mon, Nov 14, 2016 at 05:43:33PM +0100, Paolo Bonzini wrote: >> >> >> On 14/11/2016 16:40, Marcelo Tosatti wrote: >>> static bool kvmclock_src_use_reliable_get_clock(void *opaque) >>> { >>> KVMClockState *s = opaque; >>> >>> /* >>> * On

Re: [Qemu-devel] [PATCH 1/3] 9pfs: add cleanup operation in FileOperations

2016-11-14 Thread Greg Kurz
On Mon, 14 Nov 2016 07:32:56 -0500 Li Qiang wrote: > From: Li Qiang > > Currently, the backend of VirtFS doesn't have a cleanup > function. This will lead resource leak issues if the backed > driver allocates resources. This patch addresses this issue. > > Signed-off-by: Li Qiang > --- > fsd

Re: [Qemu-devel] [PATCH 2/3] 9pfs: add cleanup operation for handle backend driver

2016-11-14 Thread Greg Kurz
On Mon, 14 Nov 2016 07:32:57 -0500 Li Qiang wrote: > From: Li Qiang > > In the init operation of handle backend dirver, it allocates a > handle_data struct and opens a mount file. We should free these > resources when the 9pfs device is unrealized. This is what this > patch does. > > Signed-of

Re: [Qemu-devel] [PATCH 3/3] 9pfs: add cleanup operation for proxy backend driver

2016-11-14 Thread Greg Kurz
On Mon, 14 Nov 2016 07:32:58 -0500 Li Qiang wrote: > From: Li Qiang > > In the init operation of proxy backend dirver, it allocates a > V9fsProxy struct and some other resources. We should free these > resources when the 9pfs device is unrealized. This is what this > patch does. > > Signed-off

[Qemu-devel] [RFC 1/2] qom/cpu: move tlb_flush to cpu_common_reset

2016-11-14 Thread Alex Bennée
It is a common thing amongst the various cpu reset functions want to flush the SoftMMU's TLB entries. This is done either by calling tlb_flush directly or by way of a general memset of the CPU structure (sometimes both). This moves the tlb_flush call to the common reset function and additionally e

[Qemu-devel] [RFC 0/2] Clean-up tlb_flush and cpu reset functions

2016-11-14 Thread Alex Bennée
Hi, These changes are cleanups for tlb_flush() and associated cpu reset functions. The first patch fixes up all vCPU reset functions to rely on the common reset code to issue a tlb_flush. This includes fixing up functions which blithely memset the TLB structures which upsets tsan in MTTCG. The se

[Qemu-devel] [RFC 2/2] cputlb: drop flush_global flag from tlb_flush

2016-11-14 Thread Alex Bennée
We have never has the concept of global TLB entries which would avoid the flush so we never actually use this flag. Drop it and make clear that tlb_flush is the sledge-hammer it has always been. Signed-off-by: Alex Bennée --- cputlb.c | 21 ++--- exec.c

Re: [Qemu-devel] [RFC 0/2] Clean-up tlb_flush and cpu reset functions

2016-11-14 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [RFC 0/2] Clean-up tlb_flush and cpu reset functions Message-id: 20161114174010.31040-1-alex.ben...@linaro.org === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PATCH V11 1/1] fsdev: add IO throttle support to fsdev devices

2016-11-14 Thread Greg Kurz
On Mon, 14 Nov 2016 10:03:40 +0100 Pradeep Jagadeesh wrote: > On 11/12/2016 3:13 PM, Greg Kurz wrote: > > On Fri, 11 Nov 2016 03:54:27 -0500 > > Pradeep Jagadeesh wrote: > > > >> Uses throttling APIs to limit I/O bandwidth and number of operations on the > >> devices which use 9p-local driver.

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-11-14 Thread ashish mittal
Will look into these ASAP. On Mon, Nov 14, 2016 at 7:05 AM, Stefan Hajnoczi wrote: > On Wed, Sep 28, 2016 at 10:45 PM, Stefan Hajnoczi wrote: >> On Tue, Sep 27, 2016 at 09:09:49PM -0700, Ashish Mittal wrote: >> >> Review of .bdrv_open() and .bdrv_aio_writev() code paths. >> >> The big issues I s

Re: [Qemu-devel] [PATCH v6 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2016-11-14 Thread Fam Zheng
On Mon, 11/14 16:50, Stefan Hajnoczi wrote: > On Mon, Nov 14, 2016 at 11:49:06PM +0800, Fam Zheng wrote: > > On Mon, 11/14 15:07, Stefan Hajnoczi wrote: > > > On Mon, Nov 07, 2016 at 04:59:44PM -0800, Ashish Mittal wrote: > > > > diff --git a/block/vxhs.c b/block/vxhs.c > > > > new file mode 100644

Re: [Qemu-devel] [PATCH 07/13] virtio-scsi: always use dataplane path if ioeventfd is active

2016-11-14 Thread Paolo Bonzini
On 14/11/2016 18:09, Alex Williamson wrote: > Hmm, fixed yet not fixed. I get a nice shutdown and it even eliminates > a cpu spike shown in virt-manager at the end of shutdown that was > typical previously, but then I noticed dmesg showing me segfaults, so I > hooked up gdb and: Well, that I do

Re: [Qemu-devel] [qemu patch 2/2] kvmclock: reduce kvmclock difference on migration

2016-11-14 Thread Marcelo Tosatti
On Mon, Nov 14, 2016 at 06:20:29PM +0100, Paolo Bonzini wrote: > > > On 14/11/2016 18:13, Marcelo Tosatti wrote: > > On Mon, Nov 14, 2016 at 05:43:33PM +0100, Paolo Bonzini wrote: > >> > >> > >> On 14/11/2016 16:40, Marcelo Tosatti wrote: > >>> static bool kvmclock_src_use_reliable_get_clock(void

Re: [Qemu-devel] [PATCH for-2.8] migration: Fix return code of ram_save_iterate()

2016-11-14 Thread Juan Quintela
Thomas Huth wrote: > qemu_savevm_state_iterate() expects the iterators to return 1 > when they are done, and 0 if there is still something left to do. > However, ram_save_iterate() does not obey this rule and returns > the number of saved pages instead. This causes a fatal hang with > ppc64 guests

Re: [Qemu-devel] [PATCH 07/13] virtio-scsi: always use dataplane path if ioeventfd is active

2016-11-14 Thread Alex Williamson
On Mon, 14 Nov 2016 19:10:54 +0100 Paolo Bonzini wrote: > On 14/11/2016 18:09, Alex Williamson wrote: > > Hmm, fixed yet not fixed. I get a nice shutdown and it even eliminates > > a cpu spike shown in virt-manager at the end of shutdown that was > > typical previously, but then I noticed dmesg

Re: [Qemu-devel] [PATCH for-2.8? 0/3] block/curl: Drop TFTP "support"

2016-11-14 Thread Jeff Cody
On Fri, Nov 11, 2016 at 08:46:11PM +0100, Max Reitz wrote: > On 09.11.2016 20:15, Jeff Cody wrote: > > On Tue, Nov 08, 2016 at 08:14:58AM +0100, Markus Armbruster wrote: > >> Max Reitz writes: > >> > >>> On 07.11.2016 09:20, Markus Armbruster wrote: > Max Reitz writes: > > > On 03.1

[Qemu-devel] Qemu 2.6 => Qemu 2.7 migration: error while loading state for instance 0x0 of device '0000:00:03.0/virtio-balloon'

2016-11-14 Thread Stefan Priebe - Profihost AG
Hello, today i did a first live migration from Qemu 2.6.2 to Qemu 2.7.0. The VM is running windows and virtio-balloon and with machine type pc-i440fx-2.5. The output of the target qemu process was: kvm_apic_post_load: Yeh kvm_apic_post_load: Yeh kvm_apic_post_load: Yeh kvm_apic_post_load: Yeh kvm

Re: [Qemu-devel] [PATCH v4 0/6] jobs: fix transactional race condition

2016-11-14 Thread John Snow
Jeff, where did we leave off on this? --js On 11/08/2016 01:50 AM, John Snow wrote: There are a few problems with transactional job completion right now. First, if jobs complete so quickly they complete before remaining jobs get a chance to join the transaction, the completion mode can leave w

Re: [Qemu-devel] [PATCH v4 0/6] jobs: fix transactional race condition

2016-11-14 Thread Jeff Cody
On Mon, Nov 14, 2016 at 01:58:03PM -0500, John Snow wrote: > Jeff, where did we leave off on this? > > --js I've applied it to my branch, but you made me realize I didn't send out a notice. Sorry about that! Here is my notice: :) Thanks, Applied to my block branch: git://github.com/codyprim

Re: [Qemu-devel] [PATCH v6 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2016-11-14 Thread Eric Blake
On 11/14/2016 12:03 PM, Fam Zheng wrote: Please move system headers (<>) above user headers (""). This way you can be sure the system header isn't affected by any macros defined by user headers. >>> >>> Yes, but still after "qemu/osdep.h", which prepares necessary bits for any >>>

Re: [Qemu-devel] [PATCH 18/21] qmp: add x-debug-block-dirty-bitmap-sha256

2016-11-14 Thread John Snow
On 11/09/2016 01:17 PM, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/dirty-bitmap.c | 5 + blockdev.c | 33 + include/block/dirty-bitmap.h | 2 ++ include/qemu/hbitmap.h | 8 +++

Re: [Qemu-devel] [PATCH 01/21] specs/qcow2: fix bitmap granularity qemu-specific note

2016-11-14 Thread John Snow
On 11/09/2016 01:17 PM, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy --- docs/specs/qcow2.txt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/docs/specs/qcow2.txt b/docs/specs/qcow2.txt index 80cdfd0..dda53dd 100644 --- a/docs/specs/qco

Re: [Qemu-devel] [RFC 2/2] cputlb: drop flush_global flag from tlb_flush

2016-11-14 Thread Richard Henderson
On 11/14/2016 06:40 PM, Alex Bennée wrote: We have never has the concept of global TLB entries which would avoid the flush so we never actually use this flag. Drop it and make clear that tlb_flush is the sledge-hammer it has always been. Signed-off-by: Alex Bennée --- Reviewed-by: Richard Hen

Re: [Qemu-devel] [PATCH 07/13] virtio-scsi: always use dataplane path if ioeventfd is active

2016-11-14 Thread Paolo Bonzini
On 14/11/2016 19:49, Alex Williamson wrote: > On Mon, 14 Nov 2016 19:10:54 +0100 > Paolo Bonzini wrote: > >> On 14/11/2016 18:09, Alex Williamson wrote: >>> Hmm, fixed yet not fixed. I get a nice shutdown and it even eliminates >>> a cpu spike shown in virt-manager at the end of shutdown that

Re: [Qemu-devel] [PATCH v12 05/22] vfio iommu: Added pin and unpin callback functions to vfio_iommu_driver_ops

2016-11-14 Thread Alex Williamson
On Mon, 14 Nov 2016 21:12:19 +0530 Kirti Wankhede wrote: > Added APIs for pining and unpining set of pages. These call back into > backend iommu module to actually pin and unpin pages. > Added two new callback functions to struct vfio_iommu_driver_ops. Backend > IOMMU module that supports pining

Re: [Qemu-devel] [RFC 1/2] qom/cpu: move tlb_flush to cpu_common_reset

2016-11-14 Thread Richard Henderson
On 11/14/2016 06:40 PM, Alex Bennée wrote: It is a common thing amongst the various cpu reset functions want to flush the SoftMMU's TLB entries. This is done either by calling tlb_flush directly or by way of a general memset of the CPU structure (sometimes both). This moves the tlb_flush call to

Re: [Qemu-devel] [PATCH 07/13] virtio-scsi: always use dataplane path if ioeventfd is active

2016-11-14 Thread Alex Williamson
On Mon, 14 Nov 2016 20:33:32 +0100 Paolo Bonzini wrote: > On 14/11/2016 19:49, Alex Williamson wrote: > > On Mon, 14 Nov 2016 19:10:54 +0100 > > Paolo Bonzini wrote: > > > >> On 14/11/2016 18:09, Alex Williamson wrote: > >>> Hmm, fixed yet not fixed. I get a nice shutdown and it even elimi

[Qemu-devel] [PULL 1/4] migration: fix missing assignment for has_x_checkpoint_delay

2016-11-14 Thread Juan Quintela
From: zhanghailiang We forgot to assign true to params->has_x_checkpoint_delay parameter in qmp_query_migrate_parameters. Without this, qmp command 'query-migrate-parameters' doesn't show the default value for x-checkpoint-delay option. This also fixes the fact that HMP was relying on unspecifi

[Qemu-devel] [PULL 3/4] tests/test-vmstate.c: add array of pointer to struct

2016-11-14 Thread Juan Quintela
From: Halil Pasic Increase test coverage by adding tests for the macro VMSTATE_ARRAY_OF_POINTER_TO_STRUCT. Signed-off-by: Halil Pasic Reviewed-by: Guenther Hutzl Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- tests/test-vmstate.c | 74 +++

[Qemu-devel] [PULL 0/4] Migration pull

2016-11-14 Thread Juan Quintela
The following changes since commit 83c83f9a5266ff113060f887f106a47920fa6974: Merge remote-tracking branch 'bonzini/tags/for-upstream' into staging (2016-11-11 12:51:50 +) are available in the git repository at: git://github.com/juanquintela/qemu.git tags/migration/20161114

[Qemu-devel] [PULL 4/4] migration: Fix return code of ram_save_iterate()

2016-11-14 Thread Juan Quintela
From: Thomas Huth qemu_savevm_state_iterate() expects the iterators to return 1 when they are done, and 0 if there is still something left to do. However, ram_save_iterate() does not obey this rule and returns the number of saved pages instead. This causes a fatal hang with ppc64 guests when you

[Qemu-devel] [PULL 2/4] tests/test-vmstate.c: add save_buffer util func

2016-11-14 Thread Juan Quintela
From: Halil Pasic Let us de-duplicate some code by introducing an utility function for saving a chunk of bytes (used when testing load based on wire). Signed-off-by: Halil Pasic Reviewed-by: Guenther Hutzl Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- tests/test-vmstate.c | 23

Re: [Qemu-devel] [PATCH 02/21] specs/qcow2: do not use wording 'bitmap header'

2016-11-14 Thread John Snow
On 11/09/2016 01:17 PM, Vladimir Sementsov-Ogievskiy wrote: A bitmap directory entry is sometimes called a 'bitmap header'. This patch leaves only one name - 'bitmap directory entry'. The name 'bitmap header' creates misunderstandings with 'qcow2 header' and 'qcow2 bitmap header extension' (whi

Re: [Qemu-devel] [RFC 0/3] aio: experimental virtio-blk polling mode

2016-11-14 Thread Karl Rister
On 11/14/2016 09:26 AM, Stefan Hajnoczi wrote: > On Fri, Nov 11, 2016 at 01:59:25PM -0600, Karl Rister wrote: >> On 11/09/2016 11:13 AM, Stefan Hajnoczi wrote: >>> Recent performance investigation work done by Karl Rister shows that the >>> guest->host notification takes around 20 us. This is more

[Qemu-devel] [PULL] slirp: Fix access to freed memory

2016-11-14 Thread Samuel Thibault
if_start() goes through the slirp->if_fastq and slirp->if_batchq list of pending messages, and accesses ifm->ifq_so->so_nqueued of its elements if ifm->ifq_so != NULL. When freeing a socket, we thus need to make sure that any pending message for this socket does not refer to the socket any more.

[Qemu-devel] [PULL] slirp: Fix access to freed memory

2016-11-14 Thread Samuel Thibault
The following changes since commit 83c83f9a5266ff113060f887f106a47920fa6974: Merge remote-tracking branch 'bonzini/tags/for-upstream' into staging (2016-11-11 12:51:50 +) are available in the git repository at: http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault for you t

Re: [Qemu-devel] [PULL] slirp: Fix access to freed memory

2016-11-14 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PULL] slirp: Fix access to freed memory Message-id: 20161114202030.17685-2-samuel.thiba...@ens-lyon.org === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=

Re: [Qemu-devel] [PATCH for-2.8 0/2] pc: remove redundant fw_cfg file "etc/boot-cpus"

2016-11-14 Thread Michael S. Tsirkin
On Fri, Nov 11, 2016 at 04:21:10PM +0100, Igor Mammedov wrote: > > Commit 080ac219cc7d9c55adf925c3545b7450055ad625 >pc: Add 'etc/boot-cpus' fw_cfg file for machine with more than 255 CPUs > > added "etc/boot-cpus" fw_cfg file durung 2.8 merge window, however > QEMU alredy had similar legacy F

Re: [Qemu-devel] [PATCH 4/4] q35: introduce q35-lite

2016-11-14 Thread Michael S. Tsirkin
On Mon, Nov 14, 2016 at 04:06:02PM +0800, Chao Peng wrote: > On Mon, 2016-11-07 at 18:09 +0100, Paolo Bonzini wrote: > > > > On 06/11/2016 08:06, Michael S. Tsirkin wrote: > > > > > > On Sat, Nov 05, 2016 at 03:19:51AM -0400, Chao Peng wrote: > > > > > > > > > > > > > > This patch introduces a

Re: [Qemu-devel] [RFC 0/3] aio: experimental virtio-blk polling mode

2016-11-14 Thread Paolo Bonzini
On 14/11/2016 21:12, Karl Rister wrote: > 25646,929 > 51235,627 >1,02446,477 >2,00035,247 >2,04846,322 >4,00046,540 >4,09646,368 >8,000

[Qemu-devel] QEMU postcopy-test failing on ppc64

2016-11-14 Thread Stefan Hajnoczi
I hit a failure running "make check" on ppc64 for the first time. Ideas? Stefan commit 682df581c65ed2c1b9e77093e332214ecaa1ee93 GTESTER check-qtest-ppc64 Memory content inconsistency at 5af4000 first_byte = 1b last_byte = 1a current = 7c hit_edge = 1 Memory content inconsistency at 5af5000 fi

[Qemu-devel] [PATCH 0/3] Migration fixes

2016-11-14 Thread Juan Quintela
Hi This are the fixes that were of the multifd patches. The most important one is the second patch, that one that checks for valid flags on reception. Please, review. Juan Quintela (3): migration: create Migration Incoming State at init time migration: Test for disabled features on recept

[Qemu-devel] [PATCH 1/3] migration: create Migration Incoming State at init time

2016-11-14 Thread Juan Quintela
Signed-off-by: Juan Quintela --- include/migration/migration.h | 1 - migration/migration.c | 38 +- migration/savevm.c| 4 ++-- 3 files changed, 19 insertions(+), 24 deletions(-) diff --git a/include/migration/migration.h b/include/migra

[Qemu-devel] [PATCH 2/3] migration: Test for disabled features on reception

2016-11-14 Thread Juan Quintela
Right now, if we receive a compressed page or a xbzrle page while this features are disabled, Bad Things (TM) can happen. Just add a test for them. Signed-off-by: Juan Quintela --- migration/ram.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/migrat

[Qemu-devel] [PATCH 3/3] migration: Don't create decompression threads if not enabled

2016-11-14 Thread Juan Quintela
Signed-off-by: Juan Quintela -- I removed the [HACK] part because previous patch just check that compression pages are not received. Signed-off-by: Juan Quintela --- migration/ram.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/migration/ram.c b/migration/ram.c index 4bb707c..24e2

[Qemu-devel] [kvm-unit-tests PATCH v6 01/11] lib: xstr: allow multiple args

2016-11-14 Thread Andrew Jones
Make implementation equivalent to Linux's include/linux/stringify.h Reviewed-by: Eric Auger Signed-off-by: Andrew Jones --- lib/libcflat.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/libcflat.h b/lib/libcflat.h index 72b1bf9668ef..82005f5d014f 100644 --- a/lib/li

[Qemu-devel] [kvm-unit-tests PATCH v6 00/11] arm/arm64: add gic framework

2016-11-14 Thread Andrew Jones
v6: - rebased to latest master - several other changes thanks to Andre and Alex, changes in individual patch change logs - some code cleanups v5: - fix arm32/gicv3 compile [drew] - use modern register names [Andre] - one Andre r-b v4: - Eric's r-b's - Andre's suggestion to only take de

[Qemu-devel] [kvm-unit-tests PATCH v6 03/11] arm/arm64: smp: support more than 8 cpus

2016-11-14 Thread Andrew Jones
By adding support for launching with gicv3 we can break the 8 vcpu limit. This patch adds support to smp code and also selects the vgic model corresponding to the host. The vgic model may also be manually selected by adding e.g. -machine gic-version=3 to extra_params. Reviewed-by: Alex Bennée Rev

[Qemu-devel] [kvm-unit-tests PATCH v6 02/11] arm64: fix get_"sysreg32" and make MPIDR 64bit

2016-11-14 Thread Andrew Jones
mrs is always 64bit, so we should always use a 64bit register. Sometimes we'll only want to return the lower 32, but not for MPIDR, as that does define fields in the upper 32. Reviewed-by: Alex Bennée Reviewed-by: Eric Auger Signed-off-by: Andrew Jones --- v5: switch arm32's get_mpidr to 'unsi

[Qemu-devel] [kvm-unit-tests PATCH v6 05/11] arm/arm64: irq enable/disable

2016-11-14 Thread Andrew Jones
Reviewed-by: Alex Bennée Reviewed-by: Eric Auger Signed-off-by: Andrew Jones --- lib/arm/asm/processor.h | 10 ++ lib/arm64/asm/processor.h | 10 ++ 2 files changed, 20 insertions(+) diff --git a/lib/arm/asm/processor.h b/lib/arm/asm/processor.h index bc46d1f980ee..959ecda5dc

[Qemu-devel] [kvm-unit-tests PATCH v6 08/11] libcflat: add IS_ALIGNED() macro, and page sizes

2016-11-14 Thread Andrew Jones
From: Peter Xu These macros will be useful to do page alignment checks. Reviewed-by: Andre Przywara Signed-off-by: Peter Xu [drew: also added SZ_64K and changed to shifts] Signed-off-by: Andrew Jones --- v6: change to shifts [Alex] --- lib/libcflat.h | 6 ++ 1 file changed, 6 insertions

[Qemu-devel] [kvm-unit-tests PATCH v6 10/11] arm/arm64: gicv3: add an IPI test

2016-11-14 Thread Andrew Jones
Signed-off-by: Andrew Jones --- v6: move most gicv2/gicv3 wrappers to common code [Alex] v5: - fix copy+paste error in gicv3_write_eoir [drew] - use modern register names [Andre] v4: - heavily comment gicv3_ipi_send_tlist() [Eric] - changes needed for gicv2 iar/irqstat fix to other patch v2:

[Qemu-devel] [kvm-unit-tests PATCH v6 11/11] arm/arm64: gic: don't just use zero

2016-11-14 Thread Andrew Jones
Allow user to select who sends ipis and with which irq, rather than just always sending irq=0 from cpu0. Signed-off-by: Andrew Jones --- v6: - make sender/irq names more future-proof [drew] - sanity check inputs [drew] - introduce check_sender/irq and bad_sender/irq to more cleanly do chec

[Qemu-devel] [kvm-unit-tests PATCH v6 04/11] arm/arm64: add some delay routines

2016-11-14 Thread Andrew Jones
Allow a thread to wait some specified amount of time. Can specify in cycles, usecs, and msecs. Reviewed-by: Alex Bennée Reviewed-by: Eric Auger Signed-off-by: Andrew Jones --- lib/arm/asm/processor.h | 19 +++ lib/arm/processor.c | 15 +++ lib/arm64/asm/proc

[Qemu-devel] [kvm-unit-tests PATCH v6 09/11] arm/arm64: add initial gicv3 support

2016-11-14 Thread Andrew Jones
Reviewed-by: Alex Bennée Signed-off-by: Andrew Jones --- v6: - added comments [Alex] - added stride parameter to gicv3_set_redist_base [Andre] - redist-wait s/rwp/uwp/ and comment [Andre] - removed unnecessary wait-for-rwps [Andre] v5: use modern register names [Andre] v4: - only take defin

[Qemu-devel] [kvm-unit-tests PATCH v6 06/11] arm/arm64: add initial gicv2 support

2016-11-14 Thread Andrew Jones
Add some gicv2 support. This just adds init and enable functions, allowing unit tests to start messing with it. Reviewed-by: Andre Przywara Signed-off-by: Andrew Jones --- v6: added comments (register offset headers) [Alex] v5: share/use only the modern register names [Andre] v4: - only take d

[Qemu-devel] [kvm-unit-tests PATCH v6 07/11] arm/arm64: gicv2: add an IPI test

2016-11-14 Thread Andrew Jones
Reviewed-by: Eric Auger Signed-off-by: Andrew Jones --- v6: move the spurious check to its own check_ function [drew] v5: use modern registers [Andre] v4: properly mask irqnr in ipi_handler v2: add more details in the output if a test fails, report spurious interrupts if we get them --- arm/

Re: [Qemu-devel] [PULL v2 00/34] virtio, vhost, pc, pci: tests, documentation, fixes and cleanups

2016-11-14 Thread Michael S. Tsirkin
On Mon, Nov 14, 2016 at 03:52:58PM +, Stefan Hajnoczi wrote: > On Fri, Nov 11, 2016 at 08:09:58PM +0200, Michael S. Tsirkin wrote: > > libvhost-user is the only thing that might be controvertial here, but it's > > only > > affecting contrib/ and tests so I think it's still fair game, and sever

Re: [Qemu-devel] [PATCH v7 00/10] Convert msix_init() to error

2016-11-14 Thread Michael S. Tsirkin
On Mon, Nov 14, 2016 at 03:25:30PM +0800, Cao jin wrote: > v7 changelog: > 1. fix the segfaut bug in patch 2. So drop the all the R-b of it, >please take a look, there is detailed description in the patch. > 2. add the R-b from Hannes Reinecke Pls remember to ping after release. > Test: > 1.

<    1   2   3   >