Re: [Qemu-devel] [Qemu-block] [PATCH for-2.8] block: Let write zeroes fallback work even with small max_transfer

2016-11-10 Thread Kevin Wolf
Am 10.11.2016 um 03:11 hat Fam Zheng geschrieben: > On Wed, 11/09 14:06, Eric Blake wrote: > > On 11/09/2016 07:49 AM, Stefan Hajnoczi wrote: > > > On Tue, Nov 08, 2016 at 04:52:15PM -0600, Eric Blake wrote: > > >> Commit 443668ca rewrote the write_zeroes logic to guarantee that > > >> an unaligned

Re: [Qemu-devel] [PATCH v11 09/22] vfio iommu type1: Add task structure to vfio_dma

2016-11-10 Thread Dong Jia Shi
* Kirti Wankhede [2016-11-05 02:40:43 +0530]: Hi Kirti, [...] > static int vfio_dma_do_map(struct vfio_iommu *iommu, > struct vfio_iommu_type1_dma_map *map) > { > dma_addr_t iova = map->iova; > unsigned long vaddr = map->vaddr; > size_t size = map->si

[Qemu-devel] [PATCH] qtest: fix a memory leak

2016-11-10 Thread Marc-André Lureau
Spotted by ASAN. Signed-off-by: Marc-André Lureau --- qtest.c | 1 + 1 file changed, 1 insertion(+) diff --git a/qtest.c b/qtest.c index 46b99ae..39a73c4 100644 --- a/qtest.c +++ b/qtest.c @@ -240,6 +240,7 @@ static void GCC_FMT_ATTR(2, 3) qtest_sendf(CharBackend *chr, va_start(ap, fmt);

[Qemu-devel] [PATCH] tests: fix qmp response leak

2016-11-10 Thread Marc-André Lureau
Spotted by ASAN. Signed-off-by: Marc-André Lureau --- tests/libqos/usb.c | 1 + tests/postcopy-test.c | 2 +- tests/pvpanic-test.c | 1 + tests/test-filter-mirror.c | 2 +- tests/test-filter-redirector.c | 4 ++-- tests/virtio-blk-test.c| 15 ++

Re: [Qemu-devel] [PATCH] test-uuid: fix leak

2016-11-10 Thread Fam Zheng
On Wed, 11/09 15:02, Marc-André Lureau wrote: > ASAN spotted: > SUMMARY: AddressSanitizer: 74 byte(s) leaked in 2 allocation(s). > > Signed-off-by: Marc-André Lureau > --- > tests/test-uuid.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/test-uuid.c b/tests/test-uuid.c > index

[Qemu-devel] [PATCH] spapr-vty: Fix bad assert() statement

2016-11-10 Thread Thomas Huth
When using the serial console in the GTK interface of QEMU (and QEMU has been compiled with CONFIG_VTE), it is possible to trigger the assert() statement in vty_receive() in spapr_vty.c by pasting a chunk of text with length > 16 into the QEMU window. Most of the other serial backends seem to simpl

[Qemu-devel] [Bug 1639322] Re: pasting into ppc64 serial console kills qemu

2016-11-10 Thread Thomas Huth
OK, seems like you need to compile QEMU with CONFIG_VTE enabled (i.e. with the vte-devel packages installed before running configure) to get copy-n-paste support in the GTK interface, that's why I was initially not able to reproduce this issue. Anyway, now I can trigger the assert(), too, and I'

[Qemu-devel] [Bug 1021649] Re: qemu 1.1.0 waits for a keypress at boot

2016-11-10 Thread Thomas Huth
Can this issue still be reproduced with the latest version of QEMU, or can we close this bug nowadays? ** Changed in: qemu Status: Confirmed => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.

[Qemu-devel] [Bug 660060] Re: virtio block read errors

2016-11-10 Thread Lionel Bouton
You can close this bug: it has been fixed long ago. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/660060 Title: virtio block read errors Status in QEMU: Incomplete Bug description: Context :

Re: [Qemu-devel] [PATCH v13 1/2] virtio-crypto: Add virtio crypto device specification

2016-11-10 Thread Gonglei (Arei)
Hi, I attach a diff for next version in order to review more convenient, with - Drop the all gap stuff; - Drop all structures undefined in virtio_crypto.h - re-describe per request for per crypto service avoid confusion Pls review, thanks! diff --git a/virtio-crypto.tex b/virtio-crypto.tex

[Qemu-devel] [Bug 1212402] Re: Enabling KVM with recent QEMU builds from GIT hang at boot on Ubuntu Precise AMD64 kernel 3.8.0

2016-11-10 Thread Thomas Huth
According to comment #1, this has been fixed with kernel 3.9, so setting the status to "Fix released" now. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.

[Qemu-devel] [Bug 1021649] Re: qemu 1.1.0 waits for a keypress at boot

2016-11-10 Thread Richard Jones
No this refers to a very old version of qemu. This bug should be closed. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1021649 Title: qemu 1.1.0 waits for a keypress at boot Status in QEMU: Fix

Re: [Qemu-devel] Sphinx for QEMU docs? (and a doc-comment format question)

2016-11-10 Thread Paolo Bonzini
- Original Message - > From: "Fam Zheng" > To: "Stefan Hajnoczi" > Cc: "John Snow" , "Peter Maydell" > , "QEMU Developers" > , "Stefan Hajnoczi" , "Paolo > Bonzini" > Sent: Thursday, November 10, 2016 4:39:14 AM > Subject: Re: [Qemu-devel] Sphinx for QEMU docs? (and a doc-comment for

[Qemu-devel] [PULL 4/6] MAINTAINERS: Add an entry for the CHRP NVRAM files

2016-11-10 Thread Thomas Huth
I recently added new files to the source tree that are not covered by any maintainer yet -- and since every new source file should have a maintainer nowadays, I volunteer to look after these files now, too. Reviewed-by: David Gibson Reviewed-by: Stefan Hajnoczi Signed-off-by: Thomas Huth --- M

[Qemu-devel] [PULL 0/6] Fixes for the MAINTAINERS file

2016-11-10 Thread Thomas Huth
The following changes since commit 9b4b0350264d8164996265d635c8b9599673afb4: Merge remote-tracking branch 'public/tags/tracing-pull-request' into staging (2016-11-09 12:44:16 +) are available in the git repository at: https://github.com/huth/qemu.git tags/maintainers-2016111

[Qemu-devel] [PULL 3/6] m68k: Update the 68k sections in the MAINTAINERS file

2016-11-10 Thread Thomas Huth
disas/m68k.c obviously belong to the m68k CPU section in the MAINTAINERS file, but remove the hw/m68k/ directory here since it only contains machine (not CPU) related files, as requested by Laurent. Add the machine related files to the right machine sections instead. Reviewed-by: Laurent Vivier R

[Qemu-devel] [PULL 1/6] MAINTAINERS: Add some ARM related files to the corresponding sections

2016-11-10 Thread Thomas Huth
The files w/cpu/a*mpcore.c are already assigned to the ARM CPU section, but the corresponding headers include/hw/cpu/a*mpcore.h are still missing. The file hw/*/imx* are already assigned to the i.MX31 machine, but the corresponding header files include/hw/*/imx* are still missing. The file hw/mis

[Qemu-devel] [PULL 6/6] MAINTAINERS: Remove obsolete stable branches

2016-11-10 Thread Thomas Huth
There are only very old and orphaned stable branches listed in the MAINTAINERS file - so this section is pretty useless nowadays. Let's remove it. Reviewed-by: John Snow Signed-off-by: Thomas Huth --- MAINTAINERS | 22 -- 1 file changed, 22 deletions(-) diff --git a/MAINTAI

[Qemu-devel] [PULL 2/6] sparc: Add slavio_misc.c and eccmemctl.c to the MAINTAINERS file

2016-11-10 Thread Thomas Huth
Both files seem to belong to the Sun4m machine. Reviewed-by: Stefan Hajnoczi Signed-off-by: Thomas Huth --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index d7eef43..451e7cc 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -710,6 +710,8 @@ S: Mainta

[Qemu-devel] [PULL 5/6] MAINTAINERS: Add Fam and Jsnow for Bitmap support

2016-11-10 Thread Thomas Huth
From: John Snow These files are currently unmaintained. I'm proposing that Fam and I co-maintain them; under the model that whomever between us isn't authoring a given series will be responsible for reviewing it. Signed-off-by: John Snow Acked-by: Fam Zheng Acked-by: Max Reitz Reviewed-by: S

[Qemu-devel] [Bug 1021649] Re: qemu 1.1.0 waits for a keypress at boot

2016-11-10 Thread Paolo Bonzini
** Changed in: qemu Status: Incomplete => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1021649 Title: qemu 1.1.0 waits for a keypress at boot Status in QEMU: Fix Released St

[Qemu-devel] [Bug 660060] Re: virtio block read errors

2016-11-10 Thread Thomas Huth
Thanks for your response! So I'm closing this ticket now... ** Changed in: qemu Status: Incomplete => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/660060 Title: virtio block r

Re: [Qemu-devel] virtIO question

2016-11-10 Thread Stefan Hajnoczi
On Wed, Nov 09, 2016 at 06:58:16PM +0800, zhun...@gmail.com wrote: > I want to ask a another question,why a virt_queue in virtio include in_sgs > and out_sgs,for example,send_queue of virtIO net driver have in_sgs and > out_sgs,when transmit data,It add buffer to out_sgs of send_queue,but how it

Re: [Qemu-devel] [PATCHv2 0/3] Allow ISA to be disabled on some platforms

2016-11-10 Thread Edgar E. Iglesias
On Wed, Nov 09, 2016 at 11:22:01PM +1100, David Gibson wrote: > This is a rebase and revision of a series I wrote quite some time ago. > This makes some cleanups that are a start on allowing ISA to be > compiled out for platforms which don't use it. > > Unfortunately, a lot of the pieces here don'

Re: [Qemu-devel] [PULL for-2.8 0/1] ipxe: update to 20161108 snapshot.

2016-11-10 Thread Stefan Hajnoczi
On Wed, Nov 09, 2016 at 10:09:24AM +0100, Gerd Hoffmann wrote: > Hi, > > This rebases ipxe to latest master. ipxe qemu builds will not use > fxsave/fxrestore any more, which caused problems on older intel cpus > due to kvm not emulating these instructions. > > Special thanks to Laszlo for push

Re: [Qemu-devel] Sphinx for QEMU docs? (and a doc-comment format question)

2016-11-10 Thread Daniel P. Berrange
On Thu, Nov 10, 2016 at 05:08:03AM -0500, Paolo Bonzini wrote: > > > - Original Message - > > From: "Fam Zheng" > > To: "Stefan Hajnoczi" > > Cc: "John Snow" , "Peter Maydell" > > , "QEMU Developers" > > , "Stefan Hajnoczi" , "Paolo > > Bonzini" > > Sent: Thursday, November 10, 2016

Re: [Qemu-devel] [PULL for-2.8 0/2] usb: two memory leak fixes.

2016-11-10 Thread Stefan Hajnoczi
On Wed, Nov 09, 2016 at 02:33:29PM +0100, Gerd Hoffmann wrote: > Hi, > > Here is the usb patch queue, fixing two memory leaks. > > please pull, > Gerd > > The following changes since commit 207faf24c58859f5240f66bf6decc33b87a1776e: > > Merge remote-tracking branch 'pm215/tags/pull-target-

Re: [Qemu-devel] [PULL for-2.8 0/3] ui: bugfixes for gtk, curses and hid emulation.

2016-11-10 Thread Stefan Hajnoczi
On Wed, Nov 09, 2016 at 03:38:40PM +0100, Gerd Hoffmann wrote: > Hi, > > Here is the UI patch queue with three bugfixes, > most importantly the cursesw configure fix. > > please pull, > Gerd > > The following changes since commit 207faf24c58859f5240f66bf6decc33b87a1776e: > > Merge remote-

Re: [Qemu-devel] [PATCH] qtest: fix a memory leak

2016-11-10 Thread Stefan Hajnoczi
On Thu, Nov 10, 2016 at 12:25:36PM +0400, Marc-André Lureau wrote: > Spotted by ASAN. > > Signed-off-by: Marc-André Lureau > --- > qtest.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [Qemu-devel] [PULL 0/6] Fixes for the MAINTAINERS file

2016-11-10 Thread Stefan Hajnoczi
ble in the git repository at: > > > https://github.com/huth/qemu.git tags/maintainers-20161110 > > for you to fetch changes up to 275196e9a2b13e3e24fd6cf638c02a6454071b8a: > > MAINTAINERS: Remove ob

Re: [Qemu-devel] [PATCH] tests: fix qmp response leak

2016-11-10 Thread Stefan Hajnoczi
On Thu, Nov 10, 2016 at 12:36:29PM +0400, Marc-André Lureau wrote: > Spotted by ASAN. > > Signed-off-by: Marc-André Lureau > --- > tests/libqos/usb.c | 1 + > tests/postcopy-test.c | 2 +- > tests/pvpanic-test.c | 1 + > tests/test-filter-mirror.c | 2 +- >

Re: [Qemu-devel] [PULL for-2.8 0/1] ipxe: update to 20161108 snapshot.

2016-11-10 Thread Stefan Hajnoczi
On Wed, Nov 09, 2016 at 10:09:24AM +0100, Gerd Hoffmann wrote: > This rebases ipxe to latest master. ipxe qemu builds will not use > fxsave/fxrestore any more, which caused problems on older intel cpus > due to kvm not emulating these instructions. > > Special thanks to Laszlo for pushing these p

Re: [Qemu-devel] [RFC PATCH 2/4] vhost-user: add the vhost-user extension to support the vhost-pci based inter-vm communication

2016-11-10 Thread Marc-André Lureau
Hi On Thu, Nov 10, 2016 at 6:47 AM Wei Wang wrote: > This is the slave part of vhost-user implemented in QEMU, with an extension > to support vhost-pci. > Instead of implementing "another vhost-user slave", it would be worth investigating using libvhost-user instead ( https://lists.gnu.org/arch

Re: [Qemu-devel] [RFC PATCH 1/4] qemu-char: add the "1-server-N-client" support

2016-11-10 Thread Marc-André Lureau
Hi On Thu, Nov 10, 2016 at 6:47 AM Wei Wang wrote: > This patch enables a qemu server socket to be connected by multiple > client sockets. > > Thanks for sharing this early version of the series, I hope some early feedback will help you. I'll be waiting for a more complete implementation for det

Re: [Qemu-devel] [PATCH 0/3] target-arm: cache tbflags in CPUARMState

2016-11-10 Thread Alex Bennée
Paolo Bonzini writes: > Computing TranslationBlock flags is pretty expensive on ARM, especially > 32-bit. Because tbflags are computed on every tb lookup, it is not > unlikely to see cpu_get_tb_cpu_state close to the top of the profile > now that QHT makes the hash table much more efficient. >

Re: [Qemu-devel] [QEMU PATCH v2] kvmclock: advance clock by time window between vm_stop and pre_save

2016-11-10 Thread Marcelo Tosatti
GOn Wed, Nov 09, 2016 at 05:23:50PM +0100, Paolo Bonzini wrote: > > > On 08/11/2016 11:22, Dr. David Alan Gilbert wrote: > > * Marcelo Tosatti (mtosa...@redhat.com) wrote: > >> On Mon, Nov 07, 2016 at 08:03:50PM +, Dr. David Alan Gilbert wrote: > >>> * Marcelo Tosatti (mtosa...@redhat.com) wr

Re: [Qemu-devel] [QEMU PATCH v12 2/4] migration: migrate QTAILQ

2016-11-10 Thread Halil Pasic
On 11/08/2016 01:06 AM, Jianjun Duan wrote: > Currently we cannot directly transfer a QTAILQ instance because of the > limitation in the migration code. Here we introduce an approach to > transfer such structures. We created VMStateInfo vmstate_info_qtailq > for QTAILQ. Similar VMStateInfo can be

[Qemu-devel] [Bug 616769] Re: interrupt problem x86_64

2016-11-10 Thread Paolo Minazzi
Hello Thomas, it happens some years ago and now I'm not able to reproduce it. I'm sorry, thanks again, Paolo -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/616769 Title: interrupt problem x86_64 St

Re: [Qemu-devel] virtIO question

2016-11-10 Thread zhun...@gmail.com
From this point of view ,I think it make sense well, thank you very much! but I have another question about notify mechanism between virtIO driver and qemu. according the source code of Linux and qemu, when driver add a sg buffer to send queue named sq, sq->vq->vring.avail->idx++ vq->num_added++

Re: [Qemu-devel] [PATCH 0/3] target-arm: cache tbflags in CPUARMState

2016-11-10 Thread Paolo Bonzini
On 10/11/2016 12:42, Alex Bennée wrote: > > Paolo Bonzini writes: > >> Computing TranslationBlock flags is pretty expensive on ARM, especially >> 32-bit. Because tbflags are computed on every tb lookup, it is not >> unlikely to see cpu_get_tb_cpu_state close to the top of the profile >> now t

[Qemu-devel] [PATCH] tests: add XSCOM tests for the PowerNV machine

2016-11-10 Thread Cédric Le Goater
Add a couple of tests on the XSCOM bus of the PowerNV machine for the the POWER8 and POWER9 CPUs. The first tests reads the CFAM identifier of the chip. The second test goes further in the XSCOM address space and reaches the cores to read their DTS registers. This last one is disabled on P9 for the

Re: [Qemu-devel] [virtio-comment] Re: [PATCH v1] docs/vhost-user: extend the vhost-user protocol to support the vhost-pci based inter-vm communication

2016-11-10 Thread Marc-André Lureau
Hi Wei On Wed, Nov 9, 2016 at 12:32 PM Wei Wang wrote: > On 11/08/2016 08:17 PM, Marc-André Lureau wrote: > > > > > > > > Message Specification > > > - > > > > > > Note that all numbers are in the machine native byte order. A > > > vhost

[Qemu-devel] [PATCH v2 0/1] vfio-pci: fix assert fail in host property if unused

2016-11-10 Thread Daniel Oram
Changes since v1: * Wrap commit log at 70 chars. Commit 4a946268 changed the default value of the structure (PCIHostDeviceAddress) underlying the host property in vfio-pci to be ~0 in all fields. Since this structure has excess bits for representing a standard BDF (:FF:FF.F) this triggers a

[Qemu-devel] [PATCH v2 1/1] Fix assert in PCI address property when used by vfio-pci

2016-11-10 Thread Daniel Oram
Allow the PCIHostDeviceAddress structure to work as the host property in vfio-pci when it has it's default value of all fields set to ~0. In this form the property indicates a non-existant device but given the field bit sizes gets asserted as excess (and invalid) precision overflows the string buff

Re: [Qemu-devel] Sphinx for QEMU docs? (and a doc-comment format question)

2016-11-10 Thread Stefan Hajnoczi
On Thu, Nov 10, 2016 at 11:39:14AM +0800, Fam Zheng wrote: > On Wed, 11/09 11:32, Stefan Hajnoczi wrote: > > No doc comments -> error. > > I'm not sure that is a good idea. For example all .bdrv_co_flush_to_disk > implementations have the same semantics and signature, requiring doc comments > ever

Re: [Qemu-devel] [RFC 1/3] aio-posix: add aio_set_poll_handler()

2016-11-10 Thread Stefan Hajnoczi
On Wed, Nov 09, 2016 at 06:30:11PM +0100, Paolo Bonzini wrote: Thanks for the feedback. I hope that Karl will be able to find a QEMU_AIO_POLL_MAX_NS setting that improves the benchmark. At that point I'll send a new version of this series so we can iron out the details. > > +static bool run_pol

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v13 1/2] virtio-crypto: Add virtio crypto device specification

2016-11-10 Thread Michael S. Tsirkin
On Thu, Nov 10, 2016 at 02:25:44AM +, Gonglei (Arei) wrote: > > > > > Subject: [virtio-dev] Re: [Qemu-devel] [PATCH v13 1/2] virtio-crypto: Add > > virtio > > crypto device specification > > > > On Wed, Nov 09, 2016 at 01:11:20AM +, Gonglei (Arei) wrote: > > > Nope, Actually I kept those

Re: [Qemu-devel] [PATCH] target-m68k: add rol/ror/roxl/roxr instructions

2016-11-10 Thread Richard Henderson
On 11/09/2016 09:22 PM, Laurent Vivier wrote: Le 09/11/2016 à 20:39, Richard Henderson a écrit : On 11/09/2016 07:47 PM, Richard Henderson wrote: On 11/09/2016 06:30 PM, Laurent Vivier wrote: +/* create [src:X:..] */ + +tcg_gen_deposit_i32(t0, QREG_CC_X, src, 1, size); +

Re: [Qemu-devel] [PATCH v1 1/1] virtio crypto device specification: asymmetric crypto service

2016-11-10 Thread Zeng, Xin
Ping... Appreciate for any comments for this patch! Thanks > -Original Message- > From: virtio-...@lists.oasis-open.org [mailto:virtio-...@lists.oasis-open.org] > On Behalf Of Zeng, Xin > Sent: Thursday, November 3, 2016 8:19 PM > To: virtio-...@lists.oasis-open.org; qemu-devel@nongnu.or

Re: [Qemu-devel] [PATCH v13 1/2] virtio-crypto: Add virtio crypto device specification

2016-11-10 Thread Michael S. Tsirkin
On Thu, Nov 10, 2016 at 09:37:40AM +, Gonglei (Arei) wrote: > Hi, > > I attach a diff for next version in order to review more convenient, with > > - Drop the all gap stuff; > - Drop all structures undefined in virtio_crypto.h > - re-describe per request for per crypto service avoid confus

Re: [Qemu-devel] [RFC 1/3] aio-posix: add aio_set_poll_handler()

2016-11-10 Thread Paolo Bonzini
On Thursday, November 10, 2016 11:17:35 AM, Stefan Hajnoczi wrote: > > I think the question is not "is there any polling to be done" but rather > > "is there anything that requires looking at a file descriptor". If you > > have e.g. an NBD device on the AioContext you cannot poll. On the other

Re: [Qemu-devel] [PATCH 0/3] target-arm: cache tbflags in CPUARMState

2016-11-10 Thread Alex Bennée
Paolo Bonzini writes: > On 10/11/2016 12:42, Alex Bennée wrote: >> >> Paolo Bonzini writes: >> >>> Computing TranslationBlock flags is pretty expensive on ARM, especially >>> 32-bit. Because tbflags are computed on every tb lookup, it is not >>> unlikely to see cpu_get_tb_cpu_state close to th

[Qemu-devel] [PATCH v2 3/3] vus: Introduce a vhost-user-scsi sample application

2016-11-10 Thread Felipe Franciosi
This commit introduces a vhost-user-scsi backend sample application. It must be linked with libiscsi and libvhost-user. To use it, compile with: make vhost-user-scsi And run as follows: ./vhost-user-scsi -u /tmp/vus.sock -i iscsi://uri_to_target/ The application is currently limited at one LUN o

[Qemu-devel] [PATCH v2 0/3] Introduce vhost-user-scsi and sample application

2016-11-10 Thread Felipe Franciosi
Based on various discussions on the 2016 KVM Forum, I'm sending over a vhost-user-scsi implementation for your consideration. This patch set introduces a new vhost-user SCSI device. While heavily based on vhost-scsi, it is implemented using vhost's userspace counterpart. The device has been coded

[Qemu-devel] [PATCH v2 2/3] vus: Introduce vhost-user-scsi host device

2016-11-10 Thread Felipe Franciosi
This commit introduces a vhost-user device for SCSI. This is based on the existing vhost-scsi implementation, but done over vhost-user instead. It also uses a chardev to connect to the backend. Unlike vhost-scsi (today), VMs using vhost-user-scsi can be live migrated. To use it, one must configure

[Qemu-devel] [PATCH v2 1/3] vhost-scsi: create a vhost-scsi-common abstraction

2016-11-10 Thread Felipe Franciosi
In order to introduce a new vhost-user-scsi host device type, it makes sense to abstract part of vhost-scsi into a common parent class. This commit does exactly that. Signed-off-by: Felipe Franciosi --- hw/scsi/Makefile.objs | 2 +- hw/scsi/vhost-scsi-common.c | 143 +

Re: [Qemu-devel] [PATCHv2 0/3] Allow ISA to be disabled on some platforms

2016-11-10 Thread Michael S. Tsirkin
On Wed, Nov 09, 2016 at 11:22:01PM +1100, David Gibson wrote: > This is a rebase and revision of a series I wrote quite some time ago. > This makes some cleanups that are a start on allowing ISA to be > compiled out for platforms which don't use it. > > Unfortunately, a lot of the pieces here don'

Re: [Qemu-devel] [PATCH v2 3/3] net: virtio-net discards TX data after link down

2016-11-10 Thread Michael S. Tsirkin
On Thu, Nov 10, 2016 at 01:56:05AM +0200, Yuri Benditovich wrote: > > > On Wed, Nov 9, 2016 at 10:28 PM, Michael S. Tsirkin wrote: > > On Wed, Nov 09, 2016 at 05:22:02PM +0200, yuri.benditov...@daynix.com > wrote: > > From: Yuri Benditovich > > > > https://bugzilla.redhat.c

Re: [Qemu-devel] [PATCH v2 0/3] Introduce vhost-user-scsi and sample application

2016-11-10 Thread Michael S. Tsirkin
On Thu, Nov 10, 2016 at 05:49:16AM -0800, Felipe Franciosi wrote: > Based on various discussions on the 2016 KVM Forum, I'm sending over a > vhost-user-scsi implementation for your consideration. > > This patch set introduces a new vhost-user SCSI device. While heavily > based on vhost-scsi, it is

Re: [Qemu-devel] [PULL for-2.8 0/1] ipxe: update to 20161108 snapshot.

2016-11-10 Thread Laszlo Ersek
On 11/10/16 11:48, Stefan Hajnoczi wrote: > On Wed, Nov 09, 2016 at 10:09:24AM +0100, Gerd Hoffmann wrote: >> Hi, >> >> This rebases ipxe to latest master. ipxe qemu builds will not use >> fxsave/fxrestore any more, which caused problems on older intel cpus >> due to kvm not emulating these inst

Re: [Qemu-devel] [PATCH v2 2/3] vus: Introduce vhost-user-scsi host device

2016-11-10 Thread Marc-André Lureau
Hi On Thu, Nov 10, 2016 at 5:50 PM Felipe Franciosi wrote: > This commit introduces a vhost-user device for SCSI. This is based > on the existing vhost-scsi implementation, but done over vhost-user > instead. It also uses a chardev to connect to the backend. Unlike > vhost-scsi (today), VMs usin

[Qemu-devel] [Bug?] Guest pause because VMPTRLD failed in KVM

2016-11-10 Thread gong lei
Hello, We encountered a problem that a guest paused because the KMOD report VMPTRLD failed. The related information is as follows: 1) Qemu command: /usr/bin/qemu-kvm -name omu1 -S -machine pc-i440fx-2.3,accel=kvm,usb=off -cpu host -m 15625 -realtime mlock=off -smp 8,sockets=1,cores=8,threa

Re: [Qemu-devel] [PULL 12/47] virtio: remove ioeventfd_disabled altogether

2016-11-10 Thread Christian Borntraeger
On 10/30/2016 10:23 PM, Michael S. Tsirkin wrote: > From: Paolo Bonzini > > Now that there is not anymore a switch from the generic ioeventfd handler > to the dataplane handler, virtio_bus_set_host_notifier(assign=true) is > always called with !bus->ioeventfd_started, hence virtio_bus_stop_ioeven

Re: [Qemu-devel] [PULL 12/47] virtio: remove ioeventfd_disabled altogether

2016-11-10 Thread Paolo Bonzini
On 10/11/2016 15:35, Christian Borntraeger wrote: > On 10/30/2016 10:23 PM, Michael S. Tsirkin wrote: >> From: Paolo Bonzini >> >> Now that there is not anymore a switch from the generic ioeventfd handler >> to the dataplane handler, virtio_bus_set_host_notifier(assign=true) is >> always called

Re: [Qemu-devel] [PATCH] spapr-vty: Fix bad assert() statement

2016-11-10 Thread Paolo Bonzini
On 10/11/2016 10:06, Thomas Huth wrote: > When using the serial console in the GTK interface of QEMU (and > QEMU has been compiled with CONFIG_VTE), it is possible to trigger > the assert() statement in vty_receive() in spapr_vty.c by pasting > a chunk of text with length > 16 into the QEMU windo

Re: [Qemu-devel] [PULL 12/47] virtio: remove ioeventfd_disabled altogether

2016-11-10 Thread Christian Borntraeger
On 11/10/2016 03:38 PM, Paolo Bonzini wrote: > > > On 10/11/2016 15:35, Christian Borntraeger wrote: >> On 10/30/2016 10:23 PM, Michael S. Tsirkin wrote: >>> From: Paolo Bonzini >>> >>> Now that there is not anymore a switch from the generic ioeventfd handler >>> to the dataplane handler, virtio

Re: [Qemu-devel] [PATCH 0/4] make SMBUS/SATA/PIT configurable and introduce

2016-11-10 Thread Michael S. Tsirkin
On Sat, Nov 05, 2016 at 03:19:47AM -0400, Chao Peng wrote: > This patchset makes SMBUS/SATA/PIT configurable and introduces a new > machine type q35-lite with these features disabled by default. This is > useful for creating light weight virtual machine without boot time > penalty when these device

Re: [Qemu-devel] [PATCHv2 3/3] Split ISA and sysbus versions of m48t59 device

2016-11-10 Thread Paolo Bonzini
On 09/11/2016 13:22, David Gibson wrote: > The m48t59 device supports both ISA and direct sysbus attached versions of > the device in the one .c file. This can be awkward for some embedded > machine types which need the sysbus M48T59, but don't want to pull in the > ISA bus code and its other de

Re: [Qemu-devel] [PATCH v6 01/19] docs: new design document multi-thread-tcg.txt

2016-11-10 Thread Richard Henderson
On 11/09/2016 03:57 PM, Alex Bennée wrote: This documents the current design for upgrading TCG emulation to take advantage of modern CPUs by running a thread-per-CPU. The document goes through the various areas of the code affected by such a change and proposes design requirements for each part o

Re: [Qemu-devel] [PATCH v2] vhost: Update 'ioeventfd_started' with host notifiers

2016-11-10 Thread Christian Borntraeger
On 11/09/2016 01:44 PM, Felipe Franciosi wrote: > Following the recent refactor of virtio notfiers [1], more specifically > the patch that uses virtio_bus_set_host_notifier [2] by default, core > virtio code requires 'ioeventfd_started' to be set to true/false when > the host notifiers are configur

Re: [Qemu-devel] [PATCH] dma: rc4030: limit interval timer reload value

2016-11-10 Thread Paolo Bonzini
On 10/11/2016 06:56, Gonglei (Arei) wrote: > Any ideas about this fix? It seems sensible, but perhaps the field is even smaller. Let's CC Hervé and Aurelien as I don't have a datasheet for this device. Also, s->itr is used here: tm_hz = 1000 / (s->itr + 1); timer_mod(s->periodic_time

Re: [Qemu-devel] [PATCH v6 3/3] IOMMU: enable intel_iommu map and unmap notifiers

2016-11-10 Thread Michael S. Tsirkin
On Tue, Nov 08, 2016 at 01:04:24PM +0200, Aviv B.D wrote: > From: "Aviv Ben-David" > > Adds a list of registered vtd_as's to intel iommu state to save > iteration over each PCI device in a search of the corrosponding domain. > > Signed-off-by: Aviv Ben-David > --- > hw/i386/intel_iommu.c

Re: [Qemu-devel] [PATCH v6 0/3] IOMMU: intel_iommu support map and unmap notifications

2016-11-10 Thread Michael S. Tsirkin
On Tue, Nov 08, 2016 at 01:04:21PM +0200, Aviv B.D wrote: > From: "Aviv Ben-David" > > * Advertize Cache Mode capability in iommu cap register. > This capability is controlled by "cache-mode" property of intel-iommu > device. > To enable this option call QEMU with "-device intel-iommu,cache

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v12 0/2] virtio-crypto: virtio crypto device specification

2016-11-10 Thread Michael S. Tsirkin
On Sat, Nov 05, 2016 at 09:15:58AM +, Gonglei (Arei) wrote: > > > > Subject: [virtio-dev] Re: [PATCH v12 0/2] virtio-crypto: virtio crypto > > device > > specification > > > > On Mon, Oct 24, 2016 at 06:51:52AM +, Gonglei (Arei) wrote: > > > Ping > > > > > > And the corresponding sou

Re: [Qemu-devel] [PATCH] smbios: Add 1 terminator if there is any string field defined in given table.

2016-11-10 Thread Michael S. Tsirkin
On Tue, Sep 06, 2016 at 04:28:33PM +0800, Lin Ma wrote: > If user specifies binary file on command line to load smbios entries, then > will get error messages while decoding them in guest. > > Reproducer: > 1. dump a smbios table to a binary file from host or guest.(says table 1) > 2. load the bin

Re: [Qemu-devel] [PATCH v6 03/19] tcg: add kick timer for single-threaded vCPU emulation

2016-11-10 Thread Richard Henderson
On 11/09/2016 03:57 PM, Alex Bennée wrote: Currently we rely on the side effect of the main loop grabbing the iothread_mutex to give any long running basic block chains a kick to ensure the next vCPU is scheduled. As this code is being re-factored and rationalised we now do it explicitly here. S

Re: [Qemu-devel] [PATCHv2 3/3] Split ISA and sysbus versions of m48t59 device

2016-11-10 Thread Mark Cave-Ayland
On 10/11/16 14:57, Paolo Bonzini wrote: > > > On 09/11/2016 13:22, David Gibson wrote: >> The m48t59 device supports both ISA and direct sysbus attached versions of >> the device in the one .c file. This can be awkward for some embedded >> machine types which need the sysbus M48T59, but don't wa

[Qemu-devel] [PATCH v4 07/15] qapi: use one symbol per line

2016-11-10 Thread Marc-André Lureau
The documentation parser we are going to add only handles a single symbol per line. Signed-off-by: Marc-André Lureau --- qapi/block-core.json | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index c64a48c..e1cc94a 100644 ---

Re: [Qemu-devel] [PATCH v6 05/19] tcg: drop global lock during TCG code execution

2016-11-10 Thread Richard Henderson
On 11/09/2016 03:57 PM, Alex Bennée wrote: From: Jan Kiszka This finally allows TCG to benefit from the iothread introduction: Drop the global mutex while running pure TCG CPU code. Reacquire the lock when entering MMIO or PIO emulation, or when leaving the TCG loop. We have to revert a few op

[Qemu-devel] [PATCH v4 03/15] qga/schema: improve guest-set-vcpus Returns: section

2016-11-10 Thread Marc-André Lureau
The documentation parser we are going to add finishes a section after an empty line. Fix the Returns: section of guest-set-vcpus, and itemize the possible return values. Signed-off-by: Marc-André Lureau --- qga/qapi-schema.json | 12 1 file changed, 4 insertions(+), 8 deletions(-)

[Qemu-devel] [PATCH v4 05/15] qapi: fix missing symbol @prefix

2016-11-10 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- qapi-schema.json | 4 ++-- qapi/block-core.json | 4 ++-- qapi/crypto.json | 36 ++-- 3 files changed, 22 insertions(+), 22 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index

[Qemu-devel] [PATCH v4 15/15] build-sys: add qapi doc generation targets

2016-11-10 Thread Marc-André Lureau
Generate and install the man and html version of QAPI documentation. Add it also to optional pdf/dvi/info targets. Also support plain-text targets docs/qemu-ga-ref.txt & docs/qemu-qmp-ref.txt. Signed-off-by: Marc-André Lureau --- Makefile | 56

[Qemu-devel] [PATCH v4 00/15] qapi doc generation (whole version, squashed)

2016-11-10 Thread Marc-André Lureau
Add a qapi2texi script to generate the documentation from the qapi schemas. The 13th patch in this series is a squashed version of the documentation move from qmp-commands.txt to the schemas. The whole version (not sent on the ML to avoid spamming) is in the following git branch: https://github.co

[Qemu-devel] [PATCH v4 01/15] qapi: improve device_add schema

2016-11-10 Thread Marc-André Lureau
'device_add' is still incomplete for now, but we can fix a few arguments: - 'bus' is a common argument, regardless of the device - 'id' is an optionnal argument Signed-off-by: Marc-André Lureau --- qapi-schema.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qapi-sche

[Qemu-devel] [PATCH v4 09/15] qapi: add some sections in docs

2016-11-10 Thread Marc-André Lureau
Add some more section titles to organize the produced documents. Signed-off-by: Marc-André Lureau --- qapi-schema.json | 4 qapi/block-core.json | 6 -- qapi/block.json | 10 -- qapi/common.json | 6 -- qapi/crypto.json | 5 - qapi/event.json |

[Qemu-devel] [PATCH v4 11/15] qapi: add qapi2texi script

2016-11-10 Thread Marc-André Lureau
As the name suggests, the qapi2texi script converts JSON QAPI description into a texi file suitable for different target formats (info/man/txt/pdf/html...). It parses the following kind of blocks: Free-form: ## # = Section # == Subsection # # Some text foo with *emphasis* # 1. with a

[Qemu-devel] [PATCH v4 14/15] docs: add qemu logo

2016-11-10 Thread Marc-André Lureau
The pdf (needed by texi2pdf for vectorized images) was generated thanks to inkscape, from the pc-bios/qemu_logo.svg file. Move the original file in the docs folder too, since it's not being referenced elsewhere. Signed-off-by: Marc-André Lureau --- docs/qemu-ga-ref.texi | 4 doc

[Qemu-devel] [PATCH v4 04/15] qapi: fix schema symbol sections

2016-11-10 Thread Marc-André Lureau
According to docs/qapi-code-gen.txt, there needs to be '##' to start a and end a symbol section, that's also what the documentation parser expects. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- qapi-schema.json | 18 +- qapi/block-core.json | 1 + qga/qapi-sc

[Qemu-devel] [PATCH v4 02/15] qga/schema: fix double-return in doc

2016-11-10 Thread Marc-André Lureau
guest-get-memory-block-info documentation should have only one "Returns:". Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- qga/qapi-schema.json | 1 - 1 file changed, 1 deletion(-) diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json index c21f308..758803a 100644 --- a/qga/qap

[Qemu-devel] [PATCH v4 08/15] qapi: add missing colon-ending for section name

2016-11-10 Thread Marc-André Lureau
The documentation parser we are going to add expects a section name to end with ':', otherwise the comment is treated as free-form text body. Signed-off-by: Marc-André Lureau --- qapi-schema.json | 300 +-- qapi/block-core.json | 196 ++

[Qemu-devel] [PATCH for-2.8] megasas: do not call pci_dma_unmap after having freed the frame once

2016-11-10 Thread Paolo Bonzini
Commit 8cc4678 ("megasas: remove useless check for cmd->frame", 2016-07-17) was wrong because I trusted Coverity too much. It turns out that there _is_ a path through which cmd->frame can become NULL. After megasas_handle_frame's switch (md->frame->header.frame_cmd), megasas_init_firmware can be

[Qemu-devel] [PATCH v4 06/15] qapi: fix various symbols mismatch in documentation

2016-11-10 Thread Marc-André Lureau
There are various mismatch: - invalid symbols - section and member symbols mismatch - enum or union values vs 'type' The documentation parser catches all these cases. Signed-off-by: Marc-André Lureau --- qapi-schema.json | 20 +--- qapi/block-core.json | 4 qapi/common

[Qemu-devel] [PATCH v4 10/15] docs: add master qapi texi files

2016-11-10 Thread Marc-André Lureau
The qapi2texi script generates a file to be included in a texi file. Add "QEMU QMP Reference Manual" and "QEMU Guest Agent Protocol Reference" master texi files. Signed-off-by: Marc-André Lureau --- docs/qemu-ga-ref.texi | 78 ++ docs/qemu-qmp-ref

[Qemu-devel] [PATCH for-2.8] megasas: clean up and fix request completion/cancellation

2016-11-10 Thread Paolo Bonzini
megasas_command_cancel is a callback; it should report the abort in the frame, not try another abort! Compare for instance with mptsas_request_cancelled. So extract the common bits for request completion in a new function megasas_complete_command, call it from both the .complete and .cancel callb

Re: [Qemu-devel] [PATCH v4 14/15] docs: add qemu logo

2016-11-10 Thread Daniel P. Berrange
On Thu, Nov 10, 2016 at 07:22:08PM +0400, Marc-André Lureau wrote: > The pdf (needed by texi2pdf for vectorized images) was generated thanks > to inkscape, from the pc-bios/qemu_logo.svg file. Move the original file > in the docs folder too, since it's not being referenced elsewhere. I don't think

Re: [Qemu-devel] [PATCHv2 3/3] Split ISA and sysbus versions of m48t59 device

2016-11-10 Thread Paolo Bonzini
- Original Message - > From: "Mark Cave-Ayland" > To: "Paolo Bonzini" , "David Gibson" > , "edgar iglesias" > , mich...@walle.cc, pro...@gmail.com, > borntrae...@de.ibm.com, "cornelia huck" > , kbast...@mail.uni-paderborn.de, jcmvb...@gmail.com > Cc: veroniaba...@gmail.com, "peter mayd

Re: [Qemu-devel] [PULL for-2.8 0/1] ipxe: update to 20161108 snapshot.

2016-11-10 Thread Stefan Hajnoczi
On Thu, Nov 10, 2016 at 2:10 PM, Laszlo Ersek wrote: > On 11/10/16 11:48, Stefan Hajnoczi wrote: >> On Wed, Nov 09, 2016 at 10:09:24AM +0100, Gerd Hoffmann wrote: >>> Hi, >>> >>> This rebases ipxe to latest master. ipxe qemu builds will not use >>> fxsave/fxrestore any more, which caused proble

Re: [Qemu-devel] [PATCH v6 0/3] IOMMU: intel_iommu support map and unmap notifications

2016-11-10 Thread Alex Williamson
On Thu, 10 Nov 2016 17:14:24 +0200 "Michael S. Tsirkin" wrote: > On Tue, Nov 08, 2016 at 01:04:21PM +0200, Aviv B.D wrote: > > From: "Aviv Ben-David" > > > > * Advertize Cache Mode capability in iommu cap register. > > This capability is controlled by "cache-mode" property of intel-iommu >

Re: [Qemu-devel] [PATCH v6 0/3] IOMMU: intel_iommu support map and unmap notifications

2016-11-10 Thread Michael S. Tsirkin
On Thu, Nov 10, 2016 at 08:30:21AM -0700, Alex Williamson wrote: > On Thu, 10 Nov 2016 17:14:24 +0200 > "Michael S. Tsirkin" wrote: > > > On Tue, Nov 08, 2016 at 01:04:21PM +0200, Aviv B.D wrote: > > > From: "Aviv Ben-David" > > > > > > * Advertize Cache Mode capability in iommu cap register.

[Qemu-devel] [PATCH v4 12/15] texi2pod: learn quotation, deftp and deftypefn

2016-11-10 Thread Marc-André Lureau
Learn a few more markups used for API documentation. Signed-off-by: Marc-André Lureau --- scripts/texi2pod.pl | 44 +++- 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a/scripts/texi2pod.pl b/scripts/texi2pod.pl index 8767662..5df4b5f 100755 -

  1   2   3   >