Re: [Qemu-devel] [PATCH 0/3] hostmem-file: make option 'size' optional

2016-11-07 Thread Haozhong Zhang
On 11/07/16 08:52 +0100, Markus Armbruster wrote: Haozhong Zhang writes: This patch series is mostly the followup of patch 3 in "[PATCH v2 0/3] Improve truncation behavior of memory-backend-file" [1][2]. For certain usages of memory-backend-file, users simply want to use the entire backend fi

Re: [Qemu-devel] [PATCH] docs/block-replication.txt: Introduce nbd qmp commands

2016-11-07 Thread Changlong Xie
On 11/07/2016 03:50 PM, Markus Armbruster wrote: Changlong Xie writes: Signed-off-by: Changlong Xie --- docs/block-replication.txt | 22 +- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/docs/block-replication.txt b/docs/block-replication.txt index 6bde6

[Qemu-devel] [Bug 1637511] Re: Armitage crashes KVM guest with Kali2016.2 for QXL video

2016-11-07 Thread Thomas Huth
If it's related to QXL, you should likely rather report this bug to the Spice people instead of QEMU. See https://www.spice- space.org/support.html for more information. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.lau

Re: [Qemu-devel] [PATCH v4 7/8] qmp: Support abstract classes on device-list-properties

2016-11-07 Thread Markus Armbruster
Eduardo Habkost writes: > On Fri, Nov 04, 2016 at 04:45:17PM +0100, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > (CCing libvirt people, as I forgot to CC them) >> > >> > On Mon, Oct 31, 2016 at 03:07:23PM +0100, Igor Mammedov wrote: >> >> On Fri, 28 Oct 2016 23:48:06 -0200 >> >>

Re: [Qemu-devel] [PATCH for-2.8? 0/3] block/curl: Drop TFTP "support"

2016-11-07 Thread Markus Armbruster
Max Reitz writes: > On 03.11.2016 08:56, Markus Armbruster wrote: >> Max Reitz writes: >> >>> See patch 3 for the reason why we have actually never supported TFTP at >>> all (except for very small files (i.e. below 256 kB or so)). >> >> Care to explain why it works "for very small files" in a

[Qemu-devel] [PATCH 1/3] net: Add virtio queue interface to update used index from vring state

2016-11-07 Thread yuri . benditovich
From: Yuri Benditovich Bring virtio queue to correct internal state for host-to-guest operations when vhost is temporary stopped. Signed-off-by: Yuri Benditovich --- hw/virtio/virtio.c | 5 + include/hw/virtio/virtio.h | 1 + 2 files changed, 6 insertions(+) diff --git a/hw/virti

[Qemu-devel] [PATCH 0/3] virtio-net discards TX data after link down

2016-11-07 Thread yuri . benditovich
From: Yuri Benditovich https://bugzilla.redhat.com/show_bug.cgi?id=1295637 Upon set_link monitor command or upon netdev deletion virtio-net sends link down indication to the guest and stops vhost if one is used. Guest driver can still submit data for TX until it recognizes link loss. If these pac

[Qemu-devel] [PATCH 2/3] net: vhost stop updates virtio queue state

2016-11-07 Thread yuri . benditovich
From: Yuri Benditovich Prepare virtio queue for push operation from qemu after vhost was stopped. Signed-off-by: Yuri Benditovich --- hw/virtio/vhost.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index bd051ab..2e990d0 100644 --- a/hw/virtio/vhost.

[Qemu-devel] [PATCH 3/3] net: virtio-net discards TX data after link down

2016-11-07 Thread yuri . benditovich
From: Yuri Benditovich https://bugzilla.redhat.com/show_bug.cgi?id=1295637 Upon set_link monitor command or upon netdev deletion virtio-net sends link down indication to the guest and stops vhost if one is used. Guest driver can still submit data for TX until it recognizes link loss. If these pac

[Qemu-devel] [Bug 1500935] Re: Qemu / KVM always wants to be on top

2016-11-07 Thread AlainKnaff
Seems to be fixed by now. Indeed kvm no longer does this on none of the 2 distributions that I currently use (Debian 8.6.0 and Kubuntu 14.04.5) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1500935 T

Re: [Qemu-devel] [PATCH v4 06/20] ppc/pnv: add XSCOM infrastructure

2016-11-07 Thread Olaf Hering
On Mon, Oct 03, Cédric Le Goater wrote: > +++ b/include/hw/ppc/pnv_xscom.h > +typedef struct PnvChip PnvChip; This causes a compile error with gcc 4.5.1: ... [ 552s] In file included from /usr/src/packages/BUILD/qemu-20161104T092624.9226682/hw/ppc/pnv.c:29:0: [ 552s] /usr/src/packages/BUILD

[Qemu-devel] [Bug 1178107] Re: qemu-system-*.exe -cpu ? (or -M ?) exit silently

2016-11-07 Thread Thomas Huth
OK, so this is not a bug, but a feature of MiNGW (or SDL? ... now that you've mentioned it, I remember there was something similar in libSDL on Windows), thus let's close this ticket. ** Changed in: qemu Status: Incomplete => Invalid -- You received this bug notification because you are a

Re: [Qemu-devel] [PATCH v4 06/20] ppc/pnv: add XSCOM infrastructure

2016-11-07 Thread Cédric Le Goater
On 11/07/2016 09:26 AM, Olaf Hering wrote: > On Mon, Oct 03, Cédric Le Goater wrote: > >> +++ b/include/hw/ppc/pnv_xscom.h > >> +typedef struct PnvChip PnvChip; > > This causes a compile error with gcc 4.5.1: Ah yes. That happens with "old" compilers. I will remove the extra definition. Thank

Re: [Qemu-devel] [PATCH] s390x/kvm: fix run_on_cpu sigp conversions

2016-11-07 Thread Paolo Bonzini
On 07/11/2016 08:36, Fam Zheng wrote: > On Fri, 11/04 10:06, Paolo Bonzini wrote: >> >> >> On 02/11/2016 17:21, Cornelia Huck wrote: >>> Commit 14e6fe12a ("*_run_on_cpu: introduce run_on_cpu_data type") >>> attempted to convert all users of run_on_cpu to use the new >>> run_on_cpu_data type. It m

Re: [Qemu-devel] [PATCH v11 07/22] vfio iommu type1: Update argument of vaddr_get_pfn()

2016-11-07 Thread Alexey Kardashevskiy
On 05/11/16 08:10, Kirti Wankhede wrote: > Update arguments of vaddr_get_pfn() to take struct mm_struct *mm as input > argument. > > Signed-off-by: Kirti Wankhede > Signed-off-by: Neo Jia > Change-Id: I885fd4cd4a9f66f4ee2c1caf58267464ec239f52 > --- > drivers/vfio/vfio_iommu_type1.c | 30 +++

Re: [Qemu-devel] Crashing in tcp_close

2016-11-07 Thread Brian Candler
On 06/11/2016 18:04, Samuel Thibault wrote: Brian, could you run it with export MALLOC_CHECK_=2 and also this could be useful: export MALLOC_PERTURB_=1234 Also, to rule out the double-free scenario, and try to catch a buffer overflow coming from the socket structure itself, I have attached a

Re: [Qemu-devel] [PATCH] s390x/kvm: fix run_on_cpu sigp conversions

2016-11-07 Thread Fam Zheng
On Mon, 11/07 09:34, Paolo Bonzini wrote: > > > On 07/11/2016 08:36, Fam Zheng wrote: > > On Fri, 11/04 10:06, Paolo Bonzini wrote: > >> > >> > >> On 02/11/2016 17:21, Cornelia Huck wrote: > >>> Commit 14e6fe12a ("*_run_on_cpu: introduce run_on_cpu_data type") > >>> attempted to convert all users

Re: [Qemu-devel] [PATCH 1/2] virtio: allow per-device-class legacy features

2016-11-07 Thread Jason Wang
On 2016年11月04日 19:01, Michael S. Tsirkin wrote: Legacy features are those that transitional devices only expose on the legacy interface. Allow different ones per device class. Signed-off-by: Michael S. Tsirkin --- include/hw/virtio/virtio.h | 5 + hw/s390x/virtio-ccw.c | 4 +++-

Re: [Qemu-devel] [PATCH 2/2] virtio-net: mark VIRTIO_NET_F_GSO as legacy

2016-11-07 Thread Jason Wang
On 2016年11月04日 19:01, Michael S. Tsirkin wrote: virtio 1.0 spec says this is a legacy feature bit, hide it from guests in legacy mode. Note: for cross-version migration compatibility, we keep the bit set in host_features. The result will be that a guest migrating cross-version will see host fe

[Qemu-devel] 答复: Re: [PATCH v4 1/5] qom: Add interface check in object_class_is_abstract

2016-11-07 Thread Lin Ma
>>> Markus Armbruster 2016/11/4 星期五 上午 2:18 >>> >Lin Ma writes: > >> Signed-off-by: Lin Ma >> --- >> qom/object.c | 6 +- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/qom/object.c b/qom/object.c >> index 7a05e35..4096645 100644 >> --- a/qom/object.c >> +++ b/qom/ob

[Qemu-devel] [PATCH for-2.8] nfs: Fix memory leak in nfs_file_create()

2016-11-07 Thread Kevin Wolf
The leak was introduced in commit 94d6a7a7. Signed-off-by: Kevin Wolf --- block/nfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/nfs.c b/block/nfs.c index 55c4e0b..d082783 100644 --- a/block/nfs.c +++ b/block/nfs.c @@ -676,6 +676,7 @@ static int nfs_file_create(const char *url, Qe

[Qemu-devel] [PATCH 1/2] aio-posix: avoid NULL pointer dereference in aio_epoll_update

2016-11-07 Thread Paolo Bonzini
aio_epoll_update dereferences parameter "node", but it could have been NULL if deleting an fd handler that was not registered in the first place. Signed-off-by: Paolo Bonzini --- aio-posix.c | 33 ++--- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/a

[Qemu-devel] [PATCH 2/2] aio-posix: simplify aio_epoll_update

2016-11-07 Thread Paolo Bonzini
Extract common code out of the "if". Signed-off-by: Paolo Bonzini --- aio-posix.c | 23 --- 1 file changed, 8 insertions(+), 15 deletions(-) diff --git a/aio-posix.c b/aio-posix.c index ec908f7..d54553d 100644 --- a/aio-posix.c +++ b/aio-posix.c @@ -81,29 +81,22 @@ static vo

[Qemu-devel] [PATCH for-2.8 0/2] aio-posix: epoll cleanups

2016-11-07 Thread Paolo Bonzini
The first fixes a NULL-pointer dereference that was reported by Coverity (so definitely for 2.8). The second is a small simplification. Paolo Bonzini (2): aio-posix: avoid NULL pointer dereference in aio_epoll_update aio-posix: simplify aio_epoll_update aio-posix.c | 56

Re: [Qemu-devel] Sphinx for QEMU docs? (and a doc-comment format question)

2016-11-07 Thread Daniel P. Berrange
On Sat, Nov 05, 2016 at 06:42:23PM +, Peter Maydell wrote: > Hi; I had a play on Friday afternoon with Sphinx, which is the > restructured-text documentation processor that the Linux kernel is > just switching to for their documentation. My first impression is > that it would probably be useful

Re: [Qemu-devel] Crashing in tcp_close

2016-11-07 Thread Brian Candler
On 07/11/2016 08:42, Brian Candler wrote: The following crashes occurred when running with a single vcpu. Normally I have been running with -smp 8,sockets=1,cores=4,threads=2 as it seems to crash less with those settings; however I'm trying it again like that in a loop to see if I can get a cra

Re: [Qemu-devel] Wiki documentation organization

2016-11-07 Thread Cornelia Huck
On Fri, 4 Nov 2016 18:05:57 -0400 Programmingkid wrote: > It looks like the QEMU wiki is being organized into folders. I'm thinking the > page http://wiki.qemu.org/Documentation/Platforms/ should be a listing of all > the platforms QEMU currently supports. The list would be links to their > re

[Qemu-devel] [PATCH] qdev: fix use-after-free regression from becdfa00cfa

2016-11-07 Thread Marc-André Lureau
Spotted by Coverity, CID 1365383. Signed-off-by: Marc-André Lureau --- hw/core/qdev-properties-system.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/hw/core/qdev-properties-system.c b/hw/core/qdev-properties-system.c index c35f0f5..1b7ea50 100644 --- a/hw/core/qdev

Re: [Qemu-devel] [PATCH for-2.8 0/2] aio-posix: epoll cleanups

2016-11-07 Thread Fam Zheng
On Mon, 11/07 10:33, Paolo Bonzini wrote: > The first fixes a NULL-pointer dereference that was reported by > Coverity (so definitely for 2.8). The second is a small simplification. > > Paolo Bonzini (2): > aio-posix: avoid NULL pointer dereference in aio_epoll_update > aio-posix: simplify ai

Re: [Qemu-devel] Wiki documentation organization

2016-11-07 Thread Cornelia Huck
On Mon, 7 Nov 2016 10:39:32 +0100 Cornelia Huck wrote: > On Fri, 4 Nov 2016 18:05:57 -0400 > Programmingkid wrote: > > > It looks like the QEMU wiki is being organized into folders. I'm thinking > > the page http://wiki.qemu.org/Documentation/Platforms/ should be a listing > > of all the plat

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-11-07 Thread Stefan Hajnoczi
On Fri, Nov 04, 2016 at 06:30:47PM +, Ketan Nilangekar wrote: > > On Nov 4, 2016, at 2:52 AM, Stefan Hajnoczi wrote: > >> On Thu, Oct 20, 2016 at 01:31:15AM +, Ketan Nilangekar wrote: > >> 2. The idea of having multi-threaded epoll based network client was to > >> drive more throughput by

Re: [Qemu-devel] [Qemu-block] [PATCH] Added iopmem device emulation

2016-11-07 Thread Stefan Hajnoczi
On Fri, Nov 04, 2016 at 09:47:33AM -0600, Logan Gunthorpe wrote: > On 04/11/16 04:49 AM, Stefan Hajnoczi wrote: > > QEMU already has NVDIMM support (https://pmem.io/). It can be used both > > for passthrough and fake non-volatile memory: > > > > qemu-system-x86_64 \ > > -M pc,nvdimm=on \ >

Re: [Qemu-devel] Crashing in tcp_close

2016-11-07 Thread Stefan Hajnoczi
On Mon, Nov 07, 2016 at 08:42:17AM +, Brian Candler wrote: > On 06/11/2016 18:04, Samuel Thibault wrote: > > Brian, could you run it with > > > > export MALLOC_CHECK_=2 > > > > and also this could be useful: > > > > export MALLOC_PERTURB_=1234 > > > > Also, to rule out the double-free scena

[Qemu-devel] [PULL 2/4] nvic: set pending status for not active interrupts

2016-11-07 Thread Peter Maydell
From: Marcin Krzeminski According to ARM DUI 0552A 4.2.10. NVIC set pending status also for disabled interrupts. Correct the logic for when interrupts are marked pending both on input level transition and when interrupts are dismissed, to match the NVIC behaviour rather than the 11MPCore GIC. Si

[Qemu-devel] [PULL 0/4] target-arm queue

2016-11-07 Thread Peter Maydell
: Merge remote-tracking branch 'sstabellini/tags/xen-20161102-tag' into staging (2016-11-04 09:26:24 +) are available in the git repository at: git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20161107 for you to fetch changes up to 9706e0162d2405218fd7

[Qemu-devel] [PULL 4/4] hw/i2c/bitbang_i2c: Handle NACKs from devices

2016-11-07 Thread Peter Maydell
If the guest attempts to talk to a nonexistent device over i2c, the i2c_start_transfer() function will return non-zero, indicating that the bus is signalling a NACK. Similarly, if the i2c_send() function returns nonzero then the target device returned a NACK. Handle this possibility in the bitbang_

Re: [Qemu-devel] Mentor Summit notes

2016-11-07 Thread Stefan Hajnoczi
On Fri, Nov 04, 2016 at 10:35:04AM +0100, KONRAD Frederic wrote: > Le 01/11/2016 à 10:31, Stefan Hajnoczi a écrit : > > Valentine and I attended Google Summer of Code Mentor Summit on behalf > > of QEMU. The event brings together GSoC mentors from all > > participating organizations. > > > > A lo

[Qemu-devel] [PULL 1/4] char: cadence: check baud rate generator and divider values

2016-11-07 Thread Peter Maydell
From: Prasad J Pandit The Cadence UART device emulator calculates speed by dividing the baud rate by a 'baud rate generator' & 'baud rate divider' value. The device specification defines these register values to be non-zero and within certain limits. Add checks for these limits to avoid errors li

Re: [Qemu-devel] Mentor Summit notes

2016-11-07 Thread Stefan Hajnoczi
On Tue, Nov 01, 2016 at 09:21:20AM -0700, Alistair Francis wrote: > On Tue, Nov 1, 2016 at 2:31 AM, Stefan Hajnoczi wrote: > > Valentine and I attended Google Summer of Code Mentor Summit on behalf > > of QEMU. The event brings together GSoC mentors from all > > participating organizations. > > >

[Qemu-devel] [PULL 3/4] Fix corruption of CPSR when SCTLR.EE is set

2016-11-07 Thread Peter Maydell
From: Julian Brown Fix a typo in arm_cpu_do_interrupt_aarch32 (OR'ing with ~CPSR_E instead of CPSR_E) which meant that when we took an interrupt with SCTLR.EE set we would corrupt the CPSR. Signed-off-by: Julian Brown Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- target-arm/hel

Re: [Qemu-devel] [PATCH] tests/.gitignore: Ignore test-char

2016-11-07 Thread Marc-André Lureau
On Mon, Nov 7, 2016 at 8:52 AM Changlong Xie wrote: > Signed-off-by: Changlong Xie > Introduced in commit ea3af47d7 Reviewed-by: Marc-André Lureau > --- > tests/.gitignore | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/.gitignore b/tests/.gitignore > index c0d7857..e9b182

Re: [Qemu-devel] Crashing in tcp_close

2016-11-07 Thread Brian Candler
On 07/11/2016 10:42, Stefan Hajnoczi wrote: Let's try to isolate the cause of this crash: Are you able to switch -netdev user to -netdev tap so we can rule out the slirp user network stack as the source of memory corruption? Let me try to set that up. Using packer.io, I will have to start a VM b

[Qemu-devel] [PATCH 00/14] improve nvdimm hotplug

2016-11-07 Thread Xiao Guangrong
This patchset is against commit 72213633 (acpi: fix DMAR device scope for IOAPIC) on pci branch of Michael's git tree. It improves nvdimm hotplug based on the comments from Igor and Stefan during this release window Thanks! Xiao Guangrong (14): qdev: hotplug: drop HotplugHandler.post_plug call

[Qemu-devel] [PATCH 03/14] pc: memhp: move nvdimm hotplug out of memory hotplug

2016-11-07 Thread Xiao Guangrong
as they use completely different way to handle hotplug event Suggested-by: Igor Mammedov Signed-off-by: Xiao Guangrong --- default-configs/mips-softmmu-common.mak | 1 + docs/specs/acpi_mem_hotplug.txt | 3 --- docs/specs/acpi_nvdimm.txt | 5 + hw/acpi/ich9.c

[Qemu-devel] [PATCH 04/14] pc: memhp: stop handling nvdimm hotplug in pc_dimm_unplug

2016-11-07 Thread Xiao Guangrong
as it is never called when nvdimm hotplug happens Suggested-by: Igor Mammedov Signed-off-by: Xiao Guangrong --- hw/i386/pc.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 8ef3920..97e23c4 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -1761,12 +1761

[Qemu-devel] [PATCH 01/14] qdev: hotplug: drop HotplugHandler.post_plug callback

2016-11-07 Thread Xiao Guangrong
as nvdimm acpi is okay to build fit when the nvdimm device has not been 'realized' Suggested-by: Igor Mammedov Signed-off-by: Xiao Guangrong --- hw/acpi/nvdimm.c | 6 +- hw/core/hotplug.c| 11 --- hw/core/qdev.c | 20 hw/i386/pc.c | 23 +++

[Qemu-devel] [PATCH 11/14] nvdimm acpi: fix two comments

2016-11-07 Thread Xiao Guangrong
fixed the English issue and code-style issue Suggested-by: Stefan Hajnoczi Signed-off-by: Xiao Guangrong --- hw/acpi/nvdimm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c index c7e7744..6f6f51f 100644 --- a/hw/acpi/nvdimm.c +++ b/hw

[Qemu-devel] [PATCH 08/14] nvdimm acpi: cleanup nvdimm_build_fit

2016-11-07 Thread Xiao Guangrong
inline buf_size to refine the code a bit Suggested-by: Igor Mammedov Signed-off-by: Xiao Guangrong --- hw/acpi/nvdimm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c index f2c0659..148999e 100644 --- a/hw/acpi/nvdimm.c +++ b/hw/acpi/n

[Qemu-devel] [PATCH 07/14] nvdimm acpi: rename nvdimm_plugged_device_list

2016-11-07 Thread Xiao Guangrong
Its behavior has been changed as the nvdimm device which is being realized also will be handled in this function, so rename it to reflect the fact Suggested-by: Igor Mammedov Signed-off-by: Xiao Guangrong --- hw/acpi/nvdimm.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(

[Qemu-devel] [PATCH 02/14] nvdimm acpi: drop the lock of fit buffer

2016-11-07 Thread Xiao Guangrong
as there is a global lock to protect vm-exit handlers and QMP/monitor, this lock can be dropped Suggested-by: Igor Mammedov Signed-off-by: Xiao Guangrong --- hw/acpi/nvdimm.c| 11 +-- include/hw/mem/nvdimm.h | 17 + 2 files changed, 6 insertions(+), 22 deletions(

[Qemu-devel] [PATCH 14/14] nvdimm acpi: introduce NVDIMM_DSM_MEMORY_SIZE

2016-11-07 Thread Xiao Guangrong
and use it to replace the raw number Suggested-by: Igor Mammedov Signed-off-by: Xiao Guangrong --- hw/acpi/nvdimm.c | 30 +- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c index 5f48b75..8e7d6ec 100644 --- a/hw/acp

[Qemu-devel] [PATCH 06/14] docs: improve the doc of Read FIT method

2016-11-07 Thread Xiao Guangrong
Improve the description and clearly document the length field Suggested-by: Igor Mammedov Signed-off-by: Xiao Guangrong --- docs/specs/acpi_nvdimm.txt | 96 +++--- 1 file changed, 47 insertions(+), 49 deletions(-) diff --git a/docs/specs/acpi_nvdimm.txt

[Qemu-devel] [PATCH 05/14] nvdimm acpi: clean up nvdimm_build_acpi

2016-11-07 Thread Xiao Guangrong
To make the code more clearer, we 1) check ram_slots first, and build ssdt & nfit only when it is available 2) use nvdimm_get_plugged_device_list() to check if there is nvdimm device plugged Suggested-by: Igor Mammedov Signed-off-by: Xiao Guangrong --- hw/acpi/nvdimm.c | 30 -

[Qemu-devel] [PATCH 12/14] nvdimm acpi: rename nvdimm_dsm_reserved_root

2016-11-07 Thread Xiao Guangrong
Rename it to nvdimm_dsm_handle_reserved_root_method Suggested-by: Igor Mammedov Signed-off-by: Xiao Guangrong --- hw/acpi/nvdimm.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c index 6f6f51f..6692648 100644 --- a/hw/acpi/nvdimm.c

[Qemu-devel] [PATCH 09/14] nvdimm acpi: rename nvdimm_acpi_hotplug

2016-11-07 Thread Xiao Guangrong
Rename it to nvdimm_plug() Suggested-by: Igor Mammedov Signed-off-by: Xiao Guangrong --- hw/acpi/nvdimm.c| 2 +- hw/i386/pc.c| 2 +- include/hw/mem/nvdimm.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c index 14899

Re: [Qemu-devel] [PATCH] s390x/kvm: fix run_on_cpu sigp conversions

2016-11-07 Thread Stefan Hajnoczi
On Wed, Nov 02, 2016 at 05:21:03PM +0100, Cornelia Huck wrote: > Commit 14e6fe12a ("*_run_on_cpu: introduce run_on_cpu_data type") > attempted to convert all users of run_on_cpu to use the new > run_on_cpu_data type. It missed to change the called sigp_* routines, > however. Fix that. > > Fixes: 1

[Qemu-devel] [PATCH 10/14] nvdimm acpi: define DSM return codes

2016-11-07 Thread Xiao Guangrong
and use these codes to refine the code Suggested-by: Igor Mammedov Signed-off-by: Xiao Guangrong --- hw/acpi/nvdimm.c | 46 +++--- 1 file changed, 27 insertions(+), 19 deletions(-) diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c index 7733f14..c7e7744 1

[Qemu-devel] [PATCH 13/14] nvdimm acpi: use aml_name_decl to define named object

2016-11-07 Thread Xiao Guangrong
to make the code more clearer Suggested-by: Igor Mammedov Signed-off-by: Xiao Guangrong --- hw/acpi/nvdimm.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c index 6692648..5f48b75 100644 --- a/hw/acpi/nvdimm.c +++ b/hw/acpi/nvdimm.c

[Qemu-devel] [Bug 1410288] Re: qemu-img conversion to qcow2 hangs with blank image less than 100kiB

2016-11-07 Thread Robie Basak
qemu is 2.5 in 16.04 and 2.6.1 in Zesty, so this is presumably Fix Released now. If incorrect, please explain and reopen. ** Changed in: qemu (Ubuntu) Status: Triaged => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to Q

Re: [Qemu-devel] [PATCH] hw/input/hid: support alternative sysrq/break scancodes for gtk-vnc

2016-11-07 Thread Peter Korsgaard
Ping? Any feedback? Anything else needed? Original patch is here: http://patchwork.ozlabs.org/patch/688469/ On Fri, Oct 28, 2016 at 4:51 PM, Peter Korsgaard wrote: > The printscreen/sysrq and pause/break keys currently don't work for guests > using -usbdevice keyboard when accessed through vnc

Re: [Qemu-devel] [PATCH 0/5] target-m68k patches

2016-11-07 Thread Richard Henderson
On 11/06/2016 08:52 PM, Laurent Vivier wrote: Richard Henderson (4): target-m68k: Do not cpu_abort on undefined insns target-m68k: Inline shifts target-m68k: Implement bitfield ops for registers target-m68k: Implement bitfield ops for memory There is something wrong with the bitfield pa

[Qemu-devel] [PATCH] build-sys: remove libtool left-over

2016-11-07 Thread Marc-André Lureau
Libtool support was removed in commit e999ee44349, there is a few left-over. Signed-off-by: Marc-André Lureau --- Makefile | 6 ++ Makefile.objs | 1 - .gitignore| 2 -- configure | 2 -- 4 files changed, 2 insertions(+), 9 deletions(-) diff --git a/Makefile b/Makefile index 47

Re: [Qemu-devel] [PATCH 0/5] target-m68k patches

2016-11-07 Thread Laurent Vivier
Le 07/11/2016 à 13:08, Richard Henderson a écrit : > On 11/06/2016 08:52 PM, Laurent Vivier wrote: >>> Richard Henderson (4): >>> target-m68k: Do not cpu_abort on undefined insns >>> target-m68k: Inline shifts >>> target-m68k: Implement bitfield ops for registers >>> target-m68k: Implement

Re: [Qemu-devel] [PATCH v4 7/8] qmp: Support abstract classes on device-list-properties

2016-11-07 Thread Eduardo Habkost
On Mon, Nov 07, 2016 at 09:09:58AM +0100, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Fri, Nov 04, 2016 at 04:45:17PM +0100, Markus Armbruster wrote: > >> Eduardo Habkost writes: > >> > >> > (CCing libvirt people, as I forgot to CC them) > >> > > >> > On Mon, Oct 31, 2016 at 03:

Re: [Qemu-devel] [PATCH] build-sys: remove libtool left-over

2016-11-07 Thread Marc-André Lureau
On Mon, Nov 7, 2016 at 4:23 PM Marc-André Lureau < marcandre.lur...@redhat.com> wrote: > Libtool support was removed in commit e999ee44349, there is a few > left-over. > > Signed-off-by: Marc-André Lureau > --- > Makefile | 6 ++ > Makefile.objs | 1 - > .gitignore| 2 -- > configur

Re: [Qemu-devel] [PATCH v4 7/8] qmp: Support abstract classes on device-list-properties

2016-11-07 Thread Halil Pasic
On 10/29/2016 03:48 AM, Eduardo Habkost wrote: > When an abstract class is used on device-list-properties, we can > simply return the class properties registered for the class. > > This will be useful if management software needs to query for > supported options that apply to all devices of a gi

Re: [Qemu-devel] [PATCH for-2.8?] rules.mak: speedup save-vars load-vars

2016-11-07 Thread Stefan Hajnoczi
On Wed, Nov 02, 2016 at 05:24:01PM +0100, Paolo Bonzini wrote: > Unnesting variables spends a lot of time parsing and executing foreach > and if functions. Because actually very few variables have to be > saved and restored, a good strategy is to remember what has to be done > in load-vars, and on

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.8? 0/3] block/curl: Drop TFTP "support"

2016-11-07 Thread Stefan Hajnoczi
On Wed, Nov 02, 2016 at 06:55:36PM +0100, Max Reitz wrote: > See patch 3 for the reason why we have actually never supported TFTP at > all (except for very small files (i.e. below 256 kB or so)). I agree with dropping TFTP from the curl block driver but for the record: TFTP is not good for large

Re: [Qemu-devel] [PATCH v5 0/5] nvdimm: hotplug support

2016-11-07 Thread Stefan Hajnoczi
On Fri, Nov 04, 2016 at 10:51:43AM +0100, Igor Mammedov wrote: > On Fri, 4 Nov 2016 09:15:48 + > Stefan Hajnoczi wrote: > > On Fri, Nov 04, 2016 at 06:22:26AM +0200, Michael S. Tsirkin wrote: > > > On Fri, Nov 04, 2016 at 06:01:54AM +0200, Michael S. Tsirkin wrote: > > > > On Fri, Nov 04, 20

Re: [Qemu-devel] [PATCH v4 7/8] qmp: Support abstract classes on device-list-properties

2016-11-07 Thread Eduardo Habkost
On Mon, Nov 07, 2016 at 01:45:59PM +0100, Halil Pasic wrote: > > > On 10/29/2016 03:48 AM, Eduardo Habkost wrote: > > When an abstract class is used on device-list-properties, we can > > simply return the class properties registered for the class. > > > > This will be useful if management softwa

Re: [Qemu-devel] [PATCH RFC v2] tcmu: Introduce qemu-tcmu

2016-11-07 Thread Stefan Hajnoczi
On Fri, Nov 04, 2016 at 05:34:09PM +0800, Fam Zheng wrote: > RFC because only minimal scsi commands are now handled. The plan is to > refactor and reuse scsi-disk emulation code. Also there is no test code. > > Similar to NBD, there will be QMP commands to start built-in targets so > that guest im

Re: [Qemu-devel] [QEMU PATCH] kvmclock: advance clock by time window between vm_stop and pre_save

2016-11-07 Thread Dr. David Alan Gilbert
* Radim Krčmář (rkrc...@redhat.com) wrote: > 2016-11-04 15:07-0200, Marcelo Tosatti: > > On Fri, Nov 04, 2016 at 04:25:23PM +0100, Radim Krčmář wrote: > >> > +/* > >> > + * Transition from VM-running to VM-stopped via migration? > >> > + * Record when the VM was stopped. > >

Re: [Qemu-devel] [PATCH] docs/tracing.txt: Update documentation of default backend

2016-11-07 Thread Stefan Hajnoczi
On Fri, Nov 04, 2016 at 04:27:17PM +, Peter Maydell wrote: > In commit baf86d6b3c we switched the default trace backend from "nop" > to "log". Update the documentation to match. > > Signed-off-by: Peter Maydell > --- > docs/tracing.txt | 7 +-- > 1 file changed, 5 insertions(+), 2 deleti

Re: [Qemu-devel] [PATCH 0/5] target-m68k patches

2016-11-07 Thread Peter Maydell
On 7 November 2016 at 12:24, Laurent Vivier wrote: > If you want to have a try, this tree is based on tgt-m68k + what is > needed to boot an etch-m68k container. > > git://github.com/vivier/qemu-m68k.git for-rth You could try using 'risu' to do single-instruction level comprehensive testing, if y

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.8] block: Don't mark node clean after failed flush

2016-11-07 Thread Stefan Hajnoczi
On Sat, Nov 05, 2016 at 12:03:15AM +0100, Kevin Wolf wrote: > Commit 3ff2f67a changed bdrv_co_flush() so that no flush is issues if > the image hasn't been dirtied since the last flush. This is not quite > correct: The condition should be that the image hasn't been dirtied > since the last _success

Re: [Qemu-devel] Sphinx for QEMU docs? (and a doc-comment format question)

2016-11-07 Thread Stefan Hajnoczi
On Sat, Nov 05, 2016 at 06:42:23PM +, Peter Maydell wrote: > In particular I think we could: > * set up a framework for our in-tree docs/ which gives us a >place to put new docs (both for-users and for-developers) -- >I think having someplace to put things will reduce the barrier >

[Qemu-devel] [Bug 1639791] [NEW] early virtio console output is lost

2016-11-07 Thread Michal Suchanek
Public bug reported: This is broken in git and reportedly in 2.5 through 2.7. Running a Linux kernel which includes a testsuite in initrd sometimes produces no output. Reportedly the console is sometimes not open when the early userspace tries to log output resulting in either the testsuite term

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.8] nfs: Fix memory leak in nfs_file_create()

2016-11-07 Thread Stefan Hajnoczi
On Mon, Nov 07, 2016 at 10:31:29AM +0100, Kevin Wolf wrote: > The leak was introduced in commit 94d6a7a7. > > Signed-off-by: Kevin Wolf > --- > block/nfs.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

[Qemu-devel] [PATCH] Fix legacy ncurses detection.

2016-11-07 Thread Michal Suchanek
ncurses version in SUSE does not have .pc files so this is still needed to build from git. Signed-off-by: Michal Suchanek --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index fd6f898..aab70ef 100755 --- a/configure +++ b/configure @@ -2926

Re: [Qemu-devel] Sphinx for QEMU docs? (and a doc-comment format question)

2016-11-07 Thread Daniel P. Berrange
On Mon, Nov 07, 2016 at 01:30:45PM +, Stefan Hajnoczi wrote: > On Sat, Nov 05, 2016 at 06:42:23PM +, Peter Maydell wrote: > > In particular I think we could: > > * set up a framework for our in-tree docs/ which gives us a > >place to put new docs (both for-users and for-developers) --

Re: [Qemu-devel] [PATCH 0/5] target-m68k patches

2016-11-07 Thread Laurent Vivier
Le 07/11/2016 à 14:12, Peter Maydell a écrit : > On 7 November 2016 at 12:24, Laurent Vivier wrote: >> If you want to have a try, this tree is based on tgt-m68k + what is >> needed to boot an etch-m68k container. >> >> git://github.com/vivier/qemu-m68k.git for-rth > > You could try using 'risu' t

Re: [Qemu-devel] Migration dirty bitmap: should only mark pages as dirty after they have been sent

2016-11-07 Thread Chunguang Li
> -Original Messages- > From: "Li, Liang Z" > Sent Time: Friday, November 4, 2016 > To: "Chunguang Li" > Cc: "Dr. David Alan Gilbert" , "Amit Shah" > , "pbonz...@redhat.com" , > "qemu-devel@nongnu.org" , "stefa...@redhat.com" > , "quint...@redhat.com" > Subject: RE: RE: [Qemu-devel

[Qemu-devel] [Bug 678363] Re: Swapping caps lock and control causes qemu confusion

2016-11-07 Thread Michal Suchanek
Which interface is this? I suspect this behaves differently in GTK/SDL/... Also it seems to WorkForMe(tm) mostly. qemu tends to ignore the layout completely so installing same keymap in host and guest gives consistent result, and other configurations give inconsistent but correct result. -- You

Re: [Qemu-devel] Sphinx for QEMU docs? (and a doc-comment format question)

2016-11-07 Thread Peter Maydell
On 7 November 2016 at 13:30, Stefan Hajnoczi wrote: > You are suggesting Sphinx for two different purposes: > > 1. Formatting docs/ in HTML, PDF, etc. > > 2. API documentation from doc comments. > > It's a good idea for #1 since we can then publish automated builds of > the docs. They will be eas

Re: [Qemu-devel] [PATCH 0/5] target-m68k patches

2016-11-07 Thread Peter Maydell
On 7 November 2016 at 13:44, Laurent Vivier wrote: > I know risu, I would like to port it to m68k but for the moment it's too > much work. I think someone is already working on a port to PPC, perhaps > after that it will be easier to port it to m68k. Yes, I have the ppc patchset on my review queu

Re: [Qemu-devel] [PATCH V8] fsdev: add IO throttle support to fsdev devices

2016-11-07 Thread Pradeep Jagadeesh
Hi Greg, Sorry for the late reply, was out of office. I agree with all comments and fix them all. Also will send the patch soon. -Pradeep Hi Pradeep, There are still a couple of issues to address with this v8, even if we're not that far from the final version. On Sun, 30 Oct 2016 11:30:43 -0

Re: [Qemu-devel] [PATCH] Fix legacy ncurses detection.

2016-11-07 Thread Peter Maydell
On 7 November 2016 at 13:38, Michal Suchanek wrote: > ncurses version in SUSE does not have .pc files so this is still needed to > build from git. > > Signed-off-by: Michal Suchanek > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure >

Re: [Qemu-devel] Crashing in tcp_close

2016-11-07 Thread Stefan Hajnoczi
On Mon, Nov 07, 2016 at 11:09:10AM +, Brian Candler wrote: > On 07/11/2016 10:42, Stefan Hajnoczi wrote: > > Let's try to isolate the cause of this crash: > > > > Are you able to switch -netdev user to -netdev tap so we can rule out > > the slirp user network stack as the source of memory corr

Re: [Qemu-devel] [PATCH 0/5] target-m68k patches

2016-11-07 Thread Laurent Vivier
Le 07/11/2016 à 14:50, Peter Maydell a écrit : > On 7 November 2016 at 13:44, Laurent Vivier wrote: >> I know risu, I would like to port it to m68k but for the moment it's too >> much work. I think someone is already working on a port to PPC, perhaps >> after that it will be easier to port it to m

Re: [Qemu-devel] alpha platform is missing files after initrd load

2016-11-07 Thread Laszlo Ersek
On 11/07/16 08:37, Dennis Luehring wrote: > Am 04.11.2016 um 22:08 schrieb Richard Henderson: >> No, it was less specific than that. Something like "unpacking failed: >> error". >> >>> >And, apparently, it used to be handled with a panic() call, but then >>> that >>> >was deemed "policy", and down

Re: [Qemu-devel] alpha platform is missing files after initrd load

2016-11-07 Thread Laszlo Ersek
On 11/07/16 08:35, Dennis Luehring wrote: > Am 04.11.2016 um 20:40 schrieb Laszlo Ersek: >> I guess it is "possible to design a system which can recover from >> this", except noone seems to have bothered, since 2009. (Ditto for the >> proposed "panic-level=X" alternative.) >> >> I've now briefly co

Re: [Qemu-devel] Migration dirty bitmap: should only mark pages as dirty after they have been sent

2016-11-07 Thread Li, Liang Z
> > > > > > > > > I think this is "very" wasteful. Assume the workload > > > > > > > > > writes the pages > > > > > dirty randomly within the guest address space, and the transfer > > > > > speed is constant. Intuitively, I think nearly half of the dirty > > > > > pages produced in Iteration 1 is n

Re: [Qemu-devel] alpha platform is missing files after initrd load

2016-11-07 Thread Laszlo Ersek
On 11/07/16 15:15, Laszlo Ersek wrote: > On 11/07/16 08:35, Dennis Luehring wrote: >> Am 04.11.2016 um 20:40 schrieb Laszlo Ersek: >>> I guess it is "possible to design a system which can recover from >>> this", except noone seems to have bothered, since 2009. (Ditto for the >>> proposed "panic-lev

Re: [Qemu-devel] alpha platform is missing files after initrd load

2016-11-07 Thread Dennis Luehring
Am 07.11.2016 um 15:12 schrieb Laszlo Ersek: The second error message is incorrect in its own right (it's just another symptom of running out of memory; there a two cpios big(~370MB) initrd.cpio + 1GB ram gives only this message: "Initramfs unpacking failed: write error" small(~14MB) initrd.cp

Re: [Qemu-devel] [PATCH v4 7/8] qmp: Support abstract classes on device-list-properties

2016-11-07 Thread Markus Armbruster
Eduardo Habkost writes: > On Mon, Nov 07, 2016 at 09:09:58AM +0100, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > On Fri, Nov 04, 2016 at 04:45:17PM +0100, Markus Armbruster wrote: >> >> Eduardo Habkost writes: >> >> >> >> > (CCing libvirt people, as I forgot to CC them) >> >> >

[Qemu-devel] [PATCH v2 0/5]

2016-11-07 Thread Bastian Koppelmann
Hi, this series was originally posted by Peer Adelt some time ago[1], but still had some problems which I tried to fix with this patch set. The tricky bits here were the FTOUZ and MADD/MSUB.F instructions. The latter had the problem of not giving back the correct NAN when the result of the add/

[Qemu-devel] [PATCH v2 3/5] target-tricore: Added new MOV instruction variant

2016-11-07 Thread Bastian Koppelmann
From: Peer Adelt Puts the content of data register D[a] into E[c][63:32] and the content of data register D[b] into E[c][31:0]. [BK: fix style error] Signed-off-by: Peer Adelt Message-Id: <1465314555-11501-4-git-send-email-peer.ad...@c-lab.de> --- target-tricore/translate.c | 15

[Qemu-devel] [PATCH v2 4/5] target-tricore: Added new JNE instruction variant

2016-11-07 Thread Bastian Koppelmann
From: Peer Adelt If D[15] is != sign_ext(const4) then PC will be set to (PC + zero_ext(disp4 + 16)). [BK: fixed style errors] Signed-off-by: Peer Adelt Message-Id: <1465314555-11501-5-git-send-email-peer.ad...@c-lab.de> --- target-tricore/translate.c | 18 ++ target-trico

[Qemu-devel] [PATCH v2 5/5] target-tricore: Add updfl instruction

2016-11-07 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- target-tricore/fpu_helper.c | 12 target-tricore/helper.h | 1 + target-tricore/translate.c | 3 +++ 3 files changed, 16 insertions(+) diff --git a/target-tricore/fpu_helper.c b/target-tricore/fpu_helper.c index d530a0b..89de0ea 100644 --

Re: [Qemu-devel] Migration dirty bitmap: should only mark pages as dirty after they have been sent

2016-11-07 Thread Li, Liang Z
> > I compare SHA1 with XBZRLE. I use XBZRLE in two ways: > > 1. Begins to buffer pages from iteration 1; 2. As current > > implementation, begins to buffer pages from iteration 2. > > > > I post the results of three workloads: cpu2006.zeusmp, cpu2006.mcf, > > memcached. > > I set the cache size as

  1   2   3   4   >