Re: [Qemu-devel] [PATCH] docs: fix COLO architecture diagram

2016-11-01 Thread Zhang Chen
On 11/01/2016 02:25 PM, Hailiang Zhang wrote: Hmm, there are other contents in this file need to be updated, for example, we support blockdev-add command for nbd now, so we can convert the related hmp command to qmp command way. But since we didn't integrate COLO frame with block replication an

Re: [Qemu-devel] [PATCH v5 28/33] cputlb: make tlb_flush_by_mmuidx safe for MTTCG

2016-11-01 Thread Alex Bennée
Pranith Kumar writes: > Hi Alex, > > Alex Bennée writes: > >> These flushes allow a per-mmuidx granularity to the TLB flushing and are >> currently only used by the ARM model. As it is possible to hammer the >> other vCPU threads with flushes (and build up long queues of identical >> flushes) we

Re: [Qemu-devel] [PATCH v10 10/19] vfio iommu: Add blocking notifier to notify DMA_UNMAP

2016-11-01 Thread Kirti Wankhede
On 11/1/2016 9:15 AM, Dong Jia Shi wrote: > * Alex Williamson [2016-10-29 08:03:01 -0600]: > >> On Sat, 29 Oct 2016 16:07:05 +0530 >> Kirti Wankhede wrote: >> >>> On 10/29/2016 2:03 AM, Alex Williamson wrote: On Sat, 29 Oct 2016 01:32:35 +0530 Kirti Wankhede wrote: > On

Re: [Qemu-devel] [PATCH v5 28/33] cputlb: make tlb_flush_by_mmuidx safe for MTTCG

2016-11-01 Thread Peter Maydell
On 1 November 2016 at 07:45, Alex Bennée wrote: > > Pranith Kumar writes: >> FYI, this is causing a build error on my system with gcc 6.2. >> >> CC aarch64-softmmu/cputlb.o >> In file included from >> /home/pranith/devops/code/qemu/include/qemu/osdep.h:36:0, >> from /home

Re: [Qemu-devel] [PATCH v10 05/19] vfio iommu: Added pin and unpin callback functions to vfio_iommu_driver_ops

2016-11-01 Thread Jike Song
On 10/27/2016 05:29 AM, Kirti Wankhede wrote: > Added two new callback functions to struct vfio_iommu_driver_ops. Backend > IOMMU module that supports pining and unpinning pages for mdev devices > should provide these functions. > Added APIs for pining and unpining pages to VFIO module. These calls

Re: [Qemu-devel] [PATCH v10 10/19] vfio iommu: Add blocking notifier to notify DMA_UNMAP

2016-11-01 Thread Dong Jia Shi
* Kirti Wankhede [2016-11-01 13:17:19 +0530]: > > > On 11/1/2016 9:15 AM, Dong Jia Shi wrote: > > * Alex Williamson [2016-10-29 08:03:01 -0600]: > > > >> On Sat, 29 Oct 2016 16:07:05 +0530 > >> Kirti Wankhede wrote: > >> > >>> On 10/29/2016 2:03 AM, Alex Williamson wrote: > On Sat, 29 O

Re: [Qemu-devel] [PATCH v10 00/19] Add Mediated device support

2016-11-01 Thread Jike Song
On 10/27/2016 05:29 AM, Kirti Wankhede wrote: > This series adds Mediated device support to Linux host kernel. Purpose > of this series is to provide a common interface for mediated device > management that can be used by different devices. This series introduces > Mdev core module that creates and

Re: [Qemu-devel] [PATCH v5] block/vxhs.c Add support for a new block device type called "vxhs"

2016-11-01 Thread Daniel P. Berrange
On Mon, Oct 31, 2016 at 11:34:58PM -0700, Ashish Mittal wrote: > Source code for the qnio library that this code loads can be downloaded > from: > https://github.com/MittalAshish/libqnio.git Your patch is unable to compile against this, because the qnio_api.h header is using a "struct iovec" type

Re: [Qemu-devel] [PULL 0/2] x86 and machine queue, 2016-10-31

2016-11-01 Thread Peter Maydell
On 31 October 2016 at 18:30, Eduardo Habkost wrote: > The following changes since commit 6bc56d317f7b5004ea2d89d264bddc8b4d081700: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream-mttcg' into > staging (2016-10-31 15:29:12 +) > > are available in the git repository at: >

[Qemu-devel] Mentor Summit notes

2016-11-01 Thread Stefan Hajnoczi
Valentine and I attended Google Summer of Code Mentor Summit on behalf of QEMU. The event brings together GSoC mentors from all participating organizations. A lot of people benefit from QEMU and told me so at the summit. There are also many who hadn't heard of QEMU before. I gave a lightning ta

Re: [Qemu-devel] [PULL 08/27] hostmem-file: make option 'size' optional

2016-11-01 Thread Haozhong Zhang
On 10/31/16 20:22 -0200, Eduardo Habkost wrote: On Mon, Oct 31, 2016 at 03:47:53PM -0400, Paolo Bonzini wrote: - Original Message - > From: "Eduardo Habkost" > To: "Paolo Bonzini" > Cc: qemu-devel@nongnu.org, "Haozhong Zhang" > Sent: Monday, October 31, 2016 7:20:10 PM > Subject: Re

Re: [Qemu-devel] [PATCH v2] qxl: Only emit QXL_INTERRUPT_CLIENT_MONITORS_CONFIG on config changes

2016-11-01 Thread Gerd Hoffmann
> This commit makes sure that we only emit > QXL_INTERRUPT_CLIENT_MONITORS_CONFIG when there are actual configuration > changes the guest should act on. Added to vga queue. thanks, Gerd

[Qemu-devel] [PATCH] virtio-gpu: fix information leak in getting capset info dispatch

2016-11-01 Thread Li Qiang
From: Li Qiang In virgl_cmd_get_capset_info dispatch function, the 'resp' hasn't been full initialized before writing to the guest. This will leak the 'resp.padding' and 'resp.hdr.padding' fieds to the guest. This patch fix this issue. Signed-off-by: Li Qiang --- hw/display/virtio-gpu-3d.c | 1

Re: [Qemu-devel] [PATCH 2/4] block/curl: Fix return value from curl_read_cb

2016-11-01 Thread Matthew Booth
I've long since lost all context on this patch, so I'll trust you :) Thanks for the ping, Matt On Wed, Oct 26, 2016 at 10:17 AM, Kevin Wolf wrote: > Am 25.10.2016 um 20:37 hat Eric Blake geschrieben: > > On 10/24/2016 09:54 PM, Max Reitz wrote: > > > While commit 38bbc0a580f9f10570b1d1b5d3e92f

Re: [Qemu-devel] [PATCH 1/6] tests/docker/Makefile.include: fix diff-index call

2016-11-01 Thread Alex Bennée
Fam Zheng writes: > On Fri, 10/28 17:33, Alex Bennée wrote: >> The whole thing is wrapped inside a call quiet-command as well as being >> the actual call taking a --quiet argument so the redirect is >> superfluous. For reasons I have yet to determine this also seems to be >> causing the source p

Re: [Qemu-devel] [PATCH 3/3] Move getting XWindow ID from baum driver to graphical backend

2016-11-01 Thread Gerd Hoffmann
Hi, > typedef void QemuConsoleConfigListener(void); I think we should also pass the console which has changed: QemuConsoleConfigListener(QemuConsole *con); > qemu_console_config_add_listener(QemuConsoleConfigListener listener); > qemu_console_config_remove_listener(QemuConsoleConfigListener

Re: [Qemu-devel] [PATCH 1/4] console: add API to get underlying gui window ID

2016-11-01 Thread Gerd Hoffmann
> int qemu_console_get_width(QemuConsole *con, int fallback); > int qemu_console_get_height(QemuConsole *con, int fallback); > +/* Return the low-level window id for the first graphical console */ > +int qemu_graphic_console_get_window_id(void); > +void qemu_console_set_window_id(int index, int w

Re: [Qemu-devel] [RFC 1/2] linux-headers: update

2016-11-01 Thread Peter Maydell
On 29 October 2016 at 22:10, Alexander Graf wrote: > This patch updates the Linux headers to include the in-progress user > space ARM timer patches. It is explicitly RFC, as the patches are not > merged yet. > --- Is there a cover letter email for this series ? thanks -- PMM

Re: [Qemu-devel] [PATCH 1/1] migration: fix compiler warning on uninitialized variable

2016-11-01 Thread Peter Maydell
On 31 October 2016 at 21:50, Jeff Cody wrote: > Some older GCC versions (e.g. 4.4.7) report a warning on an > uninitialized variable for 'request', even though all possible code > paths that reference 'request' will be initialized. To appease > these versions, initialize the variable to 0. > > R

Re: [Qemu-devel] [PULL 00/14] Block patches for 2.8

2016-11-01 Thread Peter Maydell
On 31 October 2016 at 19:22, Jeff Cody wrote: > The following changes since commit 6bc56d317f7b5004ea2d89d264bddc8b4d081700: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream-mttcg' into > staging (2016-10-31 15:29:12 +) > > are available in the git repository at: > > g.

Re: [Qemu-devel] [PULL 37/47] nvdimm acpi: introduce fit buffer

2016-11-01 Thread Igor Mammedov
On Tue, 1 Nov 2016 11:30:46 +0800 Xiao Guangrong wrote: > On 10/31/2016 07:09 PM, Igor Mammedov wrote: > > On Mon, 31 Oct 2016 17:52:24 +0800 > > Xiao Guangrong wrote: > > > >> On 10/31/2016 05:45 PM, Igor Mammedov wrote: > >>> On Sun, 30 Oct 2016 23:25:05 +0200 > >>> "Michael S. Tsirkin" w

Re: [Qemu-devel] [PATCH 1/6] tests/docker/Makefile.include: fix diff-index call

2016-11-01 Thread Fam Zheng
On Tue, 11/01 10:02, Alex Bennée wrote: > > Fam Zheng writes: > > > On Fri, 10/28 17:33, Alex Bennée wrote: > >> The whole thing is wrapped inside a call quiet-command as well as being > >> the actual call taking a --quiet argument so the redirect is > >> superfluous. For reasons I have yet to d

[Qemu-devel] [PATCH] virtio-gpu: fix memory leak in update_cursor_data_virgl

2016-11-01 Thread Li Qiang
From: Li Qiang In update_cursor_data_virgl function, if the 'width'/ 'height' is not equal to current cursor's width/height it will return without free the 'data' allocated previously. This will lead a memory leak issue. This patch fix this issue. Signed-off-by: Li Qiang --- hw/display/virtio-

Re: [Qemu-devel] [PATCH] virtio-gpu: fix information leak in getting capset info dispatch

2016-11-01 Thread Gerd Hoffmann
On Di, 2016-11-01 at 02:53 -0700, Li Qiang wrote: > From: Li Qiang > > In virgl_cmd_get_capset_info dispatch function, the 'resp' hasn't > been full initialized before writing to the guest. This will leak > the 'resp.padding' and 'resp.hdr.padding' fieds to the guest. This > patch fix this issue.

Re: [Qemu-devel] [PATCH] virtio-gpu: fix memory leak in update_cursor_data_virgl

2016-11-01 Thread Gerd Hoffmann
On Di, 2016-11-01 at 04:06 -0700, Li Qiang wrote: > From: Li Qiang > > In update_cursor_data_virgl function, if the 'width'/ 'height' > is not equal to current cursor's width/height it will return > without free the 'data' allocated previously. This will lead > a memory leak issue. This patch fix

Re: [Qemu-devel] [PATCH] virtio-gpu: fix memory leak in update_cursor_data_virgl

2016-11-01 Thread Marc-André Lureau
Hi On Tue, Nov 1, 2016 at 2:07 PM Li Qiang wrote: > From: Li Qiang > > In update_cursor_data_virgl function, if the 'width'/ 'height' > is not equal to current cursor's width/height it will return > without free the 'data' allocated previously. This will lead > a memory leak issue. This patch f

Re: [Qemu-devel] [PULL] Update OpenBIOS images

2016-11-01 Thread Peter Maydell
On 31 October 2016 at 20:25, Mark Cave-Ayland wrote: > Hi Peter, > > Here are the OpenBIOS updates for the 2.8 release. Please pull. > > > ATB, > > Mark. > > > The following changes since commit e80b4b8fb6babce7dcc91ea9ddeecbc351fd4646: > > Merge remote-tracking branch > 'remotes/awilliam/tags/

Re: [Qemu-devel] [RFC 2/2] ARM: KVM: Enable in-kernel timers with user space gic

2016-11-01 Thread Peter Maydell
On 29 October 2016 at 22:10, Alexander Graf wrote: > When running with KVM enabled, you can choose between emulating the > gic in kernel or user space. If the kernel supports in-kernel virtualization > of the interrupt controller, it will default to that. If not, if will > default to user space em

Re: [Qemu-devel] [PATCH 1/6] tests/docker/Makefile.include: fix diff-index call

2016-11-01 Thread Alex Bennée
Fam Zheng writes: > On Tue, 11/01 10:02, Alex Bennée wrote: >> >> Fam Zheng writes: >> >> > On Fri, 10/28 17:33, Alex Bennée wrote: >> >> The whole thing is wrapped inside a call quiet-command as well as being >> >> the actual call taking a --quiet argument so the redirect is >> >> superfluous.

Re: [Qemu-devel] [PULL v2 for-2.8 00/15] target-sparc updates

2016-11-01 Thread Peter Maydell
On 31 October 2016 at 20:50, Richard Henderson wrote: > V2 with a workaround for win32 namespace pollution. Whee! > Only resending patch 09/15, wherein the change lies. > > > r~ > > > The following changes since commit 4178c782f85530d261058abdccc734aa9b7c89ca: > > Merge remote-tracking branch

Re: [Qemu-devel] [PULL 00/14] Block patches for 2.8

2016-11-01 Thread Jeff Cody
On Tue, Nov 01, 2016 at 10:23:59AM +, Peter Maydell wrote: > On 31 October 2016 at 19:22, Jeff Cody wrote: > > The following changes since commit 6bc56d317f7b5004ea2d89d264bddc8b4d081700: > > > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream-mttcg' > > into staging (2016-1

[Qemu-devel] [PULL v2 for-2.8 5/7] 9pfs: xattrcreate requires non-opened fids

2016-11-01 Thread Greg Kurz
The xattrcreate operation only makes sense on a freshly cloned fid actually, since any open state would be leaked because of the fid_type change. This is indeed what the linux kernel client does: fid = clone_fid(fid); [...] retval = p9_client_xattrcreate(fid, name, value_le

[Qemu-devel] [PULL v2 for-2.8 0/7] 9p patches for 2.8 20161030

2016-11-01 Thread Greg Kurz
The following changes since commit 02ba9265e8d65f24d0cdca158d96e0b0451f6b71: migration: fix compiler warning on uninitialized variable (2016-11-01 09:31:53 +) are available in the git repository at: https://github.com/gkurz/qemu.git tags/for-upstream for you to fetch changes up to 79de

[Qemu-devel] [PULL v2 for-2.8 1/7] 9pfs: add xattrwalk_fid field in V9fsXattr struct

2016-11-01 Thread Greg Kurz
From: Li Qiang Currently, 9pfs sets the 'copied_len' field in V9fsXattr to -1 to tag xattr walk fid. As the 'copied_len' is also used to account for copied bytes, this may make confusion. This patch add a bool 'xattrwalk_fid' to tag the xattr walk fid. Suggested-by: Greg Kurz Signed-off-by: Li

[Qemu-devel] [PULL v2 for-2.8 3/7] 9pfs: fix integer overflow issue in xattr read/write

2016-11-01 Thread Greg Kurz
From: Li Qiang The v9fs_xattr_read() and v9fs_xattr_write() are passed a guest originated offset: they must ensure this offset does not go beyond the size of the extended attribute that was set in v9fs_xattrcreate(). Unfortunately, the current code implement these checks with unsafe calculations

[Qemu-devel] [PULL v2 for-2.8 7/7] 9pfs: drop excessive error message from virtfs_reset()

2016-11-01 Thread Greg Kurz
The virtfs_reset() function is called either when the virtio-9p device gets reset, or when the client starts a new 9P session. In both cases, if it finds fids from a previous session, the following is printed in the monitor: 9pfs:virtfs_reset: One or more uncluncked fids found during reset For ex

[Qemu-devel] [PULL v2 for-2.8 2/7] 9pfs: convert 'len/copied_len' field in V9fsXattr to the type of uint64_t

2016-11-01 Thread Greg Kurz
From: Li Qiang The 'len' in V9fsXattr comes from the 'size' argument in setxattr() function in guest. The setxattr() function's declaration is this: int setxattr(const char *path, const char *name, const void *value, size_t size, int flags); and 'size' is treated as u64 in linux ke

[Qemu-devel] [PULL v2 for-2.8 4/7] 9pfs: limit xattr size in xattrcreate

2016-11-01 Thread Greg Kurz
We shouldn't allow guests to create extended attribute with arbitrary sizes. On linux hosts, the limit is XATTR_SIZE_MAX. Let's use it. Signed-off-by: Greg Kurz --- hw/9pfs/9p.c | 7 ++- hw/9pfs/trace-events | 2 +- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/hw/9p

[Qemu-devel] [PULL v2 for-2.8 6/7] 9pfs: don't BUG_ON() if fid is already opened

2016-11-01 Thread Greg Kurz
A buggy or malicious guest could pass the id of an already opened fid and cause QEMU to abort. Let's return EINVAL to the guest instead. Signed-off-by: Greg Kurz Reviewed-by: Eric Blake --- hw/9pfs/9p.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/hw

[Qemu-devel] [PULL v2 for-2.8 5/9] tcg: Add tcg_gen_mulsu2_{i32, i64, tl}

2016-11-01 Thread Richard Henderson
This multiply has one signed input and one unsigned input, producing the full double-width result. Signed-off-by: Richard Henderson Message-Id: <1475011433-24456-2-git-send-email-...@twiddle.net> --- tcg/tcg-op.c | 43 +++ tcg/tcg-op.h | 4 2 files c

[Qemu-devel] [PULL v2 for-2.8 1/9] target-cris: Do not dump cpu state with -d in_asm

2016-11-01 Thread Richard Henderson
Dumping cpu state is what -d cpu is for. Reviewed-by: Edgar E. Iglesias Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target-cris/translate.c | 25 ++--- 1 file changed, 2 insertions(+), 23 deletions(-) diff --git a/target-cris/translate.c b/target-cris/tra

[Qemu-devel] [PULL v2 for-2.8 2/9] target-microblaze: Do not dump cpu state with -d in_asm

2016-11-01 Thread Richard Henderson
Dumping cpu state is what -d cpu is for. Reviewed-by: Edgar E. Iglesias Signed-off-by: Richard Henderson --- target-microblaze/translate.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/target-microblaze/translate.c b/target-microblaze/translate.c index 80098ec..5a4

[Qemu-devel] [PULL v2 for-2.8 0/9] tcg queued patches

2016-11-01 Thread Richard Henderson
nce commit e80b4b8fb6babce7dcc91ea9ddeecbc351fd4646: Merge remote-tracking branch 'remotes/awilliam/tags/vfio-updates-20161031.0' into staging (2016-10-31 18:19:06 +) are available in the git repository at: git://github.com/rth7680/qemu.git tags/pull-tcg-20161101 for you to

[Qemu-devel] [PULL v2 for-2.8 7/9] MAINTAINERS: Update PPC status and maintainer

2016-11-01 Thread Richard Henderson
From: Pranith Kumar Richard agreed to make odd fixes to PPC tcg parts[1]. This patch makes the change. [1] https://lists.gnu.org/archive/html/qemu-ppc/2016-03/msg00657.html Signed-off-by: Pranith Kumar Signed-off-by: Richard Henderson --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+)

[Qemu-devel] [PULL v2 for-2.8 3/9] target-openrisc: Do not dump cpu state with -d in_asm

2016-11-01 Thread Richard Henderson
Dumping cpu state is what -d cpu is for. Cc: Jia Liu Signed-off-by: Richard Henderson --- target-openrisc/translate.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/target-openrisc/translate.c b/target-openrisc/translate.c index 28c9446..a4625f9 100644 --- a/target-o

[Qemu-devel] [PULL v2 for-2.8 6/9] target-microblaze: Cleanup dec_mul

2016-11-01 Thread Richard Henderson
Use tcg_gen_mul_tl for muli and mul instructions. Use tcg_gen_muls2_tl for mulh instruction. Use tcg_gen_mulu2_tl for mulhu instruction. Use tcg_gen_mulsu2_tl for mulhsu instruction. Note that this last fixes a bug, in that mulhsu was previously treating both operands as signed, instead of treatin

[Qemu-devel] [PULL v2 for-2.8 9/9] tcg: correct 32-bit tcg_gen_ld8s_i64 sign-extension

2016-11-01 Thread Richard Henderson
From: Joseph Myers The version of tcg_gen_ld8s_i64 for 32-bit systems does a load into the low part of the return value - then attempts a sign extension into the high part, but wrongly sets the high part to a sign extension of itself rather than of the low part. This results in TCG internal erro

[Qemu-devel] [PULL v2 for-2.8 4/9] log: Add locking to large logging blocks

2016-11-01 Thread Richard Henderson
Reuse the existing locking provided by stdio to keep in_asm, cpu, op, op_opt, op_ind, and out_asm as contiguous blocks. While it isn't possible to interleave e.g. in_asm or op_opt logs because of the TB lock protecting all code generation, it is possible to interleave cpu logs, or to interleave a

[Qemu-devel] [PULL v2 for-2.8 8/9] tcg/tcg.h: Improve documentation of TCGv_i32 etc types

2016-11-01 Thread Richard Henderson
From: Peter Maydell The typedefs we use for the TCGv_i32, TCGv_i64 and TCGv_ptr types are somewhat confusing, because we define them as pointers to structs, but the structs themselves are never defined. Explain in the comments a bit more clearly why this is OK and what is going on under the hood.

Re: [Qemu-devel] [PATCH v3 1/2] target-m68k: add 64bit mull

2016-11-01 Thread Richard Henderson
On 10/31/2016 05:48 PM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier --- target-m68k/translate.c | 62 +++-- 1 file changed, 50 insertions(+), 12 deletions(-) Reviewed-by: Richard Henderson r~

[Qemu-devel] [PATCH v1 1/1] qemu-doc: update gluster protocol usage guide

2016-11-01 Thread Prasanna Kumar Kalever
Document: 1. The new debug and logfile options with their usages and 2. New json format and its usage. Signed-off-by: Prasanna Kumar Kalever --- qemu-doc.texi | 46 -- qemu-options.hx | 14 -- 2 files changed, 44 insertions(+), 16 deletio

Re: [Qemu-devel] [PATCH v3 2/2] target-m68k: add 680x0 divu/divs variants

2016-11-01 Thread Richard Henderson
On 10/31/2016 05:48 PM, Laurent Vivier wrote: +void HELPER(divull)(CPUM68KState *env, int numr, int regr, uint32_t den) +{ +uint32_t num = env->dregs[numr]; uint64_t num = deposit64(env->dregs[numr], 32, 32, env->dregs[regr]); Similarly in divsll with int64_t num. +if (!((quot >> 3

[Qemu-devel] [PATCH] virtio-gpu: fix information leak in capset get dispatch

2016-11-01 Thread Li Qiang
From: Li Qiang In virgl_cmd_get_capset function, it uses g_malloc to allocate a response struct to the guest. As the 'resp'struct hasn't been full initialized it will lead the 'resp->padding' field to the guest. Use g_malloc0 to avoid this. Signed-off-by: Li Qiang --- hw/display/virtio-gpu-3d.

Re: [Qemu-devel] [PULL 00/47] virtio, pc: fixes and features

2016-11-01 Thread Peter Maydell
On 31 October 2016 at 22:48, Michael S. Tsirkin wrote: > On Mon, Oct 31, 2016 at 10:50:31AM +0100, Igor Mammedov wrote: >> On Sun, 30 Oct 2016 23:23:18 +0200 >> "Michael S. Tsirkin" wrote: >> >> > The following changes since commit >> > 5b2ecabaeabc17f032197246c4846b9ba95ba8a6: >> > >> > Merge

Re: [Qemu-devel] [PULL for-2.8 0/5] qemu-ga patch queue for 2.8

2016-11-01 Thread Peter Maydell
On 1 November 2016 at 00:59, Michael Roth wrote: > The following changes since commit e80b4b8fb6babce7dcc91ea9ddeecbc351fd4646: > > Merge remote-tracking branch > 'remotes/awilliam/tags/vfio-updates-20161031.0' into staging (2016-10-31 > 18:19:06 +) > > are available in the git repository

[Qemu-devel] [PULL v2 02/14] rbd: make the code more readable

2016-11-01 Thread Jeff Cody
From: Xiubo Li Make it a bit clearer and more readable. Signed-off-by: Xiubo Li Reviewed-by: Stefan Hajnoczi Reviewed-by: John Snow Reviewed-by: Jeff Cody Message-id: 1476519973-6436-1-git-send-email-lixi...@cmss.chinamobile.com CC: John Snow Signed-off-by: Jeff Cody --- block/rbd.c | 29

[Qemu-devel] [PULL v2 00/14] Block patches for 2.8

2016-11-01 Thread Jeff Cody
The following changes since commit bf99fd3983d7185178a0f65ce29bb94b1aecaed1: Merge remote-tracking branch 'remotes/rth/tags/pull-sparc-20161031-2' into staging (2016-11-01 11:21:02 +) are available in the git repository at: g...@github.com:codyprime/qemu-kvm-jtc.git tags/block-pull-requ

[Qemu-devel] [PULL v2 04/14] block/gluster: memory usage: use one glfs instance per volume

2016-11-01 Thread Jeff Cody
From: Prasanna Kumar Kalever Currently, for every drive accessed via gfapi we create a new glfs instance (call glfs_new() followed by glfs_init()) which could consume memory in few 100 MB's, from the table below it looks like for each instance ~300 MB VSZ was consumed Before: --- Disks VSZ

[Qemu-devel] [PULL v2 01/14] qapi: add release designator to gluster logfile option

2016-11-01 Thread Jeff Cody
The "logfile" option to BlockdevOptionsGluster will not be in QEMU until 2.8. Update comment to indicate this. Reported-by: Eric Blake Signed-off-by: Jeff Cody --- qapi/block-core.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/block-core.json b/qapi/block-core.js

[Qemu-devel] [PULL v2 03/14] block: add gluster ifdef guard checks for SEEK_DATA/SEEK_HOLE support

2016-11-01 Thread Jeff Cody
Add checks to see if the system compiling QEMU has support for SEEK_HOLE/SEEK_DATA. If the system does not, we will flag that seek data is unsupported in gluster. Note: this is not a check on whether the gluster server itself supports SEEK_DATA (that is already done during runtime), but rather if

[Qemu-devel] [PULL v2 08/14] blockjobs: hide internal jobs from management API

2016-11-01 Thread Jeff Cody
From: John Snow If jobs are not created directly by the user, do not allow them to be seen by the user/management utility. At the moment, 'internal' jobs are those that do not have an ID. As of this patch it is impossible to create such jobs. Signed-off-by: John Snow Message-id: 1477584421-1399

[Qemu-devel] [PULL v2 13/14] blockjobs: split interface into public/private, Part 1

2016-11-01 Thread Jeff Cody
From: John Snow To make it a little more obvious which functions are intended to be public interface and which are intended to be for use only by jobs themselves, split the interface into "public" and "private" files. Convert blockjobs (e.g. block/backup) to using the private interface. Leave bl

[Qemu-devel] [PULL v2 06/14] block/gluster: improve defense over string to int conversion

2016-11-01 Thread Jeff Cody
From: Prasanna Kumar Kalever using atoi() for converting string to int may be error prone in case if string supplied in the argument is not a fold of numerical number, This is not a bug because in the existing code, static QemuOptsList runtime_tcp_opts = { .name = "gluster_tcp", .head =

[Qemu-devel] [PULL v2 05/14] block: Turn on "unmap" in active commit

2016-11-01 Thread Jeff Cody
From: Fam Zheng We already specified BDRV_O_UNMAP when opening images in 'qemu-img commit', but didn't turn on the "unmap" in the active commit job. This patch fixes that so that zeroed clusters in top image can be discarded which is desired in the virt-sparsify use case, where a temporary overla

[Qemu-devel] [PULL v2 12/14] Blockjobs: Internalize user_pause logic

2016-11-01 Thread Jeff Cody
From: John Snow BlockJobs will begin hiding their state in preparation for some refactorings anyway, so let's internalize the user_pause mechanism instead of leaving it to callers to correctly manage. Signed-off-by: John Snow Reviewed-by: Kevin Wolf Reviewed-by: Jeff Cody Message-id: 14775844

[Qemu-devel] [PULL v2 07/14] block/gluster: fix port type in the QAPI options list

2016-11-01 Thread Jeff Cody
From: Prasanna Kumar Kalever After introduction of qapi schema in gluster block driver code, the port type is now string as per InetSocketAddress { 'struct': 'InetSocketAddress', 'data': { 'host': 'str', 'port': 'str', '*to': 'uint16', '*ipv4': 'bool', '*ipv6': 'bool' } }

Re: [Qemu-devel] [PATCH] virtio-gpu: fix information leak in capset get dispatch

2016-11-01 Thread Marc-André Lureau
Hi On Tue, Nov 1, 2016 at 3:38 PM Li Qiang wrote: > From: Li Qiang > > In virgl_cmd_get_capset function, it uses g_malloc to allocate > a response struct to the guest. As the 'resp'struct hasn't been full > initialized it will lead the 'resp->padding' field to the guest. > Use g_malloc0 to avoi

[Qemu-devel] [PULL v2 09/14] blockjobs: Allow creating internal jobs

2016-11-01 Thread Jeff Cody
From: John Snow Add the ability to create jobs without an ID. Signed-off-by: John Snow Reviewed-by: Kevin Wolf Reviewed-by: Jeff Cody Message-id: 1477584421-1399-3-git-send-email-js...@redhat.com Signed-off-by: Jeff Cody --- block/backup.c| 2 +- block/commit.c| 2

[Qemu-devel] [PULL v2 14/14] blockjobs: fix documentation

2016-11-01 Thread Jeff Cody
From: John Snow (Trivial) Fix wrong function names in documentation. Signed-off-by: John Snow Reviewed-by: Kevin Wolf Reviewed-by: Jeff Cody Message-id: 1477584421-1399-8-git-send-email-js...@redhat.com Signed-off-by: Jeff Cody --- include/block/blockjob_int.h | 4 ++-- 1 file changed, 2 i

[Qemu-devel] [PULL v2 10/14] Replication/Blockjobs: Create replication jobs as internal

2016-11-01 Thread Jeff Cody
From: John Snow Bubble up the internal interface to commit and backup jobs, then switch replication tasks over to using this methodology. Signed-off-by: John Snow Reviewed-by: Kevin Wolf Reviewed-by: Jeff Cody Message-id: 1477584421-1399-4-git-send-email-js...@redhat.com Signed-off-by: Jeff C

[Qemu-devel] [PULL v2 11/14] blockjob: centralize QMP event emissions

2016-11-01 Thread Jeff Cody
From: John Snow There's no reason to leave this to blockdev; we can do it in blockjobs directly and get rid of an extra callback for most users. All non-internal events, even those created outside of QMP, will consistently emit events. Signed-off-by: John Snow Reviewed-by: Kevin Wolf Reviewed

Re: [Qemu-devel] [PULL v2 00/14] Block patches for 2.8

2016-11-01 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PULL v2 00/14] Block patches for 2.8 Message-id: 1478004671-19154-1-git-send-email-jc...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(gi

Re: [Qemu-devel] [PULL 00/47] virtio, pc: fixes and features

2016-11-01 Thread Igor Mammedov
On Tue, 1 Nov 2016 00:48:11 +0200 "Michael S. Tsirkin" wrote: > On Mon, Oct 31, 2016 at 10:50:31AM +0100, Igor Mammedov wrote: > > On Sun, 30 Oct 2016 23:23:18 +0200 > > "Michael S. Tsirkin" wrote: > > > > > The following changes since commit > > > 5b2ecabaeabc17f032197246c4846b9ba95ba8a6: >

Re: [Qemu-devel] [PATCH V4] docs: add PCIe devices placement guidelines

2016-11-01 Thread Marcel Apfelbaum
On 10/31/2016 07:44 PM, Laine Stump wrote: On 10/31/2016 12:18 PM, Marcel Apfelbaum wrote: Hi Laine, Thank you for having a look at the document. + +2.2.1 Plugging a PCI Express device into a PCI Express Root Port: + -device ioh3420,id=root_port1,slot=x[,chassis=y][,bus=pcie.0][,ad

Re: [Qemu-devel] [PATCH v5 28/33] cputlb: make tlb_flush_by_mmuidx safe for MTTCG

2016-11-01 Thread Pranith Kumar
On Tue, Nov 1, 2016 at 3:45 AM, Alex Bennée wrote: > > Odd. I'll look into it. What was you configure string and host architecture? > It's a plain configure string, nothing special: $ ../configure --target-list=aarch64-softmmu But I did rebase your patches on master, May be something new in th

Re: [Qemu-devel] [PULL v2 for-2.8 0/7] 9p patches for 2.8 20161030

2016-11-01 Thread Peter Maydell
On 1 November 2016 at 12:00, Greg Kurz wrote: > The following changes since commit 02ba9265e8d65f24d0cdca158d96e0b0451f6b71: > > migration: fix compiler warning on uninitialized variable (2016-11-01 > 09:31:53 +) > > are available in the git repository at: > > https://github.com/gkurz/qem

[Qemu-devel] [PATCH V5] docs: add PCIe devices placement guidelines

2016-11-01 Thread Marcel Apfelbaum
Proposes best practices on how to use PCI Express/PCI device in PCI Express based machines and explain the reasoning behind them. Reviewed-by: Laszlo Ersek Signed-off-by: Marcel Apfelbaum --- Hi, v4->v5: - Addressed Laine's comments: - Advertize (slot,chassis) parameters as mandatory -

Re: [Qemu-devel] [PULL 37/47] nvdimm acpi: introduce fit buffer

2016-11-01 Thread Xiao Guangrong
On 11/01/2016 06:35 PM, Igor Mammedov wrote: On Tue, 1 Nov 2016 11:30:46 +0800 Xiao Guangrong wrote: On 10/31/2016 07:09 PM, Igor Mammedov wrote: On Mon, 31 Oct 2016 17:52:24 +0800 Xiao Guangrong wrote: On 10/31/2016 05:45 PM, Igor Mammedov wrote: On Sun, 30 Oct 2016 23:25:05 +0200 "Mic

Re: [Qemu-devel] [PULL 00/47] virtio, pc: fixes and features

2016-11-01 Thread Xiao Guangrong
On 11/01/2016 09:21 PM, Igor Mammedov wrote: On Tue, 1 Nov 2016 00:48:11 +0200 "Michael S. Tsirkin" wrote: On Mon, Oct 31, 2016 at 10:50:31AM +0100, Igor Mammedov wrote: On Sun, 30 Oct 2016 23:23:18 +0200 "Michael S. Tsirkin" wrote: The following changes since commit 5b2ecabaeabc17f03219

Re: [Qemu-devel] [PULL 00/47] virtio, pc: fixes and features

2016-11-01 Thread Michael S. Tsirkin
On Tue, Nov 01, 2016 at 02:21:07PM +0100, Igor Mammedov wrote: > On Tue, 1 Nov 2016 00:48:11 +0200 > "Michael S. Tsirkin" wrote: > > > On Mon, Oct 31, 2016 at 10:50:31AM +0100, Igor Mammedov wrote: > > > On Sun, 30 Oct 2016 23:23:18 +0200 > > > "Michael S. Tsirkin" wrote: > > > > > > > The fo

Re: [Qemu-devel] [PULL 37/47] nvdimm acpi: introduce fit buffer

2016-11-01 Thread Igor Mammedov
On Tue, 1 Nov 2016 21:40:46 +0800 Xiao Guangrong wrote: > On 11/01/2016 06:35 PM, Igor Mammedov wrote: > > On Tue, 1 Nov 2016 11:30:46 +0800 > > Xiao Guangrong wrote: > > > >> On 10/31/2016 07:09 PM, Igor Mammedov wrote: > >>> On Mon, 31 Oct 2016 17:52:24 +0800 > >>> Xiao Guangrong wrote: >

Re: [Qemu-devel] [PATCH v9 04/12] vfio iommu: Add support for mediated devices

2016-11-01 Thread Kirti Wankhede
On 10/28/2016 7:48 AM, Alexey Kardashevskiy wrote: > On 27/10/16 23:31, Kirti Wankhede wrote: >> >> >> On 10/27/2016 12:50 PM, Alexey Kardashevskiy wrote: >>> On 18/10/16 08:22, Kirti Wankhede wrote: VFIO IOMMU drivers are designed for the devices which are IOMMU capable. Mediated devic

Re: [Qemu-devel] [PULL 00/47] virtio, pc: fixes and features

2016-11-01 Thread Igor Mammedov
On Tue, 1 Nov 2016 15:55:36 +0200 "Michael S. Tsirkin" wrote: > On Tue, Nov 01, 2016 at 02:21:07PM +0100, Igor Mammedov wrote: > > On Tue, 1 Nov 2016 00:48:11 +0200 > > "Michael S. Tsirkin" wrote: > > > > > On Mon, Oct 31, 2016 at 10:50:31AM +0100, Igor Mammedov wrote: > > > > On Sun, 30 Oc

Re: [Qemu-devel] [PULL 08/27] hostmem-file: make option 'size' optional

2016-11-01 Thread Eduardo Habkost
On Tue, Nov 01, 2016 at 05:32:20PM +0800, Haozhong Zhang wrote: > On 10/31/16 20:22 -0200, Eduardo Habkost wrote: > > On Mon, Oct 31, 2016 at 03:47:53PM -0400, Paolo Bonzini wrote: > > > > > > > > > - Original Message - > > > > From: "Eduardo Habkost" > > > > To: "Paolo Bonzini" > > > >

Re: [Qemu-devel] [PULL v2 for-2.8 0/9] tcg queued patches

2016-11-01 Thread Peter Maydell
) > > are available in the git repository at: > > git://github.com/rth7680/qemu.git tags/pull-tcg-20161101 > > for you to fetch changes up to 13110e2d41d0b9d77edea5b23e1a808c86eb22cb: > > tcg: correct 32-bit tcg_gen_ld8s_i64 sign-extension (2016-10-31 21:36:29 > -0600)

Re: [Qemu-devel] [PATCH] migration: fix missing assignment for has_x_checkpoint_delay

2016-11-01 Thread Eric Blake
On 11/01/2016 12:50 AM, zhanghailiang wrote: > We forgot to assign true to params->has_x_checkpoint_delay parameter > in qmp_query_migrate_parameters. > > Without this, qmp command 'query-migrate-parameters' doesn't show the > default value for x-checkpoint-delay option. > It doesn't influence out

Re: [Qemu-devel] [PULL 00/47] virtio, pc: fixes and features

2016-11-01 Thread Peter Maydell
On 1 November 2016 at 14:14, Igor Mammedov wrote: > PS: > Looks like with new soft-freeze rules we just have one big > hard-freeze window and people trying to frantically squeeze > in features last minute. > I think previous soft-freeze rules worked better where > maintainers were still allowed me

[Qemu-devel] [PATCH] atomic.h: Use __atomic_load_n() for acquire

2016-11-01 Thread Pranith Kumar
We can use __atomic_load_n() saving a store and load from the _val. Signed-off-by: Pranith Kumar --- include/qemu/atomic.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/include/qemu/atomic.h b/include/qemu/atomic.h index 878fa07..6775603 100644 --- a/include/qemu/atomic.

[Qemu-devel] [PATCH 1/1] checkpatch: allow spaces before parenthesis for 'coroutine_fn'

2016-11-01 Thread Jeff Cody
Signed-off-by: Jeff Cody --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 3afa19a..9e64e61 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -1754,7 +1754,7 @@ sub process {

Re: [Qemu-devel] [PATCH 1/1] checkpatch: allow spaces before parenthesis for 'coroutine_fn'

2016-11-01 Thread Eric Blake
On 11/01/2016 09:38 AM, Jeff Cody wrote: > Signed-off-by: Jeff Cody > --- > scripts/checkpatch.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index 3afa19a..9e64e61 100755 > --- a/scripts/chec

Re: [Qemu-devel] [PATCH] atomic.h: Use __atomic_load_n() for acquire

2016-11-01 Thread Paolo Bonzini
On 01/11/2016 15:33, Pranith Kumar wrote: > We can use __atomic_load_n() saving a store and load from the _val. > > Signed-off-by: Pranith Kumar > --- > include/qemu/atomic.h | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/include/qemu/atomic.h b/include/qemu/atomi

Re: [Qemu-devel] [PATCH] atomic.h: Use __atomic_load_n() for acquire

2016-11-01 Thread Pranith Kumar
On Tue, Nov 1, 2016 at 10:44 AM, Paolo Bonzini wrote: > > Can you do the same for atomic_rcu_read__nocheck (both implementations)? > Sure, will send an updated patch. -- Pranith

Re: [Qemu-devel] [PATCH 1/1] checkpatch: allow spaces before parenthesis for 'coroutine_fn'

2016-11-01 Thread Paolo Bonzini
On 01/11/2016 15:38, Jeff Cody wrote: > Signed-off-by: Jeff Cody > --- > scripts/checkpatch.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index 3afa19a..9e64e61 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/ch

Re: [Qemu-devel] [PATCH 8/8] nvdimm acpi: use common macros instead of magic names

2016-11-01 Thread Stefan Hajnoczi
On Sat, Oct 29, 2016 at 12:11:56AM +0800, Xiao Guangrong wrote: > /* > * DSM notifier: > - * NTFI: write the address of DSM memory and notify QEMU to emulate > - * the access. > + * NVDIMM_DSM_NOTIFY: write the address of DSM memory and notify QEMU to > + *

Re: [Qemu-devel] [PATCH 0/8] nvdimm acpi: bug fix and cleanup

2016-11-01 Thread Stefan Hajnoczi
On Sat, Oct 29, 2016 at 12:11:48AM +0800, Xiao Guangrong wrote: > Thanks to Igor's suggestion, this patchset fixes some bugs in NVDIMM ACPI, > also it refines the nvdimm code slightly > > Xiao Guangrong (8): > acpi nvdimm: fix wrong buffer size returned by DSM method > acpi nvdimm: fix device

Re: [Qemu-devel] [QEMU PATCH v9 2/3] migration: migrate QTAILQ

2016-11-01 Thread Paolo Bonzini
On 31/10/2016 14:10, Halil Pasic wrote: > I think this got overly complicated. I agree. :) > Here is a little patch on > top of your stuff which gets rid of 15 lines and IMHO simplifies > things quite a bit. What do you think? > > It is based on/inspired by Dave's proposal with the dummy stu

Re: [Qemu-devel] [PATCH] cpus: make qemu_mutex_iothread_locked() understand co-routines

2016-11-01 Thread Paolo Bonzini
On 21/10/2016 13:54, Alex Bennée wrote: > There is a slight wart when checking for the state of the BQL when using > GThread base co-routines (which we keep for ThreadSanitizer runs). While > the main-loop holds the BQL it is suspended until the co-routine > completes however the co-routines run

Re: [Qemu-devel] [PATCH] docs/rcu.txt: Fix minor typo

2016-11-01 Thread Paolo Bonzini
On 18/10/2016 07:04, Pranith Kumar wrote: > s/presented/prevented/ > > Signed-off-by: Pranith Kumar > --- > docs/rcu.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/docs/rcu.txt b/docs/rcu.txt > index a70b72c..c84e7f4 100644 > --- a/docs/rcu.txt > +++ b/docs/rcu.t

Re: [Qemu-devel] [PATCH] main-loop: Suppress I/O thread warning under qtest

2016-11-01 Thread Paolo Bonzini
On 17/10/2016 20:09, Max Reitz wrote: > We do not want to display the "I/O thread spun" warning for test cases > that run under qtest. The first attempt for this (commit > 01c22f2cdd4fcf02276ea10f48253850a5fd7259) tested whether qtest_enabled() > was true. > > Commit 21a24302e85024dd7b2a151158ad

Re: [Qemu-devel] [PULL v2 00/14] Block patches for 2.8

2016-11-01 Thread Peter Maydell
On 1 November 2016 at 12:50, Jeff Cody wrote: > The following changes since commit bf99fd3983d7185178a0f65ce29bb94b1aecaed1: > > Merge remote-tracking branch 'remotes/rth/tags/pull-sparc-20161031-2' into > staging (2016-11-01 11:21:02 +) > > are available in the git repository at: > > g..

  1   2   3   >