Re: [Qemu-devel] [RFC] powernv: CPU compatibility modes don't make sense for powernv

2016-10-28 Thread Greg Kurz
On Fri, 28 Oct 2016 22:14:12 +1100 David Gibson wrote: > On Fri, Oct 28, 2016 at 11:32:43AM +0200, Greg Kurz wrote: > > On Fri, 28 Oct 2016 13:05:01 +1100 > > David Gibson wrote: > > > > > powernv has some code (derived from the spapr equivalent) used in device > > > tree generation which dep

[Qemu-devel] [PATCH] net: split colo_compare_pkt_info into two trace events

2016-10-28 Thread Alex Bennée
It seems there is a limit to the number of arguments a UST trace event can take and at 11 the previous trace command broke the build. Split the trace into a src pkt and dst pkt trace to fix this. Signed-off-by: Alex Bennée --- net/colo-compare.c | 21 +++-- net/trace-events |

Re: [Qemu-devel] [PULL 00/23] Block layer patches

2016-10-28 Thread Peter Maydell
On 27 October 2016 at 19:08, Kevin Wolf wrote: > The following changes since commit 5929d7e8a0e1f4bc3528b50397ae8dd0fd6b: > > Merge remote-tracking branch 'remotes/rth/tags/pull-atomic-20161026' into > staging (2016-10-27 14:06:34 +0100) > > are available in the git repository at: > > > g

Re: [Qemu-devel] [PATCH v2 2/2] gdbstub: Fix vCont behaviour

2016-10-28 Thread Claudio Imbrenda
On 27/10/16 13:40, Pedro Alves wrote: > I'm not a qemu gdbstub expert, but FYI, seeing this reminded me to push > to gdb's master a (getting old) gdb patch that clarifies how vCont actions > should be interpreted: > > https://sourceware.org/ml/gdb-patches/2016-02/msg00493.html > > It's already l

Re: [Qemu-devel] [PATCH v3 00/20] dataplane: remove RFifoLock

2016-10-28 Thread Fam Zheng
On Thu, 10/27 12:48, Paolo Bonzini wrote: > The only difference from v2 is the disappearing of bdrv_aio_pdiscard, > bdrv_aio_ioctl and bdrv_ioctl. The diff-of-diff looks sane - only a few hunks are dropped as you said, and a comment update about the rule of acquiring AIOContext in bdrv_drain_all,

Re: [Qemu-devel] [QEMU PATCH v9 0/3] migration: migrate QTAILQ

2016-10-28 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [QEMU PATCH v9 0/3] migration: migrate QTAILQ Message-id: 1477607317-27817-1-git-send-email-du...@linux.vnet.ibm.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=bas

Re: [Qemu-devel] [PATCH v2 2/2] gdbstub: Fix vCont behaviour

2016-10-28 Thread Pedro Alves
On 10/28/2016 02:35 PM, Claudio Imbrenda wrote: > On 27/10/16 13:40, Pedro Alves wrote: >> I'm not a qemu gdbstub expert, but FYI, seeing this reminded me to push >> to gdb's master a (getting old) gdb patch that clarifies how vCont actions >> should be interpreted: >> >> https://sourceware.org/ml

Re: [Qemu-devel] [PATCH v4] char: cadence: check baud rate generator and divider values

2016-10-28 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Subject: [Qemu-devel] [PATCH v4] char: cadence: check baud rate generator and divider values Message-id: 1477596

Re: [Qemu-devel] [PATCHv2] monitor: deprecate 'default' option

2016-10-28 Thread Michael Tokarev
11.10.2016 20:41, Marc-André Lureau wrote: > This option does nothing since commit 06ac27f. Deprecate it. Applied to -trivial, together with additional hunk from Marcus, thanks! /mjt

[Qemu-devel] [Bug 721659] Re: qemu-kvm-0.13.0 doesn't pass USB devices to the VM

2016-10-28 Thread Thomas Huth
QEMU 0.13.0 is quite outdated - and I assume that USB passthrough should be working fine with the latest version, so I'm closing this bug ticket now. If you still have problems with the latest version of QEMU, feel free to open it again (or create a new bug ticket instead). ** Changed in: qemu

[Qemu-devel] [Bug 688052] Re: usb does not work 0.13.0

2016-10-28 Thread Thomas Huth
QEMU 0.13.0 is quite outdated - and I assume that USB passthrough should be working fine with the latest version, so I'm closing this bug ticket now. If you still have problems with the latest version of QEMU, feel free to open it again (or create a new bug ticket instead). ** Changed in: qemu

Re: [Qemu-devel] [PATCH v4 1/2] block/nfs: Introduce runtime_opts in NFS

2016-10-28 Thread Kevin Wolf
Am 28.10.2016 um 14:47 hat Ashijeet Acharya geschrieben: > Make NFS block driver use various fine grained runtime_opts. > Set .bdrv_parse_filename() to nfs_parse_filename() and introduce two > new functions nfs_parse_filename() and nfs_parse_uri() to help parsing > the URI. > Add a new option "serv

[Qemu-devel] [Bug 712337] Re: connecthon basic test5 failed with qemu 0.14 on Virtfs path in guest

2016-10-28 Thread Thomas Huth
According to comment #1, the problem does not occur anymore with the latest version of QEMU, but you've set the status to "In Progress" instead of closing it ... so can we close this ticket nowadays or is there still something left to do? ** Changed in: qemu Status: In Progress => Incomplet

[Qemu-devel] [Bug 727134] Re: pci-stub.o: In function `do_pci_info':0.14.0 compile problem

2016-10-28 Thread Thomas Huth
QEMU 0.14.0 is quite outdated - and I assume that compilation is working fine again with the latest version, so I'm closing this bug ticket now. If you still have problems with the latest version of QEMU, feel free to open it again (or create a new bug ticket instead). ** Changed in: qemu S

Re: [Qemu-devel] [PATCH v3] util/mmap-alloc: check parameter before using

2016-10-28 Thread Michael Tokarev
28.10.2016 11:56, Cao jin wrote: > Also refactor a little bit for readability See comments below... > Signed-off-by: Cao jin > --- > util/mmap-alloc.c | 17 - > 1 file changed, 8 insertions(+), 9 deletions(-) > > diff --git a/util/mmap-alloc.c b/util/mmap-alloc.c > index 5a85aa

Re: [Qemu-devel] [PATCH v4] char: cadence: check baud rate generator and divider values

2016-10-28 Thread Fam Zheng
On Fri, 10/28 07:03, no-re...@patchew.org wrote: > In file included from > /usr/x86_64-w64-mingw32/sys-root/mingw/lib/glib-2.0/include/glibconfig.h:9:0, > from > /usr/x86_64-w64-mingw32/sys-root/mingw/include/glib-2.0/glib/gtypes.h:32, > from > /usr/x86_64-w64-m

Re: [Qemu-devel] [PATCH v3 00/15] target-sparc improvements

2016-10-28 Thread Mark Cave-Ayland
On 27/10/16 18:07, Richard Henderson wrote: > The two main goals in this patch set are: > * Make use of the new MO_ALIGN_* flags, to allow less use of check_align, > and support partially misaligned fp memory ops. > * More cleanups for ASIs, in the end using the new atomic ops. > > Change

Re: [Qemu-devel] [PATCH v2 2/2] gdbstub: Fix vCont behaviour

2016-10-28 Thread Claudio Imbrenda
On 28/10/16 16:01, Pedro Alves wrote: >> From the new specifications I seem to understand that if I specify a >> default as first action, then no further actions will be considered, >> since it matches all threads? > > Right. ok, that's the way I understand the new specs, which is not how I had u

Re: [Qemu-devel] [Xen-devel] [PATCH v2] xenfv: set has_acpi_build to false

2016-10-28 Thread Wei Liu
On Thu, Oct 27, 2016 at 11:58:29AM -0700, Stefano Stabellini wrote: > On Thu, 27 Oct 2016, Sander Eikelenboom wrote: > > Thursday, October 27, 2016, 3:51:09 PM, you wrote: > > > > > Xen's toolstack is in charge of building ACPI tables. Skip ACPI table > > > building and loading in QEMU by setting

Re: [Qemu-devel] [PATCH v3] block/vxhs: Add Veritas HyperScale VxHS block device support

2016-10-28 Thread Eric Blake
On 10/28/2016 02:44 AM, Ashish Mittal wrote: > This patch adds support for a new block device type called "vxhs". > Source code for the qnio library that this code loads can be downloaded from: > https://github.com/MittalAshish/libqnio.git > > Sample command line using the JSON syntax: > ./qemu-sy

Re: [Qemu-devel] [PATCH v4 0/2] Script changes to find duplicate #include entries

2016-10-28 Thread Michael Tokarev
21.10.2016 09:57, Anand J wrote: > There were some files in the code base with multiple inclusion of the same > header files. > Following changes are made to mitigate this issue. > > 1) --check-dup-head option is added to the scripts/clean-includes to search > files and > find out such entr

Re: [Qemu-devel] [PULL 0/6] Ide patches

2016-10-28 Thread Peter Maydell
On 27 October 2016 at 22:18, John Snow wrote: > The following changes since commit 835f3d24b42fcbeca5c49048994a4e5d0fe905c5: > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-audio-20161027-1' > into staging (2016-10-27 17:24:29 +0100) > > are available in the git repository at: > >

Re: [Qemu-devel] [PATCH v2] block/vxhs: Add Veritas HyperScale VxHS block device support

2016-10-28 Thread Rakesh Ranjan
Hi Jeff etc al, Thanks a lot for your due diligence to review the code changes throughly and providing comments, suggestions to improve. We are completely on top of this and have already started to expedite the overall development. We would like to get you help regarding the applicability of qemu

[Qemu-devel] [PULL 02/20] blockjob: introduce .drain callback for jobs

2016-10-28 Thread Fam Zheng
From: Paolo Bonzini This is required to decouple block jobs from running in an AioContext. With multiqueue block devices, a BlockDriverState does not really belong to a single AioContext. The solution is to first wait until all I/O operations are complete; then loop in the main thread for the b

[Qemu-devel] [PATCH 1/2] s390x/pci: use generic interface to inject interrupt

2016-10-28 Thread Cornelia Huck
From: Yi Min Zhao Let's use the generic interface to inject adapter interrupts. Signed-off-by: Yi Min Zhao Acked-by: Cornelia Huck Signed-off-by: Cornelia Huck --- hw/s390x/s390-pci-bus.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390

[Qemu-devel] [PATCH 2/2] s390x/pci: Check memory region dispatching callbacks

2016-10-28 Thread Cornelia Huck
From: Pierre Morel The instructions PCI STORE, PCI LOAD and PCI STORE BLOCK use calls to memory_region_dispatch_write() and memory_region_dispatch_read() but do not test the return value. Furthermore, the instruction PCI STORE BLOCK sets up a PGM_ADDRESSING exception when the operand 3 is not wi

[Qemu-devel] [PULL 04/20] block: add BDS field to count in-flight requests

2016-10-28 Thread Fam Zheng
From: Paolo Bonzini Unlike tracked_requests, this field also counts throttled requests, and remains non-zero if an AIO operation needs a BH to be "really" completed. With this change, it is no longer necessary to have a dummy BdrvTrackedRequest for requests that are never serialising, and it is

[Qemu-devel] [PATCH 0/2] s390x: Two more patches for 2.8

2016-10-28 Thread Cornelia Huck
Last round for 2.8: two fixes/improvements in the s390x PCI code. I plan to send a pullreq on Monday. Pierre Morel (1): s390x/pci: Check memory region dispatching callbacks Yi Min Zhao (1): s390x/pci: use generic interface to inject interrupt hw/s390x/s390-pci-bus.c | 4 +--- hw/s390x/s3

[Qemu-devel] [PULL 03/20] mirror: use bdrv_drained_begin/bdrv_drained_end

2016-10-28 Thread Fam Zheng
From: Paolo Bonzini Ensure that there are no changes between the last check to bdrv_get_dirty_count and the switch to the target. There is already a bdrv_drained_end call, we only need to ensure that bdrv_drained_begin is not called twice. Signed-off-by: Paolo Bonzini Reviewed-by: Fam Zheng M

[Qemu-devel] [Bug 1636217] Re: qemu-kvm 2.7 does not boot kvm VMs with virtio on top of VMware ESX

2016-10-28 Thread Fabian Grünbichler
I traced this back to the switch to enabling virtio-1 mode by default in 2.7 in commit 9a4c0e220d8a4f82b5665d0ee95ef94d8e1509d5 forcing the old behaviour with a 2.6 machine type works. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [PULL 05/20] block: change drain to look only at one child at a time

2016-10-28 Thread Fam Zheng
From: Paolo Bonzini bdrv_requests_pending is checking children to also wait until internal requests (such as metadata writes) have completed. However, checking children is in general overkill. Children requests can be of two kinds: - requests caused by an operation on bs, e.g. a bdrv_aio_write

[Qemu-devel] [PULL 06/20] qed: Implement .bdrv_drain

2016-10-28 Thread Fam Zheng
The "need_check_timer" is used to clear the "NEED_CHECK" flag in the image header after a grace period once metadata update has finished. To comply with the bdrv_drain semantics, we should make sure it remains deleted once .bdrv_drain is called. The change to qed_need_check_timer_cb is needed beca

[Qemu-devel] [PULL 07/20] block: introduce BDRV_POLL_WHILE

2016-10-28 Thread Fam Zheng
From: Paolo Bonzini We want the BDS event loop to run exclusively in the iothread that owns the BDS's AioContext. This macro will provide the synchronization between the two event loops; for now it just wraps the common idiom of a while loop around aio_poll. Signed-off-by: Paolo Bonzini Review

[Qemu-devel] [PATCH] x86/cpuid:add AVX512_4VNNIW and AVX512_4FMAPS features.

2016-10-28 Thread He Chen
From: Luwei Kang The spec can be found in Intel Software Developer Manual or in Instruction Set Extensions Programming Reference. Signed-off-by: Luwei Kang Signed-off-by: Piotr Luc --- target-i386/cpu.c | 19 ++- target-i386/cpu.h | 4 2 files changed, 22 insertions(+),

[Qemu-devel] [PULL 10/20] sheepdog: use BDRV_POLL_WHILE

2016-10-28 Thread Fam Zheng
From: Paolo Bonzini This is important when the sheepdog driver works on a BlockDriverState that is attached to an I/O thread other than the main thread. Signed-off-by: Paolo Bonzini Reviewed-by: Fam Zheng Message-Id: <1477565348-5458-11-git-send-email-pbonz...@redhat.com> Signed-off-by: Fam Zh

[Qemu-devel] [PULL 20/20] aio: convert from RFifoLock to QemuRecMutex

2016-10-28 Thread Fam Zheng
From: Paolo Bonzini It is simpler and a bit faster, and QEMU does not need the contention callbacks (and thus the fairness) anymore. Reviewed-by: Fam Zheng Signed-off-by: Paolo Bonzini Message-Id: <1477565348-5458-21-git-send-email-pbonz...@redhat.com> Signed-off-by: Fam Zheng --- async.c

[Qemu-devel] [PULL 11/20] aio: introduce qemu_get_current_aio_context

2016-10-28 Thread Fam Zheng
From: Paolo Bonzini This will be used by BDRV_POLL_WHILE (and thus by bdrv_drain) to choose how to wait for I/O completion. Reviewed-by: Fam Zheng Signed-off-by: Paolo Bonzini Message-Id: <1477565348-5458-12-git-send-email-pbonz...@redhat.com> Signed-off-by: Fam Zheng --- include/block/aio.h

[Qemu-devel] [Bug 1637511] [NEW] Armitage crashes KVM guest with Kali2016.2 for QXL video

2016-10-28 Thread moenchmeyer
Public bug reported: I recently got a strange bug which seems to be related to qemu-kvm and QXL. I came here via the hints of the KVM web-site for KVM/qemu bug tracking. But, I am not sure whether this is the right bug-tracker at all. Please advise me if I placed the report wrongly. I installed K

[Qemu-devel] [PULL 14/20] block: prepare bdrv_reopen_multiple to release AioContext

2016-10-28 Thread Fam Zheng
From: Paolo Bonzini After the next patch bdrv_drain_all will have to be called without holding any AioContext. Prepare to do this by adding an AioContext argument to bdrv_reopen_multiple. Reviewed-by: Stefan Hajnoczi Reviewed-by: Fam Zheng Signed-off-by: Paolo Bonzini Message-Id: <1477565348

[Qemu-devel] [PULL 12/20] iothread: detach all block devices before stopping them

2016-10-28 Thread Fam Zheng
From: Paolo Bonzini Soon bdrv_drain will not call aio_poll itself on iothreads. If block devices are left hanging off the iothread's AioContext, there will be no one to do I/O for those poor devices. Signed-off-by: Paolo Bonzini Reviewed-by: Fam Zheng Message-Id: <1477565348-5458-13-git-send-

[Qemu-devel] [Bug 1579327] Re: emulation of vexpress-a9 vexpress-a15 in multicore mode seems to be broken

2016-10-28 Thread Nicolae Rosia
I believe this is not a qemu boot since booting the kernel with -smp 4 works just fine, sorry for the noise -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1579327 Title: emulation of vexpress-a9 vex

Re: [Qemu-devel] [PATCH] Fix build for less common build directories names

2016-10-28 Thread Michael Tokarev
17.10.2016 07:43, Stefan Weil wrote: > Am 16.10.2016 um 21:04 schrieb Peter Maydell: >> On 16 October 2016 at 15:31, Michael Tokarev wrote: >>> 13.10.2016 21:29, Stefan Weil wrote: scripts/tracetool generates a C preprocessor macro from the name of the build directory. Any characters whi

[Qemu-devel] [PATCH v2] qxl: Only emit QXL_INTERRUPT_CLIENT_MONITORS_CONFIG on config changes

2016-10-28 Thread Christophe Fergeau
Currently if the client keeps sending the same monitor config to QEMU/spice-server, QEMU will always raise a QXL_INTERRUPT_CLIENT_MONITORS_CONFIG regardless of whether there was a change or not. Guest-side (with fedora 25), the kernel QXL KMS driver will also forward the event to user-space without

[Qemu-devel] [PULL 5/9] char: cadence: correct reset value for baud rate registers

2016-10-28 Thread Peter Maydell
From: Prasad J Pandit The Cadence UART device emulator stores 'baud rate generator' and 'baud rate divider' values, used in computing speed, in two registers. The device specification defines their range and their reset value. Use their correct value when resetting the device in cadence_uart_rese

[Qemu-devel] [PULL 15/20] qemu-io: acquire AioContext

2016-10-28 Thread Fam Zheng
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Reviewed-by: Fam Zheng Message-Id: <1477565348-5458-16-git-send-email-pbonz...@redhat.com> Signed-off-by: Fam Zheng --- qemu-io-cmds.c | 4 1 file changed, 4 insertions(+) diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c index dbe0413..4750e9

[Qemu-devel] [PULL 17/20] block: only call aio_poll on the current thread's AioContext

2016-10-28 Thread Fam Zheng
From: Paolo Bonzini aio_poll is not thread safe; for example bdrv_drain can hang if the last in-flight I/O operation is completed in the I/O thread after the main thread has checked bs->in_flight. The bug remains latent as long as all of it is called within aio_context_acquire/aio_context_releas

[Qemu-devel] [PULL 01/20] replication: interrupt failover if the main device is closed

2016-10-28 Thread Fam Zheng
From: Paolo Bonzini Without this change, there is a race condition in tests/test-replication. Depending on how fast the failover job (active commit) runs, there is a chance of two bad things happening: 1) replication_done can be called after the secondary has been closed and hence when the BDRVR

[Qemu-devel] [PULL 13/20] replication: pass BlockDriverState to reopen_backing_file

2016-10-28 Thread Fam Zheng
From: Paolo Bonzini This will be needed in the next patch to retrieve the AioContext. Reviewed-by: Stefan Hajnoczi Reviewed-by: Fam Zheng Signed-off-by: Paolo Bonzini Message-Id: <1477565348-5458-14-git-send-email-pbonz...@redhat.com> Signed-off-by: Fam Zheng --- block/replication.c | 21 ++

[Qemu-devel] [PULL 09/20] nfs: use BDRV_POLL_WHILE

2016-10-28 Thread Fam Zheng
From: Paolo Bonzini This will make it possible to use nfs_get_allocated_file_size on a file that is not in the main AioContext. Reviewed-by: Stefan Hajnoczi Reviewed-by: Fam Zheng Signed-off-by: Paolo Bonzini Message-Id: <1477565348-5458-10-git-send-email-pbonz...@redhat.com> Signed-off-by: F

[Qemu-devel] [PATCH] hw/input/hid: support alternative sysrq/break scancodes for gtk-vnc

2016-10-28 Thread Peter Korsgaard
The printscreen/sysrq and pause/break keys currently don't work for guests using -usbdevice keyboard when accessed through vnc with a gtk-vnc based client. The reason for this is a mismatch between gtk-vnc and qemu in how these keys should be mapped to XT keycodes. On the original IBM XT these ke

[Qemu-devel] [PULL 8/9] hw/arm/spitz: Fix reset handling

2016-10-28 Thread Peter Maydell
From: Guenter Roeck Using the CPU reset handler for resets triggered by writing into gpio pins other than GPIO01 is not appropriate and does not work, since the reset triggered by writing into GPIO01 is configurable. Use a separate reset handler for spitz to reset the entire system and not just t

[Qemu-devel] [PULL 08/20] nfs: move nfs_set_events out of the while loops

2016-10-28 Thread Fam Zheng
From: Paolo Bonzini nfs_set_events only needs to be called once before entering the while loop; afterwards, nfs_process_read and nfs_process_write take care of it. Reviewed-by: Stefan Hajnoczi Reviewed-by: Fam Zheng Signed-off-by: Paolo Bonzini Message-Id: <1477565348-5458-9-git-send-email-pb

[Qemu-devel] [PULL 00/20] Block patches

2016-10-28 Thread Fam Zheng
The following changes since commit 9879b75873cacc88cdee490f6ab481e8ce766c69: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2016-10-28 12:06:41 +0100) are available in the git repository at: g...@github.com:famz/qemu tags/for-upstream for you to fetch changes

Re: [Qemu-devel] [PATCH] iotests: Always use -machine accel=qtest

2016-10-28 Thread Max Reitz
On 17.10.2016 20:39, Max Reitz wrote: > Currently, we only use -machine accel=qtest when qemu is invoked through > the common.qemu functions. However, we always want to use it, so move it > from common.qemu directly into QEMU_OPTIONS. > > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/commo

[Qemu-devel] [PULL 0/9] target-arm queue

2016-10-28 Thread Peter Maydell
jnsnow/tags/ide-pull-request' into staging (2016-10-28 14:29:50 +0100) are available in the git repository at: git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20161028 for you to fetch changes up to d26a10e232eb18bf9e32dc2366231715bfd1d5b4: hw/arm/tosa: Fix reset

[Qemu-devel] [PULL 19/20] qemu-thread: introduce QemuRecMutex

2016-10-28 Thread Fam Zheng
From: Paolo Bonzini GRecMutex is new in glib 2.32, so we cannot use it. Introduce a recursive mutex in qemu-thread instead, which will be used instead of RFifoLock. Reviewed-by: Fam Zheng Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini Message-Id: <1477565348-5458-20-git-send-email

[Qemu-devel] [PULL 2/9] arm: cubieboard: Add support for initrd

2016-10-28 Thread Peter Maydell
From: Guenter Roeck Signed-off-by: Guenter Roeck Message-id: 1477361131-18752-1-git-send-email-li...@roeck-us.net Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- hw/arm/cubieboard.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/cubieboard.c b/hw/arm/cubieboard.c index

[Qemu-devel] [PULL 7/9] arm: virt: add PMU property to mach-virt machine type

2016-10-28 Thread Peter Maydell
From: Wei Huang CPU vPMU is now turned ON by default, but this feature wasn't introduced until virt-2.7 machine type. To solve this problem, this patch adds a PMU option in machine state, which is used to control CPU's vPMU status. This PMU option is not exposed to command line and is turned off

[Qemu-devel] [PULL 9/9] hw/arm/tosa: Fix reset handling

2016-10-28 Thread Peter Maydell
From: Guenter Roeck Using the CPU reset handler for resets triggered by writing into gpio pins other than GPIO01 is not appropriate and does not work, since the reset triggered by writing into GPIO01 is configurable. Use a separate reset handler for tosa to reset the entire system and not just th

[Qemu-devel] [PULL 16/20] qemu-img: call aio_context_acquire/release around block job

2016-10-28 Thread Fam Zheng
From: Paolo Bonzini This will be needed by bdrv_reopen_multiple, which calls bdrv_drain_all and thus will *release* the AioContext. Signed-off-by: Paolo Bonzini Reviewed-by: Fam Zheng Message-Id: <1477565348-5458-17-git-send-email-pbonz...@redhat.com> Signed-off-by: Fam Zheng --- qemu-img.c

[Qemu-devel] [PULL 02/23] hw/tpm/tpm_passthrough: Simplify if-statements a little bit

2016-10-28 Thread Michael Tokarev
From: Thomas Huth The condition '!A || (A && B)' is equivalent to '!A || B' Buglink: https://bugs.launchpad.net/qemu/+bug/1464611 Signed-off-by: Thomas Huth Reviewed-by: Peter Maydell Signed-off-by: Michael Tokarev --- hw/tpm/tpm_passthrough.c | 6 ++ 1 file changed, 2 insertions(+), 4

[Qemu-devel] [PULL 18/20] iothread: release AioContext around aio_poll

2016-10-28 Thread Fam Zheng
From: Paolo Bonzini This is the first step towards having fine-grained critical sections in dataplane threads, which will resolve lock ordering problems between address_space_* functions (which need the BQL when doing MMIO, even after we complete RCU-based dispatch) and the AioContext. Because A

[Qemu-devel] [PULL 3/9] hw/arm/pxa2xx: Set value default values for CCCR and CKEN on PXA255

2016-10-28 Thread Peter Maydell
From: Guenter Roeck The code used default values for PXA270 to configure CCCR. For PXA255, the resulting register value is invalid (unsupported) and resulted in a division by zero in the Linux kernel. Use default values from datasheet instead. Signed-off-by: Guenter Roeck Message-id: 1477361273

[Qemu-devel] [PULL 1/9] i.MX: Fix GPIO ISR register write

2016-10-28 Thread Peter Maydell
From: Guenter Roeck Writing the ISR register is supposed to clear interrupt status bits, not to set them. This patch makes '-M sabrelite' work without devicetree changes (Linux kernel versions 3.18 to 4.7 with imx_v6_v7_defconfig and up to v4.8 with multi_v7_defconfig; mainline has different pro

[Qemu-devel] [PULL 17/23] s390: avoid always-true comparison in s390_pci_generate_fid()

2016-10-28 Thread Michael Tokarev
From: Peter Maydell Coverity points out that the comparison "fid <= ZPCI_MAX_FID" in s390_pci_generate_fid() is always true (because fid is 32 bits and ZPCI_MAX_FID is 0x). This isn't a bug because the real loop termination condition is expressed later via an "if (...) break;" inside the

[Qemu-devel] [PULL 4/9] versatilepb: do not run if user asks for more than 256MB RAM

2016-10-28 Thread Peter Maydell
From: Jean-Christophe Dubois The versatilepb physical address space layout only has a 256MB region for RAM before the devices. Without a guard on the amount of RAM requested by the user we would happily create a RAM area that overlapped with the devices, resulting in very confusing behaviour (typ

[Qemu-devel] [PULL 6/9] arm: Add an option to turn on/off vPMU support

2016-10-28 Thread Peter Maydell
From: Wei Huang This patch adds a pmu=[on/off] option to enable/disable vPMU support in guest vCPU. It allows virt tools, such as libvirt, to determine the exsitence of vPMU and configure it. Note this option is only available for cortex-a57/cortex-53/ host CPUs, but unavailable on ARMv7 and othe

Re: [Qemu-devel] [PATCH] Fix build for less common build directories names

2016-10-28 Thread Peter Maydell
On 28 October 2016 at 15:57, Michael Tokarev wrote: > 17.10.2016 07:43, Stefan Weil wrote: >> Am 16.10.2016 um 21:04 schrieb Peter Maydell: >>> On 16 October 2016 at 15:31, Michael Tokarev wrote: 13.10.2016 21:29, Stefan Weil wrote: > scripts/tracetool generates a C preprocessor macro fr

[Qemu-devel] [PULL 06/23] target-lm32: disable asm logging via LOG_DIS()

2016-10-28 Thread Michael Tokarev
From: Michael Walle The lm32 target already has a disassembler which logs the assembly instructions with "-d in_asm". Therefore, turn of the LOG_DIS() macro to prevent logging the assembly instructions twice. Also turn the macro in a one which is always compiled to catch any errors while the macr

[Qemu-devel] [PULL 08/23] target-lm32: rewrite gen_compare()

2016-10-28 Thread Michael Tokarev
From: Michael Walle Drop the rX, rY and rZ stuff and use dc->r{0,1,2} directly. This should also fix the false positive in coverity CID 1005720. Signed-off-by: Michael Walle Reviewed-by: Peter Maydell Signed-off-by: Michael Tokarev --- target-lm32/translate.c | 7 ++- 1 file changed, 2 i

Re: [Qemu-devel] [PATCH 0/3] iotests: Skip 162 if there is no SSH support

2016-10-28 Thread Max Reitz
On 12.10.2016 22:49, Max Reitz wrote: > As reported by Hao QingFeng, iotest 162 is currently executed even if > qemu does not have any SSH support (which makes it fail, naturally). > > Fixing that is not so trivial, because qemu-img currently does not > report modules, and SSH can be compiled as a

[Qemu-devel] [PULL 07/23] lm32: milkymist-tmu2: fix integer overflow

2016-10-28 Thread Michael Tokarev
From: Michael Walle Don't truncate the multiplication and do a 64 bit one instead because because the result is stored in a 64 bit variable. Spotted by coverity, CID 1167561. Signed-off-by: Michael Walle Reviewed-by: Peter Maydell Signed-off-by: Michael Tokarev --- hw/display/milkymist-tmu2

[Qemu-devel] [PULL 13/23] usb: Change *_exitfn return type from int to void

2016-10-28 Thread Michael Tokarev
From: Akanksha Srivastava The *_exitfn functions cannot fail and should not be returning int. This also removes the passthru_exitfn since this callback does nothing as of now. This was suggested as a Bite-sized task for code cleanup. Signed-off-by: Akanksha Srivastava Reviewed-by: Stefan Hajnocz

[Qemu-devel] [PULL 00/23] Trivial patches for 2016-10-28

2016-10-28 Thread Michael Tokarev
Here's a next pull request for the trivial patches tree. Nothing exciting is in there this time, small things here and there. Thanks, /mjt The following changes since commit fd209e4a773dd5a7fea79eaaffd276ebcb99e92a: Merge remote-tracking branch 'remotes/jnsnow/tags/ide-pull-request' into sta

Re: [Qemu-devel] [PULL v1 00/11] Merge qio 2016/10/27

2016-10-28 Thread Peter Maydell
On 27 October 2016 at 22:46, Peter Maydell wrote: > On 27 October 2016 at 22:40, Daniel P. Berrange wrote: >> On Thu, Oct 27, 2016 at 04:33:27PM +0100, Peter Maydell wrote: >>> On 27 October 2016 at 16:10, Peter Maydell wrote: >>> > On 27 October 2016 at 13:57, Daniel P. Berrange >>> > wrote:

Re: [Qemu-devel] [PATCH] raw-posix: Rename 'raw_s' to 'rs'

2016-10-28 Thread Max Reitz
On 27.10.2016 12:45, Fam Zheng wrote: > It is too confusing because it sounds like a BDRVRawState variable. > > Suggested-by: Max Reitz > Signed-off-by: Fam Zheng > --- > block/raw-posix.c | 56 > +++ > 1 file changed, 28 insertions(+), 28 de

[Qemu-devel] [PULL 11/23] colo-compare: remove unused struct CompareChardevProps and 'props' variable

2016-10-28 Thread Michael Tokarev
From: zhanghailiang After commit 0a73336d, 'props' variable in find_and_check_chardev() is unused. Remove it, togther with struct CompareChardevProps. Signed-off-by: zhanghailiang Reviewed-by: Zhang Chen Signed-off-by: Michael Tokarev --- net/colo-compare.c | 8 1 file changed, 8 de

[Qemu-devel] [PULL 05/23] target-lm32: swap operand of wcsr in LOG_DIS()

2016-10-28 Thread Michael Tokarev
From: Michael Walle Be consistent with the reference manual. Signed-off-by: Michael Walle Reviewed-by: Peter Maydell Signed-off-by: Michael Tokarev --- target-lm32/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-lm32/translate.c b/target-lm32/translate.

[Qemu-devel] [PULL 01/23] filter-dump: add missing "["

2016-10-28 Thread Michael Tokarev
From: Changlong Xie Signed-off-by: Changlong Xie Signed-off-by: Michael Tokarev --- qemu-options.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-options.hx b/qemu-options.hx index b1fbdb0..c209b53 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -3902,7 +3902,7

[Qemu-devel] [PULL 19/23] qemu-ga: Remove stray 'q' in documentation

2016-10-28 Thread Michael Tokarev
From: Stefan Weil Signed-off-by: Stefan Weil Reviewed-by: Michael Roth Signed-off-by: Michael Tokarev --- qemu-ga.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-ga.texi b/qemu-ga.texi index 0e53bf6..4c7a8fd 100644 --- a/qemu-ga.texi +++ b/qemu-ga.texi @@ -30,7 +

[Qemu-devel] [PULL 18/23] Makefile: Fix help text for target 'installer'

2016-10-28 Thread Michael Tokarev
From: Stefan Weil The NSIS based installer currently does not install qemu-ga. It installs the executables and other files for the QEMU system emulation. Signed-off-by: Stefan Weil Reviewed-by: Michael Roth Signed-off-by: Michael Tokarev --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1

Re: [Qemu-devel] [libvirt-users] pci-assign fails with read error on config-space file

2016-10-28 Thread Laine Stump
On 10/28/2016 07:28 AM, Henning Schild wrote: Hey, i am running an unusual setup where i assign pci devices behind the back of libvirt. I have two options to do that: 1. a wrapper script for qemu that takes care of suid-root and appends arguments for pci-assign 2. virsh qemu-monitor-command ...

[Qemu-devel] [PULL 23/23] Fix build for less common build directories names

2016-10-28 Thread Michael Tokarev
From: Stefan Weil scripts/tracetool generates a C preprocessor macro from the name of the build directory. Any characters which are possible in a directory name but not allowed in a macro name must be substituted, otherwise builds will fail. Signed-off-by: Stefan Weil Signed-off-by: Michael Tok

Re: [Qemu-devel] pci-assign fails with read error on config-space file

2016-10-28 Thread Laszlo Ersek
On 10/28/16 13:28, Henning Schild wrote: > Hey, > > i am running an unusual setup where i assign pci devices behind the > back of libvirt. I have two options to do that: > 1. a wrapper script for qemu that takes care of suid-root and appends > arguments for pci-assign > 2. virsh qemu-monitor-comma

[Qemu-devel] [PULL 03/23] target-lm32: fix style issue

2016-10-28 Thread Michael Tokarev
From: Michael Walle Both branches of the ternary operator have the same expressions. Drop the operator. This fixes: https://bugs.launchpad.net/qemu/+bug/1414293 Signed-off-by: Michael Walle Reviewed-by: Thomas Huth Reviewed-by: Peter Maydell Signed-off-by: Michael Tokarev --- target-lm32/t

[Qemu-devel] [PULL 20/23] monitor: deprecate 'default' option

2016-10-28 Thread Michael Tokarev
From: Marc-André Lureau This option does nothing since commit 06ac27f. Deprecate it. Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster Signed-off-by: Michael Tokarev --- include/monitor/monitor.h | 2 +- monitor.c | 2 +- qemu-options.hx | 8 --

[Qemu-devel] [PULL 04/23] target-lm32: fix LOG_DIS operand order

2016-10-28 Thread Michael Tokarev
From: Michael Walle The order of most opcodes with immediates was wrong (according to the reference manual) in the (debug) logging. Additionally, one operand for the andhi instruction was completly wrong. Fix these. Signed-off-by: Michael Walle Reviewed-by: Peter Maydell Signed-off-by: Michael

[Qemu-devel] [PULL 16/23] migration: Remove unneeded NULL check from migrate_fd_error()

2016-10-28 Thread Michael Tokarev
From: Peter Maydell All the callers of migrate_fd_error() pass a non-NULL error parameter, and if any did pass NULL then we would segfault in error_copy(), so remove the unnecessary NULL check earlier in the function. (Spotted by Coverity.) Signed-off-by: Peter Maydell Signed-off-by: Michael To

[Qemu-devel] [PULL 10/23] milkymist-pfpu: fix potential integer overflow

2016-10-28 Thread Michael Tokarev
From: Michael Walle Since the lm32 is a 32 bit architecture, just return a 32 bit value which is then converted to a 64 bit value. Spotted by coverity, CID 1005506. Signed-off-by: Michael Walle Signed-off-by: Michael Tokarev --- hw/misc/milkymist-pfpu.c | 2 +- 1 file changed, 1 insertion(+)

[Qemu-devel] [PULL 14/23] qemu-options.hx: set: fix copy-paste error

2016-10-28 Thread Michael Tokarev
Reported-By: Daniel Shahaf Signed-off-by: Michael Tokarev --- qemu-options.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-options.hx b/qemu-options.hx index c209b53..f296406 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -172,7 +172,7 @@ DEF("set", HAS_ARG, QE

Re: [Qemu-devel] [PATCH v4] char: cadence: check baud rate generator and divider values

2016-10-28 Thread Alistair Francis
On Thu, Oct 27, 2016 at 12:24 PM, P J P wrote: > From: Prasad J Pandit > > The Cadence UART device emulator calculates speed by dividing the > baud rate by a 'baud rate generator' & 'baud rate divider' value. > The device specification defines these register values to be > non-zero and within cer

[Qemu-devel] [PULL 09/23] hw/block/nvme: Simplify if-statements a little bit

2016-10-28 Thread Michael Tokarev
From: Thomas Huth The condition '!A || (A && B)' is equivalent to '!A || B'. Buglink: https://bugs.launchpad.net/qemu/+bug/1464611 Signed-off-by: Thomas Huth Reviewed-by: Peter Maydell Reviewed-by: Stefan Hajnoczi Signed-off-by: Michael Tokarev --- hw/block/nvme.c | 4 ++-- 1 file changed,

[Qemu-devel] [PULL 15/23] scripts/hxtool: fix undefined behavour of echo

2016-10-28 Thread Michael Tokarev
From: Daniel Shahaf Avoid undefined behaviour of echo(1) with backslashes in arguments The behaviour is implementation-defined, different /bin/sh's behave differently. Signed-off-by: Daniel Shahaf Signed-off-by: Michael Tokarev --- scripts/hxtool | 20 ++-- 1 file changed, 10

[Qemu-devel] [PULL 12/23] MAINTAINERS: qemu-trivial information

2016-10-28 Thread Michael Tokarev
From: Laurent Vivier Information about "qemu-trivial" ML can be found in the wiki: http://wiki.qemu.org/Contribute/TrivialPatches But the first place where a developer looks is the file MAINTAINERS. This also allows the get_maintainer.pl script to display the qemu-trivial ML address when t

Re: [Qemu-devel] [PULL 00/73] ppc-for-2.8 queue 20161028

2016-10-28 Thread Peter Maydell
ble in the git repository at: > > git://github.com/dgibson/qemu.git tags/ppc-for-2.8-20161028 > > for you to fetch changes up to 10c21b5c20bf3d20b7b0ad279db37ae89cc7937d: > > ppc: allow certain HV interrupts to be del

[Qemu-devel] [PATCH 0/8] nvdimm acpi: bug fix and cleanup

2016-10-28 Thread Xiao Guangrong
Thanks to Igor's suggestion, this patchset fixes some bugs in NVDIMM ACPI, also it refines the nvdimm code slightly Xiao Guangrong (8): acpi nvdimm: fix wrong buffer size returned by DSM method acpi nvdimm: fix device physical address base acpi nvdimm: fix OperationRegion definition acpi

[Qemu-devel] [PULL 21/23] scripts/clean-includes: added duplicate #include check

2016-10-28 Thread Michael Tokarev
From: Anand J Enhance the clean-includes script to optionally check for duplicate #include entries. Script might output false positive entries as well. Such entries should not be removed. So if it finds any duplicate entries script will terminate with an exit status 1. Then each and every file s

[Qemu-devel] [PATCH 1/8] acpi nvdimm: fix wrong buffer size returned by DSM method

2016-10-28 Thread Xiao Guangrong
Currently, 'RLEN' is the totally buffer size written by QEMU and it is ACPI internally used only. The buffer size returned to guest should not include 'RLEN' itself Signed-off-by: Xiao Guangrong --- hw/acpi/nvdimm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/acpi/nv

[Qemu-devel] [PATCH 5/8] acpi nvdimm: fix Arg6 usage

2016-10-28 Thread Xiao Guangrong
As the function only has 5 args, we use local7 instead of it Suggested-by: Igor Mammedov Signed-off-by: Xiao Guangrong --- hw/acpi/nvdimm.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c index 0b8c275..cc958a4 100644 --- a/hw/acpi/

[Qemu-devel] [PATCH 3/8] acpi nvdimm: fix OperationRegion definition

2016-10-28 Thread Xiao Guangrong
Based on ACPI spec: RegionOffset := TermArg => Integer However, Named object is not a TermArg. This patch moves OperationRegion to NCAL() and uses localX as its RegionOffset Suggested-by: Igor Mammedov Signed-off-by: Xiao Guangrong --- hw/acpi/nvdimm.c | 122 -

<    1   2   3   >