On 28 October 2016 at 15:57, Michael Tokarev <m...@tls.msk.ru> wrote: > 17.10.2016 07:43, Stefan Weil wrote: >> Am 16.10.2016 um 21:04 schrieb Peter Maydell: >>> On 16 October 2016 at 15:31, Michael Tokarev <m...@tls.msk.ru> wrote: >>>> 13.10.2016 21:29, Stefan Weil wrote: >>>>> scripts/tracetool generates a C preprocessor macro from the name of the >>>>> build directory. Any characters which are possible in a directory name >>>>> but not allowed in a macro name must be substituted, otherwise builds >>>>> will fail. >>>> >>>> Applied to -trivial, thank you! >>> >>> Consensus on this and the other thread seemed to be >>> that we should just fix the bug where tracetool is >>> putting the build directory name into symbols >>> rather than working around that... >>> >>> thanks >>> -- PMM >> >> IMHO the patch can be applied nevertheless, as it uses a clearer >> regular expression for characters allowed in macro names >> (not one that is specific for the current QEMU code). > > So, what's the thing here?
I think we concluded that the underlying problem was a bit tricky to fix and we should apply this workaround in the meantime. thanks -- PMM
